[GitHub] [shardingsphere-elasticjob-lite] terrymanu merged pull request #916: Remove JobType

2020-07-03 Thread GitBox


terrymanu merged pull request #916:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/916


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu merged pull request #915: fix member variable access modifiers.

2020-07-03 Thread GitBox


terrymanu merged pull request #915:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/915


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] xiongqisong opened a new issue #6255: Why sharding-jdbc-core-spring-boot-starter use too old version of sharding-jdbc-core?

2020-07-03 Thread GitBox


xiongqisong opened a new issue #6255:
URL: https://github.com/apache/shardingsphere/issues/6255


   Just curious,why "sharding-jdbc-core-spring-boot-starter" 2.0.3 depends on 
sharding-jdbc-core 2.0.3, but sharding-jdbc-core newest version is 4.1.1?
   The sample in 
"https://shardingsphere.apache.org/document/current/cn/user-manual/shardingsphere-jdbc/usage/sharding/java-api/";
 isn't suitable for developer who use sharding-jdbc-core-spring-boot-starter, 
because the package name, some classes are different, for example, 
ShardingTableRuleConfiguration has been changed to TableRuleConfiguration in 
sharding-jdbc-core 4.1.1



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] xbkaishui commented on a change in pull request #6247: Optimize startup time, ignore load unConfigured table's column and in…

2020-07-03 Thread GitBox


xbkaishui commented on a change in pull request #6247:
URL: https://github.com/apache/shardingsphere/pull/6247#discussion_r449437523



##
File path: 
shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/schema/SchemaMetaDataLoader.java
##
@@ -49,35 +41,33 @@
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
 @Slf4j(topic = "ShardingSphere-metadata")
 public final class SchemaMetaDataLoader {
-
+

Review comment:
   done





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu opened a new pull request #917: Refactor TypedJob

2020-07-03 Thread GitBox


terrymanu opened a new pull request #917:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/917


   For #792.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu commented on pull request #917: Refactor TypedJob

2020-07-03 Thread GitBox


terrymanu commented on pull request #917:
URL: 
https://github.com/apache/shardingsphere-elasticjob-lite/pull/917#issuecomment-653414909


   Closed because invalid commit version



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu closed pull request #917: Refactor TypedJob

2020-07-03 Thread GitBox


terrymanu closed pull request #917:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/917


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] Roronoa-Zoro opened a new issue #6256: query all tables where sql contains a sharding column and non sharding column

2020-07-03 Thread GitBox


Roronoa-Zoro opened a new issue #6256:
URL: https://github.com/apache/shardingsphere/issues/6256


   ## Bug Report
   
   **For English only**, other languages will not accept.
   
   Before report a bug, make sure you have:
   
   - Searched open and closed [GitHub 
issues](https://github.com/apache/shardingsphere/issues).
   - Read documentation: [ShardingSphere 
Doc](https://shardingsphere.apache.org/document/current/en/overview).
   
   Please pay attention on issues you submitted, because we maybe need more 
details. 
   If no response anymore and we cannot reproduce it on current information, we 
will **close it**.
   
   Please answer these questions before submitting your issue. Thanks!
   
   ### Which version of ShardingSphere did you use?
   4.0.1
   ### Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy?
   ShardingSphere-JDBC
   ### Expected behavior
   will only query one table
   ### Actual behavior
   query all tables
   ### Reason analyze (If you can)
   
   ### Steps to reproduce the behavior, such as: SQL to execute, sharding rule 
configuration, when exception occur etc.
   I have a sql : select * from t_xx_url where xx_url=? and expire_time>?, and 
xx_url is sharding column, I use standard sharding algorithm, the class logic 
is Math.abs(xx_url.hashCode()) % 16.
   ### Example codes for reproduce this issue (such as a github link).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #6187: Add port to proxy instance

2020-07-03 Thread GitBox


menghaoranss commented on a change in pull request #6187:
URL: https://github.com/apache/shardingsphere/pull/6187#discussion_r449443134



##
File path: 
shardingsphere-control-panel/shardingsphere-orchestration/shardingsphere-orchestration-core/shardingsphere-orchestration-core-facade/src/main/java/org/apache/shardingsphere/orchestration/core/facade/ShardingOrchestrationFacade.java
##
@@ -81,7 +81,7 @@
 
 private final ShardingOrchestrationListenerManager listenerManager;
 
-public ShardingOrchestrationFacade(final OrchestrationConfiguration 
orchestrationConfig, final Collection shardingSchemaNames) {
+public ShardingOrchestrationFacade(final OrchestrationConfiguration 
orchestrationConfig, final Collection shardingSchemaNames, final int 
identifier) {

Review comment:
   > keeping this as `instanceId` also does not seem to be justified since 
this is only a part of the actual `instanceId`.
   > Should we keep this as `instanceSubId`?
   
   How about `instanceSign` or `instanceTag`, my understanding, this parameter 
is just a sign or tag of `instanceId`.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] readazusa commented on issue #914: Can you remove the quartz dependency and implement your own time scheduling framework

2020-07-03 Thread GitBox


readazusa commented on issue #914:
URL: 
https://github.com/apache/shardingsphere-elasticjob-lite/issues/914#issuecomment-653417178


   To reduce the dependence of the framework and improve the controllability of 
scheduling, I hope elastic job can create its own scheduling implementation, 
   just like SS removed ‘durid’ SQL statement parsing and used its own set of 
SQL parsing. This is just an idea of my own, thank you.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] kimmking closed issue #6231: The closing delete/modify dataSource process in OrchestrationShardingDataSource#renew(DataSourceChangedEvent)

2020-07-03 Thread GitBox


kimmking closed issue #6231:
URL: https://github.com/apache/shardingsphere/issues/6231


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] readazusa removed a comment on issue #914: Can you remove the quartz dependency and implement your own time scheduling framework

2020-07-03 Thread GitBox


readazusa removed a comment on issue #914:
URL: 
https://github.com/apache/shardingsphere-elasticjob-lite/issues/914#issuecomment-653417178


   To reduce the dependence of the framework and improve the controllability of 
scheduling, I hope elastic job can create its own scheduling implementation, 
   just like SS removed ‘durid’ SQL statement parsing and used its own set of 
SQL parsing. This is just an idea of my own, thank you.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] kimmking commented on issue #6251: sharding 4.1.1 spring boot hikari oracle start

2020-07-03 Thread GitBox


kimmking commented on issue #6251:
URL: https://github.com/apache/shardingsphere/issues/6251#issuecomment-653418296


   It seems your actual sql is wrong, so we want to know 
   > what's your logic sql and actual sql?
   
   and then profile for details.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] readazusa commented on issue #914: Can you remove the quartz dependency and implement your own time scheduling framework

2020-07-03 Thread GitBox


readazusa commented on issue #914:
URL: 
https://github.com/apache/shardingsphere-elasticjob-lite/issues/914#issuecomment-653418510


   To reduce the dependence of the framework and improve the controllability of 
scheduling, I hope elastic job can create its own scheduling implementation, 
   just like SS removed ‘durid’ SQL statement parsing and used its own set of 
SQL parsing. This is just an idea of my own, thank you.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #6187: Add port to proxy instance

2020-07-03 Thread GitBox


menghaoranss commented on a change in pull request #6187:
URL: https://github.com/apache/shardingsphere/pull/6187#discussion_r449445890



##
File path: 
shardingsphere-control-panel/shardingsphere-orchestration/shardingsphere-orchestration-core/shardingsphere-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/instance/OrchestrationInstance.java
##
@@ -29,21 +28,30 @@
 public final class OrchestrationInstance {
 
 private static final String DELIMITER = "@";
-
-private static final OrchestrationInstance INSTANCE = new 
OrchestrationInstance();
+
+private static OrchestrationInstance instance;
 
 private final String instanceId;
-
-private OrchestrationInstance() {
-instanceId = IpUtils.getIp() + DELIMITER + 
ManagementFactory.getRuntimeMXBean().getName().split(DELIMITER)[0] + DELIMITER 
+ UUID.randomUUID().toString();
+
+public OrchestrationInstance(final int identifier) {
+instanceId = IpUtils.getIp() + DELIMITER + identifier + DELIMITER + 
UUID.randomUUID().toString();

Review comment:
   > what we really want is a singleton instance with the property 
accessible everywhere.
   > probably we should keep the constructor as it is and provide a 
`getInstance()` method throwing `IllegalStateException` if instance object is 
not created
   > 
   > I do not think making an assignment like `instance = this` is a good idea.
   > @menghaoranss thoughts?
   
   Agree with you, may be we can keep the no arguments constructor , and then 
add a new method to generate `instanceId`. Generate `instanceId` when 
`OrchestrationInstance` is initialized in `RegistryCenter`. 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] yanyzy merged pull request #6241: Move persistMetaData() to OrchestrationSchemaContexts

2020-07-03 Thread GitBox


yanyzy merged pull request #6241:
URL: https://github.com/apache/shardingsphere/pull/6241


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-ui] EasonFeng5870 opened a new pull request #3: Add metadata info shown in ShardingSphere-UI

2020-07-03 Thread GitBox


EasonFeng5870 opened a new pull request #3:
URL: https://github.com/apache/shardingsphere-ui/pull/3


   Both frontend and backend are changed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu merged pull request #918: Remove useless ScriptJob interface

2020-07-03 Thread GitBox


terrymanu merged pull request #918:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/918


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu opened a new pull request #918: Remove useless ScriptJob interface

2020-07-03 Thread GitBox


terrymanu opened a new pull request #918:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/918


   For #792.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] jingshanglu commented on issue #6228: table name is not rewrited correctly in subquery

2020-07-03 Thread GitBox


jingshanglu commented on issue #6228:
URL: https://github.com/apache/shardingsphere/issues/6228#issuecomment-653420167


   @kimmking @nkuflk Ok, i'll check it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] kimmking merged pull request #6254: OpenTracing spi design in sharding-proxy

2020-07-03 Thread GitBox


kimmking merged pull request #6254:
URL: https://github.com/apache/shardingsphere/pull/6254


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu opened a new pull request #919: Refactor TypedJob for not SimpleJob only

2020-07-03 Thread GitBox


terrymanu opened a new pull request #919:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/919


   For #792.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu merged pull request #919: Refactor TypedJob for not SimpleJob only

2020-07-03 Thread GitBox


terrymanu merged pull request #919:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/919


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] xiongqisong closed issue #6255: Why sharding-jdbc-core-spring-boot-starter use too old version of sharding-jdbc-core?

2020-07-03 Thread GitBox


xiongqisong closed issue #6255:
URL: https://github.com/apache/shardingsphere/issues/6255


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] xiongqisong commented on issue #6255: Why sharding-jdbc-core-spring-boot-starter use too old version of sharding-jdbc-core?

2020-07-03 Thread GitBox


xiongqisong commented on issue #6255:
URL: https://github.com/apache/shardingsphere/issues/6255#issuecomment-653422855


   forgive me,the search engine give the wrong document, actually,you should go 
to https://shardingsphere.apache.org/index_zh.html and see the document which 
version of shardingsphere you are using, PEACE



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] kimmking commented on issue #6239: Unknown system variable 'transaction_isolation'

2020-07-03 Thread GitBox


kimmking commented on issue #6239:
URL: https://github.com/apache/shardingsphere/issues/6239#issuecomment-653426821


   MySQL8,  tx_isolation -> transaction_isolation.
   And in recent version, proxy return the version with mysql 8.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] wuguowei19880907 commented on issue #6251: sharding 4.1.1 spring boot hikari oracle start

2020-07-03 Thread GitBox


wuguowei19880907 commented on issue #6251:
URL: https://github.com/apache/shardingsphere/issues/6251#issuecomment-653427085


   > It seems your actual sql is wrong, so we want to know
   > 
   > > what's your logic sql and actual sql?
   > 
   > and then profile for details.
   
   this is the whole code,
   https://github.com/wuguowei19880907/kotlin-spring-boot.git



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] xbkaishui commented on pull request #6247: Optimize startup time, ignore load unConfigured table's column and in…

2020-07-03 Thread GitBox


xbkaishui commented on pull request #6247:
URL: https://github.com/apache/shardingsphere/pull/6247#issuecomment-653430514


   Sync up the new load logic with orchestration module. for this task. I think 
there is no code to change. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] swayamraina commented on a change in pull request #6187: Add port to proxy instance

2020-07-03 Thread GitBox


swayamraina commented on a change in pull request #6187:
URL: https://github.com/apache/shardingsphere/pull/6187#discussion_r449462203



##
File path: 
shardingsphere-control-panel/shardingsphere-orchestration/shardingsphere-orchestration-core/shardingsphere-orchestration-core-facade/src/main/java/org/apache/shardingsphere/orchestration/core/facade/ShardingOrchestrationFacade.java
##
@@ -81,7 +81,7 @@
 
 private final ShardingOrchestrationListenerManager listenerManager;
 
-public ShardingOrchestrationFacade(final OrchestrationConfiguration 
orchestrationConfig, final Collection shardingSchemaNames) {
+public ShardingOrchestrationFacade(final OrchestrationConfiguration 
orchestrationConfig, final Collection shardingSchemaNames, final int 
identifier) {

Review comment:
   `instanceTag` sounds good!





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] jokercheng-coder opened a new issue #6257: MutableIntervalShardingAlgorithm

2020-07-03 Thread GitBox


jokercheng-coder opened a new issue #6257:
URL: https://github.com/apache/shardingsphere/issues/6257


   ## Question
   文档中提到的一些内置算法,在源码中没有找到,是被移除了么? 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] yu199195 commented on issue #6248: NPE occured at shardingsphere version 4.1.1

2020-07-03 Thread GitBox


yu199195 commented on issue #6248:
URL: https://github.com/apache/shardingsphere/issues/6248#issuecomment-653433499


   @lcx1989210  in weixin group ,Haven't you solved it already?   `order` is 
keyword of mysql.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero commented on issue #6248: NPE occured at shardingsphere version 4.1.1

2020-07-03 Thread GitBox


tristaZero commented on issue #6248:
URL: https://github.com/apache/shardingsphere/issues/6248#issuecomment-653433955


   @lcx1989210 Sorry for that, In order to support more SQLs and standardize 
SQL parsing, we refactored sharding parser from 4.x release.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero commented on issue #6248: NPE occured at shardingsphere version 4.1.1

2020-07-03 Thread GitBox


tristaZero commented on issue #6248:
URL: https://github.com/apache/shardingsphere/issues/6248#issuecomment-653434608


   @jingshanglu Thanks for detailed feedback. :-)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero closed issue #6248: NPE occured at shardingsphere version 4.1.1

2020-07-03 Thread GitBox


tristaZero closed issue #6248:
URL: https://github.com/apache/shardingsphere/issues/6248


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero edited a comment on issue #6248: NPE occured at shardingsphere version 4.1.1

2020-07-03 Thread GitBox


tristaZero edited a comment on issue #6248:
URL: https://github.com/apache/shardingsphere/issues/6248#issuecomment-653434608


   @jingshanglu Thanks for detailed feedback. :-) Since this issue was fixed on 
our master branch, I will close it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] yu199195 commented on issue #6226: broadcast table DML SQL route wrong if broadcast table are configured only on subset of the datasources.

2020-07-03 Thread GitBox


yu199195 commented on issue #6226:
URL: https://github.com/apache/shardingsphere/issues/6226#issuecomment-653435396


   `testGlobal` is you broadcast Table ,so will route to the all datasources, 
Any other questions?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] yu199195 commented on issue #6257: MutableIntervalShardingAlgorithm

2020-07-03 Thread GitBox


yu199195 commented on issue #6257:
URL: https://github.com/apache/shardingsphere/issues/6257#issuecomment-653436740


   please in english,  Please follow the issue rules 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] kekerzzZ opened a new pull request #920: Extract abstraction for JobExecutorServiceHandler interface

2020-07-03 Thread GitBox


kekerzzZ opened a new pull request #920:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/920


   Extract abstraction for JobExecutorServiceHandler interface.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero commented on issue #6239: Unknown system variable 'transaction_isolation'

2020-07-03 Thread GitBox


tristaZero commented on issue #6239:
URL: https://github.com/apache/shardingsphere/issues/6239#issuecomment-653442190


   @1006572352 @kimmking 
   Thanks for your feedback.
   
   It is sorted as a bug. Here is one of the recommended solutions, welcome 
everyone to try to fix it, and contribute to our community.
   
   1. Get the version of MySQL servers deployed, like 5.7 by JDBC interface
   2. Set the `SERVER_VERSION` in `MySQLServerInfo` class.
   3. Therefore the versions of ShardingProxy and MySQL from the bottom are 
consistent.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu merged pull request #921: Add init method for TypedJob

2020-07-03 Thread GitBox


terrymanu merged pull request #921:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/921


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu opened a new pull request #921: Add init method for TypedJob

2020-07-03 Thread GitBox


terrymanu opened a new pull request #921:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/921


   For #792.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] kekerzzZ commented on pull request #920: Extract abstraction for JobExecutorServiceHandler interface

2020-07-03 Thread GitBox


kekerzzZ commented on pull request #920:
URL: 
https://github.com/apache/shardingsphere-elasticjob-lite/pull/920#issuecomment-653445302


   I will open new.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] kekerzzZ closed pull request #920: Extract abstraction for JobExecutorServiceHandler interface

2020-07-03 Thread GitBox


kekerzzZ closed pull request #920:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/920


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] kekerzzZ opened a new pull request #922: Extract abstraction for JobExecutorServiceHandler interface

2020-07-03 Thread GitBox


kekerzzZ opened a new pull request #922:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/922


   Extract abstraction for JobExecutorServiceHandler interface .
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] kekerzzZ closed pull request #922: Extract abstraction for JobExecutorServiceHandler interface

2020-07-03 Thread GitBox


kekerzzZ closed pull request #922:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/922


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] jacksparrow414 commented on issue #6256: query all tables where sql contains a sharding column and non sharding column

2020-07-03 Thread GitBox


jacksparrow414 commented on issue #6256:
URL: https://github.com/apache/shardingsphere/issues/6256#issuecomment-653458848


   show you complete config,please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] kimmking closed issue #6257: MutableIntervalShardingAlgorithm

2020-07-03 Thread GitBox


kimmking closed issue #6257:
URL: https://github.com/apache/shardingsphere/issues/6257


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] bruse1990 opened a new issue #6258: QueryAssistedEncryptAlgorithm which version is this class

2020-07-03 Thread GitBox


bruse1990 opened a new issue #6258:
URL: https://github.com/apache/shardingsphere/issues/6258


   
org.apache.shardingsphere

sharding-jdbc-spring-boot-starter
4.1.1

   
   i use above config,but not found example's class  
**QueryAssistedEncryptAlgorithm**,so i want to use this class ,what should i do



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] kekerzzZ opened a new pull request #923: Extract abstraction for JobExecutorServiceHandler interface

2020-07-03 Thread GitBox


kekerzzZ opened a new pull request #923:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/923


   Extract abstraction for JobExecutorServiceHandler interface.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] jingshanglu opened a new pull request #6259: fix rewrite for subquery in from

2020-07-03 Thread GitBox


jingshanglu opened a new pull request #6259:
URL: https://github.com/apache/shardingsphere/pull/6259


   Fixes #6228 .
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu merged pull request #923: Extract abstraction for JobExecutorServiceHandler interface

2020-07-03 Thread GitBox


terrymanu merged pull request #923:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/923


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] jingshanglu commented on issue #6228: table name is not rewrited correctly in subquery

2020-07-03 Thread GitBox


jingshanglu commented on issue #6228:
URL: https://github.com/apache/shardingsphere/issues/6228#issuecomment-653465604


   @nkuflk Now the pr #6259 fix it,but plz use alias in whereClause and 
projections, Alias not applicable in subquery is not supported.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero opened a new pull request #6260: Review some functions of ConfigCenter

2020-07-03 Thread GitBox


tristaZero opened a new pull request #6260:
URL: https://github.com/apache/shardingsphere/pull/6260


   Ref #6240 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] Technoboy- opened a new issue #924: Fix JobOperationController bug

2020-07-03 Thread GitBox


Technoboy- opened a new issue #924:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/issues/924


   1.  JobOperationController#disableJob/enableJob/shutdownJob consume json, 
but ajax has request with no context-type.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] terrymanu merged pull request #6260: Review some functions of ConfigCenter

2020-07-03 Thread GitBox


terrymanu merged pull request #6260:
URL: https://github.com/apache/shardingsphere/pull/6260


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] wcsoft opened a new pull request #6261: Add doc Proxy translation in English

2020-07-03 Thread GitBox


wcsoft opened a new pull request #6261:
URL: https://github.com/apache/shardingsphere/pull/6261


   Add doc Proxy translation in English
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu opened a new pull request #925: Decouple JobBootstrap with OneOffJobBootstrap and ScheduleJobBootstrap

2020-07-03 Thread GitBox


terrymanu opened a new pull request #925:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/925


   For #792.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu merged pull request #925: Decouple JobBootstrap with OneOffJobBootstrap and ScheduleJobBootstrap

2020-07-03 Thread GitBox


terrymanu merged pull request #925:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/925


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu opened a new pull request #926: Recover test cases for one-off test

2020-07-03 Thread GitBox


terrymanu opened a new pull request #926:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/926


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] wcsoft commented on issue #6070: [Translation] Translate technical articles concerning Apache ShardingSphere

2020-07-03 Thread GitBox


wcsoft commented on issue #6070:
URL: https://github.com/apache/shardingsphere/issues/6070#issuecomment-653493905


   https://github.com/apache/shardingsphere/pull/6261



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu merged pull request #926: Recover test cases for one-off test

2020-07-03 Thread GitBox


terrymanu merged pull request #926:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/926


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] wcsoft removed a comment on issue #6070: [Translation] Translate technical articles concerning Apache ShardingSphere

2020-07-03 Thread GitBox


wcsoft removed a comment on issue #6070:
URL: https://github.com/apache/shardingsphere/issues/6070#issuecomment-653493905


   https://github.com/apache/shardingsphere/pull/6261



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] wcsoft commented on issue #6070: [Translation] Translate technical articles concerning Apache ShardingSphere

2020-07-03 Thread GitBox


wcsoft commented on issue #6070:
URL: https://github.com/apache/shardingsphere/issues/6070#issuecomment-653494382


   Add proxy translaction in English 
https://github.com/apache/shardingsphere/pull/6261
   
   pls review. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] Technoboy- opened a new pull request #927: Fix JobOperationController bug

2020-07-03 Thread GitBox


Technoboy- opened a new pull request #927:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/927


   Fixes #924.
   
   Changes proposed in this pull request:
   - JobOperationController.java
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu opened a new issue #928: Test case `org.apache.shardingsphere.elasticjob.lite.integrate.assertion.enable.oneoff.dataflow.StreamingDataflowElasticJob

2020-07-03 Thread GitBox


terrymanu opened a new issue #928:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/issues/928


   Sometimes the test is block because the 
`StreamingDataflowElasticJob.isCompleted()` is never return true which maybe by 
thread safe reason.
   
   The exception will throw sometimes, exception is:
   
   ```
   [ERROR] 2020-07-03 19:20:51,443 --Curator-TreeCache-0-- 
[org.apache.curator.framework.imps.CuratorFrameworkImpl] Ensure path threw 
exception 
   java.lang.InterruptedException: null
at 
java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedNanos(AbstractQueuedSynchronizer.java:1039)
at 
java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(AbstractQueuedSynchronizer.java:1328)
at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:277)
at 
org.apache.curator.CuratorZookeeperClient.internalBlockUntilConnectedOrTimedOut(CuratorZookeeperClient.java:325)
at org.apache.curator.RetryLoop.callWithRetry(RetryLoop.java:106)
at 
org.apache.curator.framework.imps.NamespaceImpl.fixForNamespace(NamespaceImpl.java:83)
at 
org.apache.curator.framework.imps.CuratorFrameworkImpl.fixForNamespace(CuratorFrameworkImpl.java:594)
at 
org.apache.curator.framework.imps.ExistsBuilderImpl.forPath(ExistsBuilderImpl.java:151)
at 
org.apache.curator.framework.imps.ExistsBuilderImpl.forPath(ExistsBuilderImpl.java:39)
at 
org.apache.shardingsphere.elasticjob.lite.reg.zookeeper.ZookeeperRegistryCenter.isExisted(ZookeeperRegistryCenter.java:197)
at 
org.apache.shardingsphere.elasticjob.lite.internal.storage.JobNodeStorage.isJobNodeExisted(JobNodeStorage.java:56)
at 
org.apache.shardingsphere.elasticjob.lite.internal.election.LeaderService.hasLeader(LeaderService.java:91)
at 
org.apache.shardingsphere.elasticjob.lite.internal.election.ElectionListenerManager$LeaderElectionJobListener.isActiveElection(ElectionListenerManager.java:69)
at 
org.apache.shardingsphere.elasticjob.lite.internal.election.ElectionListenerManager$LeaderElectionJobListener.dataChanged(ElectionListenerManager.java:63)
at 
org.apache.shardingsphere.elasticjob.lite.internal.listener.AbstractJobListener.childEvent(AbstractJobListener.java:42)
at 
org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:732)
at 
org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:726)
at 
org.apache.curator.framework.listen.ListenerContainer$1.run(ListenerContainer.java:93)
at 
com.google.common.util.concurrent.MoreExecutors$DirectExecutorService.execute(MoreExecutors.java:299)
at 
org.apache.curator.framework.listen.ListenerContainer.forEach(ListenerContainer.java:85)
at 
org.apache.curator.framework.recipes.cache.TreeCache.callListeners(TreeCache.java:725)
at 
org.apache.curator.framework.recipes.cache.TreeCache.access$1400(TreeCache.java:71)
at 
org.apache.curator.framework.recipes.cache.TreeCache$4.run(TreeCache.java:843)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
   [ERROR] 2020-07-03 19:20:51,448 --Curator-TreeCache-0-- 
[org.apache.curator.framework.recipes.cache.TreeCache]  
   java.lang.NullPointerException: null
at 
org.apache.shardingsphere.elasticjob.lite.internal.server.ServerNode.isLocalServerPath(ServerNode.java:61)
at 
org.apache.shardingsphere.elasticjob.lite.internal.election.ElectionListenerManager$LeaderElectionJobListener.isLocalServerEnabled(ElectionListenerManager.java:81)
at 
org.apache.shardingsphere.elasticjob.lite.internal.election.ElectionListenerManager$LeaderElectionJobListener.isActiveElection(ElectionListenerManager.java:69)
at 
org.apache.shardingsphere.elasticjob.lite.internal.election.ElectionListenerManager$LeaderElectionJobListener.dataChanged(ElectionListenerManager.java:63)
at 
org.apache.shardingsphere.elasticjob.lite.internal.listener.AbstractJobListener.childEvent(AbstractJobListener.java:42)
at 
org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:732)
at 
org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:726)
at 
org.apache.curator.framework.listen.ListenerContainer$1.run(ListenerContainer.java:93)
at 
com.google.common.util.concurrent.MoreExecutors$DirectExecutorService.execute(MoreExecutors.java:299)
at 
org.apache.curator.framework.listen.L

[GitHub] [shardingsphere-elasticjob-lite] viviel edited a comment on issue #928: Test case `org.apache.shardingsphere.elasticjob.lite.integrate.assertion.enable.oneoff.dataflow.StreamingDataflowElasti

2020-07-03 Thread GitBox


viviel edited a comment on issue #928:
URL: 
https://github.com/apache/shardingsphere-elasticjob-lite/issues/928#issuecomment-653502828


   Can I have a try?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] viviel commented on issue #928: Test case `org.apache.shardingsphere.elasticjob.lite.integrate.assertion.enable.oneoff.dataflow.StreamingDataflowElasticJobTes

2020-07-03 Thread GitBox


viviel commented on issue #928:
URL: 
https://github.com/apache/shardingsphere-elasticjob-lite/issues/928#issuecomment-653502828


   Can I have a try



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu commented on issue #928: Test case `org.apache.shardingsphere.elasticjob.lite.integrate.assertion.enable.oneoff.dataflow.StreamingDataflowElasticJob

2020-07-03 Thread GitBox


terrymanu commented on issue #928:
URL: 
https://github.com/apache/shardingsphere-elasticjob-lite/issues/928#issuecomment-653503232


   @viviel Sure, I just assign to you.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu opened a new pull request #929: Refactor api package structure

2020-07-03 Thread GitBox


terrymanu opened a new pull request #929:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/929


   For #792.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu merged pull request #929: Refactor api package structure

2020-07-03 Thread GitBox


terrymanu merged pull request #929:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/929


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu merged pull request #927: Fix JobOperationController bug

2020-07-03 Thread GitBox


terrymanu merged pull request #927:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/927


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu closed issue #924: Fix JobOperationController bug

2020-07-03 Thread GitBox


terrymanu closed issue #924:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/issues/924


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #6187: Add port to proxy instance

2020-07-03 Thread GitBox


menghaoranss commented on a change in pull request #6187:
URL: https://github.com/apache/shardingsphere/pull/6187#discussion_r449540024



##
File path: 
shardingsphere-control-panel/shardingsphere-orchestration/shardingsphere-orchestration-core/shardingsphere-orchestration-core-facade/src/main/java/org/apache/shardingsphere/orchestration/core/facade/ShardingOrchestrationFacade.java
##
@@ -81,7 +81,7 @@
 
 private final ShardingOrchestrationListenerManager listenerManager;
 
-public ShardingOrchestrationFacade(final OrchestrationConfiguration 
orchestrationConfig, final Collection shardingSchemaNames) {
+public ShardingOrchestrationFacade(final OrchestrationConfiguration 
orchestrationConfig, final Collection shardingSchemaNames, final int 
identifier) {

Review comment:
   Looking forward to your submission for optimization.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-ui] yu199195 commented on pull request #3: Add metadata info shown in ShardingSphere-UI

2020-07-03 Thread GitBox


yu199195 commented on pull request #3:
URL: https://github.com/apache/shardingsphere-ui/pull/3#issuecomment-653508131


   @menghaoranss  will review



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-ui] menghaoranss commented on a change in pull request #3: Add metadata info shown in ShardingSphere-UI

2020-07-03 Thread GitBox


menghaoranss commented on a change in pull request #3:
URL: https://github.com/apache/shardingsphere-ui/pull/3#discussion_r449543999



##
File path: 
shardingsphere-ui-backend/src/main/java/org/apache/shardingsphere/ui/servcie/MetadataCenterService.java
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.ui.servcie;
+
+import 
org.apache.shardingsphere.orchestration.core.metadatacenter.MetaDataCenterNode;
+
+/**
+ * metadata center service.

Review comment:
   Comments should start with a capital letter.

##
File path: 
shardingsphere-ui-backend/src/main/java/org/apache/shardingsphere/ui/servcie/impl/MetadataCenterServiceImpl.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.ui.servcie.impl;
+
+import 
org.apache.shardingsphere.orchestration.core.metadatacenter.MetaDataCenterNode;
+import org.apache.shardingsphere.ui.common.constant.OrchestrationType;
+import org.apache.shardingsphere.ui.common.domain.CenterConfig;
+import org.apache.shardingsphere.ui.common.exception.ShardingSphereUIException;
+import org.apache.shardingsphere.ui.servcie.CenterConfigService;
+import org.apache.shardingsphere.ui.servcie.MetadataCenterService;
+import org.springframework.stereotype.Service;
+
+import javax.annotation.Resource;
+import java.util.Optional;
+
+/**
+ * Implementation of metadata center operation service.
+ */
+@Service
+public class MetadataCenterServiceImpl implements MetadataCenterService {

Review comment:
   This class should be final.

##
File path: 
shardingsphere-ui-backend/src/main/java/org/apache/shardingsphere/ui/servcie/impl/MetadataCenterServiceImpl.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.ui.servcie.impl;
+
+import 
org.apache.shardingsphere.orchestration.core.metadatacenter.MetaDataCenterNode;
+import org.apache.shardingsphere.ui.common.constant.OrchestrationType;
+import org.apache.shardingsphere.ui.common.domain.CenterConfig;
+import org.apache.shardingsphere.ui.common.exception.ShardingSphereUIException;
+import org.apache.shardingsphere.ui.servcie.CenterConfigService;
+import org.apache.shardingsphere.ui.servcie.MetadataCenterService;
+import org.springframework.stereotype.Service;
+
+import javax.annotation.Resource;
+import java.util.Optional;
+
+/**
+ * Implementation of metadata center operation service.
+ */
+@Service
+public class MetadataCenterServiceImpl implements MetadataCenterService {
+
+@Resource
+private CenterConfigService centerConfigService;
+
+@Override
+publ

[GitHub] [shardingsphere] kimmking commented on issue #6258: QueryAssistedEncryptAlgorithm which version is this class

2020-07-03 Thread GitBox


kimmking commented on issue #6258:
URL: https://github.com/apache/shardingsphere/issues/6258#issuecomment-653530585


   where is the config?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] kimmking closed issue #6228: table name is not rewrited correctly in subquery

2020-07-03 Thread GitBox


kimmking closed issue #6228:
URL: https://github.com/apache/shardingsphere/issues/6228


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] kimmking merged pull request #6259: fix rewrite for subquery in from

2020-07-03 Thread GitBox


kimmking merged pull request #6259:
URL: https://github.com/apache/shardingsphere/pull/6259


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] nmyphp opened a new pull request #930: Refactor EventTraceHistoryController

2020-07-03 Thread GitBox


nmyphp opened a new pull request #930:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/930


   Changes proposed in this pull request:
   - Refactor EventTraceHistoryController and extract interface 
EventTraceHistoryService
   - Define Request and Response dto, instead of map request
   - Simplify RDBJobEventSearch
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-ui] EasonFeng5870 commented on pull request #3: Add metadata info shown in ShardingSphere-UI

2020-07-03 Thread GitBox


EasonFeng5870 commented on pull request #3:
URL: https://github.com/apache/shardingsphere-ui/pull/3#issuecomment-653554099


   @menghaoranss  thanks for the review. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] xbkaishui commented on issue #6258: QueryAssistedEncryptAlgorithm which version is this class

2020-07-03 Thread GitBox


xbkaishui commented on issue #6258:
URL: https://github.com/apache/shardingsphere/issues/6258#issuecomment-653554258


   QueryAssistedEncryptAlgorithm is only available in version 5.x,  It's very 
strange 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] xbkaishui edited a comment on issue #6258: QueryAssistedEncryptAlgorithm which version is this class

2020-07-03 Thread GitBox


xbkaishui edited a comment on issue #6258:
URL: https://github.com/apache/shardingsphere/issues/6258#issuecomment-653554258


QueryAssistedEncryptAlgorithm is only available in version 5.x,  you should 
not use this is 4.x 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] xbkaishui commented on issue #6239: Make the version of ShardingProxy and DB cluster consistent

2020-07-03 Thread GitBox


xbkaishui commented on issue #6239:
URL: https://github.com/apache/shardingsphere/issues/6239#issuecomment-653556712


let me try,  @tuohai666  please re-assign to me 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] xbkaishui commented on issue #6239: Make the version of ShardingProxy and DB cluster consistent

2020-07-03 Thread GitBox


xbkaishui commented on issue #6239:
URL: https://github.com/apache/shardingsphere/issues/6239#issuecomment-653557896


   I have a question, why we set the CHARSET to utf8_general_ci in  
MySQLServerInfo ?  can we change it to  utf8mb4_unicode_ci to support like 
emoji ? 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] xbkaishui commented on issue #4913: The diagram in English document contains Chinese characters.

2020-07-03 Thread GitBox


xbkaishui commented on issue #4913:
URL: https://github.com/apache/shardingsphere/issues/4913#issuecomment-653565952


   let me try 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] xbkaishui commented on issue #6113: Create the introduction document of Sharding-example module

2020-07-03 Thread GitBox


xbkaishui commented on issue #6113:
URL: https://github.com/apache/shardingsphere/issues/6113#issuecomment-653572082


   let me try.  a coupe of questions?  
   - what's is the best way to run the example module?  for now I just import 
only the example module as a new project  :blush: 
   - the example module contains so much functions. I can't cover them all 
:cry: 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tuohai666 commented on issue #6239: Make the version of ShardingProxy and DB cluster consistent

2020-07-03 Thread GitBox


tuohai666 commented on issue #6239:
URL: https://github.com/apache/shardingsphere/issues/6239#issuecomment-653578400


   ok



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] xbkaishui opened a new pull request #6262: fix #4913 change image chinese to eng

2020-07-03 Thread GitBox


xbkaishui opened a new pull request #6262:
URL: https://github.com/apache/shardingsphere/pull/6262


   Fixes #4913.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] strongduanmu opened a new pull request #6263: parse top expr for SQLServer query

2020-07-03 Thread GitBox


strongduanmu opened a new pull request #6263:
URL: https://github.com/apache/shardingsphere/pull/6263


   Fixes #4867 .
   
   Changes proposed in this pull request:
   - modify the `TOP` rule in DMLStatement.g4 of SQLServer
   - add function `visitTop()` to parse the `TOP` rule
   - add parse test cases to check `TOP` rule
   - modify the relative test cases in `select-pagination.xml` and 
`select-pagination-group-by-order-by.xml`
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] swayamraina commented on a change in pull request #6187: Add port to proxy instance

2020-07-03 Thread GitBox


swayamraina commented on a change in pull request #6187:
URL: https://github.com/apache/shardingsphere/pull/6187#discussion_r449677660



##
File path: 
shardingsphere-control-panel/shardingsphere-orchestration/shardingsphere-orchestration-core/shardingsphere-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/instance/OrchestrationInstance.java
##
@@ -29,21 +28,30 @@
 public final class OrchestrationInstance {
 
 private static final String DELIMITER = "@";
-
-private static final OrchestrationInstance INSTANCE = new 
OrchestrationInstance();
+
+private static OrchestrationInstance instance;
 
 private final String instanceId;
-
-private OrchestrationInstance() {
-instanceId = IpUtils.getIp() + DELIMITER + 
ManagementFactory.getRuntimeMXBean().getName().split(DELIMITER)[0] + DELIMITER 
+ UUID.randomUUID().toString();
+
+public OrchestrationInstance(final int identifier) {
+instanceId = IpUtils.getIp() + DELIMITER + identifier + DELIMITER + 
UUID.randomUUID().toString();

Review comment:
   @menghaoranss 
   i am thinking of keeping the impl like this,
   ```
   public static OrchestrationInstance init(final String instanceTag) {
   if (null == instance) {
   synchronized (OrchestrationInstance.class) {
   if (null == instance) {
   instance = new OrchestrationInstance(instanceTag);
   }
   }
   }
   return instance;
   }
   
   public static String getInstanceId() {
   if (null == instance) {
   throw new IllegalStateException("OrchestrationInstance not 
initialized!");
   }
   return instance.instanceId;
   }
   ```
   but because of this code `InstanceStateChangedListenerTest.setUp()` throws 
the `IllegalStateException`.
   Will need to refactor the test-case as well.
   
   Should this be ok?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] nkuflk commented on issue #6228: table name is not rewrited correctly in subquery

2020-07-03 Thread GitBox


nkuflk commented on issue #6228:
URL: https://github.com/apache/shardingsphere/issues/6228#issuecomment-653702440


   > @nkuflk Now the pr #6259 fix it,but plz use alias in whereClause and 
projections, Alias not applicable in subquery is not supported.
   
   Thanks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero merged pull request #6262: fix #4913 change image chinese to eng

2020-07-03 Thread GitBox


tristaZero merged pull request #6262:
URL: https://github.com/apache/shardingsphere/pull/6262


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero closed issue #4913: The diagram in English document contains Chinese characters.

2020-07-03 Thread GitBox


tristaZero closed issue #4913:
URL: https://github.com/apache/shardingsphere/issues/4913


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero commented on pull request #6262: fix #4913 change image chinese to eng

2020-07-03 Thread GitBox


tristaZero commented on pull request #6262:
URL: https://github.com/apache/shardingsphere/pull/6262#issuecomment-653705323


   @xbkaishui We are glad to see your joining. :-)
   Since the images could not show well on the GitHub page, I merged it.
   Do you think it is better to rename `merge result` as `merged result`? For 
`merge` is a verb, right?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] tristaZero edited a comment on pull request #6262: fix #4913 change image chinese to eng

2020-07-03 Thread GitBox


tristaZero edited a comment on pull request #6262:
URL: https://github.com/apache/shardingsphere/pull/6262#issuecomment-653705323


   @xbkaishui We are glad to see your joining. :-)
   Since the images could not show well on the GitHub page, I merged it.
   Do you think it is better to rename `merge result` as `merged result`? For 
`merge` is a verb, right?
   If so, maybe a new PR is welcomed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere-elasticjob-lite] terrymanu merged pull request #930: Refactor EventTraceHistoryController

2020-07-03 Thread GitBox


terrymanu merged pull request #930:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/930


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] bruse1990 commented on issue #6258: QueryAssistedEncryptAlgorithm which version is this class

2020-07-03 Thread GitBox


bruse1990 commented on issue #6258:
URL: https://github.com/apache/shardingsphere/issues/6258#issuecomment-653717665


   `
org.apache.shardingsphere

sharding-jdbc-spring-boot-starter
4.1.1
`
   
   `org.mybatis.spring.MyBatisSystemException: nested exception is 
org.apache.ibatis.exceptions.PersistenceException: 
   ### Error updating database.  Cause: java.security.NoSuchAlgorithmException: 
Cannot find any provider supporting CUSTOM_AES
   ### The error may exist in file 
[D:\workspace\javaweb\cctestplatform\target\classes\mapper\UserMapper.xml]
   ### The error may involve defaultParameterMap
   ### The error occurred while setting parameters
   ### SQL: INSERT INTO user (username,password,name) VALUES (?, ?, ?)
   ### Cause: java.security.NoSuchAlgorithmException: Cannot find any provider 
supporting CUSTOM_AES
   
at 
org.mybatis.spring.MyBatisExceptionTranslator.translateExceptionIfPossible(MyBatisExceptionTranslator.java:92)
at 
org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:440)
at com.sun.proxy.$Proxy71.insert(Unknown Source)
at 
org.mybatis.spring.SqlSessionTemplate.insert(SqlSessionTemplate.java:271)
at org.apache.ibatis.binding.MapperMethod.execute(MapperMethod.java:62)
at org.apache.ibatis.binding.MapperProxy.invoke(MapperProxy.java:93)
at com.sun.proxy.$Proxy72.addUser(Unknown Source)
at 
com.caomingyu.cctestplatform.CctestplatformApplicationTests.add(CctestplatformApplicationTests.java:21)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:686)
at 
org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
at 
org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
at 
org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140)
at 
org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$6(TestMethodTestDescriptor.java:212)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:208)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:137)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:71)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:135)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
at 
org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
at 
org.junit.platform.engine.

[GitHub] [shardingsphere] bruse1990 removed a comment on issue #6258: QueryAssistedEncryptAlgorithm which version is this class

2020-07-03 Thread GitBox


bruse1990 removed a comment on issue #6258:
URL: https://github.com/apache/shardingsphere/issues/6258#issuecomment-653717665


   `
org.apache.shardingsphere

sharding-jdbc-spring-boot-starter
4.1.1
`
   
   `org.mybatis.spring.MyBatisSystemException: nested exception is 
org.apache.ibatis.exceptions.PersistenceException: 
   ### Error updating database.  Cause: java.security.NoSuchAlgorithmException: 
Cannot find any provider supporting CUSTOM_AES
   ### The error may exist in file 
[D:\workspace\javaweb\cctestplatform\target\classes\mapper\UserMapper.xml]
   ### The error may involve defaultParameterMap
   ### The error occurred while setting parameters
   ### SQL: INSERT INTO user (username,password,name) VALUES (?, ?, ?)
   ### Cause: java.security.NoSuchAlgorithmException: Cannot find any provider 
supporting CUSTOM_AES
   
at 
org.mybatis.spring.MyBatisExceptionTranslator.translateExceptionIfPossible(MyBatisExceptionTranslator.java:92)
at 
org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:440)
at com.sun.proxy.$Proxy71.insert(Unknown Source)
at 
org.mybatis.spring.SqlSessionTemplate.insert(SqlSessionTemplate.java:271)
at org.apache.ibatis.binding.MapperMethod.execute(MapperMethod.java:62)
at org.apache.ibatis.binding.MapperProxy.invoke(MapperProxy.java:93)
at com.sun.proxy.$Proxy72.addUser(Unknown Source)
at 
com.caomingyu.cctestplatform.CctestplatformApplicationTests.add(CctestplatformApplicationTests.java:21)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:686)
at 
org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
at 
org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
at 
org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140)
at 
org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$6(TestMethodTestDescriptor.java:212)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:208)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:137)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:71)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:135)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
at 
org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
at 
org.junit.platform

[GitHub] [shardingsphere] bruse1990 commented on issue #6258: QueryAssistedEncryptAlgorithm which version is this class

2020-07-03 Thread GitBox


bruse1990 commented on issue #6258:
URL: https://github.com/apache/shardingsphere/issues/6258#issuecomment-653717906


   org.mybatis.spring.MyBatisSystemException: nested exception is 
org.apache.ibatis.exceptions.PersistenceException: 
   ### Error updating database.  Cause: java.security.NoSuchAlgorithmException: 
Cannot find any provider supporting CUSTOM_AES
   ### The error may exist in file 
[D:\workspace\javaweb\cctestplatform\target\classes\mapper\UserMapper.xml]
   ### The error may involve defaultParameterMap
   ### The error occurred while setting parameters
   ### SQL: INSERT INTO user (username,password,name) VALUES (?, ?, ?)
   ### Cause: java.security.NoSuchAlgorithmException: Cannot find any provider 
supporting CUSTOM_AES
   
at 
org.mybatis.spring.MyBatisExceptionTranslator.translateExceptionIfPossible(MyBatisExceptionTranslator.java:92)
at 
org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:440)
at com.sun.proxy.$Proxy71.insert(Unknown Source)
at 
org.mybatis.spring.SqlSessionTemplate.insert(SqlSessionTemplate.java:271)
at org.apache.ibatis.binding.MapperMethod.execute(MapperMethod.java:62)
at org.apache.ibatis.binding.MapperProxy.invoke(MapperProxy.java:93)
at com.sun.proxy.$Proxy72.addUser(Unknown Source)
at 
com.caomingyu.cctestplatform.CctestplatformApplicationTests.add(CctestplatformApplicationTests.java:21)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:686)
at 
org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
at 
org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
at 
org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140)
at 
org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$6(TestMethodTestDescriptor.java:212)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:208)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:137)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:71)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:135)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
at 
org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
at java.util.ArrayList.forEach(ArrayList.java:1249)
at 
org.junit.platform.engine.suppo

[GitHub] [shardingsphere] bruse1990 commented on issue #6258: QueryAssistedEncryptAlgorithm which version is this class

2020-07-03 Thread GitBox


bruse1990 commented on issue #6258:
URL: https://github.com/apache/shardingsphere/issues/6258#issuecomment-653717879


   4.1.1 throw exception
   Where is the lack of configuration?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




  1   2   3   4   5   6   7   8   9   10   >