[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #3822: SQLParseEngine parse mysql update sql fail

2019-12-31 Thread GitBox 
SteNicholas commented on issue #3822: SQLParseEngine parse mysql update sql fail
URL: 
https://github.com/apache/incubator-shardingsphere/issues/3822#issuecomment-569899437
 
 
   > > @caszhou You should modify the SQL like
   > > ```
   > > System.out.println(engine.parse("UPDATE tenant_vehicle SET 
tenant_id=?,\nvin=?,\nsource=?,\ncreate_time=?,\nupdate_time=?,\nversion=? 
WHERE id=? AND version=?", true));
   > > ```
   > > 
   > > 
   > > or
   > > ```
   > > System.out.println(engine.parse("UPDATE tenant_vehicle SET 
tenant_id=?,'\n'vin=?,'\n'source=?,'\n''\n''\n'create_time=?,'\n'update_time=?,'\n'version=?
 WHERE id=? AND version=?", true));
   > > ```
   > 
   > The really reason for this error is the field `source`.
   
   `SOURCE` is unreserved word. This is the bug, but `\n\n\n` doesn't support.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #3822: SQLParseEngine parse mysql update sql fail

2019-12-28 Thread GitBox 
SteNicholas commented on issue #3822: SQLParseEngine parse mysql update sql fail
URL: 
https://github.com/apache/incubator-shardingsphere/issues/3822#issuecomment-569452195
 
 
   @caszhou You should modify the SQL like
   ```
   System.out.println(engine.parse("UPDATE tenant_vehicle SET 
tenant_id=?,\nvin=?,\nsource=?,\ncreate_time=?,\nupdate_time=?,\nversion=? 
WHERE id=? AND version=?", true));
   ```
   or
   ```
   System.out.println(engine.parse("UPDATE tenant_vehicle SET 
tenant_id=?,'\n'vin=?,'\n'source=?,'\n''\n''\n'create_time=?,'\n'update_time=?,'\n'version=?
 WHERE id=? AND version=?", true));
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #3822: SQLParseEngine parse mysql update sql fail

2019-12-27 Thread GitBox 
SteNicholas commented on issue #3822: SQLParseEngine parse mysql update sql fail
URL: 
https://github.com/apache/incubator-shardingsphere/issues/3822#issuecomment-569250813
 
 
   @caszhou Yeah, the bug is that MySQLParser parses exception for update 
statement including more than 1 `\n`. @terrymanu Please assign to me to fix 
this bug.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services