[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test
terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#discussion_r335802298 ## File path: sharding-sql-test/src/main/resources/sql/sharding/dml/insert.xml ## @@ -48,4 +48,7 @@ + Review comment: I don't think this case is different with the case `insert_duplicate_key_update_two_group_data`. Can we merge the 2 cases? What I mean is can we just remove this case? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test
terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#discussion_r335801518 ## File path: sharding-sql-test/src/main/resources/sql/sharding/dml/insert.xml ## @@ -48,4 +48,7 @@ + + Review comment: What's mean `two_group_data`? We may name test cases more accurate. Perhaps `with_complicated_expression` is a better name. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test
terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#discussion_r335801762 ## File path: sharding-sql-test/src/main/resources/sql/sharding/dml/insert.xml ## @@ -48,4 +48,7 @@ + + + Review comment: The SQL fragment of `salary = VALUES(id)` does not make sense, use `id = VALUES(id)` is better This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test
terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#discussion_r335801366 ## File path: sharding-sql-test/src/main/resources/sql/sharding/dml/insert.xml ## @@ -48,4 +48,7 @@ + + Review comment: I think `with_function_values` should be `with_values_function` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test
terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#discussion_r335801950 ## File path: sharding-sql-test/src/main/resources/sql/sharding/dml/insert.xml ## @@ -48,4 +48,7 @@ + + Review comment: The SQL fragment of `salary = VALUES(id)+VALUES(age)` does not make sense, use `salary = VALUES(salary)+VALUES(salary) + 10` is better This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test
terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#discussion_r335801247 ## File path: sharding-sql-test/src/main/resources/sql/sharding/dml/insert.xml ## @@ -48,4 +48,7 @@ + Review comment: what's mean of `with_function_common`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test
terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#discussion_r335470036 ## File path: sharding-sql-test/src/main/resources/sql/sharding/dml/insert.xml ## @@ -48,4 +48,7 @@ + + + Review comment: What's mean of equation values? maybe values function is better? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test
terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#discussion_r335336757 ## File path: sharding-core/sharding-core-parse/sharding-core-parse-test/src/test/resources/sharding/dml/insert.xml ## @@ -665,4 +665,79 @@ + + Review comment: Do not name as `xxx_1` and `xxx_2`, please name the test case make sense. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
