[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3959: Get ciphertext column as a string

2020-01-20 Thread GitBox 
terrymanu commented on issue #3959: Get ciphertext column as a string
URL: 
https://github.com/apache/incubator-shardingsphere/pull/3959#issuecomment-576514620
 
 
   Thank you very much


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3959: Get ciphertext column as a string

2020-01-19 Thread GitBox 
terrymanu commented on issue #3959: Get ciphertext column as a string
URL: 
https://github.com/apache/incubator-shardingsphere/pull/3959#issuecomment-576079900
 
 
   Ok, I understand. Let's talk about code style for this PR.
   I will use line comment to discuss with you.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3959: Get ciphertext column as a string

2020-01-17 Thread GitBox 
terrymanu commented on issue #3959: Get ciphertext column as a string
URL: 
https://github.com/apache/incubator-shardingsphere/pull/3959#issuecomment-575556753
 
 
   Hi, 
   
   > mysql is not a varchar field type
   
   What is mean?
   
   > getString will not have a type exception.
   
   What is type exception? Did you mean cast exception?
   
   > Can the user do a type conversion here and return the expected type
   
   I can't get the point, is it a question sentence? 
   
   The question I want to know  is what the objective of your pull request? Did 
you meet some problem?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3959: Get ciphertext column as a string

2020-01-14 Thread GitBox 
terrymanu commented on issue #3959: Get ciphertext column as a string
URL: 
https://github.com/apache/incubator-shardingsphere/pull/3959#issuecomment-574468461
 
 
   The code you modify
   
   ```java
   (String) mergedResult.getValue(columnIndex, String.class)
   ```
   
   It is still use getString from original ResultSet. Is it correct if your 
type of field is BigDecimal?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3959: Get ciphertext column as a string

2020-01-14 Thread GitBox 
terrymanu commented on issue #3959: Get ciphertext column as a string
URL: 
https://github.com/apache/incubator-shardingsphere/pull/3959#issuecomment-574212590
 
 
   Hi, I am still want ask the question. I just copy my comment from  #3934
   
   I have a little confuse, why force get value from ResultSet by String type?
   I can't get the point, what is the issue in original code?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services