[GitHub] [incubator-skywalking] linliaoy opened a new issue #2435: oap 部署在k8s 内部,使用集群方式部署异常

2019-04-02 Thread GitBox
linliaoy opened a new issue #2435: oap 部署在k8s 内部,使用集群方式部署异常
URL: https://github.com/apache/incubator-skywalking/issues/2435
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ *] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   在k8s 集群内部搭建oap,使用k8s 管理集群方式,使用standlone 方式部署没有问题。
   配置是按照文档6.0.0-GA,不一样的配置如下:
   application.yml: |-
   cluster:
 kubernetes:
   watchTimeoutSeconds: 60
   labelSelector: app=oap
   uidEnvName: SKYWALKING_COLLECTOR_UID
   core:
 default:
   role: Aggregator
   
   oap报错信息
   
![image](https://user-images.githubusercontent.com/16507478/55384280-e17e1700-555c-11e9-8f48-b4b143e77a94.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking] wu-sheng commented on issue #2378: A question about IndexOutOfBoundsException

2019-04-02 Thread GitBox
wu-sheng commented on issue #2378: A question about IndexOutOfBoundsException 
URL: 
https://github.com/apache/incubator-skywalking/issues/2378#issuecomment-479009917
 
 
   Then your server still run in utc time. Not +8


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking] wu-sheng commented on issue #2435: oap 部署在k8s 内部,使用集群方式部署异常

2019-04-02 Thread GitBox
wu-sheng commented on issue #2435: oap 部署在k8s 内部,使用集群方式部署异常
URL: 
https://github.com/apache/incubator-skywalking/issues/2435#issuecomment-479011538
 
 
   English only, please. Which cluster management do you use? If k8s, then, do 
you have API server access right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking] wu-sheng closed issue #2435: oap 部署在k8s 内部,使用集群方式部署异常

2019-04-02 Thread GitBox
wu-sheng closed issue #2435: oap 部署在k8s 内部,使用集群方式部署异常
URL: https://github.com/apache/incubator-skywalking/issues/2435
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-skywalking-website] branch master updated: Update user wall.

2019-04-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository 
https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git


The following commit(s) were added to refs/heads/master by this push:
 new 4d91395  Update user wall.
4d91395 is described below

commit 4d913956cf6e5ab67368338425d350a35d612fad
Author: Wu Sheng 
AuthorDate: Tue Apr 2 09:34:10 2019 -0700

Update user wall.
---
 docs/.vuepress/public/assets/users-20190402.png | Bin 0 -> 226025 bytes
 docs/.vuepress/public/assets/users.png  | Bin 180061 -> 226025 bytes
 2 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/docs/.vuepress/public/assets/users-20190402.png 
b/docs/.vuepress/public/assets/users-20190402.png
new file mode 100755
index 000..5a9f3d6
Binary files /dev/null and b/docs/.vuepress/public/assets/users-20190402.png 
differ
diff --git a/docs/.vuepress/public/assets/users.png 
b/docs/.vuepress/public/assets/users.png
old mode 100644
new mode 100755
index b10641f..5a9f3d6
Binary files a/docs/.vuepress/public/assets/users.png and 
b/docs/.vuepress/public/assets/users.png differ



[incubator-skywalking-website] branch asf-site updated (d519178 -> 30950c2)

2019-04-02 Thread tanjian
This is an automated email from the ASF dual-hosted git repository.

tanjian pushed a change to branch asf-site
in repository 
https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git.


 discard d519178  Update asf-site
 new 30950c2  Update asf-site

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (d519178)
\
 N -- N -- N   refs/heads/asf-site (30950c2)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 404.html   |   6 +++---
 assets/js/{app.be1f8c56.js => app.4465b20b.js} |   2 +-
 assets/users-20190402.png  | Bin 0 -> 226025 bytes
 assets/users.png   | Bin 180061 -> 226025 bytes
 blog/2018-05-24-skywalking-net.html|   4 ++--
 blog/2018-12-12-skywalking-service-mesh-ready.html |   4 ++--
 blog/2019-01-01-Understand-Trace.html  |   4 ++--
 blog/2019-01-25-mesh-loadtest.html |   4 ++--
 blog/index.html|   4 ++--
 downloads/index.html   |   4 ++--
 events/index.html  |   4 ++--
 index.html |   4 ++--
 team/index.html|   4 ++--
 zh/blog/2018-05-24-skywalking-net.html |   4 ++--
 ...2018-12-18-Apache-SkyWalking-5-0-UserGuide.html |   4 ++--
 ...018-12-21-SkyWalking-apm-sniffer-beginning.html |   4 ++--
 .../2018-12-21-SkyWalking-source-code-read.html|   4 ++--
 zh/blog/2019-01-02-Understand-trace-trans2cn.html  |   4 ++--
 .../2019-01-02-skywalking-elasticsearch-basic.html |   4 ++--
 zh/blog/2019-01-03-monitor-microservice.html   |   4 ++--
 zh/blog/2019-01-21-agent-plugin-practice.html  |   4 ++--
 zh/blog/2019-01-24-skywalking-remote-debug.html|   4 ++--
 zh/blog/2019-02-24-skywalking-pk-pinpoint.html |   4 ++--
 zh/blog/2019-03-01-skywalking-troubleshoot.html|   4 ++--
 zh/blog/index.html |   4 ++--
 zh/doc/index.html  |   4 ++--
 zh/downloads/index.html|   4 ++--
 zh/events/index.html   |   4 ++--
 zh/index.html  |   4 ++--
 zh/team/index.html |   4 ++--
 30 files changed, 56 insertions(+), 56 deletions(-)
 rename assets/js/{app.be1f8c56.js => app.4465b20b.js} (83%)
 create mode 100644 assets/users-20190402.png



[incubator-skywalking] 01/01: Update user wall

2019-04-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch user-wall
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git

commit 52d26648813bc9ddaf68d583107bafb056bca9ee
Author: Wu Sheng 
AuthorDate: Tue Apr 2 09:43:41 2019 -0700

Update user wall
---
 README.md  | 2 +-
 docs/powered-by.md | 9 +++--
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 0c612a4..f81c84e 100644
--- a/README.md
+++ b/README.md
@@ -90,7 +90,7 @@ Follow this [document](docs/en/guides/How-to-build.md).
 A wide variety of companies and organizations use SkyWalking for research, 
production and commercial product.
 Here is the **User Wall** of SkyWalking.
 
-http://skywalking.apache.org/assets/users-20190222.png"/>
+http://skywalking.apache.org/assets/users-20190402.png"/>
 
 Users are encouraged to add themselves to the [PoweredBy](docs/powered-by.md) 
page.
 
diff --git a/docs/powered-by.md b/docs/powered-by.md
index 848ee88..8861f03 100644
--- a/docs/powered-by.md
+++ b/docs/powered-by.md
@@ -60,6 +60,7 @@ or providing commercial products including Apache SkyWalking.
 1. Source++ https://sourceplusplus.com
 1. StartDT 奇点云 https://www.startdt.com/
 1. Successchannel 苏州渠成易销网络科技有限公司. http://www.successchannel.com
+1. Tetrate.io https://www.tetrate.io/
 1. Today36524.com Today便利店
 1. Tools information technology co. LTD 杭州图尔兹信息技术有限公司 http://bintools.cn/
 1. Tsfinance.com 重庆宜迅联供应链科技有限公司 https://www.tsfinance.com.cn/
@@ -90,11 +91,15 @@ Deploy SkyWalking in production enviroments.
 
 Support 60+ Instances, Over 300k Calls Per Minute, Over 50k Spans Per Second
 
+## Oscart
+Use multiple language agents from SkyWalking and its ecosystem, including 
SkyWalking Javaagent and [SkyAPM nodejs 
agent](https://github.com/SkyAPM/SkyAPM-nodejs). SkyWalking OAP platform acts 
as backend and visualization.
+
 ## Primeton
 Integrated in Primeton EOS PLATFORM 8, which is a commercial micro-service 
platform.
 
-## Oscart
-Use multiple language agents from SkyWalking and its ecosystem, including 
SkyWalking Javaagent and [SkyAPM nodejs 
agent](https://github.com/SkyAPM/SkyAPM-nodejs). SkyWalking OAP platform acts 
as backend and visualization.
+## Tetrate
+Tetrate provides enterprise level service mesh. SkyWalking acts as the core 
observability platform for hybrid
+enterprise service mesh environment.
 
 ## Qiniu Cloud
 Provide a customized version SkyWalking agent. It could provide distributed 
tracing and integrated in its intelligence log management platform.



[incubator-skywalking] branch user-wall created (now 52d2664)

2019-04-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a change to branch user-wall
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git.


  at 52d2664  Update user wall

This branch includes the following new commits:

 new 52d2664  Update user wall

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




[GitHub] [incubator-skywalking] wu-sheng opened a new pull request #2436: Update user wall and powered-by page

2019-04-02 Thread GitBox
wu-sheng opened a new pull request #2436: Update user wall and powered-by page
URL: https://github.com/apache/incubator-skywalking/pull/2436
 
 
   Ref #443 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking] wu-sheng commented on issue #443: Which companies are using SkyWalking

2019-04-02 Thread GitBox
wu-sheng commented on issue #443: Which companies are using SkyWalking
URL: 
https://github.com/apache/incubator-skywalking/issues/443#issuecomment-479100856
 
 
   User wall updated.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking] wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available

2019-04-02 Thread GitBox
wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats 
analysis product available
URL: 
https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-479101939
 
 
   Trace formats are supported, I would expect to support analysis in the short 
term. Because no particular committer or contributor wants to work on this.
   
   As, I will remove the milestone and label as `TBD`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking] wu-sheng closed issue #2266: Make metric available at topology

2019-04-02 Thread GitBox
wu-sheng closed issue #2266: Make metric available at topology
URL: https://github.com/apache/incubator-skywalking/issues/2266
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking] wu-sheng commented on issue #2266: Make metric available at topology

2019-04-02 Thread GitBox
wu-sheng commented on issue #2266: Make metric available at topology
URL: 
https://github.com/apache/incubator-skywalking/issues/2266#issuecomment-479102364
 
 
   This is supported in RocketBot UI. We will have this automatically after the 
project donation finished.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-skywalking] branch master updated: Update user wall (#2436)

2019-04-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git


The following commit(s) were added to refs/heads/master by this push:
 new 8c1b816  Update user wall (#2436)
8c1b816 is described below

commit 8c1b816d1e88f26d00af5d0d6b38a53dd6345cbf
Author: 吴晟 Wu Sheng 
AuthorDate: Tue Apr 2 10:51:41 2019 -0700

Update user wall (#2436)
---
 README.md  | 2 +-
 docs/powered-by.md | 9 +++--
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 0c612a4..f81c84e 100644
--- a/README.md
+++ b/README.md
@@ -90,7 +90,7 @@ Follow this [document](docs/en/guides/How-to-build.md).
 A wide variety of companies and organizations use SkyWalking for research, 
production and commercial product.
 Here is the **User Wall** of SkyWalking.
 
-http://skywalking.apache.org/assets/users-20190222.png"/>
+http://skywalking.apache.org/assets/users-20190402.png"/>
 
 Users are encouraged to add themselves to the [PoweredBy](docs/powered-by.md) 
page.
 
diff --git a/docs/powered-by.md b/docs/powered-by.md
index 848ee88..8861f03 100644
--- a/docs/powered-by.md
+++ b/docs/powered-by.md
@@ -60,6 +60,7 @@ or providing commercial products including Apache SkyWalking.
 1. Source++ https://sourceplusplus.com
 1. StartDT 奇点云 https://www.startdt.com/
 1. Successchannel 苏州渠成易销网络科技有限公司. http://www.successchannel.com
+1. Tetrate.io https://www.tetrate.io/
 1. Today36524.com Today便利店
 1. Tools information technology co. LTD 杭州图尔兹信息技术有限公司 http://bintools.cn/
 1. Tsfinance.com 重庆宜迅联供应链科技有限公司 https://www.tsfinance.com.cn/
@@ -90,11 +91,15 @@ Deploy SkyWalking in production enviroments.
 
 Support 60+ Instances, Over 300k Calls Per Minute, Over 50k Spans Per Second
 
+## Oscart
+Use multiple language agents from SkyWalking and its ecosystem, including 
SkyWalking Javaagent and [SkyAPM nodejs 
agent](https://github.com/SkyAPM/SkyAPM-nodejs). SkyWalking OAP platform acts 
as backend and visualization.
+
 ## Primeton
 Integrated in Primeton EOS PLATFORM 8, which is a commercial micro-service 
platform.
 
-## Oscart
-Use multiple language agents from SkyWalking and its ecosystem, including 
SkyWalking Javaagent and [SkyAPM nodejs 
agent](https://github.com/SkyAPM/SkyAPM-nodejs). SkyWalking OAP platform acts 
as backend and visualization.
+## Tetrate
+Tetrate provides enterprise level service mesh. SkyWalking acts as the core 
observability platform for hybrid
+enterprise service mesh environment.
 
 ## Qiniu Cloud
 Provide a customized version SkyWalking agent. It could provide distributed 
tracing and integrated in its intelligence log management platform.



[incubator-skywalking] branch user-wall deleted (was 52d2664)

2019-04-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a change to branch user-wall
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git.


 was 52d2664  Update user wall

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.



[GitHub] [incubator-skywalking] wu-sheng merged pull request #2436: Update user wall and powered-by page

2019-04-02 Thread GitBox
wu-sheng merged pull request #2436: Update user wall and powered-by page
URL: https://github.com/apache/incubator-skywalking/pull/2436
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking] coveralls commented on issue #2436: Update user wall and powered-by page

2019-04-02 Thread GitBox
coveralls commented on issue #2436: Update user wall and powered-by page
URL: 
https://github.com/apache/incubator-skywalking/pull/2436#issuecomment-479120718
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/22555313/badge)](https://coveralls.io/builds/22555313)
   
   Coverage increased (+0.002%) to 15.415% when pulling 
**52d26648813bc9ddaf68d583107bafb056bca9ee on user-wall** into 
**ff6fb90d384f0030af2723afa06b02d8792eb861 on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking] wu-sheng opened a new issue #2437: Support istio report protocol and attribute protocol, make mixer unrequired

2019-04-02 Thread GitBox
wu-sheng opened a new issue #2437: Support istio report protocol and attribute 
protocol, make mixer unrequired
URL: https://github.com/apache/incubator-skywalking/issues/2437
 
 
   We have received many feedbacks about the concerns of Istio mixer, so, I am 
proposing we support [Mixer Report 
Protocol](https://github.com/istio/api/blob/f2e09a7a27446db1b33a26b169d6a88556e7ebbd/mixer/v1/mixer.proto#L58)
 with [Istio Attribute 
Protocol](https://github.com/istio/api/blob/master/mixer/v1/attributes.proto). 
   
   Also from Istio 1.1.0, the compress has been turned off. 
   
   But, anyway, we use particular keys(and types) we need, to pick the 
telemetry values. Then we could generate SkyWalking native format, and push 
forward to `SkyWalking.receiver`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking] wu-sheng closed issue #1768: [DISCUSS] Heading to graduation

2019-04-02 Thread GitBox
wu-sheng closed issue #1768: [DISCUSS] Heading to graduation
URL: https://github.com/apache/incubator-skywalking/issues/1768
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking] wu-sheng commented on issue #1768: [DISCUSS] Heading to graduation

2019-04-02 Thread GitBox
wu-sheng commented on issue #1768: [DISCUSS] Heading to graduation
URL: 
https://github.com/apache/incubator-skywalking/issues/1768#issuecomment-479175662
 
 
   We passed the community vote and Incubator vote. We are waiting for the ASF 
board final resolution.
   
   I think we could close this discussion for now. Thank you all for supporting 
the project, and welcome everyone in the community.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking] linliaoy commented on issue #2435: oap 部署在k8s 内部,使用集群方式部署异常

2019-04-02 Thread GitBox
linliaoy commented on issue #2435: oap 部署在k8s 内部,使用集群方式部署异常
URL: 
https://github.com/apache/incubator-skywalking/issues/2435#issuecomment-479314226
 
 
   I the correct use of 00 - rbac. Yml, but I use the namespace is the default, 
the other is to operate according to the document 
(https://github.com/apache/incubator-skywalking-kubernetes).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking] linliaoy edited a comment on issue #2435: oap 部署在k8s 内部,使用集群方式部署异常

2019-04-02 Thread GitBox
linliaoy edited a comment on issue #2435: oap 部署在k8s 内部,使用集群方式部署异常
URL: 
https://github.com/apache/incubator-skywalking/issues/2435#issuecomment-479314226
 
 
   I the correct use of 00 - rbac. Yml, but I use the namespace is the default, 
the other is to operate according to the document 
(https://github.com/apache/incubator-skywalking-kubernetes).
   
   The reference configuration k8s rules here 
(https://github.com/apache/incubator-skywalking/blob/master/docs/en/setup/backend/advanced-deployment.md)
 。
   
   Any questions about where the configuration is here,Where is this configured。
   
![image](https://user-images.githubusercontent.com/16507478/55450162-d250a500-5600-11e9-864f-0e3f799b97ce.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking] wu-sheng commented on issue #2435: Oap is deployed within k8s and USES clustering to deploy exceptions

2019-04-02 Thread GitBox
wu-sheng commented on issue #2435: Oap is deployed within k8s and USES 
clustering to deploy exceptions
URL: 
https://github.com/apache/incubator-skywalking/issues/2435#issuecomment-479316920
 
 
   If you want to understand the mode, you need to understand how skywalking 
cluster runs. The config we provided is only for `Mixed` mode.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking] wu-sheng commented on issue #2422: [Rejected by License Issue]add cluster nacos support

2019-04-02 Thread GitBox
wu-sheng commented on issue #2422: [Rejected by License Issue]add cluster nacos 
support
URL: 
https://github.com/apache/incubator-skywalking/pull/2422#issuecomment-479343352
 
 
   @litian33 Could you try to use the latest Nacos release to submit a new PR 
and list the new dependencies there?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking] wu-sheng opened a new issue #2438: Increase the test coverage

2019-04-02 Thread GitBox
wu-sheng opened a new issue #2438: Increase the test coverage
URL: https://github.com/apache/incubator-skywalking/issues/2438
 
 
   Today, SkyWalking's tests are mostly around integration tests, which are 
benifit for end users. Now we hope through this, people from community could 
help on Unit Tests.
   
   JUnit and Mockito are provided. This is a good start for everyone wants to 
contribute codes. When you submit test cases PR, please ref to this issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking-ui] liudingnet commented on issue #237: list of servers in container (6.0.0-GA)

2019-04-02 Thread GitBox
liudingnet commented on issue #237: list of servers in container (6.0.0-GA)
URL: 
https://github.com/apache/incubator-skywalking-ui/issues/237#issuecomment-479353650
 
 
   Container Deployed Cluster Architect.
   I solved the problem, should upgrade the spring cloud to 2.x, otherwise ui 
zuul property named"list of servers" can be ignored with default value 
127.0.0.1:12800. You could easily repeat it!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking-ui] wu-sheng commented on issue #237: list of servers in container (6.0.0-GA)

2019-04-02 Thread GitBox
wu-sheng commented on issue #237: list of servers in container (6.0.0-GA)
URL: 
https://github.com/apache/incubator-skywalking-ui/issues/237#issuecomment-479356819
 
 
   I am not sure. My production environment is running in container and k8s 
based always. So, I am not sure the issue.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking] wu-sheng commented on issue #2438: Increase the test coverage rate

2019-04-02 Thread GitBox
wu-sheng commented on issue #2438: Increase the test coverage rate
URL: 
https://github.com/apache/incubator-skywalking/issues/2438#issuecomment-479358499
 
 
   Also, in this kind of pull request, we don't limit how many test cases you 
provide. Even one new test case, which could effectively test one more line, it 
will be acceptable. Just try your best to make tests more sense.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-skywalking] Remember-Forever commented on issue #2378: A question about IndexOutOfBoundsException

2019-04-02 Thread GitBox
Remember-Forever commented on issue #2378: A question about 
IndexOutOfBoundsException 
URL: 
https://github.com/apache/incubator-skywalking/issues/2378#issuecomment-479360671
 
 
   Thx. I resolved it


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services