[skywalking] branch kezhenxu94-patch-1 deleted (was a7d5e42)

2019-08-24 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a change to branch kezhenxu94-patch-1
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


 was a7d5e42  Add Thomas Cook to powered-by

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.



[GitHub] [skywalking] wu-sheng merged pull request #3316: Add Thomas Cook to powered-by

2019-08-24 Thread GitBox
wu-sheng merged pull request #3316: Add Thomas Cook to powered-by
URL: https://github.com/apache/skywalking/pull/3316
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[skywalking] branch master updated: Add Thomas Cook to powered-by (#3316)

2019-08-24 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/master by this push:
 new dbab697  Add Thomas Cook to powered-by (#3316)
dbab697 is described below

commit dbab6977c8141f0df3d62c42122698c37bc4850d
Author: kezhenxu94 
AuthorDate: Sun Aug 25 12:45:29 2019 +0800

Add Thomas Cook to powered-by (#3316)
---
 docs/powered-by.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/docs/powered-by.md b/docs/powered-by.md
index 55c4cd6..fbfe217 100644
--- a/docs/powered-by.md
+++ b/docs/powered-by.md
@@ -76,6 +76,7 @@ or providing commercial products including Apache SkyWalking.
 1. syswin.com 北京思源集团 http://www.syswin.com/
 1. szhittech.com 深圳和而泰智能控制股份有限公司. http://www.szhittech.com/
 1. Tetrate.io https://www.tetrate.io/
+1. Thomas Cook 托迈酷客 https://www.thomascook.com.cn
 1. Today36524.com Today便利店
 1. Tongcheng. 同城金服. https://jr.ly.com/
 1. Tools information technology co. LTD 杭州图尔兹信息技术有限公司 http://bintools.cn/



[GitHub] [skywalking] meteor1993 opened a new issue #3317: Skywalking can not connect to elasticsearch

2019-08-24 Thread GitBox
meteor1993 opened a new issue #3317: Skywalking can not connect to elasticsearch
URL: https://github.com/apache/skywalking/issues/3317
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [x] Bug
   ___
   ### Bug
   - Which version of SkyWalking, OS and JRE?
   skywalking: 6.3
   elasticsearch: 6.8.2
   
   - What happen?
   When i restart skywalking,the skywalking can not connect to elasticsearch.
   
   When I first started skywalking, everything was fine, but when I restarted 
skywalking, skywalking would not connect elasticsearch,which produces the 
following exceptions:
   
   ```
   2019-08-24 13:09:30,828 - 
org.apache.skywalking.oap.server.library.client.elasticsearch.ElasticSearchClient
 - 91 [main] INFO  [] - elasticsearch cluster nodes: localhost:9200
   2019-08-24 13:09:34,169 - 
org.apache.skywalking.oap.server.starter.OAPServerStartUp - 55 [main] ERROR [] 
- method [HEAD], host [http://localhost:9200], URI [/], status line [HTTP/1.1 
503 Service Unavailable]
   org.elasticsearch.ElasticsearchStatusException: method [HEAD], host 
[http://localhost:9200], URI [/], status line [HTTP/1.1 503 Service Unavailable]
at 
org.elasticsearch.client.RestHighLevelClient.parseResponseException(RestHighLevelClient.java:625)
 ~[elasticsearch-rest-high-level-client-6.3.2.jar:6.3.2]
at 
org.elasticsearch.client.RestHighLevelClient.performRequest(RestHighLevelClient.java:535)
 ~[elasticsearch-rest-high-level-client-6.3.2.jar:6.3.2]
at 
org.elasticsearch.client.RestHighLevelClient.ping(RestHighLevelClient.java:275) 
~[elasticsearch-rest-high-level-client-6.3.2.jar:6.3.2]
at 
org.apache.skywalking.oap.server.library.client.elasticsearch.ElasticSearchClient.connect(ElasticSearchClient.java:82)
 ~[library-client-6.3.0.jar:6.3.0]
at 
org.apache.skywalking.oap.server.storage.plugin.elasticsearch.StorageModuleElasticsearchProvider.start(StorageModuleElasticsearchProvider.java:96)
 ~[storage-elasticsearch-plugin-6.3.0.jar:6.3.0]
at 
org.apache.skywalking.oap.server.library.module.BootstrapFlow.start(BootstrapFlow.java:61)
 ~[library-module-6.3.0.jar:6.3.0]
at 
org.apache.skywalking.oap.server.library.module.ModuleManager.init(ModuleManager.java:67)
 ~[library-module-6.3.0.jar:6.3.0]
at 
org.apache.skywalking.oap.server.starter.OAPServerStartUp.main(OAPServerStartUp.java:43)
 [server-starter-6.3.0.jar:6.3.0]
   Caused by: org.elasticsearch.client.ResponseException: method [HEAD], host 
[http://localhost:9200], URI [/], status line [HTTP/1.1 503 Service Unavailable]
at 
org.elasticsearch.client.RestClient$SyncResponseListener.get(RestClient.java:705)
 ~[elasticsearch-rest-client-6.3.2.jar:6.3.2]
at 
org.elasticsearch.client.RestClient.performRequest(RestClient.java:235) 
~[elasticsearch-rest-client-6.3.2.jar:6.3.2]
at 
org.elasticsearch.client.RestClient.performRequest(RestClient.java:198) 
~[elasticsearch-rest-client-6.3.2.jar:6.3.2]
at 
org.elasticsearch.client.RestHighLevelClient.performRequest(RestHighLevelClient.java:522)
 ~[elasticsearch-rest-high-level-client-6.3.2.jar:6.3.2]
... 6 more
   Caused by: org.elasticsearch.client.ResponseException: method [HEAD], host 
[http://localhost:9200], URI [/], status line [HTTP/1.1 503 Service Unavailable]
at org.elasticsearch.client.RestClient$1.completed(RestClient.java:377) 
~[elasticsearch-rest-client-6.3.2.jar:6.3.2]
at org.elasticsearch.client.RestClient$1.completed(RestClient.java:366) 
~[elasticsearch-rest-client-6.3.2.jar:6.3.2]
at 
org.apache.http.concurrent.BasicFuture.completed(BasicFuture.java:119) 
~[httpcore-4.4.5.jar:4.4.5]
at 
org.apache.http.impl.nio.client.DefaultClientExchangeHandlerImpl.responseCompleted(DefaultClientExchangeHandlerImpl.java:177)
 ~[httpasyncclient-4.1.2.jar:4.1.2]
at 
org.apache.http.nio.protocol.HttpAsyncRequestExecutor.processResponse(HttpAsyncRequestExecutor.java:436)
 ~[httpcore-nio-4.4.5.jar:4.4.5]
at 
org.apache.http.nio.protocol.HttpAsyncRequestExecutor.responseReceived(HttpAsyncRequestExecutor.java:309)
 ~[httpcore-nio-4.4.5.jar:4.4.5]
at 
org.apache.http.impl.nio.DefaultNHttpClientConnection.consumeInput(DefaultNHttpClientConnection.java:255)
 ~[httpcore-nio-4.4.5.jar:4.4.5]
at 
org.apache.http.impl.nio.client.InternalIODispatch.onInputReady(InternalIODispatch.java:81)
 ~[httpasyncclient-4.1.2.jar:4.1.2]
at 
org.apache.http.impl.nio.client.InternalIODispatch.onInputReady(InternalIODispatch.java:39)
 ~[httpasyncclient-4.1.2.jar:4.1.2]
at 
org.apache.http.impl.nio.reactor.AbstractIODispatch.inputReady(AbstractIODispatch.java:114)
 ~[httpcore-nio-4.4.5.jar:4.4.5]
at 
org.apache.http.impl.nio.reactor.BaseIOReactor.readable(BaseIOReactor.java:162) 
~[httpcore-nio-4.4.5.jar:4.4.5]
at 
org.apache.http.impl.nio.reactor.AbstractIOReactor.processEvent(AbstractIOReactor.java:337)
 

[GitHub] [skywalking] kezhenxu94 removed a comment on issue #3316: Add Thomas Cook to powered-by

2019-08-24 Thread GitBox
kezhenxu94 removed a comment on issue #3316: Add Thomas Cook to powered-by
URL: https://github.com/apache/skywalking/pull/3316#issuecomment-524598257
 
 
   /run ci


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] kezhenxu94 commented on issue #3316: Add Thomas Cook to powered-by

2019-08-24 Thread GitBox
kezhenxu94 commented on issue #3316: Add Thomas Cook to powered-by
URL: https://github.com/apache/skywalking/pull/3316#issuecomment-524598257
 
 
   /run ci


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] kezhenxu94 opened a new pull request #3316: Add Thomas Cook to powered-by

2019-08-24 Thread GitBox
kezhenxu94 opened a new pull request #3316: Add Thomas Cook to powered-by
URL: https://github.com/apache/skywalking/pull/3316
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[skywalking] branch kezhenxu94-patch-1 created (now a7d5e42)

2019-08-24 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a change to branch kezhenxu94-patch-1
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


  at a7d5e42  Add Thomas Cook to powered-by

This branch includes the following new commits:

 new a7d5e42  Add Thomas Cook to powered-by

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




[skywalking] 01/01: Add Thomas Cook to powered-by

2019-08-24 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a commit to branch kezhenxu94-patch-1
in repository https://gitbox.apache.org/repos/asf/skywalking.git

commit a7d5e427b3a21d52fc240ac0e2eb0c0f2a0a7c94
Author: kezhenxu94 
AuthorDate: Sun Aug 25 11:26:40 2019 +0800

Add Thomas Cook to powered-by
---
 docs/powered-by.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/docs/powered-by.md b/docs/powered-by.md
index 55c4cd6..fbfe217 100644
--- a/docs/powered-by.md
+++ b/docs/powered-by.md
@@ -76,6 +76,7 @@ or providing commercial products including Apache SkyWalking.
 1. syswin.com 北京思源集团 http://www.syswin.com/
 1. szhittech.com 深圳和而泰智能控制股份有限公司. http://www.szhittech.com/
 1. Tetrate.io https://www.tetrate.io/
+1. Thomas Cook 托迈酷客 https://www.thomascook.com.cn
 1. Today36524.com Today便利店
 1. Tongcheng. 同城金服. https://jr.ly.com/
 1. Tools information technology co. LTD 杭州图尔兹信息技术有限公司 http://bintools.cn/



[GitHub] [skywalking] kezhenxu94 commented on issue #443: Which companies are using SkyWalking

2019-08-24 Thread GitBox
kezhenxu94 commented on issue #443: Which companies are using SkyWalking
URL: https://github.com/apache/skywalking/issues/443#issuecomment-524595336
 
 
   Thomas Cook (https://www.thomascook.com.cn) , based on 
https://github.com/apache/skywalking/issues/3315#issue-484876289


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] kezhenxu94 closed issue #3315: Elasticsearch exception [type=version_conflict_engine_exception

2019-08-24 Thread GitBox
kezhenxu94 closed issue #3315: Elasticsearch exception 
[type=version_conflict_engine_exception
URL: https://github.com/apache/skywalking/issues/3315
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] kezhenxu94 commented on issue #3315: Elasticsearch exception [type=version_conflict_engine_exception

2019-08-24 Thread GitBox
kezhenxu94 commented on issue #3315: Elasticsearch exception 
[type=version_conflict_engine_exception
URL: https://github.com/apache/skywalking/issues/3315#issuecomment-524595124
 
 
   Duplicate of #2496 , please refer to that issue for answer


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] zhaoyuguang commented on issue #3311: Features/cassandra 3.x plugin

2019-08-24 Thread GitBox
zhaoyuguang commented on issue #3311: Features/cassandra 3.x plugin
URL: https://github.com/apache/skywalking/pull/3311#issuecomment-524592711
 
 
   Hi @stone-wlg, Please add testcases at 
https://github.com/SkyAPMTest/agent-auto-integration-testcases


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] wuxingye opened a new issue #3315: Elasticsearch exception [type=version_conflict_engine_exception

2019-08-24 Thread GitBox
wuxingye opened a new issue #3315: Elasticsearch exception 
[type=version_conflict_engine_exception
URL: https://github.com/apache/skywalking/issues/3315
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   
   - [ ] Bug
   
   --
   
   ### Bug
   
   - Which version of SkyWalking, OS and JRE?
   
   SkyWalking: 6.3
   
   Elasticsearch:6.8.2
   
   OS and JRE: official docker images
   
   mode: Zookeeper cluster
   
   detail (docker-compose.yml):
   
   ```yml
   version: '3.3'
   
   services:
 es6_01:
   restart: always
   container_name: es6_01
   image: elasticsearch:6.8.2
   hostname: es6_01
   privileged: true
   environment:
 - TZ="Asia/Shanghai"
 - node.name=es6_01
 - network.host=es6_01
 - discovery.zen.minimum_master_nodes=2
 - discovery.zen.ping.unicast.hosts=es6_01,es6_02,es6_03
 - cluster.name=es6
 - bootstrap.memory_lock=true
 - "ES_JAVA_OPTS=-Xms512m -Xmx512m"
   ulimits:
 memlock:
   soft: -1
   hard: -1
   volumes:
 - es6_data1:/usr/share/elasticsearch/data
   ports:
 - 9211:9200
 - 9311:9300
   
 es6_02:
   restart: always
   container_name: es6_02
   image: elasticsearch:6.8.2
   hostname: es6_02
   privileged: true
   environment:
 - TZ="Asia/Shanghai"
 - node.name=es6_02
 - network.host=es6_02
 - discovery.zen.minimum_master_nodes=2
 - discovery.zen.ping.unicast.hosts=es6_01,es6_02,es6_03
 - cluster.name=es6
 - bootstrap.memory_lock=true
 - "ES_JAVA_OPTS=-Xms512m -Xmx512m"
   ulimits:
 memlock:
   soft: -1
   hard: -1
   volumes:
 - es6_data2:/usr/share/elasticsearch/data
   ports:
 - 9212:9200
 - 9312:9300
   
 es6_03:
   restart: always
   container_name: es6_03
   image: elasticsearch:6.8.2
   hostname: es6_03
   privileged: true
   environment:
 - TZ="Asia/Shanghai"
 - node.name=es6_03
 - network.host=es6_03
 - discovery.zen.minimum_master_nodes=2
 - discovery.zen.ping.unicast.hosts=es6_01,es6_02,es6_03
 - cluster.name=es6
 - bootstrap.memory_lock=true
 - "ES_JAVA_OPTS=-Xms512m -Xmx512m"
   ulimits:
 memlock:
   soft: -1
   hard: -1
   volumes:
 - es6_data3:/usr/share/elasticsearch/data
   ports:
 - 9213:9200
 - 9313:9300
   
 oap1:
   image: apache/skywalking-oap-server:6.3.0
   container_name: oap1
   hostname: oap1
   privileged: true
   restart: always
   ports:
 - 11801:11800
 - 12801:12800
   environment:
 TZ: Asia/Shanghai
 SW_CLUSTER: zookeeper
 SW_CLUSTER_ZK_HOST_PORT: 
zookeeper1:2181,zookeeper2:2181,zookeeper3:2181
 SW_STORAGE: elasticsearch
 SW_STORAGE_ES_CLUSTER_NODES: es6_01:9200,es6_02:9200,es6_03:9200
   depends_on:
 - es6_01
 - es6_02
 - es6_03
   links:
 - es6_01
 - es6_02
 - es6_03
 oap2:
   image: apache/skywalking-oap-server:6.3.0
   container_name: oap2
   hostname: oap2
   privileged: true
   restart: always
   ports:
 - 11802:11800
 - 12802:12800
   environment:
 TZ: Asia/Shanghai
 SW_CLUSTER: zookeeper
 SW_CLUSTER_ZK_HOST_PORT: 
zookeeper1:2181,zookeeper2:2181,zookeeper3:2181
 SW_STORAGE: elasticsearch
 SW_STORAGE_ES_CLUSTER_NODES: es6_01:9200,es6_02:9200,es6_03:9200
   depends_on:
 - es6_01
 - es6_02
 - es6_03
   links:
 - es6_01
 - es6_02
 - es6_03
 oap3:
   image: apache/skywalking-oap-server:6.3.0
   container_name: oap3
   hostname: oap3
   privileged: true
   restart: always
   ports:
 - 11803:11800
 - 12803:12800
   environment:
 TZ: Asia/Shanghai
 SW_CLUSTER: zookeeper
 SW_CLUSTER_ZK_HOST_PORT: 
zookeeper1:2181,zookeeper2:2181,zookeeper3:2181
 SW_STORAGE: elasticsearch
 SW_STORAGE_ES_CLUSTER_NODES: es6_01:9200,es6_02:9200,es6_03:9200
   depends_on:
 - es6_01
 - es6_02
 - es6_03
   links:
 - es6_01
 - es6_02
 - es6_03
   
 ui:
   image: apache/skywalking-ui:6.3.0
   container_name: ui
   depends_on:
 - oap1
 - oap2
 - oap3
   links:
 - oap1
 - oap2
 - oap3
   restart: always
   ports:
 - 2800:8080
   environment:
 SW_OAP_ADDRESS: oap1:12800,oap2:12800,oap3:12800
   
   networks:
 default:
   external:
 name: kakarot
   
   volumes:
 es6_data1:
   driver_opts:
 type: none
 device: 

[GitHub] [skywalking] qxo edited a comment on issue #3314: ProtectiveShieldMatcher add feature for exclude some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore some package

2019-08-24 Thread GitBox
qxo edited a comment on issue #3314: ProtectiveShieldMatcher add feature for 
exclude some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore 
some package
URL: https://github.com/apache/skywalking/pull/3314#issuecomment-524563334
 
 
   ```
   final ByteBuddy byteBuddy = new ByteBuddy()
   .with(TypeValidation.of(Config.Agent.IS_OPEN_DEBUGGING_CLASS));
   
   Junction ignores = nameStartsWith("net.bytebuddy.");
   
   //change start 
   String ignoreList = 
System.getProperty("skywalking_ignore_class_prefixlist");
   if (ignoreList != null && (ignoreList = ignoreList.trim()).length() 
> 0) {
   logger.info("skywalking_ignore_class_prefixlist:{}",ignoreList);
   for (String p : ignoreList.split("[ ,;:]+")) {
   ignores = ignores.or(nameStartsWith(p));
   }
   }
   //change end
   
   ignores = ignores.or(nameStartsWith("org.slf4j."))
   .or(nameStartsWith("org.apache.logging."))
   .or(nameStartsWith("org.groovy."))
   .or(nameContains("javassist"))
   .or(nameContains(".asm."))
   .or(nameStartsWith("sun.reflect"))
   .or(allSkyWalkingAgentExcludeToolkit())
   .or(ElementMatchers.isSynthetic());
   new AgentBuilder.Default(byteBuddy)
   .ignore(
   ignores)
   .type(pluginFinder.buildMatch())
   .transform(new Transformer(pluginFinder))
   .with(new Listener())
   .installOn(instrumentation);
   ```
   
   then -Dskywalking_ignore_class_prefixlist=com.jprofiler


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] qxo commented on issue #3314: ProtectiveShieldMatcher add feature for exclude some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore some package

2019-08-24 Thread GitBox
qxo commented on issue #3314: ProtectiveShieldMatcher add feature for exclude 
some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore some 
package
URL: https://github.com/apache/skywalking/pull/3314#issuecomment-524563334
 
 
   {code}
   
   final ByteBuddy byteBuddy = new ByteBuddy()
   .with(TypeValidation.of(Config.Agent.IS_OPEN_DEBUGGING_CLASS));
   
   Junction ignores = nameStartsWith("net.bytebuddy.");
   
   //change start 
   String ignoreList = 
System.getProperty("skywalking_ignore_class_prefixlist");
   if (ignoreList != null && (ignoreList = ignoreList.trim()).length() 
> 0) {
   logger.info("skywalking_ignore_class_prefixlist:{}",ignoreList);
   for (String p : ignoreList.split("[ ,;:]+")) {
   ignores = ignores.or(nameStartsWith(p));
   }
   }
   //change end
   
   ignores = ignores.or(nameStartsWith("org.slf4j."))
   .or(nameStartsWith("org.apache.logging."))
   .or(nameStartsWith("org.groovy."))
   .or(nameContains("javassist"))
   .or(nameContains(".asm."))
   .or(nameStartsWith("sun.reflect"))
   .or(allSkyWalkingAgentExcludeToolkit())
   .or(ElementMatchers.isSynthetic());
   new AgentBuilder.Default(byteBuddy)
   .ignore(
   ignores)
   .type(pluginFinder.buildMatch())
   .transform(new Transformer(pluginFinder))
   .with(new Listener())
   .installOn(instrumentation);
   {code}
   
   then -Dskywalking_ignore_class_prefixlist=com.jprofiler


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] wu-sheng commented on issue #3314: ProtectiveShieldMatcher add feature for exclude some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore some package

2019-08-24 Thread GitBox
wu-sheng commented on issue #3314: ProtectiveShieldMatcher add feature for 
exclude some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore 
some package
URL: https://github.com/apache/skywalking/pull/3314#issuecomment-524560313
 
 
   Could you provide the codes you changed? This should work.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] qxo edited a comment on issue #3314: ProtectiveShieldMatcher add feature for exclude some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore some package

2019-08-24 Thread GitBox
qxo edited a comment on issue #3314: ProtectiveShieldMatcher add feature for 
exclude some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore 
some package
URL: https://github.com/apache/skywalking/pull/3314#issuecomment-524559735
 
 
   On my test add ignore like "SkyWalkingAgent#L91-L99"  will not fix the issue:
   `at 
org.apache.skywalking.apm.dependencies.net.bytebuddy.pool.TypePool$Resolution$Illegal.resolve(TypePool.java:144)`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] qxo commented on issue #3314: ProtectiveShieldMatcher add feature for exclude some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore some package

2019-08-24 Thread GitBox
qxo commented on issue #3314: ProtectiveShieldMatcher add feature for exclude 
some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore some 
package
URL: https://github.com/apache/skywalking/pull/3314#issuecomment-524559735
 
 
   On my test add ignore like "SkyWalkingAgent#L91-L99"  will not work the 
issue:
   `at 
org.apache.skywalking.apm.dependencies.net.bytebuddy.pool.TypePool$Resolution$Illegal.resolve(TypePool.java:144)`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] wu-sheng commented on issue #3314: ProtectiveShieldMatcher add feature for exclude some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore some package

2019-08-24 Thread GitBox
wu-sheng commented on issue #3314: ProtectiveShieldMatcher add feature for 
exclude some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore 
some package
URL: https://github.com/apache/skywalking/pull/3314#issuecomment-524555799
 
 
   
https://github.com/apache/skywalking/blob/0ae2228a86713d89ce9f6bf849fb9a96303d0cfa/apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java#L91-L99


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] wu-sheng commented on issue #3314: ProtectiveShieldMatcher add feature for exclude some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore some package

2019-08-24 Thread GitBox
wu-sheng commented on issue #3314: ProtectiveShieldMatcher add feature for 
exclude some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore 
some package
URL: https://github.com/apache/skywalking/pull/3314#issuecomment-524555743
 
 
   `SkyWalkingAgent` is the class name, Line 91 - 99. Ignore is there static, 
you could provide this feature there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] qxo commented on issue #3314: ProtectiveShieldMatcher add feature for exclude some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore some package

2019-08-24 Thread GitBox
qxo commented on issue #3314: ProtectiveShieldMatcher add feature for exclude 
some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore some 
package
URL: https://github.com/apache/skywalking/pull/3314#issuecomment-524555644
 
 
   where is "SkyWalkingAgent#L91-L99" , A link will be helpful:)
   
   I don't known if was the way for ignore classes “out of box”
   I thought it should have:)
   
   看到问题点,就顺带解决了,觉得该回馈开源社区就提上来了,也许存在更好的方式是我不知的
   
   Never mind, help yourself:)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] kezhenxu94 closed issue #3249: IllegalMethodStackDepthException:

2019-08-24 Thread GitBox
kezhenxu94 closed issue #3249: IllegalMethodStackDepthException:
URL: https://github.com/apache/skywalking/issues/3249
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] kezhenxu94 commented on issue #3249: IllegalMethodStackDepthException:

2019-08-24 Thread GitBox
kezhenxu94 commented on issue #3249: IllegalMethodStackDepthException:
URL: https://github.com/apache/skywalking/issues/3249#issuecomment-524551171
 
 
   Duplicate of #2659 but still failed to get a reproduce project, I'll close 
this until some users can provide a demo to reproduce


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] wu-sheng closed pull request #3314: ProtectiveShieldMatcher add feature for exclude some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore some package

2019-08-24 Thread GitBox
wu-sheng closed pull request #3314: ProtectiveShieldMatcher add feature for 
exclude some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore 
some package
URL: https://github.com/apache/skywalking/pull/3314
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] wu-sheng closed issue #3296: MySQL PreparedStatement execute method been enhanced twice

2019-08-24 Thread GitBox
wu-sheng closed issue #3296: MySQL PreparedStatement execute method been 
enhanced twice
URL: https://github.com/apache/skywalking/issues/3296
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[skywalking] branch master updated: fix 3296 (#3306)

2019-08-24 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/master by this push:
 new 3c8307f  fix 3296 (#3306)
3c8307f is described below

commit 3c8307fe1f04b88a49e53e08f58f6b35c67e0e85
Author: honganan <975990...@qq.com>
AuthorDate: Sat Aug 24 17:32:39 2019 +0800

fix 3296 (#3306)
---
 .../mysql/v5/define/PreparedStatementInstrumentation.java| 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git 
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/v5/define/PreparedStatementInstrumentation.java
 
b/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/v5/define/PreparedStatementInstrumentation.java
index 50b34ea..bf2209f 100644
--- 
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/v5/define/PreparedStatementInstrumentation.java
+++ 
b/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/v5/define/PreparedStatementInstrumentation.java
@@ -19,15 +19,16 @@
 
 package org.apache.skywalking.apm.plugin.jdbc.mysql.v5.define;
 
-import net.bytebuddy.description.method.MethodDescription;
-import net.bytebuddy.matcher.ElementMatcher;
+import static net.bytebuddy.matcher.ElementMatchers.named;
+import static 
org.apache.skywalking.apm.agent.core.plugin.match.NameMatch.byName;
+
 import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.ConstructorInterceptPoint;
 import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.InstanceMethodsInterceptPoint;
 import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch;
 import org.apache.skywalking.apm.plugin.jdbc.mysql.Constants;
 
-import static net.bytebuddy.matcher.ElementMatchers.named;
-import static 
org.apache.skywalking.apm.agent.core.plugin.match.MultiClassNameMatch.byMultiClassMatch;
+import net.bytebuddy.description.method.MethodDescription;
+import net.bytebuddy.matcher.ElementMatcher;
 
 /**
  * {@link PreparedStatementInstrumentation} define that the mysql-2.x plugin 
intercepts the following methods in the
@@ -45,7 +46,6 @@ public class PreparedStatementInstrumentation extends 
AbstractMysqlInstrumentati
 
 private static final String SERVICE_METHOD_INTERCEPTOR = 
Constants.PREPARED_STATEMENT_EXECUTE_METHODS_INTERCEPTOR;
 public static final String MYSQL_PREPARED_STATEMENT_CLASS_NAME = 
"com.mysql.jdbc.PreparedStatement";
-public static final String JDBC42_PREPARED_STATEMENT_CLASS_NAME = 
"com.mysql.jdbc.JDBC42PreparedStatement";
 
 @Override public final ConstructorInterceptPoint[] 
getConstructorsInterceptPoints() {
 return new ConstructorInterceptPoint[0];
@@ -73,7 +73,7 @@ public class PreparedStatementInstrumentation extends 
AbstractMysqlInstrumentati
 }
 
 @Override protected ClassMatch enhanceClass() {
-return 
byMultiClassMatch(MYSQL_PREPARED_STATEMENT_CLASS_NAME,JDBC42_PREPARED_STATEMENT_CLASS_NAME);
+return byName(MYSQL_PREPARED_STATEMENT_CLASS_NAME);
 }
 
 }



[GitHub] [skywalking] wu-sheng merged pull request #3306: Honganan fix 3296

2019-08-24 Thread GitBox
wu-sheng merged pull request #3306: Honganan fix 3296
URL: https://github.com/apache/skywalking/pull/3306
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services