[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 164  -582 
 Lines 183633925-14438 
 Branches   1778 467 -1311 
   
   - Hits   9218   0 -9218 
   + Misses 84083925 -4483 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [680 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[skywalking] branch ui-template updated (76057c0 -> ebd84f9)

2020-05-31 Thread daming
This is an automated email from the ASF dual-hosted git repository.

daming pushed a change to branch ui-template
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


from 76057c0  fix e2e test
 add ebd84f9  fix checkstyle & remove fluent

No new revisions were added by this update.

Summary of changes:
 .../e2e/dashboard/DashboardConfigurationMatcher.java  | 11 +--
 .../e2e/dashboard/DashboardConfigurationsMatcher.java |  1 -
 .../java/org/apache/skywalking/e2e/storage/StorageE2E.java|  5 +++--
 3 files changed, 8 insertions(+), 9 deletions(-)



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 162  -584 
 Lines 183633919-1 
 Branches   1778 467 -1311 
   
   - Hits   9218   0 -9218 
   + Misses 84083919 -4489 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [682 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `1.21%`.
   > The diff coverage is `32.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   48.98%   -1.22% 
   + Complexity 2700 2697   -3 
   
 Files   746  757  +11 
 Lines 1836318641 +278 
 Branches   1778 1808  +30 
   
   - Hits   9218 9131  -87 
   - Misses 8408 8775 +367 
   + Partials737  735   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `58.46% <ø> (-0.94%)` | `11.00 <0.00> (-1.00)` | |
   | 
[...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=)
 | `8.47% <0.00%> (-0.15%)` | `2.00 <0.00> (ø)` | |
   | 
[...rofile/core/mock/MockStreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tTdHJlYW1Bbm5vdGF0aW9uTGlzdGVuZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `1.20%`.
   > The diff coverage is `32.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   48.99%   -1.21% 
   + Complexity 2700 2697   -3 
   
 Files   746  756  +10 
 Lines 1836318637 +274 
 Branches   1778 1808  +30 
   
   - Hits   9218 9131  -87 
   - Misses 8408 8771 +363 
   + Partials737  735   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `58.46% <ø> (-0.94%)` | `11.00 <0.00> (-1.00)` | |
   | 
[...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=)
 | `8.47% <0.00%> (-0.15%)` | `2.00 <0.00> (ø)` | |
   | 
[...rofile/core/mock/MockStreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tTdHJlYW1Bbm5vdGF0aW9uTGlzdGVuZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 160  -586 
 Lines 183633908-14455 
 Branches   1778 467 -1311 
   
   - Hits   9218   0 -9218 
   + Misses 84083908 -4500 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [684 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 158  -588 
 Lines 183633896-14467 
 Branches   1778 467 -1311 
   
   - Hits   9218   0 -9218 
   + Misses 84083896 -4512 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [684 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 157  -589 
 Lines 183633891-14472 
 Branches   1778 467 -1311 
   
   - Hits   9218   0 -9218 
   + Misses 84083891 -4517 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [685 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 155  -591 
 Lines 183633855-14508 
 Branches   1778 462 -1316 
   
   - Hits   9218   0 -9218 
   + Misses 84083855 -4553 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [687 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] kezhenxu94 commented on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


kezhenxu94 commented on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636626544


   > > @dmsolr a reminder, POJOS that are serialized or deserialized should not 
have fluent accessors, they must have `get`/`set` prefixes, including the ones 
that are parsed from YAML, so you missed something, `*Matcher`
   > 
   > 
   > 
   > *Matcher have to have get/set prefixes else?
   
   They are used to parse the YAML, so yes



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] dmsolr commented on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


dmsolr commented on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636625902


   > @dmsolr a reminder, POJOS that are serialized or deserialized should not 
have fluent accessors, they must have `get`/`set` prefixes, including the ones 
that are parsed from YAML, so you missed something, `*Matcher`
   
   *Matcher have to have get/set prefixes else?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `1.20%`.
   > The diff coverage is `32.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   48.99%   -1.21% 
   + Complexity 2700 2697   -3 
   
 Files   746  756  +10 
 Lines 1836318637 +274 
 Branches   1778 1808  +30 
   
   - Hits   9218 9131  -87 
   - Misses 8408 8771 +363 
   + Partials737  735   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `58.46% <ø> (-0.94%)` | `11.00 <0.00> (-1.00)` | |
   | 
[...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=)
 | `8.47% <0.00%> (-0.15%)` | `2.00 <0.00> (ø)` | |
   | 
[...rofile/core/mock/MockStreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tTdHJlYW1Bbm5vdGF0aW9uTGlzdGVuZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 

[GitHub] [skywalking] kezhenxu94 commented on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


kezhenxu94 commented on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636624996


   @dmsolr a reminder, POJOS that are serialized or deserialized should not 
have fluent accessors, they must have `get`/`set` prefixes, including the ones 
that are parsed from YAML, so you missed something, `*Matcher`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `1.54%`.
   > The diff coverage is `32.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   48.65%   -1.55% 
   + Complexity 2700 2678  -22 
   
 Files   746  754   +8 
 Lines 1836318631 +268 
 Branches   1778 1808  +30 
   
   - Hits   9218 9065 -153 
   - Misses 8408 8840 +432 
   + Partials737  726  -11 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `58.46% <ø> (-0.94%)` | `11.00 <0.00> (-1.00)` | |
   | 
[...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=)
 | `8.47% <0.00%> (-0.15%)` | `2.00 <0.00> (ø)` | |
   | 
[...rofile/core/mock/MockStreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tTdHJlYW1Bbm5vdGF0aW9uTGlzdGVuZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `2.17%`.
   > The diff coverage is `28.60%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   48.02%   -2.18% 
   + Complexity 2700 2640  -60 
   
 Files   746  754   +8 
 Lines 1836318631 +268 
 Branches   1778 1808  +30 
   
   - Hits   9218 8947 -271 
   - Misses 8408 8958 +550 
   + Partials737  726  -11 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `58.46% <ø> (-0.94%)` | `11.00 <0.00> (-1.00)` | |
   | 
[...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-79.84%)` | `3.00 <0.00> (-6.00)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-93.75%)` | `0.00 <0.00> (-12.00)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `1.31%`.
   > The diff coverage is `32.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   48.88%   -1.32% 
   + Complexity 2700 2689  -11 
   
 Files   746  756  +10 
 Lines 1836318637 +274 
 Branches   1778 1808  +30 
   
   - Hits   9218 9111 -107 
   - Misses 8408 8792 +384 
   + Partials737  734   -3 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `58.46% <ø> (-0.94%)` | `11.00 <0.00> (-1.00)` | |
   | 
[...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=)
 | `8.47% <0.00%> (-0.15%)` | `2.00 <0.00> (ø)` | |
   | 
[...rofile/core/mock/MockStreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tTdHJlYW1Bbm5vdGF0aW9uTGlzdGVuZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 

[skywalking] branch ui-template updated (79c14a1 -> 76057c0)

2020-05-31 Thread daming
This is an automated email from the ASF dual-hosted git repository.

daming pushed a change to branch ui-template
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


from 79c14a1  Fix E2E test
 add 76057c0  fix e2e test

No new revisions were added by this update.

Summary of changes:
 .../skywalking/e2e/dashboard/DashboardConfiguration.java  |  2 --
 .../e2e/dashboard/DashboardConfigurationMatcher.java  | 10 +-
 .../skywalking/e2e/dashboard/DashboardConfigurations.java |  4 +---
 .../e2e/dashboard/DashboardConfigurationsMatcher.java | 11 +++
 4 files changed, 13 insertions(+), 14 deletions(-)



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `1.29%`.
   > The diff coverage is `32.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   48.90%   -1.30% 
   + Complexity 2700 2689  -11 
   
 Files   746  754   +8 
 Lines 1836318631 +268 
 Branches   1778 1808  +30 
   
   - Hits   9218 9111 -107 
   - Misses 8408 8786 +378 
   + Partials737  734   -3 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `58.46% <ø> (-0.94%)` | `11.00 <0.00> (-1.00)` | |
   | 
[...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=)
 | `8.47% <0.00%> (-0.15%)` | `2.00 <0.00> (ø)` | |
   | 
[...rofile/core/mock/MockStreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tTdHJlYW1Bbm5vdGF0aW9uTGlzdGVuZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `3.06%`.
   > The diff coverage is `26.03%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   47.13%   -3.07% 
   + Complexity 2700 2561 -139 
   
 Files   746  738   -8 
 Lines 1836318221 -142 
 Branches   1778 1774   -4 
   
   - Hits   9218 8589 -629 
   - Misses 8408 8933 +525 
   + Partials737  699  -38 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `57.69% <ø> (-1.71%)` | `10.00 <0.00> (-2.00)` | |
   | 
[...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-79.84%)` | `3.00 <0.00> (-6.00)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-93.75%)` | `0.00 <0.00> (-12.00)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `2.34%`.
   > The diff coverage is `28.60%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   47.85%   -2.35% 
   + Complexity 2700 2632  -68 
   
 Files   746  754   +8 
 Lines 1836318631 +268 
 Branches   1778 1808  +30 
   
   - Hits   9218 8916 -302 
   - Misses 8408 8996 +588 
   + Partials737  719  -18 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `57.69% <ø> (-1.71%)` | `10.00 <0.00> (-2.00)` | |
   | 
[...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-79.84%)` | `3.00 <0.00> (-6.00)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-93.75%)` | `0.00 <0.00> (-12.00)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `6.07%`.
   > The diff coverage is `23.45%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   44.11%   -6.08% 
   + Complexity 2700 2427 -273 
   
 Files   746  738   -8 
 Lines 1836318221 -142 
 Branches   1778 1774   -4 
   
   - Hits   9218 8039-1179 
   - Misses 8408 9532+1124 
   + Partials737  650  -87 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...storage/plugin/influxdb/InfluxStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9JbmZsdXhTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-79.84%)` | `3.00 <0.00> (-6.00)` | |
   | 
[...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-4.00)` | |
   | 
[...er/storage/plugin/influxdb/base/ManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL01hbmFnZW1lbnREQU8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `0.00% <ø> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `3.03%`.
   > The diff coverage is `26.03%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   47.15%   -3.04% 
   + Complexity 2700 2562 -138 
   
 Files   746  738   -8 
 Lines 1836318221 -142 
 Branches   1778 1774   -4 
   
   - Hits   9218 8593 -625 
   - Misses 8408 8929 +521 
   + Partials737  699  -38 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `57.69% <ø> (-1.71%)` | `10.00 <0.00> (-2.00)` | |
   | 
[...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-79.84%)` | `3.00 <0.00> (-6.00)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-93.75%)` | `0.00 <0.00> (-12.00)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `9.25%`.
   > The diff coverage is `18.29%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   40.94%   -9.26% 
   + Complexity 2700 2283 -417 
   
 Files   746  738   -8 
 Lines 1836318201 -162 
 Branches   1778 1772   -6 
   
   - Hits   9218 7453-1765 
   - Misses 840810138+1730 
   + Partials737  610 -127 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh)
 | `5.88% <0.00%> (-59.88%)` | `2.00 <0.00> (-7.00)` | |
   | 
[...age/plugin/elasticsearch/base/ManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NYW5hZ2VtZW50RXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-4.00)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `19.61%`.
   > The diff coverage is `18.29%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4843   +/-   ##
   =
   - Coverage 50.19%   30.58%   -19.62% 
   + Complexity 2700 1656 -1044 
   =
 Files   746  738-8 
 Lines 1836318201  -162 
 Branches   1778 1772-6 
   =
   - Hits   9218 5567 -3651 
   - Misses 840812258 +3850 
   + Partials737  376  -361 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh)
 | `5.88% <0.00%> (-59.88%)` | `2.00 <0.00> (-7.00)` | |
   | 
[...age/plugin/elasticsearch/base/ManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NYW5hZ2VtZW50RXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-4.00)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `22.11%`.
   > The diff coverage is `18.04%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4843   +/-   ##
   =
   - Coverage 50.19%   28.08%   -22.12% 
   + Complexity 2700 1560 -1140 
   =
 Files   746  736   -10 
 Lines 1836318154  -209 
 Branches   1778 1771-7 
   =
   - Hits   9218 5098 -4120 
   - Misses 840812711 +4303 
   + Partials737  345  -392 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...erver/core/profile/ProfileTaskMutationService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza011dGF0aW9uU2VydmljZS5qYXZh)
 | `0.00% <0.00%> (-55.11%)` | `0.00 <0.00> (-4.00)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `4.00% <ø> (-52.00%)` | `0.00 <0.00> (-2.00)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh)
 | `5.88% <0.00%> (-59.88%)` | `2.00 <0.00> (-7.00)` | |
   | 
[...age/plugin/elasticsearch/base/ManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NYW5hZ2VtZW50RXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `22.13%`.
   > The diff coverage is `18.04%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4843   +/-   ##
   =
   - Coverage 50.19%   28.06%   -22.14% 
   + Complexity 2700 1560 -1140 
   =
 Files   746  738-8 
 Lines 1836318165  -198 
 Branches   1778 1771-7 
   =
   - Hits   9218 5098 -4120 
   - Misses 840812722 +4314 
   + Partials737  345  -392 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...erver/core/profile/ProfileTaskMutationService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza011dGF0aW9uU2VydmljZS5qYXZh)
 | `0.00% <0.00%> (-55.11%)` | `0.00 <0.00> (-4.00)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `4.00% <ø> (-52.00%)` | `0.00 <0.00> (-2.00)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh)
 | `5.88% <0.00%> (-59.88%)` | `2.00 <0.00> (-7.00)` | |
   | 
[...age/plugin/elasticsearch/base/ManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NYW5hZ2VtZW50RXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `23.23%`.
   > The diff coverage is `17.01%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4843   +/-   ##
   =
   - Coverage 50.19%   26.96%   -23.24% 
   + Complexity 2700 1520 -1180 
   =
 Files   746  735   -11 
 Lines 1836318128  -235 
 Branches   1778 1753   -25 
   =
   - Hits   9218 4888 -4330 
   - Misses 840812893 +4485 
   + Partials737  347  -390 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...erver/core/profile/ProfileTaskMutationService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza011dGF0aW9uU2VydmljZS5qYXZh)
 | `0.00% <0.00%> (-55.11%)` | `0.00 <0.00> (-4.00)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `4.00% <ø> (-52.00%)` | `0.00 <0.00> (-2.00)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh)
 | `5.88% <0.00%> (-59.88%)` | `2.00 <0.00> (-7.00)` | |
   | 
[...age/plugin/elasticsearch/base/ManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NYW5hZ2VtZW50RXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `23.09%`.
   > The diff coverage is `18.04%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4843   +/-   ##
   =
   - Coverage 50.19%   27.10%   -23.10% 
   + Complexity 2700 1524 -1176 
   =
 Files   746  736   -10 
 Lines 1836318151  -212 
 Branches   1778 1771-7 
   =
   - Hits   9218 4919 -4299 
   - Misses 840812887 +4479 
   + Partials737  345  -392 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...erver/core/profile/ProfileTaskMutationService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza011dGF0aW9uU2VydmljZS5qYXZh)
 | `0.00% <0.00%> (-55.11%)` | `0.00 <0.00> (-4.00)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `4.00% <ø> (-52.00%)` | `0.00 <0.00> (-2.00)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh)
 | `5.88% <0.00%> (-59.88%)` | `2.00 <0.00> (-7.00)` | |
   | 
[...age/plugin/elasticsearch/base/ManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NYW5hZ2VtZW50RXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `23.24%`.
   > The diff coverage is `17.01%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4843   +/-   ##
   =
   - Coverage 50.19%   26.95%   -23.25% 
   + Complexity 2700 1522 -1178 
   =
 Files   746  736   -10 
 Lines 1836318151  -212 
 Branches   1778 1771-7 
   =
   - Hits   9218 4893 -4325 
   - Misses 840812913 +4505 
   + Partials737  345  -392 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...erver/core/profile/ProfileTaskMutationService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza011dGF0aW9uU2VydmljZS5qYXZh)
 | `0.00% <0.00%> (-55.11%)` | `0.00 <0.00> (-4.00)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `4.00% <ø> (-52.00%)` | `0.00 <0.00> (-2.00)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh)
 | `5.88% <0.00%> (-59.88%)` | `2.00 <0.00> (-7.00)` | |
   | 
[...age/plugin/elasticsearch/base/ManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NYW5hZ2VtZW50RXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 165  -581 
 Lines 183633929-14434 
 Branches   1778 467 -1311 
   
   - Hits   9218   0 -9218 
   + Misses 84083929 -4479 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [679 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 159  -587 
 Lines 183633892-14471 
 Branches   1778 463 -1315 
   
   - Hits   9218   0 -9218 
   + Misses 84083892 -4516 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [685 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 158  -588 
 Lines 183633887-14476 
 Branches   1778 463 -1315 
   
   - Hits   9218   0 -9218 
   + Misses 84083887 -4521 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [686 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 148  -598 
 Lines 183633714-14649 
 Branches   1778 444 -1334 
   
   - Hits   9218   0 -9218 
   + Misses 84083714 -4694 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [693 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 164  -582 
 Lines 183633925-14438 
 Branches   1778 467 -1311 
   
   - Hits   9218   0 -9218 
   + Misses 84083925 -4483 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [680 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 164  -582 
 Lines 183633925-14438 
 Branches   1778 467 -1311 
   
   - Hits   9218   0 -9218 
   + Misses 84083925 -4483 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [680 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 164  -582 
 Lines 183633925-14438 
 Branches   1778 467 -1311 
   
   - Hits   9218   0 -9218 
   + Misses 84083925 -4483 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [680 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[skywalking] branch ui-template updated (07e3674 -> 79c14a1)

2020-05-31 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a change to branch ui-template
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


from 07e3674  Update 
test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/storage/StorageE2E.java
 add 79c14a1  Fix E2E test

No new revisions were added by this update.

Summary of changes:
 .../query/UITemplateManagementDAOImpl.java |  4 +-
 .../apache/skywalking/e2e/storage/StorageE2E.java  | 48 ++
 ...after.yml => dashboardConfiguration-change.yml} |  2 +-
 .../storage/dashboardConfiguration-disable.yml |  2 +-
 4 files changed, 35 insertions(+), 21 deletions(-)
 rename 
test/e2e/e2e-test/src/test/resources/expected/storage/{dashboardConfiguration-after.yml
 => dashboardConfiguration-change.yml} (97%)



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 162  -584 
 Lines 183633919-1 
 Branches   1778 467 -1311 
   
   - Hits   9218   0 -9218 
   + Misses 84083919 -4489 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [682 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 160  -586 
 Lines 183633908-14455 
 Branches   1778 467 -1311 
   
   - Hits   9218   0 -9218 
   + Misses 84083908 -4500 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [684 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


wu-sheng commented on a change in pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#discussion_r433045784



##
File path: 
test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/storage/StorageE2E.java
##
@@ -156,6 +167,54 @@ void serviceInstanceTopo() throws Exception {
 verifyServiceInstanceRelationMetrics(topology.getCalls());
 }
 
+@RetryableTest
+void addUITemplate() throws Exception {
+try {
+TemplateChangeStatus templateChangeStatus = graphql.addTemplate(
+new DashboardSetting()
+.name("test-ui-config-1")
+.active(true)
+.configuration("{}")
+.type(TemplateType.DASHBOARD)
+);
+LOGGER.info("add template = {}", templateChangeStatus);
+} catch (Exception e) {
+LOGGER.error("add ui template error.", e);
+}
+verifyTemplates("expected/storage/dashboardConfiguration.yml");
+}
+
+@RetryableTest
+void changeTemplate() throws Exception {

Review comment:
   I don't want to discuss about the language culture thing, as these two 
words are not that different. You could argue about add, insert or create too. 
As creating is a part of CRUD. 
   
   The point is, unless we want to set up term rules in order to keep all names 
consistent in the project, don't know how to say which one is better.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 160  -586 
 Lines 183633908-14455 
 Branches   1778 467 -1311 
   
   - Hits   9218   0 -9218 
   + Misses 84083908 -4500 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [684 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 159  -587 
 Lines 183633903-14460 
 Branches   1778 467 -1311 
   
   - Hits   9218   0 -9218 
   + Misses 84083903 -4505 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [685 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 155  -591 
 Lines 183633855-14508 
 Branches   1778 462 -1316 
   
   - Hits   9218   0 -9218 
   + Misses 84083855 -4553 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [687 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 157  -589 
 Lines 183633891-14472 
 Branches   1778 467 -1311 
   
   - Hits   9218   0 -9218 
   + Misses 84083891 -4517 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [685 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 149  -597 
 Lines 183633723-14640 
 Branches   1778 454 -1324 
   
   - Hits   9218   0 -9218 
   + Misses 84083723 -4685 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [691 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


kezhenxu94 commented on a change in pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#discussion_r433043929



##
File path: 
test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/storage/StorageE2E.java
##
@@ -156,6 +167,54 @@ void serviceInstanceTopo() throws Exception {
 verifyServiceInstanceRelationMetrics(topology.getCalls());
 }
 
+@RetryableTest
+void addUITemplate() throws Exception {
+try {
+TemplateChangeStatus templateChangeStatus = graphql.addTemplate(
+new DashboardSetting()
+.name("test-ui-config-1")
+.active(true)
+.configuration("{}")
+.type(TemplateType.DASHBOARD)
+);
+LOGGER.info("add template = {}", templateChangeStatus);
+} catch (Exception e) {
+LOGGER.error("add ui template error.", e);
+}
+verifyTemplates("expected/storage/dashboardConfiguration.yml");
+}
+
+@RetryableTest
+void changeTemplate() throws Exception {

Review comment:
   Seems this case depends on `addUITemplate`, it's a bad idea that one 
test case depends on another, please add an individual template in this case 
for testing modification (`changeTemplate`), BTW, I'm wondering whether 
`updateTemplate` in the backend query plugin is better or not, `update` is more 
widely used in the `CRUD` operations @wu-sheng `change` is somewhat Chinglish





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


kezhenxu94 commented on a change in pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#discussion_r433043929



##
File path: 
test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/storage/StorageE2E.java
##
@@ -156,6 +167,54 @@ void serviceInstanceTopo() throws Exception {
 verifyServiceInstanceRelationMetrics(topology.getCalls());
 }
 
+@RetryableTest
+void addUITemplate() throws Exception {
+try {
+TemplateChangeStatus templateChangeStatus = graphql.addTemplate(
+new DashboardSetting()
+.name("test-ui-config-1")
+.active(true)
+.configuration("{}")
+.type(TemplateType.DASHBOARD)
+);
+LOGGER.info("add template = {}", templateChangeStatus);
+} catch (Exception e) {
+LOGGER.error("add ui template error.", e);
+}
+verifyTemplates("expected/storage/dashboardConfiguration.yml");
+}
+
+@RetryableTest
+void changeTemplate() throws Exception {

Review comment:
   Seems this case depends on `addUITemplate`, it's a bad idea that one 
test case depends on another, please add an individual template in this case 
for testing modification (`changeTemplate`), BTW, I'm wondering whether 
`updateTemplate` in the backend query plugin is better or not, `update` is more 
widely used in the `CRUD` operations @wu-sheng 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[skywalking] branch ui-template updated (6a53b86 -> 07e3674)

2020-05-31 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a change to branch ui-template
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


from 6a53b86  fix e2e
 add 07e3674  Update 
test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/storage/StorageE2E.java

No new revisions were added by this update.

Summary of changes:
 .../src/test/java/org/apache/skywalking/e2e/storage/StorageE2E.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **increase** coverage by `0.21%`.
   > The diff coverage is `38.66%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   + Coverage 50.19%   50.40%   +0.21% 
   - Complexity 2700 2704   +4 
   
 Files   746 1328 +582 
 Lines 1836328969   +10606 
 Branches   1778 3157+1379 
   
   + Hits   921814603+5385 
   - Misses 840813686+5278 
   + Partials737  680  -57 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[.../oap/server/core/query/input/DashboardSetting.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvaW5wdXQvRGFzaGJvYXJkU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/core/query/type/DashboardConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvdHlwZS9EYXNoYm9hcmRDb25maWd1cmF0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...alking/oap/query/graphql/GraphQLQueryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL0dyYXBoUUxRdWVyeVByb3ZpZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ry/graphql/resolver/UIConfigurationManagement.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL1VJQ29uZmlndXJhdGlvbk1hbmFnZW1lbnQuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [936 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full 

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


kezhenxu94 commented on a change in pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#discussion_r433043202



##
File path: 
test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/storage/StorageE2E.java
##
@@ -156,6 +167,54 @@ void serviceInstanceTopo() throws Exception {
 verifyServiceInstanceRelationMetrics(topology.getCalls());
 }
 
+@RetryableTest
+void addUITemplate() throws Exception {

Review comment:
   The `template`-related operations should not be retryable, it should be 
successful or failed at one time. 
   
   ```suggestion
   @Test
   void addUITemplate() throws Exception {
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **increase** coverage by `0.21%`.
   > The diff coverage is `38.66%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   + Coverage 50.19%   50.40%   +0.21% 
   - Complexity 2700 2704   +4 
   
 Files   746 1328 +582 
 Lines 1836328969   +10606 
 Branches   1778 3157+1379 
   
   + Hits   921814603+5385 
   - Misses 840813686+5278 
   + Partials737  680  -57 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[.../oap/server/core/query/input/DashboardSetting.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvaW5wdXQvRGFzaGJvYXJkU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/core/query/type/DashboardConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvdHlwZS9EYXNoYm9hcmRDb25maWd1cmF0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...alking/oap/query/graphql/GraphQLQueryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL0dyYXBoUUxRdWVyeVByb3ZpZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ry/graphql/resolver/UIConfigurationManagement.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL1VJQ29uZmlndXJhdGlvbk1hbmFnZW1lbnQuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [936 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `1.21%`.
   > The diff coverage is `32.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   48.98%   -1.22% 
   - Complexity 2700 2704   +4 
   
 Files   746  758  +12 
 Lines 1836318680 +317 
 Branches   1778 1809  +31 
   
   - Hits   9218 9150  -68 
   - Misses 8408 8795 +387 
   + Partials737  735   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `57.69% <ø> (-1.71%)` | `10.00 <0.00> (-2.00)` | |
   | 
[...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=)
 | `8.47% <0.00%> (-0.15%)` | `2.00 <0.00> (ø)` | |
   | 
[...rofile/core/mock/MockStreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tTdHJlYW1Bbm5vdGF0aW9uTGlzdGVuZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `1.20%`.
   > The diff coverage is `32.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   48.99%   -1.21% 
   - Complexity 2700 2704   +4 
   
 Files   746  757  +11 
 Lines 1836318676 +313 
 Branches   1778 1809  +31 
   
   - Hits   9218 9150  -68 
   - Misses 8408 8791 +383 
   + Partials737  735   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `57.69% <ø> (-1.71%)` | `10.00 <0.00> (-2.00)` | |
   | 
[...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=)
 | `8.47% <0.00%> (-0.15%)` | `2.00 <0.00> (ø)` | |
   | 
[...rofile/core/mock/MockStreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tTdHJlYW1Bbm5vdGF0aW9uTGlzdGVuZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `1.20%`.
   > The diff coverage is `32.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   48.99%   -1.21% 
   - Complexity 2700 2704   +4 
   
 Files   746  757  +11 
 Lines 1836318676 +313 
 Branches   1778 1809  +31 
   
   - Hits   9218 9150  -68 
   - Misses 8408 8791 +383 
   + Partials737  735   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `57.69% <ø> (-1.71%)` | `10.00 <0.00> (-2.00)` | |
   | 
[...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=)
 | `8.47% <0.00%> (-0.15%)` | `2.00 <0.00> (ø)` | |
   | 
[...rofile/core/mock/MockStreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tTdHJlYW1Bbm5vdGF0aW9uTGlzdGVuZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `1.21%`.
   > The diff coverage is `32.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   48.98%   -1.22% 
   - Complexity 2700 2703   +3 
   
 Files   746  757  +11 
 Lines 1836318676 +313 
 Branches   1778 1809  +31 
   
   - Hits   9218 9148  -70 
   - Misses 8408 8792 +384 
   + Partials737  736   -1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `57.69% <ø> (-1.71%)` | `10.00 <0.00> (-2.00)` | |
   | 
[...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=)
 | `8.47% <0.00%> (-0.15%)` | `2.00 <0.00> (ø)` | |
   | 
[...rofile/core/mock/MockStreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tTdHJlYW1Bbm5vdGF0aW9uTGlzdGVuZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `1.20%`.
   > The diff coverage is `32.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   48.99%   -1.21% 
   - Complexity 2700 2703   +3 
   
 Files   746  757  +11 
 Lines 1836318669 +306 
 Branches   1778 1795  +17 
   
   - Hits   9218 9146  -72 
   - Misses 8408 8786 +378 
 Partials737  737  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `57.69% <ø> (-1.71%)` | `10.00 <0.00> (-2.00)` | |
   | 
[...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=)
 | `8.47% <0.00%> (-0.15%)` | `2.00 <0.00> (ø)` | |
   | 
[...rofile/core/mock/MockStreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tTdHJlYW1Bbm5vdGF0aW9uTGlzdGVuZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `1.17%`.
   > The diff coverage is `32.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   49.01%   -1.18% 
   - Complexity 2700 2703   +3 
   
 Files   746  755   +9 
 Lines 1836318658 +295 
 Branches   1778 1795  +17 
   
   - Hits   9218 9146  -72 
   - Misses 8408 8775 +367 
 Partials737  737  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `57.69% <ø> (-1.71%)` | `10.00 <0.00> (-2.00)` | |
   | 
[...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=)
 | `8.47% <0.00%> (-0.15%)` | `2.00 <0.00> (ø)` | |
   | 
[...rofile/core/mock/MockStreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tTdHJlYW1Bbm5vdGF0aW9uTGlzdGVuZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `1.81%`.
   > The diff coverage is `28.60%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   48.38%   -1.82% 
   + Complexity 2700 2665  -35 
   
 Files   746  755   +9 
 Lines 1836318658 +295 
 Branches   1778 1795  +17 
   
   - Hits   9218 9028 -190 
   - Misses 8408 8893 +485 
 Partials737  737  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `57.69% <ø> (-1.71%)` | `10.00 <0.00> (-2.00)` | |
   | 
[...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-79.84%)` | `3.00 <0.00> (-6.00)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-93.75%)` | `0.00 <0.00> (-12.00)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `1.79%`.
   > The diff coverage is `28.60%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   48.40%   -1.80% 
   + Complexity 2700 2665  -35 
   
 Files   746  753   +7 
 Lines 1836318652 +289 
 Branches   1778 1795  +17 
   
   - Hits   9218 9028 -190 
   - Misses 8408 8887 +479 
 Partials737  737  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `57.69% <ø> (-1.71%)` | `10.00 <0.00> (-2.00)` | |
   | 
[...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-79.84%)` | `3.00 <0.00> (-6.00)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-93.75%)` | `0.00 <0.00> (-12.00)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `3.24%`.
   > The diff coverage is `28.60%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   46.95%   -3.25% 
   + Complexity 2700 2625  -75 
   
 Files   746  753   +7 
 Lines 1836318652 +289 
 Branches   1778 1795  +17 
   
   - Hits   9218 8758 -460 
   - Misses 8408 9187 +779 
   + Partials737  707  -30 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `15.38% <ø> (-44.02%)` | `4.00 <0.00> (-8.00)` | |
   | 
[...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-79.84%)` | `3.00 <0.00> (-6.00)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-93.75%)` | `0.00 <0.00> (-12.00)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `3.49%`.
   > The diff coverage is `28.60%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   46.70%   -3.50% 
   + Complexity 2700 2613  -87 
   
 Files   746  753   +7 
 Lines 1836318652 +289 
 Branches   1778 1795  +17 
   
   - Hits   9218 8712 -506 
   - Misses 8408 9241 +833 
   + Partials737  699  -38 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `15.38% <ø> (-44.02%)` | `4.00 <0.00> (-8.00)` | |
   | 
[...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-79.84%)` | `3.00 <0.00> (-6.00)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-93.75%)` | `0.00 <0.00> (-12.00)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `4.29%`.
   > The diff coverage is `28.60%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   45.90%   -4.30% 
   + Complexity 2700 2592 -108 
   
 Files   746  753   +7 
 Lines 1836318652 +289 
 Branches   1778 1795  +17 
   
   - Hits   9218 8562 -656 
   - Misses 8408 9393 +985 
   + Partials737  697  -40 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `15.38% <ø> (-44.02%)` | `4.00 <0.00> (-8.00)` | |
   | 
[...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-79.84%)` | `3.00 <0.00> (-6.00)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-93.75%)` | `0.00 <0.00> (-12.00)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `4.38%`.
   > The diff coverage is `27.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   45.81%   -4.39% 
   + Complexity 2700 2590 -110 
   
 Files   746  753   +7 
 Lines 1836318652 +289 
 Branches   1778 1795  +17 
   
   - Hits   9218 8545 -673 
   - Misses 8408 9410+1002 
   + Partials737  697  -40 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `15.38% <ø> (-44.02%)` | `4.00 <0.00> (-8.00)` | |
   | 
[...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-79.84%)` | `3.00 <0.00> (-6.00)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-93.75%)` | `0.00 <0.00> (-12.00)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `7.34%`.
   > The diff coverage is `27.36%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   42.85%   -7.35% 
   + Complexity 2700 2472 -228 
   
 Files   746  753   +7 
 Lines 1836318602 +239 
 Branches   1778 1793  +15 
   
   - Hits   9218 7971-1247 
   - Misses 8408 9981+1573 
   + Partials737  650  -87 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...erver/core/profile/ProfileTaskMutationService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza011dGF0aW9uU2VydmljZS5qYXZh)
 | `0.00% <0.00%> (-55.11%)` | `0.00 <0.00> (-4.00)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `4.00% <ø> (-52.00%)` | `0.00 <0.00> (-2.00)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `15.38% <ø> (-44.02%)` | `4.00 <0.00> (-8.00)` | |
   | 
[...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-79.84%)` | `3.00 <0.00> (-6.00)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-93.75%)` | `0.00 <0.00> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `7.31%`.
   > The diff coverage is `27.36%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   42.88%   -7.32% 
   + Complexity 2700 2472 -228 
   
 Files   746  752   +6 
 Lines 1836318586 +223 
 Branches   1778 1789  +11 
   
   - Hits   9218 7971-1247 
   - Misses 8408 9965+1557 
   + Partials737  650  -87 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...erver/core/profile/ProfileTaskMutationService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza011dGF0aW9uU2VydmljZS5qYXZh)
 | `0.00% <0.00%> (-55.11%)` | `0.00 <0.00> (-4.00)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `4.00% <ø> (-52.00%)` | `0.00 <0.00> (-2.00)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `15.38% <ø> (-44.02%)` | `4.00 <0.00> (-8.00)` | |
   | 
[...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-79.84%)` | `3.00 <0.00> (-6.00)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-93.75%)` | `0.00 <0.00> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `7.22%`.
   > The diff coverage is `27.36%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   42.97%   -7.23% 
   + Complexity 2700 2472 -228 
   
 Files   746  751   +5 
 Lines 1836318547 +184 
 Branches   1778 1788  +10 
   
   - Hits   9218 7971-1247 
   - Misses 8408 9926+1518 
   + Partials737  650  -87 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...erver/core/profile/ProfileTaskMutationService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza011dGF0aW9uU2VydmljZS5qYXZh)
 | `0.00% <0.00%> (-55.11%)` | `0.00 <0.00> (-4.00)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `4.00% <ø> (-52.00%)` | `0.00 <0.00> (-2.00)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `15.38% <ø> (-44.02%)` | `4.00 <0.00> (-8.00)` | |
   | 
[...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-79.84%)` | `3.00 <0.00> (-6.00)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-93.75%)` | `0.00 <0.00> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `7.86%`.
   > The diff coverage is `23.88%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   42.33%   -7.87% 
   + Complexity 2700 2439 -261 
   
 Files   746  750   +4 
 Lines 1836318521 +158 
 Branches   1778 1788  +10 
   
   - Hits   9218 7840-1378 
   - Misses 840810036+1628 
   + Partials737  645  -92 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...erver/core/profile/ProfileTaskMutationService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza011dGF0aW9uU2VydmljZS5qYXZh)
 | `0.00% <0.00%> (-55.11%)` | `0.00 <0.00> (-4.00)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `4.00% <ø> (-52.00%)` | `0.00 <0.00> (-2.00)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh)
 | `14.86% <0.00%> (-50.89%)` | `3.00 <0.00> (-6.00)` | |
   | 
[...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-4.00)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `15.38% <ø> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `7.92%`.
   > The diff coverage is `23.88%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   - Coverage 50.19%   42.27%   -7.93% 
   + Complexity 2700 2439 -261 
   
 Files   746  751   +5 
 Lines 1836318547 +184 
 Branches   1778 1788  +10 
   
   - Hits   9218 7840-1378 
   - Misses 840810062+1654 
   + Partials737  645  -92 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...erver/core/profile/ProfileTaskMutationService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza011dGF0aW9uU2VydmljZS5qYXZh)
 | `0.00% <0.00%> (-55.11%)` | `0.00 <0.00> (-4.00)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `4.00% <ø> (-52.00%)` | `0.00 <0.00> (-2.00)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh)
 | `14.86% <0.00%> (-50.89%)` | `3.00 <0.00> (-6.00)` | |
   | 
[...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-4.00)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `15.38% <ø> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `23.27%`.
   > The diff coverage is `17.01%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4843   +/-   ##
   =
   - Coverage 50.19%   26.92%   -23.28% 
   + Complexity 2700 1513 -1187 
   =
 Files   746  733   -13 
 Lines 1836318097  -266 
 Branches   1778 1753   -25 
   =
   - Hits   9218 4872 -4346 
   - Misses 840812889 +4481 
   + Partials737  336  -401 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...erver/core/profile/ProfileTaskMutationService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza011dGF0aW9uU2VydmljZS5qYXZh)
 | `0.00% <0.00%> (-55.11%)` | `0.00 <0.00> (-4.00)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `4.00% <ø> (-52.00%)` | `0.00 <0.00> (-2.00)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh)
 | `5.88% <0.00%> (-59.88%)` | `2.00 <0.00> (-7.00)` | |
   | 
[...age/plugin/elasticsearch/base/ManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NYW5hZ2VtZW50RXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 157  -589 
 Lines 183633861-14502 
 Branches   1778 463 -1315 
   
   - Hits   9218   0 -9218 
   + Misses 84083861 -4547 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [687 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 155  -591 
 Lines 183633849-14514 
 Branches   1778 463 -1315 
   
   - Hits   9218   0 -9218 
   + Misses 84083849 -4559 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [687 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4843   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 148  -598 
 Lines 183633714-14649 
 Branches   1778 444 -1334 
   
   - Hits   9218   0 -9218 
   + Misses 84083714 -4694 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [693 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4843: Support UI template management.

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#issuecomment-636055964


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=h1) 
Report
   > Merging 
[#4843](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **increase** coverage by `0.22%`.
   > The diff coverage is `38.66%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4843/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4843  +/-   ##
   
   + Coverage 50.19%   50.42%   +0.22% 
   - Complexity 2700 2702   +2 
   
 Files   746 1327 +581 
 Lines 1836328959   +10596 
 Branches   1778 3157+1379 
   
   + Hits   921814602+5384 
   - Misses 840813677+5269 
   + Partials737  680  -57 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4843?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=)
 | `91.66% <ø> (ø)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/core/analysis/management/ManagementData.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFuYWdlbWVudC9NYW5hZ2VtZW50RGF0YS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh)
 | `56.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[.../oap/server/core/query/input/DashboardSetting.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvaW5wdXQvRGFzaGJvYXJkU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/core/query/type/DashboardConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvdHlwZS9EYXNoYm9hcmRDb25maWd1cmF0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/core/storage/annotation/Column.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL0NvbHVtbi5qYXZh)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...alking/oap/query/graphql/GraphQLQueryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL0dyYXBoUUxRdWVyeVByb3ZpZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ry/graphql/resolver/UIConfigurationManagement.java](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL1VJQ29uZmlndXJhdGlvbk1hbmFnZW1lbnQuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [936 
more](https://codecov.io/gh/apache/skywalking/pull/4843/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full 

[skywalking] branch ui-template updated (b5a3f22 -> 6a53b86)

2020-05-31 Thread daming
This is an automated email from the ASF dual-hosted git repository.

daming pushed a change to branch ui-template
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


from b5a3f22  fix e2e
 add 2bf6629  e2e
 add 2852863  update
 add be873da  update
 add a2879a2  update
 add d4f0a1b  use name as ID
 add 3b48962  revert
 add a3d4e62  update
 add 41e5c53  update
 add 569dbd6  update
 add 9c27aae  update
 add 336b9ec  update
 add e804732  ??
 add 4cefbfc  fix
 add 99f09a8  update
 add 22c52e8  update
 add 5363350  store
 add 6a53b86  fix e2e

No new revisions were added by this update.

Summary of changes:
 .../query/UITemplateManagementDAOImpl.java |  2 +-
 .../e2e/UIConfigurationManagementClient.java   | 34 ++---
 .../e2e/dashboard/TemplateChangeStatus.java|  2 -
 .../apache/skywalking/e2e/storage/StorageE2E.java  | 59 +-
 4 files changed, 51 insertions(+), 46 deletions(-)



[GitHub] [skywalking] zhaoyuguang commented on issue #4841: Customize enhance plugin extensions

2020-05-31 Thread GitBox


zhaoyuguang commented on issue #4841:
URL: https://github.com/apache/skywalking/issues/4841#issuecomment-636594829


   That sounds good!
   
   it would probably be great in the following scenarios if implemented. Async 
frameworks, or we don't know much about the underlying framework or the 
framework within our own organization. You can quickly complete the plug-in.
   As for `ref` and `peer`, I think we can make a contract with the user to 
expose some appropriate API, let them fill in the peer in `exit span`, and tell 
`SkyWalking`  how get `ref`. So for synchronized threads, there are a few 
Suggestions for exitspan and entryspan:
   
   `Exit span` needs to add an entry point for input peer and return the 
serialized data to the user contextCarrier.
   `Entry span` needs to add places where the specified user fills in the 
contextCarrier serialized data, and be careful with the batch framework.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] wu-sheng commented on a change in pull request #4847: [WIP]Provide kafka as collector/reporter

2020-05-31 Thread GitBox


wu-sheng commented on a change in pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#discussion_r433023087



##
File path: apm-sniffer/config/agent.config
##
@@ -78,3 +78,6 @@ logging.level=${SW_LOGGING_LEVEL:INFO}
 
 # mysql plugin configuration
 # plugin.mysql.trace_sql_parameters=${SW_MYSQL_TRACE_SQL_PARAMETERS:false}
+
+# Kafka producer configuration
+# 
collector.kafka.bootstrap_servers=${SW_KAFKA_BOOTSTRAP_SERVERS:localhost:9092}

Review comment:
   I think we should share the backend service, and the kafka sender could 
be activated automatically through the same agent plugin activation way(copy).

##
File path: apm-sniffer/pom.xml
##
@@ -32,10 +32,8 @@
 apm-agent
 apm-agent-core
 apm-sdk-plugin
-apm-toolkit-activation

Review comment:
   Why remove toolkit?

##
File path: 
oap-server/server-receiver-plugin/skywalking-mq-receiver-plugins/kafka-receiver-plugin/pom.xml
##
@@ -0,0 +1,48 @@
+
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+skywalking-mq-receiver-plugins
+org.apache.skywalking
+8.0.0-SNAPSHOT
+
+4.0.0
+
+kafka-receiver-plugin
+
+
+
+org.apache.kafka
+kafka-clients
+2.4.1

Review comment:
   Kafka version should be managed in the oap level pom.xml

##
File path: apm-sniffer/optional-producer-plugins/kafka-producer-plugin/pom.xml
##
@@ -0,0 +1,58 @@
+
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+optional-producer-plugins
+org.apache.skywalking
+8.0.0-SNAPSHOT
+
+4.0.0
+
+kafka-producer-plugin
+jar
+
+
+
+org.apache.skywalking
+apm-agent-core
+${project.version}
+provided
+
+
+org.apache.skywalking
+apm-util
+${project.version}
+provided
+
+
+org.apache.skywalking
+apm-test-tools
+${project.version}
+test
+
+
+org.apache.kafka
+kafka-clients
+2.3.1
+provided

Review comment:
   Why this is `provided`? If this is provided, you wouldn't have the 
Kafka-clients at the runtime, as the agent core doesn't include those.

##
File path: apm-sniffer/config/agent.config
##
@@ -78,3 +78,6 @@ logging.level=${SW_LOGGING_LEVEL:INFO}
 
 # mysql plugin configuration
 # plugin.mysql.trace_sql_parameters=${SW_MYSQL_TRACE_SQL_PARAMETERS:false}
+
+# Kafka producer configuration
+# 
collector.kafka.bootstrap_servers=${SW_KAFKA_BOOTSTRAP_SERVERS:localhost:9092}

Review comment:
   From the Config, you have implemented the JVM, trace and profile, so, I 
think when this plugin activated, there is no need to have grpc endpoint, right?

##
File path: apm-sniffer/optional-producer-plugins/pom.xml
##
@@ -0,0 +1,144 @@
+
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+apm-sniffer
+org.apache.skywalking
+8.0.0-SNAPSHOT
+
+4.0.0
+
+optional-producer-plugins
+pom
+
+
+kafka-producer-plugin
+
+
+
+net.bytebuddy
+
${shade.package}.${shade.net.bytebuddy.source}
+UTF-8
+
+
+
${project.build.directory}${sdk.plugin.related.dir}/../../../../skywalking-agent
+
+
${agent.package.dest.dir}/mq-reporter-plugins
+
+1.0b3
+1.8.1
+
+
+
+
+org.apache.skywalking
+apm-agent-core
+${project.version}
+provided
+
+
+org.apache.skywalking
+apm-util
+${project.version}
+provided
+
+
+org.apache.skywalking
+apm-test-tools
+${project.version}
+test
+
+
+
+
+
+
+maven-shade-plugin

Review comment:
   Why shade the bytebuddy?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] wu-sheng commented on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-05-31 Thread GitBox


wu-sheng commented on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-636586920


   I just removed the 8.0.0 milestone in case we can't make it. The plan is 
code freeze in the next week.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] 1HEJIANFENG commented on issue #4444: UI中当前端点不展示内容

2020-05-31 Thread GitBox


1HEJIANFENG commented on issue #:
URL: https://github.com/apache/skywalking/issues/#issuecomment-636586711


   did it matters ?   how to slove it



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] dmsolr opened a new pull request #4847: [WIP]Provide kafka as collector/reporter

2020-05-31 Thread GitBox


dmsolr opened a new pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847


   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [x] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   1. Introduce Kafka as Agent Reporter and OAP Receiver, which are optional 
plugins.
   2. Agent still needs GRPC when it is an interactive case. (Agent get the 
Profile Task List. But `ProfileThreadSnapshot` is reported by MQ)
   3. Currently, it is missing cluster(it is coming soon) and e2e test.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4840: Increased Vert.x support

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840#issuecomment-635855272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=h1) 
Report
   > Merging 
[#4840](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `0.36%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4840/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4840  +/-   ##
   
   - Coverage 50.19%   49.83%   -0.37% 
   + Complexity 2700 2684  -16 
   
 Files   746  745   -1 
 Lines 1836318359   -4 
 Branches   1778 1778  
   
   - Hits   9218 9149  -69 
   - Misses 8408 8478  +70 
   + Partials737  732   -5 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=)
 | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | |
   | 
[...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==)
 | `80.00% <0.00%> (-20.00%)` | `3.00% <0.00%> (-1.00%)` | |
   | 
[.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=)
 | `80.64% <0.00%> (-6.46%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...agent/core/context/OperationNameFormatService.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9PcGVyYXRpb25OYW1lRm9ybWF0U2VydmljZS5qYXZh)
 | `21.73% <0.00%> (-4.35%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=)
 | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
   | 
[...skywalking/apm/agent/core/boot/ServiceManager.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9TZXJ2aWNlTWFuYWdlci5qYXZh)
 | `64.70% <0.00%> (-2.95%)` | `15.00% <0.00%> (-1.00%)` | |
   | 
[...p/server/storage/plugin/influxdb/InfluxClient.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9JbmZsdXhDbGllbnQuamF2YQ==)
 | `60.78% <0.00%> (-1.97%)` | `13.00% <0.00%> (-1.00%)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `56.94% <0.00%> (-1.39%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `58.64% <0.00%> (-0.76%)` | `11.00% <0.00%> (-1.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4840: Increased Vert.x support

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840#issuecomment-635855272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=h1) 
Report
   > Merging 
[#4840](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `0.36%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4840/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4840  +/-   ##
   
   - Coverage 50.19%   49.83%   -0.37% 
   + Complexity 2700 2684  -16 
   
 Files   746  745   -1 
 Lines 1836318359   -4 
 Branches   1778 1778  
   
   - Hits   9218 9149  -69 
   - Misses 8408 8478  +70 
   + Partials737  732   -5 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=)
 | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | |
   | 
[...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==)
 | `80.00% <0.00%> (-20.00%)` | `3.00% <0.00%> (-1.00%)` | |
   | 
[.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=)
 | `80.64% <0.00%> (-6.46%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...agent/core/context/OperationNameFormatService.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9PcGVyYXRpb25OYW1lRm9ybWF0U2VydmljZS5qYXZh)
 | `21.73% <0.00%> (-4.35%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=)
 | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
   | 
[...skywalking/apm/agent/core/boot/ServiceManager.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9TZXJ2aWNlTWFuYWdlci5qYXZh)
 | `64.70% <0.00%> (-2.95%)` | `15.00% <0.00%> (-1.00%)` | |
   | 
[...p/server/storage/plugin/influxdb/InfluxClient.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9JbmZsdXhDbGllbnQuamF2YQ==)
 | `60.78% <0.00%> (-1.97%)` | `13.00% <0.00%> (-1.00%)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `56.94% <0.00%> (-1.39%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `58.64% <0.00%> (-0.76%)` | `11.00% <0.00%> (-1.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4840: Increased Vert.x support

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840#issuecomment-635855272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=h1) 
Report
   > Merging 
[#4840](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `0.36%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4840/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4840  +/-   ##
   
   - Coverage 50.19%   49.83%   -0.37% 
   + Complexity 2700 2684  -16 
   
 Files   746  745   -1 
 Lines 1836318359   -4 
 Branches   1778 1778  
   
   - Hits   9218 9149  -69 
   - Misses 8408 8478  +70 
   + Partials737  732   -5 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=)
 | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | |
   | 
[...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==)
 | `80.00% <0.00%> (-20.00%)` | `3.00% <0.00%> (-1.00%)` | |
   | 
[.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=)
 | `80.64% <0.00%> (-6.46%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...agent/core/context/OperationNameFormatService.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9PcGVyYXRpb25OYW1lRm9ybWF0U2VydmljZS5qYXZh)
 | `21.73% <0.00%> (-4.35%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=)
 | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
   | 
[...skywalking/apm/agent/core/boot/ServiceManager.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9TZXJ2aWNlTWFuYWdlci5qYXZh)
 | `64.70% <0.00%> (-2.95%)` | `15.00% <0.00%> (-1.00%)` | |
   | 
[...p/server/storage/plugin/influxdb/InfluxClient.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9JbmZsdXhDbGllbnQuamF2YQ==)
 | `60.78% <0.00%> (-1.97%)` | `13.00% <0.00%> (-1.00%)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `56.94% <0.00%> (-1.39%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `58.64% <0.00%> (-0.76%)` | `11.00% <0.00%> (-1.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4840: Increased Vert.x support

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840#issuecomment-635855272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=h1) 
Report
   > Merging 
[#4840](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `0.36%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4840/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4840  +/-   ##
   
   - Coverage 50.19%   49.83%   -0.37% 
   + Complexity 2700 2684  -16 
   
 Files   746  745   -1 
 Lines 1836318359   -4 
 Branches   1778 1778  
   
   - Hits   9218 9149  -69 
   - Misses 8408 8478  +70 
   + Partials737  732   -5 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=)
 | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | |
   | 
[...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==)
 | `80.00% <0.00%> (-20.00%)` | `3.00% <0.00%> (-1.00%)` | |
   | 
[.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=)
 | `80.64% <0.00%> (-6.46%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...agent/core/context/OperationNameFormatService.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9PcGVyYXRpb25OYW1lRm9ybWF0U2VydmljZS5qYXZh)
 | `21.73% <0.00%> (-4.35%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=)
 | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
   | 
[...skywalking/apm/agent/core/boot/ServiceManager.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9TZXJ2aWNlTWFuYWdlci5qYXZh)
 | `64.70% <0.00%> (-2.95%)` | `15.00% <0.00%> (-1.00%)` | |
   | 
[...p/server/storage/plugin/influxdb/InfluxClient.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9JbmZsdXhDbGllbnQuamF2YQ==)
 | `60.78% <0.00%> (-1.97%)` | `13.00% <0.00%> (-1.00%)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `56.94% <0.00%> (-1.39%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=)
 | `58.64% <0.00%> (-0.76%)` | `11.00% <0.00%> (-1.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4840: Increased Vert.x support

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840#issuecomment-635855272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=h1) 
Report
   > Merging 
[#4840](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `0.43%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4840/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4840  +/-   ##
   
   - Coverage 50.19%   49.76%   -0.44% 
   + Complexity 2700 2678  -22 
   
 Files   746  745   -1 
 Lines 1836318359   -4 
 Branches   1778 1778  
   
   - Hits   9218 9136  -82 
   - Misses 8408 8488  +80 
   + Partials737  735   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=)
 | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | |
   | 
[...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh)
 | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
   | 
[...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==)
 | `80.00% <0.00%> (-20.00%)` | `3.00% <0.00%> (-1.00%)` | |
   | 
[.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=)
 | `80.64% <0.00%> (-6.46%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...agent/core/context/OperationNameFormatService.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9PcGVyYXRpb25OYW1lRm9ybWF0U2VydmljZS5qYXZh)
 | `21.73% <0.00%> (-4.35%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=)
 | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
   | 
[...skywalking/apm/agent/core/boot/ServiceManager.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9TZXJ2aWNlTWFuYWdlci5qYXZh)
 | `64.70% <0.00%> (-2.95%)` | `15.00% <0.00%> (-1.00%)` | |
   | 
[...p/server/storage/plugin/influxdb/InfluxClient.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9JbmZsdXhDbGllbnQuamF2YQ==)
 | `60.78% <0.00%> (-1.97%)` | `13.00% <0.00%> (-1.00%)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `56.94% <0.00%> (-1.39%)` | `17.00% <0.00%> (-1.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4840: Increased Vert.x support

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840#issuecomment-635855272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=h1) 
Report
   > Merging 
[#4840](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `0.41%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4840/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4840  +/-   ##
   
   - Coverage 50.19%   49.77%   -0.42% 
   + Complexity 2700 2678  -22 
   
 Files   746  743   -3 
 Lines 1836318353  -10 
 Branches   1778 1778  
   
   - Hits   9218 9136  -82 
   - Misses 8408 8482  +74 
   + Partials737  735   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=)
 | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | |
   | 
[...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh)
 | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
   | 
[...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==)
 | `80.00% <0.00%> (-20.00%)` | `3.00% <0.00%> (-1.00%)` | |
   | 
[.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=)
 | `80.64% <0.00%> (-6.46%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...agent/core/context/OperationNameFormatService.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9PcGVyYXRpb25OYW1lRm9ybWF0U2VydmljZS5qYXZh)
 | `21.73% <0.00%> (-4.35%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=)
 | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
   | 
[...skywalking/apm/agent/core/boot/ServiceManager.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9TZXJ2aWNlTWFuYWdlci5qYXZh)
 | `64.70% <0.00%> (-2.95%)` | `15.00% <0.00%> (-1.00%)` | |
   | 
[...p/server/storage/plugin/influxdb/InfluxClient.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9JbmZsdXhDbGllbnQuamF2YQ==)
 | `60.78% <0.00%> (-1.97%)` | `13.00% <0.00%> (-1.00%)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `56.94% <0.00%> (-1.39%)` | `17.00% <0.00%> (-1.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4840: Increased Vert.x support

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840#issuecomment-635855272







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4840: Increased Vert.x support

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840#issuecomment-635855272







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4840: Increased Vert.x support

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840#issuecomment-635855272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=h1) 
Report
   > Merging 
[#4840](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `12.77%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4840/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4840   +/-   ##
   =
   - Coverage 50.19%   37.42%   -12.78% 
   + Complexity 2700 1972  -728 
   =
 Files   746  740-6 
 Lines 1836318303   -60 
 Branches   1778 1777-1 
   =
   - Hits   9218 6849 -2369 
   - Misses 840810957 +2549 
   + Partials737  497  -240 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [152 
more](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree-more)
 | |
   
   --
   
   

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4840: Increased Vert.x support

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840#issuecomment-635855272







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4840: Increased Vert.x support

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840#issuecomment-635855272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=h1) 
Report
   > Merging 
[#4840](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `12.99%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4840/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4840   +/-   ##
   =
   - Coverage 50.19%   37.20%   -13.00% 
   + Complexity 2700 1964  -736 
   =
 Files   746  740-6 
 Lines 1836318303   -60 
 Branches   1778 1777-1 
   =
   - Hits   9218 6809 -2409 
   - Misses 840811005 +2597 
   + Partials737  489  -248 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [155 
more](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree-more)
 | |
   
   --
   
   

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4840: Increased Vert.x support

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840#issuecomment-635855272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=h1) 
Report
   > Merging 
[#4840](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `20.49%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4840/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4840   +/-   ##
   =
   - Coverage 50.19%   29.70%   -20.50% 
   + Complexity 2700 1653 -1047 
   =
 Files   746  740-6 
 Lines 1836318250  -113 
 Branches   1778 1775-3 
   =
   - Hits   9218 5421 -3797 
   - Misses 840812449 +4041 
   + Partials737  380  -357 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [232 
more](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree-more)
 | |
   
   --
   
   

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4840: Increased Vert.x support

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840#issuecomment-635855272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=h1) 
Report
   > Merging 
[#4840](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `17.12%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4840/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4840   +/-   ##
   =
   - Coverage 50.19%   33.07%   -17.13% 
   + Complexity 2700 1820  -880 
   =
 Files   746  740-6 
 Lines 1836318253  -110 
 Branches   1778 1775-3 
   =
   - Hits   9218 6037 -3181 
   - Misses 840811795 +3387 
   + Partials737  421  -316 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [190 
more](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree-more)
 | |
   
   --
   
   

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4840: Increased Vert.x support

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840#issuecomment-635855272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=h1) 
Report
   > Merging 
[#4840](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `22.83%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4840/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4840   +/-   ##
   =
   - Coverage 50.19%   27.36%   -22.84% 
   + Complexity 2700 1513 -1187 
   =
 Files   746  724   -22 
 Lines 1836317836  -527 
 Branches   1778 1740   -38 
   =
   - Hits   9218 4881 -4337 
   - Misses 840812616 +4208 
   + Partials737  339  -398 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [259 
more](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4840: Increased Vert.x support

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840#issuecomment-635855272







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4840: Increased Vert.x support

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840#issuecomment-635855272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=h1) 
Report
   > Merging 
[#4840](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `23.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4840/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4840   +/-   ##
   =
   - Coverage 50.19%   27.05%   -23.15% 
   + Complexity 2700 1497 -1203 
   =
 Files   746  724   -22 
 Lines 1836317830  -533 
 Branches   1778 1728   -50 
   =
   - Hits   9218 4824 -4394 
   - Misses 840812678 +4270 
   + Partials737  328  -409 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [267 
more](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4840: Increased Vert.x support

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840#issuecomment-635855272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=h1) 
Report
   > Merging 
[#4840](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `23.18%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4840/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4840   +/-   ##
   =
   - Coverage 50.19%   27.01%   -23.19% 
   + Complexity 2700 1495 -1205 
   =
 Files   746  724   -22 
 Lines 1836317829  -534 
 Branches   1778 1727   -51 
   =
   - Hits   9218 4817 -4401 
   - Misses 840812682 +4274 
   + Partials737  330  -407 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [270 
more](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4840: Increased Vert.x support

2020-05-31 Thread GitBox


codecov[bot] edited a comment on pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840#issuecomment-635855272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=h1) 
Report
   > Merging 
[#4840](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/deccc262f348949869cebdd4b98c7714974367eb=desc)
 will **decrease** coverage by `50.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4840/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4840   +/-   ##
   
   - Coverage 50.19%   0.00%   -50.20% 
   
 Files   746 160  -586 
 Lines 183633908-14455 
 Branches   1778 467 -1311 
   
   - Hits   9218   0 -9218 
   + Misses 84083908 -4500 
   + Partials737   0  -737 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4840?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [709 
more](https://codecov.io/gh/apache/skywalking/pull/4840/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

  1   2   3   4   5   >