[GitHub] [skywalking] wu-sheng commented on issue #6237: Spring Cloud Gateway support not working on 8.2/8.3/6.6/6.5
wu-sheng commented on issue #6237: URL: https://github.com/apache/skywalking/issues/6237#issuecomment-765211906 > the test case here is not including anything like rewrite url in which case our scenario is not working @ascrutae If you have time, you could give a try. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (19ffa52) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **decrease** coverage by `21.33%`. > The diff coverage is `21.40%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## = - Coverage 50.82% 29.48% -21.34% = Files 1693 1654 -39 Lines 3583834560 -1278 Branches 3963 4567 +604 = - Hits 1821410190 -8024 - Misses1668723426 +6739 - Partials937 944+7 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...lkit/log/log4j/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lkit/log/log4j/v2/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMi54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...it/log/logback/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nYmFjay0xLngvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0NsaWVudEFwcGVuZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00 <0.00> (-1.00)` | | | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `49.42% <0.00%> (-9.88%)` | `0.00 <0.00> (-18.00)` | | | [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `69.06% <0.00%> (-0.72%)` | `0.00 <0.00> (-23.00)` | | | [.../core/plugin/AbstractClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0Fic3RyYWN0Q2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-80.00%)` | `0.00 <0.00> (-7.00)` | | | [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhh
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (bbafda2) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **increase** coverage by `4.98%`. > The diff coverage is `48.12%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## + Coverage 50.82% 55.80% +4.98% - Complexity 3469 3795 +326 Files 1693 944 -749 Lines 3583823451 -12387 Branches 3963 2289-1674 - Hits 1821413088-5126 + Misses16687 9247-7440 - Partials937 1116 +179 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | | | [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: | | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <0.00%> (-19.06%)` | `12.00 <0.00> (ø)` | | | [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `36.36% <0.00%> (-8.09%)` | `3.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `72.72% <0.00%> (-20.38%)` | `28.00 <0.00> (-2.00)` | | | [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [.../configuration/grpc/GRPCConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlnV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `75.00% <ø> (ø)` | `7.00 <0.00> (ø
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (bbafda2) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **increase** coverage by `4.97%`. > The diff coverage is `48.12%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## + Coverage 50.82% 55.80% +4.97% - Complexity 3469 3793 +324 Files 1693 944 -749 Lines 3583823451 -12387 Branches 3963 2289-1674 - Hits 1821413086-5128 + Misses16687 9249-7438 - Partials937 1116 +179 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | | | [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: | | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <0.00%> (-19.06%)` | `12.00 <0.00> (ø)` | | | [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `36.36% <0.00%> (-8.09%)` | `3.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `72.72% <0.00%> (-20.38%)` | `28.00 <0.00> (-2.00)` | | | [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [.../configuration/grpc/GRPCConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlnV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `75.00% <ø> (ø)` | `7.00 <0.00> (ø
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (bbafda2) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **increase** coverage by `4.48%`. > The diff coverage is `48.12%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## + Coverage 50.82% 55.31% +4.48% - Complexity 3469 3773 +304 Files 1693 944 -749 Lines 3583823451 -12387 Branches 3963 2289-1674 - Hits 1821412971-5243 + Misses16687 9371-7316 - Partials937 1109 +172 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | | | [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: | | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <0.00%> (-19.06%)` | `12.00 <0.00> (ø)` | | | [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `36.36% <0.00%> (-8.09%)` | `3.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `72.72% <0.00%> (-20.38%)` | `28.00 <0.00> (-2.00)` | | | [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [.../configuration/grpc/GRPCConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlnV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `75.00% <ø> (ø)` | `7.00 <0.00> (ø
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (bbafda2) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **increase** coverage by `4.46%`. > The diff coverage is `48.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## + Coverage 50.82% 55.28% +4.46% - Complexity 3469 3771 +302 Files 1693 944 -749 Lines 3583823451 -12387 Branches 3963 2289-1674 - Hits 1821412966-5248 + Misses16687 9376-7311 - Partials937 1109 +172 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | | | [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: | | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <0.00%> (-19.06%)` | `12.00 <0.00> (ø)` | | | [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `36.36% <0.00%> (-8.09%)` | `3.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `72.72% <0.00%> (-20.38%)` | `28.00 <0.00> (-2.00)` | | | [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [.../configuration/grpc/GRPCConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlnV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `75.00% <ø> (ø)` | `7.00 <0.00> (ø
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (bbafda2) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **increase** coverage by `4.18%`. > The diff coverage is `47.76%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## + Coverage 50.82% 55.00% +4.18% - Complexity 3469 3744 +275 Files 1693 944 -749 Lines 3583823451 -12387 Branches 3963 2289-1674 - Hits 1821412900-5314 + Misses16687 9450-7237 - Partials937 1101 +164 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `46.59% <0.00%> (-12.72%)` | `17.00 <0.00> (-1.00)` | | | [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `51.91% <0.00%> (-17.87%)` | `25.00 <0.00> (+2.00)` | :arrow_down: | | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `44.44% <0.00%> (-23.51%)` | `11.00 <0.00> (-1.00)` | | | [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `36.36% <0.00%> (-8.09%)` | `3.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `72.72% <0.00%> (-20.38%)` | `28.00 <0.00> (-2.00)` | | | [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [.../configuration/grpc/GRPCConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlnV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `75.00% <ø> (ø)` | `7.00
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (bbafda2) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **increase** coverage by `4.16%`. > The diff coverage is `47.76%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## + Coverage 50.82% 54.98% +4.16% - Complexity 3469 3741 +272 Files 1693 944 -749 Lines 3583823451 -12387 Branches 3963 2289-1674 - Hits 1821412895-5319 + Misses16687 9455-7232 - Partials937 1101 +164 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `46.59% <0.00%> (-12.72%)` | `17.00 <0.00> (-1.00)` | | | [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `51.91% <0.00%> (-17.87%)` | `25.00 <0.00> (+2.00)` | :arrow_down: | | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `44.44% <0.00%> (-23.51%)` | `11.00 <0.00> (-1.00)` | | | [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `36.36% <0.00%> (-8.09%)` | `3.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `72.72% <0.00%> (-20.38%)` | `28.00 <0.00> (-2.00)` | | | [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [.../configuration/grpc/GRPCConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlnV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `75.00% <ø> (ø)` | `7.00
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (bbafda2) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **increase** coverage by `2.16%`. > The diff coverage is `50.07%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## + Coverage 50.82% 52.98% +2.16% + Complexity 3469 2971 -498 Files 1693 794 -899 Lines 3583819878 -15960 Branches 3963 1884-2079 - Hits 1821410533-7681 + Misses16687 8518-8169 + Partials937 827 -110 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00 <0.00> (-1.00)` | | | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `72.72% <0.00%> (-20.38%)` | `28.00 <0.00> (-2.00)` | | | [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | | | [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [.../configuration/grpc/GRPCConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlnV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `75.00% <ø> (ø)` | `7.00 <0.00> (ø)` | | | [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `71.18% <ø> (ø)` | `7.00 <0.00> (ø)` | | | [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (bbafda2) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **increase** coverage by `2.08%`. > The diff coverage is `50.07%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## + Coverage 50.82% 52.90% +2.08% + Complexity 3469 2969 -500 Files 1693 794 -899 Lines 3583819878 -15960 Branches 3963 1884-2079 - Hits 1821410517-7697 + Misses16687 8535-8152 + Partials937 826 -111 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00 <0.00> (-1.00)` | | | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `72.72% <0.00%> (-20.38%)` | `28.00 <0.00> (-2.00)` | | | [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | | | [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [.../configuration/grpc/GRPCConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlnV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `75.00% <ø> (ø)` | `7.00 <0.00> (ø)` | | | [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `71.18% <ø> (ø)` | `7.00 <0.00> (ø)` | | | [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (bbafda2) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **increase** coverage by `1.77%`. > The diff coverage is `50.07%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## + Coverage 50.82% 52.59% +1.77% + Complexity 3469 2953 -516 Files 1693 794 -899 Lines 3583819878 -15960 Branches 3963 1884-2079 - Hits 1821410455-7759 + Misses16687 8600-8087 + Partials937 823 -114 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00 <0.00> (-1.00)` | | | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `72.72% <0.00%> (-20.38%)` | `28.00 <0.00> (-2.00)` | | | [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | | | [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [.../configuration/grpc/GRPCConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlnV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `75.00% <ø> (ø)` | `7.00 <0.00> (ø)` | | | [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `71.18% <ø> (ø)` | `7.00 <0.00> (ø)` | | | [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (bbafda2) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **increase** coverage by `0.28%`. > The diff coverage is `47.91%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## + Coverage 50.82% 51.10% +0.28% + Complexity 3469 2883 -586 Files 1693 794 -899 Lines 3583819850 -15988 Branches 3963 1879-2084 - Hits 1821410144-8070 + Misses16687 8897-7790 + Partials937 809 -128 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00 <0.00> (-1.00)` | | | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `72.72% <0.00%> (-20.38%)` | `28.00 <0.00> (-2.00)` | | | [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | | | [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [.../configuration/grpc/GRPCConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlnV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `75.00% <ø> (ø)` | `7.00 <0.00> (ø)` | | | [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWF
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (bbafda2) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **decrease** coverage by `0.54%`. > The diff coverage is `47.91%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## - Coverage 50.82% 50.27% -0.55% + Complexity 3469 2855 -614 Files 1693 794 -899 Lines 3583819850 -15988 Branches 3963 1879-2084 - Hits 18214 9980-8234 + Misses16687 9076-7611 + Partials937 794 -143 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00 <0.00> (-1.00)` | | | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `72.72% <0.00%> (-20.38%)` | `28.00 <0.00> (-2.00)` | | | [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | | | [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [.../configuration/grpc/GRPCConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlnV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `75.00% <ø> (ø)` | `7.00 <0.00> (ø)` | | | [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWF
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (bbafda2) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **decrease** coverage by `4.22%`. > The diff coverage is `47.91%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## - Coverage 50.82% 46.59% -4.23% + Complexity 3469 2710 -759 Files 1693 794 -899 Lines 3583819814 -16024 Branches 3963 1878-2085 - Hits 18214 9233-8981 + Misses16687 9843-6844 + Partials937 738 -199 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00 <0.00> (-1.00)` | | | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `72.72% <0.00%> (-20.38%)` | `28.00 <0.00> (-2.00)` | | | [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | | | [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [.../configuration/grpc/GRPCConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlnV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `75.00% <ø> (ø)` | `7.00 <0.00> (ø)` | | | [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWF
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
wu-sheng commented on a change in pull request #6243:
URL: https://github.com/apache/skywalking/pull/6243#discussion_r562428868
##
File path:
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/oc/OCMetricHandler.java
##
@@ -107,6 +118,13 @@
return result;
}
+private static Map buildLabelsFromNodeInfo(Node node,
+ Map buildLabelsResult) {
+if (node != null)
+buildLabelsResult.put("node_identifier_host_name",
node.getIdentifier().getHostName());
Review comment:
I am just wondering whether this is the meaning, as it is reported every
time, rather than a separated metric.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (bbafda2) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **decrease** coverage by `4.28%`. > The diff coverage is `47.91%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## - Coverage 50.82% 46.53% -4.29% + Complexity 3469 2704 -765 Files 1693 794 -899 Lines 3583819814 -16024 Branches 3963 1878-2085 - Hits 18214 9221-8993 + Misses16687 9859-6828 + Partials937 734 -203 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00 <0.00> (-1.00)` | | | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `72.72% <0.00%> (-20.38%)` | `28.00 <0.00> (-2.00)` | | | [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | | | [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [.../configuration/grpc/GRPCConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlnV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `75.00% <ø> (ø)` | `7.00 <0.00> (ø)` | | | [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWF
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (bbafda2) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **decrease** coverage by `4.65%`. > The diff coverage is `47.91%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## - Coverage 50.82% 46.17% -4.66% + Complexity 3469 2686 -783 Files 1693 794 -899 Lines 3583819805 -16033 Branches 3963 1863-2100 - Hits 18214 9144-9070 + Misses16687 9926-6761 + Partials937 735 -202 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00 <0.00> (-1.00)` | | | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `72.72% <0.00%> (-20.38%)` | `28.00 <0.00> (-2.00)` | | | [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | | | [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [.../configuration/grpc/GRPCConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlnV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `75.00% <ø> (ø)` | `7.00 <0.00> (ø)` | | | [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWF
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (bbafda2) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **decrease** coverage by `6.28%`. > The diff coverage is `30.35%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## - Coverage 50.82% 44.53% -6.29% + Complexity 3469 2615 -854 Files 1693 794 -899 Lines 3583819805 -16033 Branches 3963 1863-2100 - Hits 18214 8820-9394 + Misses1668710292-6395 + Partials937 693 -244 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00 <0.00> (-1.00)` | | | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `72.72% <0.00%> (-20.38%)` | `28.00 <0.00> (-2.00)` | | | [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | | | [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [.../configuration/grpc/GRPCConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlnV2F0Y2hlclJlZ2lzdGVy
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (bbafda2) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **decrease** coverage by `7.08%`. > The diff coverage is `30.35%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## - Coverage 50.82% 43.73% -7.09% + Complexity 3469 2591 -878 Files 1693 794 -899 Lines 3583819795 -16043 Branches 3963 1862-2101 - Hits 18214 8657-9557 + Misses1668710461-6226 + Partials937 677 -260 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00 <0.00> (-1.00)` | | | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `72.72% <0.00%> (-20.38%)` | `28.00 <0.00> (-2.00)` | | | [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | | | [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [.../configuration/grpc/GRPCConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlnV2F0Y2hlclJlZ2lzdGVy
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (bbafda2) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **decrease** coverage by `13.21%`. > The diff coverage is `25.88%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## = - Coverage 50.82% 37.60% -13.22% + Complexity 3469 2215 -1254 = Files 1693 794 -899 Lines 3583819644-16194 Branches 3963 1832 -2131 = - Hits 18214 7388-10826 + Misses1668711688 -4999 + Partials937 568 -369 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00 <0.00> (-1.00)` | | | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `5.55% <0.00%> (-84.59%)` | `2.00 <0.00> (-18.00)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `72.72% <0.00%> (-20.38%)` | `28.00 <0.00> (-2.00)` | | | [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | | | [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] haboy52581 commented on issue #6237: Spring Cloud Gateway support not working on 8.2/8.3/6.6/6.5
haboy52581 commented on issue #6237: URL: https://github.com/apache/skywalking/issues/6237#issuecomment-765183470 the test case here is not including anything like rewrite url in which case our scenario is not working This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] dmsolr commented on pull request #6239: add pulsar reporter & fetcher
dmsolr commented on pull request #6239: URL: https://github.com/apache/skywalking/pull/6239#issuecomment-765178160 For now, placement in SkyAPM Repo will be a good choice. Once have many people need this, we are easy to take it back. We notice that the jar of Pulsar client is so big. Which more than 19m without dependencies. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (4ba7c02) into [master](https://codecov.io/gh/apache/skywalking/commit/3656fc7eb8d6218191efdd7e94a3e586654d3f97?el=desc) (3656fc7) will **increase** coverage by `1.66%`. > The diff coverage is `46.58%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## + Coverage 50.82% 52.48% +1.66% - Complexity 3469 3781 +312 Files 1693 1747 +54 Lines 3583836997+1159 Branches 3963 4092 +129 + Hits 1821419419+1205 + Misses1668716613 -74 - Partials937 965 +28 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...lkit/log/log4j/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lkit/log/log4j/v2/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMi54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...it/log/logback/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nYmFjay0xLngvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0NsaWVudEFwcGVuZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `57.95% <0.00%> (-1.35%)` | `18.00 <0.00> (ø)` | | | [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `69.56% <0.00%> (-0.22%)` | `25.00 <0.00> (+2.00)` | :arrow_down: | | [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `36.36% <0.00%> (-8.09%)` | `3.00 <0.00> (ø)` | | | [...ql/commons/CreateCallableStatementInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbXNzcWwtY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL21zc3FsL2NvbW1vbnMvQ3JlYXRlQ2FsbGFibGVTdGF0ZW1lbnRJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ql/commons/CreatePreparedStatementInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbXNzcWwtY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy
[GitHub] [skywalking] FudanYuan2019 opened a new issue #6245: Does SkyWalking support thrift-0.9.2?
FudanYuan2019 opened a new issue #6245: URL: https://github.com/apache/skywalking/issues/6245 Please answer these questions before submitting your issue. - Why do you submit this issue? - [* ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know? Does SkyWalking support thrift-0.9.2? ___ ### Bug - Which version of SkyWalking, OS, and JRE? - Which company or project? - What happened? If possible, provide a way to reproduce the error. e.g. demo application, component version. ___ ### Requirement or improvement - Please describe your requirements or improvement suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6239: add pulsar reporter & fetcher
wu-sheng commented on pull request #6239: URL: https://github.com/apache/skywalking/pull/6239#issuecomment-765170760 @pierre94 Do you want to work with us to move this to SkyAPM org, and only host the doc link in the Apache repo? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6245: Does SkyWalking support thrift-0.9.2?
wu-sheng commented on issue #6245: URL: https://github.com/apache/skywalking/issues/6245#issuecomment-765167527 From the supported list(versions we tested), it isn't. https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/Supported-list.md This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking-website] wu-sheng merged pull request #202: Fixed size scale of bilibili video
wu-sheng merged pull request #202: URL: https://github.com/apache/skywalking-website/pull/202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #6245: Does SkyWalking support thrift-0.9.2?
wu-sheng closed issue #6245: URL: https://github.com/apache/skywalking/issues/6245 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
hanahmily commented on a change in pull request #6243:
URL: https://github.com/apache/skywalking/pull/6243#discussion_r562305993
##
File path:
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/oc/OCMetricHandler.java
##
@@ -57,11 +58,21 @@
@Override public StreamObserver export(
StreamObserver responseObserver) {
return new StreamObserver() {
-@Override public void onNext(ExportMetricsServiceRequest request) {
+private Node node;
+
+@Override
+public void onNext(ExportMetricsServiceRequest request) {
+if (request.hasNode())
+node = request.getNode();
Review comment:
In case of NPE, I prefer to assign a default value to the `Node`, even
node is sent in the first message.
##
File path:
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/oc/OCMetricHandler.java
##
@@ -107,6 +118,13 @@
return result;
}
+private static Map buildLabelsFromNodeInfo(Node node,
+ Map buildLabelsResult) {
+if (node != null)
+buildLabelsResult.put("node_identifier_host_name",
node.getIdentifier().getHostName());
Review comment:
Could we add other fields more than `hostname` in `ProcessIdenifier`?
##
File path:
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/oc/OCMetricHandler.java
##
@@ -57,11 +58,21 @@
@Override public StreamObserver export(
StreamObserver responseObserver) {
return new StreamObserver() {
-@Override public void onNext(ExportMetricsServiceRequest request) {
+private Node node;
+
+@Override
+public void onNext(ExportMetricsServiceRequest request) {
+if (request.hasNode())
+node = request.getNode();
Review comment:
Exactly, `Optional.orElse()` is what I like. Some defensive programming
style.
##
File path:
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/oc/OCMetricHandler.java
##
@@ -107,6 +118,13 @@
return result;
}
+private static Map buildLabelsFromNodeInfo(Node node,
+ Map buildLabelsResult) {
+if (node != null)
+buildLabelsResult.put("node_identifier_host_name",
node.getIdentifier().getHostName());
Review comment:
MAL has a capacity to transform `.` to `_`, which means no matter what
we choose, the final result must be `node_identifier_host_name `.
##
File path:
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/oc/OCMetricHandler.java
##
@@ -107,6 +118,13 @@
return result;
}
+private static Map buildLabelsFromNodeInfo(Node node,
+ Map buildLabelsResult) {
+if (node != null)
+buildLabelsResult.put("node_identifier_host_name",
node.getIdentifier().getHostName());
Review comment:
A common use case about the `start_timestamp` is to get `uptime` metric,
the expression should leverage `start_timestamp` and `MAL` 's `now()` function
as below:
`now()-start_timestamp`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking-client-js] kezhenxu94 commented on pull request #41: fix: wrong URL when using relative path in xhr
kezhenxu94 commented on pull request #41: URL: https://github.com/apache/skywalking-client-js/pull/41#issuecomment-764704717 > Please fix CI before merge. Fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6241: [FAQ doc] Fix compiling on Mac M1 chip
codecov[bot] edited a comment on pull request #6241: URL: https://github.com/apache/skywalking/pull/6241#issuecomment-764638128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #6238: logging.max_history_files does not work
wu-sheng closed issue #6238: URL: https://github.com/apache/skywalking/issues/6238 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng merged pull request #16: feat: add http logging receiver
wu-sheng merged pull request #16: URL: https://github.com/apache/skywalking-satellite/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] pierre94 commented on pull request #6239: add pulsar reporter & fetcher
pierre94 commented on pull request #6239: URL: https://github.com/apache/skywalking/pull/6239#issuecomment-764481220 I want to provide optional pulsar reporter and fetcher to adapt to different data infrastructure. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6244: Profile stopped working in 8.3.0
wu-sheng commented on issue #6244: URL: https://github.com/apache/skywalking/issues/6244#issuecomment-764662635 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on issue #6205: Add log analyzer in es storage
EvanLjp commented on issue #6205: URL: https://github.com/apache/skywalking/issues/6205#issuecomment-765063842 i am already write some codes， i would try to push it on this weekend This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6205: Add log analyzer in es storage
wu-sheng commented on issue #6205: URL: https://github.com/apache/skywalking/issues/6205#issuecomment-765062147 @EvanLjp Are you adding this in 8.4.0? I may plan to finalize the 8.4.0 in next weekend, or 2 weeks later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] pantovad edited a comment on issue #5983: SelfObservability does not display any data in version 8.3.0
pantovad edited a comment on issue #5983: URL: https://github.com/apache/skywalking/issues/5983#issuecomment-764924271 Hello, With the setup as explained in the instructions I still get no oap-server metrics ... was working fine in 8.2.0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] zifeihan commented on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
zifeihan commented on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-764325292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wankai123 commented on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
wankai123 commented on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764710429 done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6221: Skywalking Client JS - ES module
wu-sheng commented on issue #6221: URL: https://github.com/apache/skywalking/issues/6221#issuecomment-764072927 If you want to send the data by your self, read the protocol doc. For segments, it is https://github.com/apache/skywalking/blob/v8.3.0/docs/en/protocols/HTTP-API-Protocol.md This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking-client-js] wu-sheng commented on pull request #41: fix: wrong URL when using relative path in xhr
wu-sheng commented on pull request #41: URL: https://github.com/apache/skywalking-client-js/pull/41#issuecomment-764670928 Please fix CI before merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6240: Support DNS period resolving mechanism
wu-sheng commented on a change in pull request #6240:
URL: https://github.com/apache/skywalking/pull/6240#discussion_r561735751
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
##
@@ -163,11 +163,14 @@
* Get profile task list interval
*/
public static int GET_PROFILE_TASK_INTERVAL = 20;
-
/**
* Get agent dynamic config interval
*/
public static int GET_AGENT_DYNAMIC_CONFIG_INTERVAL = 20;
+/**
+ * If true, skywalking agent will enable periodically resolving DNS to
update receiver service addresses. Otherwise disable
Review comment:
```suggestion
* If true, skywalking agent will enable periodically resolving DNS
to update receiver service addresses.
```
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
##
@@ -163,11 +163,14 @@
* Get profile task list interval
*/
public static int GET_PROFILE_TASK_INTERVAL = 20;
-
/**
* Get agent dynamic config interval
*/
public static int GET_AGENT_DYNAMIC_CONFIG_INTERVAL = 20;
+/**
+ * If true, skywalking agent will enable periodically resolving DNS to
update receiver service addresses. Otherwise disable
+ */
+public static boolean DNS_PERIOD_RESOLVE_ACTIVE = false;
Review comment:
```suggestion
public static boolean IS_RESOLVE_DNS_PERIODICALLY = false;
```
I think the current naming style is like this.
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/GRPCChannelManager.java
##
@@ -91,6 +97,23 @@ public void shutdown() {
@Override
public void run() {
+if (DNS_PERIOD_RESOLVE_ACTIVE) {
+String backendService =
Config.Collector.BACKEND_SERVICE.split(",")[0];
+try {
+String[] domainAndPort = backendService.split(":");
+
+List newGrpcServers = Arrays
+.stream(InetAddress.getAllByName(domainAndPort[0]))
+.map(InetAddress::getHostAddress)
+.map(ip -> String.format("%s:%s", ip,
domainAndPort[1]))
+.collect(Collectors.toList());
+
+grpcServers = newGrpcServers;
+} catch (Throwable t) {
+LOGGER.error(t, "Failed to resolve {} of backend service.",
backendService);
+}
+}
+
Review comment:
I think this should be called only when gRPC connection available.
`reconnect==true`
##
File path: docs/en/setup/service-agent/java-agent/README.md
##
@@ -95,6 +95,7 @@ property key | Description | Default |
`collector.grpc_upstream_timeout`|How long grpc client will timeout in sending
data to upstream. Unit is second.|`30` seconds|
`collector.get_profile_task_interval`|Sniffer get profile task list
interval.|`20`|
`collector.get_agent_dynamic_config_interval`|Sniffer get agent dynamic config
interval|`20`|
+`collector.dns_period_resolve_active`|If true, skywalking agent will enable
periodically resolving DNS to update receiver service addresses. Otherwise
disable|`false`|
Review comment:
```suggestion
`collector.dns_period_resolve_active`|If true, skywalking agent will enable
periodically resolving DNS to update receiver service addresses. |`false`|
```
Also should follow latest naming suggestion.
##
File path: CHANGES.md
##
@@ -37,6 +37,7 @@ Release Notes.
* Fix RestTemplate plugin recording url tag with wrong port
* Support collecting logs and forwarding through gRPC.
* Support config `agent.sample_n_per_3_secs` can be changed in the runtime.
+* Support DNS period resolving mechanism to update backend service.
Review comment:
```suggestion
* Support DNS periodic resolving mechanism to update backend service
addresses.
```
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/GRPCChannelManager.java
##
@@ -92,6 +98,23 @@ public void shutdown() {
@Override
public void run() {
LOGGER.debug("Selected collector grpc service running, reconnect:{}.",
reconnect);
+if (IS_RESOLVE_DNS_PERIODICALLY || reconnect) {
+String backendService =
Config.Collector.BACKEND_SERVICE.split(",")[0];
+try {
+String[] domainAndPort = backendService.split(":");
+
+List newGrpcServers = Arrays
+.stream(InetAddress.getAllByName(domainAndPort[0]))
+.map(InetAddress::getHostAddress)
+.map(ip -> String.format("%s:%s", ip,
domainAndPort[1]))
+.collect(Collectors.toList());
+
+grpcServers = newGrpcSe
[GitHub] [skywalking] kezhenxu94 removed a comment on issue #5983: SelfObservability does not display any data in version 8.3.0
kezhenxu94 removed a comment on issue #5983: URL: https://github.com/apache/skywalking/issues/5983#issuecomment-746346788 > I am new to Skywalking and want to setup APM for my services. Did you read [this](https://github.com/apache/skywalking/blob/master/docs/en/setup/backend/backend-telemetry.md#self-observability)? > I am facing issue with SelfObservability UI not showing anything neither meter tables got created in mysql database. > > Skywalking version 8.3 > > Can you please suggest the configuration > > 1. In self.yml ( where this url should point to ) The url should point to `http://localhost:1234`, this is an endpoint exposed by OAP itself, and is consumed by itself, make sure to enable `telemetry` that exposes the endpoint. > > ```yaml > # targets will be labeled as "instance" > targets: > - url: http://localhost:1234 > sslCaFilePath: > labels: > service: oap-server > ``` > > 1. There is no data on Profile and Log tab on UI , What configuration i need to set. Profile task is created by you, if you didn't create any, there is no data without doubt. The Log tab is for frontend at the moment, check [the SDK](https://github.com/apache/skywalking-client-js) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] Fine0830 commented on issue #6224: Are there any new features for Skywalking Client JS 0.3.0? Live Demo
Fine0830 commented on issue #6224: URL: https://github.com/apache/skywalking/issues/6224#issuecomment-764640827 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
wu-sheng merged pull request #6232: URL: https://github.com/apache/skywalking/pull/6232 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] xuanyu66 commented on a change in pull request #6240: Support DNS period resolving mechanism
xuanyu66 commented on a change in pull request #6240:
URL: https://github.com/apache/skywalking/pull/6240#discussion_r561883384
##
File path: docs/en/setup/service-agent/java-agent/README.md
##
@@ -95,6 +95,7 @@ property key | Description | Default |
`collector.grpc_upstream_timeout`|How long grpc client will timeout in sending
data to upstream. Unit is second.|`30` seconds|
`collector.get_profile_task_interval`|Sniffer get profile task list
interval.|`20`|
`collector.get_agent_dynamic_config_interval`|Sniffer get agent dynamic config
interval|`20`|
+`collector.dns_period_resolve_active`|If true, skywalking agent will enable
periodically resolving DNS to update receiver service addresses. Otherwise
disable|`false`|
Review comment:
fixed
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/GRPCChannelManager.java
##
@@ -91,6 +97,23 @@ public void shutdown() {
@Override
public void run() {
+if (DNS_PERIOD_RESOLVE_ACTIVE) {
+String backendService =
Config.Collector.BACKEND_SERVICE.split(",")[0];
+try {
+String[] domainAndPort = backendService.split(":");
+
+List newGrpcServers = Arrays
+.stream(InetAddress.getAllByName(domainAndPort[0]))
+.map(InetAddress::getHostAddress)
+.map(ip -> String.format("%s:%s", ip,
domainAndPort[1]))
+.collect(Collectors.toList());
+
+grpcServers = newGrpcServers;
+} catch (Throwable t) {
+LOGGER.error(t, "Failed to resolve {} of backend service.",
backendService);
+}
+}
+
Review comment:
fixed
##
File path: CHANGES.md
##
@@ -37,6 +37,7 @@ Release Notes.
* Fix RestTemplate plugin recording url tag with wrong port
* Support collecting logs and forwarding through gRPC.
* Support config `agent.sample_n_per_3_secs` can be changed in the runtime.
+* Support DNS period resolving mechanism to update backend service.
Review comment:
fixed
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
##
@@ -163,11 +163,14 @@
* Get profile task list interval
*/
public static int GET_PROFILE_TASK_INTERVAL = 20;
-
/**
* Get agent dynamic config interval
*/
public static int GET_AGENT_DYNAMIC_CONFIG_INTERVAL = 20;
+/**
+ * If true, skywalking agent will enable periodically resolving DNS to
update receiver service addresses. Otherwise disable
Review comment:
fixed
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
##
@@ -163,11 +163,14 @@
* Get profile task list interval
*/
public static int GET_PROFILE_TASK_INTERVAL = 20;
-
/**
* Get agent dynamic config interval
*/
public static int GET_AGENT_DYNAMIC_CONFIG_INTERVAL = 20;
+/**
+ * If true, skywalking agent will enable periodically resolving DNS to
update receiver service addresses. Otherwise disable
+ */
+public static boolean DNS_PERIOD_RESOLVE_ACTIVE = false;
Review comment:
fixed
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/GRPCChannelManager.java
##
@@ -92,6 +98,23 @@ public void shutdown() {
@Override
public void run() {
LOGGER.debug("Selected collector grpc service running, reconnect:{}.",
reconnect);
+if (IS_RESOLVE_DNS_PERIODICALLY || reconnect) {
+String backendService =
Config.Collector.BACKEND_SERVICE.split(",")[0];
+try {
+String[] domainAndPort = backendService.split(":");
+
+List newGrpcServers = Arrays
+.stream(InetAddress.getAllByName(domainAndPort[0]))
+.map(InetAddress::getHostAddress)
+.map(ip -> String.format("%s:%s", ip,
domainAndPort[1]))
+.collect(Collectors.toList());
+
+grpcServers = newGrpcServers;
Review comment:
I don't get it
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #6244: Profile stopped working in 8.3.0
wu-sheng closed issue #6244: URL: https://github.com/apache/skywalking/issues/6244 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng merged pull request #18: Include go.sum|go.mod in CI consistency check
wu-sheng merged pull request #18: URL: https://github.com/apache/skywalking-satellite/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6240: Support DNS period resolving mechanism
kezhenxu94 commented on a change in pull request #6240:
URL: https://github.com/apache/skywalking/pull/6240#discussion_r562302909
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/GRPCChannelManager.java
##
@@ -92,6 +98,23 @@ public void shutdown() {
@Override
public void run() {
LOGGER.debug("Selected collector grpc service running, reconnect:{}.",
reconnect);
+if (IS_RESOLVE_DNS_PERIODICALLY || reconnect) {
Review comment:
```suggestion
if (IS_RESOLVE_DNS_PERIODICALLY && reconnect) {
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6239: add pulsar reporter & fetcher
wu-sheng commented on pull request #6239: URL: https://github.com/apache/skywalking/pull/6239#issuecomment-764470377 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-website] branch master updated: fix: scale (#202)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/master by this push:
new 35917b9 fix: scale (#202)
35917b9 is described below
commit 35917b9907d98a61e5ff142d6ede09c889608161
Author: Juntao Zhang
AuthorDate: Fri Jan 22 14:13:07 2021 +0800
fix: scale (#202)
---
layouts/shortcodes/bilibili.html| 4 ++--
themes/docsy/assets/scss/_blog.scss | 16
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/layouts/shortcodes/bilibili.html b/layouts/shortcodes/bilibili.html
index 3badb35..c04b73e 100644
--- a/layouts/shortcodes/bilibili.html
+++ b/layouts/shortcodes/bilibili.html
@@ -2,7 +2,7 @@
{{ $pageNum := index .Params 1 | default 1}}
{{ if (findRE "^[bB][vV][0-9a-zA-Z]+$" $videoID) }}
-
+
{{ else }}
-
+
{{ end }}
diff --git a/themes/docsy/assets/scss/_blog.scss
b/themes/docsy/assets/scss/_blog.scss
index 475e40d..f96ff5a 100644
--- a/themes/docsy/assets/scss/_blog.scss
+++ b/themes/docsy/assets/scss/_blog.scss
@@ -75,3 +75,19 @@
}
}
+.bilibili-container {
+ position: relative;
+ width: 100%;
+ height: 0;
+ padding-bottom: 57%;
+ margin: 3% auto;
+ text-align: center;
+
+ iframe {
+position: absolute;
+width: 100%;
+height: 100%;
+left: 0;
+top: 0;
+ }
+}
[GitHub] [skywalking] pantovad commented on issue #6244: Profile stopped working in 8.3.0
pantovad commented on issue #6244: URL: https://github.com/apache/skywalking/issues/6244#issuecomment-764793003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] pantovad commented on issue #5983: SelfObservability does not display any data in version 8.3.0
pantovad commented on issue #5983: URL: https://github.com/apache/skywalking/issues/5983#issuecomment-764924271 Hello, With the setup as explained in the instructions I still get no oap-server metrics ... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6241: [FAQ doc] Fix compiling on Mac M1 chip
wu-sheng merged pull request #6241: URL: https://github.com/apache/skywalking/pull/6241 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on pull request #6239: add pulsar reporter & fetcher
EvanLjp commented on pull request #6239: URL: https://github.com/apache/skywalking/pull/6239#issuecomment-764498977 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6241: [FAQ doc] Fix compiling on Mac M1 chip
codecov[bot] commented on pull request #6241: URL: https://github.com/apache/skywalking/pull/6241#issuecomment-764638128 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6241?src=pr&el=h1) Report > Merging [#6241](https://codecov.io/gh/apache/skywalking/pull/6241?src=pr&el=desc) (c5649f1) into [master](https://codecov.io/gh/apache/skywalking/commit/4e3a200b4d8f44f6748b782c5943f140e1be1c34?el=desc) (4e3a200) will **decrease** coverage by `16.39%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/6241?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6241 +/- ## = - Coverage 51.98% 35.59% -16.40% + Complexity 3732 2080 -1652 = Files 1743 777 -966 Lines 3686719240-17627 Branches 4081 1818 -2263 = - Hits 19166 6848-12318 + Misses1674011870 -4870 + Partials961 522 -439 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6241?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6241/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6241/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `25.00% <ø> (+25.00%)` | `2.00 <0.00> (+2.00)` | | | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6241/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6241/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6241/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6241/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6241/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6241/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6241/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | | | [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6241/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYn
[GitHub] [skywalking-satellite] kezhenxu94 commented on pull request #18: Include go.sum|go.mod in CI consistency
kezhenxu94 commented on pull request #18:
URL:
https://github.com/apache/skywalking-satellite/pull/18#issuecomment-764448130
According to [the
doc](https://github.com/golang/go/wiki/Modules#why-does-go-mod-tidy-record-indirect-and-test-dependencies-in-my-gomod),
`go mod tidy` should be consistent in all platforms:
> go mod tidy also ensures your current go.mod reflects the dependency
requirements for all possible combinations of OS, architecture, and build tags
(as described here). In contrast, other commands like go build and go test only
update go.mod to provide the packages imported by the requested packages under
the current GOOS, GOARCH, and build tags (which is one reason go mod tidy might
add requirements that were not added by go build or similar).
I checked your issue in #10 , which is caused by the `packr` tool because it
used `GO111MODULE=on` so that it modifies the `go.{mod,sum}` always when no
`packr2` is installed (this happens on GitHub Action, but not on your local
machine unless you remove `$(go env GOPATH)/bin/packr2`), we don't use it and
thus I remove it here.
Another problem is that you had `$(GO) mod tidy &> /dev/null`, causing the
`go mod tidy` to run at background and the following command `git status -s`
will detect nothing because `go mod tidy` has not finished yet (mostly because
it cause some time), see
[here](https://github.com/apache/skywalking-satellite/runs/1740240310) for the
problem that was never detected before because of this .
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking-client-js] kezhenxu94 merged pull request #41: fix: wrong URL when using relative path in xhr
kezhenxu94 merged pull request #41: URL: https://github.com/apache/skywalking-client-js/pull/41 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #6222: dns resolve for skywalking trace receiver service addresses
wu-sheng closed issue #6222: URL: https://github.com/apache/skywalking/issues/6222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
wu-sheng commented on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764628146 Next time, please use a pure new branch to send the pull request. Otherwise, it always brings the previous commit log. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking-website] wu-sheng merged pull request #201: Post the recorded speech.
wu-sheng merged pull request #201: URL: https://github.com/apache/skywalking-website/pull/201 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] T-baby removed a comment on issue #5011: java.lang.NullPointerException at org.apache.skywalking.apm.agent.core.context.ContextManager.stopSpan
T-baby removed a comment on issue #5011: URL: https://github.com/apache/skywalking/issues/5011#issuecomment-700485285 I had the same problem, I looked at the test cases for skywalking and there are no tests for vert.x 3.8+, is it not supported for 3.8+? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] commented on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=h1) Report > Merging [#6243](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=desc) (3656fc7) into [master](https://codecov.io/gh/apache/skywalking/commit/4e3a200b4d8f44f6748b782c5943f140e1be1c34?el=desc) (4e3a200) will **decrease** coverage by `1.16%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6243 +/- ## - Coverage 51.98% 50.82% -1.17% + Complexity 3732 3469 -263 Files 1743 1693 -50 Lines 3686735838-1029 Branches 4081 3963 -118 - Hits 1916618214 -952 + Misses1674016687 -53 + Partials961 937 -24 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6243?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...hance/ClassInstanceMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NJbnN0YW5jZU1ldGhvZHNFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `100.00% <ø> (ø)` | `2.00 <0.00> (ø)` | | | [...g/oap/server/receiver/otel/oc/OCMetricHandler.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9vYy9PQ01ldHJpY0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | | | [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | | | [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6243/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.0
[GitHub] [skywalking] wu-sheng closed issue #6242: How to set up client sampling
wu-sheng closed issue #6242: URL: https://github.com/apache/skywalking/issues/6242 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
wu-sheng commented on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-764296381 Let's enable at the OAP side. This is a low cost feature. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
kezhenxu94 commented on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-764195118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
wu-sheng commented on a change in pull request #6243:
URL: https://github.com/apache/skywalking/pull/6243#discussion_r561856410
##
File path: docs/en/setup/backend/backend-receivers.md
##
@@ -182,7 +182,9 @@ receiver-otel:
enabledHandlers: ${SW_OTEL_RECEIVER_ENABLED_HANDLERS:"oc"}
enabledOcRules: ${SW_OTEL_RECEIVER_ENABLED_OC_RULES:"istio-controlplane"}
```
-
+The receiver will add a labelkey 'node_identifier_host_name' to the collected
data samples，
+the labelvalue is from
opencensus.proto.agent.common.v1.Node.identifier.host_name,
+to support the identification of the source of the metric data.
Review comment:
```suggestion
The receiver adds a label with `key=node_identifier_host_name` to the
collected data samples，
and value from `Node.identifier.host_name` defined in opencensus agent
proto,
to be the identification of the metric data.
```
##
File path:
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/oc/OCMetricHandler.java
##
@@ -107,6 +111,15 @@
return result;
}
+private static Map buildLabelsWithNodeInfo(Node node,
Review comment:
```suggestion
private static Map buildLabelsFromNodeInfo(Node node,
```
##
File path:
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/oc/OCMetricHandler.java
##
@@ -107,6 +111,15 @@
return result;
}
+private static Map buildLabelsWithNodeInfo(Node node,
+ List
keys,
+
List values) {
+Map result = buildLabels(keys, values);
Review comment:
Take a look at this comment in the original proto
```
// This is required only in the first message on the stream or if the
// previous sent ExportMetricsServiceRequest message has a different Node
(e.g.
// when the same RPC is used to send Metrics from multiple Applications).
opencensus.proto.agent.common.v1.Node node = 1;
```
You need to hold the previous node, if the current `request#hasNode()` is
false, use the previous one.
##
File path:
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/oc/OCMetricHandler.java
##
@@ -107,6 +111,15 @@
return result;
}
+private static Map buildLabelsWithNodeInfo(Node node,
Review comment:
Please don't hide `buildLabels` in the `buildLabelsWithNodeInfo`, it is
misleading the reader. Do like this `buildLabelsFromNodeInfo(buildLables(...))`.
##
File path:
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/oc/OCMetricHandler.java
##
@@ -57,11 +58,21 @@
@Override public StreamObserver export(
StreamObserver responseObserver) {
return new StreamObserver() {
-@Override public void onNext(ExportMetricsServiceRequest request) {
+private Node node;
+
+@Override
+public void onNext(ExportMetricsServiceRequest request) {
+if (request.hasNode())
+node = request.getNode();
Review comment:
I am not sure whether without `{}` is allowed. We will see.
##
File path:
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/oc/OCMetricHandler.java
##
@@ -107,6 +118,13 @@
return result;
}
+private static Map buildLabelsFromNodeInfo(Node node,
+ Map buildLabelsResult) {
+if (node != null)
+buildLabelsResult.put("node_identifier_host_name",
node.getIdentifier().getHostName());
Review comment:
```
// Identifier that uniquely identifies a process within a VM/container.
message ProcessIdentifier {
// The host name. Usually refers to the machine/container name.
// For example: os.Hostname() in Go, socket.gethostname() in Python.
string host_name = 1;
// Process id.
uint32 pid = 2;
// Start time of this ProcessIdentifier. Represented in epoch time.
google.protobuf.Timestamp start_timestamp = 3;
}
```
I think there is only `pid` makes sense? Do you think `_` is good, or should
consider `.`? Such as `node.identifier.host_name`.
##
File path:
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/oc/OCMetricHandler.java
##
@@ -57,11 +58,21 @@
@Override public StreamObserver export(
StreamObserver responseObserver) {
return new StreamObserver() {
-@Override public void onNext(ExportMetricsServiceRequest request)
[GitHub] [skywalking] wu-sheng commented on issue #6242: How to set up client sampling
wu-sheng commented on issue #6242: URL: https://github.com/apache/skywalking/issues/6242#issuecomment-764615438 No trace, no trace id. We don't provide such strange mechanism. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] EvanLjp edited a comment on pull request #6239: add pulsar reporter & fetcher
EvanLjp edited a comment on pull request #6239: URL: https://github.com/apache/skywalking/pull/6239#issuecomment-764498977 > @pierre94 Yes, I understand Pulsar could be the transport layer. My question is more that, whether should this be included in the main repo. > > FYI @apache/skywalking-committers , especially @hanahmily @dmsolr @kezhenxu94 @arugal @EvanLjp What do you think about this policy? The reporter plugin is much different with the other framework plugin, which hosts very little codes(less than 10 files usually). But as the reporter, we have to shade and re-distribute the whole dependencies. I think we should consider hosting codes in other places(including new repo) in or out of ASF. Sounds Great, If this is possible, logging-agent-receiver would not cost so much time to solve the shade problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6240: Support DNS period resolving mechanism
wu-sheng merged pull request #6240: URL: https://github.com/apache/skywalking/pull/6240 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
wankai123 commented on a change in pull request #6243:
URL: https://github.com/apache/skywalking/pull/6243#discussion_r561956826
##
File path: docs/en/setup/backend/backend-receivers.md
##
@@ -182,7 +182,9 @@ receiver-otel:
enabledHandlers: ${SW_OTEL_RECEIVER_ENABLED_HANDLERS:"oc"}
enabledOcRules: ${SW_OTEL_RECEIVER_ENABLED_OC_RULES:"istio-controlplane"}
```
-
+The receiver will add a labelkey 'node_identifier_host_name' to the collected
data samples，
+the labelvalue is from
opencensus.proto.agent.common.v1.Node.identifier.host_name,
+to support the identification of the source of the metric data.
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #16: feat: add http logging receiver
wu-sheng commented on pull request #16: URL: https://github.com/apache/skywalking-satellite/pull/16#issuecomment-764081220 Done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #6224: Are there any new features for Skywalking Client JS 0.3.0? Live Demo
kezhenxu94 commented on issue #6224: URL: https://github.com/apache/skywalking/issues/6224#issuecomment-764609188 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6240: Support DNS period resolving mechanism
codecov[bot] edited a comment on pull request #6240: URL: https://github.com/apache/skywalking/pull/6240#issuecomment-764521851 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] zifeihan commented on issue #5048: Skywalking and Spring-data-JPA conflict
zifeihan commented on issue #5048: URL: https://github.com/apache/skywalking/issues/5048#issuecomment-764353301 > Did you sloved this problem? @zifeihan I have occred the same proble for 8.3 > > ERROR 2021-01-19 16:29:47:547 main SkyWalkingAgent : Enhance class com.ccb.medium.repository.OrganRepository error. > java.lang.IllegalArgumentException: None of [protected void java.lang.Object.finalize() throws java.lang.Throwable, public final void java.lang.Object.wait() throws java.lang.InterruptedException, public final void java.lang.Object.wait(long,int) throws java.lang.InterruptedException, public final native void java.lang.Object.wait(long) throws java.lang.InterruptedException, public boolean java.lang.Object.equals(java.lang.Object), public java.lang.String java.lang.Object.toString(), public native int java.lang.Object.hashCode(), public final native java.lang.Class java.lang.Object.getClass(), protected native java.lang.Object java.lang.Object.clone() throws java.lang.CloneNotSupportedException, public final native void java.lang.Object.notify(), public final native void java.lang.Object.notifyAll(), public java.lang.Object org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(java.lang.Object,java.lang.Object[],java.util.concurrent.Callable, java.lang.reflect.Method) throws java.lang.Throwable] allows for delegation from public abstract com.ccb.medium.entity.OrganT org.springframework.data.repository.CrudRepository.save(com.ccb.medium.entity.OrganT) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.implementation.bind.MethodDelegationBinder$Processor.bind(MethodDelegationBinder.java:1096) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.implementation.MethodDelegation$Appender.apply(MethodDelegation.java:1346) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.dynamic.scaffold.TypeWriter$MethodPool$Record$ForDefinedMethod$WithBody.applyCode(TypeWriter.java:708) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.dynamic.scaffold.TypeWriter$MethodPool$Record$ForDefinedMethod$WithBody.applyBody(TypeWriter.java:693) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.dynamic.scaffold.TypeWriter$MethodPool$Record$ForDefinedMethod.apply(TypeWriter.java:600) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.dynamic.scaffold.TypeWriter$MethodPool$Record$AccessBridgeWrapper.apply(TypeWriter.java:1266) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.dynamic.scaffold.TypeWriter$Default$ForInlining$WithFullProcessing$RedefinitionClassVisitor.onVisitEnd(TypeWriter.java:5110) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.utility.visitor.MetadataAwareClassVisitor.visitEnd(MetadataAwareClassVisitor.java:370) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.jar.asm.ClassReader.accept(ClassReader.java:715) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.jar.asm.ClassReader.accept(ClassReader.java:394) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.dynamic.scaffold.TypeWriter$Default$ForInlining.create(TypeWriter.java:3892) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.dynamic.scaffold.TypeWriter$Default.make(TypeWriter.java:2166) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.dynamic.scaffold.inline.RebaseDynamicTypeBuilder.make(RebaseDynamicTypeBuilder.java:252) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer.doTransform(AgentBuilder.java:10366) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer.transform(AgentBuilder.java:10302) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer.access$1600(AgentBuilder.java:10068) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer$LegacyVmDispatcher.run(AgentBuilder.java:10687) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer$LegacyVmDispatcher.run(AgentBuilder.java:10634) > at java.security.AccessController.doPrivileged(Native Method) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer.transform(AgentBuilder.java:10225) > at sun.instrument.TransformerManager.transform(TransformerManager.java:188) > at sun.instrument.InstrumentationImpl.transform(InstrumentationImpl.java:428) > at java.lang.ClassLoader.defineClass1(Native Method) > at java.lang.ClassLoader.defineClass(ClassLoader.java:763) > at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) > at java.net.URLClassLoader.defineClass(URLClassLoader.java:467) > at java.net.URLClassLoader.access$100(URLClassLoader.java:73) > at java.net.URLClass
[GitHub] [skywalking] wu-sheng commented on issue #6237: Spring Cloud Gateway support not working on 8.2/8.3/6.6/6.5
wu-sheng commented on issue #6237: URL: https://github.com/apache/skywalking/issues/6237#issuecomment-764026400 Could you be more clear sbout the difference? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6241: Add How-to-build-with-mac-m1.md FAQ.
wu-sheng commented on a change in pull request #6241: URL: https://github.com/apache/skywalking/pull/6241#discussion_r561852374 ## File path: docs/en/FAQ/How-to-build-with-mac-m1.md ## @@ -0,0 +1,30 @@ +### Problem Review comment: ```suggestion # Fix compiling on MacBook M1 chip ### Problem ``` ## File path: docs/en/FAQ/README.md ## @@ -26,6 +26,8 @@ These are known and common FAQs. We welcome you to contribute yours. * [Compatible with other javaagent bytecode processing](Compatible-with-other-javaagent-bytecode-processing.md) * [**Java agent memory leak** when enhance `Worker thread` at use Thread Pool](Memory-leak-enhance-Worker-thread.md) * [Thrift plugin](thrift-plugin.md) +* [How-to-build-with-mac-m1](How-to-build-with-mac-m1.md) Review comment: ```suggestion * [Fix compiling on Mac M1 chip](How-to-build-with-mac-m1.md) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6240: Support DNS period resolving mechanism
codecov[bot] commented on pull request #6240: URL: https://github.com/apache/skywalking/pull/6240#issuecomment-764521851 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=h1) Report > Merging [#6240](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=desc) (9965876) into [master](https://codecov.io/gh/apache/skywalking/commit/4e3a200b4d8f44f6748b782c5943f140e1be1c34?el=desc) (4e3a200) will **increase** coverage by `4.55%`. > The diff coverage is `38.25%`. [](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6240 +/- ## + Coverage 51.98% 56.53% +4.55% + Complexity 3732 776-2956 Files 1743 167-1576 Lines 36867 4091 -32776 Branches 4081 474-3607 - Hits 19166 2313 -16853 + Misses16740 1484 -15256 + Partials961 294 -667 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <0.00%> (-19.06%)` | `12.00 <2.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (-46.67%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.25% <100.00%> (+0.60%)` | `0.00 <0.00> (ø)` | | | [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | | | [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` |
[GitHub] [skywalking] margauxcabrera commented on issue #6221: Skywalking Client JS - ES module
margauxcabrera commented on issue #6221: URL: https://github.com/apache/skywalking/issues/6221#issuecomment-763964167 Can you please tell me if it requires some parameters? 'Cause I've tried it in postman and got this error:  This is the error from the logs: ``` 2021-01-20 21:32:59,905 - org.eclipse.jetty.server.HttpChannel -71700376 [qtp1493883713-77] WARN [] - /v3/segments java.lang.UnsupportedOperationException: null at org.apache.skywalking.oap.server.receiver.trace.provider.handler.v8.rest.TraceSegmentReportBaseServletHandler.doGet(TraceSegmentReportBaseServletHandler.java:64) ~[skywalking-trace-receiver-plugin-8.3.0.jar:8.3.0] at org.apache.skywalking.oap.server.library.server.jetty.JettyJsonHandler.doGet(JettyJsonHandler.java:44) ~[library-server-8.3.0.jar:8.3.0] at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) ~[javax.servlet-api-3.1.0.jar:3.1.0] at org.apache.skywalking.oap.server.library.server.jetty.JettyJsonHandler.service(JettyJsonHandler.java:107) ~[library-server-8.3.0.jar:8.3.0] at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) ~[javax.servlet-api-3.1.0.jar:3.1.0] at org.apache.skywalking.oap.server.library.server.jetty.JettyJsonHandler.service(JettyJsonHandler.java:112) ~[library-server-8.3.0.jar:8.3.0] at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:763) ~[jetty-servlet-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:551) ~[jetty-servlet-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1363) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:489) ~[jetty-servlet-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1278) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.Server.handle(Server.java:500) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:383) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:547) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:375) [jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:273) [jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311) [jetty-io-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:103) [jetty-io-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:117) [jetty-io-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:336) [jetty-util-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:313) [jetty-util-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:171) [jetty-util-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:129) [jetty-util-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:375) [jetty-util-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:806) [jetty-util-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(Queu
[GitHub] [skywalking] mrproliu commented on issue #6244: Profile stopped working in 8.3.0
mrproliu commented on issue #6244: URL: https://github.com/apache/skywalking/issues/6244#issuecomment-765062542 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #6221: Skywalking Client JS - ES module
wu-sheng closed issue #6221: URL: https://github.com/apache/skywalking/issues/6221 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6238: logging.max_history_files does not work
wu-sheng commented on issue #6238: URL: https://github.com/apache/skywalking/issues/6238#issuecomment-764670124 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6243: Support the identification of the source host of the metric data in otel-receiver-plugin
codecov[bot] edited a comment on pull request #6243: URL: https://github.com/apache/skywalking/pull/6243#issuecomment-764629494 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking] branch master updated: Support DNS period resolving mechanism (#6240)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 100823c Support DNS period resolving mechanism (#6240)
100823c is described below
commit 100823cb6e7f076de0ac7b5da2dd6789e21fcf38
Author: Leon Yang <1395305...@qq.com>
AuthorDate: Fri Jan 22 13:14:21 2021 +0800
Support DNS period resolving mechanism (#6240)
---
CHANGES.md | 1 +
.../skywalking/apm/agent/core/conf/Config.java | 5 -
.../apm/agent/core/remote/GRPCChannelManager.java | 23 ++
docs/en/setup/service-agent/java-agent/README.md | 1 +
4 files changed, 29 insertions(+), 1 deletion(-)
diff --git a/CHANGES.md b/CHANGES.md
index 210a0d8..10c79af 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -37,6 +37,7 @@ Release Notes.
* Fix RestTemplate plugin recording url tag with wrong port
* Support collecting logs and forwarding through gRPC.
* Support config `agent.sample_n_per_3_secs` can be changed in the runtime.
+* Support DNS periodic resolving mechanism to update backend service.
OAP-Backend
* Make meter receiver support MAL.
diff --git
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
index b7da770..4f4a981 100755
---
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
+++
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
@@ -163,11 +163,14 @@ public class Config {
* Get profile task list interval
*/
public static int GET_PROFILE_TASK_INTERVAL = 20;
-
/**
* Get agent dynamic config interval
*/
public static int GET_AGENT_DYNAMIC_CONFIG_INTERVAL = 20;
+/**
+ * If true, skywalking agent will enable periodically resolving DNS to
update receiver service addresses.
+ */
+public static boolean IS_RESOLVE_DNS_PERIODICALLY = false;
}
public static class Profile {
diff --git
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/GRPCChannelManager.java
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/GRPCChannelManager.java
index ca13a48..79d114d 100755
---
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/GRPCChannelManager.java
+++
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/GRPCChannelManager.java
@@ -21,6 +21,8 @@ package org.apache.skywalking.apm.agent.core.remote;
import io.grpc.Channel;
import io.grpc.Status;
import io.grpc.StatusRuntimeException;
+
+import java.net.InetAddress;
import java.util.Arrays;
import java.util.Collections;
import java.util.LinkedList;
@@ -29,6 +31,8 @@ import java.util.Random;
import java.util.concurrent.Executors;
import java.util.concurrent.ScheduledFuture;
import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+
import org.apache.skywalking.apm.agent.core.boot.BootService;
import org.apache.skywalking.apm.agent.core.boot.DefaultImplementor;
import org.apache.skywalking.apm.agent.core.boot.DefaultNamedThreadFactory;
@@ -37,6 +41,8 @@ import org.apache.skywalking.apm.agent.core.logging.api.ILog;
import org.apache.skywalking.apm.agent.core.logging.api.LogManager;
import org.apache.skywalking.apm.util.RunnableWithExceptionProtection;
+import static
org.apache.skywalking.apm.agent.core.conf.Config.Collector.IS_RESOLVE_DNS_PERIODICALLY;
+
@DefaultImplementor
public class GRPCChannelManager implements BootService, Runnable {
private static final ILog LOGGER =
LogManager.getLogger(GRPCChannelManager.class);
@@ -92,6 +98,23 @@ public class GRPCChannelManager implements BootService,
Runnable {
@Override
public void run() {
LOGGER.debug("Selected collector grpc service running, reconnect:{}.",
reconnect);
+if (IS_RESOLVE_DNS_PERIODICALLY && reconnect) {
+String backendService =
Config.Collector.BACKEND_SERVICE.split(",")[0];
+try {
+String[] domainAndPort = backendService.split(":");
+
+List newGrpcServers = Arrays
+.stream(InetAddress.getAllByName(domainAndPort[0]))
+.map(InetAddress::getHostAddress)
+.map(ip -> String.format("%s:%s", ip,
domainAndPort[1]))
+.collect(Collectors.toList());
+
+grpcServers = newGrpcServers;
+} catch (Throwable t) {
+LOGGER.error(t, "Failed to resolve {} of backend service.",
backendService);
+}
+}
+
if (reconnect) {
[GitHub] [skywalking] wu-sheng closed issue #6222: dns resolve for skywalking trace receiver service addresses
wu-sheng closed issue #6222: URL: https://github.com/apache/skywalking/issues/6222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6240: Support DNS period resolving mechanism
wu-sheng merged pull request #6240: URL: https://github.com/apache/skywalking/pull/6240 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6240: Support DNS period resolving mechanism
codecov[bot] edited a comment on pull request #6240: URL: https://github.com/apache/skywalking/pull/6240#issuecomment-764521851 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=h1) Report > Merging [#6240](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=desc) (4f5aae2) into [master](https://codecov.io/gh/apache/skywalking/commit/43e2458e6b5744a783379027fd4be3e462c95366?el=desc) (43e2458) will **increase** coverage by `2.56%`. > The diff coverage is `7.69%`. [](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6240 +/- ## + Coverage 43.62% 46.19% +2.56% + Complexity 3182 2669 -513 Files 965 1747 +782 Lines 2378637021 +13235 Branches 2330 4080+1750 + Hits 1037717101+6724 - Misses1253818935+6397 - Partials871 985 +114 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `52.22% <0.00%> (-4.19%)` | `0.00 <0.00> (-12.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.25% <100.00%> (+0.29%)` | `0.00 <0.00> (ø)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...hance/ClassInstanceMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NJbnN0YW5jZU1ldGhvZHNFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | | | [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-6.00%)` | | | [...skywalking/apm/agent/core/plugin/PluginFinder.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvc
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6240: Support DNS period resolving mechanism
codecov[bot] edited a comment on pull request #6240: URL: https://github.com/apache/skywalking/pull/6240#issuecomment-764521851 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=h1) Report > Merging [#6240](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=desc) (4f5aae2) into [master](https://codecov.io/gh/apache/skywalking/commit/43e2458e6b5744a783379027fd4be3e462c95366?el=desc) (43e2458) will **increase** coverage by `2.55%`. > The diff coverage is `7.69%`. [](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6240 +/- ## + Coverage 43.64% 46.19% +2.55% + Complexity 3181 2669 -512 Files 963 1747 +784 Lines 2377537021 +13246 Branches 2330 4080+1750 + Hits 1037617101+6725 - Misses1252718935+6408 - Partials872 985 +113 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `52.22% <0.00%> (-4.19%)` | `0.00 <0.00> (-12.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.25% <100.00%> (+0.29%)` | `0.00 <0.00> (ø)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...hance/ClassInstanceMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NJbnN0YW5jZU1ldGhvZHNFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | | | [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-6.00%)` | | | [...skywalking/apm/agent/core/plugin/PluginFinder.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvc
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6240: Support DNS period resolving mechanism
codecov[bot] edited a comment on pull request #6240: URL: https://github.com/apache/skywalking/pull/6240#issuecomment-764521851 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=h1) Report > Merging [#6240](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=desc) (4f5aae2) into [master](https://codecov.io/gh/apache/skywalking/commit/43e2458e6b5744a783379027fd4be3e462c95366?el=desc) (43e2458) will **increase** coverage by `2.42%`. > The diff coverage is `7.69%`. [](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6240 +/- ## + Coverage 43.76% 46.19% +2.42% + Complexity 3178 2669 -509 Files 962 1747 +785 Lines 2370237021 +13319 Branches 2313 4080+1767 + Hits 1037217100+6728 - Misses1245518935+6480 - Partials875 986 +111 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `52.22% <0.00%> (-4.19%)` | `0.00 <0.00> (-12.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.25% <100.00%> (+0.29%)` | `0.00 <0.00> (ø)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...hance/ClassInstanceMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NJbnN0YW5jZU1ldGhvZHNFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | | | [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-6.00%)` | | | [...skywalking/apm/agent/core/plugin/PluginFinder.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvc
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6240: Support DNS period resolving mechanism
codecov[bot] edited a comment on pull request #6240: URL: https://github.com/apache/skywalking/pull/6240#issuecomment-764521851 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=h1) Report > Merging [#6240](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=desc) (4f5aae2) into [master](https://codecov.io/gh/apache/skywalking/commit/43e2458e6b5744a783379027fd4be3e462c95366?el=desc) (43e2458) will **decrease** coverage by `5.91%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6240 +/- ## - Coverage 43.94% 38.02% -5.92% + Complexity 3178 2669 -509 Files 959 958 -1 Lines 2360323715 +112 Branches 2302 2327 +25 - Hits 10372 9018-1354 - Misses1235613975+1619 + Partials875 722 -153 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.96%)` | `0.00 <0.00> (ø)` | | | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `0.00% <0.00%> (-56.42%)` | `0.00 <0.00> (-12.00)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [240 more](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6240: Support DNS period resolving mechanism
codecov[bot] edited a comment on pull request #6240: URL: https://github.com/apache/skywalking/pull/6240#issuecomment-764521851 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6240: Support DNS period resolving mechanism
codecov[bot] edited a comment on pull request #6240: URL: https://github.com/apache/skywalking/pull/6240#issuecomment-764521851 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=h1) Report > Merging [#6240](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=desc) (5f17ef4) into [master](https://codecov.io/gh/apache/skywalking/commit/43e2458e6b5744a783379027fd4be3e462c95366?el=desc) (43e2458) will **increase** coverage by `6.69%`. > The diff coverage is `7.69%`. [](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6240 +/- ## + Coverage 43.93% 50.62% +6.69% - Complexity 3175 3580 +405 Files 959 981 +22 Lines 2359724106 +509 Branches 2289 2369 +80 + Hits 1036712204+1837 + Misses1235510904-1451 - Partials875 998 +123 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <0.00%> (-7.53%)` | `12.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.25% <100.00%> (+0.29%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | | | [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | | | [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | | | [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | | | [...oap/server/core/analysis/manual/searchtag/Tag.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlYXJjaHRhZy9UYWcuamF2YQ==) | `40.00% <0.00%> (-20.00%)` | `1.00% <0.00%> (ø%)` | | | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (-12.68%)` | `12.00% <0.00%> (-1.00%)` | | | [.../server/storage/plugin/jdbc/h2/dao/H2BatchDAO.java](https://codecov.io/gh/apache/
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6240: Support DNS period resolving mechanism
codecov[bot] edited a comment on pull request #6240: URL: https://github.com/apache/skywalking/pull/6240#issuecomment-764521851 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=h1) Report > Merging [#6240](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=desc) (5f17ef4) into [master](https://codecov.io/gh/apache/skywalking/commit/43e2458e6b5744a783379027fd4be3e462c95366?el=desc) (43e2458) will **increase** coverage by `6.70%`. > The diff coverage is `7.69%`. [](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6240 +/- ## + Coverage 43.93% 50.64% +6.70% - Complexity 3175 3580 +405 Files 959 981 +22 Lines 2359724098 +501 Branches 2289 2369 +80 + Hits 1036712204+1837 + Misses1235510896-1459 - Partials875 998 +123 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <0.00%> (-7.53%)` | `12.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.25% <100.00%> (+0.29%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | | | [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | | | [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | | | [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | | | [...oap/server/core/analysis/manual/searchtag/Tag.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlYXJjaHRhZy9UYWcuamF2YQ==) | `40.00% <0.00%> (-20.00%)` | `1.00% <0.00%> (ø%)` | | | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (-12.68%)` | `12.00% <0.00%> (-1.00%)` | | | [.../server/storage/plugin/jdbc/h2/dao/H2BatchDAO.java](https://codecov.io/gh/apache/
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6240: Support DNS period resolving mechanism
codecov[bot] edited a comment on pull request #6240: URL: https://github.com/apache/skywalking/pull/6240#issuecomment-764521851 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=h1) Report > Merging [#6240](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=desc) (5f17ef4) into [master](https://codecov.io/gh/apache/skywalking/commit/43e2458e6b5744a783379027fd4be3e462c95366?el=desc) (43e2458) will **increase** coverage by `6.90%`. > The diff coverage is `7.69%`. [](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6240 +/- ## + Coverage 43.93% 50.83% +6.90% - Complexity 3175 3580 +405 Files 959 978 +19 Lines 2359724007 +410 Branches 2289 2358 +69 + Hits 1036712204+1837 + Misses1235510805-1550 - Partials875 998 +123 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <0.00%> (-7.53%)` | `12.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.25% <100.00%> (+0.29%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | | | [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | | | [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | | | [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | | | [...oap/server/core/analysis/manual/searchtag/Tag.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlYXJjaHRhZy9UYWcuamF2YQ==) | `40.00% <0.00%> (-20.00%)` | `1.00% <0.00%> (ø%)` | | | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (-12.68%)` | `12.00% <0.00%> (-1.00%)` | | | [.../server/storage/plugin/jdbc/h2/dao/H2BatchDAO.java](https://codecov.io/gh/apache/
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6240: Support DNS period resolving mechanism
codecov[bot] edited a comment on pull request #6240: URL: https://github.com/apache/skywalking/pull/6240#issuecomment-764521851 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=h1) Report > Merging [#6240](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=desc) (5f17ef4) into [master](https://codecov.io/gh/apache/skywalking/commit/43e2458e6b5744a783379027fd4be3e462c95366?el=desc) (43e2458) will **increase** coverage by `6.91%`. > The diff coverage is `7.69%`. [](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6240 +/- ## + Coverage 43.93% 50.84% +6.91% - Complexity 3175 3580 +405 Files 959 976 +17 Lines 2359724001 +404 Branches 2289 2358 +69 + Hits 1036712204+1837 + Misses1235510799-1556 - Partials875 998 +123 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <0.00%> (-7.53%)` | `12.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.25% <100.00%> (+0.29%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | | | [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | | | [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | | | [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | | | [...oap/server/core/analysis/manual/searchtag/Tag.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlYXJjaHRhZy9UYWcuamF2YQ==) | `40.00% <0.00%> (-20.00%)` | `1.00% <0.00%> (ø%)` | | | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (-12.68%)` | `12.00% <0.00%> (-1.00%)` | | | [.../server/storage/plugin/jdbc/h2/dao/H2BatchDAO.java](https://codecov.io/gh/apache/
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6240: Support DNS period resolving mechanism
codecov[bot] edited a comment on pull request #6240: URL: https://github.com/apache/skywalking/pull/6240#issuecomment-764521851 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=h1) Report > Merging [#6240](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=desc) (5f17ef4) into [master](https://codecov.io/gh/apache/skywalking/commit/43e2458e6b5744a783379027fd4be3e462c95366?el=desc) (43e2458) will **increase** coverage by `7.00%`. > The diff coverage is `7.69%`. [](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6240 +/- ## + Coverage 43.93% 50.93% +7.00% - Complexity 3175 3580 +405 Files 959 974 +15 Lines 2359723959 +362 Branches 2289 2354 +65 + Hits 1036712204+1837 + Misses1235510757-1598 - Partials875 998 +123 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <0.00%> (-7.53%)` | `12.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.25% <100.00%> (+0.29%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | | | [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | | | [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | | | [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | | | [...oap/server/core/analysis/manual/searchtag/Tag.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlYXJjaHRhZy9UYWcuamF2YQ==) | `40.00% <0.00%> (-20.00%)` | `1.00% <0.00%> (ø%)` | | | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (-12.68%)` | `12.00% <0.00%> (-1.00%)` | | | [.../server/storage/plugin/jdbc/h2/dao/H2BatchDAO.java](https://codecov.io/gh/apache/
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6240: Support DNS period resolving mechanism
codecov[bot] edited a comment on pull request #6240: URL: https://github.com/apache/skywalking/pull/6240#issuecomment-764521851 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=h1) Report > Merging [#6240](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=desc) (5f17ef4) into [master](https://codecov.io/gh/apache/skywalking/commit/43e2458e6b5744a783379027fd4be3e462c95366?el=desc) (43e2458) will **increase** coverage by `6.31%`. > The diff coverage is `7.69%`. [](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#6240 +/- ## + Coverage 43.93% 50.24% +6.31% - Complexity 3175 3540 +365 Files 959 974 +15 Lines 2359723956 +359 Branches 2289 2354 +65 + Hits 1036712037+1670 + Misses1235510921-1434 - Partials875 998 +123 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6240?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <0.00%> (-7.53%)` | `12.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.25% <100.00%> (+0.29%)` | `0.00 <0.00> (ø)` | | | [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | | | [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | | | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00% <0.00%> (-5.00%)` | | | [...p/server/core/source/NetworkAddressAliasSetup.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL05ldHdvcmtBZGRyZXNzQWxpYXNTZXR1cC5qYXZh) | `33.33% <0.00%> (-50.01%)` | `2.00% <0.00%> (-1.00%)` | | | [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | | | [...r/listener/NetworkAddressAliasMappingListener.java](https://codecov.io/gh/apache/skywalking/pull/6240/diff?src=
