[skywalking] branch test/e2e/istio updated (895b516ac3 -> f908de76bc)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch test/e2e/istio in repository https://gitbox.apache.org/repos/asf/skywalking.git discard 895b516ac3 test: fix ES disk insufficient in test add f908de76bc test: fix ES disk insufficient in test This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (895b516ac3) \ N -- N -- N refs/heads/test/e2e/istio (f908de76bc) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../oap/server/core/analysis/manual/segment/SegmentRecord.java| 2 +- test/e2e-v2/cases/istio/values.yaml | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-)
[PR] test: fix ES disk insufficient in test [skywalking]
kezhenxu94 opened a new pull request, #11406: URL: https://github.com/apache/skywalking/pull/11406 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking] 01/01: test: fix ES disk insufficient in test
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch test/e2e/istio in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 895b516ac3b84329746c857351bb6b05c08aa554 Author: kezhenxu94 AuthorDate: Fri Oct 13 02:11:26 2023 + test: fix ES disk insufficient in test --- .github/workflows/skywalking.yaml | 40 ++--- test/e2e-v2/cases/istio/values.yaml | 9 - 2 files changed, 28 insertions(+), 21 deletions(-) diff --git a/.github/workflows/skywalking.yaml b/.github/workflows/skywalking.yaml index 3f5b684085..bfb1b97bcb 100644 --- a/.github/workflows/skywalking.yaml +++ b/.github/workflows/skywalking.yaml @@ -539,26 +539,26 @@ jobs: - name: Kafka Log config: test/e2e-v2/cases/kafka/log/e2e.yaml - # - name: Istio Metrics Service 1.15.0 - # config: test/e2e-v2/cases/istio/metrics/e2e.yaml - # env: | - # ISTIO_VERSION=1.15.0 - # KUBERNETES_VERSION=25 - # - name: Istio Metrics Service 1.16.0 - # config: test/e2e-v2/cases/istio/metrics/e2e.yaml - # env: | - # ISTIO_VERSION=1.16.0 - # KUBERNETES_VERSION=25 - # - name: Istio Metrics Service 1.17.0 - # config: test/e2e-v2/cases/istio/metrics/e2e.yaml - # env: | - # ISTIO_VERSION=1.17.0 - # KUBERNETES_VERSION=25 - # - name: Istio Metrics Service 1.18.0 - # config: test/e2e-v2/cases/istio/metrics/e2e.yaml - # env: | - # ISTIO_VERSION=1.18.0 - # KUBERNETES_VERSION=25 + - name: Istio Metrics Service 1.15.0 +config: test/e2e-v2/cases/istio/metrics/e2e.yaml +env: | + ISTIO_VERSION=1.15.0 + KUBERNETES_VERSION=25 + - name: Istio Metrics Service 1.16.0 +config: test/e2e-v2/cases/istio/metrics/e2e.yaml +env: | + ISTIO_VERSION=1.16.0 + KUBERNETES_VERSION=25 + - name: Istio Metrics Service 1.17.0 +config: test/e2e-v2/cases/istio/metrics/e2e.yaml +env: | + ISTIO_VERSION=1.17.0 + KUBERNETES_VERSION=25 + - name: Istio Metrics Service 1.18.0 +config: test/e2e-v2/cases/istio/metrics/e2e.yaml +env: | + ISTIO_VERSION=1.18.0 + KUBERNETES_VERSION=25 - name: Rover with Istio Process 1.15.0 config: test/e2e-v2/cases/rover/process/istio/e2e.yaml diff --git a/test/e2e-v2/cases/istio/values.yaml b/test/e2e-v2/cases/istio/values.yaml index 02048abbad..2d7dc6c999 100644 --- a/test/e2e-v2/cases/istio/values.yaml +++ b/test/e2e-v2/cases/istio/values.yaml @@ -24,4 +24,11 @@ elasticsearch: elasticsearch.yml: | cluster.routing.allocation.disk.watermark.low: 90% cluster.routing.allocation.disk.watermark.high: 99% - cluster.routing.allocation.disk.watermark.flood_stage: 99% \ No newline at end of file + cluster.routing.allocation.disk.watermark.flood_stage: 99% + volumeClaimTemplate: +accessModes: [ "ReadWriteOnce" ] +resources: + requests: +storage: 2Gi + persistence: +enabled: true
[skywalking] branch test/e2e/istio updated (a8e8f326f6 -> 895b516ac3)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch test/e2e/istio in repository https://gitbox.apache.org/repos/asf/skywalking.git discard a8e8f326f6 test: fix ES disk insufficient in test new 895b516ac3 test: fix ES disk insufficient in test This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (a8e8f326f6) \ N -- N -- N refs/heads/test/e2e/istio (895b516ac3) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .github/workflows/skywalking.yaml | 40 +++ 1 file changed, 20 insertions(+), 20 deletions(-)
[skywalking] 01/01: test: fix ES disk insufficient in test
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch test/e2e/istio in repository https://gitbox.apache.org/repos/asf/skywalking.git commit a8e8f326f645bd92450f20c96546cb4a493d08b7 Author: kezhenxu94 AuthorDate: Fri Oct 13 02:05:49 2023 + test: fix ES disk insufficient in test --- test/e2e-v2/cases/istio/values.yaml | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/test/e2e-v2/cases/istio/values.yaml b/test/e2e-v2/cases/istio/values.yaml index 02048abbad..2d7dc6c999 100644 --- a/test/e2e-v2/cases/istio/values.yaml +++ b/test/e2e-v2/cases/istio/values.yaml @@ -24,4 +24,11 @@ elasticsearch: elasticsearch.yml: | cluster.routing.allocation.disk.watermark.low: 90% cluster.routing.allocation.disk.watermark.high: 99% - cluster.routing.allocation.disk.watermark.flood_stage: 99% \ No newline at end of file + cluster.routing.allocation.disk.watermark.flood_stage: 99% + volumeClaimTemplate: +accessModes: [ "ReadWriteOnce" ] +resources: + requests: +storage: 2Gi + persistence: +enabled: true
[skywalking] branch test/e2e/istio created (now a8e8f326f6)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch test/e2e/istio in repository https://gitbox.apache.org/repos/asf/skywalking.git at a8e8f326f6 test: fix ES disk insufficient in test This branch includes the following new commits: new a8e8f326f6 test: fix ES disk insufficient in test The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
Re: [PR] Fix oracle lower case tns url parse error. (#11399) [skywalking-java]
wu-sheng commented on PR #621: URL: https://github.com/apache/skywalking-java/pull/621#issuecomment-1760470062 You should update the changes file. You clicked the box in the PR, but didn't actually do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix oracle lower case tns url parse error. (#11399) [skywalking-java]
Builder34 opened a new pull request, #621: URL: https://github.com/apache/skywalking-java/pull/621 - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes [[Bug] oracle lower case tns url parse err: skywalking#11399](https://github.com/apache/skywalking/issues/11399) - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md). - To compatible upper and lower case Oracle TNS url parse. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: panic happens when reporter init failed [skywalking-go]
mrproliu commented on PR #123: URL: https://github.com/apache/skywalking-go/pull/123#issuecomment-1759233363 The root point is why the `e, ok := entity.(Entity); ok && e != nil` not working, could you please help to locate the reason? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix java-doc dead link [skywalking-java]
wu-sheng merged PR #620: URL: https://github.com/apache/skywalking-java/pull/620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-java] branch main updated: fix java-doc dead link (#620)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-java.git
The following commit(s) were added to refs/heads/main by this push:
new c2fe67b775 fix java-doc dead link (#620)
c2fe67b775 is described below
commit c2fe67b775030c4e58cd9ba86ccb5539dabf4c7c
Author: wuwen
AuthorDate: Thu Oct 12 17:08:56 2023 +0800
fix java-doc dead link (#620)
---
.../src/main/java/org/apache/skywalking/apm/toolkit/trace/Tag.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/apm-application-toolkit/apm-toolkit-trace/src/main/java/org/apache/skywalking/apm/toolkit/trace/Tag.java
b/apm-application-toolkit/apm-toolkit-trace/src/main/java/org/apache/skywalking/apm/toolkit/trace/Tag.java
index 22917d42fe..251b00296b 100644
---
a/apm-application-toolkit/apm-toolkit-trace/src/main/java/org/apache/skywalking/apm/toolkit/trace/Tag.java
+++
b/apm-application-toolkit/apm-toolkit-trace/src/main/java/org/apache/skywalking/apm/toolkit/trace/Tag.java
@@ -41,7 +41,7 @@ public @interface Tag {
/**
* @return the value of the tag to be injected into the current active
span, in the form of the customized
- * enhancement rules, for more information, refer to
https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/Customize-enhance-trace.md#how-to-configure
+ * enhancement rules, for more information, refer to https://github.com/apache/skywalking-java/blob/master/docs/en/setup/service-agent/java-agent/Customize-enhance-trace.md#how-to-configure";>Customize-enhance-trace.md#how-to-configure
*/
String value();
}
[PR] fix: panic happens when reporter init failed [skywalking-go]
YenchangChan opened a new pull request, #123:
URL: https://github.com/apache/skywalking-go/pull/123
I implemented a reporter to send span segments to Kafka， but I got panic
when kafka cannot connect. I noticed the root cause is following code:
```go
// tools/go-agent/instrument/logger/context.go
entity := operator.Entity()
if entity != nil {
if e, ok := entity.(Entity); ok && e != nil {
serviceName, instanceName = e.GetServiceName(),
e.GetInstanceName()
}
}
```
When reporter init failed, entity point to `(*reporter.Entity)(nil)`,
`(*reporter.Entity)(nil)` not equals to `nil`， so if condition will go in, and
program panic when `e.GetServiceName()` called.
I have no idea whether this happens when grpc dail serveraddr failed, but I
think it's necessary to make the code more robust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[skywalking] branch master updated: Adjust `AlarmRecord` alarmMessage column length to 512. (#11404)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 90f723ef03 Adjust `AlarmRecord` alarmMessage column length to 512.
(#11404)
90f723ef03 is described below
commit 90f723ef03b2a5e87bc63118ad9154dfb99a3f33
Author: weixiang1862 <652048...@qq.com>
AuthorDate: Thu Oct 12 16:16:42 2023 +0800
Adjust `AlarmRecord` alarmMessage column length to 512. (#11404)
---
docs/en/changes/changes.md | 1 +
.../java/org/apache/skywalking/oap/server/core/alarm/AlarmRecord.java | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
index 93a8804cda..3aecf0f752 100644
--- a/docs/en/changes/changes.md
+++ b/docs/en/changes/changes.md
@@ -20,6 +20,7 @@
* BanyanDBStorageClient: Add `keepAliveProperty` API.
* Fix table exists check in the JDBC Storage Plugin.
* Enhance extensibility of HTTP Server library.
+* Adjust `AlarmRecord` alarmMessage column length to 512.
UI
diff --git
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/alarm/AlarmRecord.java
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/alarm/AlarmRecord.java
index fa87a55e19..f75e9542f8 100644
---
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/alarm/AlarmRecord.java
+++
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/alarm/AlarmRecord.java
@@ -80,7 +80,7 @@ public class AlarmRecord extends Record {
private String id1;
@Column(name = START_TIME)
private long startTime;
-@Column(name = ALARM_MESSAGE)
+@Column(name = ALARM_MESSAGE, length = 512)
@ElasticSearch.MatchQuery
private String alarmMessage;
@Column(name = RULE_NAME)
Re: [PR] Adjust `AlarmRecord` alarmMessage column length to 512. [skywalking]
wu-sheng merged PR #11404: URL: https://github.com/apache/skywalking/pull/11404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: update Makefile to support build arm64 platform [skywalking-go]
mrproliu merged PR #122: URL: https://github.com/apache/skywalking-go/pull/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-go] branch main updated: feat: update Makefile to support build arm64 platform (#122)
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-go.git The following commit(s) were added to refs/heads/main by this push: new 907c044 feat: update Makefile to support build arm64 platform (#122) 907c044 is described below commit 907c04460023deafb5e8cb52373886106d030eb1 Author: YenchangChan <43897067+yenchangc...@users.noreply.github.com> AuthorDate: Thu Oct 12 15:37:24 2023 +0800 feat: update Makefile to support build arm64 platform (#122) --- tools/go-agent/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/go-agent/Makefile b/tools/go-agent/Makefile index a10bc2d..3279245 100644 --- a/tools/go-agent/Makefile +++ b/tools/go-agent/Makefile @@ -34,7 +34,7 @@ GO_GET = $(GO) get PLATFORMS := linux darwin windows os = $(word 1, $@) -ARCH = amd64 +ARCH ?= amd64 SHELL = /bin/bash
[PR] fix java-doc dead link [skywalking-java]
wuwen5 opened a new pull request, #620: URL: https://github.com/apache/skywalking-java/pull/620 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking] branch master updated: Enhance extensibility of HTTP Server library (#11401)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 4621e5191f Enhance extensibility of HTTP Server library (#11401)
4621e5191f is described below
commit 4621e5191fcc2fe8271a3049b788fd33c694f703
Author: mrproliu <741550...@qq.com>
AuthorDate: Thu Oct 12 15:12:53 2023 +0800
Enhance extensibility of HTTP Server library (#11401)
---
.github/workflows/skywalking.yaml | 40 +++---
docs/en/changes/changes.md | 1 +
.../oap/server/library/server/http/HTTPServer.java | 4 +--
3 files changed, 23 insertions(+), 22 deletions(-)
diff --git a/.github/workflows/skywalking.yaml
b/.github/workflows/skywalking.yaml
index bfb1b97bcb..3f5b684085 100644
--- a/.github/workflows/skywalking.yaml
+++ b/.github/workflows/skywalking.yaml
@@ -539,26 +539,26 @@ jobs:
- name: Kafka Log
config: test/e2e-v2/cases/kafka/log/e2e.yaml
- - name: Istio Metrics Service 1.15.0
-config: test/e2e-v2/cases/istio/metrics/e2e.yaml
-env: |
- ISTIO_VERSION=1.15.0
- KUBERNETES_VERSION=25
- - name: Istio Metrics Service 1.16.0
-config: test/e2e-v2/cases/istio/metrics/e2e.yaml
-env: |
- ISTIO_VERSION=1.16.0
- KUBERNETES_VERSION=25
- - name: Istio Metrics Service 1.17.0
-config: test/e2e-v2/cases/istio/metrics/e2e.yaml
-env: |
- ISTIO_VERSION=1.17.0
- KUBERNETES_VERSION=25
- - name: Istio Metrics Service 1.18.0
-config: test/e2e-v2/cases/istio/metrics/e2e.yaml
-env: |
- ISTIO_VERSION=1.18.0
- KUBERNETES_VERSION=25
+ # - name: Istio Metrics Service 1.15.0
+ # config: test/e2e-v2/cases/istio/metrics/e2e.yaml
+ # env: |
+ # ISTIO_VERSION=1.15.0
+ # KUBERNETES_VERSION=25
+ # - name: Istio Metrics Service 1.16.0
+ # config: test/e2e-v2/cases/istio/metrics/e2e.yaml
+ # env: |
+ # ISTIO_VERSION=1.16.0
+ # KUBERNETES_VERSION=25
+ # - name: Istio Metrics Service 1.17.0
+ # config: test/e2e-v2/cases/istio/metrics/e2e.yaml
+ # env: |
+ # ISTIO_VERSION=1.17.0
+ # KUBERNETES_VERSION=25
+ # - name: Istio Metrics Service 1.18.0
+ # config: test/e2e-v2/cases/istio/metrics/e2e.yaml
+ # env: |
+ # ISTIO_VERSION=1.18.0
+ # KUBERNETES_VERSION=25
- name: Rover with Istio Process 1.15.0
config: test/e2e-v2/cases/rover/process/istio/e2e.yaml
diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
index 6d116f7651..93a8804cda 100644
--- a/docs/en/changes/changes.md
+++ b/docs/en/changes/changes.md
@@ -19,6 +19,7 @@
* Fix getInstances query in the BanyanDB Metadata DAO.
* BanyanDBStorageClient: Add `keepAliveProperty` API.
* Fix table exists check in the JDBC Storage Plugin.
+* Enhance extensibility of HTTP Server library.
UI
diff --git
a/oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/http/HTTPServer.java
b/oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/http/HTTPServer.java
index 787d942a36..d79a0899ee 100644
---
a/oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/http/HTTPServer.java
+++
b/oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/http/HTTPServer.java
@@ -48,9 +48,9 @@ import static java.util.Objects.requireNonNull;
@Slf4j
public class HTTPServer implements Server {
private final HTTPServerConfig config;
-private ServerBuilder sb;
+protected ServerBuilder sb;
// Health check service, supports HEAD, GET method.
-private final Set allowedMethods =
Sets.newHashSet(HttpMethod.HEAD);
+protected final Set allowedMethods =
Sets.newHashSet(HttpMethod.HEAD);
public HTTPServer(HTTPServerConfig config) {
this.config = config;
Re: [PR] Enhance extensibility of HTTP Server library [skywalking]
wu-sheng merged PR #11401: URL: https://github.com/apache/skywalking/pull/11401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
