Re: [PR] Support collect ZGC memory pool metrics [skywalking]
wu-sheng commented on PR #11432: URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1772093729 The one I was showing above. It wasn't synced, but you are syncing sub module now, so, you need to add this to change log as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support collect ZGC memory pool metrics [skywalking]
Z-Beatles commented on PR #11432: URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1772088474 > Still missing one. > > https://user-images.githubusercontent.com/5441976/276816603-bfeae130-24d9-4fac-a5e0-8e948e822e96.png;> > Please check from git history https://github.com/apache/skywalking-booster-ui/commits/main Which one missing? There are no changes in the [skywalking-booster-ui](https://github.com/apache/skywalking-booster-ui). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-java] branch main updated: Support collect ZGC memory pool metrics (#622)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-java.git
The following commit(s) were added to refs/heads/main by this push:
new c15ac3071e Support collect ZGC memory pool metrics (#622)
c15ac3071e is described below
commit c15ac3071e42f72a528664631248b9e75d83bbaf
Author: Wayne Chu
AuthorDate: Fri Oct 20 12:38:18 2023 +0800
Support collect ZGC memory pool metrics (#622)
---
CHANGES.md | 2 +
apm-protocol/apm-network/src/main/proto| 2 +-
.../core/jvm/memorypool/MemoryPoolProvider.java| 3 +
.../core/jvm/memorypool/ZGCCollectorModule.java| 70 ++
4 files changed, 76 insertions(+), 1 deletion(-)
diff --git a/CHANGES.md b/CHANGES.md
index 16ed45919f..eab5a4afde 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -15,6 +15,8 @@ Release Notes.
* Support report MongoDB instance info in Mongodb 4.x plugin.
* To compatible upper and lower case Oracle TNS url parse.
* Fix config length limitation.
+* Support collecting ZGC memory pool metrics. Require OAP 9.7.0 to support
these new metrics.
+
Documentation
diff --git a/apm-protocol/apm-network/src/main/proto
b/apm-protocol/apm-network/src/main/proto
index f9066463de..d4da569991 16
--- a/apm-protocol/apm-network/src/main/proto
+++ b/apm-protocol/apm-network/src/main/proto
@@ -1 +1 @@
-Subproject commit f9066463deb7f9d1fbe8110eab3524694b0db298
+Subproject commit d4da5699915ee52288f8ff1c954decf6363485bc
diff --git
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/memorypool/MemoryPoolProvider.java
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/memorypool/MemoryPoolProvider.java
index 8633c1213d..901c9d4a3f 100644
---
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/memorypool/MemoryPoolProvider.java
+++
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/memorypool/MemoryPoolProvider.java
@@ -61,6 +61,9 @@ public enum MemoryPoolProvider {
} else if (name.equals("Survivor Space")) {
// Serial collector ( -XX:+UseSerialGC )
return new SerialCollectorModule(beans);
+} else if (name.equals("ZHeap")) {
+// ZGC collector ( -XX:+UseZGC )
+return new ZGCCollectorModule(beans);
} else {
// Unknown
return null;
diff --git
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/memorypool/ZGCCollectorModule.java
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/memorypool/ZGCCollectorModule.java
new file mode 100644
index 00..7cf87bcf17
--- /dev/null
+++
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/memorypool/ZGCCollectorModule.java
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.agent.core.jvm.memorypool;
+
+import org.apache.skywalking.apm.network.language.agent.v3.MemoryPool;
+import org.apache.skywalking.apm.network.language.agent.v3.PoolType;
+
+import java.lang.management.MemoryPoolMXBean;
+import java.lang.management.MemoryUsage;
+import java.util.LinkedList;
+import java.util.List;
+
+public class ZGCCollectorModule implements MemoryPoolMetricsAccessor {
+
+private final List beans;
+
+public ZGCCollectorModule(List beans) {
+this.beans = beans;
+}
+
+@Override
+public List getMemoryPoolMetricsList() {
+List poolList = new LinkedList<>();
+for (MemoryPoolMXBean bean : beans) {
+String name = bean.getName();
+PoolType type;
+if (name.equals("ZHeap")) {
+type = PoolType.ZHEAP_USAGE;
+} else if (name.equals("Metaspace")) {
+type = PoolType.METASPACE_USAGE;
+} else if (name.equals("Compressed Class Space")) {
+type = PoolType.COMPRESSED_CLASS_SPACE_USAGE;
+} else if (name.equals("CodeHeap 'non-nmethods'")) {
+
Re: [PR] Support collect ZGC memory pool metrics [skywalking-java]
wu-sheng merged PR #622: URL: https://github.com/apache/skywalking-java/pull/622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-nodejs] annotated tag v0.7.0 updated (4f9a91d -> 6a08265)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to annotated tag v0.7.0 in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git *** WARNING: tag v0.7.0 was modified! *** from 4f9a91d (commit) to 6a08265 (tag) tagging 4f9a91dad3dfd8cfe5ba8f7bd06b39e11eb5e65e (commit) replaces v0.6.0 by kezhenxu94 on Thu Oct 19 21:21:15 2023 +0800 - Log - Release Apache SkyWalking-NodeJS 0.7.0 --- No new revisions were added by this update. Summary of changes:
Re: [PR] Support collect ZGC memory pool metrics [skywalking]
wu-sheng commented on PR #11432: URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1772041590 Still missing one. https://github.com/apache/skywalking/assets/5441976/bfeae130-24d9-4fac-a5e0-8e948e822e96;> Please check from git history https://github.com/apache/skywalking-booster-ui/commits/main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support collect ZGC memory pool metrics [skywalking-java]
wu-sheng commented on code in PR #622: URL: https://github.com/apache/skywalking-java/pull/622#discussion_r1366424517 ## CHANGES.md: ## @@ -15,6 +15,8 @@ Release Notes. * Support report MongoDB instance info in Mongodb 4.x plugin. * To compatible upper and lower case Oracle TNS url parse. * Fix config length limitation. +* Support collect ZGC memory pool metrics. Review Comment: ```suggestion * Support collecting ZGC memory pool metrics. Require OAP 9.7.0 to support these new metrics. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support collect ZGC memory pool metrics [skywalking]
wu-sheng commented on PR #11432: URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1772034152 As you have updated UI, I think there is UI side commit gap too. Please update the UI part change logs accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking] branch master updated: Fix AlarmRule expression validation: add labeled metrics mock data for check. (#11437)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 062b31f4ba Fix AlarmRule expression validation: add labeled metrics
mock data for check. (#11437)
062b31f4ba is described below
commit 062b31f4ba5586c33f301dd4052f602894b784c4
Author: Wan Kai
AuthorDate: Fri Oct 20 10:45:15 2023 +0800
Fix AlarmRule expression validation: add labeled metrics mock data for
check. (#11437)
---
docs/en/changes/changes.md | 1 +
.../oap/server/core/alarm/provider/AlarmRule.java | 18 +-
.../provider/expr/rt/AlarmMQEVerifyVisitor.java| 66 --
.../server/core/alarm/provider/AlarmRuleTest.java | 18 --
test/e2e-v2/cases/alarm/alarm-settings.yml | 11 ++--
.../alarm/expected/silence-after-graphql-warn.yml | 48
.../alarm/expected/silence-before-graphql-warn.yml | 24
7 files changed, 156 insertions(+), 30 deletions(-)
diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
index a027a04a80..cebc12bf8c 100644
--- a/docs/en/changes/changes.md
+++ b/docs/en/changes/changes.md
@@ -25,6 +25,7 @@
* Fix `AlarmCore` doAlarm: catch exception for each callback to avoid
interruption.
* Optimize queryBasicTraces in TraceQueryEsDAO.
* Fix `WebhookCallback` send incorrect messages, add catch exception for each
callback HTTP Post.
+* Fix AlarmRule expression validation: add labeled metrics mock data for check.
UI
diff --git
a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRule.java
b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRule.java
index 5094957265..76c6e6cc1a 100644
---
a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRule.java
+++
b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRule.java
@@ -21,7 +21,6 @@ package org.apache.skywalking.oap.server.core.alarm.provider;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.Map;
-import java.util.Optional;
import java.util.Set;
import lombok.AccessLevel;
import lombok.Data;
@@ -39,7 +38,6 @@ import org.apache.skywalking.mqe.rt.grammar.MQEParser;
import org.apache.skywalking.mqe.rt.type.ExpressionResult;
import org.apache.skywalking.mqe.rt.type.ExpressionResultType;
import
org.apache.skywalking.oap.server.core.alarm.provider.expr.rt.AlarmMQEVerifyVisitor;
-import org.apache.skywalking.oap.server.core.storage.annotation.Column;
import
org.apache.skywalking.oap.server.core.storage.annotation.ValueColumnMetadata;
import org.apache.skywalking.oap.server.library.util.StringUtil;
@@ -95,25 +93,11 @@ public class AlarmRule {
private void verifyIncludeMetrics(Set includeMetrics, String
expression) throws IllegalExpressionException {
Set scopeSet = new HashSet<>();
for (String metricName : includeMetrics) {
-Optional valueColumn =
ValueColumnMetadata.INSTANCE.readValueColumnDefinition(
-metricName);
-if (valueColumn.isEmpty()) {
-throw new IllegalExpressionException("Metric: [" + metricName
+ "] dose not exist.");
-}
scopeSet.add(ValueColumnMetadata.INSTANCE.getScope(metricName).name());
-Column.ValueDataType dataType = valueColumn.get().getDataType();
-switch (dataType) {
-case COMMON_VALUE:
-case LABELED_VALUE:
-break;
-default:
-throw new IllegalExpressionException(
-"Metric dose not supported in alarm, metric: [" +
metricName + "] is not a common or labeled metric.");
-}
}
if (scopeSet.size() != 1) {
throw new IllegalExpressionException(
-"The metrics in expression: " + expression + " must have the
same scope level, but got: " + scopeSet);
+"The metrics in expression: " + expression + " must have the
same scope level, but got: " + scopeSet + ".");
}
}
}
diff --git
a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/expr/rt/AlarmMQEVerifyVisitor.java
b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/expr/rt/AlarmMQEVerifyVisitor.java
index 78c93afdd7..c6c556f9c8 100644
---
a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/expr/rt/AlarmMQEVerifyVisitor.java
+++
b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/expr/rt/AlarmMQEVerifyVisitor.java
@@ -18,7 +18,12 @@
package
Re: [PR] Fix AlarmRule expression validation: add labeled metrics mock data for check. [skywalking]
wu-sheng merged PR #11437: URL: https://github.com/apache/skywalking/pull/11437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support etcd client authentication [skywalking-banyandb]
hailin0 commented on PR #331: URL: https://github.com/apache/skywalking-banyandb/pull/331#issuecomment-1771972416 @hanahmily PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-client-js] branch master updated: docs: remove QQ group from README, update version (#118)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-client-js.git
The following commit(s) were added to refs/heads/master by this push:
new 613e12e docs: remove QQ group from README, update version (#118)
613e12e is described below
commit 613e12e9ec7381e20e5c194f0880480cdd5bab1b
Author: Fine0830
AuthorDate: Fri Oct 20 10:18:46 2023 +0800
docs: remove QQ group from README, update version (#118)
---
README.md | 1 -
package-lock.json | 2 +-
package.json | 2 +-
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/README.md b/README.md
index 459d4ed..8dd3bec 100644
--- a/README.md
+++ b/README.md
@@ -218,7 +218,6 @@ See more information, [click
here](https://github.com/SkyAPMTest/skywalking-clie
* Submit an [issue](https://github.com/apache/skywalking/issues)
* Mail list: **d...@skywalking.apache.org**. Mail to
`dev-subscr...@skywalking.apache.org`, follow the reply to subscribe the mail
list.
* Join `#skywalking` channel at [Apache
Slack](https://join.slack.com/t/the-asf/shared_invite/enQtNzc2ODE3MjI1MDk1LTAyZGJmNTg1NWZhNmVmOWZjMjA2MGUyOGY4MjE5ZGUwOTQxY2Q3MDBmNTM5YTllNGU4M2QyMzQ4M2U4ZjQ5YmY).
If the linke is not working, find the latest one at [Apache INFRA
WIKI](https://cwiki.apache.org/confluence/display/INFRA/Slack+Guest+Invites).
-* QQ Group: 392443393, 901167865
# Release Guide
All committers should follow [Release Guide](release.md) to publish the
official release.
diff --git a/package-lock.json b/package-lock.json
index 38c78c2..18292a9 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,6 +1,6 @@
{
"name": "skywalking-client-js",
- "version": "0.10.0",
+ "version": "0.11.0",
"lockfileVersion": 2,
"requires": true,
"packages": {
diff --git a/package.json b/package.json
index 021f5d3..12dafa6 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
{
"name": "skywalking-client-js",
- "version": "0.10.0",
+ "version": "0.11.0",
"description": "Client-side JavaScript exception and tracing library for
Apache SkyWalking APM",
"main": "index.js",
"types": "lib/src/index.d.ts",
Re: [PR] docs: remove QQ group from README, update version [skywalking-client-js]
wu-sheng merged PR #118: URL: https://github.com/apache/skywalking-client-js/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] docs: remove QQ group from README, update version [skywalking-client-js]
Fine0830 opened a new pull request, #118: URL: https://github.com/apache/skywalking-client-js/pull/118 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix AlarmRule expression validation: add labeled metrics mock data for check. [skywalking]
wankai123 opened a new pull request, #11437: URL: https://github.com/apache/skywalking/pull/11437 relate to https://github.com/apache/skywalking/discussions/11422 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking] branch chore deleted (was 2daf1a2ad6)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch chore in repository https://gitbox.apache.org/repos/asf/skywalking.git was 2daf1a2ad6 Fix import The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[skywalking] branch master updated: Fix imports (#11436)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 39eae22b94 Fix imports (#11436)
39eae22b94 is described below
commit 39eae22b9402d3d2597d82e6e0056158887ce9fb
Author: 吴晟 Wu Sheng
AuthorDate: Fri Oct 20 09:49:57 2023 +0800
Fix imports (#11436)
---
.../storage/EBPFProcessProfilingScheduleDispatcher.java| 14 ++
.../profiling/ebpf/storage/EBPFProfilingDataRecord.java| 2 +-
.../server/core/source/EBPFProcessProfilingSchedule.java | 6 +++---
3 files changed, 14 insertions(+), 8 deletions(-)
diff --git
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/ebpf/storage/EBPFProcessProfilingScheduleDispatcher.java
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/ebpf/storage/EBPFProcessProfilingScheduleDispatcher.java
index c19f1326bd..047aaf5304 100644
---
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/ebpf/storage/EBPFProcessProfilingScheduleDispatcher.java
+++
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/ebpf/storage/EBPFProcessProfilingScheduleDispatcher.java
@@ -18,8 +18,8 @@
package org.apache.skywalking.oap.server.core.profiling.ebpf.storage;
+import com.google.common.base.Charsets;
import com.google.common.hash.Hashing;
-import com.linecorp.armeria.internal.shaded.guava.base.Charsets;
import org.apache.skywalking.oap.server.core.analysis.SourceDispatcher;
import org.apache.skywalking.oap.server.core.analysis.TimeBucket;
import
org.apache.skywalking.oap.server.core.analysis.worker.MetricsStreamProcessor;
@@ -34,9 +34,15 @@ public class EBPFProcessProfilingScheduleDispatcher
implements SourceDispatcher<
traffic.setStartTime(source.getStartTime());
traffic.setEndTime(source.getCurrentTime());
traffic.setTimeBucket(TimeBucket.getMinuteTimeBucket(source.getCurrentTime()));
-traffic.setScheduleId(Hashing.sha256().newHasher()
- .putString(String.format("%s_%s_%d",
source.getTaskId(), source.getProcessId(), source.getStartTime()),
Charsets.UTF_8)
- .hash().toString());
+traffic.setScheduleId(
+Hashing
+.sha256()
+.newHasher()
+.putString(
+String.format("%s_%s_%d", source.getTaskId(),
source.getProcessId(), source.getStartTime()),
+Charsets.UTF_8
+)
+.hash().toString());
MetricsStreamProcessor.getInstance().in(traffic);
}
}
diff --git
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/ebpf/storage/EBPFProfilingDataRecord.java
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/ebpf/storage/EBPFProfilingDataRecord.java
index b40aa23488..41885e3a7c 100644
---
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/ebpf/storage/EBPFProfilingDataRecord.java
+++
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/ebpf/storage/EBPFProfilingDataRecord.java
@@ -18,8 +18,8 @@
package org.apache.skywalking.oap.server.core.profiling.ebpf.storage;
+import com.google.common.base.Charsets;
import com.google.common.hash.Hashing;
-import com.linecorp.armeria.internal.shaded.guava.base.Charsets;
import lombok.Data;
import org.apache.skywalking.oap.server.core.analysis.Stream;
import org.apache.skywalking.oap.server.core.analysis.record.Record;
diff --git
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/EBPFProcessProfilingSchedule.java
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/EBPFProcessProfilingSchedule.java
index bcae3f6e4c..10aa5f09bc 100644
---
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/EBPFProcessProfilingSchedule.java
+++
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/EBPFProcessProfilingSchedule.java
@@ -18,8 +18,8 @@
package org.apache.skywalking.oap.server.core.source;
+import com.google.common.base.Charsets;
import com.google.common.hash.Hashing;
-import com.linecorp.armeria.internal.shaded.guava.base.Charsets;
import lombok.Getter;
import lombok.Setter;
@@ -41,8 +41,8 @@ public class EBPFProcessProfilingSchedule extends Source {
public String getEntityId() {
if (entityId == null) {
entityId = Hashing.sha256().newHasher()
-.putString(String.format("%s_%s_%d", taskId, processId,
startTime), Charsets.UTF_8)
-.hash().toString();
+
Re: [I] [Bug] Some classes use shaded version of Guava's `Charsets` class [skywalking]
wu-sheng closed issue #11435: [Bug] Some classes use shaded version of Guava's `Charsets` class URL: https://github.com/apache/skywalking/issues/11435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix imports [skywalking]
wu-sheng merged PR #11436: URL: https://github.com/apache/skywalking/pull/11436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-data-collect-protocol] branch wu-sheng-patch-1 deleted (was d0457d8)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-data-collect-protocol.git was d0457d8 Update ci.yaml The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[skywalking-data-collect-protocol] branch master updated: Fix CI to run on the latest Ubuntu (#87)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-data-collect-protocol.git The following commit(s) were added to refs/heads/master by this push: new d4da569 Fix CI to run on the latest Ubuntu (#87) d4da569 is described below commit d4da5699915ee52288f8ff1c954decf6363485bc Author: 吴晟 Wu Sheng AuthorDate: Fri Oct 20 09:20:41 2023 +0800 Fix CI to run on the latest Ubuntu (#87) --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 1f21e83..b1644b7 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -25,7 +25,7 @@ on: - 'v*' jobs: CI: -runs-on: ubuntu-18.04 +runs-on: ubuntu-latest timeout-minutes: 10 steps: - uses: actions/checkout@v2
Re: [PR] Fix CI to run on the latest Ubuntu [skywalking-data-collect-protocol]
wu-sheng merged PR #87: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Update ci.yaml [skywalking-data-collect-protocol]
wu-sheng opened a new pull request, #87: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/87 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-data-collect-protocol] branch wu-sheng-patch-1 created (now d0457d8)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-data-collect-protocol.git at d0457d8 Update ci.yaml This branch includes the following new commits: new d0457d8 Update ci.yaml The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[skywalking-data-collect-protocol] 01/01: Update ci.yaml
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-data-collect-protocol.git commit d0457d83b6c71a75a4cb9c5b754f11785f6ecbf1 Author: 吴晟 Wu Sheng AuthorDate: Thu Oct 19 20:10:49 2023 -0500 Update ci.yaml --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 1f21e83..b1644b7 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -25,7 +25,7 @@ on: - 'v*' jobs: CI: -runs-on: ubuntu-18.04 +runs-on: ubuntu-latest timeout-minutes: 10 steps: - uses: actions/checkout@v2
[skywalking-data-collect-protocol] branch master updated: Support collect ZGC memory pool metrics (#86)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/skywalking-data-collect-protocol.git
The following commit(s) were added to refs/heads/master by this push:
new 3b491fa Support collect ZGC memory pool metrics (#86)
3b491fa is described below
commit 3b491fac59afd267149a372f7e23a51503bf6619
Author: Wayne Chu
AuthorDate: Fri Oct 20 09:06:09 2023 +0800
Support collect ZGC memory pool metrics (#86)
---
language-agent/JVMMetric.proto | 5 +
1 file changed, 5 insertions(+)
diff --git a/language-agent/JVMMetric.proto b/language-agent/JVMMetric.proto
index a4808f7..e0d55ed 100644
--- a/language-agent/JVMMetric.proto
+++ b/language-agent/JVMMetric.proto
@@ -73,6 +73,11 @@ enum PoolType {
SURVIVOR_USAGE = 3;
PERMGEN_USAGE = 4;
METASPACE_USAGE = 5;
+ZHEAP_USAGE = 6;
+COMPRESSED_CLASS_SPACE_USAGE = 7;
+CODEHEAP_NON_NMETHODS_USAGE = 8;
+CODEHEAP_PROFILED_NMETHODS_USAGE = 9;
+CODEHEAP_NON_PROFILED_NMETHODS_USAGE = 10;
}
message GC {
Re: [PR] Support collect ZGC memory pool metrics [skywalking]
wu-sheng commented on PR #11432: URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1771910923 Please make the submodule correctly, pointing to the master branch commit ID. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support collect ZGC memory pool metrics [skywalking-data-collect-protocol]
wu-sheng merged PR #86: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support collect ZGC memory pool metrics [skywalking]
wu-sheng commented on PR #11432: URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1771910865 Please make the submodule correctly, pointing to the master branch commit ID. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support collect ZGC memory pool metrics [skywalking-data-collect-protocol]
wu-sheng closed pull request #86: Support collect ZGC memory pool metrics URL: https://github.com/apache/skywalking-data-collect-protocol/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix imports [skywalking]
wu-sheng opened a new pull request, #11436: URL: https://github.com/apache/skywalking/pull/11436 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #11435. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking] 01/01: Fix import
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch chore
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 2daf1a2ad63b6ab67ffde89f6ef1fc9783dab896
Author: Wu Sheng
AuthorDate: Fri Oct 20 08:47:31 2023 +0800
Fix import
---
.../storage/EBPFProcessProfilingScheduleDispatcher.java| 14 ++
.../profiling/ebpf/storage/EBPFProfilingDataRecord.java| 2 +-
.../server/core/source/EBPFProcessProfilingSchedule.java | 6 +++---
3 files changed, 14 insertions(+), 8 deletions(-)
diff --git
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/ebpf/storage/EBPFProcessProfilingScheduleDispatcher.java
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/ebpf/storage/EBPFProcessProfilingScheduleDispatcher.java
index c19f1326bd..047aaf5304 100644
---
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/ebpf/storage/EBPFProcessProfilingScheduleDispatcher.java
+++
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/ebpf/storage/EBPFProcessProfilingScheduleDispatcher.java
@@ -18,8 +18,8 @@
package org.apache.skywalking.oap.server.core.profiling.ebpf.storage;
+import com.google.common.base.Charsets;
import com.google.common.hash.Hashing;
-import com.linecorp.armeria.internal.shaded.guava.base.Charsets;
import org.apache.skywalking.oap.server.core.analysis.SourceDispatcher;
import org.apache.skywalking.oap.server.core.analysis.TimeBucket;
import
org.apache.skywalking.oap.server.core.analysis.worker.MetricsStreamProcessor;
@@ -34,9 +34,15 @@ public class EBPFProcessProfilingScheduleDispatcher
implements SourceDispatcher<
traffic.setStartTime(source.getStartTime());
traffic.setEndTime(source.getCurrentTime());
traffic.setTimeBucket(TimeBucket.getMinuteTimeBucket(source.getCurrentTime()));
-traffic.setScheduleId(Hashing.sha256().newHasher()
- .putString(String.format("%s_%s_%d",
source.getTaskId(), source.getProcessId(), source.getStartTime()),
Charsets.UTF_8)
- .hash().toString());
+traffic.setScheduleId(
+Hashing
+.sha256()
+.newHasher()
+.putString(
+String.format("%s_%s_%d", source.getTaskId(),
source.getProcessId(), source.getStartTime()),
+Charsets.UTF_8
+)
+.hash().toString());
MetricsStreamProcessor.getInstance().in(traffic);
}
}
diff --git
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/ebpf/storage/EBPFProfilingDataRecord.java
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/ebpf/storage/EBPFProfilingDataRecord.java
index b40aa23488..41885e3a7c 100644
---
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/ebpf/storage/EBPFProfilingDataRecord.java
+++
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/ebpf/storage/EBPFProfilingDataRecord.java
@@ -18,8 +18,8 @@
package org.apache.skywalking.oap.server.core.profiling.ebpf.storage;
+import com.google.common.base.Charsets;
import com.google.common.hash.Hashing;
-import com.linecorp.armeria.internal.shaded.guava.base.Charsets;
import lombok.Data;
import org.apache.skywalking.oap.server.core.analysis.Stream;
import org.apache.skywalking.oap.server.core.analysis.record.Record;
diff --git
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/EBPFProcessProfilingSchedule.java
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/EBPFProcessProfilingSchedule.java
index bcae3f6e4c..10aa5f09bc 100644
---
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/EBPFProcessProfilingSchedule.java
+++
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/EBPFProcessProfilingSchedule.java
@@ -18,8 +18,8 @@
package org.apache.skywalking.oap.server.core.source;
+import com.google.common.base.Charsets;
import com.google.common.hash.Hashing;
-import com.linecorp.armeria.internal.shaded.guava.base.Charsets;
import lombok.Getter;
import lombok.Setter;
@@ -41,8 +41,8 @@ public class EBPFProcessProfilingSchedule extends Source {
public String getEntityId() {
if (entityId == null) {
entityId = Hashing.sha256().newHasher()
-.putString(String.format("%s_%s_%d", taskId, processId,
startTime), Charsets.UTF_8)
-.hash().toString();
+ .putString(String.format("%s_%s_%d", taskId,
processId, startTime), Charsets.UTF_8)
+ .hash().toString();
}
return entityId;
[skywalking] branch chore created (now 2daf1a2ad6)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch chore in repository https://gitbox.apache.org/repos/asf/skywalking.git at 2daf1a2ad6 Fix import This branch includes the following new commits: new 2daf1a2ad6 Fix import The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
Re: [I] [Bug] Some classes use shaded version of Guava's `Charsets` class [skywalking]
wu-sheng commented on issue #11435: URL: https://github.com/apache/skywalking/issues/11435#issuecomment-1771839458 This class is from Armeria project, not us. If you feel there is an issue, please report to them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Some classes use shaded version of Guava's `Charsets` class [skywalking]
wu-sheng closed issue #11435: [Bug] Some classes use shaded version of Guava's `Charsets` class URL: https://github.com/apache/skywalking/issues/11435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] Some classes use shaded version of Guava's `Charsets` class [skywalking]
Marcono1234 opened a new issue, #11435: URL: https://github.com/apache/skywalking/issues/11435 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component OAP server (apache/skywalking) ### What happened The following classes use a shaded / repackaged version of Guava's `Charsets` class. I assume this was done by accident (possibly due to IDE completion) since Guava also seems to be a dependency. - https://github.com/apache/skywalking/blob/1a27da5727303738b554780906838e73af008e42/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/ebpf/storage/EBPFProcessProfilingScheduleDispatcher.java#L22 - https://github.com/apache/skywalking/blob/1a27da5727303738b554780906838e73af008e42/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/ebpf/storage/EBPFProfilingDataRecord.java#L22 - https://github.com/apache/skywalking/blob/1a27da5727303738b554780906838e73af008e42/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/EBPFProcessProfilingSchedule.java#L22 As side note: These usages of `Charsets` can probably also be replaced with JDK's [`StandardCharsets`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/nio/charset/StandardCharsets.html) added in Java 7. ### What you expected to happen `com.google.common.base.Charsets` or ` java.nio.charset.StandardCharsets` should be imported ### How to reproduce _not applicable, see description above_ ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support etcd client authentication [skywalking-banyandb]
hailin0 commented on code in PR #331:
URL:
https://github.com/apache/skywalking-banyandb/pull/331#discussion_r1365725043
##
docs/installation/cluster.md:
##
@@ -28,3 +28,45 @@ The host is registered to the etcd cluster by the
`banyand-server` automatically
- `node-host-provider=hostname` : Default. The OS's hostname is registered as
the host part in the address.
- `node-host-provider=ip` : The OS's the first non-loopback active IP
address(IPv4) is registered as the host part in the address.
- `node-host-provider=flag` : `node-host` is registered as the host part in
the address.
+
+## Etcd Client Authentication
+
+etcd supports through tls certificates and RBAC based authentication for both
clients to server communication. This section is intended to help users set up
authentication in etcd client.
Review Comment:
fixed
##
test/integration/etcd/client_test.go:
##
@@ -0,0 +1,304 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package integration_etcd_test
+
+import (
+ "context"
+ "crypto/tls"
+ "fmt"
+ "log"
+ "net/url"
+ "path/filepath"
+ "time"
+
+ . "github.com/onsi/ginkgo/v2"
+ . "github.com/onsi/gomega"
+ "github.com/onsi/gomega/gleak"
+ "go.etcd.io/etcd/client/pkg/v3/transport"
+ clientv3 "go.etcd.io/etcd/client/v3"
+ "go.etcd.io/etcd/server/v3/embed"
+
+ databasev1
"github.com/apache/skywalking-banyandb/api/proto/banyandb/database/v1"
+ "github.com/apache/skywalking-banyandb/banyand/metadata/schema"
+ "github.com/apache/skywalking-banyandb/pkg/test"
+ "github.com/apache/skywalking-banyandb/pkg/test/flags"
+ "github.com/apache/skywalking-banyandb/pkg/test/helpers"
+ "github.com/apache/skywalking-banyandb/pkg/test/setup"
+)
+
+const host = "127.0.0.1"
+
+const namespace = "liaison-test"
+
+const nodeHost = "liaison-1"
+
+var _ = Describe("Client Test", func() {
+ var (
+ dirstring
+ dirSpaceDeffunc()
+ caFilePath string
+ serverKeyFilePath string
+ serverCertFilePath string
+ clientKeyFilePath string
+ clientCertFilePath string
+ goods []gleak.Goroutine
+ )
+ BeforeEach(func() {
+ var err error
+ dir, dirSpaceDef, err = test.NewSpace()
+ Expect(err).ShouldNot(HaveOccurred())
+ caFilePath, err = filepath.Abs("./cafile/ca.crt")
+ Expect(err).ShouldNot(HaveOccurred())
+ serverKeyFilePath, err =
filepath.Abs("./cafile/server-serverusage.key.insecure")
+ Expect(err).ShouldNot(HaveOccurred())
+ serverCertFilePath, err =
filepath.Abs("./cafile/server-serverusage.crt")
+ Expect(err).ShouldNot(HaveOccurred())
+ clientKeyFilePath, err =
filepath.Abs("./cafile/client-clientusage.key.insecure")
+ Expect(err).ShouldNot(HaveOccurred())
+ clientCertFilePath, err =
filepath.Abs("./cafile/client-clientusage.crt")
+ Expect(err).ShouldNot(HaveOccurred())
+
+ goods = gleak.Goroutines()
+ })
+ AfterEach(func() {
+ dirSpaceDef()
+ Eventually(gleak.Goroutines,
flags.EventuallyTimeout).ShouldNot(gleak.HaveLeaked(goods))
+ })
+
+ It("should be using user/password connect etcd server successfully",
func() {
+ serverTLSInfo := transport.TLSInfo{}
+ clientTLSInfo := transport.TLSInfo{}
+ clientConfig, err := clientTLSInfo.ClientConfig()
+ Expect(err).ShouldNot(HaveOccurred())
+ username := "banyandb"
+ password := "banyandb"
+
+ etcdServer, err := createEtcdServer(dir, serverTLSInfo)
+ Expect(err).ShouldNot(HaveOccurred())
+ // wait for e.Server to join the cluster
+ <-etcdServer.Server.ReadyNotify()
+ etcdEndpoint := etcdServer.Config().ListenClientUrls[0].String()
+ defer etcdServer.Close()
+
+
Re: [PR] Support etcd client authentication [skywalking-banyandb]
hailin0 commented on code in PR #331: URL: https://github.com/apache/skywalking-banyandb/pull/331#discussion_r1365724065 ## docs/installation/cluster.md: ## @@ -28,3 +28,45 @@ The host is registered to the etcd cluster by the `banyand-server` automatically - `node-host-provider=hostname` : Default. The OS's hostname is registered as the host part in the address. - `node-host-provider=ip` : The OS's the first non-loopback active IP address(IPv4) is registered as the host part in the address. - `node-host-provider=flag` : `node-host` is registered as the host part in the address. + +## Etcd Client Authentication + +etcd supports through tls certificates and RBAC based authentication for both clients to server communication. This section is intended to help users set up authentication in etcd client. + +### Client-to-server authentication with username/password + +The etcd user can be setup by the [etcd authentication guide](https://etcd.io/docs/v3.5/op-guide/authentication/) + +The username/password is configured in the following command: Review Comment: added `note` ## docs/installation/cluster.md: ## @@ -28,3 +28,45 @@ The host is registered to the etcd cluster by the `banyand-server` automatically - `node-host-provider=hostname` : Default. The OS's hostname is registered as the host part in the address. - `node-host-provider=ip` : The OS's the first non-loopback active IP address(IPv4) is registered as the host part in the address. - `node-host-provider=flag` : `node-host` is registered as the host part in the address. + +## Etcd Client Authentication + +etcd supports through tls certificates and RBAC based authentication for both clients to server communication. This section is intended to help users set up authentication in etcd client. + +### Client-to-server authentication with username/password + +The etcd user can be setup by the [etcd authentication guide](https://etcd.io/docs/v3.5/op-guide/authentication/) + +The username/password is configured in the following command: + +- `etcd-username`: The username for etcd client authentication. +- `etcd-password`: The password for etcd client authentication. + +```shell +$ ./banyand-server storage --etcd-endpoints=your-endpoints --etcd-username=your-username --etcd-password=your-password +$ ./banyand-server liaison --etcd-endpoints=your-endpoints --etcd-username=your-username --etcd-password=your-password +``` + +### Client-to-server transport security with HTTPS + +The etcd trusted certificate file can be setup by the [etcd transport security model](https://etcd.io/docs/v3.5/op-guide/security/#example-1-client-to-server-transport-security-with-https) + +- `etcd-tls-ca-file`: The path of the trusted certificate file. + +```shell +$ ./banyand-server storage --etcd-endpoints=your-https-endpoints --etcd-tls-ca-file=youf-file-path +$ ./banyand-server liaison --etcd-endpoints=your-https-endpoints --etcd-tls-ca-file=youf-file-path +``` + +### Client-to-server authentication with HTTPS client certificates Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support etcd client authentication [skywalking-banyandb]
hailin0 commented on code in PR #331:
URL:
https://github.com/apache/skywalking-banyandb/pull/331#discussion_r1365725432
##
test/integration/etcd/client_test.go:
##
@@ -0,0 +1,304 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package integration_etcd_test
+
+import (
+ "context"
+ "crypto/tls"
+ "fmt"
+ "log"
+ "net/url"
+ "path/filepath"
+ "time"
+
+ . "github.com/onsi/ginkgo/v2"
+ . "github.com/onsi/gomega"
+ "github.com/onsi/gomega/gleak"
+ "go.etcd.io/etcd/client/pkg/v3/transport"
+ clientv3 "go.etcd.io/etcd/client/v3"
+ "go.etcd.io/etcd/server/v3/embed"
+
+ databasev1
"github.com/apache/skywalking-banyandb/api/proto/banyandb/database/v1"
+ "github.com/apache/skywalking-banyandb/banyand/metadata/schema"
+ "github.com/apache/skywalking-banyandb/pkg/test"
+ "github.com/apache/skywalking-banyandb/pkg/test/flags"
+ "github.com/apache/skywalking-banyandb/pkg/test/helpers"
+ "github.com/apache/skywalking-banyandb/pkg/test/setup"
+)
+
+const host = "127.0.0.1"
+
+const namespace = "liaison-test"
+
+const nodeHost = "liaison-1"
+
+var _ = Describe("Client Test", func() {
+ var (
+ dirstring
+ dirSpaceDeffunc()
+ caFilePath string
+ serverKeyFilePath string
+ serverCertFilePath string
+ clientKeyFilePath string
+ clientCertFilePath string
+ goods []gleak.Goroutine
+ )
+ BeforeEach(func() {
+ var err error
+ dir, dirSpaceDef, err = test.NewSpace()
+ Expect(err).ShouldNot(HaveOccurred())
+ caFilePath, err = filepath.Abs("./cafile/ca.crt")
Review Comment:
fixed
##
.licenserc.yaml:
##
@@ -85,6 +85,7 @@ header: # `header` section is configurations for source codes
license header.
- 'ui'
- '.github/PULL_REQUEST_TEMPLATE'
- "**/*.prof"
+- "**/test/integration/etcd/cafile/**"
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support etcd client authentication [skywalking-banyandb]
hailin0 commented on code in PR #331: URL: https://github.com/apache/skywalking-banyandb/pull/331#discussion_r1365724556 ## docs/installation/cluster.md: ## @@ -28,3 +28,45 @@ The host is registered to the etcd cluster by the `banyand-server` automatically - `node-host-provider=hostname` : Default. The OS's hostname is registered as the host part in the address. - `node-host-provider=ip` : The OS's the first non-loopback active IP address(IPv4) is registered as the host part in the address. - `node-host-provider=flag` : `node-host` is registered as the host part in the address. + +## Etcd Client Authentication + +etcd supports through tls certificates and RBAC based authentication for both clients to server communication. This section is intended to help users set up authentication in etcd client. + +### Client-to-server authentication with username/password + +The etcd user can be setup by the [etcd authentication guide](https://etcd.io/docs/v3.5/op-guide/authentication/) + +The username/password is configured in the following command: + +- `etcd-username`: The username for etcd client authentication. +- `etcd-password`: The password for etcd client authentication. + +```shell +$ ./banyand-server storage --etcd-endpoints=your-endpoints --etcd-username=your-username --etcd-password=your-password +$ ./banyand-server liaison --etcd-endpoints=your-endpoints --etcd-username=your-username --etcd-password=your-password +``` + +### Client-to-server transport security with HTTPS Review Comment: fixed ## docs/installation/cluster.md: ## @@ -28,3 +28,45 @@ The host is registered to the etcd cluster by the `banyand-server` automatically - `node-host-provider=hostname` : Default. The OS's hostname is registered as the host part in the address. - `node-host-provider=ip` : The OS's the first non-loopback active IP address(IPv4) is registered as the host part in the address. - `node-host-provider=flag` : `node-host` is registered as the host part in the address. + +## Etcd Client Authentication + +etcd supports through tls certificates and RBAC based authentication for both clients to server communication. This section is intended to help users set up authentication in etcd client. + +### Client-to-server authentication with username/password Review Comment: fixed ## docs/installation/cluster.md: ## @@ -28,3 +28,45 @@ The host is registered to the etcd cluster by the `banyand-server` automatically - `node-host-provider=hostname` : Default. The OS's hostname is registered as the host part in the address. - `node-host-provider=ip` : The OS's the first non-loopback active IP address(IPv4) is registered as the host part in the address. - `node-host-provider=flag` : `node-host` is registered as the host part in the address. + +## Etcd Client Authentication Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Feature] GraalVM Native Image support (Experimental). [skywalking]
wu-sheng commented on code in PR #11365:
URL: https://github.com/apache/skywalking/pull/11365#discussion_r1365620656
##
oap-server/server-library/library-elasticsearch-client/src/main/java/org/apache/skywalking/library/elasticsearch/response/search/SearchHits.java:
##
@@ -48,7 +48,7 @@ public Iterator iterator() {
return getHits().iterator();
}
-static final class TotalDeserializer extends JsonDeserializer {
+public static final class TotalDeserializer extends
JsonDeserializer {
Review Comment:
OK. Let's continue the discussion after you have more conclusions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Feature] GraalVM Native Image support (Experimental). [skywalking]
yswdqz commented on code in PR #11365:
URL: https://github.com/apache/skywalking/pull/11365#discussion_r1365616426
##
oap-server/server-library/library-elasticsearch-client/src/main/java/org/apache/skywalking/library/elasticsearch/response/search/SearchHits.java:
##
@@ -48,7 +48,7 @@ public Iterator iterator() {
return getHits().iterator();
}
-static final class TotalDeserializer extends JsonDeserializer {
+public static final class TotalDeserializer extends
JsonDeserializer {
Review Comment:
In SkyWalkingFeature, but I'm hesitating on whether to keep this class. I'll
take a look after the CI for my repository finishes running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Feature] GraalVM Native Image support (Experimental). [skywalking]
wu-sheng commented on code in PR #11365:
URL: https://github.com/apache/skywalking/pull/11365#discussion_r1365613468
##
oap-server/server-library/library-elasticsearch-client/src/main/java/org/apache/skywalking/library/elasticsearch/response/search/SearchHits.java:
##
@@ -48,7 +48,7 @@ public Iterator iterator() {
return getHits().iterator();
}
-static final class TotalDeserializer extends JsonDeserializer {
+public static final class TotalDeserializer extends
JsonDeserializer {
Review Comment:
As an inner class, it should be accessible outside. Where do you use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Feature] GraalVM Native Image support (Experimental). [skywalking]
wu-sheng commented on code in PR #11365: URL: https://github.com/apache/skywalking/pull/11365#discussion_r1365610766 ## graal/graal-server-starter/src/main/resources/META-INF/native-image/main/jni-config.json: ## @@ -0,0 +1,115 @@ +[ Review Comment: If the doc is short enough, you could update https://skywalking.apache.org/docs/main/next/en/setup/backend/backend-graalvm/#compile-guide. If it is complex, we should consider to separate the docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Feature] GraalVM Native Image support (Experimental). [skywalking]
wu-sheng commented on code in PR #11365: URL: https://github.com/apache/skywalking/pull/11365#discussion_r1365605776 ## graal/graal-server-starter/src/main/resources/META-INF/native-image/main/jni-config.json: ## @@ -0,0 +1,115 @@ +[ Review Comment: I think we need a doc to guide developers about how to build this file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Feature] GraalVM Native Image support (Experimental). [skywalking]
wu-sheng commented on code in PR #11365: URL: https://github.com/apache/skywalking/pull/11365#discussion_r1365605776 ## graal/graal-server-starter/src/main/resources/META-INF/native-image/main/jni-config.json: ## @@ -0,0 +1,115 @@ +[ Review Comment: I think we need a doc to guide this about how to build this file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Feature] GraalVM Native Image support (Experimental). [skywalking]
wu-sheng commented on code in PR #11365:
URL: https://github.com/apache/skywalking/pull/11365#discussion_r1365599917
##
graal/graal-server-starter/src/main/java/org/apache/skywalking/graal/SkywalkingFeature.java:
##
@@ -0,0 +1,75 @@
+package org.apache.skywalking.graal;
+
+import org.apache.kafka.clients.consumer.RangeAssignor;
+import org.apache.skywalking.library.elasticsearch.response.Document;
+import org.apache.skywalking.library.elasticsearch.response.Documents;
+import org.apache.skywalking.library.elasticsearch.response.Index;
+import org.apache.skywalking.library.elasticsearch.response.IndexTemplate;
+import org.apache.skywalking.library.elasticsearch.response.IndexTemplates;
+import org.apache.skywalking.library.elasticsearch.response.Mappings;
+import org.apache.skywalking.library.elasticsearch.response.NodeInfo;
+import org.apache.skywalking.library.elasticsearch.response.search.SearchHit;
+import org.apache.skywalking.library.elasticsearch.response.search.SearchHits;
+import
org.apache.skywalking.library.elasticsearch.response.search.SearchResponse;
+import
org.apache.skywalking.oap.server.analyzer.agent.kafka.module.KafkaFetcherConfig;
+import org.apache.skywalking.oap.server.core.query.input.Duration;
+import
org.apache.skywalking.oap.server.storage.plugin.banyandb.BanyanDBStorageConfig;
+import
org.apache.skywalking.oap.server.storage.plugin.elasticsearch.StorageModuleElasticsearchConfig;
+import org.graalvm.nativeimage.hosted.Feature;
+import org.graalvm.nativeimage.hosted.RuntimeReflection;
+
+import java.util.Arrays;
+import java.util.List;
+
+public class SkywalkingFeature implements Feature {
Review Comment:
Please add comments to explain what this is about.
```suggestion
public class SkyWalkingFeature implements Feature {
```
`skywalking` should always be `SkyWalking`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Feature] GraalVM Native Image support (Experimental). [skywalking]
yswdqz commented on code in PR #11365:
URL: https://github.com/apache/skywalking/pull/11365#discussion_r1365600698
##
oap-server/server-library/library-elasticsearch-client/src/main/java/org/apache/skywalking/library/elasticsearch/response/search/SearchHits.java:
##
@@ -48,7 +48,7 @@ public Iterator iterator() {
return getHits().iterator();
}
-static final class TotalDeserializer extends JsonDeserializer {
+public static final class TotalDeserializer extends
JsonDeserializer {
Review Comment:
II want to simply reference this class in another class, but maybe I should
use a different approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Feature] GraalVM Native Image support (Experimental). [skywalking]
wu-sheng commented on code in PR #11365:
URL: https://github.com/apache/skywalking/pull/11365#discussion_r1365597492
##
graal/graal-server-starter/pom.xml:
##
@@ -98,13 +98,21 @@
oal-rt-graal-native
${project.version}
+
+
+org.graalvm.sdk
+graal-sdk
+23.0.1
Review Comment:
Please manage the version from the bom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Feature] GraalVM Native Image support (Experimental). [skywalking]
wu-sheng commented on code in PR #11365:
URL: https://github.com/apache/skywalking/pull/11365#discussion_r1365596306
##
oap-server/server-library/library-elasticsearch-client/src/main/java/org/apache/skywalking/library/elasticsearch/response/search/SearchHits.java:
##
@@ -48,7 +48,7 @@ public Iterator iterator() {
return getHits().iterator();
}
-static final class TotalDeserializer extends JsonDeserializer {
+public static final class TotalDeserializer extends
JsonDeserializer {
Review Comment:
Is this an unexpected change? Why `public`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[skywalking-nodejs] annotated tag v0.7.0 deleted (was 6a08265)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to annotated tag v0.7.0 in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git *** WARNING: tag v0.7.0 was deleted! *** tag was 6a08265 The revisions that were on this annotated tag are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Unify query planner and executor [skywalking-banyandb]
zesiar0 closed pull request #307: Unify query planner and executor URL: https://github.com/apache/skywalking-banyandb/pull/307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-nodejs] annotated tag v0.7.0 updated (4f9a91d -> 6a08265)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to annotated tag v0.7.0 in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git *** WARNING: tag v0.7.0 was modified! *** from 4f9a91d (commit) to 6a08265 (tag) tagging 4f9a91dad3dfd8cfe5ba8f7bd06b39e11eb5e65e (commit) replaces v0.6.0 by kezhenxu94 on Thu Oct 19 21:21:15 2023 +0800 - Log - Release Apache SkyWalking-NodeJS 0.7.0 --- No new revisions were added by this update. Summary of changes:
Re: [I] [Bug] php cannot use ini_set('skywalking_agent.service_name','value'); [skywalking]
wu-sheng closed issue #11433: [Bug] php cannot use
ini_set('skywalking_agent.service_name','value');
URL: https://github.com/apache/skywalking/issues/11433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[I] [Bug] php cannot use ini_set('skywalking_agent.service_name','value'); [skywalking]
hyper-self opened a new issue, #11433: URL: https://github.com/apache/skywalking/issues/11433 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component PHP (apache/skywalking-php) ### What happened no ### What you expected to happen ini_set() can used ### How to reproduce no ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-website] branch asf-site updated: deploy: 0eb655cfb6bc87fec87be1795db57a560bc083bb
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 14a04f78f2f deploy: 0eb655cfb6bc87fec87be1795db57a560bc083bb
14a04f78f2f is described below
commit 14a04f78f2fa6ca515d66e45b4286da9f53c4efc
Author: wu-sheng
AuthorDate: Thu Oct 19 12:48:44 2023 +
deploy: 0eb655cfb6bc87fec87be1795db57a560bc083bb
---
.../next/en/advanced-features/grpc-tls/index.html | 6 +++---
.../next/en/advanced-features/logging-setup/index.html | 6 +++---
.../advanced-features/manual-apis/toolkit-trace/index.html | 4 ++--
.../next/en/advanced-features/plugin-exclusion/index.html | 4 ++--
.../next/en/advanced-features/settings-override/index.html | 6 +++---
.../next/en/agent/performance-tests/index.html | 6 +++---
.../next/en/agent/plugin-configurations/index.html | 4 ++--
.../skywalking-go/next/en/agent/support-plugins/index.html | 4 ++--
.../next/en/agent/tracing-metrics-logging/index.html | 4 ++--
.../en/concepts-and-designs/hybrid-compilation/index.html | 4 ++--
.../next/en/concepts-and-designs/key-principles/index.html | 12 ++--
.../en/concepts-and-designs/project-structure/index.html | 4 ++--
.../build-and-use-agent/index.html | 4 ++--
.../development-guide/index.html | 10 +-
.../development-and-contribution/how-to-release/index.html | 8
.../running-and-debugging/index.html | 4 ++--
.../write-plugin-testing/index.html| 14 +++---
docs/skywalking-go/next/en/setup/docker/index.html | 4 ++--
docs/skywalking-go/next/en/setup/gobuild/index.html| 4 ++--
docs/skywalking-go/next/menu.yml | 2 +-
docs/skywalking-go/next/readme/index.html | 4 ++--
index.json | 2 +-
team/index.html| 8
23 files changed, 64 insertions(+), 64 deletions(-)
diff --git a/docs/skywalking-go/next/en/advanced-features/grpc-tls/index.html
b/docs/skywalking-go/next/en/advanced-features/grpc-tls/index.html
index c18fe9782a2..f0488cc9a80 100644
--- a/docs/skywalking-go/next/en/advanced-features/grpc-tls/index.html
+++ b/docs/skywalking-go/next/en/advanced-features/grpc-tls/index.html
@@ -415,7 +415,7 @@ if (!doNotTrack) {
-Tracing
APIs
+Tracing
APIs
@@ -549,7 +549,7 @@ if (!doNotTrack) {
})()
- Commit Id: 8cf0011
+ Commit Id: ff7ad0d
@@ -587,7 +587,7 @@ In some use cases, end users report the background:
Creating SSL/TLS Certificates
The first step is to generate certificates and key files for encrypting
communication. This is
fairly straightforward: use openssl from the command line.
-Use this https://github.com/apache/skywalking-go/tree/8cf001163fa7faf443ef46841c43fe64104fda80/tools/TLS/tls_key_generate.sh;>script
if you are not familiar with how to generate key files.
+Use this https://github.com/apache/skywalking-go/tree/ff7ad0ddecba4947f118fc28b98cdc599ca13e47/tools/TLS/tls_key_generate.sh;>script
if you are not familiar with how to generate key files.
We need the following files:
client.pem: A private RSA key to sign and authenticate the
public key. Its either a PKCS#8(PEM) or PKCS#1(DER).
diff --git
a/docs/skywalking-go/next/en/advanced-features/logging-setup/index.html
b/docs/skywalking-go/next/en/advanced-features/logging-setup/index.html
index b47bc87185b..0fb46ac1258 100644
--- a/docs/skywalking-go/next/en/advanced-features/logging-setup/index.html
+++ b/docs/skywalking-go/next/en/advanced-features/logging-setup/index.html
@@ -412,7 +412,7 @@ if (!doNotTrack) {
-Tracing
APIs
+Tracing
APIs
@@ -546,7 +546,7 @@ if (!doNotTrack) {
})()
- Commit Id: 8cf0011
+ Commit Id: ff7ad0d
@@ -581,7 +581,7 @@ if (!doNotTrack) {
Logging Setup
Logging Setup is used to integrate the Go Agent with the logging system in
the current service.
It currently supports the recognition of Logrus and
Zap frameworks. If neither of these frameworks is present, it
would output logs using Std Error.
-You can learn about the configuration details through the log
configuration item in the https://github.com/apache/skywalking-go/tree/8cf001163fa7faf443ef46841c43fe64104fda80/tools/go-agent/config/agent.default.yaml;>default
settings.
+You can learn about the configuration details through the log
configuration item in the
Re: [PR] Fix url about toolkit-trace documentation [skywalking-go]
wu-sheng merged PR #130: URL: https://github.com/apache/skywalking-go/pull/130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-go] branch main updated: Fix url about toolkit-trace documentation (#130)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-go.git The following commit(s) were added to refs/heads/main by this push: new ff7ad0d Fix url about toolkit-trace documentation (#130) ff7ad0d is described below commit ff7ad0ddecba4947f118fc28b98cdc599ca13e47 Author: Alipebt <1160756...@qq.com> AuthorDate: Thu Oct 19 19:42:02 2023 +0800 Fix url about toolkit-trace documentation (#130) --- docs/menu.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/menu.yml b/docs/menu.yml index ae01884..53f4175 100644 --- a/docs/menu.yml +++ b/docs/menu.yml @@ -45,7 +45,7 @@ catalog: - name: Manual APIs catalog: - name: Tracing APIs - path: /en/advanced-features/manual-apis/toolkit-trace.md + path: /en/advanced-features/manual-apis/toolkit-trace - name: Plugins catalog: - name: Supported Libraries
Re: [PR] Support collect ZGC memory pool metrics [skywalking]
Z-Beatles commented on PR #11432: URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1770699247 ### changes: 1. Add a new widget `JVM Memory Detail (MB)` to show memory pool detail. 2. Support collect and show ZGC memory pool metrics. ### before:  ### after: Case1: app start up use default G1 gc. `-XX:+UseG1GC`  Case2: app start up use ZGC. `-XX:+UseZGC`  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support collect ZGC memory pool metrics [skywalking]
wu-sheng commented on code in PR #11432:
URL: https://github.com/apache/skywalking/pull/11432#discussion_r1365299551
##
oap-server/server-starter/src/main/resources/oal/java-agent.oal:
##
@@ -22,6 +22,17 @@ instance_jvm_memory_heap =
from(ServiceInstanceJVMMemory.used).filter(heapStatus
instance_jvm_memory_noheap =
from(ServiceInstanceJVMMemory.used).filter(heapStatus == false).longAvg();
instance_jvm_memory_heap_max =
from(ServiceInstanceJVMMemory.max).filter(heapStatus == true).longAvg();
instance_jvm_memory_noheap_max =
from(ServiceInstanceJVMMemory.max).filter(heapStatus == false).longAvg();
+instance_jvm_memory_pool_code_cache =
from(ServiceInstanceJVMMemoryPool.used).filter(poolType ==
MemoryPoolType.CODE_CACHE_USAGE).longAvg();
+instance_jvm_memory_pool_newgen =
from(ServiceInstanceJVMMemoryPool.used).filter(poolType ==
MemoryPoolType.NEWGEN_USAGE).longAvg();
+instance_jvm_memory_pool_oldgen =
from(ServiceInstanceJVMMemoryPool.used).filter(poolType ==
MemoryPoolType.OLDGEN_USAGE).longAvg();
+instance_jvm_memory_pool_survivor =
from(ServiceInstanceJVMMemoryPool.used).filter(poolType ==
MemoryPoolType.SURVIVOR_USAGE).longAvg();
+instance_jvm_memory_pool_permgen =
from(ServiceInstanceJVMMemoryPool.used).filter(poolType ==
MemoryPoolType.PERMGEN_USAGE).longAvg();
Review Comment:
Why these? All thses are not new metrics.
I am not following.
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/general/general-instance.json:
##
@@ -326,7 +326,88 @@
]
},
{
- "x": 8,
+ "x": 16,
+ "y": 0,
+ "w": 8,
+ "h": 13,
+ "i": "5",
+ "type": "Widget",
+ "widget": {
+"title": "JVM Memory Detail (MB)"
Review Comment:
Are you adding a new widget?
This name doesn't seem diff from other GC model.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Fix url about toolkit-trace documentation [skywalking-go]
Alipebt opened a new pull request, #130: URL: https://github.com/apache/skywalking-go/pull/130 Fix problem：https://github.com/apache/skywalking-go/pull/104#issuecomment-1770349895 ### Change - Remove the suffix from the path of toolkit-trace documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support collect ZGC memory pool metrics [skywalking]
Z-Beatles commented on PR #11432: URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1770507682  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support collect ZGC memory pool metrics [skywalking-java]
Z-Beatles commented on code in PR #622:
URL: https://github.com/apache/skywalking-java/pull/622#discussion_r1365260577
##
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/memorypool/ZGCCollectorModule.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.agent.core.jvm.memorypool;
+
+import org.apache.skywalking.apm.network.language.agent.v3.MemoryPool;
+import org.apache.skywalking.apm.network.language.agent.v3.PoolType;
+
+import java.lang.management.MemoryPoolMXBean;
+import java.lang.management.MemoryUsage;
+import java.util.LinkedList;
+import java.util.List;
+
+public class ZGCCollectorModule implements MemoryPoolMetricsAccessor {
+
+private final List beans;
+
+public ZGCCollectorModule(List beans) {
+this.beans = beans;
+}
+
+@Override
+public List getMemoryPoolMetricsList() {
+List poolList = new LinkedList<>();
+for (MemoryPoolMXBean bean : beans) {
+String name = bean.getName();
+PoolType type;
+if (name.equals("ZHeap")) {
+type = PoolType.ZHEAP_USAGE;
+} else if (name.equals("Metaspace")) {
+type = PoolType.METASPACE_USAGE;
+} else if (name.equals("Compressed Class Space")) {
+type = PoolType.COMPRESSED_CLASS_SPACE_USAGE;
+} else if (name.equals("CodeHeap 'non-nmethods'")) {
Review Comment:
Yes, as we can see i added a panel `JVM Memory Detail (MB)` on UI to show
memory pool detail after `JVM Memory (MB)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[skywalking-booster-ui] branch dependabot/npm_and_yarn/tough-cookie-and-cypress/request-4.1.3 deleted (was 6006e03d)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/tough-cookie-and-cypress/request-4.1.3 in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git was 6006e03d Merge branch 'main' into dependabot/npm_and_yarn/tough-cookie-and-cypress/request-4.1.3 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] build(deps): bump tough-cookie and @cypress/request [skywalking-booster-ui]
dependabot[bot] commented on PR #328: URL: https://github.com/apache/skywalking-booster-ui/pull/328#issuecomment-1770498559 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] build(deps): bump tough-cookie and @cypress/request [skywalking-booster-ui]
Fine0830 closed pull request #328: build(deps): bump tough-cookie and @cypress/request URL: https://github.com/apache/skywalking-booster-ui/pull/328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support collect ZGC memory pool metrics [skywalking-data-collect-protocol]
Z-Beatles commented on PR #86: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/86#issuecomment-1770491572 > Provide the JVM doc about these pool types,please. `ZHEAP_USAGE = 6;` ZGC was initially introduced as an experimental feature in JDK 11, and was declared Production Ready in JDK 15. In JDK 21 was reimplemented to support generations. [JEP 377: ZGC: A Scalable Low-Latency Garbage Collector (Production)](https://openjdk.org/jeps/377) `COMPRESSED_CLASS_SPACE_USAGE = 7;` Compressed Class Space is a part of [Metaspace](https://wiki.openjdk.org/display/HotSpot/Metaspace). `CODEHEAP_NON_NMETHODS_USAGE = 8;` `CODEHEAP_PROFILED_NMETHODS_USAGE = 9;` `CODEHEAP_NON_PROFILED_NMETHODS_USAGE = 10;` As of Java 9, the JVM divides the code cache into three distinct segments each of which contains a particular type of compiled code. [JEP 197: Segmented Code Cache](https://openjdk.org/jeps/197) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-website] branch asf-site updated: deploy: 0eb655cfb6bc87fec87be1795db57a560bc083bb
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 94f87c61819 deploy: 0eb655cfb6bc87fec87be1795db57a560bc083bb
94f87c61819 is described below
commit 94f87c61819aa20bd1215135dc7cff1768d0ec26
Author: wu-sheng
AuthorDate: Thu Oct 19 10:06:25 2023 +
deploy: 0eb655cfb6bc87fec87be1795db57a560bc083bb
---
index.json | 2 +-
team/index.html | 16
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/index.json b/index.json
index 1c1623b99e6..cb31d3c55ba 100644
--- a/index.json
+++ b/index.json
@@ -1 +1 @@
-[{"body":"","excerpt":"","ref":"/tags/agent/","title":"Agent"},{"body":"CommunityOverCode
(原 ApacheCon) 是 Apache 软件基金会（ASF）的官方全球系列大会。自 1998 年以来\u0026ndash;在 ASF 成立之前
\u0026ndash; ApacheCon 已经吸引了各个层次的参与者，在 300 多个 Apache 项目及其不同的社区中探索
\u0026ldquo;明天的技术\u0026rdquo;。CommunityOverCode
通过动手实作、主题演讲、实际案例研究、培训、黑客松活动等方式，展示 Apache 项目的最新发展和新兴创新。\nCommunityOverCode
展示了无处不在的 Apache 项目的最新突破和 Apache 孵化器中即将到来的创新，以及开源开发和以 Apache
之道领导社区驱动的项目。与会者可以了解到独立于商业利益、企业偏见或推销话术之外的核心开源技术。\nSkyWalking的Golang自动探针实践 刘晗 分布
[...]
\ No newline at end of file
+[{"body":"","excerpt":"","ref":"/tags/agent/","title":"Agent"},{"body":"CommunityOverCode
(原 ApacheCon) 是 Apache 软件基金会（ASF）的官方全球系列大会。自 1998 年以来\u0026ndash;在 ASF 成立之前
\u0026ndash; ApacheCon 已经吸引了各个层次的参与者，在 300 多个 Apache 项目及其不同的社区中探索
\u0026ldquo;明天的技术\u0026rdquo;。CommunityOverCode
通过动手实作、主题演讲、实际案例研究、培训、黑客松活动等方式，展示 Apache 项目的最新发展和新兴创新。\nCommunityOverCode
展示了无处不在的 Apache 项目的最新突破和 Apache 孵化器中即将到来的创新，以及开源开发和以 Apache
之道领导社区驱动的项目。与会者可以了解到独立于商业利益、企业偏见或推销话术之外的核心开源技术。\nSkyWalking的Golang自动探针实践 刘晗 分布
[...]
\ No newline at end of file
diff --git a/team/index.html b/team/index.html
index dc5a2cc082a..3bb22cbb0cb 100644
--- a/team/index.html
+++ b/team/index.html
@@ -12186,9 +12186,9 @@ The SkyWalking team is comprised of Members and
Contributors, and the growth has
-https://github.com/michaelzangl;
target="_blank">
+https://github.com/wu-sheng; target="_blank">
- michaelzangl
+ wu-sheng
@@ -12196,9 +12196,9 @@ The SkyWalking team is comprised of Members and
Contributors, and the growth has
-https://github.com/alanlvle; target="_blank">
+https://github.com/michaelzangl;
target="_blank">
- alanlvle
+ michaelzangl
@@ -12206,9 +12206,9 @@ The SkyWalking team is comprised of Members and
Contributors, and the growth has
-https://github.com/tianyk; target="_blank">
+https://github.com/alanlvle; target="_blank">
- tianyk
+ alanlvle
@@ -12216,9 +12216,9 @@ The SkyWalking team is comprised of Members and
Contributors, and the growth has
-https://github.com/wu-sheng; target="_blank">
+https://github.com/tianyk; target="_blank">
- wu-sheng
+ tianyk
[skywalking-booster-ui] branch dependabot/npm_and_yarn/tough-cookie-and-cypress/request-4.1.3 updated (6dc1aba9 -> 6006e03d)
This is an automated email from the ASF dual-hosted git repository. qiuxiafan pushed a change to branch dependabot/npm_and_yarn/tough-cookie-and-cypress/request-4.1.3 in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git from 6dc1aba9 build(deps): bump tough-cookie and @cypress/request add 1be2792f build(deps): bump @cypress/request and cypress (#327) add 6006e03d Merge branch 'main' into dependabot/npm_and_yarn/tough-cookie-and-cypress/request-4.1.3 No new revisions were added by this update. Summary of changes: package-lock.json | 129 -- package.json | 2 +- 2 files changed, 68 insertions(+), 63 deletions(-)
[PR] Support collect ZGC memory pool metrics [skywalking]
Z-Beatles opened a new pull request, #11432: URL: https://github.com/apache/skywalking/pull/11432 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). for UI setting change, see [skywalking-java #622](https://github.com/apache/skywalking-java/pull/622) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-booster-ui] branch main updated: build(deps): bump @cypress/request and cypress (#327)
This is an automated email from the ASF dual-hosted git repository.
qiuxiafan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git
The following commit(s) were added to refs/heads/main by this push:
new 1be2792f build(deps): bump @cypress/request and cypress (#327)
1be2792f is described below
commit 1be2792ff46547fafe5b554b0cd4f086dd8d02b7
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AuthorDate: Thu Oct 19 17:41:18 2023 +0800
build(deps): bump @cypress/request and cypress (#327)
---
package-lock.json | 245 ++
package.json | 2 +-
2 files changed, 120 insertions(+), 127 deletions(-)
diff --git a/package-lock.json b/package-lock.json
index a0bbd4ec..ee38aed9 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -42,7 +42,7 @@
"@vue/test-utils": "^2.2.6",
"@vue/tsconfig": "^0.1.3",
"@vueuse/core": "^9.6.0",
-"cypress": "^12.0.2",
+"cypress": "^13.3.2",
"eslint": "^8.22.0",
"eslint-plugin-cypress": "^2.12.1",
"eslint-plugin-vue": "^9.3.0",
@@ -1315,9 +1315,9 @@
}
},
"node_modules/@cypress/request": {
- "version": "2.88.10",
- "resolved":
"https://registry.npmjs.org/@cypress/request/-/request-2.88.10.tgz;,
- "integrity":
"sha512-Zp7F+R93N0yZyG34GutyTNr+okam7s/Fzc1+i3kcqOP8vk6OuajuE9qZJ6Rs+10/1JFtXFYMdyarnU1rZuJesg==",
+ "version": "3.0.1",
+ "resolved":
"https://registry.npmjs.org/@cypress/request/-/request-3.0.1.tgz;,
+ "integrity":
"sha512-TWivJlJi8ZDx2wGOw1dbLuHJKUYX7bWySw377nlnGOW3hP9/MUKIsEdXT/YngWxVdgNCHRBmFlBipE+5/2ZZlQ==",
"dev": true,
"dependencies": {
"aws-sign2": "~0.7.0",
@@ -1333,9 +1333,9 @@
"json-stringify-safe": "~5.0.1",
"mime-types": "~2.1.19",
"performance-now": "^2.1.0",
-"qs": "~6.5.2",
+"qs": "6.10.4",
"safe-buffer": "^5.1.2",
-"tough-cookie": "~2.5.0",
+"tough-cookie": "^4.1.3",
"tunnel-agent": "^0.6.0",
"uuid": "^8.3.2"
},
@@ -2576,9 +2576,9 @@
"dev": true
},
"node_modules/@types/node": {
- "version": "18.11.13",
- "resolved": "https://registry.npmjs.org/@types/node/-/node-18.11.13.tgz;,
- "integrity":
"sha512-IASpMGVcWpUsx5xBOrxMj7Bl8lqfuTY7FKAnPmu5cHkfQVWF8GulWS1jbRqA934qZL35xh5xN/+Xe/i26Bod4w==",
+ "version": "18.18.6",
+ "resolved": "https://registry.npmjs.org/@types/node/-/node-18.18.6.tgz;,
+ "integrity":
"sha512-wf3Vz+jCmOQ2HV1YUJuCWdL64adYxumkrxtc+H1VUQlnQI04+5HtH+qZCOE21lBE7gIrt+CwX2Wv8Acrw5Ak6w==",
"dev": true
},
"node_modules/@types/normalize-package-data": {
@@ -3648,9 +3648,9 @@
}
},
"node_modules/aws4": {
- "version": "1.11.0",
- "resolved": "https://registry.npmjs.org/aws4/-/aws4-1.11.0.tgz;,
- "integrity":
"sha512-xh1Rl34h6Fi1DC2WWKfxUTVqRsNnr6LsKz2+hfwDxQJWmrx8+c7ylaqBMcHfl1U1r2dsifOvKX3LQuLNZ+XSvA==",
+ "version": "1.12.0",
+ "resolved": "https://registry.npmjs.org/aws4/-/aws4-1.12.0.tgz;,
+ "integrity":
"sha512-NmWvPnx0F1SfrQbYwOi7OeaNGokp9XhzNioJ/CSBs8Qa4vxug81mhJEAVZwxXuBmYB5KDRfMq/F3RR0BIU7sWg==",
"dev": true
},
"node_modules/axios": {
@@ -4350,9 +4350,9 @@
}
},
"node_modules/commander": {
- "version": "5.1.0",
- "resolved": "https://registry.npmjs.org/commander/-/commander-5.1.0.tgz;,
- "integrity":
"sha512-P0CysNDQ7rtVw4QIQtm+MRxV66vKFSvlsQvGYXZWR3qFU0jlMKHZZZgw8e+8DSah4UDKMqnknRDQz+xuQXQ/Zg==",
+ "version": "6.2.1",
+ "resolved": "https://registry.npmjs.org/commander/-/commander-6.2.1.tgz;,
+ "integrity":
"sha512-U7VdrJFnJgo4xjrHpTzu0yrHPGImdsmD95ZlgYSEajAn2JKzDhDTPG9kBTefmObL2w/ngeZnilk+OV9CG3d7UA==",
"dev": true,
"engines": {
"node": ">= 6"
@@ -4740,15 +4740,15 @@
"integrity":
"sha512-Z1PhmomIfypOpoMjRQB70jfvy/wxT50qW08YXO5lMIJkrdq4yOTR+AW7FqutScmB9NkLwxo+jU+kZLbofZZq/w=="
},
"node_modules/cypress": {
- "version": "12.0.2",
- "resolved": "https://registry.npmjs.org/cypress/-/cypress-12.0.2.tgz;,
- "integrity":
"sha512-WnLx1DpnbF1vbpDBkgP14rK5yS3U+Gvxrv2fsB4Owma26oIyENj7DDRnsJbSZuTfG4mcuUJxAkRHJR2wBqBfMA==",
+ "version": "13.3.2",
+ "resolved": "https://registry.npmjs.org/cypress/-/cypress-13.3.2.tgz;,
+ "integrity":
"sha512-ArLmZObcLC+xxCp7zJZZbhby9FUf5CueLej9dUM4+5j37FTS4iMSgHxQLDu01PydFUvDXcNoIVRCYrHHxD7Ybg==",
"dev": true,
"hasInstallScript": true,
"dependencies": {
-"@cypress/request": "^2.88.10",
+"@cypress/request": "^3.0.0",
"@cypress/xvfb": "^1.2.4",
-"@types/node": "^14.14.31",
+"@types/node": "^18.17.5",
"@types/sinonjs__fake-timers": "8.1.1",
"@types/sizzle": "^2.3.2",
"arch": "^2.2.0",
@@ -4760,10 +4760,10 @@
Re: [PR] build(deps): bump @cypress/request and cypress [skywalking-booster-ui]
Fine0830 merged PR #327: URL: https://github.com/apache/skywalking-booster-ui/pull/327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-booster-ui] branch dependabot/npm_and_yarn/cypress/request-and-cypress-3.0.1 deleted (was af3a82aa)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/cypress/request-and-cypress-3.0.1 in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git was af3a82aa build(deps): bump @cypress/request and cypress The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[skywalking-nodejs] branch rel/0.7.0 deleted (was eec2fa5)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch rel/0.7.0 in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git was eec2fa5 Draft release for 0.7.0 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[skywalking-nodejs] branch master updated: Draft release for 0.7.0 (#120)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git
The following commit(s) were added to refs/heads/master by this push:
new 4f9a91d Draft release for 0.7.0 (#120)
4f9a91d is described below
commit 4f9a91dad3dfd8cfe5ba8f7bd06b39e11eb5e65e
Author: kezhenxu94
AuthorDate: Thu Oct 19 17:38:50 2023 +0800
Draft release for 0.7.0 (#120)
---
CHANGELOG.md | 4
package-lock.json | 2 +-
package.json | 2 +-
3 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3a6a5d2..ea8eab3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 0.7.0
+
+* Add deadline config for trace request (#118)
+
# 0.6.0
* Add missing build doc by @kezhenxu94 in
https://github.com/apache/skywalking-nodejs/pull/92
diff --git a/package-lock.json b/package-lock.json
index 5c8b742..dc873f5 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,6 +1,6 @@
{
"name": "skywalking-backend-js",
- "version": "0.6.0",
+ "version": "0.7.0",
"lockfileVersion": 1,
"requires": true,
"dependencies": {
diff --git a/package.json b/package.json
index b04092d..9da4a27 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
{
"name": "skywalking-backend-js",
- "version": "0.6.0",
+ "version": "0.7.0",
"description": "The NodeJS agent for Apache SkyWalking",
"homepage": "skywalking.apache.org",
"main": "lib/index.js",
Re: [PR] Draft release for 0.7.0 [skywalking-nodejs]
wu-sheng merged PR #120: URL: https://github.com/apache/skywalking-nodejs/pull/120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-booster-ui] branch dependabot/npm_and_yarn/tough-cookie-and-cypress/request-4.1.3 created (now 6dc1aba9)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/tough-cookie-and-cypress/request-4.1.3 in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git at 6dc1aba9 build(deps): bump tough-cookie and @cypress/request No new revisions were added by this update.
[PR] build(deps): bump tough-cookie and @cypress/request [skywalking-booster-ui]
dependabot[bot] opened a new pull request, #328: URL: https://github.com/apache/skywalking-booster-ui/pull/328 Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) and [@cypress/request](https://github.com/cypress-io/request). These dependencies needed to be updated together. Updates `tough-cookie` from 4.1.2 to 4.1.3 Release notes Sourced from https://github.com/salesforce/tough-cookie/releases;>tough-cookie's releases. 4.1.3 Security fix for Prototype Pollution discovery in https://redirect.github.com/salesforce/tough-cookie/issues/282;>#282. This is a minor release, although output from the inspect utility is affected by this change, we felt this change was important enough to be pushed into the next patch. Commits https://github.com/salesforce/tough-cookie/commit/4ff4d29f6cefd279a412b8d62a21142ebd410b36;>4ff4d29 4.1.3 release preparation, update the package and lib/version to 4.1.3. (https://redirect.github.com/salesforce/tough-cookie/issues/284;>#284) https://github.com/salesforce/tough-cookie/commit/12d474791bb856004e858fdb1c47b7608d09cf6e;>12d4747 Prevent prototype pollution in cookie memstore (https://redirect.github.com/salesforce/tough-cookie/issues/283;>#283) https://github.com/salesforce/tough-cookie/commit/f06b72d1d447f33dfa6222c0a3c0c5e063558248;>f06b72d Fix documentation for store.findCookies, missing allowSpecialUseDomain proper... See full diff in https://github.com/salesforce/tough-cookie/compare/v4.1.2...v4.1.3;>compare view Updates `@cypress/request` from 2.88.10 to 2.88.12 Release notes Sourced from https://github.com/cypress-io/request/releases;>@cypress/request's releases. v2.88.12 https://github.com/cypress-io/request/compare/v2.88.11...v2.88.12;>2.88.12 (2023-08-01) Bug Fixes request: update tough-cookie dep (https://github.com/cypress-io/request/commit/0664780557c95610eafeedff6067bacac6783705;>0664780) v2.88.11 https://github.com/cypress-io/request/compare/v2.88.10...v2.88.11;>2.88.11 (2023-01-11) Bug Fixes Remove badges no longer used or relevant (https://redirect.github.com/cypress-io/request/issues/19;>#19) (https://github.com/cypress-io/request/commit/24a977e9c8b867fbd4ad752e2253f8fe204ff039;>24a977e) Commits https://github.com/cypress-io/request/commit/0664780557c95610eafeedff6067bacac6783705;>0664780 fix(request): update tough-cookie dep https://github.com/cypress-io/request/commit/30def80c9d957ed2a782af634602f26eb41843ee;>30def80 Merge pull request https://redirect.github.com/cypress-io/request/issues/39;>#39 from cypress-io/jordanpowell88/update-pkg-version https://github.com/cypress-io/request/commit/6b79405e704e882df06b68961ab2835c56d7cbcf;>6b79405 update package version https://github.com/cypress-io/request/commit/bfbb95fa1b376977fff49317fe56fb340ee15657;>bfbb95f Merge pull request https://redirect.github.com/cypress-io/request/issues/32;>#32 from BreakBB/fix-cve-2023-26136 https://github.com/cypress-io/request/commit/a67e1320ea1fbe74ebe936ad9ebeba3b60258774;>a67e132 pin 18.16 https://github.com/cypress-io/request/commit/825485a0913e3823f147ae0411a48248cbdfc73f;>825485a revert back to yarn but v 18 https://github.com/cypress-io/request/commit/3bce3544559d7dbf572ae09ae51092a88c6d2dc1;>3bce354 update workflow to use npm https://github.com/cypress-io/request/commit/4ceb20bc0ec023790a821c494fe77ae094bf7f03;>4ceb20b Merge branch 'master' into fix-cve-2023-26136 https://github.com/cypress-io/request/commit/228831e4fef2298bc69127e2c73772125465be84;>228831e Merge pull request https://redirect.github.com/cypress-io/request/issues/38;>#38 from cypress-io/benm/github-workflows-update https://github.com/cypress-io/request/commit/f6ee03f77f8af517d23925026835a9cd46686337;>f6ee03f chore: add in workflows for github. update workflow actions Additional commits viewable in https://github.com/cypress-io/request/compare/v2.88.10...v2.88.12;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop
[PR] build(deps): bump @cypress/request and cypress [skywalking-booster-ui]
dependabot[bot] opened a new pull request, #327: URL: https://github.com/apache/skywalking-booster-ui/pull/327 Bumps [@cypress/request](https://github.com/cypress-io/request) to 3.0.1 and updates ancestor dependency [cypress](https://github.com/cypress-io/cypress). These dependencies need to be updated together. Updates `@cypress/request` from 2.88.10 to 3.0.1 Release notes Sourced from https://github.com/cypress-io/request/releases;>@cypress/request's releases. v3.0.1 https://github.com/cypress-io/request/compare/v3.0.0...v3.0.1;>3.0.1 (2023-09-06) Bug Fixes deps: peg qs to 6.10.4 (https://github.com/cypress-io/request/commit/fb9f6255f972ed08a0d916d660e45e82e2d091f1;>fb9f625) v3.0.0 https://github.com/cypress-io/request/compare/v2.88.12...v3.0.0;>3.0.0 (2023-08-08) Features Add allowInsecureRedirect option (https://github.com/cypress-io/request/commit/c5bcf21d40fb61feaff21a0e5a2b3934a440024f;>c5bcf21) BREAKING CHANGES The allowInsecureRedirect is false by default, which may cause issues if your usage relies on insecure redirects. For the former behavior, you can opt in to insecure redirects by setting the option to true, but it is not recommended. Co-authored-by: Szymon Drosdzol mailto:szy...@doyensec.com;>szy...@doyensec.com v2.88.12 https://github.com/cypress-io/request/compare/v2.88.11...v2.88.12;>2.88.12 (2023-08-01) Bug Fixes request: update tough-cookie dep (https://github.com/cypress-io/request/commit/0664780557c95610eafeedff6067bacac6783705;>0664780) v2.88.11 https://github.com/cypress-io/request/compare/v2.88.10...v2.88.11;>2.88.11 (2023-01-11) Bug Fixes Remove badges no longer used or relevant (https://redirect.github.com/cypress-io/request/issues/19;>#19) (https://github.com/cypress-io/request/commit/24a977e9c8b867fbd4ad752e2253f8fe204ff039;>24a977e) Changelog Sourced from https://github.com/cypress-io/request/blob/master/CHANGELOG.md;>@cypress/request's changelog. Change Log v2.88.0 (2018/08/10) https://redirect.github.com/cypress-io/request/pull/2996;>#2996 fix(uuid): import versioned uuid (https://github.com/kwonoj;>@kwonoj) https://redirect.github.com/cypress-io/request/pull/2994;>#2994 Update to oauth-sign 0.9.0 (https://github.com/dlecocq;>@dlecocq) https://redirect.github.com/cypress-io/request/pull/2993;>#2993 Fix header tests (https://github.com/simov;>@simov) https://redirect.github.com/cypress-io/request/pull/2904;>#2904 https://redirect.github.com/cypress-io/request/issues/515;>#515, https://redirect.github.com/cypress-io/request/issues/2894;>#2894 Strip port suffix from Host header if the protocol is known. (https://redirect.github.com/cypress-io/request/issues/2904;>#2904) (https://github.com/paambaati;>@paambaati) https://redirect.github.com/cypress-io/request/pull/2791;>#2791 Improve AWS SigV4 support. (https://redirect.github.com/cypress-io/request/issues/2791;>#2791) (https://github.com/vikhyat;>@vikhyat) https://redirect.github.com/cypress-io/request/pull/2977;>#2977 Update test certificates (https://github.com/simov;>@simov) v2.87.0 (2018/05/21) https://redirect.github.com/cypress-io/request/pull/2943;>#2943 Replace hawk dependency with a local implemenation (https://redirect.github.com/cypress-io/request/issues/2943;>#2943) (https://github.com/hueniverse;>@hueniverse) v2.86.0 (2018/05/15) https://redirect.github.com/cypress-io/request/pull/2885;>#2885 Remove redundant code (for Node.js 0.9.4 and below) and dependency (https://github.com/ChALkeR;>@ChALkeR) https://redirect.github.com/cypress-io/request/pull/2942;>#2942 Make Test GREEN Again! (https://github.com/simov;>@simov) https://redirect.github.com/cypress-io/request/pull/2923;>#2923 Alterations for failing CI tests (https://github.com/gareth-robinson;>@gareth-robinson) v2.85.0 (2018/03/12) https://redirect.github.com/cypress-io/request/pull/2880;>#2880 Revert Update hawk to 7.0.7 (https://redirect.github.com/cypress-io/request/issues/2880;>#2880) (https://github.com/simov;>@simov) v2.84.0 (2018/03/12) https://redirect.github.com/cypress-io/request/pull/2793;>#2793 Fixed calculation of oauth_body_hash, issue https://redirect.github.com/cypress-io/request/issues/2792;>#2792 (https://github.com/dvishniakov;>@dvishniakov) https://redirect.github.com/cypress-io/request/pull/2880;>#2880 Update hawk to 7.0.7 (https://redirect.github.com/cypress-io/request/issues/2880;>#2880) (https://github.com/kornel-kedzierski;>@kornel-kedzierski) v2.83.0 (2017/09/27) https://redirect.github.com/cypress-io/request/pull/2776;>#2776 Updating tough-cookie due to security fix. (https://redirect.github.com/cypress-io/request/issues/2776;>#2776) (https://github.com/karlnorling;>@karlnorling) v2.82.0 (2017/09/19)
[skywalking-booster-ui] branch dependabot/npm_and_yarn/cypress/request-and-cypress-3.0.1 created (now af3a82aa)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/cypress/request-and-cypress-3.0.1 in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git at af3a82aa build(deps): bump @cypress/request and cypress No new revisions were added by this update.
[skywalking-booster-ui] branch dependabot/npm_and_yarn/babel/traverse-7.23.2 deleted (was e616af84)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/babel/traverse-7.23.2 in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git was e616af84 build(deps-dev): bump @babel/traverse from 7.22.5 to 7.23.2 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[skywalking-booster-ui] branch main updated: build(deps-dev): bump @babel/traverse from 7.22.5 to 7.23.2 (#326)
This is an automated email from the ASF dual-hosted git repository.
qiuxiafan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git
The following commit(s) were added to refs/heads/main by this push:
new 037c2bbb build(deps-dev): bump @babel/traverse from 7.22.5 to 7.23.2
(#326)
037c2bbb is described below
commit 037c2bbb11b74afe28f40c361889d438926b2e0f
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AuthorDate: Thu Oct 19 17:34:55 2023 +0800
build(deps-dev): bump @babel/traverse from 7.22.5 to 7.23.2 (#326)
---
package-lock.json | 202 +++---
1 file changed, 102 insertions(+), 100 deletions(-)
diff --git a/package-lock.json b/package-lock.json
index 09dad645..a0bbd4ec 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -103,12 +103,13 @@
}
},
"node_modules/@babel/code-frame": {
- "version": "7.22.5",
- "resolved":
"https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.22.5.tgz;,
- "integrity":
"sha512-Xmwn266vad+6DAqEB2A6V/CcZVp62BbwVmcOJc2RPuwih1kw02TjQvWVWlcKGbBPd+8/0V5DEkOcizRGYsspYQ==",
+ "version": "7.22.13",
+ "resolved":
"https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.22.13.tgz;,
+ "integrity":
"sha512-XktuhWlJ5g+3TJXc5upd9Ks1HutSArik6jf2eAjYFyIOf4ej3RN+184cZbzDvbPnuTJIUhPKKJE3cIsYTiAT3w==",
"dev": true,
"dependencies": {
-"@babel/highlight": "^7.22.5"
+"@babel/highlight": "^7.22.13",
+"chalk": "^2.4.2"
},
"engines": {
"node": ">=6.9.0"
@@ -154,12 +155,12 @@
}
},
"node_modules/@babel/generator": {
- "version": "7.22.5",
- "resolved":
"https://registry.npmjs.org/@babel/generator/-/generator-7.22.5.tgz;,
- "integrity":
"sha512-+lcUbnTRhd0jOewtFSedLyiPsD5tswKkbgcezOqqWFUVNEwoUTlpPOBmvhG7OXWLR4jMdv0czPGH5XbflnD1EA==",
+ "version": "7.23.0",
+ "resolved":
"https://registry.npmjs.org/@babel/generator/-/generator-7.23.0.tgz;,
+ "integrity":
"sha512-lN85QRR+5IbYrMWM6Y4pE/noaQtg4pNiqeNGX60eqOfo6gtEj6uw/JagelB8vVztSd7R6M5n1+PQkDbHbBRU4g==",
"dev": true,
"dependencies": {
-"@babel/types": "^7.22.5",
+"@babel/types": "^7.23.0",
"@jridgewell/gen-mapping": "^0.3.2",
"@jridgewell/trace-mapping": "^0.3.17",
"jsesc": "^2.5.1"
@@ -252,22 +253,22 @@
}
},
"node_modules/@babel/helper-environment-visitor": {
- "version": "7.22.5",
- "resolved":
"https://registry.npmjs.org/@babel/helper-environment-visitor/-/helper-environment-visitor-7.22.5.tgz;,
- "integrity":
"sha512-XGmhECfVA/5sAt+H+xpSg0mfrHq6FzNr9Oxh7PSEBBRUb/mL7Kz3NICXb194rCqAEdxkhPT1a88teizAFyvk8Q==",
+ "version": "7.22.20",
+ "resolved":
"https://registry.npmjs.org/@babel/helper-environment-visitor/-/helper-environment-visitor-7.22.20.tgz;,
+ "integrity":
"sha512-zfedSIzFhat/gFhWfHtgWvlec0nqB9YEIVrpuwjruLlXfUSnA8cJB0miHKwqDnQ7d32aKo2xt88/xZptwxbfhA==",
"dev": true,
"engines": {
"node": ">=6.9.0"
}
},
"node_modules/@babel/helper-function-name": {
- "version": "7.22.5",
- "resolved":
"https://registry.npmjs.org/@babel/helper-function-name/-/helper-function-name-7.22.5.tgz;,
- "integrity":
"sha512-wtHSq6jMRE3uF2otvfuD3DIvVhOsSNshQl0Qrd7qC9oQJzHvOL4qQXlQn2916+CXGywIjpGuIkoyZRRxHPiNQQ==",
+ "version": "7.23.0",
+ "resolved":
"https://registry.npmjs.org/@babel/helper-function-name/-/helper-function-name-7.23.0.tgz;,
+ "integrity":
"sha512-OErEqsrxjZTJciZ4Oo+eoZqeW9UIiOcuYKRJA4ZAgV9myA+pOXhhmpfNCKjEH/auVfEYVFJ6y1Tc4r0eIApqiw==",
"dev": true,
"dependencies": {
-"@babel/template": "^7.22.5",
-"@babel/types": "^7.22.5"
+"@babel/template": "^7.22.15",
+"@babel/types": "^7.23.0"
},
"engines": {
"node": ">=6.9.0"
@@ -391,9 +392,9 @@
}
},
"node_modules/@babel/helper-split-export-declaration": {
- "version": "7.22.5",
- "resolved":
"https://registry.npmjs.org/@babel/helper-split-export-declaration/-/helper-split-export-declaration-7.22.5.tgz;,
- "integrity":
"sha512-thqK5QFghPKWLhAV321lxF95yCg2K3Ob5yw+M3VHWfdia0IkPXUtoLH8x/6Fh486QUvzhb8YOWHChTVen2/PoQ==",
+ "version": "7.22.6",
+ "resolved":
"https://registry.npmjs.org/@babel/helper-split-export-declaration/-/helper-split-export-declaration-7.22.6.tgz;,
+ "integrity":
"sha512-AsUnxuLhRYsisFiaJwvp1QF+I3KjD5FOxut14q/GzovUe6orHLesW2C7d754kRm53h5gqrz6sFl6sxc4BVtE/g==",
"dev": true,
"dependencies": {
"@babel/types": "^7.22.5"
@@ -412,9 +413,9 @@
}
},
"node_modules/@babel/helper-validator-identifier": {
- "version": "7.22.5",
- "resolved":
"https://registry.npmjs.org/@babel/helper-validator-identifier/-/helper-validator-identifier-7.22.5.tgz;,
-
Re: [PR] build(deps-dev): bump @babel/traverse from 7.22.5 to 7.23.2 [skywalking-booster-ui]
Fine0830 merged PR #326: URL: https://github.com/apache/skywalking-booster-ui/pull/326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-booster-ui] branch dependabot/npm_and_yarn/babel/traverse-7.23.2 created (now e616af84)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/babel/traverse-7.23.2 in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git at e616af84 build(deps-dev): bump @babel/traverse from 7.22.5 to 7.23.2 No new revisions were added by this update.
[PR] build(deps-dev): bump @babel/traverse from 7.22.5 to 7.23.2 [skywalking-booster-ui]
dependabot[bot] opened a new pull request, #326: URL: https://github.com/apache/skywalking-booster-ui/pull/326 Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.5 to 7.23.2. Release notes Sourced from https://github.com/babel/babel/releases;>@babel/traverse's releases. v7.23.2 (2023-10-11) NOTE: This release also re-publishes @babel/core, even if it does not appear in the linked release commit. Thanks https://github.com/jimmydief;>@jimmydief for your first PR! :bug: Bug Fix babel-traverse https://redirect.github.com/babel/babel/pull/16033;>#16033 Only evaluate own String/Number/Math methods (https://github.com/nicolo-ribaudo;>@nicolo-ribaudo) babel-preset-typescript https://redirect.github.com/babel/babel/pull/16022;>#16022 Rewrite .tsx extension when using rewriteImportExtensions (https://github.com/jimmydief;>@jimmydief) babel-helpers https://redirect.github.com/babel/babel/pull/16017;>#16017 Fix: fallback to typeof when toString is applied to incompatible object (https://github.com/JLHwung;>@JLHwung) babel-helpers, babel-plugin-transform-modules-commonjs, babel-runtime-corejs2, babel-runtime-corejs3, babel-runtime https://redirect.github.com/babel/babel/pull/16025;>#16025 Avoid override mistake in namespace imports (https://github.com/nicolo-ribaudo;>@nicolo-ribaudo) Committers: 5 Babel Bot (https://github.com/babel-bot;>@babel-bot) Huáng Jùnliàng (https://github.com/JLHwung;>@JLHwung) James Diefenderfer (https://github.com/jimmydief;>@jimmydief) Nicolò Ribaudo (https://github.com/nicolo-ribaudo;>@nicolo-ribaudo) https://github.com/liuxingbaoyu;>@liuxingbaoyu v7.23.1 (2023-09-25) Re-publishing @babel/helpers due to a publishing error in 7.23.0. v7.23.0 (2023-09-25) Thanks https://github.com/lorenzoferre;>@lorenzoferre and https://github.com/RajShukla1;>@RajShukla1 for your first PRs! :rocket: New Feature babel-plugin-proposal-import-wasm-source, babel-plugin-syntax-import-source, babel-plugin-transform-dynamic-import https://redirect.github.com/babel/babel/pull/15870;>#15870 Support transforming import source for wasm (https://github.com/nicolo-ribaudo;>@nicolo-ribaudo) babel-helper-module-transforms, babel-helpers, babel-plugin-proposal-import-defer, babel-plugin-syntax-import-defer, babel-plugin-transform-modules-commonjs, babel-runtime-corejs2, babel-runtime-corejs3, babel-runtime, babel-standalone https://redirect.github.com/babel/babel/pull/15878;>#15878 Implement import defer proposal transform support (https://github.com/nicolo-ribaudo;>@nicolo-ribaudo) babel-generator, babel-parser, babel-types https://redirect.github.com/babel/babel/pull/15845;>#15845 Implement import defer parsing support (https://github.com/nicolo-ribaudo;>@nicolo-ribaudo) https://redirect.github.com/babel/babel/pull/15829;>#15829 Add parsing support for the source phase imports proposal (https://github.com/nicolo-ribaudo;>@nicolo-ribaudo) babel-generator, babel-helper-module-transforms, babel-parser, babel-plugin-transform-dynamic-import, babel-plugin-transform-modules-amd, babel-plugin-transform-modules-commonjs, babel-plugin-transform-modules-systemjs, babel-traverse, babel-types https://redirect.github.com/babel/babel/pull/15682;>#15682 Add createImportExpressions parser option (https://github.com/JLHwung;>@JLHwung) babel-standalone https://redirect.github.com/babel/babel/pull/15671;>#15671 Pass through nonce to the transformed script element (https://github.com/JLHwung;>@JLHwung) babel-helper-function-name, babel-helper-member-expression-to-functions, babel-helpers, babel-parser, babel-plugin-proposal-destructuring-private, babel-plugin-proposal-optional-chaining-assign, babel-plugin-syntax-optional-chaining-assign, babel-plugin-transform-destructuring, babel-plugin-transform-optional-chaining, babel-runtime-corejs2, babel-runtime-corejs3, babel-runtime, babel-standalone, babel-types https://redirect.github.com/babel/babel/pull/15751;>#15751 Add support for optional chain in assignments (https://github.com/nicolo-ribaudo;>@nicolo-ribaudo) babel-helpers, babel-plugin-proposal-decorators https://redirect.github.com/babel/babel/pull/15895;>#15895 Implement the decorator metadata proposal (https://github.com/nicolo-ribaudo;>@nicolo-ribaudo) babel-traverse, babel-types https://redirect.github.com/babel/babel/pull/15893;>#15893 Add t.buildUndefinedNode (https://github.com/liuxingbaoyu;>@liuxingbaoyu) babel-preset-typescript ... (truncated) Changelog Sourced from https://github.com/babel/babel/blob/main/CHANGELOG.md;>@babel/traverse's changelog. v7.23.2 (2023-10-11)
Re: [PR] Provide APIs to user and support correlationContext [skywalking-go]
mrproliu commented on code in PR #104: URL: https://github.com/apache/skywalking-go/pull/104#discussion_r1365178798 ## docs/menu.yml: ## @@ -42,6 +42,10 @@ catalog: path: /en/agent/plugin-configurations - name: Transport Layer Security (TLS) path: /en/advanced-features/grpc-tls +- name: Manual APIs + catalog: +- name: Tracing APIs + path: /en/advanced-features/manual-apis/toolkit-trace.md Review Comment: @Alipebt Please create a new PR to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Provide APIs to user and support correlationContext [skywalking-go]
wu-sheng commented on code in PR #104: URL: https://github.com/apache/skywalking-go/pull/104#discussion_r1365155692 ## docs/menu.yml: ## @@ -42,6 +42,10 @@ catalog: path: /en/agent/plugin-configurations - name: Transport Layer Security (TLS) path: /en/advanced-features/grpc-tls +- name: Manual APIs + catalog: +- name: Tracing APIs + path: /en/advanced-features/manual-apis/toolkit-trace.md Review Comment: You should not add `.md` as suffix. All markdowns are transferred into HTML, so no md suffix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Provide APIs to user and support correlationContext [skywalking-go]
wu-sheng commented on PR #104: URL: https://github.com/apache/skywalking-go/pull/104#issuecomment-1770359820 Here it is, https://skywalking.apache.org/docs/skywalking-go/next/en/advanced-features/manual-apis/toolkit-trace/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] rel/0.7.0 [skywalking-nodejs]
kezhenxu94 opened a new pull request, #120: URL: https://github.com/apache/skywalking-nodejs/pull/120 - 0.7.0 - Draft release for 0.7.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-nodejs] 02/02: Draft release for 0.7.0
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch rel/0.7.0 in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git commit eec2fa5b3728500610f8b54d3c824e1b5a6aba84 Author: kezhenxu94 AuthorDate: Thu Oct 19 16:51:08 2023 +0800 Draft release for 0.7.0 --- CHANGELOG.md | 4 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3a6a5d2..ea8eab3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +# 0.7.0 + +* Add deadline config for trace request (#118) + # 0.6.0 * Add missing build doc by @kezhenxu94 in https://github.com/apache/skywalking-nodejs/pull/92
[skywalking-nodejs] 01/02: 0.7.0
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a commit to branch rel/0.7.0
in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git
commit 10e1bd6131a331ecf65ef0bd9ae345126061acec
Author: kezhenxu94
AuthorDate: Thu Oct 19 16:49:22 2023 +0800
0.7.0
---
package-lock.json | 2 +-
package.json | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/package-lock.json b/package-lock.json
index 5c8b742..dc873f5 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,6 +1,6 @@
{
"name": "skywalking-backend-js",
- "version": "0.6.0",
+ "version": "0.7.0",
"lockfileVersion": 1,
"requires": true,
"dependencies": {
diff --git a/package.json b/package.json
index b04092d..9da4a27 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
{
"name": "skywalking-backend-js",
- "version": "0.6.0",
+ "version": "0.7.0",
"description": "The NodeJS agent for Apache SkyWalking",
"homepage": "skywalking.apache.org",
"main": "lib/index.js",
[skywalking-nodejs] branch rel/0.7.0 created (now eec2fa5)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch rel/0.7.0 in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git at eec2fa5 Draft release for 0.7.0 This branch includes the following new commits: new 10e1bd6 0.7.0 new eec2fa5 Draft release for 0.7.0 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
Re: [PR] Provide APIs to user and support correlationContext [skywalking-go]
Ecostack commented on PR #104: URL: https://github.com/apache/skywalking-go/pull/104#issuecomment-1770349895 Not sure if this is the right place to mention this, but it looks like the documentation generation was unsuccessful: https://skywalking.apache.org/docs/skywalking-go/next/en/advanced-features/manual-apis/toolkit-trace.md https://github.com/apache/skywalking-go/assets/8505607/4be2ef1b-8a5f-4fe2-ad89-c7f051cfc4c0;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-nodejs] branch wu-sheng-patch-1 deleted (was b75c7a9)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git was b75c7a9 Also add 18 to test lib The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[skywalking-nodejs] branch master updated: Setup node 18 for testing matrix (#119)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git
The following commit(s) were added to refs/heads/master by this push:
new ba3c123 Setup node 18 for testing matrix (#119)
ba3c123 is described below
commit ba3c1236f545595bfc29953640805d83f67ae337
Author: 吴晟 Wu Sheng
AuthorDate: Thu Oct 19 16:41:34 2023 +0800
Setup node 18 for testing matrix (#119)
---
.github/workflows/build.yaml | 2 +-
.github/workflows/test.yaml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 419f558..5442bd6 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -29,7 +29,7 @@ jobs:
timeout-minutes: 30
strategy:
matrix:
-node-version: [ 10, 12, 14, 16 ]
+node-version: [ 10, 12, 14, 16, 18 ]
steps:
- uses: actions/checkout@v2
with:
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
index b2234d3..3295e1b 100644
--- a/.github/workflows/test.yaml
+++ b/.github/workflows/test.yaml
@@ -29,7 +29,7 @@ jobs:
timeout-minutes: 30
strategy:
matrix:
-node-version: [ 10, 12, 14, 15 ]
+node-version: [ 10, 12, 14, 16, 18 ]
env:
SW_NODE_VERSION: ${{ matrix.node-version }}
steps:
Re: [PR] Setup node 18 for testing matrix [skywalking-nodejs]
wu-sheng merged PR #119: URL: https://github.com/apache/skywalking-nodejs/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support etcd client authentication [skywalking-banyandb]
hanahmily commented on code in PR #331:
URL:
https://github.com/apache/skywalking-banyandb/pull/331#discussion_r1365102335
##
.licenserc.yaml:
##
@@ -85,6 +85,7 @@ header: # `header` section is configurations for source codes
license header.
- 'ui'
- '.github/PULL_REQUEST_TEMPLATE'
- "**/*.prof"
+- "**/test/integration/etcd/cafile/**"
Review Comment:
Would you please put them into `testdata`, which is ignored by the checker
automatically? You can put this folder in any place.
##
test/integration/etcd/client_test.go:
##
@@ -0,0 +1,304 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package integration_etcd_test
+
+import (
+ "context"
+ "crypto/tls"
+ "fmt"
+ "log"
+ "net/url"
+ "path/filepath"
+ "time"
+
+ . "github.com/onsi/ginkgo/v2"
+ . "github.com/onsi/gomega"
+ "github.com/onsi/gomega/gleak"
+ "go.etcd.io/etcd/client/pkg/v3/transport"
+ clientv3 "go.etcd.io/etcd/client/v3"
+ "go.etcd.io/etcd/server/v3/embed"
+
+ databasev1
"github.com/apache/skywalking-banyandb/api/proto/banyandb/database/v1"
+ "github.com/apache/skywalking-banyandb/banyand/metadata/schema"
+ "github.com/apache/skywalking-banyandb/pkg/test"
+ "github.com/apache/skywalking-banyandb/pkg/test/flags"
+ "github.com/apache/skywalking-banyandb/pkg/test/helpers"
+ "github.com/apache/skywalking-banyandb/pkg/test/setup"
+)
+
+const host = "127.0.0.1"
+
+const namespace = "liaison-test"
+
+const nodeHost = "liaison-1"
+
+var _ = Describe("Client Test", func() {
+ var (
+ dirstring
+ dirSpaceDeffunc()
+ caFilePath string
+ serverKeyFilePath string
+ serverCertFilePath string
+ clientKeyFilePath string
+ clientCertFilePath string
+ goods []gleak.Goroutine
+ )
+ BeforeEach(func() {
+ var err error
+ dir, dirSpaceDef, err = test.NewSpace()
+ Expect(err).ShouldNot(HaveOccurred())
+ caFilePath, err = filepath.Abs("./cafile/ca.crt")
Review Comment:
Please use
https://github.com/apache/skywalking-banyandb/blob/main/test/integration/standalone/other/tls_test.go#L47
to load files
##
docs/installation/cluster.md:
##
@@ -28,3 +28,45 @@ The host is registered to the etcd cluster by the
`banyand-server` automatically
- `node-host-provider=hostname` : Default. The OS's hostname is registered as
the host part in the address.
- `node-host-provider=ip` : The OS's the first non-loopback active IP
address(IPv4) is registered as the host part in the address.
- `node-host-provider=flag` : `node-host` is registered as the host part in
the address.
+
+## Etcd Client Authentication
Review Comment:
```suggestion
## Etcd Authentication
```
##
test/integration/etcd/client_test.go:
##
@@ -0,0 +1,304 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package integration_etcd_test
+
+import (
+ "context"
+ "crypto/tls"
+ "fmt"
+ "log"
+ "net/url"
+ "path/filepath"
+ "time"
+
+ . "github.com/onsi/ginkgo/v2"
+ . "github.com/onsi/gomega"
+ "github.com/onsi/gomega/gleak"
+
[skywalking-nodejs] branch wu-sheng-patch-1 updated (4c40a30 -> b75c7a9)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git from 4c40a30 Setup node 18 for testing matrix add b75c7a9 Also add 18 to test lib No new revisions were added by this update. Summary of changes: .github/workflows/test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: [PR] Add health check command for bydbctl [skywalking-banyandb]
hanahmily commented on code in PR #336:
URL:
https://github.com/apache/skywalking-banyandb/pull/336#discussion_r1365084428
##
CHANGES.md:
##
@@ -13,10 +13,10 @@ Release Notes.
- Support for recovery buffer using wal.
- Register the node role to the metadata registry.
- Implement the remote queue to spreading data to data nodes.
-- Fix parse environment variables error
Review Comment:
Move it to `0.6.0`
##
bydbctl/internal/cmd/health_check_test.go:
##
@@ -0,0 +1,73 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package cmd_test
+
+import (
+ . "github.com/onsi/ginkgo/v2"
+ . "github.com/onsi/gomega"
+ "github.com/spf13/cobra"
+ "github.com/zenizh/go-capturer"
+
+ "github.com/apache/skywalking-banyandb/bydbctl/internal/cmd"
+ "github.com/apache/skywalking-banyandb/pkg/test/setup"
+)
+
+var _ = Describe("health check after launching banyandb server", func() {
+ var deferFunc func()
+ var grpcAddr string
+ var rootCmd *cobra.Command
+ BeforeEach(func() {
+ grpcAddr, _, deferFunc =
setup.StandaloneWithTLS("../../../test/integration/standalone/other/testdata/server_cert.pem",
+
"../../../test/integration/standalone/other/testdata/server_key.pem")
+ rootCmd = {Use: "root"}
+ cmd.RootCmdFlags(rootCmd)
+ })
+
+ It("health", func() {
+ rootCmd.SetArgs([]string{"health", "--grpc-addr", grpcAddr,
"--grpc-cert",
"../../../test/integration/standalone/other/testdata/server_cert.pem"})
+ out := capturer.CaptureStdout(func() {
+ err := rootCmd.Execute()
+ Expect(err).NotTo(HaveOccurred())
+ })
+ Expect(out).To(ContainSubstring("connected"))
+ })
+
+ It("health", func() {
Review Comment:
```suggestion
It("should fail without the proper cert", func() {
```
##
bydbctl/internal/cmd/health_check.go:
##
@@ -0,0 +1,81 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package cmd
+
+import (
+ "crypto/tls"
+ "crypto/x509"
+ "fmt"
+ "os"
+ "time"
+
+ "github.com/pkg/errors"
+ "github.com/spf13/cobra"
+ "google.golang.org/grpc"
+ "google.golang.org/grpc/credentials"
+ ins "google.golang.org/grpc/credentials/insecure"
+
+ "github.com/apache/skywalking-banyandb/pkg/test/helpers"
+ "github.com/apache/skywalking-banyandb/pkg/version"
+)
+
+var (
+ grpcAddr string
+ grpcCert string
+)
+
+func newHealthCheckCmd() *cobra.Command {
+ healthCheckCmd := {
+ Use: "health",
+ Version: version.Build(),
+ Short: "Health check",
+ SilenceErrors: true,
+ SilenceUsage: true,
+ RunE: func(_ *cobra.Command, _ []string) (err error) {
+ opts := make([]grpc.DialOption, 0, 1)
+ if grpcCert != "" {
+ cert, errRead := os.ReadFile(grpcCert)
+ if errRead != nil {
+ return errRead
+ }
+ certPool := x509.NewCertPool()
+ if
Re: [PR] Implement local file system [skywalking-banyandb]
hanahmily commented on code in PR #341:
URL:
https://github.com/apache/skywalking-banyandb/pull/341#discussion_r1365030620
##
pkg/fs/file_system.go:
##
@@ -19,59 +19,58 @@
package fs
import (
- "container/list"
+ "bufio"
+ "os"
)
+const moduleName string = "filesystem"
+
// Mode contains permission of file and directory.
-type Mode struct{}
+type Mode uint64
// Iter is used for streaming read.
-type Iter struct{}
+type Iter struct {
+ fileName string
+ reader *bufio.Reader
+ buffer []byte
+}
// Dir operation interface.
type Dir interface {
Review Comment:
I believe we should remove the `Dir` as `os` package typically interacts
with the directory directly instead of using an `os.File`. Having a separate
Dir doesn't add any value other than requiring us to be mindful of closing it
to prevent resource leaks.
Thus, we should consider moving the directory's operations back into the
`FileSystem`.
##
pkg/fs/file_system.go:
##
@@ -19,59 +19,58 @@
package fs
import (
- "container/list"
+ "bufio"
+ "os"
)
+const moduleName string = "filesystem"
+
// Mode contains permission of file and directory.
-type Mode struct{}
+type Mode uint64
// Iter is used for streaming read.
-type Iter struct{}
+type Iter struct {
+ fileName string
+ reader *bufio.Reader
+ buffer []byte
+}
// Dir operation interface.
type Dir interface {
// Delete the directory.
DeleteDirectory() error
- // Rename the directory.
- RenameDirectory(newName string) error
// Get all lists of files or children's directories in the directory.
- ReadDirectory() (list.List, error)
- // Set directory permission.
- SetDirectoryPermission(permission Mode) error
+ ReadDirectory() ([]os.DirEntry, error)
+ // Close directory.
+ CloseDirectory() error
}
// File operation interface.
type File interface {
// Append mode, which adds new data to the end of a file.
- AppendWriteFile(buffer []byte) error
+ AppendWriteFile(buffer []byte) (int, error)
// Vector Append mode, which supports appending consecutive buffers to
the end of the file.
- AppendWritevFile(iov *[][]byte) error
+ AppendWritevFile(iov *[][]byte) (int, error)
// Delete the file.
DeleteFile() error
// Reading a specified location of file.
- ReadFile(offset int, buffer []byte) error
+ ReadFile(offset int64, buffer []byte) (int, error)
// Reading contiguous regions of a file and dispersing them into
discontinuous buffers.
- ReadvFile(iov *[][]byte) error
- // Read the entire file using streaming read
- StreamReadFile(offset int, buffer []byte) (*Iter, error)
- // Rename the file.
- RenameFile(newName string) error
+ ReadvFile(offset int64, iov *[][]byte) (int, error)
+ // Read the entire file using streaming read.
+ StreamReadFile(buffer []byte) (*Iter, error)
// Get the file written data's size and return an error if the file
does not exist. The unit of file size is Byte.
- GetFileSize() (int, error)
- // Set directory permission.
- SetFilePermission(permission Mode) error
+ GetFileSize() (int64, error)
+ // Close File.
+ CloseFile() error
}
// FileSystem operation interface.
type FileSystem interface {
- // Create the directory by specified name and mode.
- CreateDirectory(name string, permission Mode) error
- // Open the directory by specified name.
- OpenDirectory(name string) (*Dir, error)
- // Create the file by specified name and mode.
- CreateFile(name string, permission Mode) error
- // Open the file by specified name.
- OpenFile(name string) (*File, error)
+ // Create and open the directory by specified name and mode.
+ CreateDirectory(name string, permission Mode) (Dir, error)
Review Comment:
Merging Create and Open operations into one is not a proper solution. When I
create a directory, the subsequent step is to write some files into it. The Dir
is not necessary because `CreateFile` doesn't require it. However, I still need
to close the Dir. Thus, CreateDirectory doesn't return the Dir, and
OpenDirectory is still required.
##
pkg/fs/file_system.go:
##
@@ -19,59 +19,58 @@
package fs
import (
- "container/list"
+ "bufio"
+ "os"
)
+const moduleName string = "filesystem"
+
// Mode contains permission of file and directory.
-type Mode struct{}
+type Mode uint64
// Iter is used for streaming read.
-type Iter struct{}
+type Iter struct {
+ fileName string
+ reader *bufio.Reader
+ buffer []byte
+}
// Dir operation interface.
type Dir interface {
// Delete the directory.
DeleteDirectory() error
- // Rename the directory.
-
