(skywalking-booster-ui) branch main updated: fix: set the height for trace widget (#337)

2023-11-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git


The following commit(s) were added to refs/heads/main by this push:
 new 2085dc84 fix: set the height for trace widget (#337)
2085dc84 is described below

commit 2085dc84b95e964c34bd1d3089d221171f47e5b6
Author: Fine0830 
AuthorDate: Thu Nov 16 11:44:34 2023 +0800

fix: set the height for trace widget (#337)
---
 src/views/dashboard/related/trace/Index.vue | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/views/dashboard/related/trace/Index.vue 
b/src/views/dashboard/related/trace/Index.vue
index e7f25de9..1d525917 100644
--- a/src/views/dashboard/related/trace/Index.vue
+++ b/src/views/dashboard/related/trace/Index.vue
@@ -59,5 +59,6 @@ limitations under the License. -->
 width: 100%;
 overflow: auto;
 min-width: 1200px;
+height: calc(100% - 100px);
   }
 



Re: [PR] fix: set the height for trace widget [skywalking-booster-ui]

2023-11-15 Thread via GitHub


wu-sheng merged PR #337:
URL: https://github.com/apache/skywalking-booster-ui/pull/337


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] fix: set the height for trace widget [skywalking-booster-ui]

2023-11-15 Thread via GitHub


Fine0830 opened a new pull request, #337:
URL: https://github.com/apache/skywalking-booster-ui/pull/337

   Video 
   
   
https://github.com/apache/skywalking-booster-ui/assets/20871783/98205eac-3e59-4c9b-9307-6c373a18ad15
   
   
   Signed-0ff-by: Qiuxia Fan 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(skywalking) branch abandon updated (49e090debe -> b61b7a80f0)

2023-11-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a change to branch abandon
in repository https://gitbox.apache.org/repos/asf/skywalking.git


from 49e090debe Fix
 add b61b7a80f0 Fix words.

No new revisions were added by this update.

Summary of changes:
 docs/en/changes/changes.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



(skywalking) branch abandon updated: Fix

2023-11-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch abandon
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/abandon by this push:
 new 49e090debe Fix
49e090debe is described below

commit 49e090debedcd907fb3d3c03ccd822a6e36bc57d
Author: Wu Sheng 
AuthorDate: Thu Nov 16 10:13:26 2023 +0800

Fix
---
 .../oap/server/library/datacarrier/consumer/ConsumerThread.java   | 4 
 1 file changed, 4 deletions(-)

diff --git 
a/oap-server/server-library/library-datacarrier-queue/src/main/java/org/apache/skywalking/oap/server/library/datacarrier/consumer/ConsumerThread.java
 
b/oap-server/server-library/library-datacarrier-queue/src/main/java/org/apache/skywalking/oap/server/library/datacarrier/consumer/ConsumerThread.java
index d5013f1c7b..30caa739b5 100644
--- 
a/oap-server/server-library/library-datacarrier-queue/src/main/java/org/apache/skywalking/oap/server/library/datacarrier/consumer/ConsumerThread.java
+++ 
b/oap-server/server-library/library-datacarrier-queue/src/main/java/org/apache/skywalking/oap/server/library/datacarrier/consumer/ConsumerThread.java
@@ -20,7 +20,6 @@ package 
org.apache.skywalking.oap.server.library.datacarrier.consumer;
 
 import java.util.ArrayList;
 import java.util.List;
-import org.apache.skywalking.oap.server.library.datacarrier.buffer.Buffer;
 import org.apache.skywalking.oap.server.library.datacarrier.buffer.QueueBuffer;
 
 public class ConsumerThread extends Thread {
@@ -88,9 +87,6 @@ public class ConsumerThread extends Thread {
 running = false;
 }
 
-/**
- * DataSource is a refer to {@link Buffer}.
- */
 class DataSource {
 private QueueBuffer sourceBuffer;
 



Re: [PR] Change the policy of the queue(DataCarrier) L1 metric aggregate worker to IF_POSSIBLE mode [skywalking]

2023-11-15 Thread via GitHub


wu-sheng commented on PR #11554:
URL: https://github.com/apache/skywalking/pull/11554#issuecomment-1813653998

   @kezhenxu94 We need to update self-observability accordingly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Change the policy of the queue(DataCarrier) L1 metric aggregate worker to IF_POSSIBLE mode [skywalking]

2023-11-15 Thread via GitHub


wu-sheng opened a new pull request, #11554:
URL: https://github.com/apache/skywalking/pull/11554

   
   
   
   
   
   
   
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace 
the issue number. Closes #.
   - [x] Update the [`CHANGES` 
log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
   
   * Change the DataCarrier IF_POSSIBLE strategy to use ArrayBlockingQueue 
implementation.
   * Change the policy of the queue(DataCarrier) L1 metric aggregate worker to 
IF_POSSIBLE mode. 
   * Add self-observability metric `metrics_aggregator_abandon` to count the 
number of abandon metrics.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(skywalking) branch abandon created (now ceb9a63a4d)

2023-11-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a change to branch abandon
in repository https://gitbox.apache.org/repos/asf/skywalking.git


  at ceb9a63a4d * Change the DataCarrier IF_POSSIBLE strategy to use 
ArrayBlockingQueue implementation. * Change the policy of the 
queue(DataCarrier) L1 metric aggregate worker to IF_POSSIBLE mode. * Add 
self-observability metric `metrics_aggregator_abandon` to count the number of 
abandon metrics.

This branch includes the following new commits:

 new ceb9a63a4d * Change the DataCarrier IF_POSSIBLE strategy to use 
ArrayBlockingQueue implementation. * Change the policy of the 
queue(DataCarrier) L1 metric aggregate worker to IF_POSSIBLE mode. * Add 
self-observability metric `metrics_aggregator_abandon` to count the number of 
abandon metrics.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




(skywalking) 01/01: * Change the DataCarrier IF_POSSIBLE strategy to use ArrayBlockingQueue implementation. * Change the policy of the queue(DataCarrier) L1 metric aggregate worker to IF_POSSIBLE mode

2023-11-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch abandon
in repository https://gitbox.apache.org/repos/asf/skywalking.git

commit ceb9a63a4d39358db4093169e70bfe4fc021ad3e
Author: Wu Sheng 
AuthorDate: Thu Nov 16 09:58:53 2023 +0800

* Change the DataCarrier IF_POSSIBLE strategy to use ArrayBlockingQueue 
implementation.
* Change the policy of the queue(DataCarrier) L1 metric aggregate worker to 
IF_POSSIBLE mode.
* Add self-observability metric `metrics_aggregator_abandon` to count the 
number of abandon metrics.
---
 docs/en/changes/changes.md |  3 +
 .../analysis/worker/MetricsAggregateWorker.java| 13 +++-
 .../buffer/ArrayBlockingQueueBuffer.java   |  4 +-
 .../server/library/datacarrier/buffer/Buffer.java  | 76 --
 .../library/datacarrier/buffer/Channels.java   |  6 +-
 5 files changed, 18 insertions(+), 84 deletions(-)

diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
index 5c360c2e14..d1dc0c81c6 100644
--- a/docs/en/changes/changes.md
+++ b/docs/en/changes/changes.md
@@ -39,6 +39,9 @@
 * Fix `limit` doesn't work for `findEndpoint` API in ES storage.
 * Isolate MAL CounterWindow cache by metric name.
 * Fix JDBC Log query order.
+* Change the DataCarrier IF_POSSIBLE strategy to use ArrayBlockingQueue 
implementation.
+* Change the policy of the queue(DataCarrier) L1 metric aggregate worker to 
IF_POSSIBLE mode. 
+* Add self-observability metric `metrics_aggregator_abandon` to count the 
number of abandon metrics.
 
  UI
 
diff --git 
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsAggregateWorker.java
 
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsAggregateWorker.java
index 698341144f..255aa44306 100644
--- 
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsAggregateWorker.java
+++ 
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsAggregateWorker.java
@@ -25,6 +25,7 @@ import 
org.apache.skywalking.oap.server.core.analysis.data.MergableBufferedData;
 import org.apache.skywalking.oap.server.core.analysis.metrics.Metrics;
 import org.apache.skywalking.oap.server.core.worker.AbstractWorker;
 import org.apache.skywalking.oap.server.library.datacarrier.DataCarrier;
+import 
org.apache.skywalking.oap.server.library.datacarrier.buffer.BufferStrategy;
 import 
org.apache.skywalking.oap.server.library.datacarrier.consumer.BulkConsumePool;
 import 
org.apache.skywalking.oap.server.library.datacarrier.consumer.ConsumerPoolFactory;
 import org.apache.skywalking.oap.server.library.datacarrier.consumer.IConsumer;
@@ -46,6 +47,7 @@ public class MetricsAggregateWorker extends 
AbstractWorker {
 private AbstractWorker nextWorker;
 private final DataCarrier dataCarrier;
 private final MergableBufferedData mergeDataCache;
+private CounterMetrics abandonCounter;
 private CounterMetrics aggregationCounter;
 private long lastSendTime = 0;
 
@@ -68,7 +70,7 @@ public class MetricsAggregateWorker extends 
AbstractWorker {
 queueBufferSize = 1_000;
 }
 this.dataCarrier = new DataCarrier<>(
-"MetricsAggregateWorker." + modelName, name, queueChannelSize, 
queueBufferSize);
+"MetricsAggregateWorker." + modelName, name, queueChannelSize, 
queueBufferSize, BufferStrategy.IF_POSSIBLE);
 
 BulkConsumePool.Creator creator = new BulkConsumePool.Creator(
 name, BulkConsumePool.Creator.recommendMaxSize() * 2, 20);
@@ -82,6 +84,11 @@ public class MetricsAggregateWorker extends 
AbstractWorker {
 MetricsCreator metricsCreator = 
moduleDefineHolder.find(TelemetryModule.NAME)
   .provider()
   
.getService(MetricsCreator.class);
+abandonCounter = metricsCreator.createCounter(
+"metrics_aggregator_abandon", "The abandon number of rows received 
in aggregation",
+new MetricsTag.Keys("metricName", "level", "dimensionality"),
+new MetricsTag.Values(modelName, "1", "minute")
+);
 aggregationCounter = metricsCreator.createCounter(
 "metrics_aggregation", "The number of rows in aggregation",
 new MetricsTag.Keys("metricName", "level", "dimensionality"),
@@ -95,7 +102,9 @@ public class MetricsAggregateWorker extends 
AbstractWorker {
  */
 @Override
 public final void in(Metrics metrics) {
-dataCarrier.produce(metrics);
+if (!dataCarrier.produce(metrics)) {
+abandonCounter.inc();
+}
 }
 
 /**
diff --git 

Re: [I] db.instance extraction error[Bug] [skywalking]

2023-11-15 Thread via GitHub


wu-sheng commented on issue #11552:
URL: https://github.com/apache/skywalking/issues/11552#issuecomment-1813521388

   You could debug `PostgreSQLURLParser` to find out the reason. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] db.instance extraction error[Bug] [skywalking]

2023-11-15 Thread via GitHub


mitht opened a new issue, #11552:
URL: https://github.com/apache/skywalking/issues/11552

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Apache SkyWalking Component
   
   OAP server (apache/skywalking)
   
   ### What happened
   
   Trace postgresql sql data using agent 8.14.0;
   Database connection address:
   
   
spring.datasource.url=jdbc:postgresql://127.0.0.1:5432/testdb?serverTimezone=Asia/Shanghai=true=utf8=utf8=false=true
   
   The database is testdb, but
   
db.instance:Shanghai=true=utf8=utf8=false=true
   
   https://github.com/apache/skywalking/assets/29425860/f54c6df9-d077-4c77-9f3a-9a33cb586741;>
   
   
   ### What you expected to happen
   
   db.instance=testdb
   
   ### How to reproduce
   
   agent: apache-skywalking-java-agent-8.14.0
   apm: apache-skywalking-apm-bin-9.3
   
   springBoot version: 2.6.6
   postgres version: 12
   

   com.alibaba
   druid
   1.2.16
   
   
   org.postgresql
   postgresql
   42.2.18
   
   
   com.baomidou
   mybatis-plus-boot-starter
   3.3.2
   
   
   ### Anything else
   
   Every time
   
   ### Are you willing to submit a pull request to fix on your own?
   
   - [ ] Yes I am willing to submit a pull request on my own!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
notifications-unsubscr...@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [WIP] Add a getting started doc for swck [skywalking-swck]

2023-11-15 Thread via GitHub


dashanji commented on code in PR #100:
URL: https://github.com/apache/skywalking-swck/pull/100#discussion_r1394205515


##
docs/getting-started.md:
##
@@ -0,0 +1,316 @@
+## Getting Started
+
+This document introduces how to create a kubernetes cluster locally using kind 
and how to deploy the basic skywalking components to the cluster.
+
+### Prerequisites
+- [docker](https://docs.docker.com/get-docker/)
+- [kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl/)
+- [kind](https://kind.sigs.k8s.io/docs/user/quick-start/#installation)
+- [swctl](https://github.com/apache/skywalking-cli?tab=readme-ov-file#install)
+
+### Step1: Create a kubernetes cluster locally using kind
+
+> Note: If you have a kubernetes cluster already, you can skip this step.
+
+Here we create a kubernetes cluster with 1 control-plane node and 1 worker 
nodes.
+
+```shell
+$ cat <
+  Expected output
+
+```shell
+Creating cluster "kind" ...
+ ✓ Ensuring node image (kindest/node:v1.21.10) 
+ ✓ Preparing nodes  
+ ✓ Writing configuration 
+ ✓ Starting control-plane ️
+ ✓ Installing CNI 
+ ✓ Installing StorageClass 
+ ✓ Joining worker nodes 
+Set kubectl context to "kind-kind"
+You can now use your cluster with:
+
+kubectl cluster-info --context kind-kind
+
+Not sure what to do next?   Check out 
https://kind.sigs.k8s.io/docs/user/quick-start/
+```
+
+
+Check all pods in the cluster.
+
+```shell
+$ kubectl get pods -A
+```
+
+
+  Expected output
+
+```shell
+NAMESPACENAME READY   
STATUSRESTARTS   AGE
+kube-system  coredns-558bd4d5db-h5gxt 1/1 
Running   0  106s
+kube-system  coredns-558bd4d5db-lhnvz 1/1 
Running   0  106s
+kube-system  etcd-kind-control-plane  1/1 
Running   0  116s
+kube-system  kindnet-fxlkm1/1 
Running   0  106s
+kube-system  kindnet-vmcvl1/1 
Running   0  91s
+kube-system  kube-apiserver-kind-control-plane1/1 
Running   0  116s
+kube-system  kube-controller-manager-kind-control-plane   1/1 
Running   0  116s
+kube-system  kube-proxy-nr4f4 1/1 
Running   0  91s
+kube-system  kube-proxy-zl4h2 1/1 
Running   0  106s
+kube-system  kube-scheduler-kind-control-plane1/1 
Running   0  116s
+local-path-storage   local-path-provisioner-74567d47b4-kmtjh  1/1 
Running   0  106s
+```
+
+
+### Step2: Build the operator image
+
+Check into the root directory of SWCK and build the operator image as follows.
+
+```shell
+$ cd operator
+# Build the operator image
+$ make docker-build
+```
+
+You will get the operator image `controller:latest` as follows.
+
+```shell
+$ docker images 
+REPOSITORY TAGIMAGE ID   CREATED  SIZE
+controller latest 84da7509092a   22 seconds ago   53.6MB
+```
+
+Load the operator image into the kind cluster or push the image to a registry 
that
+your kubernetes cluster can access.
+
+```shell
+$ kind load docker-image controller
+```
+or
+```shell
+$ docker push $(YOUR_REGISTRY)/controller
+```
+
+### Step3: Deploy operator on the kubernetes cluster
+
+Install the CRDs as follows.
+
+```shell
+$ make install
+```
+
+Check the CRDs are installed successfully.
+
+
+  Expected output
+
+```shell
+kubectl get crd | grep skywalking
+banyandbs.operator.skywalking.apache.org 2023-11-05T03:30:43Z
+fetchers.operator.skywalking.apache.org  2023-11-05T03:30:43Z
+javaagents.operator.skywalking.apache.org2023-11-05T03:30:43Z
+oapserverconfigs.operator.skywalking.apache.org  2023-11-05T03:30:43Z
+oapserverdynamicconfigs.operator.skywalking.apache.org   2023-11-05T03:30:43Z
+oapservers.operator.skywalking.apache.org2023-11-05T03:30:43Z
+satellites.operator.skywalking.apache.org2023-11-05T03:30:43Z
+storages.operator.skywalking.apache.org  2023-11-05T03:30:43Z
+swagents.operator.skywalking.apache.org  2023-11-05T03:30:43Z
+uis.operator.skywalking.apache.org   2023-11-05T03:30:43Z
+```
+
+
+Deploy the SWCK operator to the cluster.
+
+```shell
+$ make deploy
+```
+
+Or deploy the SWCK operator to the cluster with your own image.
+
+```shell
+$ make deploy OPERATOR_IMG=$(YOUR_REGISTRY)/controller
+```
+
+Get the status of the SWCK operator pod.
+
+```shell
+$ kubectl get pod -n skywalking-swck-system
+NAME READY   STATUS
RESTARTS   AGE
+skywalking-swck-controller-manager-5f5bbd4fd-9wdw6   2/2 Running   0   
   34s
+```
+
+### Step4: Deploy skywalking componentes on the kubernetes cluster

(skywalking-showcase) branch main updated: Update Dark theme

2023-11-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-showcase.git


The following commit(s) were added to refs/heads/main by this push:
 new 6e50e20  Update Dark theme
6e50e20 is described below

commit 6e50e20df4d499361e559aae1fcc4c680dca43b4
Author: 吴晟 Wu Sheng 
AuthorDate: Wed Nov 15 21:02:18 2023 +0800

Update Dark theme
---
 Makefile.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile.in b/Makefile.in
index 19e8cab..ac0509f 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -29,10 +29,10 @@ ES_IMAGE ?= 
docker.elastic.co/elasticsearch/elasticsearch-oss
 ES_IMAGE_TAG ?= 7.10.2
 
 SW_OAP_IMAGE ?= ghcr.io/apache/skywalking/oap
-SW_OAP_IMAGE_TAG ?= 9fee0922a8d60321f9b46aecebf3832fe34c0ddd
+SW_OAP_IMAGE_TAG ?= 798c55ce8ac4124498474de65ecf1d631bf3904a
 
 SW_UI_IMAGE ?= ghcr.io/apache/skywalking/ui
-SW_UI_IMAGE_TAG ?= 9fee0922a8d60321f9b46aecebf3832fe34c0ddd
+SW_UI_IMAGE_TAG ?= 798c55ce8ac4124498474de65ecf1d631bf3904a
 
 SW_CLI_IMAGE ?= 
ghcr.io/apache/skywalking-cli/skywalking-cli:0883266bfaa36612927b69e35781b64ea181758d
 SW_EVENT_EXPORTER_IMAGE ?= 
ghcr.io/apache/skywalking-kubernetes-event-exporter/skywalking-kubernetes-event-exporter:8a012a3f968cb139f817189afb9b3748841bba22



(skywalking-go) branch fix-wrong-dir-structure deleted (was b0bbdc0)

2023-11-15 Thread liuhan
This is an automated email from the ASF dual-hosted git repository.

liuhan pushed a change to branch fix-wrong-dir-structure
in repository https://gitbox.apache.org/repos/asf/skywalking-go.git


 was b0bbdc0  add test cases and remove unnecessary error

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.



(skywalking-go) branch main updated: Fix wrong plugin structure (#150)

2023-11-15 Thread liuhan
This is an automated email from the ASF dual-hosted git repository.

liuhan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-go.git


The following commit(s) were added to refs/heads/main by this push:
 new 774a6d5  Fix wrong plugin structure (#150)
774a6d5 is described below

commit 774a6d56baba1187eb03bf1861af542c923b3dff
Author: Jiajing LU 
AuthorDate: Wed Nov 15 20:33:17 2023 +0800

Fix wrong plugin structure (#150)
---
 go.work.sum| 16 +++--
 plugins/trace-activation/instrument.go | 42 +++---
 .../{ => trace}/add_log_intercepter.go |  0
 .../{ => trace}/async_finish_intercepter.go|  0
 .../{ => trace}/async_log_intercepter.go   |  0
 .../{ => trace}/async_prepare_intercepter.go   |  0
 .../{ => trace}/async_tag_intercepter.go   |  0
 .../{ => trace}/capture_intercepter.go |  0
 .../{ => trace}/continue_intercepter.go|  0
 .../{ => trace}/correlation_get_intercepter.go |  0
 .../{ => trace}/correlation_set_intercepter.go |  0
 .../{ => trace}/create_entryspan_intercepter.go|  0
 .../{ => trace}/create_exitspan_intercepter.go |  0
 .../{ => trace}/create_localspan_intercepter.go|  0
 .../{ => trace}/get_segmentid_intercepter.go   |  0
 .../{ => trace}/get_spanid_intercepter.go  |  0
 .../{ => trace}/get_traceid_intercepter.go |  0
 .../{ => trace}/set_component_interceptor.go   |  0
 .../{ => trace}/set_name_intercepter.go|  0
 .../{ => trace}/set_tag_intercepter.go |  0
 .../{ => trace}/stopspan_intercepter.go|  0
 test/plugins/scenarios/plugin_exclusion/go.sum | 33 +
 tools/go-agent/instrument/plugins/instrument.go| 10 +++---
 .../go-agent/instrument/plugins/instrument_test.go | 27 +-
 24 files changed, 90 insertions(+), 38 deletions(-)

diff --git a/go.work.sum b/go.work.sum
index 74ee681..566b746 100644
--- a/go.work.sum
+++ b/go.work.sum
@@ -829,8 +829,6 @@ github.com/evanphx/json-patch/v5 v5.6.0/go.mod 
h1:G79N1coSVB93tBe7j6PhzjmR3/2Vvl
 github.com/exoscale/egoscale v0.46.0/go.mod 
h1:mpEXBpROAa/2i5GC0r33rfxG+TxSEka11g1PIXt9+zc=
 github.com/exoscale/egoscale v0.67.0 
h1:qgWh7T5IZGrNWtg6ib4dr+76WThvB+odTtGG+DGbXF8=
 github.com/exoscale/egoscale v0.67.0/go.mod 
h1:wi0myUxPsV8SdEtdJHQJxFLL/wEw9fiw9Gs1PWRkvkM=
-github.com/fasthttp/router v1.0.2 
h1:rdYdcAmwOLqWuFgc4afa409SYmuw4t0A66K5Ib+GT3I=
-github.com/fasthttp/router v1.0.2/go.mod 
h1:Myk/ofrwtfiLSCIfbE44+e+PyP3mR6JhZg3AYzqwJI0=
 github.com/fastly/go-utils v0.0.0-20180712184237-d95a45783239 
h1:Ghm4eQYC0nEPnSJdVkTrXpu9KtoVCSo1hg7mtI7G9KU=
 github.com/fatih/camelcase v1.0.0 
h1:hxNvNX/xYBp0ovncs8WyWZrOrpBNub/JfaMvbURyft8=
 github.com/fatih/color v1.7.0 h1:DkWD4oS2D8LGGgTQ6IvwJJXSL5Vp2ffcQg58nFV38Ys=
@@ -1146,7 +1144,6 @@ github.com/kisielk/errcheck v1.5.0 
h1:e8esj/e4R+SAOwFwN+n3zr0nYeCyeweozKfO23MvHz
 github.com/kisielk/gotool v1.0.0 
h1:AV2c/EiW3KqPNT9ZKl07ehoAGi4C5/01Cfbblndcapg=
 github.com/klauspost/asmfmt v1.3.2 
h1:4Ri7ox3EwapiOjCki+hw14RyKk201CN4rzyCJRFLpK4=
 github.com/klauspost/asmfmt v1.3.2/go.mod 
h1:AG8TuvYojzulgDAMCnYn50l/5QV3Bs/tp6j0HLHbNSE=
-github.com/klauspost/compress v1.8.2/go.mod 
h1:RyIbtBH6LamlWaDj8nUwkbUhJ87Yi3uG0guNDohfE1A=
 github.com/klauspost/compress v1.10.5/go.mod 
h1:aoV0uJVorq1K+umq18yTdKaF57EivdYsUV+/s2qKfXs=
 github.com/klauspost/compress v1.11.3/go.mod 
h1:aoV0uJVorq1K+umq18yTdKaF57EivdYsUV+/s2qKfXs=
 github.com/klauspost/compress v1.11.13/go.mod 
h1:aoV0uJVorq1K+umq18yTdKaF57EivdYsUV+/s2qKfXs=
@@ -1154,7 +1151,6 @@ github.com/klauspost/compress v1.15.9 
h1:wKRjX6JRtDdrE9qwa4b/Cip7ACOshUI4smpCQan
 github.com/klauspost/compress v1.15.12 
h1:YClS/PImqYbn+UILDnqxQCZ3RehC9N318SU3kElDUEM=
 github.com/klauspost/compress v1.15.12/go.mod 
h1:QPwzmACJjUTFsnSHH934V6woptycfrDDJnH7hvFVbGM=
 github.com/klauspost/cpuid v1.2.1 
h1:vJi+O/nMdFt0vqm8NZBI6wzALWdA2X+egi0ogNyrC/w=
-github.com/klauspost/cpuid v1.2.1/go.mod 
h1:Pj4uuM528wm8OyEC2QMXAi2YiTZ96dNQPGgoMS4s3ek=
 github.com/knadh/koanf v1.4.4/go.mod 
h1:Hgyjp4y8v44hpZtPzs7JZfRAW5AhN7KfZcwv1RYggDs=
 github.com/knadh/koanf v1.5.0 h1:q2TSd/3Pyc/5yP9ldIrSdIz26MCcyNQzW0pEAugLPNs=
 github.com/koding/multiconfig v0.0.0-20171124222453-69c27309b2d7 
h1:SWlt7BoQNASbhTUD0Oy5yysI2seJ7vWuGUp///OM4TM=
@@ -1416,6 +1412,8 @@ github.com/pelletier/go-toml v1.9.5/go.mod 
h1:u1nR/EPcESfeI/szUZKdtJ0xRNbUoANCko
 github.com/performancecopilot/speed v3.0.0+incompatible 
h1:2WnRzIquHa5QxaJKShDkLM+sc0JPuwhXzK8OYOyt3Vg=
 github.com/peterbourgon/diskv v2.0.1+incompatible 
h1:UBdAOUP5p4RWqPBg048CAvpKN+vxiaj6gdUUzhl4XmI=
 github.com/philhofer/fwd v1.0.0 h1:UbZqGr5Y38ApvM/V/jEljVxwocdweyH+vmYvRPBnbqQ=
+github.com/philhofer/fwd v1.1.2 h1:bnDivRJ1EWPjUIRXV5KfORO897HTbpFAQddBdE8t7Gw=
+github.com/philhofer/fwd v1.1.2/go.mod 
h1:qkPdfjR2SIEbspLqpe1tO4n5yICnr2DY7mqEx2tUTP0=
 github.com/pierrec/lz4 

Re: [PR] Fix wrong plugin structure [skywalking-go]

2023-11-15 Thread via GitHub


mrproliu merged PR #150:
URL: https://github.com/apache/skywalking-go/pull/150


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix wrong plugin structure [skywalking-go]

2023-11-15 Thread via GitHub


mrproliu commented on code in PR #150:
URL: https://github.com/apache/skywalking-go/pull/150#discussion_r1394137419


##
tools/go-agent/instrument/plugins/instrument.go:
##
@@ -107,9 +108,8 @@ func (i *Instrument) CouldHandle(opts *api.CompileOptions) 
bool {
// check the version of the framework could handler
version, err := i.tryToFindThePluginVersion(opts, ins)
if err != nil {
-   // Local package (e.g. replaced toolkit) does not have 
version.
-   // So when the version is not detected, we should not 
skip it.
-   logrus.Warnf("the plugin %s %s", ins.Name(), err)
+   logrus.Warnf("ignore the plugin %s, because %s", 
ins.Name(), err)
+   continue

Review Comment:
   No, we don't need to add the error here. If there is no go file, then it 
will not have any enhancements. If an error is returned here, it will cause 
useless error log output in the upper layer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(skywalking) branch master updated: sync ui (#11551)

2023-11-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/master by this push:
 new 798c55ce8a sync ui (#11551)
798c55ce8a is described below

commit 798c55ce8ac4124498474de65ecf1d631bf3904a
Author: Fine0830 
AuthorDate: Wed Nov 15 20:22:44 2023 +0800

sync ui (#11551)
---
 skywalking-ui | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/skywalking-ui b/skywalking-ui
index 832dc1676b..a4271bb479 16
--- a/skywalking-ui
+++ b/skywalking-ui
@@ -1 +1 @@
-Subproject commit 832dc1676b7a79ed74759be3cb4f35ff522ac9b4
+Subproject commit a4271bb4797034e5921e4ef795cb6df131cdc8c8



Re: [PR] Sync UI [skywalking]

2023-11-15 Thread via GitHub


wu-sheng merged PR #11551:
URL: https://github.com/apache/skywalking/pull/11551


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Sync UI [skywalking]

2023-11-15 Thread via GitHub


Fine0830 opened a new pull request, #11551:
URL: https://github.com/apache/skywalking/pull/11551

   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace 
the issue number. Closes #.
   - [ ] Update the [`CHANGES` 
log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
   
   
   * Enhance the Dark Theme.
   
   Signed-off-by: Qiuxia Fan 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(skywalking-booster-ui) branch main updated: feat: enhance the Dark Theme (#336)

2023-11-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git


The following commit(s) were added to refs/heads/main by this push:
 new a4271bb4 feat: enhance the Dark Theme (#336)
a4271bb4 is described below

commit a4271bb4797034e5921e4ef795cb6df131cdc8c8
Author: Fine0830 
AuthorDate: Wed Nov 15 19:53:23 2023 +0800

feat: enhance the Dark Theme (#336)
---
 src/components/Graph.vue   |  8 +-
 src/hooks/data.ts  | 40 ++
 src/hooks/useLegendProcessor.ts| 39 ++
 src/styles/reset.scss  | 86 -
 src/styles/theme.scss  | 88 ++
 src/views/dashboard/controls/Tab.vue   |  2 +-
 src/views/dashboard/graphs/Bar.vue |  2 +-
 src/views/dashboard/graphs/Line.vue|  2 +-
 src/views/dashboard/graphs/components/Legend.vue   |  3 +-
 src/views/dashboard/panel/Layout.vue   |  2 +-
 .../related/topology/components/Sankey.vue |  6 ++
 11 files changed, 151 insertions(+), 127 deletions(-)

diff --git a/src/components/Graph.vue b/src/components/Graph.vue
index 2ad0b48f..5ed35d1d 100644
--- a/src/components/Graph.vue
+++ b/src/components/Graph.vue
@@ -252,11 +252,11 @@ limitations under the License. -->
 display: block;
 white-space: nowrap;
 z-index: 999;
-box-shadow: #ddd 1px 2px 10px;
+box-shadow: var(--sw-topology-box-shadow);
 transition: all cubic-bezier(0.075, 0.82, 0.165, 1) linear;
-background-color: rgb(255 255 255);
+background-color: var(--sw-bg-color-overlay);
 border-radius: 4px;
-color: rgb(51 51 51);
+color: $font-color;
 padding: 5px;
   }
 
@@ -267,7 +267,7 @@ limitations under the License. -->
 
 &:hover {
   color: $active-color;
-  background-color: #eee;
+  background-color: $popper-hover-bg-color;
 }
   }
 
diff --git a/src/hooks/data.ts b/src/hooks/data.ts
index 8d88e076..3d45a00d 100644
--- a/src/hooks/data.ts
+++ b/src/hooks/data.ts
@@ -130,3 +130,43 @@ export const RespFields: Indexable = {
 error
   }`,
 };
+
+export const DarkChartColors = [
+  "#79bbff",
+  "#a0a7e6",
+  "#30A4EB",
+  "#45BFC0",
+  "#ebbf93",
+  "#884dde",
+  "#1bbf93",
+  "#7289ab",
+  "#f56c6c",
+  "#81feb7",
+  "#4094fa",
+  "#ff894d",
+  "#884dde",
+  "#ebbf93",
+  "#fedc6d",
+  "#da7cfa",
+  "#b88230",
+  "#a0cfff",
+];
+
+export const LightChartColors = [
+  "#3f96e3",
+  "#a0a7e6",
+  "#45BFC0",
+  "#FFCC55",
+  "#FF6A84",
+  "#c23531",
+  "#2f4554",
+  "#61a0a8",
+  "#d48265",
+  "#91c7ae",
+  "#749f83",
+  "#ca8622",
+  "#bda29a",
+  "#6e7074",
+  "#546570",
+  "#c4ccd3",
+];
diff --git a/src/hooks/useLegendProcessor.ts b/src/hooks/useLegendProcessor.ts
index 11c4e4b4..e9439a09 100644
--- a/src/hooks/useLegendProcessor.ts
+++ b/src/hooks/useLegendProcessor.ts
@@ -16,6 +16,9 @@
  */
 import type { LegendOptions } from "@/types/dashboard";
 import { isDef } from "@/utils/is";
+import { DarkChartColors, LightChartColors } from "./data";
+import { useAppStoreWithOut } from "@/store/modules/app";
+import { Themes } from "@/constants/data";
 
 export default function useLegendProcess(legend?: LegendOptions) {
   let isRight = false;
@@ -96,37 +99,11 @@ export default function useLegendProcess(legend?: 
LegendOptions) {
 
 return { source, headers };
   }
-  function chartColors(keys: string[]) {
-let color: string[] = [];
-switch (keys.length) {
-  case 2:
-color = ["#FF6A84", "#a0b1e6"];
-break;
-  case 1:
-color = ["#3f96e3"];
-break;
-  default:
-color = [
-  "#30A4EB",
-  "#45BFC0",
-  "#FFCC55",
-  "#FF6A84",
-  "#a0a7e6",
-  "#c23531",
-  "#2f4554",
-  "#61a0a8",
-  "#d48265",
-  "#91c7ae",
-  "#749f83",
-  "#ca8622",
-  "#bda29a",
-  "#6e7074",
-  "#546570",
-  "#c4ccd3",
-];
-break;
-}
-return color;
+  function chartColors() {
+const appStore = useAppStoreWithOut();
+const list = appStore.theme === Themes.Dark ? DarkChartColors : 
LightChartColors;
+
+return list;
   }
   return { showEchartsLegend, isRight, aggregations, chartColors };
 }
diff --git a/src/styles/reset.scss b/src/styles/reset.scss
index d2396848..75987932 100644
--- a/src/styles/reset.scss
+++ b/src/styles/reset.scss
@@ -123,89 +123,3 @@ code,
 pre {
   font-family: Consolas, Menlo, Courier, monospace;
 }
-
-.el-menu {
-  --el-menu-item-height: 50px;
-}
-
-.el-menu-item-group__title {
-  display: none;
-}
-
-.el-sub-menu .el-menu-item {
-  height: 40px;
-  line-height: 40px;
-  padding: 0 0 0 56px !important;
-}
-
-.el-sub-menu__title {
-  .el-icon.menu-icons {
-margin-top: -5px 

Re: [PR] feat: enhance the Dark Theme [skywalking-booster-ui]

2023-11-15 Thread via GitHub


wu-sheng merged PR #336:
URL: https://github.com/apache/skywalking-booster-ui/pull/336


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] feat: enhance the Dark Theme [skywalking-booster-ui]

2023-11-15 Thread via GitHub


Fine0830 opened a new pull request, #336:
URL: https://github.com/apache/skywalking-booster-ui/pull/336

   * Change legend colors for charts.
   
   * Optimize the selected widgets style and popovers style on widgets.
   
   Video 
   
   
https://github.com/apache/skywalking-booster-ui/assets/20871783/a49afe34-442a-4d74-9873-aacd94d0bf19
   
   
   Signed-off-by: Qiuxia Fan 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix wrong plugin structure [skywalking-go]

2023-11-15 Thread via GitHub


lujiajing1126 commented on code in PR #150:
URL: https://github.com/apache/skywalking-go/pull/150#discussion_r1393862011


##
tools/go-agent/instrument/plugins/instrument.go:
##
@@ -107,9 +108,8 @@ func (i *Instrument) CouldHandle(opts *api.CompileOptions) 
bool {
// check the version of the framework could handler
version, err := i.tryToFindThePluginVersion(opts, ins)
if err != nil {
-   // Local package (e.g. replaced toolkit) does not have 
version.
-   // So when the version is not detected, we should not 
skip it.
-   logrus.Warnf("the plugin %s %s", ins.Name(), err)
+   logrus.Warnf("ignore the plugin %s, because %s", 
ins.Name(), err)
+   continue

Review Comment:
   > I think a warm log is enough, an error will let the compile phase failure.
   
   
![image](https://github.com/apache/skywalking-go/assets/2568208/64d886c2-6558-4fde-9572-06e811150dc9)
   
   I meant here. The only possbility to reach here is no go sources.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix wrong plugin structure [skywalking-go]

2023-11-15 Thread via GitHub


mrproliu commented on code in PR #150:
URL: https://github.com/apache/skywalking-go/pull/150#discussion_r1393858336


##
tools/go-agent/instrument/plugins/instrument.go:
##
@@ -107,9 +108,8 @@ func (i *Instrument) CouldHandle(opts *api.CompileOptions) 
bool {
// check the version of the framework could handler
version, err := i.tryToFindThePluginVersion(opts, ins)
if err != nil {
-   // Local package (e.g. replaced toolkit) does not have 
version.
-   // So when the version is not detected, we should not 
skip it.
-   logrus.Warnf("the plugin %s %s", ins.Name(), err)
+   logrus.Warnf("ignore the plugin %s, because %s", 
ins.Name(), err)
+   continue

Review Comment:
   I think a warm log is enough, an error will let the compile phase failure. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix wrong plugin structure [skywalking-go]

2023-11-15 Thread via GitHub


lujiajing1126 commented on code in PR #150:
URL: https://github.com/apache/skywalking-go/pull/150#discussion_r1393844015


##
tools/go-agent/instrument/plugins/instrument.go:
##
@@ -107,9 +108,8 @@ func (i *Instrument) CouldHandle(opts *api.CompileOptions) 
bool {
// check the version of the framework could handler
version, err := i.tryToFindThePluginVersion(opts, ins)
if err != nil {
-   // Local package (e.g. replaced toolkit) does not have 
version.
-   // So when the version is not detected, we should not 
skip it.
-   logrus.Warnf("the plugin %s %s", ins.Name(), err)
+   logrus.Warnf("ignore the plugin %s, because %s", 
ins.Name(), err)
+   continue

Review Comment:
   If we skip all args in the loop, shall we return an error?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(skywalking-go) branch fix-wrong-dir-structure updated (c517e86 -> b0bbdc0)

2023-11-15 Thread lujiajing
This is an automated email from the ASF dual-hosted git repository.

lujiajing pushed a change to branch fix-wrong-dir-structure
in repository https://gitbox.apache.org/repos/asf/skywalking-go.git


from c517e86  only allow specific error
 add b0bbdc0  add test cases and remove unnecessary error

No new revisions were added by this update.

Summary of changes:
 tools/go-agent/instrument/plugins/instrument.go| 11 -
 .../go-agent/instrument/plugins/instrument_test.go | 27 +-
 2 files changed, 31 insertions(+), 7 deletions(-)



Re: [PR] Optimize to final type [skywalking-java]

2023-11-15 Thread via GitHub


wu-sheng commented on PR #648:
URL: https://github.com/apache/skywalking-java/pull/648#issuecomment-1811995611

   We are happy to accept change if this thing really impacts perf.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Optimize to final type [skywalking-java]

2023-11-15 Thread via GitHub


ruqinhu commented on PR #648:
URL: https://github.com/apache/skywalking-java/pull/648#issuecomment-1811993037

   > I am not following. Instrument process only happens on booting and/or 
class first loaded.Nothing more. Do you have any evidence to prove the 
performance has been impacted?
   
   i see,


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Optimize to final type [skywalking-java]

2023-11-15 Thread via GitHub


ruqinhu closed pull request #648: Optimize to final type
URL: https://github.com/apache/skywalking-java/pull/648


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Optimize to final type [skywalking-java]

2023-11-15 Thread via GitHub


wu-sheng commented on PR #648:
URL: https://github.com/apache/skywalking-java/pull/648#issuecomment-1811990588

   I am not following. Instrument process only happens on booting and/or class 
first loaded.Nothing more.
   Do you have any evidence to prove the performance has been impacted?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Optimize to final type [skywalking-java]

2023-11-15 Thread via GitHub


ruqinhu commented on PR #648:
URL: https://github.com/apache/skywalking-java/pull/648#issuecomment-1811988556

   > Why ClassNotFound is a high frequency thing?
   
   It is unnecessary to judge whether it is empty. Will JIT also optimize it?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Optimize to final type [skywalking-java]

2023-11-15 Thread via GitHub


wu-sheng commented on PR #648:
URL: https://github.com/apache/skywalking-java/pull/648#issuecomment-1811982200

   Why ClassNotFound is a high frequency thing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] Excuse me, after Docker Compose upgraded Apache/skywalking oap server to version 9.6.0, Apache/skywalking ui to version 9.6.0, and skywalking agent to version 9.0.0, has anyone encounter

2023-11-15 Thread via GitHub


wu-sheng closed issue #11550: [Bug] Excuse me, after Docker Compose upgraded 
Apache/skywalking oap server to version 9.6.0, Apache/skywalking ui to version 
9.6.0, and skywalking agent to version 9.0.0, has anyone encountered the issue 
of skywalking agent and oap being unable to communicate? The previous versions 
of Apache/skywalking oap server, Apache/skywalking ui, and skywalking agent 
were both 8.6.0 and 8.9.0, which are normal for use
URL: https://github.com/apache/skywalking/issues/11550


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] Excuse me, after Docker Compose upgraded Apache/skywalking oap server to version 9.6.0, Apache/skywalking ui to version 9.6.0, and skywalking agent to version 9.0.0, has anyone encounter

2023-11-15 Thread via GitHub


wu-sheng commented on issue #11550:
URL: https://github.com/apache/skywalking/issues/11550#issuecomment-1811981045

   This may be a discussion only. And we would not be able to debug for you. 
The content is formated badly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] [Bug] Excuse me, after Docker Compose upgraded Apache/skywalking oap server to version 9.6.0, Apache/skywalking ui to version 9.6.0, and skywalking agent to version 9.0.0, has anyone encountered t

2023-11-15 Thread via GitHub


cfy3133 opened a new issue, #11550:
URL: https://github.com/apache/skywalking/issues/11550

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Apache SkyWalking Component
   
   OAP server (apache/skywalking)
   
   ### What happened
   
   Skywalking oap and skywalking agent cannot connect and communicate
   
   ### What you expected to happen
   
   Skywalking oap and Skywalking agent can connect and communicate normally
   
   ### How to reproduce
   
   The yaml configuration file for Docker Compose startup with issues after 
upgrade is as follows:
   version: '3.8'
   services:
 elasticsearch:
   image: elasticsearch:7.17.9
   container_name: elasticsearch
   restart: always
   ports:
 - "9200:9200"
 - "9300:9300"
   networks:
 - skywalking
   environment:
 TZ: Asia/Shanghai
 discovery.type: single-node
 bootstrap.memory_lock: true
 ES_JAVA_OPTS: "-Xms1024m -Xmx1024m"
   ulimits:
 memlock:
   soft: -1
   hard: -1
   volumes:
 - /usr/share/zoneinfo/Asia/Shanghai:/etc/localtime:ro
   
 oap:
   image: apache/skywalking-oap-server:9.6.0
   container_name: oap
   restart: always
   depends_on:
 - elasticsearch
   links:
 - elasticsearch
   ports:
 - "1234:1234"
 - "11800:11800"
 - "12800:12800"
   networks:
 - skywalking
   environment:
 TZ: Asia/Shanghai
 SW_STORAGE: elasticsearch
 SW_STORAGE_ES_CLUSTER_NODES: elasticsearch:9200
 SW_HEALTH_CHECKER: default
 SW_TELEMETRY: prometheus
 JAVA_OPTS: "-Xms2048m -Xmx2048m"
   volumes:
 - /usr/share/zoneinfo/Asia/Shanghai:/etc/localtime:ro
   
 ui:
   image: apache/skywalking-ui:9.6.0
   container_name: ui
   restart: always
   depends_on:
 - oap
   links:
 - oap
   ports:
 - "28080:8080"
   networks:
 - skywalking
   environment:
 TZ: Asia/Shanghai
 SW_OAP_ADDRESS: http://oap:12800
 SW_HEALTH_CHECKER: default
 SW_TIMEOUT: 20
   volumes:
 - /usr/share/zoneinfo/Asia/Shanghai:/etc/localtime:ro
   
   networks:
 skywalking:
   driver: bridge
   
   
   The yaml configuration file for the Docker Compose startup without any 
issues before upgrading is as follows:
   version: '3.8'
   services:
 elasticsearch:
   image: elasticsearch:7.17.9
   container_name: elasticsearch
   restart: always
   ports:
 - "9200:9200"
 - "9300:9300"
   networks:
 - skywalking
   environment:
 TZ: Asia/Shanghai
 discovery.type: single-node
 bootstrap.memory_lock: true
 ES_JAVA_OPTS: "-Xms1024m -Xmx1024m"
   ulimits:
 memlock:
   soft: -1
   hard: -1
   volumes:
 - /usr/share/zoneinfo/Asia/Shanghai:/etc/localtime:ro
   
 oap:
   image: apache/skywalking-oap-server:8.6.0
   container_name: oap
   restart: always
   depends_on:
 - elasticsearch
   links:
 - elasticsearch
   ports:
 - "1234:1234"
 - "11800:11800"
 - "12800:12800"
   networks:
 - skywalking
   environment:
 TZ: Asia/Shanghai
 SW_STORAGE: elasticsearch
 SW_STORAGE_ES_CLUSTER_NODES: elasticsearch:9200
 SW_HEALTH_CHECKER: default
 SW_TELEMETRY: prometheus
 JAVA_OPTS: "-Xms2048m -Xmx2048m"
   volumes:
 - /usr/share/zoneinfo/Asia/Shanghai:/etc/localtime:ro
   
 ui:
   image: apache/skywalking-ui:8.6.0
   container_name: ui
   restart: always
   depends_on:
 - oap
   links:
 - oap
   ports:
 - "28080:8080"
   networks:
 - skywalking
   environment:
 TZ: Asia/Shanghai
 SW_OAP_ADDRESS: http://oap:12800
 SW_HEALTH_CHECKER: default
 SW_TIMEOUT: 20
   volumes:
 - /usr/share/zoneinfo/Asia/Shanghai:/etc/localtime:ro
   
   networks:
 skywalking:
   driver: bridge
   
   The startup command is as follows:
   java -javaagent:./agent/skywalking-agent.jar 
-Dskywalking.agent.service_name=test 
-Dskywalking.collector.backend_service=192.168.3.100:11800 -jar LiuMa-1.3.1.jar 
>/tmp/skywaling.out 2>&1 &
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit a pull request to fix on your own?
   
   - [ ] Yes I am willing to submit a pull request on my own!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the

(skywalking-go) branch fix-wrong-dir-structure updated (584a5b3 -> c517e86)

2023-11-15 Thread lujiajing
This is an automated email from the ASF dual-hosted git repository.

lujiajing pushed a change to branch fix-wrong-dir-structure
in repository https://gitbox.apache.org/repos/asf/skywalking-go.git


from 584a5b3  fix lint
 add c517e86  only allow specific error

No new revisions were added by this update.

Summary of changes:
 tools/go-agent/instrument/plugins/instrument.go | 14 ++
 1 file changed, 6 insertions(+), 8 deletions(-)