Re: [PR] feat: introduce flame graph to the trace profiling [skywalking-booster-ui]
CodePrometheus commented on PR #407: URL: https://github.com/apache/skywalking-booster-ui/pull/407#issuecomment-2260750211 Not ready for CR yet, please give me some time to improve the quality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] feat: introduce flame graph to the trace profiling [skywalking-booster-ui]
CodePrometheus opened a new pull request, #407: URL: https://github.com/apache/skywalking-booster-ui/pull/407 Closes https://github.com/apache/skywalking/issues/12309 https://github.com/user-attachments/assets/57751ecf-2edc-4338-85db-fca5b5cb1c8c;> Signed-off-by: Zixin Zhou [zhouzi...@apache.org](mailto:zhouzi...@apache.org) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Unknown Node when receive Kubernetes peer address is not aware in current cluster [skywalking]
wu-sheng closed pull request #12496: Add Unknown Node when receive Kubernetes peer address is not aware in current cluster URL: https://github.com/apache/skywalking/pull/12496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [BanyanDB-Server] Optimizing the query with low cardinality [skywalking]
wu-sheng closed issue #12240: [BanyanDB-Server] Optimizing the query with low cardinality URL: https://github.com/apache/skywalking/issues/12240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Measure index [skywalking-banyandb]
wu-sheng merged PR #502: URL: https://github.com/apache/skywalking-banyandb/pull/502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: add tracing.TagDBStatement and tracing.TagDBSqlParameters for gorm [skywalking-go]
wu-sheng merged PR #189: URL: https://github.com/apache/skywalking-go/pull/189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Measure index [skywalking-banyandb]
hanahmily opened a new pull request, #502: URL: https://github.com/apache/skywalking-banyandb/pull/502 - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#12240. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: add tracing.TagDBStatement and tracing.TagDBSqlParameters for gorm [skywalking-go]
mrproliu commented on code in PR #189: URL: https://github.com/apache/skywalking-go/pull/189#discussion_r1697992327 ## CHANGES.md: ## @@ -16,6 +16,7 @@ Release Notes. * Support higher versions of grpc. * Support [go-elasticsearchv8](https://github.com/elastic/go-elasticsearch) database client framework. * Support `http.Hijacker` interface for mux plugin. +* Support `db.statement` and `db.sql.parameters(optional)` for Gorm. Review Comment: ```suggestion * Support collect statements and parameters in the Gorm plugin. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: add tracing.TagDBStatement and tracing.TagDBSqlParameters for gorm [skywalking-go]
Hair1ossTeenager commented on PR #189: URL: https://github.com/apache/skywalking-go/pull/189#issuecomment-2259798408 > Thanks! Could you also update the [CHANGES.md](https://github.com/apache/skywalking-go/blob/main/CHANGES.md) done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump up graphql-java [skywalking]
kezhenxu94 merged PR #12495: URL: https://github.com/apache/skywalking/pull/12495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add Unknown Node when receive Kubernetes peer address is not aware in current cluster [skywalking]
mrproliu opened a new pull request, #12496: URL: https://github.com/apache/skywalking/pull/12496 In the Kubernetes Access Log receiver, if the peer address is not aware in the current cluster, then define it as an `Unknown` node instant to ignore the traffic. - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: add tracing.TagDBStatement and tracing.TagDBSqlParameters for gorm [skywalking-go]
mrproliu commented on PR #189: URL: https://github.com/apache/skywalking-go/pull/189#issuecomment-2259779218 Thanks! Could you also update the [CHANGES.md](https://github.com/apache/skywalking-go/blob/main/CHANGES.md) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump up graphql-java [skywalking]
kezhenxu94 opened a new pull request, #12495: URL: https://github.com/apache/skywalking/pull/12495 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1697906083
##
apm-sniffer/apm-sdk-plugin/spring-plugins/spring-jms-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/jms/MessageListenerInterceptor.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.spring.jms;
+
+import org.apache.skywalking.apm.agent.core.context.CarrierItem;
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+
+import javax.jms.Message;
+import java.lang.reflect.Method;
+
+public class MessageListenerInterceptor implements
InstanceMethodsAroundInterceptor {
+
+private static final String OPERATION_NAME_PREFIX = "JMS/";
+private static final String OPERATION_NAME_SUFFIX = "/execute";
+
+@Override
+public void beforeMethod(EnhancedInstance objInst,
+ Method method,
+ Object[] allArguments, Class[] argumentsTypes,
+ MethodInterceptResult result) throws Throwable {
+if (allArguments[1] == null) {
+return;
+}
+Message message = (Message) allArguments[1];
+ContextCarrier contextCarrier = new ContextCarrier();
+CarrierItem next = contextCarrier.items();
+while (next.hasNext()) {
+next = next.next();
+Object propertyValue =
message.getStringProperty(next.getHeadKey());
+if (propertyValue != null) {
+next.setHeadValue(propertyValue.toString());
+}
+}
Review Comment:
Context carrier is used for trace context propagation, as local span, we
don't need that.
As well as transmission latency, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1697891559
##
apm-sniffer/apm-sdk-plugin/spring-plugins/spring-jms-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/jms/MessageListenerInterceptor.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.spring.jms;
+
+import org.apache.skywalking.apm.agent.core.context.CarrierItem;
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+
+import javax.jms.Message;
+import java.lang.reflect.Method;
+
+public class MessageListenerInterceptor implements
InstanceMethodsAroundInterceptor {
+
+private static final String OPERATION_NAME_PREFIX = "JMS/";
+private static final String OPERATION_NAME_SUFFIX = "/execute";
+
+@Override
+public void beforeMethod(EnhancedInstance objInst,
+ Method method,
+ Object[] allArguments, Class[] argumentsTypes,
+ MethodInterceptResult result) throws Throwable {
+if (allArguments[1] == null) {
+return;
+}
+Message message = (Message) allArguments[1];
+ContextCarrier contextCarrier = new ContextCarrier();
+CarrierItem next = contextCarrier.items();
+while (next.hasNext()) {
+next = next.next();
+Object propertyValue =
message.getStringProperty(next.getHeadKey());
+if (propertyValue != null) {
+next.setHeadValue(propertyValue.toString());
+}
+}
Review Comment:
We changed to local span, aren't you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
cloudgc commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1697856531
##
apm-sniffer/apm-sdk-plugin/spring-plugins/spring-jms-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/jms/MessageListenerInterceptor.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.spring.jms;
+
+import org.apache.skywalking.apm.agent.core.context.CarrierItem;
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+
+import javax.jms.Message;
+import java.lang.reflect.Method;
+
+public class MessageListenerInterceptor implements
InstanceMethodsAroundInterceptor {
+
+private static final String OPERATION_NAME_PREFIX = "JMS/";
+private static final String OPERATION_NAME_SUFFIX = "/execute";
+
+@Override
+public void beforeMethod(EnhancedInstance objInst,
+ Method method,
+ Object[] allArguments, Class[] argumentsTypes,
+ MethodInterceptResult result) throws Throwable {
+if (allArguments[1] == null) {
+return;
+}
+Message message = (Message) allArguments[1];
+ContextCarrier contextCarrier = new ContextCarrier();
+CarrierItem next = contextCarrier.items();
+while (next.hasNext()) {
+next = next.next();
+Object propertyValue =
message.getStringProperty(next.getHeadKey());
+if (propertyValue != null) {
+next.setHeadValue(propertyValue.toString());
+}
+}
Review Comment:
dude, use ContextManager#createEntrySpan and set operationName , you need
fix different scenes topic or queue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: add tracing.TagDBStatement and tracing.TagDBSqlParameters for gorm [skywalking-go]
wu-sheng commented on PR #189: URL: https://github.com/apache/skywalking-go/pull/189#issuecomment-2259575284 You should consider - Trace SQL parameter should be optional. Because it impacts the performance. - Update test scenario, https://github.com/apache/skywalking-go/tree/main/test/plugins/scenarios/gorm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] feat: add tracing.TagDBStatement and tracing.TagDBSqlParameters for gorm [skywalking-go]
Hair1ossTeenager opened a new pull request, #189: URL: https://github.com/apache/skywalking-go/pull/189 feat: add tracing.TagDBStatement and tracing.TagDBSqlParameters for gorm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] 0.6.1Health check failed [skywalking]
wu-sheng closed issue #12491: [Bug] 0.6.1Health check failed URL: https://github.com/apache/skywalking/issues/12491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] 0.6.1Health check failed [skywalking]
kekekekekeshi commented on issue #12491:
URL: https://github.com/apache/skywalking/issues/12491#issuecomment-2258468168
> Hi, `/usr/bin/banyand-server data` is for the cluster mode. If you want to
run banyandb as a single node, `/usr/bin/banyand-server standalone` works.
Refer to [standalone
installation](https://github.com/apache/skywalking-banyandb/blob/main/docs/installation/standalone.md).
For setting up a cluster, use [cluster
installation](https://github.com/apache/skywalking-banyandb/blob/main/docs/installation/cluster.md).
**I didn't understand the following content**
Node Discovery
The node discovery is based on the etcd cluster. The etcd cluster is
required for the metadata module to provide the metadata service and nodes
discovery service for the whole cluster.
The host is registered to the etcd cluster by the banyand-server-static
automatically based on node-host-provider :
node-host-provider=hostname : Default. The OS's hostname is registered as
the host part in the address.
node-host-provider=ip : The OS's the first non-loopback active IP
address(IPv4) is registered as the host part in the address.
node-host-provider=flag : node-host is registered as the host part in the
address.
**When I start data and then go to start liaison, there will be an issue
where the node already exists**
/usr/bin/banyand-server data
--etcd-endpoints=[https://10.211.55.21:2379,https://10.211.55.22:2379,https://10.211.55.23:2379](https://10.211.55.21:2379,https//10.211.55.22:2379,https://10.211.55.23:2379)
--etcd-tls-ca-file=/etc/etcd/tls/ca.pem
--etcd-tls-cert-file=/etc/etcd/tls/etcd.pem
--etcd-tls-key-file=/etc/etcd/tls/etcd-key.pem --etcd-username=root
--etcd-password=root --grpc-host=10.211.55.21 --grpc-port=17912
--logging-level=debug
/usr/bin/banyand-server liaison
--etcd-endpoints=https://10.211.55.21:2379,https://10.211.55.22:2379,https://10.211.55.23:2379
--etcd-tls-ca-file=/etc/etcd/tls/ca.pem
--etcd-tls-cert-file=/etc/etcd/tls/etcd.pem
--etcd-tls-key-file=/etc/etcd/tls/etcd-key.pem --etcd-username=root
--etcd-password=root --grpc-host=10.211.55.21 --grpc-port=17912
--logging-level=debug
{"level":"debug","module":"STANDALONE","name":"metadata","registered":1,"total":7,"time":"2024-07-30T22:16:11+08:00","message":"register
flags"}
{"level":"debug","module":"STANDALONE","name":"measure","registered":2,"total":7,"time":"2024-07-30T22:16:11+08:00","message":"register
flags"}
{"level":"debug","module":"STANDALONE","name":"stream","registered":3,"total":7,"time":"2024-07-30T22:16:11+08:00","message":"register
flags"}
{"level":"warn","module":"STANDALONE","name":"max-fan-out-size","registered":3,"time":"2024-07-30T22:16:11+08:00","message":"ignoring
duplicate flag"}
{"level":"debug","module":"STANDALONE","name":"grpc","registered":4,"total":7,"time":"2024-07-30T22:16:11+08:00","message":"register
flags"}
{"level":"debug","module":"STANDALONE","name":"liaison-http","registered":5,"total":7,"time":"2024-07-30T22:16:11+08:00","message":"register
flags"}
{"level":"debug","module":"STANDALONE","name":"pprof-service","registered":6,"total":7,"time":"2024-07-30T22:16:11+08:00","message":"register
flags"}
{"level":"debug","module":"STANDALONE","name":"metric-service","registered":7,"total":7,"time":"2024-07-30T22:16:11+08:00","message":"register
flags"}
{"level":"debug","module":"DATA","name":"metadata","registered":1,"total":6,"time":"2024-07-30T22:16:11+08:00","message":"register
flags"}
{"level":"debug","module":"DATA","name":"server-queue","registered":2,"total":6,"time":"2024-07-30T22:16:11+08:00","message":"register
flags"}
{"level":"debug","module":"DATA","name":"measure","registered":3,"total":6,"time":"2024-07-30T22:16:11+08:00","message":"register
flags"}
{"level":"debug","module":"DATA","name":"stream","registered":4,"total":6,"time":"2024-07-30T22:16:11+08:00","message":"register
flags"}
{"level":"warn","module":"DATA","name":"max-fan-out-size","registered":4,"time":"2024-07-30T22:16:11+08:00","message":"ignoring
duplicate flag"}
{"level":"debug","module":"DATA","name":"pprof-service","registered":5,"total":6,"time":"2024-07-30T22:16:11+08:00","message":"register
flags"}
{"level":"debug","module":"DATA","name":"metric-service","registered":6,"total":6,"time":"2024-07-30T22:16:11+08:00","message":"register
flags"}
{"level":"debug","module":"LIAISON","name":"metadata","registered":1,"total":5,"time":"2024-07-30T22:16:11+08:00","message":"register
flags"}
{"level":"debug","module":"LIAISON","name":"grpc","registered":2,"total":5,"time":"2024-07-30T22:16:11+08:00","message":"register
flags"}
{"level":"debug","module":"LIAISON","name":"liaison-http","registered":3,"total":5,"time":"2024-07-30T22:16:11+08:00","message":"register
flags"}
Re: [I] [Bug] 0.6.1Health check failed [skywalking]
hanahmily commented on issue #12491: URL: https://github.com/apache/skywalking/issues/12491#issuecomment-2258443697 Hi, `/usr/bin/banyand-server data` is for the cluster mode. If you want to run banyandb as a single node, `/usr/bin/banyand-server standalone` works. Refer to [standalone installation](https://github.com/apache/skywalking-banyandb/blob/main/docs/installation/standalone.md). For setting up a cluster, use [cluster installation](https://github.com/apache/skywalking-banyandb/blob/main/docs/installation/cluster.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1697016810
##
apm-sniffer/apm-sdk-plugin/spring-plugins/spring-jms-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/jms/MessageListenerInterceptor.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.spring.jms;
+
+import org.apache.skywalking.apm.agent.core.context.CarrierItem;
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+
+import javax.jms.Message;
+import java.lang.reflect.Method;
+
+public class MessageListenerInterceptor implements
InstanceMethodsAroundInterceptor {
+
+private static final String OPERATION_NAME_PREFIX = "JMS/";
+private static final String OPERATION_NAME_SUFFIX = "/execute";
+
+@Override
+public void beforeMethod(EnhancedInstance objInst,
+ Method method,
+ Object[] allArguments, Class[] argumentsTypes,
+ MethodInterceptResult result) throws Throwable {
+if (allArguments[1] == null) {
+return;
+}
+Message message = (Message) allArguments[1];
+ContextCarrier contextCarrier = new ContextCarrier();
+CarrierItem next = contextCarrier.items();
+while (next.hasNext()) {
+next = next.next();
+Object propertyValue =
message.getStringProperty(next.getHeadKey());
+if (propertyValue != null) {
+next.setHeadValue(propertyValue.toString());
+}
+}
Review Comment:
I think we don't need this and `ContextManager#extract` for a local span.
The segment should link through active MQ span already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Bug] [skywalking]
kekekekekeshi commented on issue #12491:
URL: https://github.com/apache/skywalking/issues/12491#issuecomment-2258384637
banyand-server --version
{"level":"debug","module":"STANDALONE","name":"metadata","registered":1,"total":7,"time":"2024-07-30T21:41:31+08:00","message":"register
flags"}
{"level":"debug","module":"STANDALONE","name":"measure","registered":2,"total":7,"time":"2024-07-30T21:41:31+08:00","message":"register
flags"}
{"level":"debug","module":"STANDALONE","name":"stream","registered":3,"total":7,"time":"2024-07-30T21:41:31+08:00","message":"register
flags"}
{"level":"warn","module":"STANDALONE","name":"max-fan-out-size","registered":3,"time":"2024-07-30T21:41:31+08:00","message":"ignoring
duplicate flag"}
{"level":"debug","module":"STANDALONE","name":"grpc","registered":4,"total":7,"time":"2024-07-30T21:41:31+08:00","message":"register
flags"}
{"level":"debug","module":"STANDALONE","name":"liaison-http","registered":5,"total":7,"time":"2024-07-30T21:41:31+08:00","message":"register
flags"}
{"level":"debug","module":"STANDALONE","name":"pprof-service","registered":6,"total":7,"time":"2024-07-30T21:41:31+08:00","message":"register
flags"}
{"level":"debug","module":"STANDALONE","name":"metric-service","registered":7,"total":7,"time":"2024-07-30T21:41:31+08:00","message":"register
flags"}
{"level":"debug","module":"DATA","name":"metadata","registered":1,"total":6,"time":"2024-07-30T21:41:31+08:00","message":"register
flags"}
{"level":"debug","module":"DATA","name":"server-queue","registered":2,"total":6,"time":"2024-07-30T21:41:31+08:00","message":"register
flags"}
{"level":"debug","module":"DATA","name":"measure","registered":3,"total":6,"time":"2024-07-30T21:41:31+08:00","message":"register
flags"}
{"level":"debug","module":"DATA","name":"stream","registered":4,"total":6,"time":"2024-07-30T21:41:31+08:00","message":"register
flags"}
{"level":"warn","module":"DATA","name":"max-fan-out-size","registered":4,"time":"2024-07-30T21:41:31+08:00","message":"ignoring
duplicate flag"}
{"level":"debug","module":"DATA","name":"pprof-service","registered":5,"total":6,"time":"2024-07-30T21:41:31+08:00","message":"register
flags"}
{"level":"debug","module":"DATA","name":"metric-service","registered":6,"total":6,"time":"2024-07-30T21:41:31+08:00","message":"register
flags"}
{"level":"debug","module":"LIAISON","name":"metadata","registered":1,"total":5,"time":"2024-07-30T21:41:31+08:00","message":"register
flags"}
{"level":"debug","module":"LIAISON","name":"grpc","registered":2,"total":5,"time":"2024-07-30T21:41:31+08:00","message":"register
flags"}
{"level":"debug","module":"LIAISON","name":"liaison-http","registered":3,"total":5,"time":"2024-07-30T21:41:31+08:00","message":"register
flags"}
{"level":"debug","module":"LIAISON","name":"pprof-service","registered":4,"total":5,"time":"2024-07-30T21:41:31+08:00","message":"register
flags"}
{"level":"debug","module":"LIAISON","name":"metric-service","registered":5,"total":5,"time":"2024-07-30T21:41:31+08:00","message":"register
flags"}
version v0.6.1-37-g3da0259-main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[I] [Bug] [skywalking]
kekekekekeshi opened a new issue, #12491: URL: https://github.com/apache/skywalking/issues/12491 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component OAP server (apache/skywalking) ### What happened 2024-07-30 13:28:36,575 org.apache.skywalking.oap.server.telemetry.api.HealthCheckMetrics 44 [main] ERROR [] - [10.0.1-6a9d727] Health check fails org.apache.skywalking.banyandb.v1.client.grpc.exception.UnimplementedException: io.grpc.StatusRuntimeException: UNIMPLEMENTED: unknown service banyandb.database.v1.GroupRegistryService at org.apache.skywalking.banyandb.v1.client.grpc.exception.BanyanDBApiExceptionFactory.createException(BanyanDBApiExceptionFactory.java:50) ~[banyandb-java-client-0.6.0.jar:0.6.0] at org.apache.skywalking.banyandb.v1.client.grpc.exception.BanyanDBGrpcApiExceptionFactory.create(BanyanDBGrpcApiExceptionFactory.java:53) ~[banyandb-java-client-0.6.0.jar:0.6.0] at org.apache.skywalking.banyandb.v1.client.grpc.exception.BanyanDBGrpcApiExceptionFactory.createException(BanyanDBGrpcApiExceptionFactory.java:41) ~[banyandb-java-client-0.6.0.jar:0.6.0] at org.apache.skywalking.banyandb.v1.client.grpc.HandleExceptionsWith.callAndTranslateApiException(HandleExceptionsWith.java:47) ~[banyandb-java-client-0.6.0.jar:0.6.0] at org.apache.skywalking.banyandb.v1.client.grpc.MetadataClient.execute(MetadataClient.java:100) ~[banyandb-java-client-0.6.0.jar:0.6.0] at org.apache.skywalking.banyandb.v1.client.metadata.GroupMetadataRegistry.create(GroupMetadataRegistry.java:40) ~[banyandb-java-client-0.6.0.jar:0.6.0] at org.apache.skywalking.banyandb.v1.client.BanyanDBClient.define(BanyanDBClient.java:410) ~[banyandb-java-client-0.6.0.jar:0.6.0] at org.apache.skywalking.oap.server.storage.plugin.banyandb.BanyanDBStorageClient.defineIfEmpty(BanyanDBStorageClient.java:204) [storage-banyandb-plugin-10.0.1.jar:10.0.1] at org.apache.skywalking.oap.server.storage.plugin.banyandb.BanyanDBStorageProvider.start(BanyanDBStorageProvider.java:178) [storage-banyandb-plugin-10.0.1.jar:10.0.1] at org.apache.skywalking.oap.server.library.module.BootstrapFlow.start(BootstrapFlow.java:46) [library-module-10.0.1.jar:10.0.1] at org.apache.skywalking.oap.server.library.module.ModuleManager.init(ModuleManager.java:75) [library-module-10.0.1.jar:10.0.1] at org.apache.skywalking.oap.server.starter.OAPServerBootstrap.start(OAPServerBootstrap.java:52) [server-starter-10.0.1.jar:10.0.1] at org.apache.skywalking.oap.server.starter.OAPServerStartUp.main(OAPServerStartUp.java:23) [server-starter-10.0.1.jar:10.0.1] Caused by: io.grpc.StatusRuntimeException: UNIMPLEMENTED: unknown service banyandb.database.v1.GroupRegistryService at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:268) ~[grpc-stub-1.63.0.jar:1.63.0] at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:249) ~[grpc-stub-1.63.0.jar:1.63.0] at io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:167) ~[grpc-stub-1.63.0.jar:1.63.0] at org.apache.skywalking.banyandb.database.v1.GroupRegistryServiceGrpc$GroupRegistryServiceBlockingStub.create(GroupRegistryServiceGrpc.java:396) ~[banyandb-java-client-0.6.0.jar:0.6.0] at org.apache.skywalking.banyandb.v1.client.metadata.GroupMetadataRegistry.lambda$create$0(GroupMetadataRegistry.java:40) ~[banyandb-java-client-0.6.0.jar:0.6.0] at org.apache.skywalking.banyandb.v1.client.grpc.HandleExceptionsWith.callAndTranslateApiException(HandleExceptionsWith.java:45) ~[banyandb-java-client-0.6.0.jar:0.6.0] ... 9 more 2024-07-30 13:28:36,581 org.apache.skywalking.oap.server.starter.OAPServerBootstrap 64 [main] ERROR [] - [10.0.1-6a9d727] fail to define group org.apache.skywalking.oap.server.library.module.ModuleStartException: fail to define group at org.apache.skywalking.oap.server.storage.plugin.banyandb.BanyanDBStorageProvider.start(BanyanDBStorageProvider.java:183) ~[storage-banyandb-plugin-10.0.1.jar:10.0.1] at org.apache.skywalking.oap.server.library.module.BootstrapFlow.start(BootstrapFlow.java:46) ~[library-module-10.0.1.jar:10.0.1] at org.apache.skywalking.oap.server.library.module.ModuleManager.init(ModuleManager.java:75) ~[library-module-10.0.1.jar:10.0.1] at org.apache.skywalking.oap.server.starter.OAPServerBootstrap.start(OAPServerBootstrap.java:52) [server-starter-10.0.1.jar:10.0.1] at org.apache.skywalking.oap.server.starter.OAPServerStartUp.main(OAPServerStartUp.java:23) [server-starter-10.0.1.jar:10.0.1] Caused by: java.io.IOException: fail to define group at
Re: [I] [Bug] 连接0.6.1失败 [skywalking]
wu-sheng commented on issue #12490: URL: https://github.com/apache/skywalking/issues/12490#issuecomment-2258372495 No Chinese on GitHub. If you need to discuss in Chinese, use slack CN channel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] 连接0.6.1失败 [skywalking]
wu-sheng closed issue #12490: [Bug] 连接0.6.1失败 URL: https://github.com/apache/skywalking/issues/12490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] 连接0.6.1失败 [skywalking]
kekekekekeshi opened a new issue, #12490: URL: https://github.com/apache/skywalking/issues/12490 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component OAP server (apache/skywalking) ### What happened org.apache.skywalking.banyandb.v1.client.grpc.exception.UnimplementedException: io.grpc.StatusRuntimeException: UNIMPLEMENTED: unknown service banyandb.database.v1.GroupRegistryService at org.apache.skywalking.banyandb.v1.client.grpc.exception.BanyanDBApiExceptionFactory.createException(BanyanDBApiExceptionFactory.java:50) ~[banyandb-java-client-0.6.0.jar:0.6.0] at org.apache.skywalking.banyandb.v1.client.grpc.exception.BanyanDBGrpcApiExceptionFactory.create(BanyanDBGrpcApiExceptionFactory.java:53) ~[banyandb-java-client-0.6.0.jar:0.6.0] at org.apache.skywalking.banyandb.v1.client.grpc.exception.BanyanDBGrpcApiExceptionFactory.createException(BanyanDBGrpcApiExceptionFactory.java:41) ~[banyandb-java-client-0.6.0.jar:0.6.0] at org.apache.skywalking.banyandb.v1.client.grpc.HandleExceptionsWith.callAndTranslateApiException(HandleExceptionsWith.java:47) ~[banyandb-java-client-0.6.0.jar:0.6.0] at org.apache.skywalking.banyandb.v1.client.grpc.MetadataClient.execute(MetadataClient.java:100) ~[banyandb-java-client-0.6.0.jar:0.6.0] at org.apache.skywalking.banyandb.v1.client.metadata.GroupMetadataRegistry.create(GroupMetadataRegistry.java:40) ~[banyandb-java-client-0.6.0.jar:0.6.0] at org.apache.skywalking.banyandb.v1.client.BanyanDBClient.define(BanyanDBClient.java:410) ~[banyandb-java-client-0.6.0.jar:0.6.0] at org.apache.skywalking.oap.server.storage.plugin.banyandb.BanyanDBStorageClient.defineIfEmpty(BanyanDBStorageClient.java:204) [storage-banyandb-plugin-10.0.1.jar:10.0.1] at org.apache.skywalking.oap.server.storage.plugin.banyandb.BanyanDBStorageProvider.start(BanyanDBStorageProvider.java:178) [storage-banyandb-plugin-10.0.1.jar:10.0.1] at org.apache.skywalking.oap.server.library.module.BootstrapFlow.start(BootstrapFlow.java:46) [library-module-10.0.1.jar:10.0.1] at org.apache.skywalking.oap.server.library.module.ModuleManager.init(ModuleManager.java:75) [library-module-10.0.1.jar:10.0.1] at org.apache.skywalking.oap.server.starter.OAPServerBootstrap.start(OAPServerBootstrap.java:52) [server-starter-10.0.1.jar:10.0.1] at org.apache.skywalking.oap.server.starter.OAPServerStartUp.main(OAPServerStartUp.java:23) [server-starter-10.0.1.jar:10.0.1] Caused by: io.grpc.StatusRuntimeException: UNIMPLEMENTED: unknown service banyandb.database.v1.GroupRegistryService at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:268) ~[grpc-stub-1.63.0.jar:1.63.0] at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:249) ~[grpc-stub-1.63.0.jar:1.63.0] at io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:167) ~[grpc-stub-1.63.0.jar:1.63.0] at org.apache.skywalking.banyandb.database.v1.GroupRegistryServiceGrpc$GroupRegistryServiceBlockingStub.create(GroupRegistryServiceGrpc.java:396) ~[banyandb-java-client-0.6.0.jar:0.6.0] at org.apache.skywalking.banyandb.v1.client.metadata.GroupMetadataRegistry.lambda$create$0(GroupMetadataRegistry.java:40) ~[banyandb-java-client-0.6.0.jar:0.6.0] at org.apache.skywalking.banyandb.v1.client.grpc.HandleExceptionsWith.callAndTranslateApiException(HandleExceptionsWith.java:45) ~[banyandb-java-client-0.6.0.jar:0.6.0] ... 9 more 2024-07-30 13:28:36,581 org.apache.skywalking.oap.server.starter.OAPServerBootstrap 64 [main] ERROR [] - [10.0.1-6a9d727] fail to define group org.apache.skywalking.oap.server.library.module.ModuleStartException: fail to define group at org.apache.skywalking.oap.server.storage.plugin.banyandb.BanyanDBStorageProvider.start(BanyanDBStorageProvider.java:183) ~[storage-banyandb-plugin-10.0.1.jar:10.0.1] at org.apache.skywalking.oap.server.library.module.BootstrapFlow.start(BootstrapFlow.java:46) ~[library-module-10.0.1.jar:10.0.1] at org.apache.skywalking.oap.server.library.module.ModuleManager.init(ModuleManager.java:75) ~[library-module-10.0.1.jar:10.0.1] at org.apache.skywalking.oap.server.starter.OAPServerBootstrap.start(OAPServerBootstrap.java:52) [server-starter-10.0.1.jar:10.0.1] at org.apache.skywalking.oap.server.starter.OAPServerStartUp.main(OAPServerStartUp.java:23) [server-starter-10.0.1.jar:10.0.1] Caused by: java.io.IOException: fail to define group at org.apache.skywalking.oap.server.storage.plugin.banyandb.BanyanDBStorageClient.defineIfEmpty(BanyanDBStorageClient.java:210) ~[storage-banyandb-plugin-10.0.1.jar:10.0.1] at
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
hyhyf commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1696921595
##
test/plugin/scenarios/spring-jms-5.x-scenario/config/expectedData.yaml:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+segmentItems:
+ - serviceName: spring-jms-5.x-scenario
+segmentSize: ge 2
+segments:
+ - segmentId: not null
+spans:
+ - operationName: ActiveMQ/Queue/test/Producer
+parentSpanId: 0
+spanId: 1
+spanLayer: MQ
+startTime: nq 0
+endTime: nq 0
+componentId: 45
+isError: false
+spanType: Exit
+peer: not blank
+tags:
+ - { key: mq.broker, value: not blank }
+ - { key: mq.queue, value: test }
+skipAnalysis: 'false'
+ - operationName:
GET:/spring-jms-5.x-scenario/case/spring-jms-scenario
+parentSpanId: -1
+spanId: 0
+spanLayer: Http
+startTime: nq 0
+endTime: nq 0
+componentId: 1
+isError: false
+spanType: Entry
+peer: ''
+tags:
+ - { key: url, value:
'http://localhost:8080/spring-jms-5.x-scenario/case/spring-jms-scenario' }
+ - { key: http.method, value: GET }
+ - { key: http.status_code, value: '200' }
+skipAnalysis: 'false'
+ - segmentId: not null
+spans:
+ - operationName: ActiveMQ/Queue/test/Consumer
+parentSpanId: -1
+spanId: 0
+spanLayer: MQ
+startTime: nq 0
+endTime: nq 0
+componentId: 46
+isError: false
+spanType: Entry
+peer: not blank
+tags:
+ - { key: mq.broker, value: not blank }
+ - { key: mq.queue, value: test }
+ - { key: transmission.latency, value: ge 0 }
+refs:
+ - { parentEndpoint:
GET:/spring-jms-5.x-scenario/case/spring-jms-scenario, networkAddress: not null,
+ refType: CrossProcess, parentSpanId: 1,
parentTraceSegmentId: not null,
+ parentServiceInstance: not null, parentService: not null,
traceId: not null }
+skipAnalysis: 'false'
+ - segmentId: not null
+spans:
+ - operationName: Jms/queue://test/Execute
Review Comment:
That's not what I mean, but it's OK. At least we can trace what consumers
have done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Sync UI [skywalking]
wu-sheng merged PR #12489: URL: https://github.com/apache/skywalking/pull/12489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1696913705
##
test/plugin/scenarios/spring-jms-5.x-scenario/config/expectedData.yaml:
##
@@ -71,20 +71,15 @@ segmentItems:
skipAnalysis: 'false'
- segmentId: not null
spans:
- - operationName: Jms/queue://test/Execute
+ - operationName: JMS/queue://test/execute
parentSpanId: -1
spanId: 0
spanLayer: Unknown
startTime: nq 0
endTime: nq 0
componentId: 65
isError: false
-spanType: Entry
+spanType: Local
peer: ''
tags:
- { key: transmission.latency, value: ge 0 }
Review Comment:
Local span should not have this? right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Sync UI [skywalking]
Fine0830 opened a new pull request, #12489: URL: https://github.com/apache/skywalking/pull/12489 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). * Make a maximum 20 entities per query in service/instance/endpoint list widgets. * Polish error nodes in trace widget. Signed-off-by: Qiuxia Fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: set a maximum 20 entities per query in service/instance/endpoint list widgets [skywalking-booster-ui]
wu-sheng commented on PR #406: URL: https://github.com/apache/skywalking-booster-ui/pull/406#issuecomment-2258265679 Let's sync this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: set a maximum 20 entities per query in service/instance/endpoint list widgets [skywalking-booster-ui]
wu-sheng merged PR #406: URL: https://github.com/apache/skywalking-booster-ui/pull/406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] feat: set a maximum 20 entities per query in service/instance/endpoint list widgets [skywalking-booster-ui]
Fine0830 opened a new pull request, #406: URL: https://github.com/apache/skywalking-booster-ui/pull/406 Video Set a maximum 5 entities in the following video. https://github.com/user-attachments/assets/da0b7ee3-eeff-4c98-9c16-229207f5a8eb Signed-off-by: Qiuxia Fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix the protocol logs may be missing if the process is short-lived [skywalking-rover]
wu-sheng merged PR #135: URL: https://github.com/apache/skywalking-rover/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1696667248
##
test/plugin/scenarios/spring-jms-5.x-scenario/config/expectedData.yaml:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+segmentItems:
+ - serviceName: spring-jms-5.x-scenario
+segmentSize: ge 2
+segments:
+ - segmentId: not null
+spans:
+ - operationName: ActiveMQ/Queue/test/Producer
+parentSpanId: 0
+spanId: 1
+spanLayer: MQ
+startTime: nq 0
+endTime: nq 0
+componentId: 45
+isError: false
+spanType: Exit
+peer: not blank
+tags:
+ - { key: mq.broker, value: not blank }
+ - { key: mq.queue, value: test }
+skipAnalysis: 'false'
+ - operationName:
GET:/spring-jms-5.x-scenario/case/spring-jms-scenario
+parentSpanId: -1
+spanId: 0
+spanLayer: Http
+startTime: nq 0
+endTime: nq 0
+componentId: 1
+isError: false
+spanType: Entry
+peer: ''
+tags:
+ - { key: url, value:
'http://localhost:8080/spring-jms-5.x-scenario/case/spring-jms-scenario' }
+ - { key: http.method, value: GET }
+ - { key: http.status_code, value: '200' }
+skipAnalysis: 'false'
+ - segmentId: not null
+spans:
+ - operationName: ActiveMQ/Queue/test/Consumer
+parentSpanId: -1
+spanId: 0
+spanLayer: MQ
+startTime: nq 0
+endTime: nq 0
+componentId: 46
+isError: false
+spanType: Entry
+peer: not blank
+tags:
+ - { key: mq.broker, value: not blank }
+ - { key: mq.queue, value: test }
+ - { key: transmission.latency, value: ge 0 }
+refs:
+ - { parentEndpoint:
GET:/spring-jms-5.x-scenario/case/spring-jms-scenario, networkAddress: not null,
+ refType: CrossProcess, parentSpanId: 1,
parentTraceSegmentId: not null,
+ parentServiceInstance: not null, parentService: not null,
traceId: not null }
+skipAnalysis: 'false'
+ - segmentId: not null
+spans:
+ - operationName: Jms/queue://test/Execute
Review Comment:
Do you want jms works without other support? Then what mq is actually
working in that scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Fix the protocol logs may be missing if the process is short-lived [skywalking-rover]
mrproliu opened a new pull request, #135: URL: https://github.com/apache/skywalking-rover/pull/135 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
hyhyf commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1696649521
##
test/plugin/scenarios/spring-jms-5.x-scenario/config/expectedData.yaml:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+segmentItems:
+ - serviceName: spring-jms-5.x-scenario
+segmentSize: ge 2
+segments:
+ - segmentId: not null
+spans:
+ - operationName: ActiveMQ/Queue/test/Producer
+parentSpanId: 0
+spanId: 1
+spanLayer: MQ
+startTime: nq 0
+endTime: nq 0
+componentId: 45
+isError: false
+spanType: Exit
+peer: not blank
+tags:
+ - { key: mq.broker, value: not blank }
+ - { key: mq.queue, value: test }
+skipAnalysis: 'false'
+ - operationName:
GET:/spring-jms-5.x-scenario/case/spring-jms-scenario
+parentSpanId: -1
+spanId: 0
+spanLayer: Http
+startTime: nq 0
+endTime: nq 0
+componentId: 1
+isError: false
+spanType: Entry
+peer: ''
+tags:
+ - { key: url, value:
'http://localhost:8080/spring-jms-5.x-scenario/case/spring-jms-scenario' }
+ - { key: http.method, value: GET }
+ - { key: http.status_code, value: '200' }
+skipAnalysis: 'false'
+ - segmentId: not null
+spans:
+ - operationName: ActiveMQ/Queue/test/Consumer
+parentSpanId: -1
+spanId: 0
+spanLayer: MQ
+startTime: nq 0
+endTime: nq 0
+componentId: 46
+isError: false
+spanType: Entry
+peer: not blank
+tags:
+ - { key: mq.broker, value: not blank }
+ - { key: mq.queue, value: test }
+ - { key: transmission.latency, value: ge 0 }
+refs:
+ - { parentEndpoint:
GET:/spring-jms-5.x-scenario/case/spring-jms-scenario, networkAddress: not null,
+ refType: CrossProcess, parentSpanId: 1,
parentTraceSegmentId: not null,
+ parentServiceInstance: not null, parentService: not null,
traceId: not null }
+skipAnalysis: 'false'
+ - segmentId: not null
+spans:
+ - operationName: Jms/queue://test/Execute
Review Comment:
yes, but it's not perfect. If we want to trace after MQ consumers span, we
need upstream support, such as the ActiveMQ plugin, put the context snapshot
somewhere before ending the enhancement method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] K8S deploys SkyWalking MySQL Connection, but an error is reported in the log [skywalking]
zxz-hash commented on issue #12487: URL: https://github.com/apache/skywalking/issues/12487#issuecomment-2257695844 I'll try the new version first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] K8S deploys SkyWalking MySQL Connection, but an error is reported in the log [skywalking]
wu-sheng commented on issue #12487: URL: https://github.com/apache/skywalking/issues/12487#issuecomment-2257692685 You even didn't try new versions. But keep asking things from years ago. Can't see the point of this conversation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] K8S deploys SkyWalking MySQL Connection, but an error is reported in the log [skywalking]
wu-sheng commented on issue #12487: URL: https://github.com/apache/skywalking/issues/12487#issuecomment-2257690245 Again. I don't whether this is fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] K8S deploys SkyWalking MySQL Connection, but an error is reported in the log [skywalking]
zxz-hash commented on issue #12487: URL: https://github.com/apache/skywalking/issues/12487#issuecomment-2257648879 > 您可以使用您喜欢的任何存储。但是由于ID冲突，事情就很复杂了。我们在以前的版本中修复了一些问题，但无法判断是否所有问题都很好。 Does this error have any effect on the data or how can I fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] K8S deploys SkyWalking MySQL Connection, but an error is reported in the log [skywalking]
wu-sheng commented on issue #12487: URL: https://github.com/apache/skywalking/issues/12487#issuecomment-2257634265 You could use any storage you prefer. But as ID conflicts thing is complex. We fixed some in the previous versions, but can't tell whether all are good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] K8S deploys SkyWalking MySQL Connection, but an error is reported in the log [skywalking]
zxz-hash commented on issue #12487: URL: https://github.com/apache/skywalking/issues/12487#issuecomment-2257628607 > 不知道。Mysql作为存储并不受欢迎，建议用于大规模。它只是主要从官方的角度来看工作。 For the time being, I don't consider using ES because I don't have too much effort to maintain ES, so I use AWS MySQL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] K8S deploys SkyWalking MySQL Connection, but an error is reported in the log [skywalking]
wu-sheng commented on issue #12487: URL: https://github.com/apache/skywalking/issues/12487#issuecomment-2257624600 We don't. Mysql as storage is not popular and recommended for large scale. It just works mostly from official perspective. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] K8S deploys SkyWalking MySQL Connection, but an error is reported in the log [skywalking]
zxz-hash commented on issue #12487: URL: https://github.com/apache/skywalking/issues/12487#issuecomment-2257622779 > 8.5 是一年前。选择最新的。 hi Does the latest version fix this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] K8S deploys SkyWalking MySQL Connection, but an error is reported in the log [skywalking]
zxz-hash commented on issue #12487: URL: https://github.com/apache/skywalking/issues/12487#issuecomment-2257620250 I'm using the dockerfile as an image, copying the mysql driver JDBC to oap-libs/ and defining the variables that connect to mysql in k8s env -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] K8S deploys SkyWalking MySQL Connection, but an error is reported in the log [skywalking]
wu-sheng commented on issue #12487: URL: https://github.com/apache/skywalking/issues/12487#issuecomment-2257618927 8.5 is a year ago. Pick latest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] K8S deploys SkyWalking MySQL Connection, but an error is reported in the log [skywalking]
wu-sheng closed issue #12487: K8S deploys SkyWalking MySQL Connection, but an error is reported in the log URL: https://github.com/apache/skywalking/issues/12487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] K8S deploys SkyWalking MySQL Connection, but an error is reported in the log [skywalking]
zxz-hash opened a new issue, #12487: URL: https://github.com/apache/skywalking/issues/12487 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description K8S deploys SkyWalking MySQL Connection ### Use case but an error is reported in the log ### Related issues 2024-07-30 06:15:02,757 - org.apache.skywalking.oap.server.storage.plugin.jdbc.h2.dao.H2BatchDAO -100722817 [pool-4-thread-1] ERROR [] - Duplicate entry '202407300615' for key 'PRIMARY' com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Duplicate entry '202407300615' for key 'PRIMARY' at jdk.internal.reflect.GeneratedConstructorAccessor48.newInstance(Unknown Source) ~[?:?] at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?] at java.lang.reflect.Constructor.newInstance(Constructor.java:490) ~[?:?] at com.mysql.jdbc.Util.handleNewInstance(Util.java:403) ~[mysql-connector-java-5.1.49.jar:5.1.49] at com.mysql.jdbc.Util.getInstance(Util.java:386) ~[mysql-connector-java-5.1.49.jar:5.1.49] at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:936) ~[mysql-connector-java-5.1.49.jar:5.1.49] at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3933) ~[mysql-connector-java-5.1.49.jar:5.1.49] at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3869) ~[mysql-connector-java-5.1.49.jar:5.1.49] at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2524) ~[mysql-connector-java-5.1.49.jar:5.1.49] at com.mysql.jdbc.ServerPreparedStatement.serverExecute(ServerPreparedStatement.java:1281) ~[mysql-connector-java-5.1.49.jar:5.1.49] at com.mysql.jdbc.ServerPreparedStatement.executeInternal(ServerPreparedStatement.java:787) ~[mysql-connector-java-5.1.49.jar:5.1.49] at com.mysql.jdbc.PreparedStatement.execute(PreparedStatement.java:1254) ~[mysql-connector-java-5.1.49.jar:5.1.49] at com.zaxxer.hikari.pool.ProxyPreparedStatement.execute(ProxyPreparedStatement.java:44) ~[HikariCP-3.1.0.jar:?] at com.zaxxer.hikari.pool.HikariProxyPreparedStatement.execute(HikariProxyPreparedStatement.java) ~[HikariCP-3.1.0.jar:?] at org.apache.skywalking.oap.server.storage.plugin.jdbc.SQLExecutor.invoke(SQLExecutor.java:53) ~[storage-jdbc-hikaricp-plugin-8.5.0.jar:8.5.0] at org.apache.skywalking.oap.server.storage.plugin.jdbc.h2.dao.H2BatchDAO.synchronous(H2BatchDAO.java:72) [storage-jdbc-hikaricp-plugin-8.5.0.jar:8.5.0] at org.apache.skywalking.oap.server.core.storage.PersistenceTimer.lambda$extractDataAndSave$3(PersistenceTimer.java:135) [server-core-8.5.0.jar:8.5.0] ### Are you willing to submit a pull request to implement this on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix cannot translate peer address in some UDP scenarios [skywalking-rover]
mrproliu merged PR #134: URL: https://github.com/apache/skywalking-rover/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix cannot translate peer address in some UDP scenarios [skywalking-rover]
mrproliu opened a new pull request, #134: URL: https://github.com/apache/skywalking-rover/pull/134 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix highlight keywords in logs [skywalking-booster-ui]
Fine0830 merged PR #405: URL: https://github.com/apache/skywalking-booster-ui/pull/405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix highlight keywords in logs [skywalking-booster-ui]
Fine0830 opened a new pull request, #405: URL: https://github.com/apache/skywalking-booster-ui/pull/405 Fixes an error on displaying highlight words in logs. Screenshot https://github.com/user-attachments/assets/3384f753-8588-411b-85b8-ada277dd27af;> Signed-off-by: Qiuxia Fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1696118405
##
test/plugin/scenarios/spring-jms-5.x-scenario/config/expectedData.yaml:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+segmentItems:
+ - serviceName: spring-jms-5.x-scenario
+segmentSize: ge 2
+segments:
+ - segmentId: not null
+spans:
+ - operationName: ActiveMQ/Queue/test/Producer
+parentSpanId: 0
+spanId: 1
+spanLayer: MQ
+startTime: nq 0
+endTime: nq 0
+componentId: 45
+isError: false
+spanType: Exit
+peer: not blank
+tags:
+ - { key: mq.broker, value: not blank }
+ - { key: mq.queue, value: test }
+skipAnalysis: 'false'
+ - operationName:
GET:/spring-jms-5.x-scenario/case/spring-jms-scenario
+parentSpanId: -1
+spanId: 0
+spanLayer: Http
+startTime: nq 0
+endTime: nq 0
+componentId: 1
+isError: false
+spanType: Entry
+peer: ''
+tags:
+ - { key: url, value:
'http://localhost:8080/spring-jms-5.x-scenario/case/spring-jms-scenario' }
+ - { key: http.method, value: GET }
+ - { key: http.status_code, value: '200' }
+skipAnalysis: 'false'
+ - segmentId: not null
+spans:
+ - operationName: ActiveMQ/Queue/test/Consumer
+parentSpanId: -1
+spanId: 0
+spanLayer: MQ
+startTime: nq 0
+endTime: nq 0
+componentId: 46
+isError: false
+spanType: Entry
+peer: not blank
+tags:
+ - { key: mq.broker, value: not blank }
+ - { key: mq.queue, value: test }
+ - { key: transmission.latency, value: ge 0 }
+refs:
+ - { parentEndpoint:
GET:/spring-jms-5.x-scenario/case/spring-jms-scenario, networkAddress: not null,
+ refType: CrossProcess, parentSpanId: 1,
parentTraceSegmentId: not null,
+ parentServiceInstance: not null, parentService: not null,
traceId: not null }
+skipAnalysis: 'false'
+ - segmentId: not null
+spans:
+ - operationName: Jms/queue://test/Execute
Review Comment:
Is there any update? Is this practical?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] BanyanDB: stream sort-by `time` query, use internal time-series rather than `index` to improve the query performance. [skywalking]
wu-sheng merged PR #12486: URL: https://github.com/apache/skywalking/pull/12486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature] BanyanDB Stream Query Sort By Time [skywalking]
wu-sheng closed issue #12472: [Feature] BanyanDB Stream Query Sort By Time URL: https://github.com/apache/skywalking/issues/12472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix Distributed Query Bug [skywalking-banyandb]
wu-sheng merged PR #501: URL: https://github.com/apache/skywalking-banyandb/pull/501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix Distributed Query Bug [skywalking-banyandb]
hanahmily opened a new pull request, #501: URL: https://github.com/apache/skywalking-banyandb/pull/501 - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] BanyanDB: stream sort-by `time` query, use internal time-series rather than `index` to improve the query performance. [skywalking]
wankai123 opened a new pull request, #12486: URL: https://github.com/apache/skywalking/pull/12486 And: if the model column is already a `@BanyanDB.TimestampColumn`, set `@BanyanDB.NoIndexing` on it to reduce indexes. - [X] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #12472. - [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add an http endpoint wrapper for health check [skywalking]
kezhenxu94 merged PR #12485: URL: https://github.com/apache/skywalking/pull/12485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add an http endpoint wrapper for health check [skywalking]
wu-sheng commented on code in PR #12485: URL: https://github.com/apache/skywalking/pull/12485#discussion_r1694632449 ## docs/menu.yml: ## @@ -322,6 +322,8 @@ catalog: path: "/en/api/promql-service" - name: "LogQL APIs" path: "/en/api/logql-service" + - name: "Health Check API" +path: "/env/api/health-check" Review Comment: ```suggestion path: "/en/api/health-check" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add an http endpoint wrapper for health check [skywalking]
kezhenxu94 commented on code in PR #12485: URL: https://github.com/apache/skywalking/pull/12485#discussion_r1694614056 ## docs/menu.yml: ## @@ -322,6 +322,8 @@ catalog: path: "/en/api/promql-service" - name: "LogQL APIs" path: "/en/api/logql-service" + - name: "Health Check API" +path: "/env/api/health-check" Review Comment: > One more, your new API doc doesn't have a menu item, no one could find that doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add an http endpoint wrapper for health check [skywalking]
wu-sheng commented on code in PR #12485: URL: https://github.com/apache/skywalking/pull/12485#discussion_r1694603504 ## docs/en/setup/backend/backend-health-check.md: ## @@ -56,6 +56,12 @@ If some modules are unhealthy (e.g. storage H2 is down), then the result may loo Refer to [checkHealth query](https://github.com/apache/skywalking-query-protocol/blob/master/common.graphqls) for more details. +In some cases, GraphQL query may not be a good choice to check the health status of OAP, for example, in Kubernetes Review Comment: As we are running on k8s in most cases, we could move this as the first part of health check doc, rather than `in some cases` only. Should we link to your new API doc from here? ~~One more, your new API doc doesn't have a menu item, no one could find that doc.~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add an http endpoint wrapper for health check [skywalking]
wu-sheng commented on code in PR #12485: URL: https://github.com/apache/skywalking/pull/12485#discussion_r1694603504 ## docs/en/setup/backend/backend-health-check.md: ## @@ -56,6 +56,12 @@ If some modules are unhealthy (e.g. storage H2 is down), then the result may loo Refer to [checkHealth query](https://github.com/apache/skywalking-query-protocol/blob/master/common.graphqls) for more details. +In some cases, GraphQL query may not be a good choice to check the health status of OAP, for example, in Kubernetes Review Comment: As we are running on k8s in most cases, we could move this as the first part of health check doc, rather than `in some cases` only. Should we link to your new API doc from here? One more, your new API doc doesn't have a menu item, no one could find that doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add an http endpoint wrapper for health check [skywalking]
kezhenxu94 commented on code in PR #12485: URL: https://github.com/apache/skywalking/pull/12485#discussion_r1694604303 ## docs/en/api/health-check.md: ## @@ -0,0 +1,9 @@ +# Check OAP healthiness Review Comment: I added to the API catalog, as this is not about setup, it's API doc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add an http endpoint wrapper for health check [skywalking]
wu-sheng commented on code in PR #12485: URL: https://github.com/apache/skywalking/pull/12485#discussion_r169451 ## .licenserc.yaml: ## @@ -106,10 +106,10 @@ dependency: version: 2.13.4 license: Apache-2.0 - name: com.fasterxml.jackson.datatype:jackson-datatype-jsr310 - version: 2.16.1 + version: 2.17.1 Review Comment: changes should include this version upgrade as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add an http endpoint wrapper for health check [skywalking]
wu-sheng commented on code in PR #12485: URL: https://github.com/apache/skywalking/pull/12485#discussion_r1694599419 ## docs/en/api/health-check.md: ## @@ -0,0 +1,9 @@ +# Check OAP healthiness Review Comment: I think this should be added here? https://skywalking.apache.org/docs/main/next/en/setup/backend/backend-health-check/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add an http endpoint wrapper for health check [skywalking]
kezhenxu94 opened a new pull request, #12485: URL: https://github.com/apache/skywalking/pull/12485 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Switch the skywalking storage engine to mysql, and consistently report com.mysql.cj.jdbc.exceptions.MysqlDataTruncation error [skywalking]
zxz-hash commented on issue #6021: URL: https://github.com/apache/skywalking/issues/6021#issuecomment-2254786969 我也遇到这个问题 请问解决了吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve round robin selector [skywalking-banyandb]
wu-sheng merged PR #500: URL: https://github.com/apache/skywalking-banyandb/pull/500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] RoundRobinSelector Get Groups From etcd [skywalking]
wu-sheng closed issue #12470: [Bug] RoundRobinSelector Get Groups From etcd URL: https://github.com/apache/skywalking/issues/12470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Java agent 9.3 release [skywalking-website]
wu-sheng merged PR #732: URL: https://github.com/apache/skywalking-website/pull/732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Replace workaround with Armeria's natively-supported context path [skywalking]
wu-sheng merged PR #12484: URL: https://github.com/apache/skywalking/pull/12484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Replace workaround with Armeria's natively-supported context path [skywalking]
wu-sheng commented on PR #12484: URL: https://github.com/apache/skywalking/pull/12484#issuecomment-2254516197 Is `CI / E2E test (Auth, test/e2e-v2/cases/simple/auth/e2e.yaml)` case failing relative? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Replace workaround with Armeria's natively-supported context path [skywalking]
kezhenxu94 opened a new pull request, #12484: URL: https://github.com/apache/skywalking/pull/12484 - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. NO - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve round robin selector [skywalking-banyandb]
wu-sheng commented on code in PR #500: URL: https://github.com/apache/skywalking-banyandb/pull/500#discussion_r1694238312 ## docs/concept/clustering.md: ## @@ -97,11 +97,11 @@ Futhermore, the storage system might be cheaper. For instance, S3 can be more co ### 5.2 Data Sharding -Data distribution across the cluster is determined based on the `shard_num` setting for a group and the specified `entity` in each resource, be it a stream or measure. The resource’s `name` with its `entity` is the sharding key, guiding data distribution to the appropriate Data Node during write operations. +Data distribution across the cluster is determined by the `shard_num` setting for a group and the specified `entity` in each resource, whether it is a stream or a measure. The combination of the resource’s `name` and its `entity` forms the sharding key, which guides data distribution to the appropriate Data Node during write operations. -Liaison Nodes retrieve shard mapping information from Meta Nodes to achieve efficient data routing. This information is used to route data to the appropriate Data Nodes based on the sharding key of the data. +Liaison Nodes play a crucial role in this process by retrieving the `Group` list from Meta Nodes. This information is essential for efficient data routing, as it allows Liaison Nodes to direct data to the appropriate Data Nodes based on the sharding key. -This sharding strategy ensures the write load is evenly distributed across the cluster, enhancing write performance and overall system efficiency. BanyanDB uses a hash algorithm for sharding. The hash function maps the sharding key (resource name and entity) to a node in the cluster. Each shard is assigned to the node returned by the hash function. +This sharding strategy ensures that the write load is evenly distributed across the cluster, thereby enhancing write performance and overall system efficiency. BanyanDB sorts the shards by the `Group` name and the shard ID, then assigns the shards to the Data Nodes in a round-robin fashion. This method guarantees an even distribution of data across the cluster, preventing any single node from becoming a bottleneck. Review Comment: We should add an example for measures and streams about how the data layouts into the data node. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
hyhyf commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694225573
##
test/plugin/scenarios/spring-jms-5.x-scenario/config/expectedData.yaml:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+segmentItems:
+ - serviceName: spring-jms-5.x-scenario
+segmentSize: ge 2
+segments:
+ - segmentId: not null
+spans:
+ - operationName: ActiveMQ/Queue/test/Producer
+parentSpanId: 0
+spanId: 1
+spanLayer: MQ
+startTime: nq 0
+endTime: nq 0
+componentId: 45
+isError: false
+spanType: Exit
+peer: not blank
+tags:
+ - { key: mq.broker, value: not blank }
+ - { key: mq.queue, value: test }
+skipAnalysis: 'false'
+ - operationName:
GET:/spring-jms-5.x-scenario/case/spring-jms-scenario
+parentSpanId: -1
+spanId: 0
+spanLayer: Http
+startTime: nq 0
+endTime: nq 0
+componentId: 1
+isError: false
+spanType: Entry
+peer: ''
+tags:
+ - { key: url, value:
'http://localhost:8080/spring-jms-5.x-scenario/case/spring-jms-scenario' }
+ - { key: http.method, value: GET }
+ - { key: http.status_code, value: '200' }
+skipAnalysis: 'false'
+ - segmentId: not null
+spans:
+ - operationName: ActiveMQ/Queue/test/Consumer
+parentSpanId: -1
+spanId: 0
+spanLayer: MQ
+startTime: nq 0
+endTime: nq 0
+componentId: 46
+isError: false
+spanType: Entry
+peer: not blank
+tags:
+ - { key: mq.broker, value: not blank }
+ - { key: mq.queue, value: test }
+ - { key: transmission.latency, value: ge 0 }
+refs:
+ - { parentEndpoint:
GET:/spring-jms-5.x-scenario/case/spring-jms-scenario, networkAddress: not null,
+ refType: CrossProcess, parentSpanId: 1,
parentTraceSegmentId: not null,
+ parentServiceInstance: not null, parentService: not null,
traceId: not null }
+skipAnalysis: 'false'
+ - segmentId: not null
+spans:
+ - operationName: Jms/queue://test/Execute
Review Comment:
OK, i will try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694221556
##
test/plugin/scenarios/spring-jms-5.x-scenario/config/expectedData.yaml:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+segmentItems:
+ - serviceName: spring-jms-5.x-scenario
+segmentSize: ge 2
+segments:
+ - segmentId: not null
+spans:
+ - operationName: ActiveMQ/Queue/test/Producer
+parentSpanId: 0
+spanId: 1
+spanLayer: MQ
+startTime: nq 0
+endTime: nq 0
+componentId: 45
+isError: false
+spanType: Exit
+peer: not blank
+tags:
+ - { key: mq.broker, value: not blank }
+ - { key: mq.queue, value: test }
+skipAnalysis: 'false'
+ - operationName:
GET:/spring-jms-5.x-scenario/case/spring-jms-scenario
+parentSpanId: -1
+spanId: 0
+spanLayer: Http
+startTime: nq 0
+endTime: nq 0
+componentId: 1
+isError: false
+spanType: Entry
+peer: ''
+tags:
+ - { key: url, value:
'http://localhost:8080/spring-jms-5.x-scenario/case/spring-jms-scenario' }
+ - { key: http.method, value: GET }
+ - { key: http.status_code, value: '200' }
+skipAnalysis: 'false'
+ - segmentId: not null
+spans:
+ - operationName: ActiveMQ/Queue/test/Consumer
+parentSpanId: -1
+spanId: 0
+spanLayer: MQ
+startTime: nq 0
+endTime: nq 0
+componentId: 46
+isError: false
+spanType: Entry
+peer: not blank
+tags:
+ - { key: mq.broker, value: not blank }
+ - { key: mq.queue, value: test }
+ - { key: transmission.latency, value: ge 0 }
+refs:
+ - { parentEndpoint:
GET:/spring-jms-5.x-scenario/case/spring-jms-scenario, networkAddress: not null,
+ refType: CrossProcess, parentSpanId: 1,
parentTraceSegmentId: not null,
+ parentServiceInstance: not null, parentService: not null,
traceId: not null }
+skipAnalysis: 'false'
+ - segmentId: not null
+spans:
+ - operationName: Jms/queue://test/Execute
Review Comment:
Is that always MQ client dealing with the process? We should consider JMS as
a local span if MQ client is the one fetching the message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694218031
##
test/plugin/scenarios/spring-jms-5.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/spring/jms/controller/CaseController.java:
##
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.testcase.spring.jms.controller;
+
+import lombok.extern.log4j.Log4j2;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.jms.annotation.JmsListener;
+import org.springframework.jms.core.JmsMessagingTemplate;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.ResponseBody;
+import org.springframework.web.bind.annotation.RestController;
+
+import javax.jms.Message;
+import javax.jms.TextMessage;
+
+@RestController
+@RequestMapping("/case")
+@Log4j2
+public class CaseController {
+
+private static final String SUCCESS = "Success";
+
+@Autowired
+private JmsMessagingTemplate jmsMessagingTemplate;
+
+@RequestMapping("/spring-jms-scenario")
+@ResponseBody
+public String testcase() {
+jmsMessagingTemplate.convertAndSend("test", "hello world");
+return SUCCESS;
+}
+
+@RequestMapping("/healthCheck")
+@ResponseBody
+public String healthCheck() {
+return SUCCESS;
+}
+
+@JmsListener(destination = "test", concurrency = "10")
+public void onMessageReceived(Message message) throws Exception {
+TextMessage textMessage = (TextMessage) message;
+log.info("received normal message: " + textMessage.getText());
+}
Review Comment:
One message should map to one entry span at the consumer part.
Can you guarantee that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
hyhyf commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694215993
##
test/plugin/scenarios/spring-jms-5.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/spring/jms/controller/CaseController.java:
##
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.testcase.spring.jms.controller;
+
+import lombok.extern.log4j.Log4j2;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.jms.annotation.JmsListener;
+import org.springframework.jms.core.JmsMessagingTemplate;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.ResponseBody;
+import org.springframework.web.bind.annotation.RestController;
+
+import javax.jms.Message;
+import javax.jms.TextMessage;
+
+@RestController
+@RequestMapping("/case")
+@Log4j2
+public class CaseController {
+
+private static final String SUCCESS = "Success";
+
+@Autowired
+private JmsMessagingTemplate jmsMessagingTemplate;
+
+@RequestMapping("/spring-jms-scenario")
+@ResponseBody
+public String testcase() {
+jmsMessagingTemplate.convertAndSend("test", "hello world");
+return SUCCESS;
+}
+
+@RequestMapping("/healthCheck")
+@ResponseBody
+public String healthCheck() {
+return SUCCESS;
+}
+
+@JmsListener(destination = "test", concurrency = "10")
+public void onMessageReceived(Message message) throws Exception {
+TextMessage textMessage = (TextMessage) message;
+log.info("received normal message: " + textMessage.getText());
+}
Review Comment:
i used apm-activemq-5.x-plugin in test scenario, i don't know how the
consumer traffic count it, i set JMS entry span component=spring.async.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
hyhyf commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694215993
##
test/plugin/scenarios/spring-jms-5.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/spring/jms/controller/CaseController.java:
##
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.testcase.spring.jms.controller;
+
+import lombok.extern.log4j.Log4j2;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.jms.annotation.JmsListener;
+import org.springframework.jms.core.JmsMessagingTemplate;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.ResponseBody;
+import org.springframework.web.bind.annotation.RestController;
+
+import javax.jms.Message;
+import javax.jms.TextMessage;
+
+@RestController
+@RequestMapping("/case")
+@Log4j2
+public class CaseController {
+
+private static final String SUCCESS = "Success";
+
+@Autowired
+private JmsMessagingTemplate jmsMessagingTemplate;
+
+@RequestMapping("/spring-jms-scenario")
+@ResponseBody
+public String testcase() {
+jmsMessagingTemplate.convertAndSend("test", "hello world");
+return SUCCESS;
+}
+
+@RequestMapping("/healthCheck")
+@ResponseBody
+public String healthCheck() {
+return SUCCESS;
+}
+
+@JmsListener(destination = "test", concurrency = "10")
+public void onMessageReceived(Message message) throws Exception {
+TextMessage textMessage = (TextMessage) message;
+log.info("received normal message: " + textMessage.getText());
+}
Review Comment:
i used apm-activemq-5.x-plugin in test scenario, i don't know how the
consumer traffic count it, i set JMS entry span component is spring.async
##
test/plugin/scenarios/spring-jms-5.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/spring/jms/controller/CaseController.java:
##
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.testcase.spring.jms.controller;
+
+import lombok.extern.log4j.Log4j2;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.jms.annotation.JmsListener;
+import org.springframework.jms.core.JmsMessagingTemplate;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.ResponseBody;
+import org.springframework.web.bind.annotation.RestController;
+
+import javax.jms.Message;
+import javax.jms.TextMessage;
+
+@RestController
+@RequestMapping("/case")
+@Log4j2
+public class CaseController {
+
+private static final String SUCCESS = "Success";
+
+@Autowired
+private JmsMessagingTemplate jmsMessagingTemplate;
+
+@RequestMapping("/spring-jms-scenario")
+@ResponseBody
+public String testcase() {
+jmsMessagingTemplate.convertAndSend("test", "hello world");
+return SUCCESS;
+}
+
+@RequestMapping("/healthCheck")
+@ResponseBody
+public String healthCheck() {
+return SUCCESS;
+}
+
+@JmsListener(destination = "test", concurrency = "10")
+public void onMessageReceived(Message message) throws Exception {
+TextMessage textMessage = (TextMessage) message;
+log.info("received normal message: " + textMessage.getText());
+}
Review Comment:
i
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
hyhyf commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694215993
##
test/plugin/scenarios/spring-jms-5.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/spring/jms/controller/CaseController.java:
##
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.testcase.spring.jms.controller;
+
+import lombok.extern.log4j.Log4j2;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.jms.annotation.JmsListener;
+import org.springframework.jms.core.JmsMessagingTemplate;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.ResponseBody;
+import org.springframework.web.bind.annotation.RestController;
+
+import javax.jms.Message;
+import javax.jms.TextMessage;
+
+@RestController
+@RequestMapping("/case")
+@Log4j2
+public class CaseController {
+
+private static final String SUCCESS = "Success";
+
+@Autowired
+private JmsMessagingTemplate jmsMessagingTemplate;
+
+@RequestMapping("/spring-jms-scenario")
+@ResponseBody
+public String testcase() {
+jmsMessagingTemplate.convertAndSend("test", "hello world");
+return SUCCESS;
+}
+
+@RequestMapping("/healthCheck")
+@ResponseBody
+public String healthCheck() {
+return SUCCESS;
+}
+
+@JmsListener(destination = "test", concurrency = "10")
+public void onMessageReceived(Message message) throws Exception {
+TextMessage textMessage = (TextMessage) message;
+log.info("received normal message: " + textMessage.getText());
+}
Review Comment:
i used apm-activemq-5.x-plugin in test scenario, i don't know how consumer
count it, i set JMS entry span component is spring.async
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
hyhyf commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694215765
##
test/plugin/scenarios/spring-jms-5.x-scenario/config/expectedData.yaml:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+segmentItems:
+ - serviceName: spring-jms-5.x-scenario
+segmentSize: ge 2
+segments:
+ - segmentId: not null
+spans:
+ - operationName: ActiveMQ/Queue/test/Producer
+parentSpanId: 0
+spanId: 1
+spanLayer: MQ
+startTime: nq 0
+endTime: nq 0
+componentId: 45
+isError: false
+spanType: Exit
+peer: not blank
+tags:
+ - { key: mq.broker, value: not blank }
+ - { key: mq.queue, value: test }
+skipAnalysis: 'false'
+ - operationName:
GET:/spring-jms-5.x-scenario/case/spring-jms-scenario
+parentSpanId: -1
+spanId: 0
+spanLayer: Http
+startTime: nq 0
+endTime: nq 0
+componentId: 1
+isError: false
+spanType: Entry
+peer: ''
+tags:
+ - { key: url, value:
'http://localhost:8080/spring-jms-5.x-scenario/case/spring-jms-scenario' }
+ - { key: http.method, value: GET }
+ - { key: http.status_code, value: '200' }
+skipAnalysis: 'false'
+ - segmentId: not null
+spans:
+ - operationName: ActiveMQ/Queue/test/Consumer
+parentSpanId: -1
+spanId: 0
+spanLayer: MQ
+startTime: nq 0
+endTime: nq 0
+componentId: 46
+isError: false
+spanType: Entry
+peer: not blank
+tags:
+ - { key: mq.broker, value: not blank }
+ - { key: mq.queue, value: test }
+ - { key: transmission.latency, value: ge 0 }
+refs:
+ - { parentEndpoint:
GET:/spring-jms-5.x-scenario/case/spring-jms-scenario, networkAddress: not null,
+ refType: CrossProcess, parentSpanId: 1,
parentTraceSegmentId: not null,
+ parentServiceInstance: not null, parentService: not null,
traceId: not null }
+skipAnalysis: 'false'
+ - segmentId: not null
+spans:
+ - operationName: Jms/queue://test/Execute
Review Comment:
They are parallel, and ativeMQ does not trace the subsequent actions of
consumer, because JMS use other thread pool to execute listener task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694211373
##
test/plugin/scenarios/spring-jms-5.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/spring/jms/controller/CaseController.java:
##
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.testcase.spring.jms.controller;
+
+import lombok.extern.log4j.Log4j2;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.jms.annotation.JmsListener;
+import org.springframework.jms.core.JmsMessagingTemplate;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.ResponseBody;
+import org.springframework.web.bind.annotation.RestController;
+
+import javax.jms.Message;
+import javax.jms.TextMessage;
+
+@RestController
+@RequestMapping("/case")
+@Log4j2
+public class CaseController {
+
+private static final String SUCCESS = "Success";
+
+@Autowired
+private JmsMessagingTemplate jmsMessagingTemplate;
+
+@RequestMapping("/spring-jms-scenario")
+@ResponseBody
+public String testcase() {
+jmsMessagingTemplate.convertAndSend("test", "hello world");
+return SUCCESS;
+}
+
+@RequestMapping("/healthCheck")
+@ResponseBody
+public String healthCheck() {
+return SUCCESS;
+}
+
+@JmsListener(destination = "test", concurrency = "10")
+public void onMessageReceived(Message message) throws Exception {
+TextMessage textMessage = (TextMessage) message;
+log.info("received normal message: " + textMessage.getText());
+}
Review Comment:
This looks like one consuming through JMS. Why I can see active MQ consuming
as well? If we built two entry spans, the consumer traffic will be counted
twice. The RPS at consumer side would be doubled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694211083
##
test/plugin/scenarios/spring-jms-5.x-scenario/config/expectedData.yaml:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+segmentItems:
+ - serviceName: spring-jms-5.x-scenario
+segmentSize: ge 2
+segments:
+ - segmentId: not null
+spans:
+ - operationName: ActiveMQ/Queue/test/Producer
+parentSpanId: 0
+spanId: 1
+spanLayer: MQ
+startTime: nq 0
+endTime: nq 0
+componentId: 45
+isError: false
+spanType: Exit
+peer: not blank
+tags:
+ - { key: mq.broker, value: not blank }
+ - { key: mq.queue, value: test }
+skipAnalysis: 'false'
+ - operationName:
GET:/spring-jms-5.x-scenario/case/spring-jms-scenario
+parentSpanId: -1
+spanId: 0
+spanLayer: Http
+startTime: nq 0
+endTime: nq 0
+componentId: 1
+isError: false
+spanType: Entry
+peer: ''
+tags:
+ - { key: url, value:
'http://localhost:8080/spring-jms-5.x-scenario/case/spring-jms-scenario' }
+ - { key: http.method, value: GET }
+ - { key: http.status_code, value: '200' }
+skipAnalysis: 'false'
+ - segmentId: not null
+spans:
+ - operationName: ActiveMQ/Queue/test/Consumer
+parentSpanId: -1
+spanId: 0
+spanLayer: MQ
+startTime: nq 0
+endTime: nq 0
+componentId: 46
+isError: false
+spanType: Entry
+peer: not blank
+tags:
+ - { key: mq.broker, value: not blank }
+ - { key: mq.queue, value: test }
+ - { key: transmission.latency, value: ge 0 }
+refs:
+ - { parentEndpoint:
GET:/spring-jms-5.x-scenario/case/spring-jms-scenario, networkAddress: not null,
+ refType: CrossProcess, parentSpanId: 1,
parentTraceSegmentId: not null,
+ parentServiceInstance: not null, parentService: not null,
traceId: not null }
+skipAnalysis: 'false'
+ - segmentId: not null
+spans:
+ - operationName: Jms/queue://test/Execute
Review Comment:
```suggestion
- operationName: Jms/queue://test/Execute
```
I can see two entry spans, this and `ActiveMQ/Queue/test/Consumer`. Isn't
only one consumer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694210855
##
apm-sniffer/apm-sdk-plugin/spring-plugins/spring-jms-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/jms/MessageListenerInterceptor.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.spring.jms;
+
+import org.apache.skywalking.apm.agent.core.context.CarrierItem;
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+
+import javax.jms.Message;
+import java.lang.reflect.Method;
+
+public class MessageListenerInterceptor implements
InstanceMethodsAroundInterceptor {
+
+private static final String OPERATION_NAME_PREFIX = "Jms/";
+private static final String OPERATION_NAME_SUFFIX = "/Execute";
Review Comment:
```suggestion
private static final String OPERATION_NAME_SUFFIX = "/execute";
```
As this hasn't special meaning, all lower cases are enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694210780
##
apm-sniffer/apm-sdk-plugin/spring-plugins/spring-jms-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/jms/MessageListenerInterceptor.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.spring.jms;
+
+import org.apache.skywalking.apm.agent.core.context.CarrierItem;
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+
+import javax.jms.Message;
+import java.lang.reflect.Method;
+
+public class MessageListenerInterceptor implements
InstanceMethodsAroundInterceptor {
+
+private static final String OPERATION_NAME_PREFIX = "Jms/";
Review Comment:
```suggestion
private static final String OPERATION_NAME_PREFIX = "JMS/";
```
Please use upper case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
hyhyf commented on code in PR #706: URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694205125 ## apm-sniffer/apm-agent-core/pom.xml: ## @@ -22,7 +22,7 @@ org.apache.skywalking java-agent-sniffer -9.4.0-SNAPSHOT +9.3.0-SNAPSHOT Review Comment: sorry, i neglected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
wu-sheng commented on code in PR #706: URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694200342 ## apm-sniffer/apm-agent-core/pom.xml: ## @@ -22,7 +22,7 @@ org.apache.skywalking java-agent-sniffer -9.4.0-SNAPSHOT +9.3.0-SNAPSHOT Review Comment: I think you merged the things wrong. We are in 9.4.0 iteration. You reverted when merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support tracking the message listener of spring jms [skywalking-java]
wu-sheng commented on PR #706: URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2254401761 Please resolve the conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve round robin selector [skywalking-banyandb]
codecov-commenter commented on PR #500: URL: https://github.com/apache/skywalking-banyandb/pull/500#issuecomment-2254358823 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/500?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `34.78261%` with `45 lines` in your changes missing coverage. Please review. > Project coverage is 52.54%. Comparing base [(`0145fba`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/0145fba320a1a1eca77cba25dac52301407e28f5?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`d5f4211`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/d5f4211132dbd94c0be09241c241ca835a3e712d?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). | [Files](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/500?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [pkg/node/round\_robin.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/500?src=pr=tree=pkg%2Fnode%2Fround_robin.go_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGtnL25vZGUvcm91bmRfcm9iaW4uZ28=) | 39.34% | [35 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/500?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [pkg/node/interface.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/500?src=pr=tree=pkg%2Fnode%2Finterface.go_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGtnL25vZGUvaW50ZXJmYWNlLmdv) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/500?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [pkg/node/maglev.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/500?src=pr=tree=pkg%2Fnode%2Fmaglev.go_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGtnL25vZGUvbWFnbGV2Lmdv) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/500?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #500 +/- ## === + Coverage 41.63% 52.54% +10.90% === Files 156 156 Lines 1865318667 +14 === + Hits 7767 9809 +2042 + Misses 10266 8087 -2179 - Partials 620 771 +151 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/500?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix pulsar client not support init arguments other than service_url [skywalking-python]
kezhenxu94 merged PR #351: URL: https://github.com/apache/skywalking-python/pull/351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix outdated make dev-fix rule in CodeStyle.md [skywalking-python]
kezhenxu94 merged PR #350: URL: https://github.com/apache/skywalking-python/pull/350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix: pulsar client not support init arguments other than service_url [skywalking-python]
tsonglew opened a new pull request, #351: URL: https://github.com/apache/skywalking-python/pull/351 ### Fix pulsar client not support init arguments other than service_ur - [x] Updated the sw_pulsar unit test to verify that the fix works. - [x] Added *args and **kwargs to sw_pular `sw_init`, making it work with arguments other than service_url -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Update CodingStyle.md [skywalking-python]
tsonglew opened a new pull request, #350: URL: https://github.com/apache/skywalking-python/pull/350 Fix outdated make rule in CodeStyle.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Java agent 9.3 release [skywalking-website]
netlify[bot] commented on PR #732: URL: https://github.com/apache/skywalking-website/pull/732#issuecomment-2254121394 ### Deploy Preview for *skywalking-website-preview* processing. | Name | Link | |:-:|| | Latest commit | 633657b0125b4c5ccea820829c4609eea6c3e4c6 | | Latest deploy log | https://app.netlify.com/sites/skywalking-website-preview/deploys/66a4d95fedf8780008c8444c | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add Java agent 9.3 release [skywalking-website]
wu-sheng opened a new pull request, #732: URL: https://github.com/apache/skywalking-website/pull/732 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix redission has not parameter problem [skywalking-java]
wu-sheng commented on PR #712: URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253781807 I think yoi didn't read the document and understand how the things really work. What you faced is a super common case in the agent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix redission has not parameter problem [skywalking-java]
CodingMakeWordBetter commented on PR #712: URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253778215 > You could update config document to indicate this. bytes are not supported. > > I don't think this is a big issue. Encoding unexpected data could impact the target app, that is a serious issue. > You could update config document to indicate this. bytes are not supported. > > I don't think this is a big issue. Encoding unexpected data could impact the target app, that is a serious issue. Okay, I will use the local version to solve this problem. I will try upgrading from 3.15.6 to 3.20.0 and it will directly report an error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
