[GitHub] [skywalking] IanCao commented on pull request #4958: add brpc-java plugin
IanCao commented on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-650491087 116 testcase have passed,one fail but it's no valid error msg @wu-sheng This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] IanCao commented on pull request #4958: add brpc-java plugin
IanCao commented on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647902479 > > Also, I noticed, there is brpc 3.x, do you plan to support it too? > > ok, let me investigate This seems a bit difficult ![image](https://user-images.githubusercontent.com/32847163/85361345-3933e400-b54e-11ea-8be9-b3ee774422fe.png) loadBalance and netty `writeAndFlush` are in a same method This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] IanCao commented on pull request #4958: add brpc-java plugin
IanCao commented on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647887378 > Also, I noticed, there is brpc 3.x, do you plan to support it too? ok, let me investigate This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org