[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `0.75%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.10%   52.35%   -0.76% 
   + Complexity 2972 2943  -29 
   
 Files  1409  774 -635 
 Lines 3059119430   -11161 
 Branches   3404 1916-1488 
   
   - Hits  1624610172-6074 
   + Misses13543 8402-5141 
   - Partials802  856  +54 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=)
 | `0.00% <

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `0.79%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.14%   52.35%   -0.80% 
   + Complexity 2972 2943  -29 
   
 Files   773  774   +1 
 Lines 1941219430  +18 
 Branches   1916 1916  
   
   - Hits  1031610172 -144 
   - Misses 8238 8402 +164 
   + Partials858  856   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==)
 | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=)
 | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
   | 
[.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9yZXN0L1RyYWNlU2VnbWVudFJlcG9ydExpc3RTZXJ2bGV0SGFuZGxlci5qYXZh)
 | `22.22% <0.00%> (-66.67%)` | `2.00% <0.00%> (-3.00%)` | |
   | 
[...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `0.77%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.14%   52.36%   -0.78% 
   + Complexity 2972 2943  -29 
   
 Files   773  773  
 Lines 1941219426  +14 
 Branches   1916 1916  
   
   - Hits  1031610172 -144 
   - Misses 8238 8398 +160 
   + Partials858  856   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==)
 | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=)
 | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
   | 
[.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9yZXN0L1RyYWNlU2VnbWVudFJlcG9ydExpc3RTZXJ2bGV0SGFuZGxlci5qYXZh)
 | `22.22% <0.00%> (-66.67%)` | `2.00% <0.00%> (-3.00%)` | |
   | 
[...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `0.77%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.14%   52.36%   -0.78% 
   + Complexity 2972 2943  -29 
   
 Files   773  773  
 Lines 1941219426  +14 
 Branches   1916 1916  
   
   - Hits  1031610172 -144 
   - Misses 8238 8398 +160 
   + Partials858  856   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==)
 | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=)
 | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
   | 
[.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9yZXN0L1RyYWNlU2VnbWVudFJlcG9ydExpc3RTZXJ2bGV0SGFuZGxlci5qYXZh)
 | `22.22% <0.00%> (-66.67%)` | `2.00% <0.00%> (-3.00%)` | |
   | 
[...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `0.78%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.14%   52.35%   -0.79% 
   + Complexity 2972 2942  -30 
   
 Files   773  771   -2 
 Lines 1941219420   +8 
 Branches   1916 1916  
   
   - Hits  1031610168 -148 
   - Misses 8238 8396 +158 
   + Partials858  856   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==)
 | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=)
 | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
   | 
[.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9yZXN0L1RyYWNlU2VnbWVudFJlcG9ydExpc3RTZXJ2bGV0SGFuZGxlci5qYXZh)
 | `22.22% <0.00%> (-66.67%)` | `2.00% <0.00%> (-3.00%)` | |
   | 
[...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `0.76%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.14%   52.37%   -0.77% 
   + Complexity 2972 2943  -29 
   
 Files   773  771   -2 
 Lines 1941219420   +8 
 Branches   1916 1916  
   
   - Hits  1031610172 -144 
   - Misses 8238 8392 +154 
   + Partials858  856   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==)
 | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=)
 | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
   | 
[.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9yZXN0L1RyYWNlU2VnbWVudFJlcG9ydExpc3RTZXJ2bGV0SGFuZGxlci5qYXZh)
 | `22.22% <0.00%> (-66.67%)` | `2.00% <0.00%> (-3.00%)` | |
   | 
[...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `0.90%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.14%   52.23%   -0.91% 
   + Complexity 2972 2936  -36 
   
 Files   773  771   -2 
 Lines 1941219420   +8 
 Branches   1916 1916  
   
   - Hits  1031610145 -171 
   - Misses 8238 8423 +185 
   + Partials858  852   -6 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==)
 | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=)
 | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
   | 
[.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9yZXN0L1RyYWNlU2VnbWVudFJlcG9ydExpc3RTZXJ2bGV0SGFuZGxlci5qYXZh)
 | `22.22% <0.00%> (-66.67%)` | `2.00% <0.00%> (-3.00%)` | |
   | 
[...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `1.64%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.14%   51.49%   -1.65% 
   + Complexity 2972 2914  -58 
   
 Files   773  771   -2 
 Lines 1941219410   -2 
 Branches   1916 1915   -1 
   
   - Hits  10316 9995 -321 
   - Misses 8238 8576 +338 
   + Partials858  839  -19 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==)
 | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=)
 | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
   | 
[.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=)
 | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
   | 
[.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYW

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `11.63%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.15%   41.51%   -11.64% 
   + Complexity 2972 2272  -700 
   =
 Files   772  771-1 
 Lines 1940819410+2 
 Branches   1916 1915-1 
   =
   - Hits  10316 8059 -2257 
   - Misses 823410751 +2517 
   + Partials858  600  -258 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/ag

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `1.65%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.15%   51.49%   -1.66% 
   + Complexity 2972 2914  -58 
   
 Files   772  771   -1 
 Lines 1940819410   +2 
 Branches   1916 1915   -1 
   
   - Hits  10316 9995 -321 
   - Misses 8234 8576 +342 
   + Partials858  839  -19 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==)
 | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=)
 | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
   | 
[.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=)
 | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
   | 
[.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYW

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `11.72%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.15%   41.43%   -11.73% 
   + Complexity 2972 2270  -702 
   =
 Files   772  771-1 
 Lines 1940819410+2 
 Branches   1916 1915-1 
   =
   - Hits  10316 8042 -2274 
   - Misses 823410768 +2534 
   + Partials858  600  -258 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/ag

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `11.69%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.15%   41.45%   -11.70% 
   + Complexity 2972 2270  -702 
   =
 Files   772  769-3 
 Lines 1940819399-9 
 Branches   1916 1915-1 
   =
   - Hits  10316 8042 -2274 
   - Misses 823410757 +2523 
   + Partials858  600  -258 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/ag

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `11.66%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.15%   41.48%   -11.67% 
   + Complexity 2972 2270  -702 
   =
 Files   772  768-4 
 Lines 1940819383   -25 
 Branches   1916 1911-5 
   =
   - Hits  10316 8042 -2274 
   - Misses 823410741 +2507 
   + Partials858  600  -258 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/ag

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `11.77%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.26%   41.48%   -11.78% 
   + Complexity 2972 2270  -702 
   =
 Files   771  768-3 
 Lines 1936919383   +14 
 Branches   1915 1911-4 
   =
   - Hits  10316 8042 -2274 
   - Misses 819510741 +2546 
   + Partials858  600  -258 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/ag

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `11.76%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.26%   41.49%   -11.77% 
   + Complexity 2972 2269  -703 
   =
 Files   771  767-4 
 Lines 1936919378+9 
 Branches   1915 1911-4 
   =
   - Hits  10316 8041 -2275 
   - Misses 819510737 +2542 
   + Partials858  600  -258 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/ag

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `11.77%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.26%   41.48%   -11.78% 
   + Complexity 2972 2269  -703 
   =
 Files   771  768-3 
 Lines 1936919383   +14 
 Branches   1915 1911-4 
   =
   - Hits  10316 8041 -2275 
   - Misses 819510742 +2547 
   + Partials858  600  -258 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/ag

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `11.80%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.27%   41.47%   -11.81% 
   + Complexity 2972 2216  -756 
   =
 Files   769  750   -19 
 Lines 1936318952  -411 
 Branches   1915 1878   -37 
   =
   - Hits  10316 7860 -2456 
   - Misses 818910503 +2314 
   + Partials858  589  -269 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/ag

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `11.78%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.26%   41.47%   -11.79% 
   + Complexity 2972 2216  -756 
   =
 Files   771  750   -21 
 Lines 1936918952  -417 
 Branches   1915 1878   -37 
   =
   - Hits  10316 7860 -2456 
   - Misses 819510503 +2308 
   + Partials858  589  -269 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/ag

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `11.70%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.26%   41.55%   -11.71% 
   + Complexity 2972 2269  -703 
   =
 Files   771  766-5 
 Lines 1936919352   -17 
 Branches   1915 1911-4 
   =
   - Hits  10316 8041 -2275 
   - Misses 819510711 +2516 
   + Partials858  600  -258 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/ag

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `12.63%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.26%   40.62%   -12.64% 
   + Complexity 2970 2191  -779 
   =
 Files   769  750   -19 
 Lines 1936318952  -411 
 Branches   1915 1878   -37 
   =
   - Hits  10313 7700 -2613 
   - Misses 819210671 +2479 
   + Partials858  581  -277 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/ag

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `20.75%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 52.36%   31.61%   -20.76% 
   + Complexity 2938 1753 -1185 
   =
 Files   769  749   -20 
 Lines 1936318775  -588 
 Branches   1915 1834   -81 
   =
   - Hits  10140 5936 -4204 
   - Misses 836712412 +4045 
   + Partials856  427  -429 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/ag

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `14.06%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 52.36%   38.30%   -14.07% 
   + Complexity 2938 2092  -846 
   =
 Files   769  750   -19 
 Lines 1936318944  -419 
 Branches   1915 1864   -51 
   =
   - Hits  10140 7257 -2883 
   - Misses 83670 +2743 
   + Partials856  577  -279 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/ag

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `42.30%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4987   +/-   ##
   
   - Coverage 42.30%   0.00%   -42.31% 
   
 Files   767 161  -606 
 Lines 193524019-15333 
 Branches   1915 477 -1438 
   
   - Hits   8186   0 -8186 
   + Misses105574019 -6538 
   + Partials609   0  -609 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==)
 | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh)
 | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
   | 
[...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=)
 | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==)
 | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (-7.00%)` | |
   | 
[...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=)
 | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
   | 
[...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh)
 | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [603 
more](https://codecov.io/gh/apache/skywalk

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `13.86%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 42.30%   28.44%   -13.87% 
   + Complexity 2297 1604  -693 
   =
 Files   767  749   -18 
 Lines 1935218755  -597 
 Branches   1915 1832   -83 
   =
   - Hits   8186 5334 -2852 
   - Misses1055713034 +2477 
   + Partials609  387  -222 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ap/server/core/metric/promethues/rule/Relabel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvcnVsZS9SZWxhYmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...r/core/metric/promethues/rule/CounterFunction.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvcnVsZS9Db3VudGVyRnVuY3Rpb24uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `39.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4987   +/-   ##
   
   - Coverage 39.06%   0.00%   -39.07% 
   
 Files   767 161  -606 
 Lines 193384019-15319 
 Branches   1914 477 -1437 
   
   - Hits   7554   0 -7554 
   + Misses111974019 -7178 
   + Partials587   0  -587 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==)
 | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh)
 | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
   | 
[...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=)
 | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==)
 | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (-7.00%)` | |
   | 
[...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=)
 | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
   | 
[...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh)
 | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [603 
more](https://codecov.io/gh/apache/skywalk

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `35.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4987   +/-   ##
   
   - Coverage 35.19%   0.00%   -35.20% 
   
 Files   767 161  -606 
 Lines 193024019-15283 
 Branches   1913 477 -1436 
   
   - Hits   6794   0 -6794 
   + Misses119914019 -7972 
   + Partials517   0  -517 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==)
 | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh)
 | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
   | 
[...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=)
 | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==)
 | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (-7.00%)` | |
   | 
[...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=)
 | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
   | 
[...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh)
 | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [603 
more](https://codecov.io/gh/apache/skywalk

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **decrease** coverage by `32.54%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4987   +/-   ##
   
   - Coverage 32.54%   0.00%   -32.55% 
   
 Files   751 161  -590 
 Lines 188934019-14874 
 Branches   1879 477 -1402 
   
   - Hits   6148   0 -6148 
   + Misses122574019 -8238 
   + Partials488   0  -488 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==)
 | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh)
 | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
   | 
[...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=)
 | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==)
 | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (-7.00%)` | |
   | 
[...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=)
 | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
   | 
[...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh)
 | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [587 
more](https://codecov.io/gh/apache/skywalk

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #4987   +/-   ##
   ==
 Coverage0.00%   0.00%   
   ==
 Files 164 161-3 
 Lines40664019   -47 
 Branches  481 477-4 
   ==
   + Misses   40664019   -47 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=)
 | | |
   | 
[...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh)
 | | |
   | 
[...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==)
 | | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=footer). 
Last update 
[79be376...08d686a](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #4987   +/-   ##
   ==
 Coverage0.00%   0.00%   
   ==
 Files 164 161-3 
 Lines40664019   -47 
 Branches  481 477-4 
   ==
   + Misses   40664019   -47 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=)
 | | |
   | 
[...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==)
 | | |
   | 
[...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh)
 | | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=footer). 
Last update 
[79be376...08d686a](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #4987   +/-   ##
   ==
 Coverage0.00%   0.00%   
   ==
 Files 164 161-3 
 Lines40664019   -47 
 Branches  481 477-4 
   ==
   + Misses   40664019   -47 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh)
 | | |
   | 
[...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=)
 | | |
   | 
[...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==)
 | | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=footer). 
Last update 
[79be376...08d686a](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #4987   +/-   ##
   ==
 Coverage0.00%   0.00%   
   ==
 Files 164 161-3 
 Lines40664019   -47 
 Branches  481 477-4 
   ==
   + Misses   40664019   -47 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh)
 | | |
   | 
[...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==)
 | | |
   | 
[...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=)
 | | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=footer). 
Last update 
[79be376...08d686a](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #4987   +/-   ##
   ==
 Coverage0.00%   0.00%   
   ==
 Files 164 159-5 
 Lines40664007   -59 
 Branches  481 477-4 
   ==
   + Misses   40664007   -59 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...t/core/jvm/memorypool/ParallelCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvUGFyYWxsZWxDb2xsZWN0b3JNb2R1bGUuamF2YQ==)
 | | |
   | 
[...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==)
 | | |
   | 
[...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=)
 | | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | | |
   | 
[...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh)
 | | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=footer). 
Last update 
[79be376...08d686a](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master   #4987+/-   ##
   ===
 Coverage0.00%   0.00%
   ===
 Files 161 147-14 
 Lines40493727   -322 
 Branches  481 447-34 
   ===
   + Misses   40493727   -322 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==)
 | | |
   | 
[...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh)
 | | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | | |
   | 
[.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=)
 | | |
   | 
[...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=)
 | | |
   | 
[...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==)
 | | |
   | 
[...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==)
 | | |
   | 
[...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=)
 | | |
   | ... and [5 
more](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=footer). 
Last update 
[79be376...08d686a](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


---

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/79be376a0b2b8edb4bde659bb40abe5a769f688a&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master   #4987+/-   ##
   ===
 Coverage0.00%   0.00%
   ===
 Files 163 147-16 
 Lines40613727   -334 
 Branches  481 447-34 
   ===
   + Misses   40613727   -334 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | |
   | 
[...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==)
 | | |
   | 
[...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==)
 | | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | | |
   | 
[...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==)
 | | |
   | 
[...t/core/jvm/memorypool/ParallelCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvUGFyYWxsZWxDb2xsZWN0b3JNb2R1bGUuamF2YQ==)
 | | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | | |
   | 
[...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=)
 | | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | | |
   | ... and [7 
more](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=footer). 
Last update 
[79be376...08d686a](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


---

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9c706d632ba4b9a70701b269173de69c32a7ee61&el=desc)
 will **decrease** coverage by `1.34%`.
   > The diff coverage is `37.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 54.53%   53.19%   -1.35% 
   - Complexity 2971 2978   +7 
   
 Files   750 1409 +659 
 Lines 1893830596   +11658 
 Branches   1869 3407+1538 
   
   + Hits  1032816275+5947 
   - Misses 775113517+5766 
   + Partials859  804  -55 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `62.82% <0.00%> (-0.82%)` | `3.00 <0.00> (ø)` | |
   | 
[...ing/apm/plugin/graphql/v12/GraphqlInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZ3JhcGhxbC1wbHVnaW4vZ3JhcGhxbC0xMi54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL2dyYXBocWwvdjEyL0dyYXBocWxJbnRlcmNlcHRvci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...king/apm/plugin/graphql/v8/GraphqlInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZ3JhcGhxbC1wbHVnaW4vZ3JhcGhxbC04LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZ3JhcGhxbC92OC9HcmFwaHFsSW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...king/apm/plugin/graphql/v9/GraphqlInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZ3JhcGhxbC1wbHVnaW4vZ3JhcGhxbC05LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZ3JhcGhxbC92OS9HcmFwaHFsSW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...lugin/mongodb/v3/support/MongoOperationHelper.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbW9uZ29kYi0zLngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbW9uZ29kYi92My9zdXBwb3J0L01vbmdvT3BlcmF0aW9uSGVscGVyLmphdmE=)
 | `7.14% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `97.05% <ø> (+97.05%)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXR

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.10%`.
   > The diff coverage is `92.30%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.19%   +0.10% 
   - Complexity 2969 2978   +9 
   
 Files  1409 1409  
 Lines 3058330596  +13 
 Branches   3405 3407   +2 
   
   + Hits  1623616275  +39 
   + Misses1354613517  -29 
   - Partials801  804   +3 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `94.73% <94.73%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `50.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `57.14% <0.00%> (-42.86%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...erver/library/server/grpc/CustomThreadFactory.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvQ3VzdG9tVGhyZWFkRmFjdG9yeS5qYXZh)
 | `69.23% <0.00%> (-7.70%)` | `2.00% <0.00%> (-1.00%)` | |
   | 
[.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=)
 | `66.35% <

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.10%`.
   > The diff coverage is `92.30%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.19%   +0.10% 
   - Complexity 2969 2978   +9 
   
 Files  1409 1409  
 Lines 3058330596  +13 
 Branches   3405 3407   +2 
   
   + Hits  1623616275  +39 
   + Misses1354613517  -29 
   - Partials801  804   +3 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `94.73% <94.73%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `50.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `57.14% <0.00%> (-42.86%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...erver/library/server/grpc/CustomThreadFactory.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvQ3VzdG9tVGhyZWFkRmFjdG9yeS5qYXZh)
 | `69.23% <0.00%> (-7.70%)` | `2.00% <0.00%> (-1.00%)` | |
   | 
[.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=)
 | `66.35% <

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.31%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.40%   +0.31% 
   - Complexity 2969 2978   +9 
   
 Files  1409  769 -640 
 Lines 3058319355   -11228 
 Branches   3405 1905-1500 
   
   - Hits  1623610336-5900 
   + Misses13546 8162-5384 
   - Partials801  857  +56 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.13%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.22%   +0.13% 
   + Complexity 2969 2965   -4 
   
 Files  1409  769 -640 
 Lines 3058319355   -11228 
 Branches   3405 1905-1500 
   
   - Hits  1623610302-5934 
   + Misses13546 8199-5347 
   - Partials801  854  +53 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `11.55%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   41.53%   -11.56% 
   + Complexity 2969 2267  -702 
   =
 Files  1409  769  -640 
 Lines 3058319352-11231 
 Branches   3405 1905 -1500 
   =
   - Hits  16236 8038 -8198 
   + Misses1354610711 -2835 
   + Partials801  603  -198 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/con

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `11.41%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   41.67%   -11.42% 
   + Complexity 2969 2274  -695 
   =
 Files  1409  769  -640 
 Lines 3058319352-11231 
 Branches   3405 1905 -1500 
   =
   - Hits  16236 8065 -8171 
   + Misses1354610682 -2864 
   + Partials801  605  -196 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/con

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `12.42%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   40.66%   -12.43% 
   + Complexity 2969 2236  -733 
   =
 Files  1409  769  -640 
 Lines 3058319352-11231 
 Branches   3405 1905 -1500 
   =
   - Hits  16236 7869 -8367 
   + Misses1354610881 -2665 
   + Partials801  602  -199 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/con

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `12.39%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   40.69%   -12.40% 
   + Complexity 2969 2236  -733 
   =
 Files  1409  768  -641 
 Lines 3058319336-11247 
 Branches   3405 1901 -1504 
   =
   - Hits  16236 7869 -8367 
   + Misses1354610865 -2681 
   + Partials801  602  -199 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/con

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `12.33%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   40.75%   -12.34% 
   + Complexity 2969 2236  -733 
   =
 Files  1409  767  -642 
 Lines 3058319310-11273 
 Branches   3405 1901 -1504 
   =
   - Hits  16236 7869 -8367 
   + Misses1354610839 -2707 
   + Partials801  602  -199 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/con

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `12.94%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   40.13%   -12.95% 
   + Complexity 2969 2198  -771 
   =
 Files  1409  767  -642 
 Lines 3058319310-11273 
 Branches   3405 1901 -1504 
   =
   - Hits  16236 7751 -8485 
   + Misses1354610957 -2589 
   + Partials801  602  -199 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/con

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `13.16%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   39.92%   -13.17% 
   + Complexity 2969 2188  -781 
   =
 Files  1409  767  -642 
 Lines 3058319310-11273 
 Branches   3405 1901 -1504 
   =
   - Hits  16236 7709 -8527 
   + Misses1354611007 -2539 
   + Partials801  594  -207 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/con

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `14.55%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   38.53%   -14.56% 
   + Complexity 2969 2149  -820 
   =
 Files  1409  767  -642 
 Lines 3058319310-11273 
 Branches   3405 1901 -1504 
   =
   - Hits  16236 7441 -8795 
   + Misses1354611305 -2241 
   + Partials801  564  -237 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/con

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `15.77%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   37.31%   -15.78% 
   + Complexity 2969 2106  -863 
   =
 Files  1409  765  -644 
 Lines 3058319285-11298 
 Branches   3405 1900 -1505 
   =
   - Hits  16236 7196 -9040 
   + Misses1354611535 -2011 
   + Partials801  554  -247 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/con

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `15.76%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   37.32%   -15.77% 
   + Complexity 2969 2106  -863 
   =
 Files  1409  764  -645 
 Lines 3058319280-11303 
 Branches   3405 1900 -1505 
   =
   - Hits  16236 7196 -9040 
   + Misses1354611530 -2016 
   + Partials801  554  -247 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/con

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.09%`.
   > The diff coverage is `92.30%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.18%   +0.09% 
   - Complexity 2969 2978   +9 
   
 Files  1409 1409  
 Lines 3058330601  +18 
 Branches   3405 3406   +1 
   
   + Hits  1623616276  +40 
   + Misses1354613522  -24 
   - Partials801  803   +2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `94.73% <94.73%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `50.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `57.14% <0.00%> (-42.86%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==)
 | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
   | 
[...erver/library/server/grpc/CustomThreadFactory.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `18.22%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   34.86%   -18.23% 
   + Complexity 2969 2010  -959 
   =
 Files  1409  764  -645 
 Lines 3058319244-11339 
 Branches   3405 1899 -1506 
   =
   - Hits  16236 6710 -9526 
   + Misses1354612011 -1535 
   + Partials801  523  -278 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/con

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `18.23%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   34.85%   -18.24% 
   + Complexity 2969 2009  -960 
   =
 Files  1409  764  -645 
 Lines 3058319244-11339 
 Branches   3405 1899 -1506 
   =
   - Hits  16236 6708 -9528 
   + Misses1354612012 -1534 
   + Partials801  524  -277 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/con

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `20.50%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   32.58%   -20.51% 
   + Complexity 2969 1838 -1131 
   =
 Files  1409  748  -661 
 Lines 3058318832-11751 
 Branches   3405 1852 -1553 
   =
   - Hits  16236 6136-10100 
   + Misses1354612216 -1330 
   + Partials801  480  -321 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/Pr

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `20.36%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   32.72%   -20.37% 
   + Complexity 2969 1848 -1121 
   =
 Files  1409  748  -661 
 Lines 3058318832-11751 
 Branches   3405 1852 -1553 
   =
   - Hits  16236 6162-10074 
   + Misses1354612183 -1363 
   + Partials801  487  -314 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/Pr

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `18.22%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   34.85%   -18.23% 
   + Complexity 2969 1966 -1003 
   =
 Files  1409  748  -661 
 Lines 3058318844-11739 
 Branches   3405 1866 -1539 
   =
   - Hits  16236 6569 -9667 
   + Misses1354611754 -1792 
   + Partials801  521  -280 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/con

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `30.60%`.
   > The diff coverage is `46.15%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   22.48%   -30.61% 
   + Complexity 2969 1345 -1624 
   =
 Files  1409  747  -662 
 Lines 3058318645-11938 
 Branches   3405 1821 -1584 
   =
   - Hits  16236 4192-12044 
   - Misses1354614141  +595 
   + Partials801  312  -489 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `31.57% <31.57%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `1.00 <1.00> (-1.00)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `10.93% <100.00%> (-61.79%)` | `0.00 <0.00> (-13.00)` | |
   | 
[...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/oap/server/core/analysis/reco

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `53.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4987   +/-   ##
   
   - Coverage 53.08%   0.00%   -53.09% 
   
 Files  1409 160 -1249 
 Lines 305833990-26593 
 Branches   3405 467 -2938 
   
   - Hits  16236   0-16236 
   + Misses135463990 -9556 
   + Partials801   0  -801 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [1379 
more](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `53.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4987   +/-   ##
   
   - Coverage 53.08%   0.00%   -53.09% 
   
 Files  1409 159 -1250 
 Lines 305833951-26632 
 Branches   3405 466 -2939 
   
   - Hits  16236   0-16236 
   + Misses135463951 -9595 
   + Partials801   0  -801 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [1380 
more](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.09%`.
   > The diff coverage is `92.30%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.18%   +0.09% 
   - Complexity 2969 2978   +9 
   
 Files  1409 1409  
 Lines 3058330601  +18 
 Branches   3405 3406   +1 
   
   + Hits  1623616276  +40 
   + Misses1354613522  -24 
   - Partials801  803   +2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `94.73% <94.73%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `50.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `57.14% <0.00%> (-42.86%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==)
 | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
   | 
[...erver/library/server/grpc/CustomThreadFactory.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.09%`.
   > The diff coverage is `92.30%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.18%   +0.09% 
   - Complexity 2969 2976   +7 
   
 Files  1409 1409  
 Lines 3058330601  +18 
 Branches   3405 3406   +1 
   
   + Hits  1623616276  +40 
   + Misses1354613522  -24 
   - Partials801  803   +2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `94.73% <94.73%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `50.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `57.14% <0.00%> (-42.86%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==)
 | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
   | 
[...erver/library/server/grpc/CustomThreadFactory.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `53.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4987   +/-   ##
   
   - Coverage 53.08%   0.00%   -53.09% 
   
 Files  1409 152 -1257 
 Lines 305833828-26755 
 Branches   3405 454 -2951 
   
   - Hits  16236   0-16236 
   + Misses135463828 -9718 
   + Partials801   0  -801 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [1381 
more](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `53.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4987   +/-   ##
   
   - Coverage 53.08%   0.00%   -53.09% 
   
 Files  1409 156 -1253 
 Lines 305833897-26686 
 Branches   3405 459 -2946 
   
   - Hits  16236   0-16236 
   + Misses135463897 -9649 
   + Partials801   0  -801 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [1380 
more](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.27%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.36%   +0.27% 
   - Complexity 2969 2976   +7 
   
 Files  1409  770 -639 
 Lines 3058319359   -11224 
 Branches   3405 1905-1500 
   
   - Hits  1623610330-5906 
   + Misses13546 8171-5375 
   - Partials801  858  +57 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `0.77%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.08%   52.30%   -0.78% 
   + Complexity 2969 2930  -39 
   
 Files  1409  770 -639 
 Lines 3058319356   -11227 
 Branches   3405 1905-1500 
   
   - Hits  1623610125-6111 
   + Misses13546 8382-5164 
   - Partials801  849  +48 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `3.15%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.08%   49.93%   -3.16% 
   + Complexity 2969 2854 -115 
   
 Files  1409  770 -639 
 Lines 3058319356   -11227 
 Branches   3405 1905-1500 
   
   - Hits  16236 9666-6570 
   + Misses13546 8858-4688 
   - Partials801  832  +31 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `3.34%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.08%   49.74%   -3.35% 
   + Complexity 2969 2845 -124 
   
 Files  1409  770 -639 
 Lines 3058319356   -11227 
 Branches   3405 1905-1500 
   
   - Hits  16236 9628-6608 
   + Misses13546 8904-4642 
   - Partials801  824  +23 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `4.59%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.08%   48.49%   -4.60% 
   + Complexity 2969 2734 -235 
   
 Files  1409  754 -655 
 Lines 3058318946   -11637 
 Branches   3405 1871-1534 
   
   - Hits  16236 9187-7049 
   + Misses13546 8957-4589 
   - Partials801  802   +1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `4.68%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.08%   48.40%   -4.69% 
   + Complexity 2969 2732 -237 
   
 Files  1409  754 -655 
 Lines 3058318946   -11637 
 Branches   3405 1871-1534 
   
   - Hits  16236 9170-7066 
   + Misses13546 8974-4572 
   - Partials801  802   +1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `12.71%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   40.36%   -12.72% 
   + Complexity 2969 2352  -617 
   =
 Files  1409  753  -656 
 Lines 3058318866-11717 
 Branches   3405 1864 -1541 
   =
   - Hits  16236 7616 -8620 
   + Misses1354610569 -2977 
   + Partials801  681  -120 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/co

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `12.75%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   40.33%   -12.76% 
   + Complexity 2969 2352  -617 
   =
 Files  1409  754  -655 
 Lines 3058318882-11701 
 Branches   3405 1868 -1537 
   =
   - Hits  16236 7616 -8620 
   + Misses1354610585 -2961 
   + Partials801  681  -120 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/co

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `12.76%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   40.32%   -12.77% 
   + Complexity 2969 2349  -620 
   =
 Files  1409  752  -657 
 Lines 3058318840-11743 
 Branches   3405 1863 -1542 
   =
   - Hits  16236 7597 -8639 
   + Misses1354610561 -2985 
   + Partials801  682  -119 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/co

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `12.66%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   40.42%   -12.67% 
   + Complexity 2969 2352  -617 
   =
 Files  1409  752  -657 
 Lines 3058318840-11743 
 Branches   3405 1864 -1541 
   =
   - Hits  16236 7616 -8620 
   + Misses1354610543 -3003 
   + Partials801  681  -120 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/co

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `12.69%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   40.39%   -12.70% 
   + Complexity 2969 2348  -621 
   =
 Files  1409  751  -658 
 Lines 3058318801-11782 
 Branches   3405 1862 -1543 
   =
   - Hits  16236 7594 -8642 
   + Misses1354610523 -3023 
   + Partials801  684  -117 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/co

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `12.71%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4987   +/-   ##
   =
   - Coverage 53.08%   40.37%   -12.72% 
   + Complexity 2969 2346  -623 
   =
 Files  1409  751  -658 
 Lines 3058318801-11782 
 Branches   3405 1862 -1543 
   =
   - Hits  16236 7591 -8645 
   + Misses1354610524 -3022 
   + Partials801  686  -115 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/co

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `1.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.08%   52.02%   -1.07% 
   + Complexity 2969  684-2285 
   
 Files  1409  163-1246 
 Lines 30583 3971   -26612 
 Branches   3405  466-2939 
   
   - Hits  16236 2066   -14170 
   + Misses13546 1642   -11904 
   + Partials801  263 -538 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==)
 | `0.00% <0.00%> (-87.06%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-72.23%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=)
 | `0.00% <0.00%> (-69.24%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=)
 | `18.18% <0.00%> (-63.64%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `13.20% <0.00%> (-53.46%)` | `4.00% <0.00%> (ø%)` | |
   | 
[.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=)
 | `26.66% <0.00%> (-50.00%)` | `7.00% <0.00%> (ø%)` | |
   | ... and [1321 
mo

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `0.71%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.08%   52.37%   -0.72% 
   + Complexity 2969  684-2285 
   
 Files  1409  162-1247 
 Lines 30583 3945   -26638 
 Branches   3405  461-2944 
   
   - Hits  16236 2066   -14170 
   + Misses13546 1616   -11930 
   + Partials801  263 -538 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==)
 | `0.00% <0.00%> (-87.06%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-72.23%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=)
 | `18.18% <0.00%> (-63.64%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `13.20% <0.00%> (-53.46%)` | `4.00% <0.00%> (ø%)` | |
   | 
[.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=)
 | `26.66% <0.00%> (-50.00%)` | `7.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `0.71%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.08%   52.37%   -0.72% 
   + Complexity 2969  684-2285 
   
 Files  1409  162-1247 
 Lines 30583 3945   -26638 
 Branches   3405  461-2944 
   
   - Hits  16236 2066   -14170 
   + Misses13546 1616   -11930 
   + Partials801  263 -538 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==)
 | `0.00% <0.00%> (-87.06%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-72.23%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=)
 | `18.18% <0.00%> (-63.64%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `13.20% <0.00%> (-53.46%)` | `4.00% <0.00%> (ø%)` | |
   | 
[.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=)
 | `26.66% <0.00%> (-50.00%)` | `7.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.07%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.16%   +0.07% 
   + Complexity 2969  684-2285 
   
 Files  1409  160-1249 
 Lines 30583 3886   -26697 
 Branches   3405  454-2951 
   
   - Hits  16236 2066   -14170 
   + Misses13546 1557   -11989 
   + Partials801  263 -538 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==)
 | `0.00% <0.00%> (-87.06%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-72.23%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=)
 | `18.18% <0.00%> (-63.64%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `13.20% <0.00%> (-53.46%)` | `4.00% <0.00%> (ø%)` | |
   | 
[.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=)
 | `26.66% <0.00%> (-50.00%)` | `7.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.62%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.71%   +0.62% 
   + Complexity 2969  684-2285 
   
 Files  1409  159-1250 
 Lines 30583 3846   -26737 
 Branches   3405  450-2955 
   
   - Hits  16236 2066   -14170 
   + Misses13546 1517   -12029 
   + Partials801  263 -538 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==)
 | `0.00% <0.00%> (-87.06%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-72.23%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=)
 | `18.18% <0.00%> (-63.64%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `13.20% <0.00%> (-53.46%)` | `4.00% <0.00%> (ø%)` | |
   | 
[.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=)
 | `26.66% <0.00%> (-50.00%)` | `7.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.69%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.78%   +0.69% 
   + Complexity 2969  684-2285 
   
 Files  1409  158-1251 
 Lines 30583 3841   -26742 
 Branches   3405  450-2955 
   
   - Hits  16236 2066   -14170 
   + Misses13546 1512   -12034 
   + Partials801  263 -538 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==)
 | `0.00% <0.00%> (-87.06%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-72.23%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=)
 | `18.18% <0.00%> (-63.64%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `13.20% <0.00%> (-53.46%)` | `4.00% <0.00%> (ø%)` | |
   | 
[.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=)
 | `26.66% <0.00%> (-50.00%)` | `7.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.75%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.84%   +0.75% 
   + Complexity 2969  684-2285 
   
 Files  1409  157-1252 
 Lines 30583 3837   -26746 
 Branches   3405  450-2955 
   
   - Hits  16236 2066   -14170 
   + Misses13546 1508   -12038 
   + Partials801  263 -538 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==)
 | `0.00% <0.00%> (-87.06%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-72.23%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=)
 | `18.18% <0.00%> (-63.64%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `13.20% <0.00%> (-53.46%)` | `4.00% <0.00%> (ø%)` | |
   | 
[.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=)
 | `26.66% <0.00%> (-50.00%)` | `7.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.75%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.84%   +0.75% 
   + Complexity 2969  684-2285 
   
 Files  1409  157-1252 
 Lines 30583 3837   -26746 
 Branches   3405  450-2955 
   
   - Hits  16236 2066   -14170 
   + Misses13546 1508   -12038 
   + Partials801  263 -538 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==)
 | `0.00% <0.00%> (-87.06%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-72.23%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=)
 | `18.18% <0.00%> (-63.64%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `13.20% <0.00%> (-53.46%)` | `4.00% <0.00%> (ø%)` | |
   | 
[.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=)
 | `26.66% <0.00%> (-50.00%)` | `7.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `1.15%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   54.23%   +1.15% 
   + Complexity 2969  684-2285 
   
 Files  1409  155-1254 
 Lines 30583 3809   -26774 
 Branches   3405  448-2957 
   
   - Hits  16236 2066   -14170 
   + Misses13546 1480   -12066 
   + Partials801  263 -538 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==)
 | `0.00% <0.00%> (-87.06%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=)
 | `18.18% <0.00%> (-63.64%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `13.20% <0.00%> (-53.46%)` | `4.00% <0.00%> (ø%)` | |
   | 
[.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=)
 | `26.66% <0.00%> (-50.00%)` | `7.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/apm/agent/core/context/ExtensionContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25Db250ZXh0LmphdmE=)
 | `28.57% <0.00%> (-42.86%)` | `5.00% <0.00%> (ø%)` | |
   | ... and [132

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `1.30%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   54.39%   +1.30% 
   + Complexity 2969  684-2285 
   
 Files  1409  153-1256 
 Lines 30583 3798   -26785 
 Branches   3405  448-2957 
   
   - Hits  16236 2066   -14170 
   + Misses13546 1469   -12077 
   + Partials801  263 -538 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==)
 | `0.00% <0.00%> (-87.06%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=)
 | `18.18% <0.00%> (-63.64%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `13.20% <0.00%> (-53.46%)` | `4.00% <0.00%> (ø%)` | |
   | 
[.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=)
 | `26.66% <0.00%> (-50.00%)` | `7.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/apm/agent/core/context/ExtensionContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25Db250ZXh0LmphdmE=)
 | `28.57% <0.00%> (-42.86%)` | `5.00% <0.00%> (ø%)` | |
   | 
[...ing/apm/agent/core/logging/core/WriterFactory.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1dyaXRlckZhY3RvcnkuamF2YQ==)
 | `21.42% <0.00%> (-42.86%)` | `2.00% <0.00%> (ø%)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `32.25% <0.00%> (-39.58%)` | `9.00% <0.00%> (ø%)` | |
   | ... and [1322 
more](https://codecov.io/gh/apache/sk

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `1.15%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   54.23%   +1.15% 
   + Complexity 2969  684-2285 
   
 Files  1409  155-1254 
 Lines 30583 3809   -26774 
 Branches   3405  448-2957 
   
   - Hits  16236 2066   -14170 
   + Misses13546 1480   -12066 
   + Partials801  263 -538 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==)
 | `0.00% <0.00%> (-87.06%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=)
 | `18.18% <0.00%> (-63.64%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `13.20% <0.00%> (-53.46%)` | `4.00% <0.00%> (ø%)` | |
   | 
[.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=)
 | `26.66% <0.00%> (-50.00%)` | `7.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/apm/agent/core/context/ExtensionContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25Db250ZXh0LmphdmE=)
 | `28.57% <0.00%> (-42.86%)` | `5.00% <0.00%> (ø%)` | |
   | ... and [132

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `53.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4987   +/-   ##
   
   - Coverage 53.08%   0.00%   -53.09% 
   
 Files  1409 151 -1258 
 Lines 305833786-26797 
 Branches   3405 448 -2957 
   
   - Hits  16236   0-16236 
   + Misses135463786 -9760 
   + Partials801   0  -801 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [1380 
more](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `53.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4987   +/-   ##
   
   - Coverage 53.08%   0.00%   -53.09% 
   
 Files  1409 149 -1260 
 Lines 305833773-26810 
 Branches   3405 447 -2958 
   
   - Hits  16236   0-16236 
   + Misses135463773 -9773 
   + Partials801   0  -801 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [1380 
more](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `92.30%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.08%   53.07%   -0.02% 
   + Complexity 2969 2966   -3 
   
 Files  1409 1410   +1 
 Lines 3058330610  +27 
 Branches   3405 3405  
   
   + Hits  1623616246  +10 
   - Misses1354613561  +15 
   - Partials801  803   +2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `94.73% <94.73%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==)
 | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `50.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `57.14% <0.00%> (-42.86%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `92.30%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.08%   53.07%   -0.02% 
   + Complexity 2969 2966   -3 
   
 Files  1409 1410   +1 
 Lines 3058330610  +27 
 Branches   3405 3405  
   
   + Hits  1623616246  +10 
   - Misses1354613561  +15 
   - Partials801  803   +2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `94.73% <94.73%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==)
 | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `50.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `57.14% <0.00%> (-42.86%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.08%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.17%   +0.08% 
   + Complexity 2969 2966   -3 
   
 Files  1409  772 -637 
 Lines 3058319374   -11209 
 Branches   3405 1909-1496 
   
   - Hits  1623610302-5934 
   + Misses13546 8216-5330 
   - Partials801  856  +55 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.08%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.17%   +0.08% 
   + Complexity 2969 2966   -3 
   
 Files  1409  772 -637 
 Lines 3058319374   -11209 
 Branches   3405 1909-1496 
   
   - Hits  1623610302-5934 
   + Misses13546 8216-5330 
   - Partials801  856  +55 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.09%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.18%   +0.09% 
   + Complexity 2969 2966   -3 
   
 Files  1409  771 -638 
 Lines 3058319370   -11213 
 Branches   3405 1909-1496 
   
   - Hits  1623610302-5934 
   + Misses13546 8212-5334 
   - Partials801  856  +55 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.07%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.16%   +0.07% 
   + Complexity 2969 2965   -4 
   
 Files  1409  771 -638 
 Lines 3058319370   -11213 
 Branches   3405 1909-1496 
   
   - Hits  1623610298-5938 
   + Misses13546 8216-5330 
   - Partials801  856  +55 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.20%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.28%   +0.20% 
   + Complexity 2969 2965   -4 
   
 Files  1409  768 -641 
 Lines 3058319325   -11258 
 Branches   3405 1908-1497 
   
   - Hits  1623610298-5938 
   + Misses13546 8171-5375 
   - Partials801  856  +55 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **decrease** coverage by `0.53%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   - Coverage 53.08%   52.54%   -0.54% 
   + Complexity 2969 2944  -25 
   
 Files  1409  768 -641 
 Lines 3058319315   -11268 
 Branches   3405 1907-1498 
   
   - Hits  1623610150-6086 
   + Misses13546 8323-5223 
   - Partials801  842  +41 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-06 Thread GitBox


codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=h1) 
Report
   > Merging 
[#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3df2e8ddcebb00eccb1747919f5352c9909c15df&el=desc)
 will **increase** coverage by `0.09%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4987/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4987  +/-   ##
   
   + Coverage 53.08%   53.18%   +0.09% 
   + Complexity 2969 2965   -4 
   
 Files  1409  769 -640 
 Lines 3058319364   -11219 
 Branches   3405 1909-1496 
   
   - Hits  1623610298-5938 
   + Misses13546 8210-5336 
   - Partials801  856  +55 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh)
 | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | |
   | 
[.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==)
 | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | |
   | 
[...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh)
 | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | |
   | 
[...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> 

  1   2   3   4   5   6   >