[GitHub] [skywalking] codecov-io edited a comment on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)

2020-01-19 Thread GitBox
codecov-io edited a comment on issue #4247: fix thread unsafe problem in 
server-alarm-plugin (#4230)
URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575109679
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=h1) 
Report
   > Merging 
[#4247](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/85b1107ae29652b3a4df2cd3b11ded78d41171eb?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4247/graphs/tree.svg?width=650=qrILxY5yA8=150=pr)](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4247  +/-   ##
   ==
   - Coverage   26.92%   26.91%   -0.01% 
   ==
 Files1162 1162  
 Lines   2539825399   +1 
 Branches 3627 3628   +1 
   ==
   - Hits 6839 6837   -2 
   - Misses  1795517957   +2 
   - Partials  604  605   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh)
 | `74% <100%> (-1.84%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=footer). 
Last update 
[85b1107...a9855bb](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] codecov-io edited a comment on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)

2020-01-19 Thread GitBox
codecov-io edited a comment on issue #4247: fix thread unsafe problem in 
server-alarm-plugin (#4230)
URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575109679
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=h1) 
Report
   > Merging 
[#4247](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/85b1107ae29652b3a4df2cd3b11ded78d41171eb?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4247/graphs/tree.svg?width=650=qrILxY5yA8=150=pr)](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4247   +/-   ##
   ===
 Coverage   26.92%   26.92%   
   ===
 Files1162 1162   
 Lines   2539825398   
 Branches 3627 3627   
   ===
 Hits 6839 6839   
 Misses  1795517955   
 Partials  604  604
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=footer). 
Last update 
[85b1107...a9855bb](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] codecov-io edited a comment on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)

2020-01-19 Thread GitBox
codecov-io edited a comment on issue #4247: fix thread unsafe problem in 
server-alarm-plugin (#4230)
URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575109679
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=h1) 
Report
   > Merging 
[#4247](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/765162dbd0a205800d187914ffa0ca4f25069bb2?src=pr=desc)
 will **increase** coverage by `0.48%`.
   > The diff coverage is `17.96%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4247/graphs/tree.svg?width=650=qrILxY5yA8=150=pr)](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4247  +/-   ##
   ==
   + Coverage   26.43%   26.92%   +0.48% 
   ==
 Files1179 1162  -17 
 Lines   2580325398 -405 
 Branches 3748 3627 -121 
   ==
   + Hits 6822 6839  +17 
   + Misses  1837917955 -424 
   - Partials  602  604   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...erver/receiver/jvm/provider/JVMModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9KVk1Nb2R1bGVQcm92aWRlci5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==)
 | `54.83% <ø> (ø)` | :arrow_up: |
   | 
[...lking/oap/server/core/query/TraceQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvVHJhY2VRdWVyeVNlcnZpY2UuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh)
 | `53.57% <ø> (ø)` | :arrow_up: |
   | 
[.../provider/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZXJMaXN0ZW5lck1hbmFnZXIuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...iver/register/provider/RegisterModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcmVnaXN0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvcmVnaXN0ZXIvcHJvdmlkZXIvUmVnaXN0ZXJNb2R1bGVQcm92aWRlci5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[.../apm/agent/core/profile/TracingThreadSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9UcmFjaW5nVGhyZWFkU25hcHNob3QuamF2YQ==)
 | `0% <0%> (ø)` | |
   | 
[...alking/oap/server/core/command/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY29tbWFuZC9Db21tYW5kU2VydmljZS5qYXZh)
 | `0% <0%> (ø)` | :arrow_up: |
   | ... and [40 
more](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov-io edited a comment on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)

2020-01-18 Thread GitBox
codecov-io edited a comment on issue #4247: fix thread unsafe problem in 
server-alarm-plugin (#4230)
URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575109679
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=h1) 
Report
   > Merging 
[#4247](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/765162dbd0a205800d187914ffa0ca4f25069bb2?src=pr=desc)
 will **increase** coverage by `0.48%`.
   > The diff coverage is `17.96%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4247/graphs/tree.svg?width=650=qrILxY5yA8=150=pr)](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4247  +/-   ##
   ==
   + Coverage   26.43%   26.92%   +0.48% 
   ==
 Files1179 1162  -17 
 Lines   2580325398 -405 
 Branches 3748 3627 -121 
   ==
   + Hits 6822 6839  +17 
   + Misses  1837917955 -424 
   - Partials  602  604   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...erver/receiver/jvm/provider/JVMModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9KVk1Nb2R1bGVQcm92aWRlci5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==)
 | `54.83% <ø> (ø)` | :arrow_up: |
   | 
[...lking/oap/server/core/query/TraceQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvVHJhY2VRdWVyeVNlcnZpY2UuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh)
 | `53.57% <ø> (ø)` | :arrow_up: |
   | 
[.../provider/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZXJMaXN0ZW5lck1hbmFnZXIuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...iver/register/provider/RegisterModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcmVnaXN0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvcmVnaXN0ZXIvcHJvdmlkZXIvUmVnaXN0ZXJNb2R1bGVQcm92aWRlci5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[.../apm/agent/core/profile/TracingThreadSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9UcmFjaW5nVGhyZWFkU25hcHNob3QuamF2YQ==)
 | `0% <0%> (ø)` | |
   | 
[...alking/oap/server/core/command/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY29tbWFuZC9Db21tYW5kU2VydmljZS5qYXZh)
 | `0% <0%> (ø)` | :arrow_up: |
   | ... and [40 
more](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov-io edited a comment on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)

2020-01-18 Thread GitBox
codecov-io edited a comment on issue #4247: fix thread unsafe problem in 
server-alarm-plugin (#4230)
URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575109679
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=h1) 
Report
   > Merging 
[#4247](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/765162dbd0a205800d187914ffa0ca4f25069bb2?src=pr=desc)
 will **increase** coverage by `0.48%`.
   > The diff coverage is `17.96%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4247/graphs/tree.svg?width=650=qrILxY5yA8=150=pr)](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4247  +/-   ##
   ==
   + Coverage   26.43%   26.92%   +0.48% 
   ==
 Files1179 1162  -17 
 Lines   2580325398 -405 
 Branches 3748 3627 -121 
   ==
   + Hits 6822 6839  +17 
   + Misses  1837917955 -424 
   - Partials  602  604   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...erver/receiver/jvm/provider/JVMModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9KVk1Nb2R1bGVQcm92aWRlci5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==)
 | `54.83% <ø> (ø)` | :arrow_up: |
   | 
[...lking/oap/server/core/query/TraceQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvVHJhY2VRdWVyeVNlcnZpY2UuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh)
 | `53.57% <ø> (ø)` | :arrow_up: |
   | 
[.../provider/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZXJMaXN0ZW5lck1hbmFnZXIuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...iver/register/provider/RegisterModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcmVnaXN0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvcmVnaXN0ZXIvcHJvdmlkZXIvUmVnaXN0ZXJNb2R1bGVQcm92aWRlci5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[.../apm/agent/core/profile/TracingThreadSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9UcmFjaW5nVGhyZWFkU25hcHNob3QuamF2YQ==)
 | `0% <0%> (ø)` | |
   | 
[...alking/oap/server/core/command/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY29tbWFuZC9Db21tYW5kU2VydmljZS5qYXZh)
 | `0% <0%> (ø)` | :arrow_up: |
   | ... and [40 
more](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov-io edited a comment on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)

2020-01-16 Thread GitBox
codecov-io edited a comment on issue #4247: fix thread unsafe problem in 
server-alarm-plugin (#4230)
URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575109679
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=h1) 
Report
   > Merging 
[#4247](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/1c7fd0c1e34fc4056083f44378325b1354911c30?src=pr=desc)
 will **increase** coverage by `0.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4247/graphs/tree.svg?width=650=qrILxY5yA8=150=pr)](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4247  +/-   ##
   ==
   + Coverage   26.34%   26.43%   +0.08% 
   ==
 Files1179 1179  
 Lines   2580325803  
 Branches 3748 3748  
   ==
   + Hits 6799 6822  +23 
   + Misses  1840118379  -22 
   + Partials  603  602   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...king/oap/server/library/module/ModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LW1vZHVsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvbW9kdWxlL01vZHVsZVByb3ZpZGVyLmphdmE=)
 | `50% <ø> (ø)` | :arrow_up: |
   | 
[...m/agent/core/remote/TraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RyYWNlU2VnbWVudFNlcnZpY2VDbGllbnQuamF2YQ==)
 | `82.35% <0%> (+1.47%)` | :arrow_up: |
   | 
[.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=)
 | `31.46% <0%> (+3.37%)` | :arrow_up: |
   | 
[...pm/agent/core/profile/ProfileTaskQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1F1ZXJ5U2VydmljZS5qYXZh)
 | `51.28% <0%> (+7.69%)` | :arrow_up: |
   | 
[...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==)
 | `85.71% <0%> (+17.85%)` | :arrow_up: |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `77.04% <0%> (+18.03%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=footer). 
Last update 
[1c7fd0c...765162d](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] codecov-io edited a comment on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)

2020-01-16 Thread GitBox
codecov-io edited a comment on issue #4247: fix thread unsafe problem in 
server-alarm-plugin (#4230)
URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575109679
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=h1) 
Report
   > Merging 
[#4247](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/82c7bccd0d8416ca88a55b135591181ff9e81834?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4247/graphs/tree.svg?width=650=qrILxY5yA8=150=pr)](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4247   +/-   ##
   ===
 Coverage   26.34%   26.34%   
   ===
 Files1179 1179   
 Lines   2580325803   
 Branches 3748 3748   
   ===
 Hits 6799 6799   
 Misses  1840118401   
 Partials  603  603
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=footer). 
Last update 
[82c7bcc...1c7fd0c](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services