[GitHub] [skywalking] codecov-io edited a comment on issue #4344: supprt gRPC alarm hook.

2020-02-11 Thread GitBox
codecov-io edited a comment on issue #4344: supprt gRPC alarm hook.
URL: https://github.com/apache/skywalking/pull/4344#issuecomment-584597339
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=h1) 
Report
   > Merging 
[#4344](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/0635bbe9b637a9baabd2ca244cdf99e6d9f62efe?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4344/graphs/tree.svg?width=650=qrILxY5yA8=150=pr)](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4344   +/-   ##
   ===
 Coverage   26.43%   26.43%   
   ===
 Files1180 1180   
 Lines   2676726767   
 Branches 3696 3696   
   ===
 Hits 7075 7075   
 Misses  1906519065   
 Partials  627  627
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=footer). 
Last update 
[0635bbe...abaee0f](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] codecov-io edited a comment on issue #4344: supprt gRPC alarm hook.

2020-02-11 Thread GitBox
codecov-io edited a comment on issue #4344: supprt gRPC alarm hook.
URL: https://github.com/apache/skywalking/pull/4344#issuecomment-584597339
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=h1) 
Report
   > Merging 
[#4344](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/2f5a4ee7453dfe82cd0ae6f4a8f27382a9336b44?src=pr=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `41.3%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4344/graphs/tree.svg?width=650=qrILxY5yA8=150=pr)](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #4344  +/-   ##
   =
   - Coverage   26.42%   26.4%   -0.02% 
   =
 Files11791180   +1 
 Lines   26743   26767  +24 
 Branches 36903696   +6 
   =
   + Hits 70687069   +1 
   - Misses  19051   19070  +19 
   - Partials  624 628   +4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...king/oap/server/library/util/GRPCStreamStatus.java](https://codecov.io/gh/apache/skywalking/pull/4344/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvR1JQQ1N0cmVhbVN0YXR1cy5qYXZh)
 | `0% <ø> (ø)` | |
   | 
[.../server/core/alarm/provider/grpc/GRPCCallback.java](https://codecov.io/gh/apache/skywalking/pull/4344/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9ncnBjL0dSUENDYWxsYmFjay5qYXZh)
 | `60.86% <35.71%> (-11.68%)` | :arrow_down: |
   | 
[...ver/core/alarm/provider/grpc/GRPCAlarmSetting.java](https://codecov.io/gh/apache/skywalking/pull/4344/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9ncnBjL0dSUENBbGFybVNldHRpbmcuamF2YQ==)
 | `50% <50%> (ø)` | |
   | 
[...ap/server/exporter/provider/grpc/GRPCExporter.java](https://codecov.io/gh/apache/skywalking/pull/4344/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyLmphdmE=)
 | `75.82% <50%> (-2.34%)` | :arrow_down: |
   | 
[.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/4344/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=)
 | `81.25% <0%> (-6.25%)` | :arrow_down: |
   | 
[.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4344/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=)
 | `61.6% <0%> (-2.68%)` | :arrow_down: |
   | 
[...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/4344/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh)
 | `69.23% <0%> (-1.29%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=footer). 
Last update 
[2f5a4ee...0635bbe](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] codecov-io edited a comment on issue #4344: supprt gRPC alarm hook.

2020-02-11 Thread GitBox
codecov-io edited a comment on issue #4344: supprt gRPC alarm hook.
URL: https://github.com/apache/skywalking/pull/4344#issuecomment-584597339
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=h1) 
Report
   > Merging 
[#4344](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/2f5a4ee7453dfe82cd0ae6f4a8f27382a9336b44?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4344/graphs/tree.svg?width=650=qrILxY5yA8=150=pr)](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4344   +/-   ##
   ===
 Coverage   26.42%   26.42%   
   ===
 Files1179 1179   
 Lines   2674326743   
 Branches 3690 3690   
   ===
 Hits 7068 7068   
 Misses  1905119051   
 Partials  624  624
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=footer). 
Last update 
[2f5a4ee...5a36298](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services