[GitHub] [skywalking] geektcp opened a new pull request #4270: bug fix

2020-01-18 Thread GitBox
geektcp opened a new pull request #4270: bug fix
URL: https://github.com/apache/skywalking/pull/4270
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   
   ___
   ### Bug fix
   - Bug description.
   ```
   Skywalking server disk is full(100%), Then clean OAP storage ES data and 
restart Skywalking ,the micro service and agent do not restart . 
   endpointInventoryCache will be null before agent registered
   ```
   - How to fix?
   check the null and do nothing at MultiScopesSpanListener.setPublicAttrs
   ___
   ### log
   ```
   2020-01-19 14:24:15,830 - 
org.apache.skywalking.oap.server.receiver.register.provider.handler.v6.grpc.RegisterServiceHandler
 - 150 [grpcServerPool-1-thread-10] INFO  [] - register service instance id=23 
[UUID:3524fb27678d48d28fb8217de4980f1a]
   2020-01-19 14:24:16,258 - 
org.apache.skywalking.oap.server.core.cache.EndpointInventoryCache - 95 
[grpcServerPool-1-thread-10] WARN  [] - EndpointInventory id 14 is not in cache 
and persistent storage.
   2020-01-19 14:24:16,259 - 
org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2 
- 126 [grpcServerPool-1-thread-10] ERROR [] - null
   java.lang.NullPointerException: null
at 
org.apache.skywalking.oap.server.receiver.trace.provider.parser.listener.endpoint.MultiScopesSpanListener.setPublicAttrs(MultiScopesSpanListener.java:246)
 ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0]
at 
org.apache.skywalking.oap.server.receiver.trace.provider.parser.listener.endpoint.MultiScopesSpanListener.parseEntry(MultiScopesSpanListener.java:146)
 ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0]
at 
org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2.lambda$notifyEntryListener$1(SegmentParseV2.java:233)
 ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0]
at java.lang.Iterable.forEach(Iterable.java:75) ~[?:1.8.0_121]
at 
org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2.notifyEntryListener(SegmentParseV2.java:231)
 ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0]
at 
org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2.preBuild(SegmentParseV2.java:195)
 ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0]
at 
org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2.parse(SegmentParseV2.java:104)
 [skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0]
at 
org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2$Producer.send(SegmentParseV2.java:282)
 [skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0]
at 
org.apache.skywalking.oap.server.receiver.trace.provider.handler.v6.grpc.TraceSegmentReportServiceHandler$1.onNext(TraceSegmentReportServiceHandler.java:57)
 [skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0]
at 
org.apache.skywalking.oap.server.receiver.trace.provider.handler.v6.grpc.TraceSegmentReportServiceHandler$1.onNext(TraceSegmentReportServiceHandler.java:49)
 [skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0]
at 
io.grpc.stub.ServerCalls$StreamingServerCallHandler$StreamingServerCallListener.onMessage(ServerCalls.java:248)
 [grpc-stub-1.15.1.jar:1.15.1]
at 
io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.messagesAvailable(ServerCallImpl.java:263)
 [grpc-core-1.15.1.jar:1.15.1]
at 
io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1MessagesAvailable.runInContext(ServerImpl.java:683)
 [grpc-core-1.15.1.jar:1.15.1]
at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37) 
[grpc-core-1.15.1.jar:1.15.1]
at 
io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123) 
[grpc-core-1.15.1.jar:1.15.1]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) 
[?:1.8.0_121]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) 
[?:1.8.0_121]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_121]
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] geektcp opened a new pull request #4270: bug fix

2020-01-18 Thread GitBox
geektcp opened a new pull request #4270: bug fix
URL: https://github.com/apache/skywalking/pull/4270
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   
   ___
   ### Bug fix
   - Bug description.
   ```
   Skywalking server disk is full(100%), Then clean OAP storage ES data and 
restart Skywalking ,the micro service and agent do not restart . 
   endpointInventoryCache will be null before agent registered
   ```
   - How to fix?
   check the null and do nothing at MultiScopesSpanListener.setPublicAttrs
   ___
   ### log
   ```
   2020-01-19 14:24:15,830 - 
org.apache.skywalking.oap.server.receiver.register.provider.handler.v6.grpc.RegisterServiceHandler
 - 150 [grpcServerPool-1-thread-10] INFO  [] - register service instance id=23 
[UUID:3524fb27678d48d28fb8217de4980f1a]
   2020-01-19 14:24:16,258 - 
org.apache.skywalking.oap.server.core.cache.EndpointInventoryCache - 95 
[grpcServerPool-1-thread-10] WARN  [] - EndpointInventory id 14 is not in cache 
and persistent storage.
   2020-01-19 14:24:16,259 - 
org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2 
- 126 [grpcServerPool-1-thread-10] ERROR [] - null
   java.lang.NullPointerException: null
at 
org.apache.skywalking.oap.server.receiver.trace.provider.parser.listener.endpoint.MultiScopesSpanListener.setPublicAttrs(MultiScopesSpanListener.java:246)
 ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0]
at 
org.apache.skywalking.oap.server.receiver.trace.provider.parser.listener.endpoint.MultiScopesSpanListener.parseEntry(MultiScopesSpanListener.java:146)
 ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0]
at 
org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2.lambda$notifyEntryListener$1(SegmentParseV2.java:233)
 ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0]
at java.lang.Iterable.forEach(Iterable.java:75) ~[?:1.8.0_121]
at 
org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2.notifyEntryListener(SegmentParseV2.java:231)
 ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0]
at 
org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2.preBuild(SegmentParseV2.java:195)
 ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0]
at 
org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2.parse(SegmentParseV2.java:104)
 [skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0]
at 
org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2$Producer.send(SegmentParseV2.java:282)
 [skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0]
at 
org.apache.skywalking.oap.server.receiver.trace.provider.handler.v6.grpc.TraceSegmentReportServiceHandler$1.onNext(TraceSegmentReportServiceHandler.java:57)
 [skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0]
at 
org.apache.skywalking.oap.server.receiver.trace.provider.handler.v6.grpc.TraceSegmentReportServiceHandler$1.onNext(TraceSegmentReportServiceHandler.java:49)
 [skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0]
at 
io.grpc.stub.ServerCalls$StreamingServerCallHandler$StreamingServerCallListener.onMessage(ServerCalls.java:248)
 [grpc-stub-1.15.1.jar:1.15.1]
at 
io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.messagesAvailable(ServerCallImpl.java:263)
 [grpc-core-1.15.1.jar:1.15.1]
at 
io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1MessagesAvailable.runInContext(ServerImpl.java:683)
 [grpc-core-1.15.1.jar:1.15.1]
at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37) 
[grpc-core-1.15.1.jar:1.15.1]
at 
io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123) 
[grpc-core-1.15.1.jar:1.15.1]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) 
[?:1.8.0_121]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) 
[?:1.8.0_121]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_121]
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services