[GitHub] [skywalking] kezhenxu94 commented on issue #4272: Codes clean up plan and set up more strict code style rules

2020-02-07 Thread GitBox
kezhenxu94 commented on issue #4272: Codes clean up plan and set up more strict 
code style rules
URL: https://github.com/apache/skywalking/issues/4272#issuecomment-583376855
 
 
   If @JohnNiang or any other contributor is interested in this, feel free to 
leave a comment and open pull requests to fix, thanks :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] kezhenxu94 commented on issue #4272: Codes clean up plan and set up more strict code style rules

2020-02-11 Thread GitBox
kezhenxu94 commented on issue #4272: Codes clean up plan and set up more strict 
code style rules
URL: https://github.com/apache/skywalking/issues/4272#issuecomment-584554649
 
 
   > @kezhenxu94 Which things left here? As #4337 has been merged.
   
   Have updated the TODOs in the first comment of this issue, those left 
unchecked are unsupported by Checkstyle plugin by default, may need some 
customization, low priority though 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] kezhenxu94 commented on issue #4272: Codes clean up plan and set up more strict code style rules

2020-02-11 Thread GitBox
kezhenxu94 commented on issue #4272: Codes clean up plan and set up more strict 
code style rules
URL: https://github.com/apache/skywalking/issues/4272#issuecomment-584616376
 
 
   @wu-sheng I'm totally ok to close it for now


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services