[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-593750362 @wu-sheng Hi Thanks for your useful feedback, and I will try to move forward. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-593319725 Hi, I have no clear way how to add an e2e test for `e2e-ShardingSphere` after reading #4335 and e2e-mysql. My initial idea is to copy the dir of `e2e-mysql` to `e2e-ShardingSphere` and modify `rc0-prepare.sh` to run `Sharding Proxy` as backend server. Do you think it is feasible or not? I am looking forward to your kind suggestion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-593278342 @wu-sheng Hi, I want to double-check the configuration `my.cnf` of ShardingProxy is supposed to locate in `root_dir/install/shardingsphere/proxy/` to provide user or e2e test, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-590262740 Got it, therefore i will push it forward following the our existing plan. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-590197372 Maybe i gave a bad example. A better example should be table `user`, `order`, `product` and so on. 😅 Sorry that `user_*` is not supported so far, in this case what should we do next? @wu-sheng This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-590156844 @wu-sheng > restrict rule How to make proxy know there is a to-check table which is not existing in configuration? > wildcard name I am not sure whether it will be included in next release, IMO it is not a widespread need that all of the `user_*` tables, i.e, user_all, user_single need sharding. Most cases i got are to shard tables like `t_order` and `t_order_item`, at this moment `wildcard` is not needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-590027379 > Based on the description, if there is a new dynamic table we missed on the config file, the system still works, this is the risk. To some extend, you are right. However it is human being's mistake that table config is missing, rather than program which just needs to look at the configuraion whether it is correct or not. Even we missed some sharding table rule, SS can share one DB's stress as well. Imagining, if there is no sharding rule, all the tables will be put into one DB. On the other hand, indeed configuration of `user_*` can reduce the likelihood of mistakes and SS should shadow more configuration detail and simply user's work and understanding. Currently, i am sorry that SS can not do so well, but what you worried also gave me some new ideas to make it better. Thanks very much. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-589933024 SS find sharding rule of one table completely based on config, i.e, if we miss any table, SS will consider it as `non-sharding table` existed on `default-datasource`(Need to configure), which SS sends the query to. When starting up, SS will load all sub-tables configured at configuration and check their metadata one by one. @wu-sheng This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-589518601 @wu-sheng I agree with you, however sorry to say currently `user_*` can not be used on configuration of sharding proxy. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-589500912 > Can't you use a Regex or expression to represent the tables? I was assuming we could do that. Using a Regex or expression to represent the tables on `configuration of sharding proxy`? @wu-sheng This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e
test and doc for SkyWalking 7
URL: https://github.com/apache/skywalking/issues/4131#issuecomment-588582921
schemaName: sharding_db
dataSources:
ds0:
url: jdbc:postgresql://localhost:5432/ds0
username: root
password:
connectionTimeoutMilliseconds: 3
idleTimeoutMilliseconds: 6
maxLifetimeMilliseconds: 180
maxPoolSize: 65
ds1:
url: jdbc:postgresql://localhost:5432/ds1
username: root
password:
connectionTimeoutMilliseconds: 3
idleTimeoutMilliseconds: 6
maxLifetimeMilliseconds: 180
maxPoolSize: 65
shardingRule:
tables:
**t_order**:
actualDataNodes: ds${0..1}.t_order${0..1}
databaseStrategy:
inline:
shardingColumn: user_id
algorithmExpression: ds${user_id % 2}
tableStrategy:
inline:
shardingColumn: order_id
algorithmExpression: t_order${order_id % 2}
keyGenerator:
type: SNOWFLAKE
column: order_id
**t_order_item**:
actualDataNodes: ds${0..1}.t_order_item${0..1}
databaseStrategy:
inline:
shardingColumn: user_id
algorithmExpression: ds${user_id % 2}
tableStrategy:
inline:
shardingColumn: order_id
algorithmExpression: t_order_item${order_id % 2}
keyGenerator:
type: SNOWFLAKE
column: order_item_id
bindingTables:
- t_order,t_order_item
defaultTableStrategy:
none:
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-588582694 > I mean config the table names with some rules(Regex), or exclusion rule is better. Such as `all table exclude tableA, tableB, tableC` are using this sharding rule. Those tables need to be configured in [sharding-proxy-config](https://shardingsphere.apache.org/document/current/en/manual/sharding-proxy/configuration/), which means we have to configure tables one by one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-588127418 > I don't like the idea we config them one by one. We could be use which tables are not sharded. Segment is a special case, and all others are metrics or related, so we could use the same rule for them. You mean config 282 tables at once? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-588126490 > No, the concern is table could be added without source code changed. Could you give me some hints how to handle this issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-588034509 My first idea of sharding stratergy is to shard certain table, taking `alarm_record` for example, into 4 DBs and 10 tables each DB, i.e, totally 40 sub-tables for one table with the sharding column `time_bucket`. Other tables at the frist can adopt the same sharding stratergy with their own sharding columns. What do you think? @dmsolr @wu-sheng This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-588029909 > Most of SkyWalking tables are created by OAL scripts. Do you know what is it? > > Limited tables are the inventory tables, or we called metadata tables, or not time serious tables. What you concerned is to provide certain rules for tables without sharding, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-587390211 > Another reminder is, Could you use a consistent-hash-func(table_name) and an exclusion rule for limited tables Thanks for your reminder, however i could not get your point. How to use `consistent-hash-func(table_name) ` to provide the sharding configuration once for all? What is the meaning of `an exclusion rule for limited tables`. @wu-sheng This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e
test and doc for SkyWalking 7
URL: https://github.com/apache/skywalking/issues/4131#issuecomment-587315261
### Some Query SQLs
select count(1) total alarm_record where 1=1 and time_bucket >=
20191210165700 and time_bucket <= 20191210171299 order by start_time desc
select * from alarm_record where 1=1 and time_bucket >= ? and time_bucket
<= ? order by start_time desc LIMIT 0, 20
select avg(value) value,entity_id from endpoint_avg where time_bucket >= ?
and time_bucket <= ? group by entity_id order by value desc limit 10
select count(1) total from segment where 1=1 and time_bucket >= ? and
time_bucket <= ? order by latency desc
select * from segment where 1=1 and time_bucket >= 20191210165700 and
time_bucket <= 20191210171299 order by latency desc LIMIT 0, 15
select entity_id id, avg(value) value from service_cpm where (entity_id in
('2','3')) and time_bucket>= ? and time_bucket<=? group by entity_id
select avg(value) value,entity_id from service_cpm where time_bucket >= ?
and time_bucket <= ? group by entity_id order by value desc limit 10
select id, value from endpoint_p90 where id in
('201912101657','201912101658','201912101659','201912101700','201912101701','201912101702','201912101703','201912101704','201912101705','201912101706','201912101707','201912101708','201912101709','201912101710','201912101711','201912101712')
select id, value from instance_clr_cpu where id in
('201912101657_2','201912101658_2','201912101659_2','201912101700_2','201912101701_2','201912101702_2','201912101703_2','201912101704_2','201912101705_2','201912101706_2','201912101707_2','201912101708_2','201912101709_2','201912101710_2','201912101711_2','201912101712_2')
select id, value from service_p50 where id in
('201912101657_2','201912101658_2','201912101659_2','201912101700_2','201912101701_2','201912101702_2','201912101703_2','201912101704_2','201912101705_2','201912101706_2','201912101707_2','201912101708_2','201912101709_2','201912101710_2','201912101711_2','201912101712_2')
select entity_id from service_relation_client_side where time_bucket>=
201912101657 and time_bucket<=201912101712 and (source_service_id=2 or
dest_service_id=2 ) group by entity_id
select entity_id id, avg(value) value from service_resp_time where
(entity_id in ('2','3')) and time_bucket>= 201912101657 and
time_bucket<=201912101712 group by entity_id
select entity_id id, avg(percentage) value from service_sla where (entity_id
in ('2','3')) and time_bucket>= ? and time_bucket<=? group by entity_id
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-587315127 ### Target tables alarm_record database_access_cpm database_access_cpm_day database_access_cpm_hour database_access_cpm_month database_access_p50 database_access_p50_day database_access_p50_hour database_access_p50_month database_access_p75 database_access_p75_day database_access_p75_hour database_access_p75_month database_access_p90 database_access_p90_day database_access_p90_hour database_access_p90_month database_access_p95 database_access_p95_day database_access_p95_hour database_access_p95_month database_access_p99 database_access_p99_day database_access_p99_hour database_access_p99_month database_access_resp_time database_access_resp_time_day database_access_resp_time_hour database_access_resp_time_month database_access_sla database_access_sla_day database_access_sla_hour database_access_sla_month endpoint_avg endpoint_avg_day endpoint_avg_hour endpoint_avg_month endpoint_cpm endpoint_cpm_day endpoint_cpm_hour endpoint_cpm_month endpoint_p50 endpoint_p50_day endpoint_p50_hour endpoint_p50_month endpoint_p75 endpoint_p75_day endpoint_p75_hour endpoint_p75_month endpoint_p90 endpoint_p90_day endpoint_p90_hour endpoint_p90_month endpoint_p95 endpoint_p95_day endpoint_p95_hour endpoint_p95_month endpoint_p99 endpoint_p99_day endpoint_p99_hour endpoint_p99_month endpoint_relation_cpm endpoint_relation_cpm_day endpoint_relation_cpm_hour endpoint_relation_cpm_month endpoint_relation_resp_time endpoint_relation_resp_time_day endpoint_relation_resp_time_hour endpoint_relation_resp_time_month endpoint_relation_server_side endpoint_relation_server_side_day endpoint_relation_server_side_hour endpoint_relation_server_side_month endpoint_sla endpoint_sla_day endpoint_sla_hour endpoint_sla_month envoy_heap_memory_max_used envoy_heap_memory_max_used_day envoy_heap_memory_max_used_hour envoy_heap_memory_max_used_month envoy_pare
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-587314746 ### All the tables created by SW alarm_record all_heatmap all_heatmap_day all_heatmap_hour all_heatmap_month all_p50 all_p50_day all_p50_hour all_p50_month all_p75 all_p75_day all_p75_hour all_p75_month all_p90 all_p90_day all_p90_hour all_p90_month all_p95 all_p95_day all_p95_hour all_p95_month all_p99 all_p99_day all_p99_hour all_p99_month database_access_cpm database_access_cpm_day database_access_cpm_hour database_access_cpm_month database_access_p50 database_access_p50_day database_access_p50_hour database_access_p50_month database_access_p75 database_access_p75_day database_access_p75_hour database_access_p75_month database_access_p90 database_access_p90_day database_access_p90_hour database_access_p90_month database_access_p95 database_access_p95_day database_access_p95_hour database_access_p95_month database_access_p99 database_access_p99_day database_access_p99_hour database_access_p99_month database_access_resp_time database_access_resp_time_day database_access_resp_time_hour database_access_resp_time_month database_access_sla database_access_sla_day database_access_sla_hour database_access_sla_month endpoint_avg endpoint_avg_day endpoint_avg_hour endpoint_avg_month endpoint_cpm endpoint_cpm_day endpoint_cpm_hour endpoint_cpm_month endpoint_inventory endpoint_p50 endpoint_p50_day endpoint_p50_hour endpoint_p50_month endpoint_p75 endpoint_p75_day endpoint_p75_hour endpoint_p75_month endpoint_p90 endpoint_p90_day endpoint_p90_hour endpoint_p90_month endpoint_p95 endpoint_p95_day endpoint_p95_hour endpoint_p95_month endpoint_p99 endpoint_p99_day
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-587314368 For the 2nd one sub-task, i present an analysis for us to discuss, welcome your comment and opinion. Specially ping @wu-sheng and @dmsolr here. Here are 311 tables created by sw, and 282 tables will be targets for sharding (initally supposed) since @wu-sheng told me tables with `all_` starter and `_inventory` terminator and one `register_lock` table are excluded. After digging the MySQL general log, i picked up some representative SQLs for us to discuss. From my point, it seems `time_bucket` and `id` are feasible for tables to do range sharding. I appended all the tables, target tables and SQLs for analysis below for you to review. Looking forward to your suggestion. In addtion, there are many tables and SQLs to shard, so i suggest at the beginning, we can pick up some important tables and SQLs to do sharding, the aim of which is to check our solution can run well from A to Z. After that, we can add more tables to `configuration` of `ShardingProxy` to shard continually, which can help split a huge task into many small ones and PRs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-587302393 Hi everyone, after discussion on dev@list, here is the schedule of this issue, - [x] Acquire all required tables and query SQLs from db logs, like general log of MySQL. - [ ] Analyse those tables and query SQLs to explore appropriate sharding strategy. - [ ] Provide class implementation of `PreciseShardingAlgorithm` and `RangeShardingAlgorithm` of ShardingSphere to do sharding. - [ ] Provide configuration of Sharding Proxy[2] for Skywalking. - [ ] Provide e2e tests of Skywalking. @dmsolr will be in charge of 4th and 5th, and i will take care of 1st to 3rd of this list. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584594056 > Then the expected module will be `oap-server/server-storage-plugin/storage-shardingsphere-algorithms`. WDYT? Sharding-algorithm implements `interface of ShardingSphere`, which means ShardingSphere pom will be imported into SkyWalking. Is it ok? On the other hand, [Second solution](https://github.com/apache/skywalking/issues/4131#issuecomment-584533083) does not encounter this issue. Wait for the second one? Or try to first one？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584534107 > There are some options > > 1. As you said, you could provide the source codes hosted in SkyWalking main repo, then, it will be released as a separate jar in 7.0.0. You could update the document to point to the jar, even it is not available today. > > 2. Open a new repo to host it and ask for a release process for it. As you haven't been a committer/PMC, you need one to help you with this. > > > Which one do you want? First one sounds easy to make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584533083 @wu-sheng Here is another news, ShardingSphere is planning to do some optimization for sharding algorithm. And the main idea is to provide user some `default sharding algorithms`, therefore there is no need of `sharding-algorithm.jar`, and user just chooses one of `existing algorithms` and configure it in `my.cnf`. I am not sure the concrete date for its completion, but once it finishes, i will continue to update this issue here. I would like to hear you suggestion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584525495 > `sharding-algorithm.jar` needs to be taken care of differently. It is a binary distribution, so it can't be hosted in any repo. @wu-sheng Agree with you, and it is also what i am confused and have no idea to handle. I can provide a `sharding-algorithm.java`, but use need to complie it to generate `sharding-algorithm.jar`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584523278 Hi @wu-sheng Not only `my.cnf`, a `sharding-algorithm.jar` is necessary to be put into `install/shardingsphere/proxy/` to handle sharding tables and dbs. If user plan to adopt sharding proxy as backend server, he has to download sharding proxy and copy `my.cnf`, and `sharding-algorithm.jar` from `install/shardingsphere/proxy`to specified dir. Do you think the above solution is feasible? And then how to specify my workload? Here is a task list from my understanding, 1. Provide `my.cnf`, a `sharding-algorithm.jar` and put them into `install/shardingsphere/proxy/` 2.Update `readme` 3.Update `storage doc` 4.Create e2e test referring to `test/e2e/mysql` If i came to wrong conclusion, please be clear what i should do next. Thanks in advance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-583944522 @wu-sheng Hi, sir. I am considering using ShardingProxy to be the backend storage for sw. If i add a configuration, something like `my.cnf` for MySQL, do you think i should put it into sw project? If so, where is a better place? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-568949594 @wu-sheng Hi, thanks for this issue which any updates from me would be related to. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
