[GitHub] [skywalking] wu-sheng commented on a change in pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
wu-sheng commented on a change in pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#discussion_r506488320 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/dependencies/org/slf4j/impl/StaticLoggerBinder.java ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.dependencies.org.slf4j.impl; + +import org.slf4j.ILoggerFactory; +import org.slf4j.spi.LoggerFactoryBinder; + +/** + * SLF4J LoggerFactoryBinder implementation using Log4j. This class is part of the required classes used to specify an + * SLF4J logger provider implementation. Review comment: ```suggestion * The slf4j-api would try to load org.slf4j.impl.StaticLoggerBinder internal. In the agent core, we add our own implementation * for bridging to SkyWalking internal log component. * Therefore, logs of netty/grpc/kafka(agent shaded components) would output through the SkyWalking's log. * * Don't move this class to any other package, its package must be as same as the shaded org.apache.skywalking.apm.dependencies.org.slf4j.impl ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
wu-sheng commented on a change in pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#discussion_r506488320 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/dependencies/org/slf4j/impl/StaticLoggerBinder.java ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.dependencies.org.slf4j.impl; + +import org.slf4j.ILoggerFactory; +import org.slf4j.spi.LoggerFactoryBinder; + +/** + * SLF4J LoggerFactoryBinder implementation using Log4j. This class is part of the required classes used to specify an + * SLF4J logger provider implementation. Review comment: ```suggestion * The slf4j-api would try to load org.slf4j.impl.StaticLoggerBinder internal. In the agent core, we add our own implementation * for bridging to SkyWalking internal log component. * Therefore, logs of netty/grpc/kafka(agent shaded components) would output through the SkyWalking's log. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
wu-sheng commented on a change in pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#discussion_r506438354 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/dependencies/org/slf4j/impl/StaticLoggerBinder.java ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.dependencies.org.slf4j.impl; Review comment: Why this class needs to locate in `org.apache.skywalking.apm.dependencies.org.slf4j.impl`? I think I have asked you to place this in the `org.apache.skywalking.apm.agent.core.logging.adaptor` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
wu-sheng commented on a change in pull request #5678:
URL: https://github.com/apache/skywalking/pull/5678#discussion_r506196768
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/core/LogLevel.java
##
@@ -19,5 +19,5 @@
package org.apache.skywalking.apm.agent.core.logging.core;
public enum LogLevel {
-DEBUG, INFO, WARN, ERROR, OFF
+TRACE, DEBUG, INFO, WARN, ERROR, OFF
Review comment:
Please help with updating `logging.level` in the agent setup doc. Add
all available values in the documentation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
