[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-533860104 You should intercept the constructor. Then you could get it at the initialization stage. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-533859719 Have you enhanced `InterceptorCallback`? I think the snapshot could propagate through the constructor. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-533848183 I mean, you need to intercept buildCallback method, and create a manual class implementing Callable and EnhancedClass. Make sense? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-533847789 Isn't it a callback implementor? I am little confused. How could you enhance all callback implementors? It is possible, but not recommended. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-533846733 What do you mean can't enhance? It looks like just intercepting return value, and change it to our own callback. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-533180262 OK. Take your time, if you could find the codebase, we could talk about it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-533160076 @stalary Could you find the codes of `KafkaTemplate$$Lambda$522/515652386`? What is the lamda in the source code? Look like the plugin is assuming this is an enhanced class, but it isn't. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532987351 @stalary Any update? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532443385 @stalary I think if this is the only issue, we could a good fix, but you need to test whether this is the only issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and
Spring Kafka
URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532227110
Such as from this error log, we are intercepting `KafkaProducer`
constructor, right?
> java.lang.ClassCastException: java.util.ArrayList cannot be cast to
java.lang.String
at
org.apache.skywalking.apm.plugin.kafka.ProducerConstructorMapInterceptor.onConstruct(ProducerConstructorMapInterceptor.java:34)
```
objInst.setSkyWalkingDynamicField(StringUtil.join(';', ((String)
config.get("bootstrap.servers")).split(",")));
```
We did String cast directly, clearly for Spring Kafka, it is not a String
type, right?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532224926 I am not asking there must be a Spring-kafka plugin, but the kafka plugin should work as expected. In some cases, spring-xxx created a new API entrance, then we need a new plugin. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532224590 > However, an error is reported when it passes through the kafka-plugin Why? If we intercept the right place, then all APIs should be same. no matter who calls it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-53862 > When spring-kafka exists, how can I enable spring-kafka-plugin by not launching the kafka plugin，I need a little help. What is the issue here? If both of them are exit span creators, then the first one should override the second automatically, if there is no across threads happening. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532210148 @stalary do you have interest to enhance this part? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532209203 Need new support for Spring Kafka. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
