[GitHub] [skywalking] wu-sheng commented on issue #4220: sniffer processing profile task and report status and snapshot

2020-01-18 Thread GitBox
wu-sheng commented on issue #4220: sniffer processing profile task and report 
status and snapshot
URL: https://github.com/apache/skywalking/pull/4220#issuecomment-575879392
 
 
   > You have only ES DAO for ES6, ProfileTaskQueryEsDAO, ProfileTaskLogEsDAO, 
and you use them in ES7, they're not compatible trivially, please add the 
implementations for ES7 version
   
   @mrproliu Please fix. FYI @kezhenxu94 it was me asking him to add more real 
e2e test in the next query and snapshot merge PR. So, maybe some points are 
missed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [skywalking] wu-sheng commented on issue #4220: sniffer processing profile task and report status and snapshot

2020-01-17 Thread GitBox
wu-sheng commented on issue #4220: sniffer processing profile task and report 
status and snapshot
URL: https://github.com/apache/skywalking/pull/4220#issuecomment-575849618
 
 
   @mrproliu javadoc is failing, please fix and resolves the above comments.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services