[GitHub] [skywalking] wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin
wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-588101582 We are waiting for nearly 24 hours, we will merge soon. Anyone has suggestions feels free to submit a separated PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin
wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-587352263 e2e fail because the profile task DAO is still accessing the H2/MySQL. It seems you miss a change. Please fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin
wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-586780704 @dmsolr Please recheck. The ElasticSearch test fails agian. I don't find any change related to you. Please take a look, what is the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin
wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-586716319 The ElasticSearch fails twice, I am rerunning it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin
wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-584540142 The strict format rule has been merged, please update this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin
wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-584171718 #4335 is going to be merged today. There would be the last two new storage methods introduced. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin
wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-583796531 Profile e2e is failing, please recheck. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin
wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-583730593 I don't want this big PR blocked too long, it is last a long time, we could create an issue to track your test change proposal. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin
wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-583730492 @kezhenxu94 I don't want the e2e use submodule actually. Setting static proto files is good for compatible check and easy to check. I think we talked about this before, right? For test reactor, it is not a block. It is test optimization. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin
wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-582253156 `docker-entrypoint.sh` files This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
