[GitHub] [skywalking] wu-sheng commented on issue #4292: Improve ES query performance
wu-sheng commented on issue #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292#issuecomment-579745860 Look like e2e is failing, please check. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4292: Improve ES query performance
wu-sheng commented on issue #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292#issuecomment-581012815 Personally If you want tk optimize, recommend you to take over #4236 . Its author seems being blocked. It has much meaning and improvement. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4292: Improve ES query performance
wu-sheng commented on issue #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292#issuecomment-581027206 > But I'm still concerned about the range filter, the benchmark results in #4291 (comment) shows the average time in a small data set, but the memory consumed in the ES side is not measured, as an APM system, a large amount of data in a small time range is not unusual, and caching such large amount of data in memory may make side effects Agree. We should evaluate the cost. And agian, take a look the TBD PR, that basically is a good one. Just need to shape the codes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4292: Improve ES query performance
wu-sheng commented on issue #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292#issuecomment-581039018 @aderm My point is, this optimization seems not very obvious. Like you said, you are confused about the data, and if this really cached in the ES server, this would make more concerns. The time range keeps changes in different query, which could use more resources. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4292: Improve ES query performance
wu-sheng commented on issue #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292#issuecomment-581044167 Really recommend working on #4236 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4292: Improve ES query performance
wu-sheng commented on issue #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292#issuecomment-581094353 > sometimes query size two, the expected value size is one Why this happens? FYI @kezhenxu94 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4292: Improve ES query performance
wu-sheng commented on issue #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292#issuecomment-584507064 > any progress？ The conclusion has been made here. https://github.com/apache/skywalking/issues/4291#issuecomment-584063442 This PR would not improve the performance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
