[GitHub] [skywalking] wu-sheng commented on pull request #5085: Include request method type in rest mapping annotations
wu-sheng commented on pull request #5085:
URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657173107
Basically, adding http method in the operation name is not a big issue. But
it mostly relates to rest style. In some systems, get and post are same, this
naming style could be an issue by separating the same access.
From my understanding, we could provide an across plugin configuration, and
makes different pluings share it.
Back to [] {}, it should not a big issue. Either is fine. We just need a
consistent way.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5085: Include request method type in rest mapping annotations
wu-sheng commented on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-674950381 e2e profiling controlled by this, https://github.com/apache/skywalking/blob/master/.github/workflows/e2e.profiling.yaml This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5085: Include request method type in rest mapping annotations
wu-sheng commented on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-674950052 I think this has affected the profiling e2e case. I think it did profiling after matching the endpoint name. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5085: Include request method type in rest mapping annotations
wu-sheng commented on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-675214362 @kezhenxu94 Could you take a look the error? @BFergerson I think the key error is here, https://github.com/apache/skywalking/blob/master/test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/profile/ProfileE2E.java#L144 You changed the endpoint naming rule, then the profile task fails because no endpoint name matched the task parameter. Note, the logs you posted are not related to this, I just say for the e2e test fail because of timeout. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5085: Include request method type in rest mapping annotations
wu-sheng commented on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-672775348 Seems Spring case is still failure. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5085: Include request method type in rest mapping annotations
wu-sheng commented on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-674640363 @BFergerson Could you make the tests passed? This PR has been open for a little long time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5085: Include request method type in rest mapping annotations
wu-sheng commented on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-662736911 Could you update this PR currently? 8.1.0 release is closing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5085: Include request method type in rest mapping annotations
wu-sheng commented on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-663283282 reas the file in the .github folder, there are a lot of yaml file controlling e2e. It is easy to follow. Those are GitHub action control files. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5085: Include request method type in rest mapping annotations
wu-sheng commented on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-687024127 @BFergerson Any update of this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
