[GitHub] jjlu521016 commented on issue #2104: Support spring-rabbit plugin for 1.x and 2.x

2019-01-15 Thread GitBox
jjlu521016 commented on issue #2104: Support  spring-rabbit plugin for 1.x and 
2.x
URL: 
https://github.com/apache/incubator-skywalking/pull/2104#issuecomment-454330420
 
 
   @wu-sheng not any update , if i had good idea,i will give PR


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jjlu521016 commented on issue #2104: Support spring-rabbit plugin for 1.x and 2.x

2018-12-31 Thread GitBox
jjlu521016 commented on issue #2104: Support  spring-rabbit plugin for 1.x and 
2.x
URL: 
https://github.com/apache/incubator-skywalking/pull/2104#issuecomment-450664251
 
 
   OK,we will try


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jjlu521016 commented on issue #2104: Support spring-rabbit plugin for 1.x and 2.x

2018-12-31 Thread GitBox
jjlu521016 commented on issue #2104: Support  spring-rabbit plugin for 1.x and 
2.x
URL: 
https://github.com/apache/incubator-skywalking/pull/2104#issuecomment-450629152
 
 
   @WithLin I had discussed rabbitmq plugin with you. at that time ,you tell me 
when  rabbitmq plugin get consumer method,it just pull message.so the trace 
will broker. and kafka have same problem. when i read rabbitmq and 
spring-rabbit open source.I find that  
   
   for rabbitmq :  when pull message ,will starting muiti threads and then deal 
with message ,so it's cross thead, the trace will broker.
   for spring-rabbit: when pull message ,it's get message info from one thread 
. it's way same with rocketmq.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services