[GitHub] wu-sheng commented on issue #2104: Support spring-rabbit plugin for 1.x and 2.x

2019-01-11 Thread GitBox
wu-sheng commented on issue #2104: Support  spring-rabbit plugin for 1.x and 2.x
URL: 
https://github.com/apache/incubator-skywalking/pull/2104#issuecomment-453459374
 
 
   Any update?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #2104: Support spring-rabbit plugin for 1.x and 2.x

2018-12-31 Thread GitBox
wu-sheng commented on issue #2104: Support  spring-rabbit plugin for 1.x and 2.x
URL: 
https://github.com/apache/incubator-skywalking/pull/2104#issuecomment-450642327
 
 
   @jjlu521016 @WithLin I hope we could provide the single rabbit MQ plugin to 
support in Spring or No-Spring situations, which makes use easier to maintain.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #2104: Support spring-rabbit plugin for 1.x and 2.x

2018-12-31 Thread GitBox
wu-sheng commented on issue #2104: Support  spring-rabbit plugin for 1.x and 2.x
URL: 
https://github.com/apache/incubator-skywalking/pull/2104#issuecomment-450642248
 
 
   > for rabbitmq : when pull message ,will starting muiti threads and then 
deal with message ,so it's cross theads, the trace will broken.
   
   If this happens, may mean our rabbit MQ plugin has bugs. Could you and 
@WithLin work together to solve this? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #2104: Support spring-rabbit plugin for 1.x and 2.x

2018-12-31 Thread GitBox
wu-sheng commented on issue #2104: Support  spring-rabbit plugin for 1.x and 2.x
URL: 
https://github.com/apache/incubator-skywalking/pull/2104#issuecomment-450626699
 
 
   Cc @WithLin #2000 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #2104: Support spring-rabbit plugin for 1.x and 2.x

2018-12-31 Thread GitBox
wu-sheng commented on issue #2104: Support  spring-rabbit plugin for 1.x and 2.x
URL: 
https://github.com/apache/incubator-skywalking/pull/2104#issuecomment-450626533
 
 
   What is the difference between this and rabbit mq plugin? I think we have it 
already.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services