[GitHub] zhaoyuguang commented on issue #2083: Support redisson plugin

2019-01-03 Thread GitBox
zhaoyuguang commented on issue #2083: Support redisson plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-451085085
 
 
   Roger, but I met some difficulties, Mr.@ascrutae  is helping me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] zhaoyuguang commented on issue #2083: Support redisson plugin

2019-01-03 Thread GitBox
zhaoyuguang commented on issue #2083: Support redisson plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-451335309
 
 
   Roger


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] zhaoyuguang commented on issue #2083: Support redisson plugin

2019-01-04 Thread GitBox
zhaoyuguang commented on issue #2083: Support redisson plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-451400155
 
 
   Did not pass the test case version, because there is a problem with the use 
of internal properties when the agent is enhanced, I see if there is a better 
way to be compatible with all versions of 3.x


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] zhaoyuguang commented on issue #2083: Support redisson plugin

2019-01-10 Thread GitBox
zhaoyuguang commented on issue #2083: Support redisson plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453077486
 
 
   Yes~


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] zhaoyuguang commented on issue #2083: Support redisson plugin

2019-01-10 Thread GitBox
zhaoyuguang commented on issue #2083: Support redisson plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453089721
 
 
   Completed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] zhaoyuguang commented on issue #2083: Support redisson plugin

2019-01-11 Thread GitBox
zhaoyuguang commented on issue #2083: Support redisson plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453487349
 
 
   I researched lettuce, lettuce was widely popular after the 5.x version, I 
will try to write a letuce plugin based on the most popular version 
5.1.3.RELEASE.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] zhaoyuguang commented on issue #2083: Support redisson plugin

2019-01-11 Thread GitBox
zhaoyuguang commented on issue #2083: Support redisson plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453500119
 
 
   Yeah~ let me try..


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] zhaoyuguang commented on issue #2083: Support redisson plugin

2019-01-11 Thread GitBox
zhaoyuguang commented on issue #2083: Support redisson plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453518382
 
 
   > Is this plugin only interceptor part that Redssion as easy java redis 
client, and other part is not support? if so, I suggest that you should make 
sense in the doc.
   
   Only intercepted redisson's operation on redis.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] zhaoyuguang commented on issue #2083: Support redisson plugin

2019-01-11 Thread GitBox
zhaoyuguang commented on issue #2083: Support redisson plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453523311
 
 
   > > Only intercepted redisson's operation on redis.
   > 
   > From the official website, https://redisson.org/, it have 7 use cases, 
which all include redis OPs. Are these supported too(If they use Easy Java 
Redis client as basic API, then maybe)?
   > 
   > If not, we may need to change `supported-list` document like this
   > 
   > * [Redisson](https://github.com/redisson/redisson) `Easy Java Redis 
client` 3.5.2+
   
   Well, it is like this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services