Re: [PR] Upgrade netty to 4.1.108 [skywalking]

2024-04-06 Thread via GitHub 


wu-sheng commented on PR #12066:
URL: https://github.com/apache/skywalking/pull/12066#issuecomment-2041080907

   Closing as no update.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Upgrade netty to 4.1.108 [skywalking]

2024-04-06 Thread via GitHub 


wu-sheng closed pull request #12066: Upgrade netty to 4.1.108
URL: https://github.com/apache/skywalking/pull/12066


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Upgrade netty to 4.1.108 [skywalking]

2024-04-02 Thread via GitHub 


wu-sheng commented on PR #12066:
URL: https://github.com/apache/skywalking/pull/12066#issuecomment-2033348909

   If this update is based on CVE fix, you need to fix CI. We have 
skywalking-eyes as CI tool to resolve the dependency versions and license. You 
need to update them accordingly.
   
   ```
   diff --git a/dist-material/release-docs/LICENSE 
b/dist-material/release-docs/LICENSE
   index 1a27f2f..6ddf07c 100644
   --- a/dist-material/release-docs/LICENSE
   +++ b/dist-material/release-docs/LICENSE
   @@ -301,2 +301,2 @@ The text of each license is the standard Apache 2.0 
license.
   -https://mvnrepository.com/artifact/io.netty/netty-buffer/4.1.100.Final 
Apache-2.0
   -https://mvnrepository.com/artifact/io.netty/netty-codec/4.1.100.Final 
Apache-2.0
   +https://mvnrepository.com/artifact/io.netty/netty-buffer/4.1.108.Final 
Apache-2.0
   +https://mvnrepository.com/artifact/io.netty/netty-codec/4.1.108.Final 
Apache-2.0
   @@ -305,6 +305,6 @@ The text of each license is the standard Apache 2.0 
license.
   -
https://mvnrepository.com/artifact/io.netty/netty-codec-http/4.1.100.Final 
Apache-2.0
   -
https://mvnrepository.com/artifact/io.netty/netty-codec-http2/4.1.100.Final 
Apache-2.0
   -
https://mvnrepository.com/artifact/io.netty/netty-codec-socks/4.1.100.Final 
Apache-2.0
   -https://mvnrepository.com/artifact/io.netty/netty-common/4.1.100.Final 
Apache-2.0
   -https://mvnrepository.com/artifact/io.netty/netty-handler/4.1.100.Final 
Apache-2.0
   -
https://mvnrepository.com/artifact/io.netty/netty-handler-proxy/4.1.100.Final 
Apache-2.0
   +
https://mvnrepository.com/artifact/io.netty/netty-codec-http/4.1.108.Final 
Apache-2.0
   +
https://mvnrepository.com/artifact/io.netty/netty-codec-http2/4.1.108.Final 
Apache-2.0
   +
https://mvnrepository.com/artifact/io.netty/netty-codec-socks/4.1.108.Final 
Apache-2.0
   +https://mvnrepository.com/artifact/io.netty/netty-common/4.1.108.Final 
Apache-2.0
   +https://mvnrepository.com/artifact/io.netty/netty-handler/4.1.108.Final 
Apache-2.0
   +
https://mvnrepository.com/artifact/io.netty/netty-handler-proxy/4.1.108.Final 
Apache-2.0
   @@ -315 +315 @@ The text of each license is the standard Apache 2.0 license.
   -
https://mvnrepository.com/artifact/io.netty/netty-tcnative-boringssl-static/2.0.52.Final
 Apache-2.0
   +
https://mvnrepository.com/artifact/io.netty/netty-tcnative-boringssl-static/2.0.65.Final
 Apache-2.0
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Upgrade netty to 4.1.108 [skywalking]

2024-04-02 Thread via GitHub 


wu-sheng commented on PR #12066:
URL: https://github.com/apache/skywalking/pull/12066#issuecomment-2032473804

   Why do we need this update?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] upgrade netty to 4.1.108 [skywalking]

2024-04-02 Thread via GitHub 


sullis opened a new pull request, #12066:
URL: https://github.com/apache/skywalking/pull/12066

   
   
   upgrade Netty to 4.1.108
   
   https://netty.io/news/2024/03/21/4-1-108-Final.html
   
   https://mvnrepository.com/artifact/io.netty/netty-bom/4.1.108.Final
   
   
   
   
   
   
   
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace 
the issue number. Closes #.
   - [ ] Update the [`CHANGES` 
log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org