Re: [PR] Fix inaccurate MongoDB Metrics [skywalking]
wu-sheng commented on PR #12126: URL: https://github.com/apache/skywalking/pull/12126#issuecomment-2062868091 Yes, please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix inaccurate MongoDB Metrics [skywalking]
weixiang1862 commented on PR #12126: URL: https://github.com/apache/skywalking/pull/12126#issuecomment-2062867772 > I suggest adding the label to simplify the name of the metric, otherwise it will show the total expression if it's not a labeled metric. And I found the Nginx dashboards have the same issue. https://private-user-images.githubusercontent.com/16773043/323238511-995a5a51-0397-41de-b224-b397bd482cfb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM0MDY2NzUsIm5iZiI6MTcxMzQwNjM3NSwicGF0aCI6Ii8xNjc3MzA0My8zMjMyMzg1MTEtOTk1YTVhNTEtMDM5Ny00MWRlLWIyMjQtYjM5N2JkNDgyY2ZiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDE4VDAyMTI1NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRiZWRkZTZjOTI2ZDA3NjE0OTU1YjhhMzc2NTNlZjYyZWEwNGMxNDljYTAwODdmYTcxN2IyN2MxODI4MmQ4NDgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19p ZD0wIn0.EUWh-ljM9VQoAxZBhb-x-59VyCe2bXLemE8EmpLZ9HY"> Should I fix nginx dashboard label in this pr too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix inaccurate MongoDB Metrics [skywalking]
weixiang1862 commented on code in PR #12126: URL: https://github.com/apache/skywalking/pull/12126#discussion_r1569806890 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/mongodb/mongodb-cluster.json: ## @@ -231,7 +232,7 @@ "tableHeaderCol2": "" }, "expressions": [ -"meter_mongodb_cluster_db_data_size/1024/1024/1024" +"aggregate_labels(meter_mongodb_cluster_db_data_size, sum(database))/1024/1024/1024" Review Comment: Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix inaccurate MongoDB Metrics [skywalking]
wankai123 commented on code in PR #12126: URL: https://github.com/apache/skywalking/pull/12126#discussion_r1569747463 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/mongodb/mongodb-cluster.json: ## @@ -231,7 +232,7 @@ "tableHeaderCol2": "" }, "expressions": [ -"meter_mongodb_cluster_db_data_size/1024/1024/1024" +"aggregate_labels(meter_mongodb_cluster_db_data_size, sum(database))/1024/1024/1024" Review Comment: suggest using the `latest` or `avg`... function to aggregate values if the widget can't show the time series values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix inaccurate MongoDB Metrics [skywalking]
weixiang1862 commented on PR #12126: URL: https://github.com/apache/skywalking/pull/12126#issuecomment-2061329463 > I suggest adding the label to simplify the name of the metric, otherwise it will show the total expression if it's not a labeled metric. > And I found the Nginx dashboards have the same issue. > https://github.com/apache/skywalking/assets/16773043/995a5a51-0397-41de-b224-b397bd482cfb";> > OK, I will check them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix inaccurate MongoDB Metrics [skywalking]
wankai123 commented on PR #12126: URL: https://github.com/apache/skywalking/pull/12126#issuecomment-2061285245 I suggest adding the label to simplify the name of the metric, otherwise it will show the total expression if it's not a labeled metric. And I found the Nginx dashboards have the same issue. https://github.com/apache/skywalking/assets/16773043/995a5a51-0397-41de-b224-b397bd482cfb";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
