Re: [PR] feat(country-map): Adds Philippines regional map and updates/cleans existing Philippines provincial map [superset]

[via GitHub]

jdruii commented on PR #27933:
URL: https://github.com/apache/superset/pull/27933#issuecomment-2044272649

   Added it. I hope it's okay that I used a different source for the changes 
that I made for the `phiippines.geojson`. The one being generated by the files 
from the Natural Earth Data is just outdated and too messy with the 
inconsistent highly urbanized cities.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Sqllab stuck executing a query [superset]

[via GitHub]

aavanzyl commented on issue #27850:
URL: https://github.com/apache/superset/issues/27850#issuecomment-2044267335

   @michael-s-molina I have deployed 3.1.2 as asked. The issue currently is not 
showing, will monitor for a couple of days and let you know. Thank you for the 
response on my issue. 
   
   For further information, I can see that when clicking on run, it calls the 
`execute` API. This in turn takes a while to respond and was an empty response 
when broken. When things are working as expected, the `execute` API responds 
with a json object. 
   
   I also noticed that the `updated_since` API call started before the 
`execute` had a chance to receive a response, leading me to believe that this 
might contribute to the issue. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] feat: custom refresh frequency [superset]

[via GitHub]

LeoDiep commented on PR #24449:
URL: https://github.com/apache/superset/pull/24449#issuecomment-2044155114

   > Hi all - please direct me to an issue link if there's a separate place for 
questions. We recently adopted Superset and I'm looking into setting up refresh 
schedules for our dashboards. This PR comes close to introducing the feature I 
think we need, but really something with the flexibility like cron schedule 
expressions would be ideal. I haven't been able to understand when the refresh 
interval triggers (i.e. how it's determined when it'll happen) or to specify a 
time it should kick off.
   > 
   > Effectively I just want to specify when my refresh interval should start 
and (based off the time window I choose) when it should stop. Can any help me 
understand this, please?
   
   Hi there,
   cron refresh would be an ideal solution to tell which dashboard should 
refresh all their pages at which time, based on the refresh schedule of 
underneath dataset.
   Hi @rusackas I wonder is it ideal similar to the cache warm up feature, 
could you please take a look at this idea or fix the cache warm up feature, so 
that users will always be able to view the lastest update data without clicking 
into 'Force refresh' on charts or 'Refresh dashboard' on top.
   Thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] feat: new CSV upload form and API [superset]

[via GitHub]

mistercrunch commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1556624571


##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { FunctionComponent, useEffect, useMemo, useState } from 'react';
+import {
+  getClientErrorObject,
+  SupersetClient,
+  SupersetTheme,
+  t,
+} from '@superset-ui/core';
+import Modal from 'src/components/Modal';
+import Collapse from 'src/components/Collapse';
+import {
+  Upload,
+  AntdForm,
+  Col,
+  Row,
+  AntdButton as Button,
+  AsyncSelect,
+  Select,
+  Typography,
+} from 'src/components';
+import { Divider, Switch } from 'antd';
+import { UploadOutlined } from '@ant-design/icons';
+import { Input, InputNumber } from 'src/components/Input';
+import rison from 'rison';
+import { UploadChangeParam, UploadFile } from 'antd/lib/upload/interface';
+import withToasts from 'src/components/MessageToasts/withToasts';
+import {
+  antDModalStyles,
+  antDModalNoPaddingStyles,
+  antdCollapseStyles,
+  StyledFormItem,
+} from './styles';
+
+interface CSVUploadModalProps {
+  addDangerToast: (msg: string) => void;
+  addSuccessToast: (msg: string) => void;
+  onHide: () => void;
+  show: boolean;
+}
+
+interface UploadInfo {
+  database_id: number;
+  table_name: string;
+  schema: string;
+  delimiter: string;
+  already_exists: string;
+  skip_initial_space: boolean;
+  skip_blank_lines: boolean;
+  day_first: boolean;
+  decimal_character: string;
+  null_values: Array;
+  header_row: string;
+  rows_to_read: string | null;
+  skip_rows: string;
+  column_dates: Array;
+  index_column: string | null;
+  dataframe_index: boolean;
+  column_labels: string;
+  columns_read: Array;
+  overwrite_duplicates: boolean;
+  column_data_types: string;
+}
+
+const defaultUploadInfo: UploadInfo = {
+  database_id: 0,
+  table_name: '',
+  schema: '',
+  delimiter: ',',
+  already_exists: 'fail',
+  skip_initial_space: false,
+  skip_blank_lines: false,
+  day_first: false,
+  decimal_character: '.',
+  null_values: [],
+  header_row: '0',
+  rows_to_read: null,
+  skip_rows: '0',
+  column_dates: [],
+  index_column: null,
+  dataframe_index: false,
+  column_labels: '',
+  columns_read: [],
+  overwrite_duplicates: false,
+  column_data_types: '',
+};
+
+const CSVUploadModal: FunctionComponent = ({
+  addDangerToast,
+  addSuccessToast,
+  onHide,
+  show,
+}) => {
+  const [form] = AntdForm.useForm();
+  // Declare states here
+  const [currentDatabaseId, setCurrentDatabaseId] = useState(0);
+  const [fileList, setFileList] = useState([]);
+  const [columns, setColumns] = React.useState([]);
+  const [delimiter, setDelimiter] = useState(',');
+  const [isLoading, setIsLoading] = useState(false);
+  const [currentSchema, setCurrentSchema] = useState('');
+
+  const nullValuesOptions = [
+{
+  value: '""',
+  label: 'Empty Strings ""',
+},
+{
+  value: 'None',
+  label: 'None',
+},
+{
+  value: 'nan',
+  label: 'nan',
+},
+{
+  value: 'null',
+  label: 'null',
+},
+{
+  value: 'N/A',
+  label: 'N/A',
+},
+  ];
+
+  const delimiterOptions = [
+{
+  value: ',',
+  label: 'Comma ","',
+},
+{
+  value: ';',
+  label: 'Semicolon ";"',
+},
+{
+  value: '\t',
+  label: 'Tab "\\t"',
+},
+{
+  value: '|',
+  label: 'Pipe',
+},
+  ];
+
+  const tableAlreadyExistsOptions = [
+{
+  value: 'fail',
+  label: 'Fail',
+},
+{
+  value: 'replace',
+  label: 'Replace',
+},
+{
+  value: 'append',
+  label: 'Append',
+},
+  ];
+
+  const onChangeDatabase = (database: { value: number; label: string }) => {
+setCurrentDatabaseId(database?.value);
+  };
+
+  const onChangeSchema = (schema: { value: string; label: string }) => {
+setCurrentSchema(schema?.value);
+  };
+
+  const onChangeDelimiter = (value: string) => {
+setDelimiter(value);
+  };
+
+  const clearModal = () => {
+setFileList([]);
+setColumns([]);
+setCurrentSchema('');
+setCurrentDatabaseId(0);
+setIs

Re: [PR] fix: improve change detection for GHAs [superset]

[via GitHub]

mistercrunch merged PR #27904:
URL: https://github.com/apache/superset/pull/27904


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] fix: improve change detection for GHAs [superset]

[via GitHub]

mistercrunch commented on PR #27904:
URL: https://github.com/apache/superset/pull/27904#issuecomment-2043816211

   I'll merge since we had 3 reviewers looking into this one so far. I will be 
monitoring `master` and upcoming PRs to make sure the right jobs are ran or 
skipped.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] feat: new CSV upload form and API [superset]

[via GitHub]

yousoph commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1556499783


##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { FunctionComponent, useEffect, useMemo, useState } from 'react';
+import {
+  getClientErrorObject,
+  SupersetClient,
+  SupersetTheme,
+  t,
+} from '@superset-ui/core';
+import Modal from 'src/components/Modal';
+import Collapse from 'src/components/Collapse';
+import {
+  Upload,
+  AntdForm,
+  Col,
+  Row,
+  AntdButton as Button,
+  AsyncSelect,
+  Select,
+  Typography,
+} from 'src/components';
+import { Divider, Switch } from 'antd';
+import { UploadOutlined } from '@ant-design/icons';
+import { Input, InputNumber } from 'src/components/Input';
+import rison from 'rison';
+import { UploadChangeParam, UploadFile } from 'antd/lib/upload/interface';
+import withToasts from 'src/components/MessageToasts/withToasts';
+import {
+  antDModalStyles,
+  antDModalNoPaddingStyles,
+  antdCollapseStyles,
+  StyledFormItem,
+} from './styles';
+
+interface CSVUploadModalProps {
+  addDangerToast: (msg: string) => void;
+  addSuccessToast: (msg: string) => void;
+  onHide: () => void;
+  show: boolean;
+}
+
+interface UploadInfo {
+  database_id: number;
+  table_name: string;
+  schema: string;
+  delimiter: string;
+  already_exists: string;
+  skip_initial_space: boolean;
+  skip_blank_lines: boolean;
+  day_first: boolean;
+  decimal_character: string;
+  null_values: Array;
+  header_row: string;
+  rows_to_read: string | null;
+  skip_rows: string;
+  column_dates: Array;
+  index_column: string | null;
+  dataframe_index: boolean;
+  column_labels: string;
+  columns_read: Array;
+  overwrite_duplicates: boolean;
+  column_data_types: string;
+}
+
+const defaultUploadInfo: UploadInfo = {
+  database_id: 0,
+  table_name: '',
+  schema: '',
+  delimiter: ',',
+  already_exists: 'fail',
+  skip_initial_space: false,
+  skip_blank_lines: false,
+  day_first: false,
+  decimal_character: '.',
+  null_values: [],
+  header_row: '0',
+  rows_to_read: null,
+  skip_rows: '0',
+  column_dates: [],
+  index_column: null,
+  dataframe_index: false,
+  column_labels: '',
+  columns_read: [],
+  overwrite_duplicates: false,
+  column_data_types: '',
+};
+
+const CSVUploadModal: FunctionComponent = ({
+  addDangerToast,
+  addSuccessToast,
+  onHide,
+  show,
+}) => {
+  const [form] = AntdForm.useForm();
+  // Declare states here
+  const [currentDatabaseId, setCurrentDatabaseId] = useState(0);
+  const [fileList, setFileList] = useState([]);
+  const [columns, setColumns] = React.useState([]);
+  const [delimiter, setDelimiter] = useState(',');
+  const [isLoading, setIsLoading] = useState(false);
+  const [currentSchema, setCurrentSchema] = useState('');
+
+  const nullValuesOptions = [
+{
+  value: '""',
+  label: 'Empty Strings ""',
+},
+{
+  value: 'None',
+  label: 'None',
+},
+{
+  value: 'nan',
+  label: 'nan',
+},
+{
+  value: 'null',
+  label: 'null',
+},
+{
+  value: 'N/A',
+  label: 'N/A',
+},
+  ];
+
+  const delimiterOptions = [
+{
+  value: ',',
+  label: 'Comma ","',
+},
+{
+  value: ';',
+  label: 'Semicolon ";"',
+},
+{
+  value: '\t',
+  label: 'Tab "\\t"',
+},
+{
+  value: '|',
+  label: 'Pipe',
+},
+  ];
+
+  const tableAlreadyExistsOptions = [
+{
+  value: 'fail',
+  label: 'Fail',
+},
+{
+  value: 'replace',
+  label: 'Replace',
+},
+{
+  value: 'append',
+  label: 'Append',
+},
+  ];
+
+  const onChangeDatabase = (database: { value: number; label: string }) => {
+setCurrentDatabaseId(database?.value);
+  };
+
+  const onChangeSchema = (schema: { value: string; label: string }) => {
+setCurrentSchema(schema?.value);
+  };
+
+  const onChangeDelimiter = (value: string) => {
+setDelimiter(value);
+  };
+
+  const clearModal = () => {
+setFileList([]);
+setColumns([]);
+setCurrentSchema('');
+setCurrentDatabaseId(0);
+setIsLoadi

Re: [PR] feat: new CSV upload form and API [superset]

[via GitHub]

yousoph commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1556499378


##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { FunctionComponent, useEffect, useMemo, useState } from 'react';
+import {
+  getClientErrorObject,
+  SupersetClient,
+  SupersetTheme,
+  t,
+} from '@superset-ui/core';
+import Modal from 'src/components/Modal';
+import Collapse from 'src/components/Collapse';
+import {
+  Upload,
+  AntdForm,
+  Col,
+  Row,
+  AntdButton as Button,
+  AsyncSelect,
+  Select,
+  Typography,
+} from 'src/components';
+import { Divider, Switch } from 'antd';
+import { UploadOutlined } from '@ant-design/icons';
+import { Input, InputNumber } from 'src/components/Input';
+import rison from 'rison';
+import { UploadChangeParam, UploadFile } from 'antd/lib/upload/interface';
+import withToasts from 'src/components/MessageToasts/withToasts';
+import {
+  antDModalStyles,
+  antDModalNoPaddingStyles,
+  antdCollapseStyles,
+  StyledFormItem,
+} from './styles';
+
+interface CSVUploadModalProps {
+  addDangerToast: (msg: string) => void;
+  addSuccessToast: (msg: string) => void;
+  onHide: () => void;
+  show: boolean;
+}
+
+interface UploadInfo {
+  database_id: number;
+  table_name: string;
+  schema: string;
+  delimiter: string;
+  already_exists: string;
+  skip_initial_space: boolean;
+  skip_blank_lines: boolean;
+  day_first: boolean;
+  decimal_character: string;
+  null_values: Array;
+  header_row: string;
+  rows_to_read: string | null;
+  skip_rows: string;
+  column_dates: Array;
+  index_column: string | null;
+  dataframe_index: boolean;
+  column_labels: string;
+  columns_read: Array;
+  overwrite_duplicates: boolean;
+  column_data_types: string;
+}
+
+const defaultUploadInfo: UploadInfo = {
+  database_id: 0,
+  table_name: '',
+  schema: '',
+  delimiter: ',',
+  already_exists: 'fail',
+  skip_initial_space: false,
+  skip_blank_lines: false,
+  day_first: false,
+  decimal_character: '.',
+  null_values: [],
+  header_row: '0',
+  rows_to_read: null,
+  skip_rows: '0',
+  column_dates: [],
+  index_column: null,
+  dataframe_index: false,
+  column_labels: '',
+  columns_read: [],
+  overwrite_duplicates: false,
+  column_data_types: '',
+};
+
+const CSVUploadModal: FunctionComponent = ({
+  addDangerToast,
+  addSuccessToast,
+  onHide,
+  show,
+}) => {
+  const [form] = AntdForm.useForm();
+  // Declare states here
+  const [currentDatabaseId, setCurrentDatabaseId] = useState(0);
+  const [fileList, setFileList] = useState([]);
+  const [columns, setColumns] = React.useState([]);
+  const [delimiter, setDelimiter] = useState(',');
+  const [isLoading, setIsLoading] = useState(false);
+  const [currentSchema, setCurrentSchema] = useState('');
+
+  const nullValuesOptions = [
+{
+  value: '""',
+  label: 'Empty Strings ""',
+},
+{
+  value: 'None',
+  label: 'None',
+},
+{
+  value: 'nan',
+  label: 'nan',
+},
+{
+  value: 'null',
+  label: 'null',
+},
+{
+  value: 'N/A',
+  label: 'N/A',
+},
+  ];
+
+  const delimiterOptions = [
+{
+  value: ',',
+  label: 'Comma ","',
+},
+{
+  value: ';',
+  label: 'Semicolon ";"',
+},
+{
+  value: '\t',
+  label: 'Tab "\\t"',
+},
+{
+  value: '|',
+  label: 'Pipe',
+},
+  ];
+
+  const tableAlreadyExistsOptions = [
+{
+  value: 'fail',
+  label: 'Fail',
+},
+{
+  value: 'replace',
+  label: 'Replace',
+},
+{
+  value: 'append',
+  label: 'Append',
+},
+  ];
+
+  const onChangeDatabase = (database: { value: number; label: string }) => {
+setCurrentDatabaseId(database?.value);
+  };
+
+  const onChangeSchema = (schema: { value: string; label: string }) => {
+setCurrentSchema(schema?.value);
+  };
+
+  const onChangeDelimiter = (value: string) => {
+setDelimiter(value);
+  };
+
+  const clearModal = () => {
+setFileList([]);
+setColumns([]);
+setCurrentSchema('');
+setCurrentDatabaseId(0);
+setIsLoadi

Re: [PR] feat: new CSV upload form and API [superset]

[via GitHub]

yousoph commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1556498542


##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { FunctionComponent, useEffect, useMemo, useState } from 'react';
+import {
+  getClientErrorObject,
+  SupersetClient,
+  SupersetTheme,
+  t,
+} from '@superset-ui/core';
+import Modal from 'src/components/Modal';
+import Collapse from 'src/components/Collapse';
+import {
+  Upload,
+  AntdForm,
+  Col,
+  Row,
+  AntdButton as Button,
+  AsyncSelect,
+  Select,
+  Typography,
+} from 'src/components';
+import { Divider, Switch } from 'antd';
+import { UploadOutlined } from '@ant-design/icons';
+import { Input, InputNumber } from 'src/components/Input';
+import rison from 'rison';
+import { UploadChangeParam, UploadFile } from 'antd/lib/upload/interface';
+import withToasts from 'src/components/MessageToasts/withToasts';
+import {
+  antDModalStyles,
+  antDModalNoPaddingStyles,
+  antdCollapseStyles,
+  StyledFormItem,
+} from './styles';
+
+interface CSVUploadModalProps {
+  addDangerToast: (msg: string) => void;
+  addSuccessToast: (msg: string) => void;
+  onHide: () => void;
+  show: boolean;
+}
+
+interface UploadInfo {
+  database_id: number;
+  table_name: string;
+  schema: string;
+  delimiter: string;
+  already_exists: string;
+  skip_initial_space: boolean;
+  skip_blank_lines: boolean;
+  day_first: boolean;
+  decimal_character: string;
+  null_values: Array;
+  header_row: string;
+  rows_to_read: string | null;
+  skip_rows: string;
+  column_dates: Array;
+  index_column: string | null;
+  dataframe_index: boolean;
+  column_labels: string;
+  columns_read: Array;
+  overwrite_duplicates: boolean;
+  column_data_types: string;
+}
+
+const defaultUploadInfo: UploadInfo = {
+  database_id: 0,
+  table_name: '',
+  schema: '',
+  delimiter: ',',
+  already_exists: 'fail',
+  skip_initial_space: false,
+  skip_blank_lines: false,
+  day_first: false,
+  decimal_character: '.',
+  null_values: [],
+  header_row: '0',
+  rows_to_read: null,
+  skip_rows: '0',
+  column_dates: [],
+  index_column: null,
+  dataframe_index: false,
+  column_labels: '',
+  columns_read: [],
+  overwrite_duplicates: false,
+  column_data_types: '',
+};
+
+const CSVUploadModal: FunctionComponent = ({
+  addDangerToast,
+  addSuccessToast,
+  onHide,
+  show,
+}) => {
+  const [form] = AntdForm.useForm();
+  // Declare states here
+  const [currentDatabaseId, setCurrentDatabaseId] = useState(0);
+  const [fileList, setFileList] = useState([]);
+  const [columns, setColumns] = React.useState([]);
+  const [delimiter, setDelimiter] = useState(',');
+  const [isLoading, setIsLoading] = useState(false);
+  const [currentSchema, setCurrentSchema] = useState('');
+
+  const nullValuesOptions = [
+{
+  value: '""',
+  label: 'Empty Strings ""',
+},
+{
+  value: 'None',
+  label: 'None',
+},
+{
+  value: 'nan',
+  label: 'nan',
+},
+{
+  value: 'null',
+  label: 'null',
+},
+{
+  value: 'N/A',
+  label: 'N/A',
+},
+  ];
+
+  const delimiterOptions = [
+{
+  value: ',',
+  label: 'Comma ","',
+},
+{
+  value: ';',
+  label: 'Semicolon ";"',
+},
+{
+  value: '\t',
+  label: 'Tab "\\t"',
+},
+{
+  value: '|',
+  label: 'Pipe',
+},
+  ];
+
+  const tableAlreadyExistsOptions = [
+{
+  value: 'fail',
+  label: 'Fail',
+},
+{
+  value: 'replace',
+  label: 'Replace',
+},
+{
+  value: 'append',
+  label: 'Append',
+},
+  ];
+
+  const onChangeDatabase = (database: { value: number; label: string }) => {
+setCurrentDatabaseId(database?.value);
+  };
+
+  const onChangeSchema = (schema: { value: string; label: string }) => {
+setCurrentSchema(schema?.value);
+  };
+
+  const onChangeDelimiter = (value: string) => {
+setDelimiter(value);
+  };
+
+  const clearModal = () => {
+setFileList([]);
+setColumns([]);
+setCurrentSchema('');
+setCurrentDatabaseId(0);
+setIsLoadi

Re: [PR] feat: new CSV upload form and API [superset]

[via GitHub]

yousoph commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1556493843


##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { FunctionComponent, useEffect, useMemo, useState } from 'react';
+import {
+  getClientErrorObject,
+  SupersetClient,
+  SupersetTheme,
+  t,
+} from '@superset-ui/core';
+import Modal from 'src/components/Modal';
+import Collapse from 'src/components/Collapse';
+import {
+  Upload,
+  AntdForm,
+  Col,
+  Row,
+  AntdButton as Button,
+  AsyncSelect,
+  Select,
+  Typography,
+} from 'src/components';
+import { Divider, Switch } from 'antd';
+import { UploadOutlined } from '@ant-design/icons';
+import { Input, InputNumber } from 'src/components/Input';
+import rison from 'rison';
+import { UploadChangeParam, UploadFile } from 'antd/lib/upload/interface';
+import withToasts from 'src/components/MessageToasts/withToasts';
+import {
+  antDModalStyles,
+  antDModalNoPaddingStyles,
+  antdCollapseStyles,
+  StyledFormItem,
+} from './styles';
+
+interface CSVUploadModalProps {
+  addDangerToast: (msg: string) => void;
+  addSuccessToast: (msg: string) => void;
+  onHide: () => void;
+  show: boolean;
+}
+
+interface UploadInfo {
+  database_id: number;
+  table_name: string;
+  schema: string;
+  delimiter: string;
+  already_exists: string;
+  skip_initial_space: boolean;
+  skip_blank_lines: boolean;
+  day_first: boolean;
+  decimal_character: string;
+  null_values: Array;
+  header_row: string;
+  rows_to_read: string | null;
+  skip_rows: string;
+  column_dates: Array;
+  index_column: string | null;
+  dataframe_index: boolean;
+  column_labels: string;
+  columns_read: Array;
+  overwrite_duplicates: boolean;
+  column_data_types: string;
+}
+
+const defaultUploadInfo: UploadInfo = {
+  database_id: 0,
+  table_name: '',
+  schema: '',
+  delimiter: ',',
+  already_exists: 'fail',
+  skip_initial_space: false,
+  skip_blank_lines: false,
+  day_first: false,
+  decimal_character: '.',
+  null_values: [],
+  header_row: '0',
+  rows_to_read: null,
+  skip_rows: '0',
+  column_dates: [],
+  index_column: null,
+  dataframe_index: false,
+  column_labels: '',
+  columns_read: [],
+  overwrite_duplicates: false,
+  column_data_types: '',
+};
+
+const CSVUploadModal: FunctionComponent = ({
+  addDangerToast,
+  addSuccessToast,
+  onHide,
+  show,
+}) => {
+  const [form] = AntdForm.useForm();
+  // Declare states here
+  const [currentDatabaseId, setCurrentDatabaseId] = useState(0);
+  const [fileList, setFileList] = useState([]);
+  const [columns, setColumns] = React.useState([]);
+  const [delimiter, setDelimiter] = useState(',');
+  const [isLoading, setIsLoading] = useState(false);
+  const [currentSchema, setCurrentSchema] = useState('');
+
+  const nullValuesOptions = [
+{
+  value: '""',
+  label: 'Empty Strings ""',
+},
+{
+  value: 'None',
+  label: 'None',
+},
+{
+  value: 'nan',
+  label: 'nan',
+},
+{
+  value: 'null',
+  label: 'null',
+},
+{
+  value: 'N/A',
+  label: 'N/A',
+},
+  ];
+
+  const delimiterOptions = [
+{
+  value: ',',
+  label: 'Comma ","',
+},
+{
+  value: ';',
+  label: 'Semicolon ";"',
+},
+{
+  value: '\t',
+  label: 'Tab "\\t"',
+},
+{
+  value: '|',
+  label: 'Pipe',
+},
+  ];
+
+  const tableAlreadyExistsOptions = [
+{
+  value: 'fail',
+  label: 'Fail',
+},
+{
+  value: 'replace',
+  label: 'Replace',
+},
+{
+  value: 'append',
+  label: 'Append',
+},
+  ];
+
+  const onChangeDatabase = (database: { value: number; label: string }) => {
+setCurrentDatabaseId(database?.value);
+  };
+
+  const onChangeSchema = (schema: { value: string; label: string }) => {
+setCurrentSchema(schema?.value);
+  };
+
+  const onChangeDelimiter = (value: string) => {
+setDelimiter(value);
+  };
+
+  const clearModal = () => {
+setFileList([]);
+setColumns([]);
+setCurrentSchema('');
+setCurrentDatabaseId(0);
+setIsLoadi

Re: [PR] feat: new CSV upload form and API [superset]

[via GitHub]

yousoph commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1556492195


##
superset/commands/database/csv_import.py:
##
@@ -0,0 +1,164 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import logging
+from typing import Any, Optional, TypedDict
+
+import pandas as pd
+from flask_babel import lazy_gettext as _
+from sqlalchemy.exc import SQLAlchemyError
+
+from superset import db
+from superset.commands.base import BaseCommand
+from superset.commands.database.exceptions import (
+DatabaseNotFoundError,
+DatabaseSchemaUploadNotAllowed,
+DatabaseUploadFailed,
+)
+from superset.connectors.sqla.models import SqlaTable
+from superset.daos.database import DatabaseDAO
+from superset.models.core import Database
+from superset.sql_parse import Table
+from superset.utils.core import get_user
+from superset.views.database.validators import schema_allows_file_upload
+
+logger = logging.getLogger(__name__)
+
+READ_CSV_CHUNK_SIZE = 1000
+
+
+class CSVImportOptions(TypedDict, total=False):
+schema: str
+delimiter: str
+already_exists: str
+column_data_types: dict[str, str]
+column_dates: list[str]
+column_labels: str
+columns_read: list[str]
+dataframe_index: str
+day_first: bool
+decimal_character: str
+header_row: int
+index_column: str
+null_values: list[str]
+overwrite_duplicates: bool
+rows_to_read: int
+skip_blank_lines: bool
+skip_initial_space: bool
+skip_rows: bool
+
+
+class CSVImportCommand(BaseCommand):
+def __init__(
+self,
+model_id: int,
+table_name: str,
+file: Any,
+options: CSVImportOptions,
+) -> None:
+self._model_id = model_id
+self._model: Optional[Database] = None
+self._table_name = table_name
+self._schema = options.get("schema")
+self._file = file
+self._options = options
+
+def run(self) -> None:
+self.validate()
+if not self._model:
+return
+try:
+df = pd.concat(
+pd.read_csv(
+chunksize=READ_CSV_CHUNK_SIZE,
+encoding="utf-8",
+filepath_or_buffer=self._file,
+header=self._options.get("header_row", 0),
+index_col=self._options.get("index_column"),
+dayfirst=self._options.get("day_first", False),
+iterator=True,
+keep_default_na=not self._options.get("null_values"),
+usecols=self._options.get("columns_read")
+if self._options.get("columns_read")
+else None,
+na_values=self._options.get("null_values")
+if self._options.get("null_values")
+else None,
+nrows=self._options.get("rows_to_read"),
+parse_dates=self._options.get("column_dates"),
+sep=self._options.get("delimiter", ","),
+skip_blank_lines=self._options.get("skip_blank_lines", 
False),
+skipinitialspace=self._options.get("skip_initial_space", 
False),
+skiprows=self._options.get("skip_rows", 0),
+dtype=self._options.get("column_data_types")
+if self._options.get("column_data_types")
+else {},
+)
+)
+csv_table = Table(table=self._table_name, schema=self._schema)
+self._model.db_engine_spec.df_to_sql(
+self._model,
+csv_table,
+df,
+to_sql_kwargs={
+"chunksize": READ_CSV_CHUNK_SIZE,
+"if_exists": self._options.get("already_exists", "fail"),
+"index": self._options.get("index_column"),
+"index_label": self._options.get("column_labels"),
+},
+)
+except ValueError as ex:
+raise DatabaseUploadFailed(
+message=_(
+"Table already exists. You can change your"
+   

Re: [PR] chore(AlteredSliceTag): Migrate to functional [superset]

[via GitHub]

github-actions[bot] commented on PR #27891:
URL: https://github.com/apache/superset/pull/27891#issuecomment-2043743246

   @eschutho Ephemeral environment spinning up at http://34.221.90.24:8080. 
Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping 
and startup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] chore: [bot] Run grit migration: Class to Functional - AlteredSliceTag [superset]

[via GitHub]

eschutho closed pull request #26155: chore: [bot] Run grit migration: Class to 
Functional - AlteredSliceTag
URL: https://github.com/apache/superset/pull/26155


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] chore(AlteredSliceTag): Migrate to functional [superset]

[via GitHub]

eschutho commented on PR #27891:
URL: https://github.com/apache/superset/pull/27891#issuecomment-2043734482

   /testenv up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Helm chart installation times out and starts to consume huge amount of CPU [superset]

[via GitHub]

margorczynski commented on issue #27931:
URL: https://github.com/apache/superset/issues/27931#issuecomment-2043724968

   Update: Now the install fails as follows:
   
   
![image](https://github.com/apache/superset/assets/1714491/a181dff3-8c2f-4283-a7c9-72cc9a71b11b)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[PR] feat: improve event logging for queries + refactor [superset]

[via GitHub]

mistercrunch opened a new pull request, #27943:
URL: https://github.com/apache/superset/pull/27943

   ### SUMMARY
   
   The driver for this PR was to enrich event logging around database engine 
and database drivers for events that interact directly with analytics databases.
   
   Digging a bit into the logging code:
   - I realized that `request.form` is empty when pushing JSON payload, and
 `request.json` should be used. This should automatically capture more
 automated logging that parses context out of the request object
 proactively
   - Adding an event `execute_sql` that targets just that, that **isn't**
 called when hitting the cache for instance. Using the context manager
 insures capturing the duration of the call as well.
   - a bit of refactor here and there
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] 2 spaces for permission "can import on ImportExportRestApi" [superset]

[via GitHub]

rusackas commented on issue #26055:
URL: https://github.com/apache/superset/issues/26055#issuecomment-2043691735

   This doesn't seem to be the case in current versions anymore. Not sure when 
it was fixed, but it's fixed! :D 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] 2 spaces for permission "can import on ImportExportRestApi" [superset]

[via GitHub]

rusackas closed issue #26055: 2 spaces for permission "can import  on 
ImportExportRestApi"
URL: https://github.com/apache/superset/issues/26055


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Datetime is late on Action log [superset]

[via GitHub]

rusackas commented on issue #26054:
URL: https://github.com/apache/superset/issues/26054#issuecomment-2043685845

   Sorry, this doesn't seem like enough to go on. I'm not sure how we can tell 
from the screenshot that the timestamps are wrong. Do you have any indication 
(the logs themselves, or something) that shows a discrepancy? Is this just a 
timezone issue or something? Note that Superset is generally in UTC time. Let 
us know if you're still facing this, and we'll see what we can do. Note that 
we're generally just supporting Superset 3.1/4.0 going forward. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Issue 1035 error Failed to start remote query on a worker. [superset]

[via GitHub]

rusackas commented on issue #26050:
URL: https://github.com/apache/superset/issues/26050#issuecomment-2043678969

   I'm not sure if this is still an issue in current versions of Superset 
(3.x). If it is, we can re-open this, or feel free to open a new issue with 
updated context and a reproducible case using example data. We're no longer 
supporting Superset 2.x or prior, and it's been a while since this thread saw 
any activity, so I'm closing this as stale.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] refactor(pinot) regression on area chart (DB engine error) [superset]

[via GitHub]

rusackas commented on issue #25749:
URL: https://github.com/apache/superset/issues/25749#issuecomment-2043678000

   Agreed. I'll be optimistic here and just close this one. If @martin-raymond 
is still facing this issue, we can revisit and/or reopen as necessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] refactor(pinot) regression on area chart (DB engine error) [superset]

[via GitHub]

rusackas closed issue #25749: refactor(pinot) regression on area chart (DB 
engine error)
URL: https://github.com/apache/superset/issues/25749


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Issue 1035 error Failed to start remote query on a worker. [superset]

[via GitHub]

rusackas closed issue #26050: Issue 1035 error Failed to start remote query on 
a worker.
URL: https://github.com/apache/superset/issues/26050


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Issue with creating a external table with a table name containing spaces. [superset]

[via GitHub]

rusackas closed issue #26047: Issue with creating a external table with a table 
name containing spaces.
URL: https://github.com/apache/superset/issues/26047


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Issue with creating a external table with a table name containing spaces. [superset]

[via GitHub]

rusackas commented on issue #26047:
URL: https://github.com/apache/superset/issues/26047#issuecomment-2043676772

   @AjayEstuate Can you give us more details of how you're connecting to Spark. 
Are you using Hive like 
[this](https://superset.apache.org/docs/databases/spark-sql/)? Closing this 
because it's gone silent for so long, but if you still have the problem and can 
provide more details (logs/errors/etc) we might be able to help debug further. 
Also wondering if this is magically fixed in currently supported versions of 
Superset (3.1/4.0). Given all of that, we're happy to reopen this if needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Unable to read HANA tables containing a "/" [superset]

[via GitHub]

rusackas commented on issue #26032:
URL: https://github.com/apache/superset/issues/26032#issuecomment-2043672116

   @mennereau are you still facing this? I'm wondering if it's somehow hana 
specific, since this thread is effectively stale and we haven't heard any 
complaints following that PR being merged. I'll close it for now, but we can 
reopen if you're still seeing it in 3.1/4.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Unable to read HANA tables containing a "/" [superset]

[via GitHub]

rusackas closed issue #26032: Unable to read HANA tables containing a "/"
URL: https://github.com/apache/superset/issues/26032


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] refactor(pinot) regression on area chart (DB engine error) [superset]

[via GitHub]

zhaoyongjie commented on issue #25749:
URL: https://github.com/apache/superset/issues/25749#issuecomment-2043657177

   Hi Evan, we are using Superset 3.1 and Pinot stable version on the
   Production environment, the corresponding query works well, so if no more
   issues are reported, might close this one.
   
   
   
   On Mon 8. Apr 2024 at 22:58, Evan Rusackas ***@***.***> wrote:
   
   > It's been quite a while since this thread was revisited, but it's one of
   > the best support threads I've read on here in a long time! @martin-raymond
   >  are you still up against this, and
   > @zhaoyongjie  do you have any new
   > theories? I'm wondering if this is still an issue in Superset 3.1 / 4.0. If
   > there is a faulty query being generated, maybe you can share what it looks
   > like now?
   >
   > —
   > Reply to this email directly, view it on GitHub
   > ,
   > or unsubscribe
   > 

   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   -- 
   
   Best regards,
   
   Yongjie
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] @superset-ui/core and @superset-ui/chart-controls npm packages not up to date. [superset]

[via GitHub]

frassinier commented on issue #22843:
URL: https://github.com/apache/superset/issues/22843#issuecomment-2043637488

   Hello team,
   
   What steps are needed to publish the packages again? 
   Is this achievable using the GitHub Actions? 
   How can we assist with this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Ambiguous Error while embedding dashboard [superset]

[via GitHub]

rusackas commented on issue #25955:
URL: https://github.com/apache/superset/issues/25955#issuecomment-2043635593

   Assuming setting CORS options worked out, since this thread seems to have 
gone stale. Optimistically closing. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Ambiguous Error while embedding dashboard [superset]

[via GitHub]

rusackas closed issue #25955: Ambiguous Error while embedding dashboard 
URL: https://github.com/apache/superset/issues/25955


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] OAUTH users not getting the login again screen when the OAUTH PROVIDERS user password reset or token invoked. [superset]

[via GitHub]

rusackas commented on issue #25904:
URL: https://github.com/apache/superset/issues/25904#issuecomment-2043634534

   @thanushcst are you still facing this? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] refactor(pinot) regression on area chart (DB engine error) [superset]

[via GitHub]

rusackas commented on issue #25749:
URL: https://github.com/apache/superset/issues/25749#issuecomment-2043630225

   It's been quite a while since this thread was revisited, but it's one of the 
best support threads I've read on here in a long time! @martin-raymond are you 
still up against this, and @zhaoyongjie do you have any new theories? I'm 
wondering if this is still an issue in Superset 3.1 / 4.0. If there is a faulty 
query being generated, maybe you can share what it looks like now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] MetaDatabase password Connection string is not encoded (special char escaping) (sqlalchemy uri) [superset]

[via GitHub]

rusackas commented on issue #25501:
URL: https://github.com/apache/superset/issues/25501#issuecomment-2043620019

   BTW, not sure, but there may be some crossover with [this 
issue](https://github.com/apache/superset/issues/27764) somewhere along the 
line.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] MetaDatabase password Connection string is not encoded (special char escaping) (sqlalchemy uri) [superset]

[via GitHub]

rusackas commented on issue #25501:
URL: https://github.com/apache/superset/issues/25501#issuecomment-2043618566

   Looks like we're still trying to get this PR across the line. Hopefully it's 
very close! Thanks @ramki88 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] fix(migration): Support non-alphanumeric passwords in alembic. [superset]

[via GitHub]

rusackas commented on PR #26094:
URL: https://github.com/apache/superset/pull/26094#issuecomment-2043616530

   @ramki88 would you mind running the [pre-commit 
hooks](https://superset.apache.org/docs/contributing/hooks-and-linting/) on 
this so it can pass CI/linting?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] fix(docs): CSP mods to re-enable Algolia search [superset]

[via GitHub]

rusackas merged PR #27942:
URL: https://github.com/apache/superset/pull/27942


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] feat: new CSV upload form and API [superset]

[via GitHub]

michael-s-molina commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1556355099


##
superset-frontend/src/features/databases/CSVUploadModal/index.test.tsx:
##
@@ -0,0 +1,330 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import fetchMock from 'fetch-mock';
+import CSVUploadModal from 'src/features/databases/CSVUploadModal';
+import { act, cleanup, render, screen } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import { waitFor } from '@testing-library/react';
+
+fetchMock.post('glob:*api/v1/database/1/csv_upload/', {});
+
+fetchMock.get(
+  
'glob:*api/v1/database/?q=(filters:!((col:allow_file_upload,opr:eq,value:!t)),page:0,page_size:100)',
+  {
+result: [
+  {
+id: 1,
+database_name: 'database1',
+  },
+  {
+id: 2,
+database_name: 'database2',
+  },
+],
+  },
+);
+
+fetchMock.get('glob:*api/v1/database/1/schemas/', {
+  result: ['information_schema', 'public'],
+});
+
+fetchMock.get('glob:*api/v1/database/2/schemas/', {
+  result: ['schema1', 'schema2'],
+});
+
+const csvProps = {
+  show: true,
+  onHide: () => {},
+};
+
+describe('CSVUploadModal', () => {

Review Comment:
   Could you avoid using `describe` here and just use `test`?



##
superset-frontend/src/features/databases/CSVUploadModal/index.test.tsx:
##
@@ -0,0 +1,330 @@
+/**

Review Comment:
   Following our other components, the test should be named 
`CSVUploadModalTest.test.tsx`.



##
superset/migrations/versions/2024-04-08_15-43_5ad7321c2169_mig_new_csv_upload_perm.py:
##
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""mig new csv upload perm
+
+Revision ID: 5ad7321c2169
+Revises: 678eefb4ab44
+Create Date: 2024-04-08 15:43:29.682687
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "5ad7321c2169"
+down_revision = "678eefb4ab44"
+
+from alembic import op
+from sqlalchemy.exc import SQLAlchemyError
+from sqlalchemy.orm import Session
+
+from superset.migrations.shared.security_converge import (
+add_pvms,
+get_reversed_new_pvms,
+get_reversed_pvm_map,
+migrate_roles,
+Pvm,
+)
+
+NEW_PVMS = {"Database": ("can_csv_upload",)}
+
+PVM_MAP = {
+Pvm("CsvToDatabaseView", "can_this_form_post"): (
+Pvm("Database", "can_csv_upload"),
+),
+Pvm("CsvToDatabaseView", "can_this_form_get"): (Pvm("Database", 
"can_csv_upload"),),
+}
+
+
+def do_upgrade(session: Session) -> None:
+add_pvms(session, NEW_PVMS)

Review Comment:
   Can any of the migrations here be considered breaking changes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Horizontal dashboard filter bar should use full width available [superset]

[via GitHub]

sfirke commented on issue #24361:
URL: https://github.com/apache/superset/issues/24361#issuecomment-2043545903

   Indeed I just tested and this has been fixed as of 3.1.1! 🙌 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Horizontal dashboard filter bar should use full width available [superset]

[via GitHub]

sfirke closed issue #24361: Horizontal dashboard filter bar should use full 
width available
URL: https://github.com/apache/superset/issues/24361


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Unable to install and use sqlalchemy-kusto package [superset]

[via GitHub]

rusackas closed issue #25032: Unable to install and use sqlalchemy-kusto package
URL: https://github.com/apache/superset/issues/25032


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] cannot logout completely [superset]

[via GitHub]

rusackas commented on issue #23443:
URL: https://github.com/apache/superset/issues/23443#issuecomment-2043542090

   Closing this one out since (a) it's gone silent, (b) we no longer support 
versions of Superset prior to 3.1, and (c) it seems like there are solutions on 
the thread that got positive feedback as working. If this needs 
revisiting/reopening, say the word, and we'll see what we can do. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Unable to install and use sqlalchemy-kusto package [superset]

[via GitHub]

rusackas commented on issue #25032:
URL: https://github.com/apache/superset/issues/25032#issuecomment-2043544746

   Sounds like all is well, which is why this went quiet. Closing! Thanks 
everyone for the help and contributions here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] cannot logout completely [superset]

[via GitHub]

rusackas closed issue #23443: cannot logout completely
URL: https://github.com/apache/superset/issues/23443


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Running pip-compile-multi fails on 2.0.1 [superset]

[via GitHub]

rusackas closed issue #23136: Running pip-compile-multi fails on 2.0.1
URL: https://github.com/apache/superset/issues/23136


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] authlib already installed, but No module named 'authlib' [superset]

[via GitHub]

rusackas commented on issue #22149:
URL: https://github.com/apache/superset/issues/22149#issuecomment-2043537623

   Closing this one out, as it seems it's gone quiet/stale, and because there 
seem to be plenty of folks that reached a solution on the thread. If people are 
still experiencing this in currently supported versions of Superset (3.1/4.0) 
just say the word and we can revisit/reopen.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] authlib already installed, but No module named 'authlib' [superset]

[via GitHub]

rusackas closed issue #22149: authlib already installed, but No module named 
'authlib'
URL: https://github.com/apache/superset/issues/22149


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Auto run start as a service on Windows [superset]

[via GitHub]

rusackas closed issue #20426: Auto run start as a service on Windows
URL: https://github.com/apache/superset/issues/20426


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Auto run start as a service on Windows [superset]

[via GitHub]

rusackas commented on issue #20426:
URL: https://github.com/apache/superset/issues/20426#issuecomment-2043532776

   This issue has gone stale, but also SUperset officially dues not support 
Windows. If you want to contribute toward windows support (package management, 
testing, documentation, etc) please feel free to contribute... lots of folks 
would be thankful. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] X-axis tick mark at first of the month is incorrectly injected into charts with weekly time grain [superset]

[via GitHub]

rusackas closed issue #19506: X-axis tick mark at first of the month is 
incorrectly injected into charts with weekly time grain
URL: https://github.com/apache/superset/issues/19506


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] X-axis tick mark at first of the month is incorrectly injected into charts with weekly time grain [superset]

[via GitHub]

rusackas commented on issue #19506:
URL: https://github.com/apache/superset/issues/19506#issuecomment-2043530594

   Closing this for a few reasons:
   1) It's gone stale - almost 5 months since the last comment
   2) The linked PR doesn't look like it'll be merging anytime soon
   3) The issue itself is reported on Superset 1.0, and we don't support 
releases that old (4.0 just came out!)
   4) That chart (and much of the UI) is on the path toward deprecation... I'm 
not sure this is happening in the latest echarts (at least I'm not able to 
figure out how to reproduce it).
   
   In short, I can't replicate this, on current Superset, and definitely not on 
the (now very old) 1.0 version. If it's still happening, I'd recommend opening 
a new issue with updated context and a reproducible example using 
example/generated data.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] fix: useTruncation infinite loop, reenable dashboard cross links on ChartList [superset]

[via GitHub]

villebro commented on code in PR #27701:
URL: https://github.com/apache/superset/pull/27701#discussion_r1556353555


##
superset-frontend/cypress-base/cypress/e2e/chart_list/list.test.ts:
##
@@ -112,9 +112,10 @@ describe('Charts list', () => {
   cy.getBySel('sort-header').eq(1).contains('Name');
   cy.getBySel('sort-header').eq(2).contains('Type');
   cy.getBySel('sort-header').eq(3).contains('Dataset');
-  cy.getBySel('sort-header').eq(4).contains('Owners');
-  cy.getBySel('sort-header').eq(5).contains('Last modified');
-  cy.getBySel('sort-header').eq(6).contains('Actions');
+  cy.getBySel('sort-header').eq(4).contains('Dashboards added to');

Review Comment:
   This is maybe out of scope, but I feel `Dashboards added to` is too verbose, 
and I think just going with `Dashboards` or `On dashboards` makes more sense.



##
superset-frontend/packages/superset-ui-core/src/hooks/useTruncation/useChildElementTruncation.ts:
##
@@ -27,92 +27,68 @@ import { RefObject, useLayoutEffect, useState, useRef } 
from 'react';
  * (including those completely hidden) and whether any elements
  * are completely hidden.
  */
-const useChildElementTruncation = (
-  elementRef: RefObject,
-  plusRef?: RefObject,
-) => {
+const useChildElementTruncation = () => {
   const [elementsTruncated, setElementsTruncated] = useState(0);
   const [hasHiddenElements, setHasHiddenElements] = useState(false);
-
-  const previousEffectInfoRef = useRef({
-scrollWidth: 0,
-parentElementWidth: 0,
-plusRefWidth: 0,
-  });
+  const elementRef = useRef(null);
+  const plusRef = useRef(null);
 
   useLayoutEffect(() => {
-const currentElement = elementRef.current;
-const plusRefElement = plusRef?.current;
-
-if (!currentElement) {
-  return;
-}
-
-const { scrollWidth, clientWidth, childNodes } = currentElement;
-
-// By using the result of this effect to truncate content
-// we're effectively changing it's size.
-// That will trigger another pass at this effect.
-// Depending on the content elements width, that second rerender could
-// yield a different truncate count, thus potentially leading to a
-// rendering loop.
-// There's only a need to recompute if the parent width or the width of
-// the child nodes changes.
-const previousEffectInfo = previousEffectInfoRef.current;
-const parentElementWidth = currentElement.parentElement?.clientWidth || 0;
-const plusRefWidth = plusRefElement?.offsetWidth || 0;
-previousEffectInfoRef.current = {
-  scrollWidth,
-  parentElementWidth,
-  plusRefWidth,
-};
-
-if (
-  previousEffectInfo.parentElementWidth === parentElementWidth &&
-  previousEffectInfo.scrollWidth === scrollWidth &&
-  previousEffectInfo.plusRefWidth === plusRefWidth
-) {
-  return;
-}
+const onResize = () => {
+  const currentElement = elementRef.current;
+  if (!currentElement) {
+return;
+  }
+  const plusRefElement = plusRef.current;
+  const { scrollWidth, clientWidth, childNodes } = currentElement;
 
-if (scrollWidth > clientWidth) {
-  // "..." is around 6px wide
-  const truncationWidth = 6;
-  const plusSize = plusRefElement?.offsetWidth || 0;
-  const maxWidth = clientWidth - truncationWidth;
-  const elementsCount = childNodes.length;
+  if (scrollWidth > clientWidth) {
+// "..." is around 6px wide
+const truncationWidth = 6;
+const plusSize = plusRefElement?.offsetWidth || 0;
+const maxWidth = clientWidth - truncationWidth;
+const elementsCount = childNodes.length;
 
-  let width = 0;
-  let hiddenElements = 0;
-  for (let i = 0; i < elementsCount; i += 1) {
-const itemWidth = (childNodes[i] as HTMLElement).offsetWidth;
-const remainingWidth = maxWidth - truncationWidth - width - plusSize;
+let width = 0;
+let hiddenElements = 0;
+for (let i = 0; i < elementsCount; i += 1) {
+  const itemWidth = (childNodes[i] as HTMLElement).offsetWidth;
+  const remainingWidth = maxWidth - width - plusSize;
 
-// assures it shows +{number} only when the item is not visible
-if (remainingWidth <= 0) {
-  hiddenElements += 1;
+  // assures it shows +{number} only when the item is not visible
+  if (remainingWidth <= 0) {
+hiddenElements += 1;
+  }
+  width += itemWidth;
 }
-width += itemWidth;
-  }
 
-  if (elementsCount > 1 && hiddenElements) {
-setHasHiddenElements(true);
-setElementsTruncated(hiddenElements);
+if (elementsCount > 1 && hiddenElements) {
+  setHasHiddenElements(true);
+  setElementsTruncated(hiddenElements);
+} else {
+  setHasHiddenElements(false);
+  setElementsTruncated(1);
+}
   } else {
 setHasHid

Re: [I] Helm chart installation times out and starts to consume huge amount of CPU [superset]

[via GitHub]

margorczynski commented on issue #27931:
URL: https://github.com/apache/superset/issues/27931#issuecomment-2043516675

   It should be the latest considering the command: @villebro 
   
   
![image](https://github.com/apache/superset/assets/1714491/241d67fa-514a-4dd4-a72b-78edb375807f)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Gauge Chart value doesn't update when jinja template filters are set [superset]

[via GitHub]

rusackas closed issue #26086: Gauge Chart value doesn't update when jinja 
template filters are set
URL: https://github.com/apache/superset/issues/26086


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Gauge Chart value doesn't update when jinja template filters are set [superset]

[via GitHub]

rusackas commented on issue #26086:
URL: https://github.com/apache/superset/issues/26086#issuecomment-2043503189

   Closing this as stale, but it's likely stale because it's hard to reproduce. 
Can you give us a reproducible test case using example charts/data so not as 
much has to be redacted? If we can make that happen, and the bug is still 
present in 3.1/4.0, we can revisit/reopen. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] setting edit list roles trino The data source can only obtain part of the schema. [superset]

[via GitHub]

rusackas closed issue #26125: setting edit list roles trino The data source can 
only obtain part of the schema.
URL: https://github.com/apache/superset/issues/26125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] setting edit list roles trino The data source can only obtain part of the schema. [superset]

[via GitHub]

rusackas commented on issue #26125:
URL: https://github.com/apache/superset/issues/26125#issuecomment-2043500138

   Closing this because it's stale, which is likely because it's also 
confusing. The issue template was not filled out, so we don't have a statement 
of expected/actual behavior. It looks like you're enabling schema access, and 
then getting a list of schemas. If you're still facing this in Superset 3.1 or 
newer, let us know, and we can revisit/reopen if there's more context here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] WITH RECURSIVE Common Table Expression doesn't parse case of select queries correctly [superset]

[via GitHub]

rusackas commented on issue #26128:
URL: https://github.com/apache/superset/issues/26128#issuecomment-2043497089

   Tempted to close this as stale, and because it's reported on Superset 2.x, 
where we're only supporting 3.1 and 4.0 now. 
   
   That said, I would bet that it's still happening... can you verify this? We 
can keep it open if it's still happening. I'm wondering if the work done 
recently around SQLGlot might have resolved this along the way (cc 
@betodealmeida @john-bodley )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] fix(drillby): Enable DrillBy in charts w/o filters (dimensions) [superset]

[via GitHub]

sowo commented on PR #27941:
URL: https://github.com/apache/superset/pull/27941#issuecomment-2043495045

   Seems the breadcrumbs and drillByConfigs need to be in sync to make 
breadcrumb navigation work. So rather than filtering out the first breadcrumb 
item when it is empty (for charts without dimensions), I decided to just hide 
the first breadcrumb. This is somewhat ugly as it leaves the separator (/) 
visible. 
   
   
![image](https://github.com/apache/superset/assets/2765941/60204837-ac17-4d68-829d-d9d5fc540eb4)
   
   
   Let me know if anyone has a better idea on how to non-intrusively fix this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Pivot Table v2, can't show subtotals based on a single column [superset]

[via GitHub]

rusackas closed issue #20076: Pivot Table v2, can't show subtotals based on a 
single column
URL: https://github.com/apache/superset/issues/20076


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Pivot Table v2, can't show subtotals based on a single column [superset]

[via GitHub]

rusackas commented on issue #20076:
URL: https://github.com/apache/superset/issues/20076#issuecomment-2043490817

   This issue has been quiet for quite a while, so I'll close it in favor of 
https://github.com/apache/superset/issues/23560, which links to the other 
similar reported issues. This thread still has a lot of useful context, so 
thank you for reporting it here and I hope it serves in helping someone tackle 
the problem. To say what everyone says in open source, contributions 
welcome/encouraged!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Not Working - fullscreen of embedding dashboard [superset]

[via GitHub]

rusackas commented on issue #23793:
URL: https://github.com/apache/superset/issues/23793#issuecomment-2043488378

   Since there are seemingly three working solutions on this thread, and it's 
been silent for 5 months, I'll go ahead and close this as resolved. Thanks for 
all the helpful pointers, everyone!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Not Working - fullscreen of embedding dashboard [superset]

[via GitHub]

rusackas closed issue #23793: Not Working - fullscreen of embedding dashboard
URL: https://github.com/apache/superset/issues/23793


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Not able to run the superset latest version [superset]

[via GitHub]

rusackas commented on issue #25624:
URL: https://github.com/apache/superset/issues/25624#issuecomment-2043484425

   The errors here don't seem to be an issue in current Superset. A couple of 
the warnings still do, but they don't seem to be impacting anything. PRs 
welcome for those, of course! Closing this as stale, but also seemingly 
resolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Not able to run the superset latest version [superset]

[via GitHub]

rusackas closed issue #25624: Not able to run the superset latest version
URL: https://github.com/apache/superset/issues/25624


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[PR] fix(docs): CSP mods to re-enable Algolia search [superset]

[via GitHub]

rusackas opened a new pull request, #27942:
URL: https://github.com/apache/superset/pull/27942

   
   
   ### SUMMARY
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   
   ### TESTING INSTRUCTIONS
   
   
   ### ADDITIONAL INFORMATION
   
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
 - [ ] Migration is atomic, supports rollback & is backwards-compatible
 - [ ] Confirm DB migration upgrade and downgrade tested
 - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] The front-end uses the '@ superset ui/embedded sdk' sdk to embed the superset dashboard page. Click on '...' in the upper right corner of the page When the button is clicked and the 'Enter ful

[via GitHub]

rusackas closed issue #25122: The front-end uses the '@ superset ui/embedded 
sdk' sdk to embed the superset dashboard page. Click on '...' in the upper 
right corner of the page When the button is clicked and the 'Enter fullscreen' 
menu option is clicked, the embedded dashboard page remains loaded. How can I 
fix this?
URL: https://github.com/apache/superset/issues/25122


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] The front-end uses the '@ superset ui/embedded sdk' sdk to embed the superset dashboard page. Click on '...' in the upper right corner of the page When the button is clicked and the 'Enter ful

[via GitHub]

rusackas commented on issue #25122:
URL: https://github.com/apache/superset/issues/25122#issuecomment-2043461574

   Seems related... the fullscreen button wasn't working before (and wasn't 
supposed to). Now that it's hidden, I think this issue is a moot point. Closing 
as resolved, but happy to revisit/reopen if there's anything further to do here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Export number in CSV in wrong format [superset]

[via GitHub]

rusackas closed issue #23939: Export number in CSV in wrong format
URL: https://github.com/apache/superset/issues/23939


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Export number in CSV in wrong format [superset]

[via GitHub]

rusackas commented on issue #23939:
URL: https://github.com/apache/superset/issues/23939#issuecomment-2043457461

   Is anyone here still planning to work on this? I'm tempted to close it as 
stale. The initial report also predates supported versions of Superset, so 
please let us know if you're still facing this in Superset 3.1/4.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] when set WTF_CSRF_ENABLED = False , login to Superset still failure, log show : flask_wtf.csrf.CSRFError: "The CSRF session token is missing " [superset]

[via GitHub]

rusackas commented on issue #25587:
URL: https://github.com/apache/superset/issues/25587#issuecomment-2043452266

   Sounds like there's nothing more to discuss here, so I'll close this one 
out. Thanks everyone!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Horizontal dashboard filter bar should use full width available [superset]

[via GitHub]

rusackas commented on issue #24361:
URL: https://github.com/apache/superset/issues/24361#issuecomment-2043453395

   @sfirke this one's gone quiet for quite a while... do you think we still 
need it open?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] when set WTF_CSRF_ENABLED = False , login to Superset still failure, log show : flask_wtf.csrf.CSRFError: "The CSRF session token is missing " [superset]

[via GitHub]

rusackas closed issue #25587: when set WTF_CSRF_ENABLED = False , login to 
Superset still  failure,   log show : flask_wtf.csrf.CSRFError: "The CSRF 
session token is missing " 
URL: https://github.com/apache/superset/issues/25587


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] PivotTable with two column metrics errors with Dremio backend on 3.0.0 [superset]

[via GitHub]

rusackas closed issue #25641: PivotTable with two column metrics errors with 
Dremio backend on 3.0.0
URL: https://github.com/apache/superset/issues/25641


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] PivotTable with two column metrics errors with Dremio backend on 3.0.0 [superset]

[via GitHub]

rusackas commented on issue #25641:
URL: https://github.com/apache/superset/issues/25641#issuecomment-2043385721

   Closing this one as stale, since it's gone nearly six months with no further 
corroboration/discussion/invesitigation. If anyone feels this needs reopening, 
just say the word. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] AUTH_ROLES_MAPPING [superset]

[via GitHub]

rusackas commented on issue #25849:
URL: https://github.com/apache/superset/issues/25849#issuecomment-2043381251

   Since there's no response to the last comment helping to diagnose/fix, I'll 
assume that it either worked out, or OP has moved on. Closing this one out as 
stale, but happy to revisit/reopen as warranted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] AUTH_ROLES_MAPPING [superset]

[via GitHub]

rusackas closed issue #25849: AUTH_ROLES_MAPPING
URL: https://github.com/apache/superset/issues/25849


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Superset showing error "not authorized" after Integrating with key clock [superset]

[via GitHub]

rusackas commented on issue #25884:
URL: https://github.com/apache/superset/issues/25884#issuecomment-2043378217

   Since it's been nearly 5 months with an unanswered diagnostic question, I'll 
assume OP moved on, and we can call this one stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Superset showing error "not authorized" after Integrating with key clock [superset]

[via GitHub]

rusackas closed issue #25884: Superset showing error  "not authorized" after 
Integrating with key clock 
URL: https://github.com/apache/superset/issues/25884


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Items are not translated (hardcoded) [superset]

[via GitHub]

rusackas commented on issue #25990:
URL: https://github.com/apache/superset/issues/25990#issuecomment-2043375456

   CC @dpgaspar for an opinion here... if this is a FAB issue, I don't think 
there's much we can do on the Superset side, and we can close it, and perhaps 
file an issue on that repo.
   
   For any strings in Superset, we don't typically support these as _bugs_ but 
you're welcome to open a PR that adds either translated strings to existing 
translated strings, or turn any static strings into translated strings in the 
codebase (e.g. adding `t(string)` on the frontend). 
   
   Tempted to close this as stale anyway, but I'll leave it open hoping that we 
can get further thoughts on the matter and/or a PR to address it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Calendar Heatmap chart does not update to match the dashboard color pallet [superset]

[via GitHub]

rusackas commented on issue #26002:
URL: https://github.com/apache/superset/issues/26002#issuecomment-2043354554

   One interesting thing here is that the heatmap chart uses a 
linear/scalar/gradient color palette. When editing a dashboard to add a color 
palette at that level, you are _only_ allowed to select a _categorical_ color 
palette. So, if that categorical palette WERE added to the heatmap, it would be 
a mess of rainbow blocks. 
   
   The problem I mention above can currently be seen with the world map and/or 
country map choropleth maps. They make sense with a gradient on their own, but 
a dashboard palette basically destrpys that. 
   
   Arguably, the behavior of this plugin is better... at least it remains 
intact. I think the real fix here is _kind of__ a feature request... but it 
would fix both bugs — we need TWO palettes that can be set at the dashboard 
level. A categorical one, and a gradient one. Then charts would be able to 
grab/apply the correct one accordingly.
   
   CC @geido @yousoph 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] [SIP-102] Allow Superset to run in a sub path URL [superset]

[via GitHub]

rusackas closed issue #24823: [SIP-102] Allow Superset to run in a sub path URL
URL: https://github.com/apache/superset/issues/24823


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] [SIP-102] Allow Superset to run in a sub path URL [superset]

[via GitHub]

rusackas commented on issue #24823:
URL: https://github.com/apache/superset/issues/24823#issuecomment-2043343610

   Thanks for the follow up @maudrid - if this is a feature request, I'll go 
ahead and close this SIP as discarded, though anyone who ever finds the thread 
and decides to act on it can reboot the process, and we'll happily reopen the 
issue for further discussion/voting/implementation. For now, I'd say it's not a 
bug, since Superset works as advertised/intended. You're welcome to open an 
"Ideas" thread on [Github 
Discussions](https://github.com/apache/superset/discussions) to find interested 
parties who want to help.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] feat(country-map): Adds Philippines regional map and updates/cleans existing Philippines provincial map [superset]

[via GitHub]

rusackas commented on PR #27933:
URL: https://github.com/apache/superset/pull/27933#issuecomment-2043336401

   Hi there... this is great, and we thank you for the contribution. Both the 
geojson files and the countries.ts file in this PR will be overwritten by 
anyone running the Jupyter notebook that generates Superset's maps. Would you 
be able to make your changes in that notebook so that the geojson/typescript in 
this PR is generated? This will help the whole project maintain good maps going 
forward.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] feat(examples): tech debt dashboard [superset]

[via GitHub]

rusackas commented on PR #26818:
URL: https://github.com/apache/superset/pull/26818#issuecomment-2043318847

   @mistercrunch just got this codecov notification in my inbox... hopefully 
I'm mistaken, but it looks like adding the label might have somehow retriggered 
some CI tasks?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] fix(drillby): Enable DrillBy in charts w/o filters (dimensions) [superset]

[via GitHub]

rusackas commented on PR #27941:
URL: https://github.com/apache/superset/pull/27941#issuecomment-2043309875

   Maybe if @sfirke's hypothesis is right, we'll get lucky and this will help 
with https://github.com/apache/superset/issues/25334 as well... but maybe not. 
Just something to test when the ephemeral env spins up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] fix(drillby): Enable DrillBy in charts w/o filters (dimensions) [superset]

[via GitHub]

rusackas commented on PR #27941:
URL: https://github.com/apache/superset/pull/27941#issuecomment-2043308997

   /testenv up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Drill by is disabled for Timeseries and Mixed Timeseries charts without dimensions [superset]

[via GitHub]

rusackas commented on issue #27940:
URL: https://github.com/apache/superset/issues/27940#issuecomment-2043308303

   Maybe the PR will fix two PRs, who knows!?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Drill by is disabled for Timeseries and Mixed Timeseries charts without dimensions [superset]

[via GitHub]

rusackas commented on issue #27940:
URL: https://github.com/apache/superset/issues/27940#issuecomment-2043307388

   @sfirke looking at the PR, it seems it just opens all dimensions for 
drilling, which _looks_ to me like a good thing. I'm not sure if @kgabryje or 
@villebro see any risk on that PR, but it looks like a win. I'll spin up a test 
env to poke around at it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Report quality is not good in mobile slack app. [superset]

[via GitHub]

rusackas commented on issue #27938:
URL: https://github.com/apache/superset/issues/27938#issuecomment-2043304014

   I believe the message is simply sent to Slack, period. How it is handled on 
desktop/mobile from there would be the responsibility of the Slack client 
itself. I'm not sure if this is something we can fix. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Drill by is disabled for Timeseries and Mixed Timeseries charts without dimensions [superset]

[via GitHub]

sfirke commented on issue #27940:
URL: https://github.com/apache/superset/issues/27940#issuecomment-2043253123

   Do this and #25334 have similar causes, since both are cases of wanting the 
bar chart series to act like a dimension?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] fix: Locale sent to frontend [superset]

[via GitHub]

michael-s-molina merged PR #27926:
URL: https://github.com/apache/superset/pull/27926


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Locale object/string mixup [superset]

[via GitHub]

michael-s-molina closed issue #27881: Locale object/string mixup
URL: https://github.com/apache/superset/issues/27881


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] feat: new CSV upload form and API [superset]

[via GitHub]

sfirke commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2043247127

   This looks great!  It gets me wondering about "upload columnar file to 
database" and "upload Excel file to database."  My users mostly use the Excel 
one.  Would some aspects of this overhaul be applicable to those upload options?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] feat(ConditionalFormatting): allow inverse color scaling and add color picker [superset]

[via GitHub]

codecov-commenter commented on PR #20353:
URL: https://github.com/apache/superset/pull/20353#issuecomment-2043244452

   ## 
[Codecov](https://app.codecov.io/gh/apache/superset/pull/20353?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   Attention: Patch coverage is `77.27273%` with `10 lines` in your changes are 
missing coverage. Please review.
   > Project coverage is 66.71%. Comparing base 
[(`ab9f72f`)](https://app.codecov.io/gh/apache/superset/commit/ab9f72f1a1359a59e64afd9e820d5823fd53b77b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`ca1296a`)](https://app.codecov.io/gh/apache/superset/pull/20353?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 3248 commits behind head on master.
   
   | 
[Files](https://app.codecov.io/gh/apache/superset/pull/20353?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...ntend/packages/superset-ui-core/src/color/utils.ts](https://app.codecov.io/gh/apache/superset/pull/20353?src=pr&el=tree&filepath=superset-frontend%2Fpackages%2Fsuperset-ui-core%2Fsrc%2Fcolor%2Futils.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvdXRpbHMudHM=)
 | 86.66% | [1 Missing and 3 partials :warning: 
](https://app.codecov.io/gh/apache/superset/pull/20353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   | 
[...onalFormattingControl/FormattingPopoverContent.tsx](https://app.codecov.io/gh/apache/superset/pull/20353?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fexplore%2Fcomponents%2Fcontrols%2FConditionalFormattingControl%2FFormattingPopoverContent.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db25kaXRpb25hbEZvcm1hdHRpbmdDb250cm9sL0Zvcm1hdHRpbmdQb3BvdmVyQ29udGVudC50c3g=)
 | 0.00% | [4 Missing :warning: 
](https://app.codecov.io/gh/apache/superset/pull/20353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   | 
[...-ui-chart-controls/src/utils/getColorFormatters.ts](https://app.codecov.io/gh/apache/superset/pull/20353?src=pr&el=tree&filepath=superset-frontend%2Fpackages%2Fsuperset-ui-chart-controls%2Fsrc%2Futils%2FgetColorFormatters.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3V0aWxzL2dldENvbG9yRm9ybWF0dGVycy50cw==)
 | 85.71% | [0 Missing and 1 partial :warning: 
](https://app.codecov.io/gh/apache/superset/pull/20353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   | 
[superset-frontend/src/utils/colorUtils.ts](https://app.codecov.io/gh/apache/superset/pull/20353?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Futils%2FcolorUtils.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvbG9yVXRpbHMudHM=)
 | 66.66% | [0 Missing and 1 partial :warning: 
](https://app.codecov.io/gh/apache/superset/pull/20353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   Additional details and impacted files
   
   
   ```diff
   @@   Coverage Diff   @@
   ##   master   #20353   +/-   ##
   ===
 Coverage   66.71%   66.71%   
   ===
 Files1739 1739   
 Lines   6514965190   +41 
 Branches 6899 6919   +20 
   ===
   + Hits4346243493   +31 
   - Misses  1993419939+5 
   - Partials 1753 1758+5 
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/superset/pull/20353/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[javascript](https://app.codecov.io/gh/apache/superset/pull/20353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `51.79% <77.27%> (+0.02%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_s

Re: [PR] fix: the legend does not preserves the order of metrics [superset]

[via GitHub]

codecov-commenter commented on PR #22164:
URL: https://github.com/apache/superset/pull/22164#issuecomment-2043244237

   ## 
[Codecov](https://app.codecov.io/gh/apache/superset/pull/22164?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   Attention: Patch coverage is `0%` with `2 lines` in your changes are missing 
coverage. Please review.
   > Project coverage is 54.22%. Comparing base 
[(`17c2bd8`)](https://app.codecov.io/gh/apache/superset/commit/17c2bd89a6ecc480851801d58fadbf130704f784?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`9154a4f`)](https://app.codecov.io/gh/apache/superset/pull/22164?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 2459 commits behind head on master.
   
   | 
[Files](https://app.codecov.io/gh/apache/superset/pull/22164?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[superset/utils/pandas\_postprocessing/pivot.py](https://app.codecov.io/gh/apache/superset/pull/22164?src=pr&el=tree&filepath=superset%2Futils%2Fpandas_postprocessing%2Fpivot.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL3Bpdm90LnB5)
 | 0.00% | [2 Missing :warning: 
](https://app.codecov.io/gh/apache/superset/pull/22164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   Additional details and impacted files
   
   
   ```diff
   @@ Coverage Diff @@
   ##   master   #22164   +/-   ##
   ===
   - Coverage   66.99%   54.22%   -12.78% 
   ===
 Files1833 2011  +178 
 Lines   6993691477+21541 
 Branches 7572 7572   
   ===
   + Hits4685549604 +2749 
   - Misses  2112139913+18792 
 Partials 1960 1960   
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[hive](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `54.37% <0.00%> (+1.76%)` | :arrow_up: |
   | 
[mysql](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `?` | |
   | 
[postgres](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `?` | |
   | 
[presto](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `53.72% <0.00%> (+1.23%)` | :arrow_up: |
   | 
[python](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `54.51% <0.00%> (-26.88%)` | :arrow_down: |
   | 
[sqlite](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `?` | |
   | 
[unit](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/superset/pull/22164?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message

Re: [PR] feat(examples): tech debt dashboard [superset]

[via GitHub]

codecov-commenter commented on PR #26818:
URL: https://github.com/apache/superset/pull/26818#issuecomment-2043243429

   ## 
[Codecov](https://app.codecov.io/gh/apache/superset/pull/26818?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 69.55%. Comparing base 
[(`c657745`)](https://app.codecov.io/gh/apache/superset/commit/c657745f02db9ab3141902d8641d69ee049fab4a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`29a6600`)](https://app.codecov.io/gh/apache/superset/pull/26818?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 503 commits behind head on master.
   
   
   Additional details and impacted files
   
   
   ```diff
   @@Coverage Diff @@
   ##   master   #26818  +/-   ##
   ==
   + Coverage   67.23%   69.55%   +2.32% 
   ==
 Files1895 1895  
 Lines   7420974209  
 Branches 8244 8244  
   ==
   + Hits4989151616+1725 
   + Misses  2224620521-1725 
 Partials 2072 2072  
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/superset/pull/26818/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[hive](https://app.codecov.io/gh/apache/superset/pull/26818/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `53.78% <ø> (?)` | |
   | 
[mysql](https://app.codecov.io/gh/apache/superset/pull/26818/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `77.96% <ø> (ø)` | |
   | 
[postgres](https://app.codecov.io/gh/apache/superset/pull/26818/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `78.06% <ø> (ø)` | |
   | 
[presto](https://app.codecov.io/gh/apache/superset/pull/26818/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `53.73% <ø> (?)` | |
   | 
[python](https://app.codecov.io/gh/apache/superset/pull/26818/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `83.01% <ø> (+4.81%)` | :arrow_up: |
   | 
[sqlite](https://app.codecov.io/gh/apache/superset/pull/26818/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `77.64% <ø> (ø)` | |
   | 
[unit](https://app.codecov.io/gh/apache/superset/pull/26818/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `56.40% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/superset/pull/26818?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] fix: Upgrade eyes-cypress to latest [superset]

[via GitHub]

codecov-commenter commented on PR #27195:
URL: https://github.com/apache/superset/pull/27195#issuecomment-2043243180

   ## 
[Codecov](https://app.codecov.io/gh/apache/superset/pull/27195?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 67.20%. Comparing base 
[(`3818da8`)](https://app.codecov.io/gh/apache/superset/commit/3818da850957c779e8d24071a4fc7302cd053959?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`a511442`)](https://app.codecov.io/gh/apache/superset/pull/27195?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 302 commits behind head on master.
   
   
   Additional details and impacted files
   
   
   ```diff
   @@   Coverage Diff   @@
   ##   master   #27195   +/-   ##
   ===
 Coverage   67.20%   67.20%   
   ===
 Files1905 1905   
 Lines   7449674498+2 
 Branches 8323 8324+1 
   ===
   + Hits5006450066+2 
 Misses  2237722377   
 Partials 2055 2055   
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/superset/pull/27195/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[javascript](https://app.codecov.io/gh/apache/superset/pull/27195/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `56.95% <ø> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/superset/pull/27195?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] fix: make fips compliant by replacing md5 with sha256 in postgres and usedforsecurity=False for python md5 [superset]

[via GitHub]

codecov-commenter commented on PR #21014:
URL: https://github.com/apache/superset/pull/21014#issuecomment-2043244518

   ## 
[Codecov](https://app.codecov.io/gh/apache/superset/pull/21014?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 69.89%. Comparing base 
[(`349e496`)](https://app.codecov.io/gh/apache/superset/commit/349e496da519f3462aa5cff2d1bd76490b04fe5d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`f08a6b1`)](https://app.codecov.io/gh/apache/superset/pull/21014?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 124 commits behind head on master.
   
   
   Additional details and impacted files
   
   
   ```diff
   @@Coverage Diff @@
   ##   master   #21014  +/-   ##
   ==
   + Coverage   69.77%   69.89%   +0.11% 
   ==
 Files1911 1911  
 Lines   7505675060   +4 
 Branches 8362 8362  
   ==
   + Hits5237452461  +87 
   + Misses  2063020547  -83 
 Partials 2052 2052  
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/superset/pull/21014/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[hive](https://app.codecov.io/gh/apache/superset/pull/21014/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `48.93% <25.00%> (?)` | |
   | 
[mysql](https://app.codecov.io/gh/apache/superset/pull/21014/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `77.91% <100.00%> (+0.02%)` | :arrow_up: |
   | 
[postgres](https://app.codecov.io/gh/apache/superset/pull/21014/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `78.02% <100.00%> (+<0.01%)` | :arrow_up: |
   | 
[presto](https://app.codecov.io/gh/apache/superset/pull/21014/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `53.64% <50.00%> (?)` | |
   | 
[python](https://app.codecov.io/gh/apache/superset/pull/21014/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `83.15% <100.00%> (+0.23%)` | :arrow_up: |
   | 
[sqlite](https://app.codecov.io/gh/apache/superset/pull/21014/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `77.46% <100.00%> (+<0.01%)` | :arrow_up: |
   | 
[unit](https://app.codecov.io/gh/apache/superset/pull/21014/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `56.76% <50.00%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/superset/pull/21014?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Can't find superset_config.py ! [superset]

[via GitHub]

Navya-Prakash commented on issue #3024:
URL: https://github.com/apache/superset/issues/3024#issuecomment-2043243557

   I have'nt installed apache superset but i have cloned the whole repo, even 
i'm trying to find out where superset_config.py is , 
   found one in docker folder but its not relevant. Do we have any other name 
or such for this file?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org