Re: [PR] chore: Fix/remove hardcode of admin role [superset]
Always-prog commented on PR #27779: URL: https://github.com/apache/superset/pull/27779#issuecomment-2132298464 I'll fix the frontend soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: Fix/remove hardcode of admin role [superset]
Always-prog commented on PR #27779: URL: https://github.com/apache/superset/pull/27779#issuecomment-2057285996 @rusackas I see, ok. I have pushed commit with the fix :+1:, please take a look! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: Fix/remove hardcode of admin role [superset]
rusackas commented on PR #27779: URL: https://github.com/apache/superset/pull/27779#issuecomment-2047774826 The main thing I'm wondering about this PR now that I look more closely at the code, is if there's a better place to store this information. I'm a little nervous about storing bootstrap data on the window object, which opens up a new "junk drawer" pattern where people might store anything there. I'm not sure if we should have the Feature Flags there either, really. Is it possible to access this via the `getBootstrapData()` like we do so many other things in the codebase already. It looks like the role is indeed in there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: Fix/remove hardcode of admin role [superset]
Always-prog commented on PR #27779: URL: https://github.com/apache/superset/pull/27779#issuecomment-2046954495 @rusackas Test cases has beed passed without rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: Fix/remove hardcode of admin role [superset]
rusackas commented on PR #27779: URL: https://github.com/apache/superset/pull/27779#issuecomment-2035493881 Rerunning the mysql test in hopes that it's just flaky, but if it fails again, the PR _**might**_ need a rebase (there were some glitches with these DB tests that got resolved on master not long ago). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: Fix/remove hardcode of admin role [superset]
Always-prog commented on PR #27779: URL: https://github.com/apache/superset/pull/27779#issuecomment-2034626260 @john-bodley Hi! Fixed code by your review. Please take a look! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: Fix/remove hardcode of admin role [superset]
Always-prog commented on PR #27779: URL: https://github.com/apache/superset/pull/27779#issuecomment-2033916417 Thank you @mistercrunch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: Fix/remove hardcode of admin role [superset]
Always-prog commented on code in PR #27779:
URL: https://github.com/apache/superset/pull/27779#discussion_r1549248158
##
superset-frontend/src/dashboard/util/permissionUtils.ts:
##
@@ -25,16 +25,14 @@ import {
import { Dashboard } from 'src/types/Dashboard';
import { findPermission } from 'src/utils/findPermission';
-// this should really be a config value,
-// but is hardcoded in backend logic already, so...
-const ADMIN_ROLE_NAME = 'admin';
+const ADMIN_ROLE_NAME = window.adminRole || 'Admin';
Review Comment:
Moved that default value of adminRole to the
superset-frontend/spec/helpers/shim.tsx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: Fix/remove hardcode of admin role [superset]
mistercrunch commented on PR #27779: URL: https://github.com/apache/superset/pull/27779#issuecomment-2033656787 more about the bot here -> https://github.com/apache-superset/supersetbot . It even has a logo now 烙 烙 烙 https://github.com/apache/superset/assets/487433/cc823495-731f-4c53-8c34-6bd755b9625b;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: Fix/remove hardcode of admin role [superset]
mistercrunch commented on PR #27779: URL: https://github.com/apache/superset/pull/27779#issuecomment-2033652768 @supersetbot orglabel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: Fix/remove hardcode of admin role [superset]
mistercrunch commented on PR #27779: URL: https://github.com/apache/superset/pull/27779#issuecomment-2033652204 @supersetbot unlabel TechAudit-BI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: Fix/remove hardcode of admin role [superset]
codecov-commenter commented on PR #27779: URL: https://github.com/apache/superset/pull/27779#issuecomment-2033343365 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27779?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `50.0%` with `2 lines` in your changes are missing coverage. Please review. > Project coverage is 69.77%. Comparing base [(`c0f8dfc`)](https://app.codecov.io/gh/apache/superset/commit/c0f8dfc7f99a0e83a8c9b3c083288c76f50aa662?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`06bbab7`)](https://app.codecov.io/gh/apache/superset/pull/27779?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 19 commits behind head on master. | [Files](https://app.codecov.io/gh/apache/superset/pull/27779?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [superset-frontend/src/preamble.ts](https://app.codecov.io/gh/apache/superset/pull/27779?src=pr=tree=superset-frontend%2Fsrc%2Fpreamble.ts_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/27779?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@Coverage Diff @@ ## master #27779 +/- ## == + Coverage 69.71% 69.77% +0.05% == Files1920 1920 Lines 7523475244 +10 Branches 8423 8425 +2 == + Hits5244752498 +51 + Misses 2072520684 -41 Partials 2062 2062 ``` | [Flag](https://app.codecov.io/gh/apache/superset/pull/27779/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [hive](https://app.codecov.io/gh/apache/superset/pull/27779/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `48.93% <ø> (?)` | | | [javascript](https://app.codecov.io/gh/apache/superset/pull/27779/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `57.39% <50.00%> (-0.01%)` | :arrow_down: | | [mysql](https://app.codecov.io/gh/apache/superset/pull/27779/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `77.88% <ø> (-0.01%)` | :arrow_down: | | [postgres](https://app.codecov.io/gh/apache/superset/pull/27779/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `77.99% <ø> (-0.01%)` | :arrow_down: | | [python](https://app.codecov.io/gh/apache/superset/pull/27779/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `83.03% <ø> (+0.12%)` | :arrow_up: | | [sqlite](https://app.codecov.io/gh/apache/superset/pull/27779/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `77.43% <ø> (-0.01%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/apache/superset/pull/27779/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `56.78% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/27779?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail:
Re: [PR] chore: Fix/remove hardcode of admin role [superset]
rusackas commented on PR #27779: URL: https://github.com/apache/superset/pull/27779#issuecomment-2032909342 > @supersetbot orglabel > How I can add orglabel?) @mistercrunch can probably help. Not sure if there's documentation for all this somewhere... we should probably add a page to the docs site or the wiki (probably the wiki, since that's where more process/dev content is going, while the docs are more end-user focused). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
