Re: [PR] chore: remove ipython from development dependencies [superset]
mistercrunch commented on PR #28703: URL: https://github.com/apache/superset/pull/28703#issuecomment-2138110987 One more thought it with segmentation in `requirements/` we can have different level of rigor for freshness for different files. Likely I'll set up supersetbot in different ways for `base.in` VS `development.in` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: remove ipython from development dependencies [superset]
mistercrunch commented on PR #28703: URL: https://github.com/apache/superset/pull/28703#issuecomment-2138106585 Yes for this particular one the "likely hood to be used" vs "dependency burden" isn't great. Currently the criteria is more or less "commonly used by humans and/or CI for development workflows". Now that we have a workflow to upgrade things (supersetbot as a pip-compile-multi-aware dependabot replacement), it seems reasonable / manageable if we wanted to bring back more segmentation/complexity under `requirements/` if we wanted to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: remove ipython from development dependencies [superset]
john-bodley commented on PR #28703: URL: https://github.com/apache/superset/pull/28703#issuecomment-2137911407 I thought development dependencies were there to help aid development. Maybe it's worth explicitly mentioning in the documentation what are viable development dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: remove ipython from development dependencies [superset]
mistercrunch merged PR #28703: URL: https://github.com/apache/superset/pull/28703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: remove ipython from development dependencies [superset]
mistercrunch closed pull request #28703: chore: remove ipython from development dependencies URL: https://github.com/apache/superset/pull/28703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[PR] chore: remove ipython from development dependencies [superset]
mistercrunch opened a new pull request, #28703: URL: https://github.com/apache/superset/pull/28703 # Summary removing ipython as it's simply a nice-to-have, but not required for Superset development -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org