Re: [PR] docs(k8s): making it clear users MUST update secrets for prod instances. [superset]
rusackas merged PR #27954: URL: https://github.com/apache/superset/pull/27954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] docs(k8s): making it clear users MUST update secrets for prod instances. [superset]
margorczynski commented on PR #27954: URL: https://github.com/apache/superset/pull/27954#issuecomment-2047214372 Hey @rusackas, yep, I think this more stronly suggests that the config needs to be overwritten for this to work, thank you for the update :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] docs(k8s): making it clear users MUST update secrets for prod instances. [superset]
rusackas commented on code in PR #27954: URL: https://github.com/apache/superset/pull/27954#discussion_r1558314552 ## docs/docs/installation/running-on-kubernetes.mdx: ## @@ -93,7 +93,7 @@ Depending how you configured external access, the URL will vary. Once you've ide Security settings -Default security settings and passwords are included but you **SHOULD** override those with your own, in particular: +Default security settings and passwords are included but you **SHOULD** override those with your own for `dev` instances, and **MUST** update them to run `prod` instances, in particular: Review Comment: Works for me! Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] docs(k8s): making it clear users MUST update secrets for prod instances. [superset]
villebro commented on code in PR #27954: URL: https://github.com/apache/superset/pull/27954#discussion_r1558311597 ## docs/docs/installation/running-on-kubernetes.mdx: ## @@ -93,7 +93,7 @@ Depending how you configured external access, the URL will vary. Once you've ide Security settings -Default security settings and passwords are included but you **SHOULD** override those with your own, in particular: +Default security settings and passwords are included but you **SHOULD** override those with your own for `dev` instances, and **MUST** update them to run `prod` instances, in particular: Review Comment: ```suggestion Default security settings and passwords are included but you **MUST** update them to run `prod` instances, in particular: ``` Maybe this is simpler - we already log a warning when starting in debug with the default `SECRET_KEY`, so people should see that whenever they start their local devenv without a `SECRET_KEY` of their own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] docs(k8s): making it clear users MUST update secrets for prod instances. [superset]
rusackas commented on PR #27954: URL: https://github.com/apache/superset/pull/27954#issuecomment-2046017001 @margorczynski let me know if this addresses your concern, or make suggestions accordingly if not :) Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[PR] docs(k8s): making it clear users MUST update secrets for prod instances. [superset]
rusackas opened a new pull request, #27954: URL: https://github.com/apache/superset/pull/27954 ### SUMMARY Addressing some confusion from this issue: https://github.com/apache/superset/issues/27931 ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS ### ADDITIONAL INFORMATION - [ ] Has associated issue: Fixes https://github.com/apache/superset/issues/27931 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
