Re: [PR] fix: Data zoom with horizontal orientation [superset]
visharavana commented on PR #27291: URL: https://github.com/apache/superset/pull/27291#issuecomment-2046614658 @michael-s-molina when you use this code to align the Data Zoom slide perfectly. yAxisIndex: isHorizontal ? 60 : undefined,  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] fix: Data zoom with horizontal orientation [superset]
michael-s-molina merged PR #27291: URL: https://github.com/apache/superset/pull/27291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] fix: Data zoom with horizontal orientation [superset]
codecov[bot] commented on PR #27291: URL: https://github.com/apache/superset/pull/27291#issuecomment-1969877054 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27291?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `0%` with `2 lines` in your changes are missing coverage. Please review. > Project coverage is 67.33%. Comparing base [(`9900f56`)](https://app.codecov.io/gh/apache/superset/commit/9900f566700e6d0a2c376aa4260a0a3f4db27404?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`c271d30`)](https://app.codecov.io/gh/apache/superset/pull/27291?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). | [Files](https://app.codecov.io/gh/apache/superset/pull/27291?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [...gin-chart-echarts/src/Timeseries/transformProps.ts](https://app.codecov.io/gh/apache/superset/pull/27291?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1Qcm9wcy50cw==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/27291?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...lugin-chart-echarts/src/Timeseries/transformers.ts](https://app.codecov.io/gh/apache/superset/pull/27291?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1lcnMudHM=) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/27291?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@Coverage Diff @@ ## master #27291 +/- ## == - Coverage 67.33% 67.33% -0.01% == Files1908 1908 Lines 7454374544 +1 Branches 8313 8314 +1 == - Hits5019650193 -3 - Misses 2229522299 +4 Partials 2052 2052 ``` | [Flag](https://app.codecov.io/gh/apache/superset/pull/27291/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/apache/superset/pull/27291/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `57.17% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/27291?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[PR] fix: Data zoom with horizontal orientation [superset]
michael-s-molina opened a new pull request, #27291: URL: https://github.com/apache/superset/pull/27291 ### SUMMARY Fixes a bug where the data zoom tool was displayed below the chart when a chart was defined with horizontal orientation. Fixes https://github.com/apache/superset/issues/26667 ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Now the data zoom tool changes according to the chart's orientation. https://github.com/apache/superset/assets/70410625/9638be07-65de-4b72-a3ad-586f8cd3d6a8 ### TESTING INSTRUCTIONS Check the video for instructions. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
