[xwiki-notifications] Build XWiki Enterprise Manager::Trunk #864 failed
Build XWiki Enterprise Manager::Trunk #864 failed Agent: Default agent Build results: http://teamcity.xwiki.org/viewLog.html?buildId=5772&buildTypeId=bt11 Configure email notifications: http://teamcity.xwiki.org/profile.html?init=1#notifications ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] Build XWiki Enterprise::1.1 #318 failed
Build XWiki Enterprise::1.1 #318 failed Agent: Default agent Build results: http://teamcity.xwiki.org/viewLog.html?buildId=5771&buildTypeId=bt24 Configure email notifications: http://teamcity.xwiki.org/profile.html?init=1#notifications ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] Build Curriki::Trunk #932 failed
Build Curriki::Trunk #932 failed Agent: Default agent Build results: http://teamcity.xwiki.org/viewLog.html?buildId=5770&buildTypeId=bt12 Configure email notifications: http://teamcity.xwiki.org/profile.html?init=1#notifications ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] Build XWiki Enterprise::Trunk #795 failed
Build XWiki Enterprise::Trunk #795 failed Agent: Default agent Build results: http://teamcity.xwiki.org/viewLog.html?buildId=5769&buildTypeId=bt7 Configure email notifications: http://teamcity.xwiki.org/profile.html?init=1#notifications ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] Build XWiki Enterprise Manager::Trunk #863 failed
Build XWiki Enterprise Manager::Trunk #863 failed Agent: Default agent Build results: http://teamcity.xwiki.org/viewLog.html?buildId=5766&buildTypeId=bt11 Configure email notifications: http://teamcity.xwiki.org/profile.html?init=1#notifications ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] Build XWiki Enterprise::Trunk #794 failed
Build XWiki Enterprise::Trunk #794 failed Agent: Default agent Build results: http://teamcity.xwiki.org/viewLog.html?buildId=5762&buildTypeId=bt7 Configure email notifications: http://teamcity.xwiki.org/profile.html?init=1#notifications ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] Build XWiki Enterprise::1.1 #317 failed
Build XWiki Enterprise::1.1 #317 failed Agent: Default agent Build results: http://teamcity.xwiki.org/viewLog.html?buildId=5761&buildTypeId=bt24 Configure email notifications: http://teamcity.xwiki.org/profile.html?init=1#notifications ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] Build Curriki::Trunk #931 failed
Build Curriki::Trunk #931 failed Agent: Default agent Build results: http://teamcity.xwiki.org/viewLog.html?buildId=5760&buildTypeId=bt12 Configure email notifications: http://teamcity.xwiki.org/profile.html?init=1#notifications ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] Build XWiki Enterprise Manager::Trunk #862 failed
Build XWiki Enterprise Manager::Trunk #862 failed Agent: Default agent Build results: http://teamcity.xwiki.org/viewLog.html?buildId=5756&buildTypeId=bt11 Configure email notifications: http://teamcity.xwiki.org/profile.html?init=1#notifications ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] Build XWiki Enterprise::Trunk #793 failed
Build XWiki Enterprise::Trunk #793 failed Agent: Default agent Build results: http://teamcity.xwiki.org/viewLog.html?buildId=5751&buildTypeId=bt7 Configure email notifications: http://teamcity.xwiki.org/profile.html?init=1#notifications ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] r6037 - in xwiki-products/curriki/trunk/gwt/src/main/java/org/curriki/gwt: client server
Author: dward Date: 2007-11-20 18:06:40 +0100 (Tue, 20 Nov 2007) New Revision: 6037 Modified: xwiki-products/curriki/trunk/gwt/src/main/java/org/curriki/gwt/client/Constants.java xwiki-products/curriki/trunk/gwt/src/main/java/org/curriki/gwt/server/CurrikiServiceImpl.java Log: - CURRIKI-1150 - Keywords are now inherited Modified: xwiki-products/curriki/trunk/gwt/src/main/java/org/curriki/gwt/client/Constants.java === --- xwiki-products/curriki/trunk/gwt/src/main/java/org/curriki/gwt/client/Constants.java 2007-11-20 16:08:06 UTC (rev 6036) +++ xwiki-products/curriki/trunk/gwt/src/main/java/org/curriki/gwt/client/Constants.java 2007-11-20 17:06:40 UTC (rev 6037) @@ -52,6 +52,7 @@ public static final String ASSET_CATEGORY_PROPERTY = "category"; public static final String ASSET_FW_ITEMS_PROPERTY = "fw_items"; public static final String ASSET_DESCRIPTION_PROPERTY = "description"; +public static final String ASSET_KEYWORDS_PROPERTY = "keywords"; public static final String ASSET_EDUCATIONAL_LEVEL_PROPERTY = "educational_level2"; public static final String ASSET_LANGUAGE_PROPERTY = "language"; public static final String ASSET_INSTRUCTIONAL_COMPONENT_PROPERTY = "instructional_component2"; Modified: xwiki-products/curriki/trunk/gwt/src/main/java/org/curriki/gwt/server/CurrikiServiceImpl.java === --- xwiki-products/curriki/trunk/gwt/src/main/java/org/curriki/gwt/server/CurrikiServiceImpl.java 2007-11-20 16:08:06 UTC (rev 6036) +++ xwiki-products/curriki/trunk/gwt/src/main/java/org/curriki/gwt/server/CurrikiServiceImpl.java 2007-11-20 17:06:40 UTC (rev 6037) @@ -834,10 +834,9 @@ BaseObject parentObjAsset = (BaseObject) compositeAssetDoc.getObject(Constants.ASSET_CLASS).clone(); copyProperty(parentObjAsset, newObjAsset, Constants.ASSET_EDUCATIONAL_LEVEL_PROPERTY); - copyProperty(parentObjAsset, newObjAsset, Constants.ASSET_FW_ITEMS_PROPERTY); - copyProperty(parentObjAsset, newObjAsset, Constants.ASSET_RIGHTS_PROPERTY); +copyProperty(parentObjAsset, newObjAsset, Constants.ASSET_KEYWORDS_PROPERTY); } // let's make sure default value is not empty @@ -943,6 +942,7 @@ mergeProperty(parentObjAsset, newObjAsset, Constants.ASSET_EDUCATIONAL_LEVEL_PROPERTY); mergeProperty(parentObjAsset, newObjAsset, Constants.ASSET_FW_ITEMS_PROPERTY); copyProperty(parentObjAsset, newObjAsset, Constants.ASSET_RIGHTS_PROPERTY); +mergeProperty(parentObjAsset, newObjAsset, Constants.ASSET_KEYWORDS_PROPERTY); } // let's make sure default value is not empty ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] Build XWiki Enterprise::Trunk #792 failed (tests failed: 5, passed: 221)
Build XWiki Enterprise::Trunk #792 failed (tests failed: 5, passed: 221) Agent: Default agent Build results: http://teamcity.xwiki.org/viewLog.html?buildId=5744&buildTypeId=bt7 Failed tests (5 tests, only first 3 failures shown here) == com.xpn.xwiki.it.xmlrpc.AllTests.Validating XWiki.XWikiAdminGroup = com.xpn.xwiki.it.xmlrpc.AllTests.Validating XWiki.Admin = com.xpn.xwiki.it.xmlrpc.AllTests.Validating XWiki.XWikiGroupTemplate = see all newly failed tests: http://teamcity.xwiki.org/viewLog.html?buildId=5744&buildTypeId=bt7 Configure email notifications: http://teamcity.xwiki.org/profile.html?init=1#notifications ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Updated: (XWIKI-1740) Add full xwiki virtual mode support for hsqldb and derby
[ http://jira.xwiki.org/jira/browse/XWIKI-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mortagne updated XWIKI-1740: --- Priority: Critical (was: Major) > Add full xwiki virtual mode support for hsqldb and derby > > > Key: XWIKI-1740 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1740 > Project: XWiki Platform > Issue Type: New Feature > Components: Core >Affects Versions: 1.1.1, 1.2 M1 >Reporter: Thomas Mortagne > Assigned To: Vincent Massol >Priority: Critical > Fix For: Future > > Attachments: 20070912-fix-xwikivirtualmode-hsqldb-derby.txt, > 20070912-fix-xwikivirtualmode-hsqldb-derby.txt > > > HSQLDB or DERBY can't be used in virtual mode (multiwiki) because theses > database engines does not support : > - "create database" sql request in XWikiHibernateStore.createWiki > - getCatalog() jdbc api in XWikiHibernateBaseStore.setDatabase -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Updated: (XWIKI-1648) Copy and save document with included content
[ http://jira.xwiki.org/jira/browse/XWIKI-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mortagne updated XWIKI-1648: --- Priority: Minor (was: Blocker) > Copy and save document with included content > > > Key: XWIKI-1648 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1648 > Project: XWiki Platform > Issue Type: New Feature > Components: Core >Affects Versions: 1.1 M4 >Reporter: Thomas Mortagne >Priority: Minor > Attachments: 20070821-copy-and-save-document-include.patch, > 20070821-copy-and-save-document-include.patch > > > Add parameter to XWiki.copyDocument include document content when we copy it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Closed: (XTOOLS-19) The Maven xar builder use file name in place of real document name
[ http://jira.xwiki.org/jira/browse/XTOOLS-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mortagne closed XTOOLS-19. - Fix Version/s: 1.7 Resolution: Fixed Assignee: Thomas Mortagne > The Maven xar builder use file name in place of real document name > -- > > Key: XTOOLS-19 > URL: http://jira.xwiki.org/jira/browse/XTOOLS-19 > Project: XWiki Platform Tools > Issue Type: Bug > Components: XAR Plugin >Affects Versions: 1.6 >Reporter: Thomas Mortagne > Assigned To: Thomas Mortagne > Fix For: 1.7 > > > When generating package.xml file the plugin sould get the real document full > name from xml content in place of using directory and file name. This could > allow us to have files with "xml" extension that is better for IDEs and > subversion. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Closed: (XWATCH-70) create a distribution module
[ http://jira.xwiki.org/jira/browse/XWATCH-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jerome Velociter closed XWATCH-70. -- Resolution: Fixed > create a distribution module > > > Key: XWATCH-70 > URL: http://jira.xwiki.org/jira/browse/XWATCH-70 > Project: XWiki Watch > Issue Type: Task > Components: Build, Test & Packaging >Affects Versions: 1.0M1 >Reporter: Jerome Velociter > Assigned To: Jerome Velociter > Fix For: 1.0M2 > > > Create a distribution module that allows to packages various distributions of > XWiki Watch for differents databases and possibly different containers (e.g: > hsqldb + jetty, mysql + jetty, etc.) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Closed: (XWATCH-69) Create a database module
[ http://jira.xwiki.org/jira/browse/XWATCH-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jerome Velociter closed XWATCH-69. -- Resolution: Fixed > Create a database module > > > Key: XWATCH-69 > URL: http://jira.xwiki.org/jira/browse/XWATCH-69 > Project: XWiki Watch > Issue Type: Task > Components: Build, Test & Packaging >Reporter: Jerome Velociter > Assigned To: Jerome Velociter > Fix For: 1.0M2 > > > Create a database module that prepares embedded database with xar content. > (e.g. hsqldb, derby) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Closed: (XWATCH-68) Create a M2 build for Watch
[ http://jira.xwiki.org/jira/browse/XWATCH-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jerome Velociter closed XWATCH-68. -- Resolution: Fixed > Create a M2 build for Watch > --- > > Key: XWATCH-68 > URL: http://jira.xwiki.org/jira/browse/XWATCH-68 > Project: XWiki Watch > Issue Type: New Feature > Components: Build, Test & Packaging >Affects Versions: 1.0M1 >Reporter: Jerome Velociter > Assigned To: Jerome Velociter > Fix For: 1.0M2 > > > Create a full m2 build for XWiki Watch with : > - Java to JS GWT compilation > - Jetty run profile > So that it's possible to run Watch from the sources with a single line maven > command -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Closed: (XWATCH-81) current keyword highlight does not differentiate on the group of the keyword
[ http://jira.xwiki.org/jira/browse/XWATCH-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jerome Velociter closed XWATCH-81. -- Fix Version/s: 1.0M2 Resolution: Fixed > current keyword highlight does not differentiate on the group of the keyword > > > Key: XWATCH-81 > URL: http://jira.xwiki.org/jira/browse/XWATCH-81 > Project: XWiki Watch > Issue Type: Bug > Components: Filters >Affects Versions: 1.0M1 >Reporter: Anca Paula Luca >Priority: Minor > Fix For: 1.0M2 > > Attachments: XWATCH-81.patch > > > If there are 2 keywords with the same value but different groups, they are > all highlighted when one of them is clicked, but only the clicked one is > applied. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] r6036 - xwiki-products/xwiki-watch/trunk/web/src/main/java/com/xpn/xwiki/watch/client/ui/menu
Author: jvelociter Date: 2007-11-20 17:08:06 +0100 (Tue, 20 Nov 2007) New Revision: 6036 Modified: xwiki-products/xwiki-watch/trunk/web/src/main/java/com/xpn/xwiki/watch/client/ui/menu/KeywordsWidget.java Log: XWATCH-81 current keyword highlight does not differentiate on the group of the keyword Patch submited by Anca Paula Luca Modified: xwiki-products/xwiki-watch/trunk/web/src/main/java/com/xpn/xwiki/watch/client/ui/menu/KeywordsWidget.java === --- xwiki-products/xwiki-watch/trunk/web/src/main/java/com/xpn/xwiki/watch/client/ui/menu/KeywordsWidget.java 2007-11-20 16:05:07 UTC (rev 6035) +++ xwiki-products/xwiki-watch/trunk/web/src/main/java/com/xpn/xwiki/watch/client/ui/menu/KeywordsWidget.java 2007-11-20 16:08:06 UTC (rev 6036) @@ -62,11 +62,13 @@ public void resetSelections() { Iterator it = keywordsLink.keySet().iterator(); String keywordactive = watch.getFilterStatus().getKeyword(); +String groupactive = watch.getFilterStatus().getGroup(); while (it.hasNext()) { Keyword keyword = (Keyword) it.next(); Hyperlink link = (Hyperlink) keywordsLink.get(keyword); if (link!=null) { -if (keyword.getName().equals(keywordactive)) { +if (keyword.getName().equals(keywordactive) +&& keyword.getGroup().equals(groupactive)) { link.addStyleName(watch.getStyleName("keyword", "link-active")); } else { link.removeStyleName(watch.getStyleName("keyword", "link-active")); ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] r6035 - xwiki-platform/xwiki-tools/trunk/build-tools/build-xar-plugin
Author: tmortagne Date: 2007-11-20 17:05:07 +0100 (Tue, 20 Nov 2007) New Revision: 6035 Modified: xwiki-platform/xwiki-tools/trunk/build-tools/build-xar-plugin/ Log: Add Eclipse checkstyle plugin properties to svn:ignore. Property changes on: xwiki-platform/xwiki-tools/trunk/build-tools/build-xar-plugin ___ Name: svn:ignore - target *.ipr *.iml .classpath .project nbproject + target *.ipr *.iml .classpath .project nbproject .checkstyle ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] r6034 - in xwiki-platform/xwiki-tools/trunk/build-tools/build-xar-plugin: . src/main/java/com/xpn/xwiki/tool/xar
Author: tmortagne Date: 2007-11-20 17:02:51 +0100 (Tue, 20 Nov 2007) New Revision: 6034 Added: xwiki-platform/xwiki-tools/trunk/build-tools/build-xar-plugin/src/main/java/com/xpn/xwiki/tool/xar/AbstractXarMojo.java xwiki-platform/xwiki-tools/trunk/build-tools/build-xar-plugin/src/main/java/com/xpn/xwiki/tool/xar/XWikiDocument.java Modified: xwiki-platform/xwiki-tools/trunk/build-tools/build-xar-plugin/pom.xml xwiki-platform/xwiki-tools/trunk/build-tools/build-xar-plugin/src/main/java/com/xpn/xwiki/tool/xar/UnXarMojo.java xwiki-platform/xwiki-tools/trunk/build-tools/build-xar-plugin/src/main/java/com/xpn/xwiki/tool/xar/XarMojo.java Log: * XTOOLS-19: The Maven xar builder use file name in place of real document name * improve xar plugin to follow XWiki checkstyle rules. Modified: xwiki-platform/xwiki-tools/trunk/build-tools/build-xar-plugin/pom.xml === --- xwiki-platform/xwiki-tools/trunk/build-tools/build-xar-plugin/pom.xml 2007-11-20 15:24:56 UTC (rev 6033) +++ xwiki-platform/xwiki-tools/trunk/build-tools/build-xar-plugin/pom.xml 2007-11-20 16:02:51 UTC (rev 6034) @@ -54,5 +54,26 @@ maven-artifact 2.0 + + dom4j + dom4j + 1.6.1 + + + + + +org.apache.maven.plugins +maven-checkstyle-plugin + + +com.xpn.xwiki.platform +xwiki-build-verifications +${pom.version} + + + + + Added: xwiki-platform/xwiki-tools/trunk/build-tools/build-xar-plugin/src/main/java/com/xpn/xwiki/tool/xar/AbstractXarMojo.java === --- xwiki-platform/xwiki-tools/trunk/build-tools/build-xar-plugin/src/main/java/com/xpn/xwiki/tool/xar/AbstractXarMojo.java (rev 0) +++ xwiki-platform/xwiki-tools/trunk/build-tools/build-xar-plugin/src/main/java/com/xpn/xwiki/tool/xar/AbstractXarMojo.java 2007-11-20 16:02:51 UTC (rev 6034) @@ -0,0 +1,79 @@ +package com.xpn.xwiki.tool.xar; + +import java.io.File; +import java.io.InputStream; +import java.util.ArrayList; +import java.util.List; + +import org.apache.maven.plugin.AbstractMojo; +import org.apache.maven.plugin.MojoExecutionException; +import org.codehaus.plexus.archiver.ArchiveFileFilter; +import org.codehaus.plexus.archiver.zip.ZipUnArchiver; +import org.codehaus.plexus.logging.Logger; +import org.codehaus.plexus.logging.console.ConsoleLogger; + +/** + * Base class for xar and unxar mojos. + * + * @version $Id: $ + */ +abstract class AbstractXarMojo extends AbstractMojo +{ +/** + * Open hook. + */ +protected static final String HOOK_OPEN = "["; + +/** + * Close hook. + */ +protected static final String HOOK_CLOSE = "]"; + +/** + * The name of the file in the package when to find general informations. + */ +protected static final String PACKAGE_XML = "package.xml"; + +/** + * Unpacks the XAR file (exclude the package.xml file if it exists). + * + * @param file the file to be unpacked. + * @param location the location where to put the unpacket files. + * @param logName the name use with [EMAIL PROTECTED] ConsoleLogger}. + * @param overwrite indicate if extracted files has to overwrite existing ones. + * @throws MojoExecutionException error when unpacking the file. + */ +protected void unpack(File file, File location, String logName, boolean overwrite) +throws MojoExecutionException +{ +try { +ZipUnArchiver unArchiver = new ZipUnArchiver(); +unArchiver.enableLogging(new ConsoleLogger(Logger.LEVEL_ERROR, logName)); +unArchiver.setSourceFile(file); +unArchiver.setDestDirectory(location); + +// Ensure that we don't overwrite XML document files present in this project since +// we want those to be used and not the ones in the dependent XAR. +unArchiver.setOverwrite(overwrite); + +if (!overwrite) { +// Do not unpack any package.xml file in dependant XARs. We'll generate a complete +// one automatically. +List filters = new ArrayList(); +filters.add(new ArchiveFileFilter() +{ +public boolean include(InputStream dataStream, String entryName) +{ +return (!entryName.equals(PACKAGE_XML)); +} +}); +unArchiver.setArchiveFilters(filters); +} + +unArchiver.extract(); +} catch (Exception e) { +throw new MojoExecutionException("Error unpacking file " + HOOK_OPEN + file ++ HOOK_CLOSE + " to " + HOOK_OPEN + location + HOOK_CLOSE, e); +} +} +} Property changes on: xwiki-platform/xwiki-too
[xwiki-notifications] [Issue] Updated: (XWATCH-81) current keyword highlight does not differentiate on the group of the keyword
[ http://jira.xwiki.org/jira/browse/XWATCH-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anca Paula Luca updated XWATCH-81: -- Attachment: XWATCH-81.patch On setting the active key, the equality test should be done by both keyword value and group name. > current keyword highlight does not differentiate on the group of the keyword > > > Key: XWATCH-81 > URL: http://jira.xwiki.org/jira/browse/XWATCH-81 > Project: XWiki Watch > Issue Type: Bug > Components: Filters >Affects Versions: 1.0M1 >Reporter: Anca Paula Luca >Priority: Minor > Attachments: XWATCH-81.patch > > > If there are 2 keywords with the same value but different groups, they are > all highlighted when one of them is clicked, but only the clicked one is > applied. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Created: (XWATCH-81) current keyword highlight does not differentiate on the group of the keyword
current keyword highlight does not differentiate on the group of the keyword Key: XWATCH-81 URL: http://jira.xwiki.org/jira/browse/XWATCH-81 Project: XWiki Watch Issue Type: Bug Components: Filters Affects Versions: 1.0M1 Reporter: Anca Paula Luca Priority: Minor If there are 2 keywords with the same value but different groups, they are all highlighted when one of them is clicked, but only the clicked one is applied. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] Build XWiki Enterprise::Trunk #791 failed (tests failed: 5, passed: 221)
Build XWiki Enterprise::Trunk #791 failed (tests failed: 5, passed: 221) Agent: Default agent Build results: http://teamcity.xwiki.org/viewLog.html?buildId=5737&buildTypeId=bt7 Failed tests (5 tests, only first 3 failures shown here) == com.xpn.xwiki.it.xmlrpc.AllTests.Validating XWiki.XWikiAdminGroup = com.xpn.xwiki.it.xmlrpc.AllTests.Validating XWiki.Admin = com.xpn.xwiki.it.xmlrpc.AllTests.Validating XWiki.XWikiGroupTemplate = see all newly failed tests: http://teamcity.xwiki.org/viewLog.html?buildId=5737&buildTypeId=bt7 Configure email notifications: http://teamcity.xwiki.org/profile.html?init=1#notifications ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Commented: (XWIKI-1845) Create improved Statistics API
[ http://jira.xwiki.org/jira/browse/XWIKI-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19767 ] Vincent Massol commented on XWIKI-1845: --- For rename I think we need to implement the jira issue about keeping the old name pointing to the new document name (same as what jira is doing for renames and deletes). > Create improved Statistics API > -- > > Key: XWIKI-1845 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1845 > Project: XWiki Platform > Issue Type: Improvement > Components: Statistics >Affects Versions: 1.2 M1 > Environment: any >Reporter: Marius Dumitru Florea > Assigned To: Marius Dumitru Florea > Fix For: 1.2 RC1 > > Attachments: stats-api.diff.txt, > stats-DoNotApply-JustAPrototype.diff.txt, Stats-FinalPreview.diff.txt, > xe-140.diff.txt > > > Improve the Statistics Application in order to allow the retrieval of the > most viewed pages, the most edited pages and the best contributors. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Commented: (XWIKI-1845) Create improved Statistics API
[ http://jira.xwiki.org/jira/browse/XWIKI-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19766 ] Sergiu Dumitriu commented on XWIKI-1845: I think the issue is a semantical one: what do we log, document access, or URL access? > Create improved Statistics API > -- > > Key: XWIKI-1845 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1845 > Project: XWiki Platform > Issue Type: Improvement > Components: Statistics >Affects Versions: 1.2 M1 > Environment: any >Reporter: Marius Dumitru Florea > Assigned To: Marius Dumitru Florea > Fix For: 1.2 RC1 > > Attachments: stats-api.diff.txt, > stats-DoNotApply-JustAPrototype.diff.txt, Stats-FinalPreview.diff.txt, > xe-140.diff.txt > > > Improve the Statistics Application in order to allow the retrieval of the > most viewed pages, the most edited pages and the best contributors. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Commented: (XWIKI-1845) Create improved Statistics API
[ http://jira.xwiki.org/jira/browse/XWIKI-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19765 ] Sergiu Dumitriu commented on XWIKI-1845: Then how about rename? > Create improved Statistics API > -- > > Key: XWIKI-1845 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1845 > Project: XWiki Platform > Issue Type: Improvement > Components: Statistics >Affects Versions: 1.2 M1 > Environment: any >Reporter: Marius Dumitru Florea > Assigned To: Marius Dumitru Florea > Fix For: 1.2 RC1 > > Attachments: stats-api.diff.txt, > stats-DoNotApply-JustAPrototype.diff.txt, Stats-FinalPreview.diff.txt, > xe-140.diff.txt > > > Improve the Statistics Application in order to allow the retrieval of the > most viewed pages, the most edited pages and the best contributors. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Commented: (XWIKI-1845) Create improved Statistics API
[ http://jira.xwiki.org/jira/browse/XWIKI-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19764 ] Vincent Massol commented on XWIKI-1845: --- I don't think they should be deleted especially since we know don't delete anymore... (recycle bin) > Create improved Statistics API > -- > > Key: XWIKI-1845 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1845 > Project: XWiki Platform > Issue Type: Improvement > Components: Statistics >Affects Versions: 1.2 M1 > Environment: any >Reporter: Marius Dumitru Florea > Assigned To: Marius Dumitru Florea > Fix For: 1.2 RC1 > > Attachments: stats-api.diff.txt, > stats-DoNotApply-JustAPrototype.diff.txt, Stats-FinalPreview.diff.txt, > xe-140.diff.txt > > > Improve the Statistics Application in order to allow the retrieval of the > most viewed pages, the most edited pages and the best contributors. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Updated: (XWIKI-1774) Authentication lost when using more than one reverse proxies
[ http://jira.xwiki.org/jira/browse/XWIKI-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergiu Dumitriu updated XWIKI-1774: --- Fix Version/s: 1.2 RC1 Assignee: Sergiu Dumitriu Fixed in rev. 6033, we need someone to test it. Eric, Robert, can one of you please try this with the code from the SVN? > Authentication lost when using more than one reverse proxies > > > Key: XWIKI-1774 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1774 > Project: XWiki Platform > Issue Type: Bug > Components: Rights Management >Affects Versions: 1.0, 1.1.1 > Environment: linux RHEL 4.4 / HP DL385 / tomcat 5.5.23 apache 2.0.59 > /mysql 5.0 >Reporter: Eric Grandjean > Assigned To: Sergiu Dumitriu >Priority: Critical > Fix For: 1.2 RC1 > > > using 2 redline server in front of 2 apache server in front of 1 tomcat server > user lost authentication > we have the following message in catalina.out > when we authentifie > !remember-me cookie validation hash mismatch! > !remember-me cookie has been tampered with! > !remember-me cookie is being deleted! > we of course remove cookies ( client side ) > using 1 redline server in front of 1 apache server in front fo 1 tomcat server > every thing works fine -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] r6033 - xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki
Author: sdumitriu Date: 2007-11-20 16:24:56 +0100 (Tue, 20 Nov 2007) New Revision: 6033 Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/MyPersistentLoginManager.java Log: XWIKI-1774: Authentication lost when using more than one reverse proxies Fixed. Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/MyPersistentLoginManager.java === --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/MyPersistentLoginManager.java 2007-11-20 14:28:27 UTC (rev 6032) +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/MyPersistentLoginManager.java 2007-11-20 15:24:56 UTC (rev 6033) @@ -21,10 +21,12 @@ package com.xpn.xwiki.user.impl.xwiki; +import java.io.IOException; import java.security.MessageDigest; import java.security.NoSuchAlgorithmException; import javax.crypto.Cipher; +import javax.servlet.ServletException; import javax.servlet.http.Cookie; import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; @@ -40,7 +42,7 @@ * parameter. * * The cookies used are: - * > + * * username * The logged in username * password @@ -182,7 +184,7 @@ if (protection.equals(PROTECTION_ALL) || protection.equals(PROTECTION_VALIDATION)) { String validationHash = -getValidationHash(protectedUsername, protectedPassword, request.getRemoteAddr()); +getValidationHash(protectedUsername, protectedPassword, getClientIP(request)); if (validationHash != null) { // Validation Cookie validationCookie = new Cookie(COOKIE_VALIDATION, validationHash); @@ -419,4 +421,147 @@ { return "true".equals(text) || "1".equals(text) || "yes".equals(text); } + +/** + * Given an array of Cookies, a name, and a default value, this method tries to find the value + * of the cookie with the given name. If there is no cookie matching the name in the array, then + * the default value is returned instead. + */ +private static String getCookieValue(Cookie[] cookies, String cookieName, String defaultValue) +{ +if (cookies != null) { +for (int i = 0; i < cookies.length; i++) { +Cookie cookie = cookies[i]; +if (cookieName.equals(cookie.getName())) { +return (cookie.getValue()); +} +} +} +return (defaultValue); +} + +/** + * Get remembered username + * + * @param request the servlet request + * @param response the servlet response + * @return the username value or null if not found or a problem with security of cookie + */ +public String getRememberedUsername(HttpServletRequest request, HttpServletResponse response) +throws IOException, ServletException +{ +String username = getCookieValue(request.getCookies(), COOKIE_USERNAME, "false"); +String password = getCookieValue(request.getCookies(), COOKIE_PASSWORD, "false"); + +String validationHash = getCookieValue(request.getCookies(), COOKIE_VALIDATION, "false"); +if (!username.equals("false")) { +if (!validationHash.equals("false")) { +// check hash +String calculatedHash = +getValidationHash(username, password, getClientIP(request)); +if (validationHash.equals(calculatedHash)) { +if (protection.equals(PROTECTION_ALL) +|| protection.equals(PROTECTION_ENCRYPTION)) { +username = decryptText(username); +} +return username; +} else { +System.out.println("!remember-me cookie validation hash mismatch! "); +System.out.println("!remember-me cookie has been tampered with! "); +System.out.println("!remember-me cookie is being deleted! "); +removeCookie(request, response, COOKIE_USERNAME); +removeCookie(request, response, COOKIE_PASSWORD); +removeCookie(request, response, COOKIE_REMEMBERME); +removeCookie(request, response, COOKIE_VALIDATION); +return null; +} +} else { +if (protection.equals(PROTECTION_ALL) || protection.equals(PROTECTION_ENCRYPTION)) { +username = decryptText(username); +} +return username; +} +} else { +return null; +} +} + +/** + * Get remembered password + * + * @param request the servlet request + * @param response the servlet response + * @return the pas
[xwiki-notifications] [Issue] Commented: (XWIKI-1845) Create improved Statistics API
[ http://jira.xwiki.org/jira/browse/XWIKI-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19762 ] Sergiu Dumitriu commented on XWIKI-1845: About 3, we need to decide what should we do. Should statistics be updated when deleting/renaming a document? > Create improved Statistics API > -- > > Key: XWIKI-1845 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1845 > Project: XWiki Platform > Issue Type: Improvement > Components: Statistics >Affects Versions: 1.2 M1 > Environment: any >Reporter: Marius Dumitru Florea > Assigned To: Marius Dumitru Florea > Fix For: 1.2 RC1 > > Attachments: stats-api.diff.txt, > stats-DoNotApply-JustAPrototype.diff.txt, Stats-FinalPreview.diff.txt, > xe-140.diff.txt > > > Improve the Statistics Application in order to allow the retrieval of the > most viewed pages, the most edited pages and the best contributors. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] Build XWiki Enterprise::1.1 #315 failed (tests failed: 1 (1 new), passed: 4)
Build XWiki Enterprise::1.1 #315 failed (tests failed: 1 (1 new), passed: 4) Agent: Default agent Build results: http://teamcity.xwiki.org/viewLog.html?buildId=5736&buildTypeId=bt24 Newly failed tests (1 test) == com.xpn.xwiki.it.xmlrpc.AllTests.testValidityOfAllDocumentsInDefaultWiki = Configure email notifications: http://teamcity.xwiki.org/profile.html?init=1#notifications ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Commented: (XWIKI-1868) Caching documents breaks the WYSIWYG editors for the inline edit mode
[ http://jira.xwiki.org/jira/browse/XWIKI-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19761 ] Sergiu Dumitriu commented on XWIKI-1868: Partially fixed by causing the inline mode not to be cached. We still need to make sure that the editors are available in other modes, for example you can do a $doc.displayEdit in view mode. I think that we need to initialize the editor in another way, like using a (css) class? > Caching documents breaks the WYSIWYG editors for the inline edit mode > - > > Key: XWIKI-1868 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1868 > Project: XWiki Platform > Issue Type: Bug > Components: Core >Affects Versions: 1.2 M2 >Reporter: Sergiu Dumitriu > > This is caused by the fact that the editors are collected in a > request-context variable when interpreting the content, and then the editor > is activated for those fields listed in the context. But when caching the > rendered content, the list of fields is not computed anymore, so the editor > will not be enabled. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Updated: (XWIKI-1845) Create improved Statistics API
[ http://jira.xwiki.org/jira/browse/XWIKI-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marius Dumitru Florea updated XWIKI-1845: - Attachment: stats-api.diff.txt Vincent, here's the patch for the API. There are some problems that should be solved in the future: 1. The number of page views increases on page refresh 2. The number of saves increases on empty change (save without changing anything) 3. When a page is deleted its stats are not. This way it is possible that the most viewed page, as reported by the stats application, to not exist any more. > Create improved Statistics API > -- > > Key: XWIKI-1845 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1845 > Project: XWiki Platform > Issue Type: Improvement > Components: Statistics >Affects Versions: 1.2 M1 > Environment: any >Reporter: Marius Dumitru Florea > Assigned To: Marius Dumitru Florea > Fix For: 1.2 RC1 > > Attachments: stats-api.diff.txt, > stats-DoNotApply-JustAPrototype.diff.txt, Stats-FinalPreview.diff.txt, > xe-140.diff.txt > > > Improve the Statistics Application in order to allow the retrieval of the > most viewed pages, the most edited pages and the best contributors. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Updated: (XE-37) Improve the statistics page to display most viewed pages, most edited pages and best contributors with graphs and history
[ http://jira.xwiki.org/jira/browse/XE-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marius Dumitru Florea updated XE-37: Attachment: stats-ui.diff.txt Vincent, here's the patch for the UI. I'm not sure about the statistics application's pom file. You should look if everything is fine. > Improve the statistics page to display most viewed pages, most edited pages > and best contributors with graphs and history > - > > Key: XE-37 > URL: http://jira.xwiki.org/jira/browse/XE-37 > Project: XWiki Enterprise > Issue Type: Improvement > Components: Statistics Application >Affects Versions: 1.0 >Reporter: Vincent Massol > Assigned To: Marius Dumitru Florea > Fix For: 1.2 RC1 > > Attachments: stats-ui.diff.txt, xwiki-stats-SplitLayoutA.jpg, > xwiki-stats-SplitLayoutB.jpg, xwiki-stats.jpg > > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] Build XWiki Enterprise::Trunk #790 failed (tests failed: 5, passed: 221)
Build XWiki Enterprise::Trunk #790 failed (tests failed: 5, passed: 221) Agent: Default agent Build results: http://teamcity.xwiki.org/viewLog.html?buildId=5731&buildTypeId=bt7 Failed tests (5 tests, only first 3 failures shown here) == com.xpn.xwiki.it.xmlrpc.AllTests.Validating XWiki.XWikiAdminGroup = com.xpn.xwiki.it.xmlrpc.AllTests.Validating XWiki.Admin = com.xpn.xwiki.it.xmlrpc.AllTests.Validating XWiki.XWikiGroupTemplate = see all newly failed tests: http://teamcity.xwiki.org/viewLog.html?buildId=5731&buildTypeId=bt7 Configure email notifications: http://teamcity.xwiki.org/profile.html?init=1#notifications ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] r6032 - xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki
Author: sdumitriu Date: 2007-11-20 15:28:27 +0100 (Tue, 20 Nov 2007) New Revision: 6032 Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWikiConfig.java Log: Apply codestyle Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWikiConfig.java === --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWikiConfig.java 2007-11-20 14:13:53 UTC (rev 6031) +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWikiConfig.java 2007-11-20 14:28:27 UTC (rev 6032) @@ -29,41 +29,48 @@ import org.apache.commons.lang.StringUtils; -public class XWikiConfig extends Properties { - -public XWikiConfig() { -// Default constructor so that properties can be added after constructing the instance +public class XWikiConfig extends Properties +{ +public XWikiConfig() +{ +// Default constructor so that properties can be added after constructing the instance // by using XWikiConfig.put(). } - -public XWikiConfig(String path) throws XWikiException { - try { - FileInputStream fis = new FileInputStream(path); - loadConfig(fis, path); - } - catch (FileNotFoundException e) { - Object[] args = { path }; - throw new XWikiException(XWikiException.MODULE_XWIKI_CONFIG, - XWikiException.ERROR_XWIKI_CONFIG_FILENOTFOUND, - "Configuration file {0} not found", e, args); - } + +public XWikiConfig(String path) throws XWikiException +{ +try { +FileInputStream fis = new FileInputStream(path); +loadConfig(fis, path); +} catch (FileNotFoundException e) { +Object[] args = {path}; +throw new XWikiException(XWikiException.MODULE_XWIKI_CONFIG, +XWikiException.ERROR_XWIKI_CONFIG_FILENOTFOUND, +"Configuration file {0} not found", +e, +args); +} } -public XWikiConfig(InputStream is) throws XWikiException { - loadConfig(is, ""); +public XWikiConfig(InputStream is) throws XWikiException +{ +loadConfig(is, ""); } -public void loadConfig(InputStream is, String path) throws XWikiException { +public void loadConfig(InputStream is, String path) throws XWikiException +{ try { load(is); -} -catch (IOException e) { -Object[] args = { path }; +} catch (IOException e) { +Object[] args = {path}; throw new XWikiException(XWikiException.MODULE_XWIKI_CONFIG, XWikiException.ERROR_XWIKI_CONFIG_FORMATERROR, -"Error reading configuration file", e, args); +"Error reading configuration file", +e, +args); } } + /** * @return array of string splited from property. * @param param - name of property ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Updated: (XWIKI-1044) Refreshing cached documents affects only the current request
[ http://jira.xwiki.org/jira/browse/XWIKI-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergiu Dumitriu updated XWIKI-1044: --- Comment: was deleted > Refreshing cached documents affects only the current request > > > Key: XWIKI-1044 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1044 > Project: XWiki Platform > Issue Type: Bug > Components: Core >Affects Versions: 1.0 B5 >Reporter: Sergiu Dumitriu > Assigned To: Sergiu Dumitriu >Priority: Minor > Fix For: 1.2 RC1 > > > If I setup a cache for a document, for subsequent requests I get the version > stored in the cache. I can override this by ading the "refresh=1" query > parameter, but this does not refresh the cache, only returns the refreshed > document. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Closed: (XWIKI-1044) Refreshing cached documents affects only the current request
[ http://jira.xwiki.org/jira/browse/XWIKI-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergiu Dumitriu closed XWIKI-1044. -- Fix Version/s: 1.2 RC1 (was: Future) Resolution: Fixed Assignee: Sergiu Dumitriu (partially) fixed in rev. 6031 When using refresh=1, only the document matching the current language and query string (excluding the refresh parameter) is updated, and not all versions of that document. > Refreshing cached documents affects only the current request > > > Key: XWIKI-1044 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1044 > Project: XWiki Platform > Issue Type: Bug > Components: Core >Affects Versions: 1.0 B5 >Reporter: Sergiu Dumitriu > Assigned To: Sergiu Dumitriu >Priority: Minor > Fix For: 1.2 RC1 > > > If I setup a cache for a document, for subsequent requests I get the version > stored in the cache. I can override this by ading the "refresh=1" query > parameter, but this does not refresh the cache, only returns the refreshed > document. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Closed: (XWIKI-937) Caching documents breaks the inline edit mode
[ http://jira.xwiki.org/jira/browse/XWIKI-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergiu Dumitriu closed XWIKI-937. - Fix Version/s: 1.2 RC1 (was: Future) Resolution: Fixed Assignee: Sergiu Dumitriu Fixed in rev. 6029 > Caching documents breaks the inline edit mode > - > > Key: XWIKI-937 > URL: http://jira.xwiki.org/jira/browse/XWIKI-937 > Project: XWiki Platform > Issue Type: Bug > Components: Core >Affects Versions: 1.0 B1, 1.0 B2, 1.0 B3, 1.0 B4, 1.0 B5 >Reporter: Sergiu Dumitriu > Assigned To: Sergiu Dumitriu > Fix For: 1.2 RC1 > > > Using $context.setCacheDuration(something > 0) will cause the rendered > content to be cached. Now, this rendered content is used both by /view/ and > /inline/, which is wrong, because the inline mode will be exactly as the > view, without modifiable fields. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Closed: (XWIKI-1872) Inline editing doesn't update cached documents
[ http://jira.xwiki.org/jira/browse/XWIKI-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergiu Dumitriu closed XWIKI-1872. -- Fix Version/s: 1.2 RC1 Resolution: Fixed Assignee: Sergiu Dumitriu Fixed in rev. 6031 > Inline editing doesn't update cached documents > -- > > Key: XWIKI-1872 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1872 > Project: XWiki Platform > Issue Type: Bug > Components: Core >Affects Versions: 1.2 M2 >Reporter: Sergiu Dumitriu > Assigned To: Sergiu Dumitriu > Fix For: 1.2 RC1 > > > ...because the cache key is computed based on the document content, which > does not take into account object properties. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] r6031 - xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render
Author: sdumitriu Date: 2007-11-20 15:13:53 +0100 (Tue, 20 Nov 2007) New Revision: 6031 Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/DefaultXWikiRenderingEngine.java Log: XWIKI-1872: Inline editing doesn't update cached documents Fixed. Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/DefaultXWikiRenderingEngine.java === --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/DefaultXWikiRenderingEngine.java 2007-11-20 13:54:43 UTC (rev 6030) +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/DefaultXWikiRenderingEngine.java 2007-11-20 14:13:53 UTC (rev 6031) @@ -334,10 +334,12 @@ String db = ((context == null) ? "xwiki" : context.getDatabase()); String cdoc = ((contentdoc == null) ? "" : contentdoc.getDatabase() + ":" -+ contentdoc.getFullName() + ":" + contentdoc.getRealLanguage()); ++ contentdoc.getFullName() + ":" + contentdoc.getRealLanguage() + ":" ++ contentdoc.getVersion()); String idoc = ((includingdoc == null) ? "" : includingdoc.getDatabase() + ":" -+ includingdoc.getFullName() + ":" + includingdoc.getRealLanguage()); ++ includingdoc.getFullName() + ":" + includingdoc.getRealLanguage() + ":" ++ includingdoc.getVersion()); String action = ((context == null) ? "view" : context.getAction()); String lang = ((context == null) ? "" : context.getLanguage()); lang += ((contentdoc == null) ? "" : ":" + contentdoc.getRealLanguage()); ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] Build XWiki Enterprise::Trunk #789 failed (tests failed: 5, passed: 221)
Build XWiki Enterprise::Trunk #789 failed (tests failed: 5, passed: 221) Agent: Default agent Build results: http://teamcity.xwiki.org/viewLog.html?buildId=5727&buildTypeId=bt7 Failed tests (5 tests, only first 3 failures shown here) == com.xpn.xwiki.it.xmlrpc.AllTests.Validating XWiki.XWikiAdminGroup = com.xpn.xwiki.it.xmlrpc.AllTests.Validating XWiki.Admin = com.xpn.xwiki.it.xmlrpc.AllTests.Validating XWiki.XWikiGroupTemplate = see all newly failed tests: http://teamcity.xwiki.org/viewLog.html?buildId=5727&buildTypeId=bt7 Configure email notifications: http://teamcity.xwiki.org/profile.html?init=1#notifications ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Created: (XWIKI-1872) Inline editing doesn't update cached documents
Inline editing doesn't update cached documents -- Key: XWIKI-1872 URL: http://jira.xwiki.org/jira/browse/XWIKI-1872 Project: XWiki Platform Issue Type: Bug Components: Core Affects Versions: 1.2 M2 Reporter: Sergiu Dumitriu ...because the cache key is computed based on the document content, which does not take into account object properties. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Commented: (XWIKI-1870) Import failed if there are rcs revisions with author is empty
[ http://jira.xwiki.org/jira/browse/XWIKI-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19755 ] Artem Melentev commented on XWIKI-1870: --- @see XWIKI-1871 about patch() overriding > Import failed if there are rcs revisions with author is empty > - > > Key: XWIKI-1870 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1870 > Project: XWiki Platform > Issue Type: Bug > Components: Packaging, Storage >Affects Versions: 1.2 M2 >Reporter: Artem Melentev > Assigned To: Artem Melentev > Fix For: 1.2 RC1 > > > How to reproduce: > - export without save author&versions > - import > - make many versions of some document (for create >1 full rcs revisions) > - full export > - import > (not tested) > There is a bug in identifying of old format of archive. (= if author contains > ".") > How to solve: > - Check what archive has old format by state(full/diff) for example, but not > by author > - override patch() for full-state nodes for resolve future inconsistencies. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Created: (XWIKI-1871) Override patch() for full-state jrcs nodes for resolve future inconsistencies.
Override patch() for full-state jrcs nodes for resolve future inconsistencies. -- Key: XWIKI-1871 URL: http://jira.xwiki.org/jira/browse/XWIKI-1871 Project: XWiki Platform Issue Type: Task Components: Packaging Affects Versions: 1.2 M2 Environment: JRCS Reporter: Artem Melentev Priority: Minor Currently patch() on full-state jrcs nodes is never called. But overriding may prevent some bugs in the future. Implementation is complicates by bad-extendible design of JRCS. See XWikiRCSArchive# XWikiJRCSNode#patch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Closed: (XWIKI-1870) Import failed if there are rcs revisions with author is empty
[ http://jira.xwiki.org/jira/browse/XWIKI-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Melentev closed XWIKI-1870. - Resolution: Fixed Fixed in r6030. > Import failed if there are rcs revisions with author is empty > - > > Key: XWIKI-1870 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1870 > Project: XWiki Platform > Issue Type: Bug > Components: Packaging, Storage >Affects Versions: 1.2 M2 >Reporter: Artem Melentev > Assigned To: Artem Melentev > Fix For: 1.2 RC1 > > > How to reproduce: > - export without save author&versions > - import > - make many versions of some document (for create >1 full rcs revisions) > - full export > - import > (not tested) > There is a bug in identifying of old format of archive. (= if author contains > ".") > How to solve: > - Check what archive has old format by state(full/diff) for example, but not > by author > - override patch() for full-state nodes for resolve future inconsistencies. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] r6030 - in xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc: . rcs
Author: amelentev Date: 2007-11-20 14:54:43 +0100 (Tue, 20 Nov 2007) New Revision: 6030 Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiDocumentArchive.java xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/rcs/XWikiRCSArchive.java Log: XWIKI-1870: Import failed if there are rcs revisions with author is empty Move archive update actions to XWikiRCSArchive Check what archive has old format by state(full|diff vs old "exp" state) Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiDocumentArchive.java === --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiDocumentArchive.java 2007-11-20 12:08:30 UTC (rev 6029) +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiDocumentArchive.java 2007-11-20 13:54:43 UTC (rev 6030) @@ -195,30 +195,6 @@ XWikiRCSNodeInfonodeInfo= (XWikiRCSNodeInfo) it.next(); XWikiRCSNodeContent nodeContent = (XWikiRCSNodeContent) it.next(); -// If the archive node is old there is no author, comment and date fields so we set them using the -// ones from a XWikiDocment object that we construct using the archive content. -if (nodeInfo.getAuthor() == null || nodeInfo.getAuthor().indexOf('.') < 0) { -Version ver = nodeInfo.getVersion(); -String xml = archive.getRevisionAsString(ver); - -try { -XWikiDocument doc = new XWikiDocument(); -doc.fromXML(xml); -// set this fields from old document -nodeInfo.setAuthor(doc.getAuthor()); -nodeInfo.setComment(doc.getComment()); -nodeInfo.setDate(doc.getDate()); -} catch (Exception e) { -// Two potential known errors: -// 1) Revision 1.1 doesn't exist. Some time in the past there was a bug in XWiki where version -//were starting at 1.2. When this happens the returned xml has a value of "\n". -// 2) A Class property with an invalid XML name was created. -//See http://jira.xwiki.org/jira/browse/XWIKI-1855 -LOG.warn("Error in revision [" + ver.toString() + "]: [" + e.getMessage() -+ "]. Ignoring non-fatal error."); -} -} - updateNode(nodeInfo); updatedNodeInfos.add(nodeInfo); updatedNodeContents.add(nodeContent); Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/rcs/XWikiRCSArchive.java === --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/rcs/XWikiRCSArchive.java 2007-11-20 12:08:30 UTC (rev 6029) +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/rcs/XWikiRCSArchive.java 2007-11-20 13:54:43 UTC (rev 6030) @@ -23,7 +23,10 @@ import java.util.Collection; import java.util.Date; import java.util.Iterator; +import java.util.List; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import org.apache.tools.ant.filters.StringInputStream; import org.suigeneris.jrcs.diff.PatchFailedException; import org.suigeneris.jrcs.rcs.Archive; @@ -38,6 +41,7 @@ import com.xpn.xwiki.XWikiContext; import com.xpn.xwiki.XWikiException; +import com.xpn.xwiki.doc.XWikiDocument; import com.xpn.xwiki.doc.XWikiDocumentArchive; /** @@ -47,6 +51,9 @@ */ public class XWikiRCSArchive extends Archive { + /** logger. */ +private static final Log LOG = LogFactory.getLog(XWikiRCSArchive.class); + /** * Used to serialize [EMAIL PROTECTED] XWikiDocumentArchive}. * @param nodeInfos - collection of [EMAIL PROTECTED] XWikiRCSNodeInfo} in any order @@ -98,10 +105,12 @@ */ private static class XWikiJRCSNode extends TrunkNode { -/** bug if author=="". */ +/** bug if author=="". see http://www.suigeneris.org/issues/browse/JRCS-24 */ public static String sauthorIfEmpty = "_"; -/** mark that node contains not patch. */ +/** mark that node contains full text, not diff. */ public static String sfullVersion = "full"; +/** mark that node contains diff. */ +public static String sdiffVersion = "diff"; /** * @param vernum - version of node * @param next - next node (with smaller version) in history @@ -155,29 +164,78 @@ } /** @param isdiff - true if node stores a diff, false - if full version */ public void setDiff(boolean isdiff) {
[xwiki-notifications] Build XWiki Enterprise::Trunk #788 failed (tests failed: 6 (1 new), passed: 220)
Build XWiki Enterprise::Trunk #788 failed (tests failed: 6 (1 new), passed: 220) Agent: Default agent Build results: http://teamcity.xwiki.org/viewLog.html?buildId=5720&buildTypeId=bt7 Newly failed tests (1 test) == com.xpn.xwiki.it.xmlrpc.AllTests.testGetPageHistory = junit.framework.AssertionFailedError: expected:&Tue Nov 20 13:45:56 CET 2007& but was:&Tue Nov 20 13:45:57 CET 2007& at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.failNotEquals(Assert.java:280) at junit.framework.Assert.assertEquals(Assert.java:64) at junit.framework.Assert.assertEquals(Assert.java:71) at com.xpn.xwiki.it.xmlrpc.PagesTest.testGetPageHistory(PagesTest.java:177) at com.xpn.xwiki.it.xmlrpc.PagesTest.testGetPageHistory(PagesTest.java:177) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at junit.framework.TestCase.runTest(TestCase.java:164) at junit.framework.TestCase.runBare(TestCase.java:130) at junit.framework.TestResult$1.protect(TestResult.java:106) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.framework.TestResult.run(TestResult.java:109) at junit.framework.TestCase.run(TestCase.java:120) at junit.framework.TestSuite.runTest(TestSuite.java:230) at junit.framework.TestSuite.run(TestSuite.java:225) at junit.framework.TestSuite.runTest(TestSuite.java:230) at junit.framework.TestSuite.run(TestSuite.java:225) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:21) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.extensions.TestSetup.run(TestSetup.java:25) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:138) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:125) at org.apache.maven.surefire.Surefire.run(Surefire.java:132) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:290) at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:818) Other failed tests (5 tests, only first 3 failures shown here) == com.xpn.xwiki.it.xmlrpc.AllTests.Validating XWiki.XWikiAdminGroup = com.xpn.xwiki.it.xmlrpc.AllTests.Validating XWiki.Admin = com.xpn.xwiki.it.xmlrpc.AllTests.Validating XWiki.XWikiGroupTemplate = see all newly failed tests: http://teamcity.xwiki.org/viewLog.html?buildId=5720&buildTypeId=bt7 Configure email notifications: http://teamcity.xwiki.org/profile.html?init=1#notifications ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Updated: (XWIKI-1870) Import failed if there are rcs revisions with author is empty
[ http://jira.xwiki.org/jira/browse/XWIKI-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Melentev updated XWIKI-1870: -- Description: How to reproduce: - export without save author&versions - import - make many versions of some document (for create >1 full rcs revisions) - full export - import (not tested) There is a bug in identifying of old format of archive. (= if author contains ".") How to solve: - Check what archive has old format by state(full/diff) for example, but not by author - override patch() for full-state nodes for resolve future inconsistencies. was: How to reproduce: - export without save author&versions - import - make many versions of some document (for create >1 full rcs revisions) - full export - import (not tested) Where is bug in identifying of old format of archive. (= if author contains ".") How to solve: - Check what archive has old format by state(full/diff) for example, but not by author - override patch() for full-state nodes for resolve future inconsistencies. > Import failed if there are rcs revisions with author is empty > - > > Key: XWIKI-1870 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1870 > Project: XWiki Platform > Issue Type: Bug > Components: Packaging, Storage >Affects Versions: 1.2 M2 >Reporter: Artem Melentev > Assigned To: Artem Melentev > Fix For: 1.2 RC1 > > > How to reproduce: > - export without save author&versions > - import > - make many versions of some document (for create >1 full rcs revisions) > - full export > - import > (not tested) > There is a bug in identifying of old format of archive. (= if author contains > ".") > How to solve: > - Check what archive has old format by state(full/diff) for example, but not > by author > - override patch() for full-state nodes for resolve future inconsistencies. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Updated: (XWIKI-1870) Import failed if there are rcs revisions with author is empty
[ http://jira.xwiki.org/jira/browse/XWIKI-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Melentev updated XWIKI-1870: -- Fix Version/s: 1.2 RC1 Assignee: Artem Melentev > Import failed if there are rcs revisions with author is empty > - > > Key: XWIKI-1870 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1870 > Project: XWiki Platform > Issue Type: Bug > Components: Packaging, Storage >Affects Versions: 1.2 M2 >Reporter: Artem Melentev > Assigned To: Artem Melentev > Fix For: 1.2 RC1 > > > How to reproduce: > - export without save author&versions > - import > - make many versions of some document (for create >1 full rcs revisions) > - full export > - import > (not tested) > Where is bug in identifying of old format of archive. (= if author contains > ".") > How to solve: > - Check what archive has old format by state(full/diff) for example, but not > by author > - override patch() for full-state nodes for resolve future inconsistencies. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Created: (XWIKI-1870) Import failed if there are rcs revisions with author is empty
Import failed if there are rcs revisions with author is empty - Key: XWIKI-1870 URL: http://jira.xwiki.org/jira/browse/XWIKI-1870 Project: XWiki Platform Issue Type: Bug Components: Packaging, Storage Affects Versions: 1.2 M2 Reporter: Artem Melentev How to reproduce: - export without save author&versions - import - make many versions of some document (for create >1 full rcs revisions) - full export - import (not tested) Where is bug in identifying of old format of archive. (= if author contains ".") How to solve: - Check what archive has old format by state(full/diff) for example, but not by author - override patch() for full-state nodes for resolve future inconsistencies. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] Build XWiki Enterprise::Trunk #787 failed (tests failed: 5, passed: 221)
Build XWiki Enterprise::Trunk #787 failed (tests failed: 5, passed: 221) Agent: Default agent Build results: http://teamcity.xwiki.org/viewLog.html?buildId=5715&buildTypeId=bt7 Failed tests (5 tests, only first 3 failures shown here) == com.xpn.xwiki.it.xmlrpc.AllTests.Validating XWiki.XWikiAdminGroup = com.xpn.xwiki.it.xmlrpc.AllTests.Validating XWiki.Admin = com.xpn.xwiki.it.xmlrpc.AllTests.Validating XWiki.XWikiGroupTemplate = see all newly failed tests: http://teamcity.xwiki.org/viewLog.html?buildId=5715&buildTypeId=bt7 Configure email notifications: http://teamcity.xwiki.org/profile.html?init=1#notifications ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Commented: (XWIKI-1044) Refreshing cached documents affects only the current request
[ http://jira.xwiki.org/jira/browse/XWIKI-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19753 ] Sergiu Dumitriu commented on XWIKI-1044: Fixed in rev. 6029 When using ?refresh=1, only the document in the current language and with the current query string, except the refresh part, is refreshed. The content in other languages or other query strings remain cached. > Refreshing cached documents affects only the current request > > > Key: XWIKI-1044 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1044 > Project: XWiki Platform > Issue Type: Bug > Components: Core >Affects Versions: 1.0 B5 >Reporter: Sergiu Dumitriu >Priority: Minor > Fix For: Future > > > If I setup a cache for a document, for subsequent requests I get the version > stored in the cache. I can override this by ading the "refresh=1" query > parameter, but this does not refresh the cache, only returns the refreshed > document. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Closed: (XWIKI-1869) Caching documents does not consider the current user language, returning the document in the cached language
[ http://jira.xwiki.org/jira/browse/XWIKI-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergiu Dumitriu closed XWIKI-1869. -- Fix Version/s: 1.2 RC1 Resolution: Fixed Assignee: Sergiu Dumitriu Fixed in rev. 6029 > Caching documents does not consider the current user language, returning the > document in the cached language > > > Key: XWIKI-1869 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1869 > Project: XWiki Platform > Issue Type: Bug > Components: Core >Affects Versions: 1.2 M2 >Reporter: Sergiu Dumitriu > Assigned To: Sergiu Dumitriu > Fix For: 1.2 RC1 > > > This is a major problem in international wikis with active caching. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Updated: (XWATCH-5) Wiki Integration
[ http://jira.xwiki.org/jira/browse/XWATCH-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anca Paula Luca updated XWATCH-5: - Attachment: XWATCH-5.patch The following sheets have been created for the wiki integration: - a FeedSheet that displays a document containing a XWikiAggregator class - a FeedArticleSheet that displays an article fetched from a feed. The content of the default XWiki.FeedEntryClassSheet was replaced with an include of this sheet, so that any fetched article is displayed using this sheet. - a GroupSheet that displays all the feeds that belong to a group. An include of sheet is set as the default content for each group document - a KeywordSheet that displays all the documents matching a keyword - a TagsSheet that displays all the documents matching the tag passed as parameter - a WikiWebHomeSheet that displays a welcome 'dashboard' The watch reader interface is now at Watch,Reader and the Watch.WebHome displays the welcome wiki page. Minor changes have been made to some other sheets in order to fix some bugs or improve their functionality as requested by the new sheets. > Wiki Integration > > > Key: XWATCH-5 > URL: http://jira.xwiki.org/jira/browse/XWATCH-5 > Project: XWiki Watch > Issue Type: Task > Components: Wiki Integration >Affects Versions: 1.0M1 >Reporter: Guillaume > Assigned To: Anca Paula Luca > Fix For: 1.0M3 > > Attachments: XWATCH-5.patch > > > We need wiki integration features. For this we first need specifications -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] r6029 - xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render
Author: sdumitriu Date: 2007-11-20 13:08:30 +0100 (Tue, 20 Nov 2007) New Revision: 6029 Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/DefaultXWikiRenderingEngine.java Log: XWIKI-1869: Caching documents does not consider the current user language, returning the document in the cached language Consider both the context language and the document language. Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/DefaultXWikiRenderingEngine.java === --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/DefaultXWikiRenderingEngine.java 2007-11-20 12:05:29 UTC (rev 6028) +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/DefaultXWikiRenderingEngine.java 2007-11-20 12:08:30 UTC (rev 6029) @@ -340,6 +340,7 @@ + includingdoc.getFullName() + ":" + includingdoc.getRealLanguage()); String action = ((context == null) ? "view" : context.getAction()); String lang = ((context == null) ? "" : context.getLanguage()); +lang += ((contentdoc == null) ? "" : ":" + contentdoc.getRealLanguage()); return db + "-" + cdoc + "-" + idoc + "-" + qs + "-" + action + "-" + lang + "-" + text.hashCode(); } ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Created: (XWIKI-1869) Caching documents does not consider the current user language, returning the document in the cached language
Caching documents does not consider the current user language, returning the document in the cached language Key: XWIKI-1869 URL: http://jira.xwiki.org/jira/browse/XWIKI-1869 Project: XWiki Platform Issue Type: Bug Components: Core Affects Versions: 1.2 M2 Reporter: Sergiu Dumitriu This is a major problem in international wikis with active caching. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] r6028 - xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render
Author: sdumitriu Date: 2007-11-20 13:05:29 +0100 (Tue, 20 Nov 2007) New Revision: 6028 Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/DefaultXWikiRenderingEngine.java Log: XWIKI-1044: Refreshing cached documents affects only the current request XWIKI-937: Caching documents breaks the inline edit mode XWIKI-1869: Caching documents does not consider the current user language, returning the document in the cached language Fixed. Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/DefaultXWikiRenderingEngine.java === --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/DefaultXWikiRenderingEngine.java 2007-11-20 11:44:00 UTC (rev 6027) +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/DefaultXWikiRenderingEngine.java 2007-11-20 12:05:29 UTC (rev 6028) @@ -324,13 +324,24 @@ private String getKey(String text, XWikiDocument contentdoc, XWikiDocument includingdoc, XWikiContext context) { -return ((context == null) ? "xwiki" : context.getDatabase()) + "-" -+ ((contentdoc == null) ? "" : contentdoc.getDatabase() + ":" -+ contentdoc.getFullName()) + "-" -+ ((includingdoc == null) ? "" : includingdoc.getDatabase() + ":" -+ includingdoc.getFullName()) + "-" -+ ((context == null || context.getRequest() == null) ? "" : context.getRequest() -.getQueryString()) + "-" + text.hashCode(); +String qs = +((context == null || context.getRequest() == null) ? "" : context.getRequest() +.getQueryString()); +if (qs != null) { +qs = qs.replaceAll("refresh=1&?", ""); +qs = qs.replaceAll("&?refresh=1", ""); +} +String db = ((context == null) ? "xwiki" : context.getDatabase()); +String cdoc = +((contentdoc == null) ? "" : contentdoc.getDatabase() + ":" ++ contentdoc.getFullName() + ":" + contentdoc.getRealLanguage()); +String idoc = +((includingdoc == null) ? "" : includingdoc.getDatabase() + ":" ++ includingdoc.getFullName() + ":" + includingdoc.getRealLanguage()); +String action = ((context == null) ? "view" : context.getAction()); +String lang = ((context == null) ? "" : context.getLanguage()); +return db + "-" + cdoc + "-" + idoc + "-" + qs + "-" + action + "-" + lang + "-" ++ text.hashCode(); } public void flushCache() ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Created: (XWIKI-1868) Caching documents breaks the WYSIWYG editors for the inline edit mode
Caching documents breaks the WYSIWYG editors for the inline edit mode - Key: XWIKI-1868 URL: http://jira.xwiki.org/jira/browse/XWIKI-1868 Project: XWiki Platform Issue Type: Bug Components: Core Affects Versions: 1.2 M2 Reporter: Sergiu Dumitriu This is caused by the fact that the editors are collected in a request-context variable when interpreting the content, and then the editor is activated for those fields listed in the context. But when caching the rendered content, the list of fields is not computed anymore, so the editor will not be enabled. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] r6027 - xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render
Author: sdumitriu Date: 2007-11-20 12:44:00 +0100 (Tue, 20 Nov 2007) New Revision: 6027 Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/DefaultXWikiRenderingEngine.java Log: Cleanup codestyle Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/DefaultXWikiRenderingEngine.java === --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/DefaultXWikiRenderingEngine.java 2007-11-20 09:02:35 UTC (rev 6026) +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/DefaultXWikiRenderingEngine.java 2007-11-20 11:44:00 UTC (rev 6027) @@ -40,26 +40,32 @@ public class DefaultXWikiRenderingEngine implements XWikiRenderingEngine { private static final Log log = LogFactory.getLog(XWikiRenderingEngine.class); + private List renderers = new ArrayList(); + private HashMap renderermap = new LinkedHashMap(); + private XWikiCache cache; -public DefaultXWikiRenderingEngine(XWiki xwiki, XWikiContext context) throws XWikiException { +public DefaultXWikiRenderingEngine(XWiki xwiki, XWikiContext context) throws XWikiException +{ -if (xwiki.Param("xwiki.render.macromapping", "1").equals("1")) +if (xwiki.Param("xwiki.render.macromapping", "1").equals("1")) { addRenderer("mapping", new XWikiMacrosMappingRenderer(xwiki, context)); +} // addRenderer(new XWikiJSPRenderer()); -if (xwiki.Param("xwiki.render.velocity", "1").equals("1")) +if (xwiki.Param("xwiki.render.velocity", "1").equals("1")) { addRenderer("velocity", new XWikiVelocityRenderer()); +} if (xwiki.Param("xwiki.render.groovy", "1").equals("1")) { addRenderer("groovy", new XWikiGroovyRenderer()); } -if (xwiki.Param("xwiki.render.plugin", "1").equals("1")) +if (xwiki.Param("xwiki.render.plugin", "1").equals("1")) { addRenderer("plugin", new XWikiPluginRenderer()); - -if (xwiki.Param("xwiki.render.wiki", "1").equals("1")) +} +if (xwiki.Param("xwiki.render.wiki", "1").equals("1")) { addRenderer("wiki", new XWikiRadeoxRenderer(false)); - +} if (xwiki.Param("xwiki.render.wikiwiki", "0").equals("1")) { addRenderer("xwiki", new XWikiWikiBaseRenderer(true, true)); } else { @@ -69,43 +75,53 @@ initCache(context); } -public void initCache(XWikiContext context) throws XWikiException { +public void initCache(XWikiContext context) throws XWikiException +{ int iCapacity = 100; try { -String capacity = context.getWiki().Param("xwiki.render.cache.capacity"); -if (capacity != null) -iCapacity = Integer.parseInt(capacity); -} catch (Exception e) {} +String capacity = context.getWiki().Param("xwiki.render.cache.capacity"); +if (capacity != null) { +iCapacity = Integer.parseInt(capacity); +} +} catch (Exception e) { +} initCache(iCapacity, context); } -public void initCache(int iCapacity, XWikiContext context) throws XWikiException { +public void initCache(int iCapacity, XWikiContext context) throws XWikiException +{ XWikiCacheService cacheService = context.getWiki().getCacheService(); cache = cacheService.newCache("xwiki.rendering.cache", iCapacity); } -public XWikiCache getCache() { +public XWikiCache getCache() +{ return cache; } -public void addRenderer(String name, XWikiRenderer renderer) { +public void addRenderer(String name, XWikiRenderer renderer) +{ renderers.add(renderer); renderermap.put(name, renderer); } -public XWikiRenderer getRenderer(String name) { +public XWikiRenderer getRenderer(String name) +{ return (XWikiRenderer) renderermap.get(name); } -public List getRendererList() { +public List getRendererList() +{ return (List) ((ArrayList) renderers).clone(); } -public List getRendererNames() { +public List getRendererNames() +{ return new LinkedList(renderermap.keySet()); } -protected XWikiRenderer removeRenderer(String name) { +protected XWikiRenderer removeRenderer(String name) +{ XWikiRenderer result = (XWikiRenderer) renderermap.remove(name); if (result != null) { renderers.remove(result); @@ -113,15 +129,19 @@ return result; } -public String renderDocument(XWikiDocument doc, XWikiContext context) throws XWikiException { - return renderText(doc.getTranslatedContent(context), doc, context); +public String renderDocument(XWikiDocument doc, XWikiContext context) throws XWikiException +{ +return renderTex
[xwiki-notifications] [Issue] Commented: (XWIKI-1044) Refreshing cached documents affects only the current request
[ http://jira.xwiki.org/jira/browse/XWIKI-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19750 ] Sergiu Dumitriu commented on XWIKI-1044: The problem is that each document is cached using a key that contains the query string, so a query containing refresh=1 will not affect a document without that parameter. The solution is to ignore this param when computing the cache key. > Refreshing cached documents affects only the current request > > > Key: XWIKI-1044 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1044 > Project: XWiki Platform > Issue Type: Bug > Components: Core >Affects Versions: 1.0 B5 >Reporter: Sergiu Dumitriu >Priority: Minor > Fix For: Future > > > If I setup a cache for a document, for subsequent requests I get the version > stored in the cache. I can override this by ading the "refresh=1" query > parameter, but this does not refresh the cache, only returns the refreshed > document. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Commented: (XWIKI-1774) Authentication lost when using more than one reverse proxies
[ http://jira.xwiki.org/jira/browse/XWIKI-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19749 ] Sergiu Dumitriu commented on XWIKI-1774: Actually there's another solution suggested by Vincent, and that is not to patch SF, but to overwrite the methods, since we're already extending the buggy class. I'll do that today and I'll need some of you guys to test it, as I don't have a cluster of proxies. > Authentication lost when using more than one reverse proxies > > > Key: XWIKI-1774 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1774 > Project: XWiki Platform > Issue Type: Bug > Components: Rights Management >Affects Versions: 1.0, 1.1.1 > Environment: linux RHEL 4.4 / HP DL385 / tomcat 5.5.23 apache 2.0.59 > /mysql 5.0 >Reporter: Eric Grandjean >Priority: Critical > > using 2 redline server in front of 2 apache server in front of 1 tomcat server > user lost authentication > we have the following message in catalina.out > when we authentifie > !remember-me cookie validation hash mismatch! > !remember-me cookie has been tampered with! > !remember-me cookie is being deleted! > we of course remove cookies ( client side ) > using 1 redline server in front of 1 apache server in front fo 1 tomcat server > every thing works fine -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Closed: (XWIKI-1862) Rights Manager Interface fixed css and xhtml validation
[ http://jira.xwiki.org/jira/browse/XWIKI-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mortagne closed XWIKI-1862. -- Fix Version/s: 1.2 RC1 Resolution: Fixed Apply Evelina's patch without modifications > Rights Manager Interface fixed css and xhtml validation > --- > > Key: XWIKI-1862 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1862 > Project: XWiki Platform > Issue Type: Improvement > Components: Templates, Skins & User Interface >Affects Versions: 1.1.2, 1.2 M2 >Reporter: Evelina Petronela Slatineanu > Assigned To: Evelina Petronela Slatineanu >Priority: Minor > Fix For: 1.2 RC1 > > Attachments: rights-manager-patch-16-11-2007.tar.gz, > xwiki-web-1.1-20-11-2007.patch, xwiki-web-19-11-2007.patch > > > The css and xhtml had some problems that prevented the validation: > - unescaped "&" entities > - the css used for the lightbox contained invalid css hacks > Fixes: > - escaped "&" > - wrote 2 separate css sheets for ie and other browsers, deleted the hacks > for transparent background in lightbox by using a png back image (for > browsers supporting png alpha transparency); for ie there is no other way > that to use "filter" and "opacity" hacks. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Closed: (XWIKI-1863) Rights Manager Interface fixed a javascript bug for scrolling in the ajax table when adding member in group
[ http://jira.xwiki.org/jira/browse/XWIKI-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mortagne closed XWIKI-1863. -- Fix Version/s: 1.2 RC1 Resolution: Fixed Apply Evelina's patch without modifications > Rights Manager Interface fixed a javascript bug for scrolling in the ajax > table when adding member in group > --- > > Key: XWIKI-1863 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1863 > Project: XWiki Platform > Issue Type: Improvement > Components: Templates, Skins & User Interface >Affects Versions: 1.1.2, 1.2 M2 >Reporter: Evelina Petronela Slatineanu > Assigned To: Evelina Petronela Slatineanu >Priority: Minor > Fix For: 1.2 RC1 > > Attachments: rights-manager-patch-16-11-2007.tar.gz > > > There was a javascript problem when dynamically adding a new member in a > group: the scroll was display even if the limit number of rows displayed was > bigger the the total rows added in the table. Fixed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Closed: (XWIKI-1864) Rights Manager Interface changed select box to radio buttons when chosing to display groups or users
[ http://jira.xwiki.org/jira/browse/XWIKI-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mortagne closed XWIKI-1864. -- Fix Version/s: 1.2 RC1 Resolution: Fixed Apply Evelina's patch without modifications > Rights Manager Interface changed select box to radio buttons when chosing to > display groups or users > > > Key: XWIKI-1864 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1864 > Project: XWiki Platform > Issue Type: Improvement > Components: Templates, Skins & User Interface >Affects Versions: 1.1.2, 1.2 M2 >Reporter: Evelina Petronela Slatineanu > Assigned To: Evelina Petronela Slatineanu >Priority: Trivial > Fix For: 1.2 RC1 > > Attachments: rights-manager-patch-16-11-2007.tar.gz > > > This is a matter of taste, as it occupies less space to use radio buttons > than a select box -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] r6026 - in xwiki-platform/web/branches/xwiki-web-1.1/standard/src/main/webapp/skins/albatross: . css/lightbox scripts/lightbox
Author: tmortagne Date: 2007-11-20 10:02:35 +0100 (Tue, 20 Nov 2007) New Revision: 6026 Modified: xwiki-platform/web/branches/xwiki-web-1.1/standard/src/main/webapp/skins/albatross/adminglobalrights.vm xwiki-platform/web/branches/xwiki-web-1.1/standard/src/main/webapp/skins/albatross/adminspacerights.vm xwiki-platform/web/branches/xwiki-web-1.1/standard/src/main/webapp/skins/albatross/css/lightbox/lightbox.css xwiki-platform/web/branches/xwiki-web-1.1/standard/src/main/webapp/skins/albatross/editgroup.vm xwiki-platform/web/branches/xwiki-web-1.1/standard/src/main/webapp/skins/albatross/editrights.vm xwiki-platform/web/branches/xwiki-web-1.1/standard/src/main/webapp/skins/albatross/edituser.vm xwiki-platform/web/branches/xwiki-web-1.1/standard/src/main/webapp/skins/albatross/getusers.vm xwiki-platform/web/branches/xwiki-web-1.1/standard/src/main/webapp/skins/albatross/scripts/lightbox/lightbox.js xwiki-platform/web/branches/xwiki-web-1.1/standard/src/main/webapp/skins/albatross/usersandgroups.css xwiki-platform/web/branches/xwiki-web-1.1/standard/src/main/webapp/skins/albatross/usersandgroups.js Log: XWIKI-1862: Rights Manager Interface fixed css and xhtml validation XWIKI-1863: Rights Manager Interface fixed a javascript bug for scrolling in the ajax table when adding member in group XWIKI-1864: Rights Manager Interface changed select box to radio buttons when chosing to display groups or users (Apply Evelina's patches without modifications) Modified: xwiki-platform/web/branches/xwiki-web-1.1/standard/src/main/webapp/skins/albatross/adminglobalrights.vm === --- xwiki-platform/web/branches/xwiki-web-1.1/standard/src/main/webapp/skins/albatross/adminglobalrights.vm 2007-11-20 09:02:29 UTC (rev 6025) +++ xwiki-platform/web/branches/xwiki-web-1.1/standard/src/main/webapp/skins/albatross/adminglobalrights.vm 2007-11-20 09:02:35 UTC (rev 6026) @@ -8,24 +8,24 @@ ## display the new interface #if($interface == "new") #if($doc.fullName == "XWiki.XWikiPreferences") -#if($request.editor == "globalrights") +#if($request.editor == "globalrights") #set($clsname = "XWiki.XWikiGlobalRights") -#else +#else #set($clsname = "XWiki.XWikiRights") #end -#elseif($doc.name == "WebPreferences") +#elseif($doc.name == "WebPreferences") #if($request.editor == "spacerights") #set($clsname = "XWiki.XWikiGlobalRights") #else -#set($clsname = "XWiki.XWikiRights") +#set($clsname = "XWiki.XWikiRights") #end #end ## url to take the users and groups to display in the ajax-based table #set($url = "?xpage=getusersandgroups") -#set($saveUrl = $doc.getURL("view", "xpage=saverights&clsname=${clsname}&fullname=XWiki.XWikiGuest&uorg=users")) +#set($saveUrl = $doc.getURL("view", "xpage=saverights&clsname=${clsname}&fullname=XWiki.XWikiGuest&uorg=users")) ## get the rights for XWikiGuest #set($r1 = 0) #set($r2 = 0) #set($r3 = 0) #set($r4 = 0) #set($r5 = 0) #set($r6 = 0) #set($r7 = 0) - + #set($guest = "XWiki.XWikiGuest") #foreach($obj in $doc.getObjects($clsname)) ## XWiki.XWikiGlobalRights or XWiki.XWikiRights #set($pers = "$!obj.getProperty('users').getValue()") @@ -35,7 +35,7 @@ #else #set($denys = "$!obj.getProperty('levels').getValue()") #end - + #if($allows && $allows.indexOf("view") > -1) #set($r1 = 1) #end #if($allows && $allows.indexOf("comment") > -1) #set($r2 = 1) #end #if($allows && $allows.indexOf("edit") > -1) #set($r3 = 1) #end @@ -51,7 +51,7 @@ #if($denys && $denys.indexOf("register") > -1) #set($r5 = 2) #end #if($denys && $denys.indexOf("admin") > -1) #set($r6 = 2) #end #if($denys && $denys.indexOf("programming") > -1) #set($r7 = 2) #end - + #if($denys && $denys == "") #set($r1 = 0) #set($r2 = 0) #set($r3 = 0) #set($r4 = 0) #set($r5 = 0) #set($r6 = 0) #set($r7 = 0) #end #if($allows && $allows == "") #set($r1 = 0) #set($r2 = 0) #set($r3 = 0) #set($r4 = 0) #set($r5 = 0) #set($r6 = 0) #set($r7 = 0) #end #end @@ -61,12 +61,12 @@ - + -$msg.get("rightsmanager.specialusers") +$msg.get("rightsmanager.specialusers") $msg.get("rightsmanager.view") $msg.get("rightsmanager.comment") $msg.get("rightsmanager.edit") @@ -91,26 +91,26 @@ - - -$msg.get("Groups") -$msg.get("Users") - + + - $msg.get("rightsmanager.groupsorusers") - $msg.get("rightsmanager.view") - $msg.get("rightsmanager.comment") - $msg.get("rightsmanager.edit") - $msg.get("rightsmanager.delete") - $msg.get("rightsmanager.register") - $msg.get("rightsmanager.admin") - ## if global rights and main wiki show programming right column - #set($hasPrgr = ($doc.fullName=='XWiki.XWi
[xwiki-notifications] r6025 - xwiki-platform/core/branches/xwiki-core-1.1/src/main/resources
Author: tmortagne Date: 2007-11-20 10:02:29 +0100 (Tue, 20 Nov 2007) New Revision: 6025 Modified: xwiki-platform/core/branches/xwiki-core-1.1/src/main/resources/ApplicationResources.properties Log: XWIKI-1862: Rights Manager Interface fixed css and xhtml validation XWIKI-1863: Rights Manager Interface fixed a javascript bug for scrolling in the ajax table when adding member in group XWIKI-1864: Rights Manager Interface changed select box to radio buttons when chosing to display groups or users (Apply Evelina's patches without modifications) Modified: xwiki-platform/core/branches/xwiki-core-1.1/src/main/resources/ApplicationResources.properties === --- xwiki-platform/core/branches/xwiki-core-1.1/src/main/resources/ApplicationResources.properties 2007-11-19 18:05:28 UTC (rev 6024) +++ xwiki-platform/core/branches/xwiki-core-1.1/src/main/resources/ApplicationResources.properties 2007-11-20 09:02:29 UTC (rev 6025) @@ -838,4 +838,6 @@ rightsmanager.comment=Comment rightsmanager.global=Global rightsmanager.local=Local -rightsmanager.both=Both \ No newline at end of file +rightsmanager.both=Both +rightsmanager.edituserprofile=For more options to edit this user, please go to the user's profile +rightsmanager.userprofile=User Profile \ No newline at end of file ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Updated: (XWIKI-1774) Authentication lost when using more than one reverse proxies
[ http://jira.xwiki.org/jira/browse/XWIKI-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergiu Dumitriu updated XWIKI-1774: --- Summary: Authentication lost when using more than one reverse proxies (was: authentication failed using several web server an several redline in front of tomcat server) > Authentication lost when using more than one reverse proxies > > > Key: XWIKI-1774 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1774 > Project: XWiki Platform > Issue Type: Bug > Components: Rights Management >Affects Versions: 1.0, 1.1.1 > Environment: linux RHEL 4.4 / HP DL385 / tomcat 5.5.23 apache 2.0.59 > /mysql 5.0 >Reporter: Eric Grandjean >Priority: Critical > > using 2 redline server in front of 2 apache server in front of 1 tomcat server > user lost authentication > we have the following message in catalina.out > when we authentifie > !remember-me cookie validation hash mismatch! > !remember-me cookie has been tampered with! > !remember-me cookie is being deleted! > we of course remove cookies ( client side ) > using 1 redline server in front of 1 apache server in front fo 1 tomcat server > every thing works fine -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications
[xwiki-notifications] [Issue] Updated: (XWIKI-1862) Rights Manager Interface fixed css and xhtml validation
[ http://jira.xwiki.org/jira/browse/XWIKI-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evelina Petronela Slatineanu updated XWIKI-1862: Attachment: xwiki-web-1.1-20-11-2007.patch The patch for 1.1 is attached. > Rights Manager Interface fixed css and xhtml validation > --- > > Key: XWIKI-1862 > URL: http://jira.xwiki.org/jira/browse/XWIKI-1862 > Project: XWiki Platform > Issue Type: Improvement > Components: Templates, Skins & User Interface >Affects Versions: 1.1.2, 1.2 M2 >Reporter: Evelina Petronela Slatineanu > Assigned To: Evelina Petronela Slatineanu >Priority: Minor > Attachments: rights-manager-patch-16-11-2007.tar.gz, > xwiki-web-1.1-20-11-2007.patch, xwiki-web-19-11-2007.patch > > > The css and xhtml had some problems that prevented the validation: > - unescaped "&" entities > - the css used for the lightbox contained invalid css hacks > Fixes: > - escaped "&" > - wrote 2 separate css sheets for ie and other browsers, deleted the hacks > for transparent background in lightbox by using a png back image (for > browsers supporting png alpha transparency); for ie there is no other way > that to use "filter" and "opacity" hacks. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ___ notifications mailing list notifications@xwiki.org http://lists.xwiki.org/mailman/listinfo/notifications