[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-30 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806016#comment-16806016
 ] 

Yetus QA commented on YETUS-749:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
50s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
1s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  
6s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
44s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  2m 
18s{color} | {color:blue} Both FindBugs and SpotBugs are enabled, using 
SpotBugs. {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  0m 
17s{color} | {color:blue} audience-annotations-component/audience-annotations 
in master has 1 extant spotbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  0m  
8s{color} | {color:blue} branch/precommit no spotbugs output file 
(spotbugsXml.xml) {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  0m  
8s{color} | {color:blue} branch/asf-site-src no spotbugs output file 
(spotbugsXml.xml) {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  1m  
2s{color} | {color:blue} root in master has 1 extant spotbugs warnings. {color} 
|
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  
4s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 7s{color} | {color:green} audience-annotations-component/audience-annotations: 
The patch generated 0 new + 17 unchanged - 1 fixed = 17 total (was 18) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 5s{color} | {color:green} The patch passed checkstyle in precommit {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 6s{color} | {color:green} The patch passed checkstyle in asf-site-src {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 8s{color} | {color:green} root: The patch generated 0 new + 17 unchanged - 1 
fixed = 17 total (was 18) {color} |
| {color:green}+1{color} | {color:green} hadolint {color} | {color:green}  0m  
2s{color} | {color:green} There were no new hadolint issues. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 4s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} 

[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-30 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806011#comment-16806011
 ] 

Yetus QA commented on YETUS-749:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/989/console in case of 
problems.


> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Precommit
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch, YETUS-749.01.patch, 
> YETUS-749.02.patch, YETUS-749.03.patch
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-29 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804654#comment-16804654
 ] 

Yetus QA commented on YETUS-749:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red} 49m 
48s{color} | {color:red} Docker failed to build yetus/yetus:dd7ecd7. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | YETUS-749 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12964135/YETUS-749.03.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/986/console |
| Powered by | Apache Yetus 0.10.0-SNAPSHOT http://yetus.apache.org |


This message was automatically generated.



> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Precommit
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch, YETUS-749.01.patch, 
> YETUS-749.02.patch, YETUS-749.03.patch
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-29 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804631#comment-16804631
 ] 

Yetus QA commented on YETUS-749:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/986/console in case of 
problems.


> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Precommit
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch, YETUS-749.01.patch, 
> YETUS-749.02.patch, YETUS-749.03.patch
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-29 Thread Allen Wittenauer (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804607#comment-16804607
 ] 

Allen Wittenauer commented on YETUS-749:


-03:
* fix the +0 to be 0
* Note that --spotbugs-strict-precheck is not set, thus why the extant values 
are 0. I'll file a separate jira to fix those after committing this one.

> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Precommit
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch, YETUS-749.01.patch, 
> YETUS-749.02.patch
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-28 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804482#comment-16804482
 ] 

Yetus QA commented on YETUS-749:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 17m  
7s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  
5s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
39s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  1m 
53s{color} | {color:blue} Both FindBugs and SpotBugs are enabled, using 
SpotBugs. {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  0m 
19s{color} | {color:blue} audience-annotations-component/audience-annotations 
in master has 1 extant spotbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  0m  
8s{color} | {color:blue} branch/precommit no spotbugs output file 
(spotbugsXml.xml) {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  0m  
7s{color} | {color:blue} branch/asf-site-src no spotbugs output file 
(spotbugsXml.xml) {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  0m 
42s{color} | {color:blue} root in master has 1 extant spotbugs warnings. 
{color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  
4s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 6s{color} | {color:green} audience-annotations-component/audience-annotations: 
The patch generated 0 new + 17 unchanged - 1 fixed = 17 total (was 18) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 4s{color} | {color:green} The patch passed checkstyle in precommit {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 4s{color} | {color:green} The patch passed checkstyle in asf-site-src {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 7s{color} | {color:green} root: The patch generated 0 new + 17 unchanged - 1 
fixed = 17 total (was 18) {color} |
| {color:green}+1{color} | {color:green} hadolint {color} | {color:green}  0m  
2s{color} | {color:green} There were no new hadolint issues. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 4s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} 

[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-28 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804459#comment-16804459
 ] 

Yetus QA commented on YETUS-749:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/985/console in case of 
problems.


> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Precommit
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch, YETUS-749.01.patch, 
> YETUS-749.02.patch
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-28 Thread Allen Wittenauer (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804457#comment-16804457
 ] 

Allen Wittenauer commented on YETUS-749:


-02:
* rebase
* fix the syntax error

> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Precommit
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch, YETUS-749.01.patch, 
> YETUS-749.02.patch
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-28 Thread Allen Wittenauer (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804455#comment-16804455
 ] 

Allen Wittenauer commented on YETUS-749:


Everything looks good except for this error, likely related to the weirdness 
currently on the ASF build machines. 

{code}
Building spotbugs database(s) using /opt/spotbugs for executables.

patch: ]]: extra operand
patch: Try 'patch --help' for more information.

Starting with 
/home/jenkins/jenkins-slave/workspace/PreCommit-YETUS-Build/patchprocess/patch-spotbugs-audience-annotations-component_audience-annotations-warnings.xml
{code}

> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Precommit
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch, YETUS-749.01.patch
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-28 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804454#comment-16804454
 ] 

Yetus QA commented on YETUS-749:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 14m 
51s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  
6s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m  
9s{color} | {color:red} root in master failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
20s{color} | {color:green} master passed {color} |
| {color:orange}-0{color} | {color:orange} javadoc {color} | {color:orange}  0m 
18s{color} | {color:orange} asf-site-src in master failed. {color} |
| {color:orange}-0{color} | {color:orange} javadoc {color} | {color:orange}  0m 
17s{color} | {color:orange} root in master failed. {color} |
| {color:red}-1{color} | {color:red} spotbugs {color} | {color:red}  0m 
18s{color} | {color:red} audience-annotations in master failed. {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  0m 
26s{color} | {color:blue} branch/precommit no spotbugs output file 
(spotbugsXml.xml) {color} |
| {color:red}-1{color} | {color:red} spotbugs {color} | {color:red}  0m  
2s{color} | {color:red} asf-site-src in master failed. {color} |
| {color:red}-1{color} | {color:red} spotbugs {color} | {color:red}  0m  
3s{color} | {color:red} root in master failed. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  
0s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m  
8s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m  
3s{color} | {color:red} audience-annotations in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m  
2s{color} | {color:red} precommit in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 8s{color} | {color:green} root: The patch generated 0 new + 17 unchanged - 1 
fixed = 17 total (was 18) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 4s{color} | {color:green} The patch passed checkstyle in asf-site-src {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch fails to run checkstyle in 
audience-annotations {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m  8s{color} | {color:orange} The patch fails to run checkstyle in precommit 
{color} |
| {color:green}+1{color} | {color:green} hadolint {color} | {color:green}  0m  
2s{color} | {color:green} There were no new hadolint issues. {color} |
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red}  0m  
4s{color} | {color:red} The patch generated 1 new + 0 unchanged - 0 fixed = 1 
total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:orange}-0{color} | 

[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-28 Thread Allen Wittenauer (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1680#comment-1680
 ] 

Allen Wittenauer commented on YETUS-749:


Add --docker-cache-from=apache/yetus-base:master to the precommit script. maybe 
that will help.

> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Precommit
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch, YETUS-749.01.patch
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-28 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804443#comment-16804443
 ] 

Yetus QA commented on YETUS-749:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/984/console in case of 
problems.


> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Precommit
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch, YETUS-749.01.patch
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-28 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804441#comment-16804441
 ] 

Yetus QA commented on YETUS-749:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red}  5m 
33s{color} | {color:red} Docker failed to build yetus/yetus:82f3493. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | YETUS-749 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12964070/YETUS-749.01.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/983/console |
| Powered by | Apache Yetus 0.10.0-SNAPSHOT http://yetus.apache.org |


This message was automatically generated.



> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Precommit
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch, YETUS-749.01.patch
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-28 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804433#comment-16804433
 ] 

Yetus QA commented on YETUS-749:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/983/console in case of 
problems.


> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Precommit
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch, YETUS-749.01.patch
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-28 Thread Allen Wittenauer (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804432#comment-16804432
 ] 

Allen Wittenauer commented on YETUS-749:


Is it sad that I just expect the ASF infra to fail now?

> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Precommit
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch, YETUS-749.01.patch
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-28 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804291#comment-16804291
 ] 

Yetus QA commented on YETUS-749:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red}  1m 
19s{color} | {color:red} Docker failed to build yetus/yetus:82f3493. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | YETUS-749 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12964070/YETUS-749.01.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/982/console |
| Powered by | Apache Yetus 0.10.0-SNAPSHOT http://yetus.apache.org |


This message was automatically generated.



> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Precommit
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch, YETUS-749.01.patch
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-28 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804286#comment-16804286
 ] 

Yetus QA commented on YETUS-749:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/982/console in case of 
problems.


> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Precommit
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch, YETUS-749.01.patch
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-28 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804263#comment-16804263
 ] 

Yetus QA commented on YETUS-749:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red}  1m 
28s{color} | {color:red} Docker failed to build yetus/yetus:82f3493. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | YETUS-749 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12964070/YETUS-749.01.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/981/console |
| Powered by | Apache Yetus 0.10.0-SNAPSHOT http://yetus.apache.org |


This message was automatically generated.



> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Precommit
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch, YETUS-749.01.patch
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-28 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804262#comment-16804262
 ] 

Yetus QA commented on YETUS-749:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/981/console in case of 
problems.


> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Precommit
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch, YETUS-749.01.patch
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-28 Thread Allen Wittenauer (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804223#comment-16804223
 ] 

Allen Wittenauer commented on YETUS-749:


-01:
* this fixes the known spotbugs error in audience as a test bed
* way better fallback support
* better deprecation messages
* removed the -spotbugs settings from personalities since the code is smarter 
now
* spotbugs.sh now runs findbugs and spotbugs (one code path)
* fixed a few holdovers from YETUS-809

> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Precommit
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch, YETUS-749.01.patch
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-18 Thread Allen Wittenauer (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795683#comment-16795683
 ] 

Allen Wittenauer commented on YETUS-749:


I'm not happy with this patch. 

> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch
>
>  Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-15 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794141#comment-16794141
 ] 

Yetus QA commented on YETUS-749:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 14m 
40s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
11s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  
4s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} hadolint {color} | {color:green}  0m  
2s{color} | {color:green} There were no new hadolint issues. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 5s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green}  0m  
0s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m  
7s{color} | {color:green} precommit in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m  
6s{color} | {color:green} asf-site-src in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
14s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
18s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 20m 32s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-YETUS-Build/974/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | YETUS-749 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12962686/YETUS-749.00.patch |
| Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit 
xml compile hadolint |
| uname | Linux 3f018d075e52 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 
31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | precommit/src/main/shell/personality/yetus.sh |
| git revision | master / bdb0f18 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| shellcheck | v0.6.0 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YETUS-Build/974/testReport/ |
| Max. process+thread count | 88 (vs. ulimit of 1000) |
| modules | C: precommit asf-site-src . U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/974/console |
| Powered by 

[jira] [Commented] (YETUS-749) change findbugs to spotbugs

2019-03-15 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794137#comment-16794137
 ] 

Yetus QA commented on YETUS-749:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/974/console in case of 
problems.


> change findbugs to spotbugs
> ---
>
> Key: YETUS-749
> URL: https://issues.apache.org/jira/browse/YETUS-749
> Project: Yetus
>  Issue Type: New Feature
>  Components: build, Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-749.00.patch
>
>  Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> The latest versions of spotbugs are now shipping with executables, it seems.  
> The findbugs plugin should be moved over to spotbugs, check for those 
> executables, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)