[PATCH 1/6] lib: Clean up error handling in _notmuch_thread_create
David Bremner writes: > Austin Clements writes: > >> Previously, there were various opportunities for memory leaks in the >> error-handling paths of this function. Use a local talloc context and >> some reparenting to make eliminate these leaks, while keeping the >> control flow simple. > > pushed all but the python bindings patch. any comments on that patch, Justus? For reference, id:1353819427-13182-6-git-send-email-amdragon at mit.edu d
[PATCH v2] emacs: show: make buttons select window
Mark Walters writes: > Emacs has two button type objects: widgets (as used for saved searches > in notmuch-hello) and buttons as used by parts/citations and id links > in notmuch-show. These two behave subtly differently when clicked with > the mouse: widgets select the window clicked before running the > action, buttons do not. pushed, d
[PATCH 1/2] test/test-lib.sh: use $test_subtest_name in all tests
Tomi Ollila writes: > Set the variable '$test_subtest_name' in all functions which starts > a new test and use that variable in all functions that output > test results. pushed both d
[PATCH 1/1] devel/release-checks.sh: added check that 1st NEWS header is tidy
Tomi Ollila writes: > Check that the underlining '===...' for first (header) line in NEWS > file is of the same length as the header text and it is all '=':s. pushed, sans execs d
[PATCH v2 3/6] test: emacs: `notmuch-show-tag-all' with prefix arg should only tag open messages
Pieter Praet writes:
> * test/emacs:
>
> - New subtest "notmuch-show: change tags of open messages in current
> buffer":
> When called with a prefix arg, `notmuch-show-tag-all' ("*") should only
> change the tags of *open* messages. Currently broken, fix follows later.
I'm afraid this patch doesn't apply anymore, sorry about that. A rebased
version would be welcome (and doesn't need further review).
d
[PATCH 1/1] devel/release-checks.sh: added check that 1st NEWS header is tidy
On Sat, Feb 16 2013, David Bremner wrote: > Tomi Ollila writes: > >> +echo -n "Checking that NEWS header is tidy... " >> +if [ "`exec sed 's/./=/g; 1q' NEWS`" = "`exec sed '1d; 2q' NEWS`" ] > > This patch seems OK to me, although the execs might be a bit overkill > for a script that is run once ever few months. You're right. The 2 extra fork(2):s(*) here doesn't matter... In case you don't amend my patch in following weeks I'll send a new patch :) > d (*) FYI: It is only bash(1) which forks process to execute the external command in such a trivial cases. Most (if not all) other shells have (conservative) heuristics to avoid the "extra" fork there. If you're interested, my simple way to test this is 'strace -ff -o pidc cmd args...' Tomi
How to get thread id in emacs ui?
On Mon, Feb 18, 2013 at 04:05:26PM +0100, Rainer M Krug wrote: > On 18/02/13 15:42, David Bremner wrote: > > Rainer M Krug writes: > >> > >>> By the way, the library org-notmuch distributed with org-mode should make > >>> it easy to link > >>> into notmuch. > >> > >> Then I probably haven't loaded org-notmuch properly? What do I have to put > >> into my .emacs > >> file to load it properly? > >> > > > > I put what I know at > > > > http://notmuchmail.org/emacstips/#index24h2 > > Thanks - got it working under Ubuntu. One thing: in my org from git, > org-notmuch is in > .../org-mode/contrib/lisp and not .../lisp My following comment is probably OT, but still ... If you install org-mode from git following the instructions from the Makefile, then you should be putting something like the following in your local.mk. # Define if you want to include some (or all) files from contrib/lisp # just the filename please (no path prefix, no .el suffix), maybe with # globbing ORG_ADD_CONTRIB = org-notmuch If you do that, then David's instructions are accurate. Hope this helps, -- Suvayu Open source is the future. It sets us free.
How to get thread id in emacs ui?
Hello again Rainer, On Mon, Feb 18, 2013 at 03:05:49PM +0100, Rainer M Krug wrote: > On 18/02/13 14:36, Suvayu Ali wrote: > > On Mon, Feb 18, 2013 at 02:21:30PM +0100, Rainer M Krug wrote: > >> > >> I am using notmuch in emacs, and I linkt from my notes in org mode to > >> emails using the > >> thread: id or the message id. Is there a possibility to get these from > >> within emacs, or do I > >> have to go to the cli from notmuch? > >> > > > > As far as I'm aware, org-notmuch does all that for you. > > Actually, you might be right. But then it seems, I somehow haven't loaded > org-notmuch.el properly > - - I guess I am miaaing something at this step. > > But it also seems that org-notmuch-search-store-link stores the search string > and not the thread > or message id? > AFAIU, it does that when you call org-store-link in a search buffer. If you do that in the message buffer, it stores the message id. >From the search buffer: [[notmuch-search:from:myfriend%2520is:inbox][Notmuch search: from:myfriend is:inbox]] >From the message buffer: [[notmuch:id:C8BF5B7C-6F2E-4754-B27D-A828D894B7EA at gmail.com][Email from Myfriend]] Hope this helps, -- Suvayu Open source is the future. It sets us free.
How to get thread id in emacs ui?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 18/02/13 15:42, David Bremner wrote: > Rainer M Krug writes: >> >>> By the way, the library org-notmuch distributed with org-mode should make >>> it easy to link >>> into notmuch. >> >> Then I probably haven't loaded org-notmuch properly? What do I have to put >> into my .emacs >> file to load it properly? >> > > I put what I know at > > http://notmuchmail.org/emacstips/#index24h2 Thanks - got it working under Ubuntu. One thing: in my org from git, org-notmuch is in .../org-mode/contrib/lisp and not .../lisp Thanks a lot, Rainer > > It's a bit Debian specific at the moment, but hopefully others can fill in > the details for > other environments. > > d > - -- Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation Biology, UCT), Dipl. Phys. (Germany) Centre of Excellence for Invasion Biology Stellenbosch University South Africa Tel : +33 - (0)9 53 10 27 44 Cell: +33 - (0)6 85 62 59 98 Fax : +33 - (0)9 58 10 27 44 Fax (D):+49 - (0)3 21 21 25 22 44 email: Rainer at krugs.de Skype: RMkrug -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRIkM2AAoJENvXNx4PUvmC/MEIAK+27SwTFMGG7HRpj+1FOMCd DWVQpgXZQm8SIOCQuXVOwBog/RSzsAkkr0tSYIB5poaTuGV9kBr+95S6U8w29W03 KIHNxL9JU75a1M2k4Z9zNtKL12bKfyRMBjozV2ZEXeL36T9KzsqpfcIDkGDWw3vQ hZFSm7jD/r38EHKjnxsBuda40i3/hHl1b1Vtg5NuByaT47BjZ/IL6CbOwrxrTMJJ GgSK/5PbLCCpoPJh5KEbQpKw6OwMuxqjz/6spI8S95ZagDo6rqIxC4rS8Y/7qI2V DT223JdL23fcNBfp6cQY0fYPEdXZ2jS4UYWfZwxn97GMhx9+wv581wUCsg4Vsl8= =qJ8J -END PGP SIGNATURE-
How to get thread id in emacs ui?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 18/02/13 15:03, David Bremner wrote: > Rainer M Krug writes: > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> Hi >> >> I am using notmuch in emacs, and I linkt from my notes in org mode to emails >> using the >> thread: id or the message id. Is there a possibility to get these from >> within emacs, or do I >> have to go to the cli from notmuch? >> > > You want "c i" > > From NEWS for 0.15 > > Support for stashing the thread id in show view > > Invoking `notmuch-show-stash-message-id` with a prefix argument stashes the > (local and database > specific) thread id of the current thread instead of the message id. > Thanks - that is what I was looking for. > By the way, the library org-notmuch distributed with org-mode should make it > easy to link into > notmuch. Then I probably haven't loaded org-notmuch properly? What do I have to put into my .emacs file to load it properly? > > Be aware that thread id's are not preserved across dump-restore cycles, so it > is safer to link > to message-ids. Thanks - important info - I'll use the message id then instead. Cheers, Rainer > > d > - -- Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation Biology, UCT), Dipl. Phys. (Germany) Centre of Excellence for Invasion Biology Stellenbosch University South Africa Tel : +33 - (0)9 53 10 27 44 Cell: +33 - (0)6 85 62 59 98 Fax : +33 - (0)9 58 10 27 44 Fax (D):+49 - (0)3 21 21 25 22 44 email: Rainer at krugs.de Skype: RMkrug -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRIjYNAAoJENvXNx4PUvmCF7gH/R+yM55HxCao2pBk9jQ6E33I cuFvf8uFNXrtD+SMLnrIbbZfLCcuj5tN77kZTbuHCUqP6tPeG7P3EB42Nsru8XbZ JBVIVf2BdEXqAzxyq3hHEh6ikXZNmi7qHnjsZ7+Zco+nBfVLSVFx/GpzsaDTsQjs R5QO/R7u3rQAU9i48GaGJtCQ0E7KBUzjnBpGUlb6owdJWg4KTtxmRwerBxIFvScM 7H23oS8ZnWwN5Yqf+f8RA+9yBjrhXGUBcLYQZW62Wm6btJOE1T57LkO3mmQ7xl6/ 7+Iyv8DZkDX3F8b5wcIwOPmPAhoqx/jemkYwQHv+tC2cWQXbg1GzrlWxfrZGjz0= =/SRR -END PGP SIGNATURE-
How to get thread id in emacs ui?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 18/02/13 14:36, Suvayu Ali wrote: > On Mon, Feb 18, 2013 at 02:21:30PM +0100, Rainer M Krug wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> Hi >> >> I am using notmuch in emacs, and I linkt from my notes in org mode to emails >> using the >> thread: id or the message id. Is there a possibility to get these from >> within emacs, or do I >> have to go to the cli from notmuch? >> > > As far as I'm aware, org-notmuch does all that for you. Actually, you might be right. But then it seems, I somehow haven't loaded org-notmuch.el properly - - I guess I am miaaing something at this step. But it also seems that org-notmuch-search-store-link stores the search string and not the thread or message id? Thanks, Rainer > Do you need it for something else? You can always look at org-notmuch source. > > Cheers, > -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRIjU9AAoJENvXNx4PUvmCZh0H/iR+K4nfhRVg9XTw/Uupxz6z XbArO14poJ8H4bcRjp1pGr7yuGUByKz26oLPGC9T79y4v9yF4hZVsXpNaU6w3CKe wJO6g7ektebwwfY4bYbMihL8iUqp45jXxAtg/kvY7XnJkK8yWQdSTpvStOoNtrJA 29X/yTykThNO62aDDF9dgYhb5Y6jG3ONX4Zx1f2vOo7OePsLzvteC7muwPNNQmXl dua4wAIqIrDWdAjX3L+zUw6aZ6EKa5Mzpv2MxCQwlayqnKXQpu1QhWnxMnk/QxzD 4IC4rneCI367jm2nGH+7+4SXRY+BfNyHpnn5f1BBuCTP+MubKh3Jr706znvfMCY= =TeSY -END PGP SIGNATURE-
How to get thread id in emacs ui?
On Mon, Feb 18, 2013 at 02:21:30PM +0100, Rainer M Krug wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi > > I am using notmuch in emacs, and I linkt from my notes in org mode to emails > using the thread: id > or the message id. Is there a possibility to get these from within emacs, or > do I have to go to > the cli from notmuch? > As far as I'm aware, org-notmuch does all that for you. Do you need it for something else? You can always look at org-notmuch source. Cheers, -- Suvayu Open source is the future. It sets us free.
How to get thread id in emacs ui?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi I am using notmuch in emacs, and I linkt from my notes in org mode to emails using the thread: id or the message id. Is there a possibility to get these from within emacs, or do I have to go to the cli from notmuch? Thanks, Rainer - -- Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation Biology, UCT), Dipl. Phys. (Germany) Centre of Excellence for Invasion Biology Stellenbosch University South Africa Tel : +33 - (0)9 53 10 27 44 Cell: +33 - (0)6 85 62 59 98 Fax : +33 - (0)9 58 10 27 44 Fax (D):+49 - (0)3 21 21 25 22 44 email: Rainer at krugs.de Skype: RMkrug -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRIiraAAoJENvXNx4PUvmCXsgIALT65uIVuERvoNgL8wjijLmG uefH+kJZx9g4FCQvaj06gHm1W6jrkUMx7X9jjyryypvq31yAD0rDW1I4GwgQHhnW 6+VKgc7uudoge8nOgEc+Z1tkG7e/ZwrQ0F8ErP1AqSOUHm9pG7MetltzP80Z3Qe+ 4LAFcTj7rsg0d2+t5v9jpOqcy08j4mingf99noQ0czk7trbUadEzcBDsUrNL35uX z9V1M61mOfKhShRuk5XV/gv+f7F+rkVxqIqkA+m0MWYA19J45/yhcla9drFXeFd0 r1h9zY0clUupMxA31fCfvHqUMS4D941y+yPyPwGDTQdFPJuWeaKPLAJ+9v2JMaY= =cjnz -END PGP SIGNATURE-
How to get thread id in emacs ui?
Rainer M Krug writes: > >> By the way, the library org-notmuch distributed with org-mode should >> make it easy to link into notmuch. > > Then I probably haven't loaded org-notmuch properly? What do I have to > put into my .emacs file to load it properly? > I put what I know at http://notmuchmail.org/emacstips/#index24h2 It's a bit Debian specific at the moment, but hopefully others can fill in the details for other environments. d
How to get thread id in emacs ui?
Rainer M Krug writes: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi > > I am using notmuch in emacs, and I linkt from my notes in org mode to emails > using the thread: id > or the message id. Is there a possibility to get these from within emacs, or > do I have to go to > the cli from notmuch? > You want "c i" >From NEWS for 0.15 Support for stashing the thread id in show view Invoking `notmuch-show-stash-message-id` with a prefix argument stashes the (local and database specific) thread id of the current thread instead of the message id. By the way, the library org-notmuch distributed with org-mode should make it easy to link into notmuch. Be aware that thread id's are not preserved across dump-restore cycles, so it is safer to link to message-ids. d
How to get thread id in emacs ui?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi I am using notmuch in emacs, and I linkt from my notes in org mode to emails using the thread: id or the message id. Is there a possibility to get these from within emacs, or do I have to go to the cli from notmuch? Thanks, Rainer - -- Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation Biology, UCT), Dipl. Phys. (Germany) Centre of Excellence for Invasion Biology Stellenbosch University South Africa Tel : +33 - (0)9 53 10 27 44 Cell: +33 - (0)6 85 62 59 98 Fax : +33 - (0)9 58 10 27 44 Fax (D):+49 - (0)3 21 21 25 22 44 email: rai...@krugs.de Skype: RMkrug -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRIiraAAoJENvXNx4PUvmCXsgIALT65uIVuERvoNgL8wjijLmG uefH+kJZx9g4FCQvaj06gHm1W6jrkUMx7X9jjyryypvq31yAD0rDW1I4GwgQHhnW 6+VKgc7uudoge8nOgEc+Z1tkG7e/ZwrQ0F8ErP1AqSOUHm9pG7MetltzP80Z3Qe+ 4LAFcTj7rsg0d2+t5v9jpOqcy08j4mingf99noQ0czk7trbUadEzcBDsUrNL35uX z9V1M61mOfKhShRuk5XV/gv+f7F+rkVxqIqkA+m0MWYA19J45/yhcla9drFXeFd0 r1h9zY0clUupMxA31fCfvHqUMS4D941y+yPyPwGDTQdFPJuWeaKPLAJ+9v2JMaY= =cjnz -END PGP SIGNATURE- ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: How to get thread id in emacs ui?
On Mon, Feb 18, 2013 at 02:21:30PM +0100, Rainer M Krug wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi I am using notmuch in emacs, and I linkt from my notes in org mode to emails using the thread: id or the message id. Is there a possibility to get these from within emacs, or do I have to go to the cli from notmuch? As far as I'm aware, org-notmuch does all that for you. Do you need it for something else? You can always look at org-notmuch source. Cheers, -- Suvayu Open source is the future. It sets us free. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: How to get thread id in emacs ui?
Rainer M Krug r.m.k...@gmail.com writes: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi I am using notmuch in emacs, and I linkt from my notes in org mode to emails using the thread: id or the message id. Is there a possibility to get these from within emacs, or do I have to go to the cli from notmuch? You want c i From NEWS for 0.15 Support for stashing the thread id in show view Invoking `notmuch-show-stash-message-id` with a prefix argument stashes the (local and database specific) thread id of the current thread instead of the message id. By the way, the library org-notmuch distributed with org-mode should make it easy to link into notmuch. Be aware that thread id's are not preserved across dump-restore cycles, so it is safer to link to message-ids. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: How to get thread id in emacs ui?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 18/02/13 14:36, Suvayu Ali wrote: On Mon, Feb 18, 2013 at 02:21:30PM +0100, Rainer M Krug wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi I am using notmuch in emacs, and I linkt from my notes in org mode to emails using the thread: id or the message id. Is there a possibility to get these from within emacs, or do I have to go to the cli from notmuch? As far as I'm aware, org-notmuch does all that for you. Actually, you might be right. But then it seems, I somehow haven't loaded org-notmuch.el properly - - I guess I am miaaing something at this step. But it also seems that org-notmuch-search-store-link stores the search string and not the thread or message id? Thanks, Rainer Do you need it for something else? You can always look at org-notmuch source. Cheers, -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRIjU9AAoJENvXNx4PUvmCZh0H/iR+K4nfhRVg9XTw/Uupxz6z XbArO14poJ8H4bcRjp1pGr7yuGUByKz26oLPGC9T79y4v9yF4hZVsXpNaU6w3CKe wJO6g7ektebwwfY4bYbMihL8iUqp45jXxAtg/kvY7XnJkK8yWQdSTpvStOoNtrJA 29X/yTykThNO62aDDF9dgYhb5Y6jG3ONX4Zx1f2vOo7OePsLzvteC7muwPNNQmXl dua4wAIqIrDWdAjX3L+zUw6aZ6EKa5Mzpv2MxCQwlayqnKXQpu1QhWnxMnk/QxzD 4IC4rneCI367jm2nGH+7+4SXRY+BfNyHpnn5f1BBuCTP+MubKh3Jr706znvfMCY= =TeSY -END PGP SIGNATURE- ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: How to get thread id in emacs ui?
Rainer M Krug r.m.k...@gmail.com writes: By the way, the library org-notmuch distributed with org-mode should make it easy to link into notmuch. Then I probably haven't loaded org-notmuch properly? What do I have to put into my .emacs file to load it properly? I put what I know at http://notmuchmail.org/emacstips/#index24h2 It's a bit Debian specific at the moment, but hopefully others can fill in the details for other environments. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: How to get thread id in emacs ui?
Hello again Rainer, On Mon, Feb 18, 2013 at 03:05:49PM +0100, Rainer M Krug wrote: On 18/02/13 14:36, Suvayu Ali wrote: On Mon, Feb 18, 2013 at 02:21:30PM +0100, Rainer M Krug wrote: I am using notmuch in emacs, and I linkt from my notes in org mode to emails using the thread: id or the message id. Is there a possibility to get these from within emacs, or do I have to go to the cli from notmuch? As far as I'm aware, org-notmuch does all that for you. Actually, you might be right. But then it seems, I somehow haven't loaded org-notmuch.el properly - - I guess I am miaaing something at this step. But it also seems that org-notmuch-search-store-link stores the search string and not the thread or message id? AFAIU, it does that when you call org-store-link in a search buffer. If you do that in the message buffer, it stores the message id. From the search buffer: [[notmuch-search:from:myfriend%2520is:inbox][Notmuch search: from:myfriend is:inbox]] From the message buffer: [[notmuch:id:c8bf5b7c-6f2e-4754-b27d-a828d894b...@gmail.com][Email from Myfriend]] Hope this helps, -- Suvayu Open source is the future. It sets us free. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: How to get thread id in emacs ui?
On Mon, Feb 18, 2013 at 04:05:26PM +0100, Rainer M Krug wrote: On 18/02/13 15:42, David Bremner wrote: Rainer M Krug r.m.k...@gmail.com writes: By the way, the library org-notmuch distributed with org-mode should make it easy to link into notmuch. Then I probably haven't loaded org-notmuch properly? What do I have to put into my .emacs file to load it properly? I put what I know at http://notmuchmail.org/emacstips/#index24h2 Thanks - got it working under Ubuntu. One thing: in my org from git, org-notmuch is in .../org-mode/contrib/lisp and not .../lisp My following comment is probably OT, but still ... If you install org-mode from git following the instructions from the Makefile, then you should be putting something like the following in your local.mk. # Define if you want to include some (or all) files from contrib/lisp # just the filename please (no path prefix, no .el suffix), maybe with # globbing ORG_ADD_CONTRIB = org-notmuch If you do that, then David's instructions are accurate. Hope this helps, -- Suvayu Open source is the future. It sets us free. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH v2 3/6] test: emacs: `notmuch-show-tag-all' with prefix arg should only tag open messages
Pieter Praet pie...@praet.org writes: * test/emacs: - New subtest notmuch-show: change tags of open messages in current buffer: When called with a prefix arg, `notmuch-show-tag-all' (*) should only change the tags of *open* messages. Currently broken, fix follows later. I'm afraid this patch doesn't apply anymore, sorry about that. A rebased version would be welcome (and doesn't need further review). d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/1] devel/release-checks.sh: added check that 1st NEWS header is tidy
Tomi Ollila tomi.oll...@iki.fi writes: Check that the underlining '===...' for first (header) line in NEWS file is of the same length as the header text and it is all '=':s. pushed, sans execs d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/2] test/test-lib.sh: use $test_subtest_name in all tests
Tomi Ollila tomi.oll...@iki.fi writes: Set the variable '$test_subtest_name' in all functions which starts a new test and use that variable in all functions that output test results. pushed both d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH v2] emacs: show: make buttons select window
Mark Walters markwalters1...@gmail.com writes: Emacs has two button type objects: widgets (as used for saved searches in notmuch-hello) and buttons as used by parts/citations and id links in notmuch-show. These two behave subtly differently when clicked with the mouse: widgets select the window clicked before running the action, buttons do not. pushed, d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/6] lib: Clean up error handling in _notmuch_thread_create
Austin Clements amdra...@mit.edu writes: Previously, there were various opportunities for memory leaks in the error-handling paths of this function. Use a local talloc context and some reparenting to make eliminate these leaks, while keeping the control flow simple. pushed all but the python bindings patch. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/6] lib: Clean up error handling in _notmuch_thread_create
David Bremner da...@tethera.net writes: Austin Clements amdra...@mit.edu writes: Previously, there were various opportunities for memory leaks in the error-handling paths of this function. Use a local talloc context and some reparenting to make eliminate these leaks, while keeping the control flow simple. pushed all but the python bindings patch. any comments on that patch, Justus? For reference, id:1353819427-13182-6-git-send-email-amdra...@mit.edu d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] emacs: functions to import sender or recipient into BBDB
On Thu, Feb 07 2013, Daniel Bergey wrote: From a show buffer, notmuch-bbdb/snarf-from imports the sender into bbdb. notmuch-bbdb/snarf-to imports all recipients. Newly imported concacts are reported in the minibuffer / Messages buffer. Both functions use the BBDB parser to recognize email address formats. --- Following discussion upthread, I put everything in notmuch-address. I renamed the functions to put notmuch before bbdb. And I replaced the horrid comma-splitting from my first version with the functions BBDB provides for parsing email headers. It looks as though Reply-To is not exposed in the :headers plist. I assume the Resent-* headers are not, either. Therefore none of these are imported (nil entries in notmuch-bbdb/header-by-name). They would be easy to add if the plist is expanded. Thanks, and sorry it's taken me so long to get back to this patch. From my understanding the code looks pretty good; I have only some whitespace consistency things that jist briefly passes the threshold to mention -- comments inline. But before doing a potential cleanup patch the users of notmuch-bbdb please test and comment emacs/notmuch-address.el | 43 +++ 1 file changed, 43 insertions(+) diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el index 2bf762b..8d5f727 100644 --- a/emacs/notmuch-address.el +++ b/emacs/notmuch-address.el @@ -98,4 +98,47 @@ line. ;; This ';;' used to be 3rd last line in notmuch-address.el. Running 'tail -n 5 emacs/*.el' reveals that it is (somewhat) consistent to use it as separator between code above and (provide 'notmuch-...) that follows. +;; functions to add sender / recipients to BBDB + +(defun notmuch-bbdb/snarf-headers (headers) + ;; Helper function to avoid code duplication in the two below + ;; headers should have the same format as bbdb-get-addresses-headers + + ;; bbdb-get-addresses reads these + ;; Ugh, pass-by-global + (let ((addrs (bbdb-get-addresses nil nil 'notmuch-bbdb/get-header-content)) +(bbdb-get-addresses-headers headers) ; headers to read +(bbdb-gag-messages t) ; suppress m/n processed message +) +(bbdb-update-records addrs t t))) + +(defun notmuch-bbdb/snarf-from () + Import the sender of the current message into BBDB + (interactive) + (notmuch-bbdb/snarf-headers + (list (assoc 'authors bbdb-get-addresses-headers Two spaces above. + +(defun notmuch-bbdb/snarf-to () + Import all recipients of the current message into BBDB + (interactive) + (notmuch-bbdb/snarf-headers + (list (assoc 'recipients bbdb-get-addresses-headers Ditto. + +(defvar notmuch-bbdb/header-by-name + ;; both are case sensitive + '( (From . :From) + (To . :To) + (CC . :Cc) + (BCC . :Bcc) + (Resent-From . nil) + (Reply-To . nil) + (Resent-To . nil) + (Resent-CC . nil)) + Alist for dispatching header symbols as used by notmuch-show-get-header +from strings as used by bbdb-get-addresses) + +(defun notmuch-bbdb/get-header-content (name) + (notmuch-show-get-header (cdr (assoc name notmuch-bbdb/header-by-name + + 2 empty lines --- somewhat consistent with notmuch-lib.el ... but not with anything else ;D (provide 'notmuch-address) -- 1.7.10.4 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
