[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring
On Thu, Feb 06, 2014 at 12:54:56AM +0200, Tomi Ollila wrote:
> On Wed, Feb 05 2014, "W. Trevor King" wrote:
> > On Wed, Feb 05, 2014 at 05:00:45PM +0200, Tomi Ollila wrote:
> >> #DFF for the light-blue works better for me.
> >
> > I'm fine with that. As I said in my cover letter, I'm happy to have
> > alternative color schemes suggested. Does anyone else want to chime
> > in on better defaults? This should probably also be configurable via
> > status-config.json. Maybe:
> >
> >{ "style": {"html": {"thread-colors": ["#DFF", "#FEF"]}}}
>
> Maybe we can persuade David to test-run new notmuch-status in
> his production server before it is pushed to notmuch master, and
> bikeshed the style in http://nmbug.tethera.net/status/
I'll remove this once the series lands, but I've currently got a
preview up at http://tremily.us/status.html
> probably no-one is interested to configure those later (if we even
> get bikeshed comments... ;)
I suppose we can revisit this when someone with an existing color
scheme decides to use nmbug and nmbug-status as their bugtracker (red
a gray for Red Hat? Blue and yellow for Python? ;). Until then, I'm
fine with hardcoding this.
Cheers,
Trevor
--
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20140206/2c598ba5/attachment.pgp>
[PATCH v4] build: write VERSION file containing $(VERSION) string
This version file will be as prerequisite to the target files
that use the version info for some purpose, like printing
it to the user to examine. The contents of the VERSION file
is seldom read by the build system itself as the $(VERSION)
variable has the same information.
---
ctested also with:
mv .git .x
make
cat VERSION version
mv .x .git
make
cat VERSION version
Makefile.local | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/Makefile.local b/Makefile.local
index 174506c..65c91cb 100644
--- a/Makefile.local
+++ b/Makefile.local
@@ -21,7 +21,13 @@ endif
VERSION:=$(shell cat ${srcdir}/version)
ifeq ($(filter release release-message pre-release
update-versions,$(MAKECMDGOALS)),)
ifeq ($(IS_GIT),yes)
-VERSION:=$(shell git describe --match '[0-9.]*'|sed -e s/_/~/ -e s/-/+/ -e
s/-/~/)
+# Also write VERSION file in case its contents differ from $(VERSION)
+VERSION:=$(shell\
+ gv=`git describe --match '[0-9.]*'|sed -e s/_/~/ -e s/-/+/ -e s/-/~/`;\
+ test -f VERSION || touch VERSION;\
+ read fv < VERSION;\
+ test x"$$fv" = x"$$gv" || echo "$$gv" > VERSION;\
+ echo "$$gv")
endif
endif
@@ -69,6 +75,11 @@ ifeq ($(shell cat .first-build-message 2>/dev/null),)
endif
endif
+# Depend (also) on 'version' file. In case of ifeq ($(IS_GIT),yes)
+# this file may already have been updated.
+VERSION: version
+ echo $(VERSION) > $@
+
$(TAR_FILE):
if git tag -v $(VERSION) >/dev/null 2>&1; then \
ref=$(VERSION); \
@@ -280,6 +291,8 @@ notmuch_client_srcs = \
notmuch_client_modules = $(notmuch_client_srcs:.c=.o)
+notmuch.o: VERSION
+
notmuch: $(notmuch_client_modules) lib/libnotmuch.a util/libutil.a
parse-time-string/libparse-time-string.a
$(call quiet,CXX $(CFLAGS)) $^ $(FINAL_LIBNOTMUCH_LDFLAGS) -o $@
@@ -318,7 +331,7 @@ install-desktop:
desktop-file-install --mode 0644 --dir "$(DESTDIR)$(desktop_dir)"
notmuch.desktop
SRCS := $(SRCS) $(notmuch_client_srcs)
-CLEAN := $(CLEAN) notmuch notmuch-shared $(notmuch_client_modules) notmuch.elc
+CLEAN := $(CLEAN) VERSION notmuch notmuch-shared $(notmuch_client_modules)
DISTCLEAN := $(DISTCLEAN) .first-build-message Makefile.config
--
1.8.4.2
[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring
On Wed, Feb 05 2014, "W. Trevor King" wrote:
> On Wed, Feb 05, 2014 at 05:00:45PM +0200, Tomi Ollila wrote:
>> After I fixed the wrapper the program works fine on python 2.6.6.
>
> :)
>
>> now every other thread is background-colored (girly) pink (fef?)
>> and every other light blue (eff). for me the light blue is not
>> visible (there are no body background color set?)
>
> #EFF is visible to me, but it is light.
>
>> #DFF for the light-blue works better for me.
>
> I'm fine with that. As I said in my cover letter, I'm happy to have
> alternative color schemes suggested. Does anyone else want to chime
> in on better defaults? This should probably also be configurable via
> status-config.json. Maybe:
>
>{ "style": {"html": {"thread-colors": ["#DFF", "#FEF"]}}}
Maybe we can persuade David to test-run new notmuch-status in
his production server before it is pushed to notmuch master, and
bikeshed the style in http://nmbug.tethera.net/status/
> ?
probably no-one is interested to configure those later (if we even
get bikeshed comments... ;)
Tomi
>> I think rounded corners are nice but IMHO the round radius is too
>> big -- using 0.5mm for the radius would IMHO be better.
>
> No problem.
>
> Cheers,
> Trevor
[PATCH 0/7] emacs: show tag changes in buffer
On Sun, Jan 19 2014, Mark Walters wrote: > This is a reworked and expanded version of the single patch > id:1387065197-15776-4-git-send-email-markwalters1009 at gmail.com > > This shows any tags changed in the show buffer since it was loaded or > refreshed. By default a removed tag is displayed with strike-through > in red (if strike-through is not available, eg on a terminal, inverse > video is used instead) and an added tag is displayed underlined in > green. This version works in all three views show, search and tree. tl;dr ... ;D -- well, maybe someone reads it through ;) Anyway, this patch series looks good to me (one commit message tl;dr but I guess it is useful for anyone who actually reads it). I don't see anything it may break and I started using this in my notmuch setup from now on. Tomi
Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring
On Thu, Feb 06, 2014 at 12:54:56AM +0200, Tomi Ollila wrote:
On Wed, Feb 05 2014, W. Trevor King wrote:
On Wed, Feb 05, 2014 at 05:00:45PM +0200, Tomi Ollila wrote:
#DFF for the light-blue works better for me.
I'm fine with that. As I said in my cover letter, I'm happy to have
alternative color schemes suggested. Does anyone else want to chime
in on better defaults? This should probably also be configurable via
status-config.json. Maybe:
{ style: {html: {thread-colors: [#DFF, #FEF]}}}
Maybe we can persuade David to test-run new notmuch-status in
his production server before it is pushed to notmuch master, and
bikeshed the style in http://nmbug.tethera.net/status/
I'll remove this once the series lands, but I've currently got a
preview up at http://tremily.us/status.html
probably no-one is interested to configure those later (if we even
get bikeshed comments... ;)
I suppose we can revisit this when someone with an existing color
scheme decides to use nmbug and nmbug-status as their bugtracker (red
a gray for Red Hat? Blue and yellow for Python? ;). Until then, I'm
fine with hardcoding this.
Cheers,
Trevor
--
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
signature.asc
Description: OpenPGP digital signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
[PATCH] emacs: notmuch-hello: Add variable to control order or saved-search results
This allows for the user to control the order that results are returned from saved-searches, (and independently from the order of all other searches which is controlled by notmuch-search-oldest-first). --- This allows me to get back to the behavior that notmuch had long ago, (the documentation for the changed behavior was updated in commit c1a42652a173a4bb70ab72388e6ad150d19a2b06). I'm not sure when the actual behavioral change was made. A fanicer change might allow for a configurable sort order for each saved search, but this more minimal change at least lets me use the latest notmuch once again. emacs/notmuch-hello.el | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 7b3d76b..a9f8230 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -59,6 +59,14 @@ alist to be used. :value notmuch-sort-saved-searches)) :group 'notmuch-hello) +(defcustom notmuch-saved-searches-oldest-first t + Show the oldest mail first for saved-search results. + +This variable defines the default sort order for displaying +saved-search results. + :type 'boolean + :group 'notmuch-hello) + (defvar notmuch-hello-indent 4 How much to indent non-headers.) @@ -327,6 +335,14 @@ diagonal. :notmuch-search-terms) notmuch-search-oldest-first)) +; Like notmuch-hello-widget-search, but with the +; notmuch-saved-searches-oldest-first variable controlling the sort +; order. +(defun notmuch-hello-do-saved-search (widget rest ignore) + (notmuch-search (widget-get widget + :notmuch-search-terms) + notmuch-saved-searches-oldest-first)) + (defun notmuch-saved-search-count (search) (car (process-lines notmuch-command count search))) @@ -460,7 +476,7 @@ Such a list can be computed with `notmuch-hello-query-counts'. (widget-insert (format %8s (notmuch-hello-nice-number msg-count))) (widget-create 'push-button - :notify #'notmuch-hello-widget-search + :notify #'notmuch-hello-do-saved-search :notmuch-search-terms query name) (setq column-indent -- 1.9.rc1 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
