Re: Protected headers in notmuch
Jameson Graef Rollins writes: > I've pushed a branch of this series rebased against notmuch/release (for > some reason master is currently a couple commits behind) and fixed to > reflect the exposure of notmuch_message_get_database: > > https://gitlab.com/jrollins/notmuch/commits/protected-headers-fix > > All tests pass. Note it requires gmime 3.0 (which tripped me up for a > bit since notmuch still implicitly supports older gmime versions). > Depending on how much work that is to fix, it might be time to actually rip out the pre-3.0 support; we deprecated it 7 months ago. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: Protected headers in notmuch
I've pushed a branch of this series rebased against notmuch/release (for some reason master is currently a couple commits behind) and fixed to reflect the exposure of notmuch_message_get_database: https://gitlab.com/jrollins/notmuch/commits/protected-headers-fix All tests pass. Note it requires gmime 3.0 (which tripped me up for a bit since notmuch still implicitly supports older gmime versions). I haven't done a commit-by-commit review yet, but I am now using this series and it works as advertised: messages with encrypted subjects are searchable by the encrypted subject, and the encrypted subjects show up correctly in all the clients I'm using (both CLI and emacs). I strongly support the inclusion of this feature, particularly since it's an important component of autocrypt, which I want even more. jamie. signature.asc Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 18/20] indexing: record protected subject when indexing cleartext
On Fri, May 11 2018, Daniel Kahn Gillmor wrote: > When indexing the cleartext of an encrypted message, record any > protected subject in the database, which should make it findable and > visible in search. > --- > lib/index.cc | 42 ++ ... > diff --git a/lib/index.cc b/lib/index.cc > index 0ad683fa..db16b6f8 100644 > --- a/lib/index.cc > +++ b/lib/index.cc ... > @@ -430,8 +435,13 @@ _index_mime_part (notmuch_message_t *message, > } > continue; > } > - _index_mime_part (message, indexopts, > - g_mime_multipart_get_part (multipart, i)); > + child = g_mime_multipart_get_part (multipart, i); > + status = _notmuch_message_crypto_potential_payload (msg_crypto, > child, part, i); > + if (status) > + _notmuch_database_log (_notmuch_message_database (message), > +"Warning: failed to mark the potential > cryptographic payload (%s).\n", > +notmuch_status_to_string (status)); > + _index_mime_part (message, indexopts, child, msg_crypto); > } > return; > } In 9088db76d89264b733f6b45e776d8952da237921 _notmuch_message_database was exposed as notmuch_message_get_database, so this patch needs to be updated: diff --git a/lib/index.cc b/lib/index.cc index 74e1ba43..18e712b1 100644 --- a/lib/index.cc +++ b/lib/index.cc @@ -438,7 +438,7 @@ _index_mime_part (notmuch_message_t *message, child = g_mime_multipart_get_part (multipart, i); status = _notmuch_message_crypto_potential_payload (msg_crypto, child, part, i); if (status) - _notmuch_database_log (_notmuch_message_database (message), + _notmuch_database_log (notmuch_message_get_database (message), "Warning: failed to mark the potential cryptographic payload (%s).\n", notmuch_status_to_string (status)); _index_mime_part (message, indexopts, child, msg_crypto); This fix doesn't affect any of the subsequent patches in this series. jamie. signature.asc Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: Feature freeze for 0.27
David Bremner writes: > I've tagged 0.27_rc0 and uploaded it to Debian experimental. > For the next week or so I'll take NEWS updates and bugfixes for 0.27. > > The following changes might need a NEWS item, please send patches to > NEWS for your changes > > Antoine Amarilli (1): > doc: create manpage folders with right permissions > > Daniel Kahn Gillmor (15): > cli/insert: add --world-readable flag > doc: Examples of notmuch-reindex use and crypto policy > lib: expose notmuch_message_get_database() > properties: add notmuch_message_count_properties > lib: make notmuch_message_get_database() take a const notmuch_message_t* > cli: write session keys to database, if asked to do so > cli/show: reindex when we learned new session keys about a message > cli/show: enable --decrypt=stash > > David Bremner (45): > doc: add a section on quoting to notmuch-search-terms(7) > lib: add thread subqueries. > bindings: clean extra file created by ruby extension build system > CLI/new: add full-scan option > configure: check for makeinfo and install-info > doc: install build and install info pages My NEWS patches are pushed as part of 0.27~rc1. We need to at least document the new crypto stuff before release ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] configure: check for links to/from libdir in ldconfig output
Tomi Ollila writes: > On Wed, May 30 2018, David Bremner wrote: > >> Tomi Ollila writes: >> >>> On Tue, May 29 2018, David Bremner wrote: >>> If e.g. /lib is a link to /usr/lib, then the latter may not show up in the way we expect in the output of ldconfig. 'test foo -ef bar' checks if foo and bar have the same device and inode numbers. Since (at least in bash, ksh, and zsh) the shell dereferences symlinks before applying >>> >>> i think you have to add 'dash' to this list in this commit message, as it >>> is default /bin/sh in debian (and many debian-derived distributions); >>> that is quite common configuration there when the test line in question >>> is executed >> >> That's right. I even tested dash, _after_ I sent the patch :P >> >> What do you think about the risk/benefit of including this in 0.27? I >> guess we have lived with this bug for a long time. > > +1 for inclusion. that's how we get testers >:) Pushed as part of 0.27_rc1 d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 2/3] NEWS: mention notmuch --full-scan
David Bremner writes: This, and the next patch pushed as part of 0.27_rc1 d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/3] NEWS: mention thread:{} queries
David Bremner writes: > --- > NEWS | 9 + > 1 file changed, 9 insertions(+) > pushed as part of 0.27_rc1 d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/2] NEWS: deprecate pre-1.4.0 Xapian
David Bremner writes: > We want to give people some heads up before dropping support, since > removing a bunch of ifdefs will be a pain to revert. pushed as part of 0.27_rc1 d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
