Re: [PATCH v2 2/3] emacs: Pass the part to text/plain hook functions
David Edmondson writes: > Some text/plain hook functions may wish to access the details of the > part that is being manipulated. > --- > emacs/notmuch-show.el | 2 +- > emacs/notmuch-wash.el | 10 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index 78f1af47..b3cefcd9 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el > @@ -744,7 +744,7 @@ will return nil if the CID is unknown or cannot be > retrieved." > (save-excursion >(save-restriction > (narrow-to-region start (point-max)) > - (run-hook-with-args 'notmuch-show-insert-text/plain-hook msg depth > + (run-hook-with-args 'notmuch-show-insert-text/plain-hook msg part > depth >t) > I wonder if it would be better to have depth last as an optional parameter, so that existing user written hooks don't break. I don't know if 1) that works in practice 2) there are a non-trivial number of user written text/plain hooks ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH v2 1/2] emacs: Optionally check for missing attachments in outgoing messages
David Edmondson writes: > Query the user if the message text indicates that an attachment is > expected but no MML referencing an attachment is found. > series pushed ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/2] test: add two known broken tests searching for xapian keywords
David Bremner writes: > Thanks to plujon for pointing out this problem on IRC. The underlying > issue is that the quotes are stripped before the field processors get > the query string, and the heuristic for putting them back is not quite > right. > --- Series pushed. Let me know if it breaks something. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH v1 1/1] emacs: Easy access to URLs mentioned in the current message
David Edmondson writes: > Add a new binding when looking at messages, B, that prompts with a > list of URLs found in the current message, if any. Open the one that > is selected in a browser. pushed, amended as discussed. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH v1 1/1] emacs: Easy access to URLs mentioned in the current message
David Edmondson writes: > On Thursday, 2019-03-28 at 08:23:37 -03, David Bremner wrote: > >> David Edmondson writes: >> >> >>> +(defun notmuch-show--browse-urls () >>> + "Offer to browse any URLs in the current message." >>> + (interactive) >>> + (let ((urls (notmuch-show--gather-urls))) >>> +(if urls >>> + (browse-url (completing-read "Browse URL: " (cdr urls) nil nil (car >>> urls))) >>> + (message "No URLs found." >>> + >>> (provide 'notmuch-show) >> >> It's a minor point, but should this really have -- to signal a private >> function? It's bound to key which sortof makes it defacto public, no? > > Yes. > > Do you want an updated patch or will you fix it on the fly? > I can fix it. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] NEWS: deprecate Emacs 24
David Edmondson writes: >> + >> +Support for GNU Emacs older than 24 is deprecated with this release, >> +and may be removed in a future release. >> + > > “older than 24” implies to me that 24 is supported. > > dme. > -- > I get this feeling I'm in motion, a sudden sense of liberty. Oops. I was thinking "older than 25", but failed to write that. Thanks for the correction. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] NEWS: deprecate Emacs 24
On Thursday, 2019-03-28 at 08:31:03 -03, David Bremner wrote: > --- > NEWS | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/NEWS b/NEWS > index 9fcb57ed..5dffd5a2 100644 > --- a/NEWS > +++ b/NEWS > @@ -7,6 +7,12 @@ Command Line Interface > `notmuch show` now supports --body=false and --include-html with > --format=text > > +Emacs > +- > + > +Support for GNU Emacs older than 24 is deprecated with this release, > +and may be removed in a future release. > + “older than 24” implies to me that 24 is supported. dme. -- I get this feeling I'm in motion, a sudden sense of liberty. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH v1 1/1] emacs: Easy access to URLs mentioned in the current message
On Thursday, 2019-03-28 at 08:23:37 -03, David Bremner wrote: > David Edmondson writes: > > >> +(defun notmuch-show--browse-urls () >> + "Offer to browse any URLs in the current message." >> + (interactive) >> + (let ((urls (notmuch-show--gather-urls))) >> +(if urls >> +(browse-url (completing-read "Browse URL: " (cdr urls) nil nil (car >> urls))) >> + (message "No URLs found." >> + >> (provide 'notmuch-show) > > It's a minor point, but should this really have -- to signal a private > function? It's bound to key which sortof makes it defacto public, no? Yes. Do you want an updated patch or will you fix it on the fly? dme. -- I'm catching up with myself! ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [vim] Plugin crashes on certain multi-mime emails
Nicolas Lesser writes: > For some emails, notmuch-vim crashes. I can't figure out the reason for > this. The stack trace is: > > Error detected while processing function > 13_search_show_thread[10]..13_show: > line 39: > NoMethodError: undefined method `mime_type' for nil:NilClass > eval:22:in `block (2 levels) in ' > eval:8:in `each' > eval:8:in `block in ' > eval:323:in `render' > eval:4:in `' > eval:8:in `command' > eval:8:in `' > > The error seems to only come up for multi-mime emails, but then also not > all of them. It seems like the error is that find_first_text returns nil, > but that can only happen if the message doesn't have any content-type > "text/plain" or "text/html" AFAICT, but I checked: It does both. GMail > doesn't have any problems reading that same email. > > Any ideas? Thanks. Not really, but maybe looking at the output from devel/printmimestructure can give some clues. Also looking at the output of notmuch show on the command line. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
[PATCH] NEWS: deprecate Emacs 24
--- NEWS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS b/NEWS index 9fcb57ed..5dffd5a2 100644 --- a/NEWS +++ b/NEWS @@ -7,6 +7,12 @@ Command Line Interface `notmuch show` now supports --body=false and --include-html with --format=text +Emacs +- + +Support for GNU Emacs older than 24 is deprecated with this release, +and may be removed in a future release. + Notmuch 0.28.3 (2019-03-05) === -- 2.20.1 ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: inconsistent handling of stderr in notmuch-emacs
Tomi Ollila writes: > > for Older emacses the following code snippet could be utilized > (originally a13b38824 (Austin Clements 2013-05-31)): > > (proc (apply #'start-process name buffer > "/bin/sh" "-c" > "exec 2>\"$1\"; shift; exec \"$0\" \"$@\"" > command err-file args)) > > But if we dropped support for emacs 24 (NEWS.25 mentioned make-process) > then we could use make-process everywhere :D I'm OK with deprecating support for emacs24 in the next release, and considering that the medium term plan for dealing with this issue. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH v1 1/1] emacs: Easy access to URLs mentioned in the current message
David Edmondson writes: > +(defun notmuch-show--browse-urls () > + "Offer to browse any URLs in the current message." > + (interactive) > + (let ((urls (notmuch-show--gather-urls))) > +(if urls > + (browse-url (completing-read "Browse URL: " (cdr urls) nil nil (car > urls))) > + (message "No URLs found." > + > (provide 'notmuch-show) It's a minor point, but should this really have -- to signal a private function? It's bound to key which sortof makes it defacto public, no? d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH v2 1/2] emacs: Optionally check for missing attachments in outgoing messages
David Bremner writes: > > notmuch-mua-send-hook is not firing for me. I ran the following test > > ./devel/try-emac-mua -q > > (add-hook 'notmuch-mua-send-hook (lambda () (error "boo!"))) C-x C-e > (notmuch-hello) C-x C-e > m > delete Fcc header > C-c C-c > select trasport > > Nothing in messages from my hook, no traceback. > > This is not caused by your patches, but seems like we should figure out > what's going on? For the record, this was fixed in notmuch 0.28 ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
