[PATCH] NEWS: add news entry for tree navigation changes

2020-08-22 Thread William Casarin
Signed-off-by: William Casarin 
---
 NEWS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/NEWS b/NEWS
index b25bfaa3..9e635ab6 100644
--- a/NEWS
+++ b/NEWS
@@ -6,6 +6,8 @@ Emacs
 
 The minimum supported major version of GNU Emacs is now 25.1.
 
+Support for moving between threads after notmuch-tree-from-search-thread.
+
 Notmuch-Mutt
 
 
-- 
2.28.0
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: [PATCH v2] emacs: Use pop-to-buffer-same-window rather than switch-to-buffer

2020-08-22 Thread Sean Whitton
Hello,

On Sat 22 Aug 2020 at 12:04PM +03, Tomi Ollila wrote:

> On Tue, Aug 11 2020, Sean Whitton wrote:
>
>> This means that notmuch commands obey display-buffer-alist so the user
>> can customize how buffers show up.
>>
>> It also permits the use of C-x 4 4, C-x 5 5 and C-x t t, available in
>> Emacs 28.  For example, one can use C-x 4 4 M-x notmuch-jump-search RET
>> to open a saved search in another window rather than the current window.
>> Or in notmuch-search mode, C-x 5 5 RET to view the message at point in
>> a new frame.
>>
>> notmuch-tree has custom buffer display logic, so bind
>> display-buffer-overriding-action to make pop-to-buffer-same-window
>> behave exactly as switch-to-buffer while that function is running.
>> ---
>> Changes since v1: rebased onto latest master.
>
> I've been having this in my emacs setup (one-notmuch.elc =D) couple
> of days, and haven't seen anything strange.

Thanks both for testing it!

-- 
Sean Whitton
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


call for NEWS entries for 0.31

2020-08-22 Thread David Bremner

Here's a lightly edited output from git shortlog to jog your collective
memories. Please send patches for NEWS for any non-trivial user visible
changes.

David Bremner (125):
  test: add known broken test for error handling on closed database
  lib: catch error from closed db in n_m_get_message_id
  lib: migrate to post Xapian 1.3.4 compact support
  lib: migrate from Xapian ValueRangeProcessor to RangeProcessor
  test: drop upgrade from v1 tests
  lib: add regression test for n_m_get_date; clarify API
  doc: replace use of environment variables with a generated config
  doc: add new python bindings to main documentation tree.
  lib: catch exceptions in n_m_get_flag, provide n_m_get_flag_st
  lib: add notmuch_message_has_maildir_flag_st
  cli/new: replace newly deprecated n_m_has_maildir_flag
  test: add regression test for n_m_maildir_flags_to_tags
  test: add broken test for n_m_remove_all_tags
  lib: handle xapian exception in n_m_remove_all_tags
  lib: fix return value for n_m_reindex
  lib: move deallocation of memory from n_d_close to n_d_destroy
  lib/n_d_get_version: catch exceptions and clarify the API
  lib: convert relative filenames to absolute in n_d_index_file
  lib: replace use of static_cast for writable databases
  build: upload html docs as part of release process
  lib: return NULL from n_d_get_default_indexopts on error
  lib: catch exceptions in n_directory_get_child_directories
  lib: catch exceptions in n_directory_get_child_files
  lib: fix return value for n_directory_delete

Jonas Bernoulli (38):
  test: Deal with Emacs 27 switching to lexical scope by default
  test: Remove misguided emacs testing utilities
  test: Explicitly state that we want to sign with sender
  emacs: Extend face to window edge again
  emacs: Fix some function declarations
  emacs: notmuch-poll: Let the user know we are polling
  emacs: Improve doc-strings
  emacs: Autoload notmuch-jump-search only once
  emacs: Autoload notmuch-jump using an autoload cookie
  emacs: Use cl-incf where appropriate
  emacs: Remove notmuch-setq-local
  emacs: Remove notmuch-read-char-choice
  emacs: Drop old advices that were only need for Emacs 23
  emacs: Do not abuse advice to monkey patch while testing
  emacs: Use new advice mechanism do advice mm-shr


Jonas Witschel (1):
  doc: make gzipped man pages reproducible

Sean Whitton (2):
  emacs: notmuch-search: avoid wiping out buffer-local variables
  emacs: Use pop-to-buffer-same-window rather than switch-to-buffer

Teemu Likonen (3):
  Emacs: Ensure left-to-right display for message headers
  Emacs: Indent first header line only when indentation is turned on

William Casarin (3):
  emacs/tree: introduce notmuch-tree-parent-buffer variable
  emacs/tree: enable moving to next thread in search results
  emacs/tree: add notmuch-tree-archive-thread-then-next

Đoàn Trần Công Danh (3):
  configure: check for pytest with python -m pytest
  configure: drop check for default xapian backend
  T355: specify hash algorithm explicitly
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: [PATCH v2] emacs: Use pop-to-buffer-same-window rather than switch-to-buffer

2020-08-22 Thread David Bremner
Sean Whitton  writes:

> This means that notmuch commands obey display-buffer-alist so the user
> can customize how buffers show up.
>

applied to release and master
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: [PATCH] AUTHORS: update for 0.31

2020-08-22 Thread David Bremner
David Bremner  writes:

> Just shuffles existing authors around, mainly due to Jonas's
> enthusiastic cleanup work.

applied to release and master

d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: [PATCH v2] Emacs: Fix notmuch-message-summary-face definition

2020-08-22 Thread David Bremner
Teemu Likonen  writes:

>
> This change fixes the face definition form to produce:
>
> ((DISPLAY
>   :extend t :background "#f0f0f0")
>  (DISPLAY
>   :extend t :background "#303030"))
>
> which follows the (DISPLAY . PLIST) format (see above).

applied to release and master

d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: [PATCH v2] emacs: Use pop-to-buffer-same-window rather than switch-to-buffer

2020-08-22 Thread Tomi Ollila
On Tue, Aug 11 2020, Sean Whitton wrote:

> This means that notmuch commands obey display-buffer-alist so the user
> can customize how buffers show up.
>
> It also permits the use of C-x 4 4, C-x 5 5 and C-x t t, available in
> Emacs 28.  For example, one can use C-x 4 4 M-x notmuch-jump-search RET
> to open a saved search in another window rather than the current window.
> Or in notmuch-search mode, C-x 5 5 RET to view the message at point in
> a new frame.
>
> notmuch-tree has custom buffer display logic, so bind
> display-buffer-overriding-action to make pop-to-buffer-same-window
> behave exactly as switch-to-buffer while that function is running.
> ---
> Changes since v1: rebased onto latest master.

I've been having this in my emacs setup (one-notmuch.elc =D) couple
of days, and haven't seen anything strange.

Just now I tested a bit more, tried show and tree modes, with 
M-x debug-on-entry pop-to-buffer-same-window active and see some
call paths (interestingly (or not so), starting this mail composition
pop-to-buffer-same-window was not in call path -- but probably 
switch-to-buffer would be neither and there is no change in status quo)

So LGTM.

Tomi

>
>  emacs/notmuch-draft.el |  3 ++-
>  emacs/notmuch-hello.el |  2 +-
>  emacs/notmuch-show.el  |  8 
>  emacs/notmuch-tree.el  | 13 +
>  emacs/notmuch.el   |  4 ++--
>  5 files changed, 18 insertions(+), 12 deletions(-)
>
> diff --git a/emacs/notmuch-draft.el b/emacs/notmuch-draft.el
> index 759e6c9e..283830ad 100644
> --- a/emacs/notmuch-draft.el
> +++ b/emacs/notmuch-draft.el
> @@ -232,7 +232,8 @@ applied to newly inserted messages)."
>(draft (equal tags (notmuch-update-tags tags notmuch-draft-tags
>  (when (or draft
> (yes-or-no-p "Message does not appear to be a draft: edit as new? 
> "))
> -  (switch-to-buffer (get-buffer-create (concat "*notmuch-draft-" id 
> "*")))
> +  (pop-to-buffer-same-window
> +   (get-buffer-create (concat "*notmuch-draft-" id "*")))
>(setq buffer-read-only nil)
>(erase-buffer)
>(let ((coding-system-for-read 'no-conversion))
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index c127bba9..bb60a890 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -973,7 +973,7 @@ following:
>(let ((notmuch-hello-auto-refresh nil))
>  (if no-display
>   (set-buffer "*notmuch-hello*")
> -  (switch-to-buffer "*notmuch-hello*")))
> +  (pop-to-buffer-same-window "*notmuch-hello*")))
>;; Install auto-refresh hook
>(when notmuch-hello-auto-refresh
>  (add-hook 'window-configuration-change-hook
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index b0f2d28b..98d9c935 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -1241,7 +1241,7 @@ matched."
>   (eval (car (get 'mm-inline-override-types 
> 'standard-value
>(cons "application/*" mm-inline-override-types)
>  mm-inline-override-types)))
> -(switch-to-buffer (get-buffer-create buffer-name))
> +(pop-to-buffer-same-window (get-buffer-create buffer-name))
>  ;; No need to track undo information for this buffer.
>  (setq buffer-undo-list t)
>  (notmuch-show-mode)
> @@ -1998,7 +1998,7 @@ to show, nil otherwise."
>(let* ((id (notmuch-show-get-message-id))
>(buf (get-buffer-create (concat "*notmuch-raw-" id "*")))
>(inhibit-read-only t))
> -(switch-to-buffer buf)
> +(pop-to-buffer-same-window buf)
>  (erase-buffer)
>  (let ((coding-system-for-read 'no-conversion))
>(call-process notmuch-command nil t nil "show" "--format=raw" id))
> @@ -2057,7 +2057,7 @@ message."
> (set-buffer-modified-p nil)
> (setq buffer-read-only t)
> (unless (zerop exit-code)
> - (switch-to-buffer-other-window buf)
> + (pop-to-buffer buf)
>   (message (format "Command '%s' exited abnormally with code %d"
>shell-command exit-code
>  
> @@ -2465,7 +2465,7 @@ If the part is displayed in an external application 
> then close
>  the new buffer."
>(let ((buf (get-buffer-create (generate-new-buffer-name
>(concat " *notmuch-internal-part*")
> -(switch-to-buffer buf)
> +(pop-to-buffer-same-window buf)
>  (if (eq (mm-display-part handle) 'external)
>   (kill-buffer buf)
>(goto-char (point-min))
> diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
> index fbba4bb3..f36a6e72 100644
> --- a/emacs/notmuch-tree.el
> +++ b/emacs/notmuch-tree.el
> @@ -543,9 +543,14 @@ NOT change the database."
>(setq notmuch-tree-message-window
>   (split-window-vertically (/ (window-height) 4)))
>(with-selected-window notmuch-tree-message-window
> - ;; Since we are only displaying one message do not indent.
> - (let ((notmuch-show-indent-messages-width 0)
> -