Re: [PATCH v2 0/2] scaffolding for autocrypt support

2021-02-22 Thread Daniel Kahn Gillmor
Hi David, all--

On Sun 2021-02-21 15:21:30 +, David Edmondson wrote:
> I started looking at how to add autocrypt support based on
> https://git.sr.ht/~zge/autocrypt.

Thanks for this work, i'm glad to see the interest in autocrypt!

I tend to think that the autocrypt handling belongs in libnotmuch, and
not just in the emacs frontend, so i'm a bit concerned about what we'll
have to prune out of the emacs frontend if we do manage to land the
features in libnotmuch itself.

I want it in libnotmuch and in the cli because:

 a) i want the database to hold the autocrypt tables, so that it can be
dumped/restored between notmuch-based clients

 b) i want non-emacs frontends of notmuch to be able to make use of it
relatively easily.

that said, i've failed to get the code into shape for libnotmuch yet,
and i also don't want to block this work -- i want to see more autocrypt
adoption generally, and i'm feeling guilty for having been so tardy in
getting ito into notmuch.

My general outline for getting autocrypt into notmuch is the following
list of steps.  it's a fairly long list, but each step shouldn't be a
huge amount of work.

 0) augment the database so that it can store the autocrypt "peers"
table and the autocrypt "accounts" table, and they can be dumped and
restored.  see
https://autocrypt.org/level1.html#autocrypt-internal-state

 1) add a configuration option that affects "notmuch
{new,insert,reindex}" that ingests the loading of autocrypt headers
according to the standard policy for updating the peer state (see
https://autocrypt.org/level1.html#updating-autocrypt-peer-state)

 2) add a configuration option that affects "notmuch
{new,insert,reindex}" that enables detection of any Autocrypt Setup
Message from another client sharing the same inbox, and adjusts the
"accounts" table appropriately.

 3) add a "notmuch autocrypt" subcommand with its own subsubcommands:
"notmuch autocrypt enable  [mutual]" and "notmuch autocrypt
disable " -- these subsubcommands update the "accounts" table
as well.

 4) add "notmuch autocrypt generate-setup-message" subsubcommand for
enabled accounts that produces its own self-targeted Autocrypt Setup
Message on stdout, which can be injected into the mailsystem
by the user's notmuch setup.

 5) Add "notmuch autocrypt prune" subsubcommand which clears accumulated
cruft from the autocrypt peers table

 6) in libnotmuch, if  is a source e-mail address, and  is a
set of destination addresses, add  is a
boolean, a new function notmuch_autocrypt_recommendation(,
, ) that returns an Autocrypt
Recommendation (ui-recommendation and a set of target-keys, see

https://autocrypt.org/level1.html#provide-a-recommendation-for-message-encryption)

 7) add a new subsubcommand that exposes
notmuch_autocrypt_recommendation() to the cli.

 8) emacs frontend work during message composition (i have no idea how
to do this) -- dynamically adjust the message composition buffer as
the from, to, cc, and bcc fields change to show the current
autocrypt recommendation status, in combination with the ability for
the user to manually turn on encryption (if available) or off (if on
by default).

 9) more emacs frontend work -- at send time (at the end of composition)
if the autocrypt recommendation is encrypt, or if it's available and
the user has manually turned it on, encrypt the message using
standard autocrypt format (which is just PGP/MIME, using the
recommended keys).

It's possible that (9) could be replaced with a new subcommand like
"notmuch send" which could have a "--autocrypt-checked" argument, such
that the notmuch cli actually does the full encryption for the user, or
acts as some sort of filter for the outgoing message.  there might also
be some library-level work that could use notmuch and gmime to translate
the message this way; I haven't really pieced those things together, or
how they would integrate into the emacs frontend, but the steps laid out
above seem to be necessary for that to happen in either case.

I'd love any collaboration on this -- especially for the parts that i
don't know how to do at all, like the emacs composition window frontend
-- but also on the earlier parts, as i've been procrastinating on it for
too long.

David, do you think this plan will collide with the series you're
proposing?  do you see problems or downsides with the plan sketched here
(other than it not existing 😛)?

> Sending seems straightforward, as far as I understand autocrypt, at
> least.

https://autocrypt.org and the #autocrypt channel on freenode are both
good resources for understanding autocrypt in more detail, fwiw.

 --dkg


signature.asc
Description: PGP signature
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


[PATCH] test/emacs: test for functions in notmuch-search-result-format.

2021-02-22 Thread David Bremner
Based on the commit message in id:20210221151902.2301690-3-...@dme.org
---

I didn't have time so far to write tests for the other two cases, but
maybe this is a start.

 test/T310-emacs.sh| 27 +++
 .../notmuch-search-header-function| 25 +
 2 files changed, 52 insertions(+)
 create mode 100644 test/emacs.expected-output/notmuch-search-header-function

diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh
index 78ac19a8..647c6491 100755
--- a/test/T310-emacs.sh
+++ b/test/T310-emacs.sh
@@ -39,6 +39,33 @@ test_emacs '(notmuch-search "tag:inbox")
(test-output)'
 test_expect_equal_file $EXPECTED/notmuch-search-tag-inbox OUTPUT
 
+test_begin_subtest "Functions in search-result-format"
+test_emacs '(defun -notmuch-result-flags (format-string result)
+ (let ((tags-to-letters (quote (("attachment" . "&")
+("signed" . "=")
+("unread" . "u")
+("inbox" . "i"
+   (tags (plist-get result :tags)))
+   (format format-string
+   (mapconcat (lambda (t2l)
+(if (member (car t2l) tags)
+(cdr t2l)
+  " "))
+  tags-to-letters ""
+   (setq test-search-format
+ (quote ((-notmuch-result-flags . "%s ")
+ ("date" . "%12s ")
+ ("count" . "%9s ")
+ ("authors" . "%-30s ")
+ ("subject" . "%s ")
+ ("tags" . "(%s)"
+   (let
+   ((notmuch-search-result-format test-search-format))
+ (notmuch-search "tag:inbox")
+ (notmuch-test-wait))
+   (test-output)'
+test_expect_equal_file $EXPECTED/notmuch-search-header-function OUTPUT
+
 test_begin_subtest "Incremental parsing of search results"
 test_emacs "(cl-letf* (((symbol-function 'orig)
(symbol-function 'notmuch-search-process-filter))
diff --git a/test/emacs.expected-output/notmuch-search-header-function 
b/test/emacs.expected-output/notmuch-search-header-function
new file mode 100644
index ..08b4bee7
--- /dev/null
+++ b/test/emacs.expected-output/notmuch-search-header-function
@@ -0,0 +1,25 @@
+  ui   2010-12-29 [1/1] François Boulogne  [aur-general] 
Guidelines: cp, mkdir vs install (inbox unread)
+  ui   2010-12-16 [1/1] Olivier Berger Essai accentué 
(inbox unread)
+  ui   2009-11-18 [1/1] Chris Wilson   [notmuch] [PATCH 
1/2] Makefile: evaluate pkg-config once (inbox unread)
+& ui   2009-11-18 [2/2] Alex Botero-Lowry, Carl Worth  [notmuch] [PATCH] 
Error out if no query is supplied to search instead of going into an infinite 
loop (attachment inbox unread)
+  ui   2009-11-18 [2/2] Ingmar Vanhassel, Carl Worth   [notmuch] [PATCH] 
Typsos (inbox unread)
+ =ui   2009-11-18 [3/3] Adrian Perez de Castro, Keith Packard, Carl Worth  
   [notmuch] Introducing myself (inbox signed unread)
+  ui   2009-11-18 [3/3] Israel Herraiz, Keith Packard, Carl Worth  
   [notmuch] New to the list (inbox unread)
+  ui   2009-11-18 [3/3] Jan Janak, Carl Worth  [notmuch] What a 
great idea! (inbox unread)
+  ui   2009-11-18 [2/2] Jan Janak, Carl Worth  [notmuch] [PATCH] 
Older versions of install do not support -C. (inbox unread)
+  ui   2009-11-18 [3/3] Aron Griffis, Keith Packard, Carl Worth
   [notmuch] archive (inbox unread)
+  ui   2009-11-18 [2/2] Keith Packard, Carl Worth  [notmuch] [PATCH] 
Make notmuch-show 'X' (and 'x') commands remove inbox (and unread) tags (inbox 
unread)
+ =ui   2009-11-18 [7/7] Lars Kellogg-Stedman, Mikhail Gusarov, Keith 
Packard, Carl Worth   [notmuch] Working with Maildir storage? (inbox signed 
unread)
+  ui   2009-11-18 [5/5] Mikhail Gusarov, Carl Worth, Keith Packard 
   [notmuch] [PATCH 1/2] Close message file after parsing message headers 
(inbox unread)
+  ui   2009-11-18 [2/2] Keith Packard, Alexander Botero-Lowry  
[notmuch] [PATCH] Create a default notmuch-show-hook that highlights URLs and 
uses word-wrap (inbox unread)
+  ui   2009-11-18 [1/1] Alexander Botero-Lowry [notmuch] request 
for pull (inbox unread)
+  ui   2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry
[notmuch] Mac OS X/Darwin compatibility issues (inbox unread)
+  ui   2009-11-18 [1/1] Rolland Santimano  [notmuch] Link to 
mailing list archives ? (inbox unread)
+  ui   2009-11-18 [1/1] Jan Janak  [notmuch] [PATCH] 
notmuch new: Support for conversion of spool subdirectories into tags (inbox 
unread)
+  ui   2009-11-18