Re: Forcing a sync of maildir flags?
Hello, On Tue 03 May 2022 at 09:14AM -03, David Bremner wrote: > I have the same intuition. Unfortunately it is not as simple as adding > in a couple calls to this function. The complications I am aware of so > far are > > 1) We need to distinguish between when a newly discovered file should > update tags, and when the newly discovered file should have it's flags > updated. > > 2) Renaming files in the middle of notmuch new needs to be done > carefully in order that notmuch doesn't lose track of the files. They > are only lost until the next run of notmuch-new, but it's not ideal. Okay, thanks for the info. Nice to have it all recorded in this thread. -- Sean Whitton ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH v2 1/2] emacs: Make indentation more consistent in notmuch-search-show-thread
Tomi Ollila writes: > To me it looks like this change "breaks" indentation -- the original > where all function (notmuch-show) arguments are aligned vertically, > starting from same column in each line...??? > Argh, it was me that was stupid. I had nameless-mode activated which affects indentation. Please ignore that commit then (I'll retract it with the next re-roll) and apologies for the inconvenience. >> >> base-commit: e3ad0087f3453c89871acac8b11da8bab1ac54df > > btw: what is this 'base commit:' line ? > It's included in the patch by git-format-patch. I think it helps git to know on which commit to apply these patches to. Other projects mandated that option so I have it on by default. /Leo ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH v2 1/2] emacs: Make indentation more consistent in notmuch-search-show-thread
On Mon, May 02 2022, Leo Okawa Ericson wrote: > --- > emacs/notmuch.el | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/emacs/notmuch.el b/emacs/notmuch.el > index c9cf80dc..c1ddb06b 100644 > --- a/emacs/notmuch.el > +++ b/emacs/notmuch.el > @@ -525,13 +525,13 @@ (defun notmuch-search-show-thread ( > elide-toggle) >(let ((thread-id (notmuch-search-find-thread-id))) > (if thread-id > (notmuch-show thread-id > - elide-toggle > - (current-buffer) > - notmuch-search-query-string > - ;; Name the buffer based on the subject. > - (format "*%s*" (truncate-string-to-width > - (notmuch-search-find-subject) > - 30 nil nil t))) To me it looks like this change "breaks" indentation -- the original where all function (notmuch-show) arguments are aligned vertically, starting from same column in each line...??? > +elide-toggle > +(current-buffer) > +notmuch-search-query-string > +;; Name the buffer based on the subject. > +(format "*%s*" (truncate-string-to-width > +(notmuch-search-find-subject) > +30 nil nil t))) >(message "End of search results." > > (defun notmuch-tree-from-search-current-query () > > base-commit: e3ad0087f3453c89871acac8b11da8bab1ac54df btw: what is this 'base commit:' line ? Tomi > -- > 2.36.0 ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: Forcing a sync of maildir flags?
Sean Whitton writes: > Hello David, >> # next line is a no-op, because it already doesn't have the unread tag >> notmuch tag -unread folder:sent > > Seems also worth noting that to my mind it ultimately shouldn't be > necessary to run that command -- notmuch should notice that one copy of > the message has different maildir flags to the other in a way that's out > of sync with the notmuch tags it has. > Right, that's probably a useful way to think about the problem. >> The key point is that from notmuch's point of view the message never has >> the unread tag, so there is no change for "notmuch tag" to sync with >> maildir flags. >> >> It doesn't seem to make a difference if I put the copy in inbox/new or >> inbox/cur, so I don't think it is related to the previous efforts not to >> prematurely move files out of new/. >> >> As far as I can tell, notmuch-new (unlike notmuch-insert) does not call >> notmuch_message_tags_to_maildir_flags, so the maildir flags on the newly >> discovered copy are not updated. Perhaps it should, but that seems like >> a pretty big change, so I want to proceed with caution. > > It makes sense to me for notmuch-new to call that function too, fwiw. I have the same intuition. Unfortunately it is not as simple as adding in a couple calls to this function. The complications I am aware of so far are 1) We need to distinguish between when a newly discovered file should update tags, and when the newly discovered file should have it's flags updated. 2) Renaming files in the middle of notmuch new needs to be done carefully in order that notmuch doesn't lose track of the files. They are only lost until the next run of notmuch-new, but it's not ideal. d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
