[PATCH] NEWS: document that print message prints all parts including hidden parts

2013-01-19 Thread David Bremner
Mark Walters  writes:

> ---
> The new invisibility code means that notmuch-show-print-message prints
> all parts of the message regardless of whether they are shown or
> hidden. This is probably a bug but the correct fix, and even the
> `correct' behaviour is not clear. So for the moment just document the
> current behaviour.

Pushed as part of the release. 

I think that one line commit messages are probably defensible when the
only change is adding NEWS.

d


Re: [PATCH] NEWS: document that print message prints all parts including hidden parts

2013-01-19 Thread David Bremner
Mark Walters markwalters1...@gmail.com writes:

 ---
 The new invisibility code means that notmuch-show-print-message prints
 all parts of the message regardless of whether they are shown or
 hidden. This is probably a bug but the correct fix, and even the
 `correct' behaviour is not clear. So for the moment just document the
 current behaviour.

Pushed as part of the release. 

I think that one line commit messages are probably defensible when the
only change is adding NEWS.

d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


[PATCH] NEWS: document that print message prints all parts including hidden parts

2013-01-17 Thread Tomi Ollila
On Thu, Jan 17 2013, Mark Walters  wrote:

> ---

How did you manage to get this part under the --- -separator;
I think this part below will not go to the commit message.

Otherwise, NEWS entry looks good to me. The same thing happens
when one `copy-region-as-kill`s region -- when yanking the invisible
part appears. This is easily noticiable by user and therefore I suggest
no effort is taken to document it -- someone might even think it
lessens the S/N ratio (due to tl;dr effect).

Tomi


> The new invisibility code means that notmuch-show-print-message prints
> all parts of the message regardless of whether they are shown or
> hidden. This is probably a bug but the correct fix, and even the
> `correct' behaviour is not clear. So for the moment just document the
> current behaviour.
>
> Note the default setup before would also have printed all parts since 
> notmuch-show-all-multipart/alternative-parts defaulted true.
>
> Best wishes
>
> Mark
>
>  NEWS |4 
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index 69f21a0..f16381c 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -81,6 +81,10 @@ Visibility of MIME parts can be toggled
>`notmuch-multipart/alternative-discouraged` and
>`notmuch-show-all-multipart/alternative-parts`.
>  
> +  Note notmuch-show-print-message (bound to '#' by default) will print
> +  all parts of multipart/alternative message regardless of whether
> +  they are currently hidden or shown in the buffer.
> +
>  Emacs now buttonizes mid: links
>  
>mid: links are a standardized way to link to messages by message ID
> -- 
> 1.7.9.1
>
> ___
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch


[PATCH] NEWS: document that print message prints all parts including hidden parts

2013-01-17 Thread Mark Walters
---
The new invisibility code means that notmuch-show-print-message prints
all parts of the message regardless of whether they are shown or
hidden. This is probably a bug but the correct fix, and even the
`correct' behaviour is not clear. So for the moment just document the
current behaviour.

Note the default setup before would also have printed all parts since 
notmuch-show-all-multipart/alternative-parts defaulted true.

Best wishes

Mark

 NEWS |4 
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/NEWS b/NEWS
index 69f21a0..f16381c 100644
--- a/NEWS
+++ b/NEWS
@@ -81,6 +81,10 @@ Visibility of MIME parts can be toggled
   `notmuch-multipart/alternative-discouraged` and
   `notmuch-show-all-multipart/alternative-parts`.

+  Note notmuch-show-print-message (bound to '#' by default) will print
+  all parts of multipart/alternative message regardless of whether
+  they are currently hidden or shown in the buffer.
+
 Emacs now buttonizes mid: links

   mid: links are a standardized way to link to messages by message ID
-- 
1.7.9.1



[PATCH] NEWS: document that print message prints all parts including hidden parts

2013-01-16 Thread Mark Walters
---
The new invisibility code means that notmuch-show-print-message prints
all parts of the message regardless of whether they are shown or
hidden. This is probably a bug but the correct fix, and even the
`correct' behaviour is not clear. So for the moment just document the
current behaviour.

Note the default setup before would also have printed all parts since 
notmuch-show-all-multipart/alternative-parts defaulted true.

Best wishes

Mark

 NEWS |4 
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/NEWS b/NEWS
index 69f21a0..f16381c 100644
--- a/NEWS
+++ b/NEWS
@@ -81,6 +81,10 @@ Visibility of MIME parts can be toggled
   `notmuch-multipart/alternative-discouraged` and
   `notmuch-show-all-multipart/alternative-parts`.
 
+  Note notmuch-show-print-message (bound to '#' by default) will print
+  all parts of multipart/alternative message regardless of whether
+  they are currently hidden or shown in the buffer.
+
 Emacs now buttonizes mid: links
 
   mid: links are a standardized way to link to messages by message ID
-- 
1.7.9.1

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH] NEWS: document that print message prints all parts including hidden parts

2013-01-16 Thread Tomi Ollila
On Thu, Jan 17 2013, Mark Walters markwalters1...@gmail.com wrote:

 ---

How did you manage to get this part under the --- -separator;
I think this part below will not go to the commit message.

Otherwise, NEWS entry looks good to me. The same thing happens
when one `copy-region-as-kill`s region -- when yanking the invisible
part appears. This is easily noticiable by user and therefore I suggest
no effort is taken to document it -- someone might even think it
lessens the S/N ratio (due to tl;dr effect).

Tomi


 The new invisibility code means that notmuch-show-print-message prints
 all parts of the message regardless of whether they are shown or
 hidden. This is probably a bug but the correct fix, and even the
 `correct' behaviour is not clear. So for the moment just document the
 current behaviour.

 Note the default setup before would also have printed all parts since 
 notmuch-show-all-multipart/alternative-parts defaulted true.

 Best wishes

 Mark

  NEWS |4 
  1 files changed, 4 insertions(+), 0 deletions(-)

 diff --git a/NEWS b/NEWS
 index 69f21a0..f16381c 100644
 --- a/NEWS
 +++ b/NEWS
 @@ -81,6 +81,10 @@ Visibility of MIME parts can be toggled
`notmuch-multipart/alternative-discouraged` and
`notmuch-show-all-multipart/alternative-parts`.
  
 +  Note notmuch-show-print-message (bound to '#' by default) will print
 +  all parts of multipart/alternative message regardless of whether
 +  they are currently hidden or shown in the buffer.
 +
  Emacs now buttonizes mid: links
  
mid: links are a standardized way to link to messages by message ID
 -- 
 1.7.9.1

 ___
 notmuch mailing list
 notmuch@notmuchmail.org
 http://notmuchmail.org/mailman/listinfo/notmuch
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch