Re: [PATCH] emacs: Fix a notmuch-print.el compiler warning.

2012-02-02 Thread Tomi Ollila 
On Wed, 25 Jan 2012 09:24:46 +, David Edmondson  wrote:
> On Wed, 25 Jan 2012 11:19:30 +0200, Tomi Ollila  wrote:
> > On Wed, 25 Jan 2012 08:52:15 +, David Edmondson  wrote:
> > > `notmuch-show-get-prop' should be declared.
> > > ---
> > 
> > How 'bout 
> > 
> > (require 'notmuch-lib)
> > 
> > and put that declare-function there ?
> > 
> > So that when declaration gets checked when notmuch-show defuns it 
> 
> That doesn't work, as I recall. A `declare-function' in a `require'd
> file has no effect - the compiler will still complain.

Ok

+1

I (might) check how check-declare can be used here...


Tomi
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] emacs: Fix a notmuch-print.el compiler warning.

2012-01-26 Thread David Bremner 
On Wed, 25 Jan 2012 08:52:15 +, David Edmondson  wrote:
> `notmuch-show-get-prop' should be declared.

pushed.

d

Re: [PATCH] emacs: Fix a notmuch-print.el compiler warning.

2012-01-26 Thread David Bremner 
On Wed, 25 Jan 2012 08:52:15 +, David Edmondson  wrote:
> `notmuch-show-get-prop' should be declared.

pushed.

d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] emacs: Fix a notmuch-print.el compiler warning.

2012-01-25 Thread Tomi Ollila 
On Wed, 25 Jan 2012 09:24:46 +, David Edmondson  wrote:
> On Wed, 25 Jan 2012 11:19:30 +0200, Tomi Ollila  wrote:
> > On Wed, 25 Jan 2012 08:52:15 +, David Edmondson  wrote:
> > > `notmuch-show-get-prop' should be declared.
> > > ---
> > 
> > How 'bout 
> > 
> > (require 'notmuch-lib)
> > 
> > and put that declare-function there ?
> > 
> > So that when declaration gets checked when notmuch-show defuns it 
> 
> That doesn't work, as I recall. A `declare-function' in a `require'd
> file has no effect - the compiler will still complain.

Ok

+1

I (might) check how check-declare can be used here...


Tomi

[PATCH] emacs: Fix a notmuch-print.el compiler warning.

2012-01-25 Thread Tomi Ollila 
On Wed, 25 Jan 2012 08:52:15 +, David Edmondson  wrote:
> `notmuch-show-get-prop' should be declared.
> ---

How 'bout 

(require 'notmuch-lib)

and put that declare-function there ?

So that when declaration gets checked when notmuch-show defuns it 


Tomi

[PATCH] emacs: Fix a notmuch-print.el compiler warning.

2012-01-25 Thread David Edmondson 
On Wed, 25 Jan 2012 11:19:30 +0200, Tomi Ollila  wrote:
> On Wed, 25 Jan 2012 08:52:15 +, David Edmondson  wrote:
> > `notmuch-show-get-prop' should be declared.
> > ---
> 
> How 'bout 
> 
> (require 'notmuch-lib)
> 
> and put that declare-function there ?
> 
> So that when declaration gets checked when notmuch-show defuns it 

That doesn't work, as I recall. A `declare-function' in a `require'd
file has no effect - the compiler will still complain.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:

[PATCH] emacs: Fix a notmuch-print.el compiler warning.

2012-01-25 Thread David Edmondson 
`notmuch-show-get-prop' should be declared.
---
 emacs/notmuch-print.el |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/emacs/notmuch-print.el b/emacs/notmuch-print.el
index f96ccbe..fd86288 100644
--- a/emacs/notmuch-print.el
+++ b/emacs/notmuch-print.el
@@ -19,6 +19,8 @@
 ;;
 ;; Authors: David Edmondson 

+(declare-function notmuch-show-get-prop "notmuch-show" (prop &optional props))
+
 (defcustom notmuch-print-mechanism 'notmuch-print-lpr
   "How should printing be done?"
   :group 'notmuch
-- 
1.7.8.3

Re: [PATCH] emacs: Fix a notmuch-print.el compiler warning.

2012-01-25 Thread David Edmondson 
On Wed, 25 Jan 2012 11:19:30 +0200, Tomi Ollila  wrote:
> On Wed, 25 Jan 2012 08:52:15 +, David Edmondson  wrote:
> > `notmuch-show-get-prop' should be declared.
> > ---
> 
> How 'bout 
> 
> (require 'notmuch-lib)
> 
> and put that declare-function there ?
> 
> So that when declaration gets checked when notmuch-show defuns it 

That doesn't work, as I recall. A `declare-function' in a `require'd
file has no effect - the compiler will still complain.


pgplXhQ7y9RAS.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: Fix a notmuch-print.el compiler warning.

2012-01-25 Thread Tomi Ollila 
On Wed, 25 Jan 2012 08:52:15 +, David Edmondson  wrote:
> `notmuch-show-get-prop' should be declared.
> ---

How 'bout 

(require 'notmuch-lib)

and put that declare-function there ?

So that when declaration gets checked when notmuch-show defuns it 


Tomi
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] emacs: Fix a notmuch-print.el compiler warning.

2012-01-25 Thread David Edmondson 
`notmuch-show-get-prop' should be declared.
---
 emacs/notmuch-print.el |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/emacs/notmuch-print.el b/emacs/notmuch-print.el
index f96ccbe..fd86288 100644
--- a/emacs/notmuch-print.el
+++ b/emacs/notmuch-print.el
@@ -19,6 +19,8 @@
 ;;
 ;; Authors: David Edmondson 
 
+(declare-function notmuch-show-get-prop "notmuch-show" (prop &optional props))
+
 (defcustom notmuch-print-mechanism 'notmuch-print-lpr
   "How should printing be done?"
   :group 'notmuch
-- 
1.7.8.3

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch