[PATCH] emacs: Put notmuch-hello-sections in custom group notmuch-hello
Pushed, d
Re: [PATCH] emacs: Put notmuch-hello-sections in custom group notmuch-hello
Pushed, d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
[PATCH] emacs: Put notmuch-hello-sections in custom group notmuch-hello
Quoth Jani Nikula on Apr 16 at 6:58 am: > Hi Austin, id:"1330811724-30901-1-git-send-email-jani at nikula.org" :) > > Mark had a valid point about ordering within groups, which I didn't > follow up on, but this is a necessary intermediate step in the right > direction no matter what. I don't care whose patches get merged, but > let's merge the change. Ah, indeed! If only I had an MUA that let me easily search my mail... The order of the customs is just the order they're listed in defgroup (currently we don't pass any to defgroup) followed by the order Emacs evaluates the defcustoms in (defcustom -> custom-handle-keyword -> custom-add-to-group). We could use defgroup is put really important ones at the top if we want.
[PATCH] emacs: Put notmuch-hello-sections in custom group notmuch-hello
On Mon, 16 Apr 2012, Jani Nikula wrote: > Hi Austin, id:"1330811724-30901-1-git-send-email-jani at nikula.org" :) > > Mark had a valid point about ordering within groups, which I didn't > follow up on, but this is a necessary intermediate step in the right > direction no matter what. I don't care whose patches get merged, but > let's merge the change. > > Jani. I complete agree: let's push one of these (and sorry for holding up your original patch!) Best wishes Mark > > > On Sun, 15 Apr 2012 22:57:36 -0400, Austin Clements > wrote: >> --- >> emacs/notmuch-hello.el |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el >> index 71d37b8..f10d98d 100644 >> --- a/emacs/notmuch-hello.el >> +++ b/emacs/notmuch-hello.el >> @@ -226,7 +226,7 @@ by an additional filter query. Similarly, the count of >> messages >> displayed next to the buttons can be generated by applying a >> different filter to the tag query. These filters are also >> supported for \"Customized queries section\" items." >> - :group 'notmuch >> + :group 'notmuch-hello >>:type >>'(repeat >> (choice (function-item notmuch-hello-insert-header) >> -- >> 1.7.9.1 >> >> ___ >> notmuch mailing list >> notmuch at notmuchmail.org >> http://notmuchmail.org/mailman/listinfo/notmuch > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch
[PATCH] emacs: Put notmuch-hello-sections in custom group notmuch-hello
Hi Austin, id:"1330811724-30901-1-git-send-email-jani at nikula.org" :) Mark had a valid point about ordering within groups, which I didn't follow up on, but this is a necessary intermediate step in the right direction no matter what. I don't care whose patches get merged, but let's merge the change. Jani. On Sun, 15 Apr 2012 22:57:36 -0400, Austin Clements wrote: > --- > emacs/notmuch-hello.el |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el > index 71d37b8..f10d98d 100644 > --- a/emacs/notmuch-hello.el > +++ b/emacs/notmuch-hello.el > @@ -226,7 +226,7 @@ by an additional filter query. Similarly, the count of > messages > displayed next to the buttons can be generated by applying a > different filter to the tag query. These filters are also > supported for \"Customized queries section\" items." > - :group 'notmuch > + :group 'notmuch-hello >:type >'(repeat > (choice (function-item notmuch-hello-insert-header) > -- > 1.7.9.1 > > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] emacs: Put notmuch-hello-sections in custom group notmuch-hello
Hi Austin, id:1330811724-30901-1-git-send-email-j...@nikula.org :) Mark had a valid point about ordering within groups, which I didn't follow up on, but this is a necessary intermediate step in the right direction no matter what. I don't care whose patches get merged, but let's merge the change. Jani. On Sun, 15 Apr 2012 22:57:36 -0400, Austin Clements amdra...@mit.edu wrote: --- emacs/notmuch-hello.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 71d37b8..f10d98d 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -226,7 +226,7 @@ by an additional filter query. Similarly, the count of messages displayed next to the buttons can be generated by applying a different filter to the tag query. These filters are also supported for \Customized queries section\ items. - :group 'notmuch + :group 'notmuch-hello :type '(repeat (choice (function-item notmuch-hello-insert-header) -- 1.7.9.1 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] emacs: Put notmuch-hello-sections in custom group notmuch-hello
On Mon, 16 Apr 2012, Jani Nikula j...@nikula.org wrote: Hi Austin, id:1330811724-30901-1-git-send-email-j...@nikula.org :) Mark had a valid point about ordering within groups, which I didn't follow up on, but this is a necessary intermediate step in the right direction no matter what. I don't care whose patches get merged, but let's merge the change. Jani. I complete agree: let's push one of these (and sorry for holding up your original patch!) Best wishes Mark On Sun, 15 Apr 2012 22:57:36 -0400, Austin Clements amdra...@mit.edu wrote: --- emacs/notmuch-hello.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 71d37b8..f10d98d 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -226,7 +226,7 @@ by an additional filter query. Similarly, the count of messages displayed next to the buttons can be generated by applying a different filter to the tag query. These filters are also supported for \Customized queries section\ items. - :group 'notmuch + :group 'notmuch-hello :type '(repeat (choice (function-item notmuch-hello-insert-header) -- 1.7.9.1 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] emacs: Put notmuch-hello-sections in custom group notmuch-hello
Quoth Jani Nikula on Apr 16 at 6:58 am: Hi Austin, id:1330811724-30901-1-git-send-email-j...@nikula.org :) Mark had a valid point about ordering within groups, which I didn't follow up on, but this is a necessary intermediate step in the right direction no matter what. I don't care whose patches get merged, but let's merge the change. Ah, indeed! If only I had an MUA that let me easily search my mail... The order of the customs is just the order they're listed in defgroup (currently we don't pass any to defgroup) followed by the order Emacs evaluates the defcustoms in (defcustom - custom-handle-keyword - custom-add-to-group). We could use defgroup is put really important ones at the top if we want. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
[PATCH] emacs: Put notmuch-hello-sections in custom group notmuch-hello
--- emacs/notmuch-hello.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 71d37b8..f10d98d 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -226,7 +226,7 @@ by an additional filter query. Similarly, the count of messages displayed next to the buttons can be generated by applying a different filter to the tag query. These filters are also supported for \"Customized queries section\" items." - :group 'notmuch + :group 'notmuch-hello :type '(repeat (choice (function-item notmuch-hello-insert-header) -- 1.7.9.1
[PATCH] emacs: Put notmuch-hello-sections in custom group notmuch-hello
--- emacs/notmuch-hello.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 71d37b8..f10d98d 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -226,7 +226,7 @@ by an additional filter query. Similarly, the count of messages displayed next to the buttons can be generated by applying a different filter to the tag query. These filters are also supported for \Customized queries section\ items. - :group 'notmuch + :group 'notmuch-hello :type '(repeat (choice (function-item notmuch-hello-insert-header) -- 1.7.9.1 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch