Re: [PATCH 0/7] Port notmuch-show's x/X bindings to notmuch-tree
Teemu Likonen [2019-11-20T10:10:43+02] wrote: > William Casarin [2019-11-17T14:29:22-08] wrote: >> These patches bring notmuch-tree more in line with the user experience >> of notmuch-show by adding the x/X bindings. > > I have not tested the patch set yet but I think it is very good idea > to add x/X keybindings to make tree view work similarly to show view. Now I have been using the patch set some days and it works as expected. Usually I open a thread with M-TAB (notmuch-tree-from-search-thread) and if I then find thread uninteresting I hit "X" (notmuch-tree-archive-thread-then-exit) and continue browsing the thread list. I'm quite experienced with Emacs Lisp (and Common Lisp) but I don't know Notmuch Emacs code to give educated comments on this patch set's code. From user's side it works and I support this feature. Thanks! -- /// OpenPGP key: 4E1055DC84E9DFF613D78557719D69D324539450 // https://keys.openpgp.org/search?q=tliko...@iki.fi / https://keybase.io/tlikonen https://github.com/tlikonen signature.asc Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 0/7] Port notmuch-show's x/X bindings to notmuch-tree
William Casarin [2019-11-17T14:29:22-08] wrote: > These patches bring notmuch-tree more in line with the user experience > of notmuch-show by adding the x/X bindings. I have not tested the patch set yet but I think it is very good idea to add x/X keybindings to make tree view work similarly to show view. Perhaps I will try the patch set later. Would you mind sending a fixed version of "PATCH 5/7" (see id:87mucuay8p@jb55.com)? -- /// OpenPGP key: 4E1055DC84E9DFF613D78557719D69D324539450 // https://keys.openpgp.org/search?q=tliko...@iki.fi / https://keybase.io/tlikonen https://github.com/tlikonen signature.asc Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
[PATCH 0/7] Port notmuch-show's x/X bindings to notmuch-tree
These patches bring notmuch-tree more in line with the user experience of notmuch-show by adding the x/X bindings. id:20191113225752.26502-1-j...@jb55.com is also recommended, it adds a bind for opening a thread in notmuch-tree mode. William Casarin (7): emacs/tree: return true if a thread was found in next-thread emacs/tree: add notmuch-tree-goto-matching-message emacs/tree: add notmuch-tree-matching-message emacs/tree: add kill-both prefix argument to notmuch-tree-quit emacs/tree: add notmuch-tree-archive-message-than-next-or-exit emacs/tree: add notmuch-tree-archive-thread-then-exit emacs/tree: add x/X bindings emacs/notmuch-tree.el | 72 +++ 1 file changed, 52 insertions(+), 20 deletions(-) base-commit: 7ad7cfbff232431377562271901ee00202bf0bd0 -- 2.23.0 ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
