[PATCH 1/2] add notmuch keybinding 'd'

[Antoine Beaupré]

It adds a tag 'deleted' and removes the tags 'inbox' and 'unread'. It
works in show as well as in search mode

Based on previous work by: Sebastian Spaeth 

Signed-off-by: Antoine Beaupr? 
---
 emacs/notmuch-show.el |8 
 emacs/notmuch.el  |   11 +++
 2 files changed, 19 insertions(+), 0 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index f96743b..c83b992 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -875,6 +875,7 @@ function is used. "
(define-key map "+" 'notmuch-show-add-tag)
(define-key map "x" 'notmuch-show-archive-thread-then-exit)
(define-key map "a" 'notmuch-show-archive-thread)
+   (define-key map "d" 'notmuch-show-delete)
(define-key map "N" 'notmuch-show-next-message)
(define-key map "P" 'notmuch-show-previous-message)
(define-key map "n" 'notmuch-show-next-open-message)
@@ -1297,6 +1298,13 @@ the result."
 (mapcar (lambda (s) (concat "-" s)) toremove))
   (notmuch-show-set-tags new-tags

+(defun notmuch-show-delete ()
+  "Delete current mail (tag +deleted -unread -inbox)."
+  (interactive)
+  (notmuch-show-add-tag "deleted")
+  (notmuch-show-remove-tag "unread")
+  (notmuch-show-remove-tag "inbox"))
+
 (defun notmuch-show-toggle-headers ()
   "Toggle the visibility of the current message headers."
   (interactive)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index f11ec24..f6fb07b 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -215,6 +215,7 @@ For a mouse binding, return nil."
 (define-key map [mouse-1] 'notmuch-search-show-thread)
 (define-key map "*" 'notmuch-search-operate-all)
 (define-key map "a" 'notmuch-search-archive-thread)
+(define-key map "d" 'notmuch-search-delete-thread-or-region)
 (define-key map "-" 'notmuch-search-remove-tag)
 (define-key map "+" 'notmuch-search-add-tag)
 (define-key map (kbd "RET") 'notmuch-search-show-thread)
@@ -611,6 +612,16 @@ This function advances the next thread when finished."
   "Data that has not yet been processed.")
 (make-variable-buffer-local 'notmuch-search-process-filter-data)

+(defun notmuch-search-delete-thread-or-region ()
+  "Delete the currently selected thread (tag \"+deleted -inbox -unread\").
+
+This function advances the next thread when finished."
+  (interactive)
+  (notmuch-search-add-tag "deleted")
+  (notmuch-search-remove-tag "inbox")
+  (notmuch-search-remove-tag "unread")
+  (forward-line))
+
 (defun notmuch-search-process-sentinel (proc msg)
   "Add a message to let user know when \"notmuch search\" exits"
   (let ((buffer (process-buffer proc))
-- 
1.7.5.4

[PATCH 1/2] add notmuch keybinding 'd'

[David Edmondson]

On Sat, 16 Jul 2011 14:39:59 -0400, Antoine Beaupr?  
wrote:
> It adds a tag 'deleted' and removes the tags 'inbox' and 'unread'. It
> works in show as well as in search mode

Various people have asked for a keybinding to add a 'delete' tag. Is
this version the right one to choose?

It seems sane to me (though I won't use it).
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 

[PATCH 1/2] add notmuch keybinding 'd'

[Jani Nikula]

On Tue, 03 Jan 2012 14:56:50 +, David Edmondson  wrote:
> On Sat, 16 Jul 2011 14:39:59 -0400, Antoine Beaupr?  
> wrote:
> > It adds a tag 'deleted' and removes the tags 'inbox' and 'unread'. It
> > works in show as well as in search mode
> 
> Various people have asked for a keybinding to add a 'delete' tag. Is
> this version the right one to choose?

The code's there, and talk is cheap... but I'd rather like to see a
solution that would make it easy for users to add arbitrary tagging
operations to key bindings, instead of a fixed binding for "deleted".

That way perhaps adding a default 'd' for "deleted" wouldn't feel so
special either.

> It seems sane to me (though I won't use it).

I wouldn't use it either, and I don't use "deleted" tag in the first
place. And even if I used it, I'd still like to keep the distinction
between "deleted after reading" and "deleted unread", which this patch
loses by removing the "unread" tag.


BR,
Jani.

[PATCH 1/2] add notmuch keybinding 'd'

[Jameson Graef Rollins]

On Tue, 03 Jan 2012 21:57:22 +0200, Jani Nikula  wrote:
> The code's there, and talk is cheap... but I'd rather like to see a
> solution that would make it easy for users to add arbitrary tagging
> operations to key bindings, instead of a fixed binding for "deleted".

It's already easy for users to add arbitrary key bindings.  It's emacs,
and the whole point of which is that it's infinitely extensible [0]:

(define-key notmuch-show-mode-map "d"
  (lambda ()
"Delete current message and advance to next message."
(interactive)
(notmuch-show-add-tag "delete")
(notmuch-show-next-open-message-or-pop)))

There really can't be an "easier" solution to add a key binding other
than just adding the above to your .emacs, and I really don't think it
would be worth it to try to make one.

The fact that it's already so easy to customize the key bindings is why
I've been reluctant (or even against) getting into protracted
discussions about what the default key bindings should be.  Everyone is
going to want a different behavior, and since it's easy enough to
customize, just let users define what they want.

> I wouldn't use it either, and I don't use "deleted" tag in the first
> place. And even if I used it, I'd still like to keep the distinction
> between "deleted after reading" and "deleted unread", which this patch
> loses by removing the "unread" tag.

Beyond what I just said about letting everyone customize things
themselves, I agree that I don't personally want other tags added or
removed when I "delete" a message.  The key binding above is actually
the one I use.

jamie.

[0] http://notmuchmail.org/emacstips/#index6h2
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: 

[PATCH 1/2] add notmuch keybinding 'd'

[Jani Nikula]

On Tue, 03 Jan 2012 13:35:23 -0800, Jameson Graef Rollins  wrote:
> There really can't be an "easier" solution to add a key binding other
> than just adding the above to your .emacs, and I really don't think it
> would be worth it to try to make one.

I guess you're right. Thanks for the example too.

> The fact that it's already so easy to customize the key bindings is why
> I've been reluctant (or even against) getting into protracted
> discussions about what the default key bindings should be.  Everyone is
> going to want a different behavior, and since it's easy enough to
> customize, just let users define what they want.

This is what I was basically after too: provide elementary functions
that make it easy for users to do what they want. (Just in this case
nothing more is really needed.)

As a side note, GNU Global has an interesting approach of not binding
any keys, unless you have done:
(setq gtags-suggested-key-mapping t)


BR,
Jani.

[PATCH 1/2] add notmuch keybinding 'd'

[David Edmondson]

On Tue, 03 Jan 2012 14:56:50 +, David Edmondson  wrote:
> On Sat, 16 Jul 2011 14:39:59 -0400, Antoine Beaupr?  
> wrote:
> > It adds a tag 'deleted' and removes the tags 'inbox' and 'unread'. It
> > works in show as well as in search mode
> 
> Various people have asked for a keybinding to add a 'delete' tag. Is
> this version the right one to choose?

No-one has spoken up in favour of this particular change (and the removal
of "unread" seems questionable) so I plan to mark it 'obsolete'. If
anyone would like to bring it back, please post an updated version of
the patch and argue for it.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 

[PATCH 1/2] add notmuch keybinding 'd'

[Antoine Beaupré]

On Tue, 03 Jan 2012 21:57:22 +0200, Jani Nikula  wrote:
> I wouldn't use it either, and I don't use "deleted" tag in the first
> place. And even if I used it, I'd still like to keep the distinction
> between "deleted after reading" and "deleted unread", which this patch
> loses by removing the "unread" tag.

I have been using this for months now.

But honestly, I don't care much anymore: the hard part is not the tag,
it's what you do with it after (hint: just remove the damn file).

Most patches I have submitted here haven't been accepted and I have to
painfully reroll my own packages every time there's a new release, which
has been a very frustrating experience. To see such a trivial patch
obsoleted tops it.

For the curious, those (other) patches are:

 * lib: add 'safe' setting for flags
 * lib: Add back the synchronization of 'T' flag with deleted tag
 * run notmuch-hello-mode-hook at the end of the hello mode setup

Most of those do not change the current behavior, and I have been
running them for more than 4 months.

I'd very much like to get help to get this in... 

A.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: 

[PATCH 1/2] add notmuch keybinding 'd'

[Jameson Graef Rollins]

On Fri, 06 Jan 2012 15:10:57 -0500, Antoine Beaupr?  
wrote:
> Most patches I have submitted here haven't been accepted and I have to
> painfully reroll my own packages every time there's a new release, which
> has been a very frustrating experience. To see such a trivial patch
> obsoleted tops it.

Don't be too over dramatic, Antoine.  A lot of patches have sat fallow
for a long time, and a lot of us maintain our own stuff on top what's in
master.

There's also been discussion on this particular topic since long before
you showed up.  cworth pushed back on adding a delete key until we had a
more integrated solution.  I think the same thing is happening here.

I'm going to take a crack at an implementation of this functionality
this weekend that I think will satisfy most of out needs.

jamie.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: 

[PATCH 1/2] add notmuch keybinding 'd'

[David Bremner]

On Fri, 06 Jan 2012 15:10:57 -0500, Antoine Beaupr?  
wrote:
> On Tue, 03 Jan 2012 21:57:22 +0200, Jani Nikula  wrote:

>  * lib: add 'safe' setting for flags
>  * lib: Add back the synchronization of 'T' flag with deleted tag
>  * run notmuch-hello-mode-hook at the end of the hello mode setup

> 
> Most of those do not change the current behavior, and I have been
> running them for more than 4 months.
> 
> I'd very much like to get help to get this in... 

Hi Antoine;

I understand your frustration; it's not very motivating to feel
ignored. Over the last few months we have been working to develop a
patch review process for notmuch [1], but as you can see from [2] there
is still a backlog of patches that have not been reviewed, the two lib
patches you mention among them. More reviewers are always welcome ;).

David

[1]: http://notmuchmail.org/nmbug/
[2]: http://nmbug.tethera.net/status/

[PATCH 1/2] add notmuch keybinding 'd'

[Jani Nikula]

Hi Antoine -

On Fri, 06 Jan 2012 15:10:57 -0500, Antoine Beaupr?  
wrote:
> On Tue, 03 Jan 2012 21:57:22 +0200, Jani Nikula  wrote:
> > I wouldn't use it either, and I don't use "deleted" tag in the first
> > place. And even if I used it, I'd still like to keep the distinction
> > between "deleted after reading" and "deleted unread", which this patch
> > loses by removing the "unread" tag.
> 
> I have been using this for months now.
> 
> But honestly, I don't care much anymore: the hard part is not the tag,
> it's what you do with it after (hint: just remove the damn file).
> 
> Most patches I have submitted here haven't been accepted and I have to
> painfully reroll my own packages every time there's a new release, which
> has been a very frustrating experience. To see such a trivial patch
> obsoleted tops it.

This patch, while trivial, fixes a specific use case for you, according
to your preferences. I was hoping for something more generic, and
Jameson showed how this can be done in one's .emacs without adding new
code (or carrying your own patches) at all. If this approach does not
work for you, please let us know why!

> For the curious, those (other) patches are:
> 
>  * lib: add 'safe' setting for flags
>  * lib: Add back the synchronization of 'T' flag with deleted tag
>  * run notmuch-hello-mode-hook at the end of the hello mode setup
> 
> Most of those do not change the current behavior, and I have been
> running them for more than 4 months.

I haven't looked at the patches, but please understand that not changing
the current behaviour is not a sufficient reason for inclusion. Once in,
people will start using the features, which will need to be maintained
and supported potentially for a very long time. Once in, it's not easy
to take features out. Especially so for lib. So we need to be careful.

Tests have also become an increasingly important part in getting any
non-trivial changes in. It's not enough that they work perfectly now; we
need to be able to make sure later changes won't break them.

> I'd very much like to get help to get this in... 

I'll try to find a moment to review your other patches.

I've also had my moments of frustration, but things have really improved
significantly since you've sent those patches. David is doing an
excellent job. Be persistent!


Kind regards,
Jani.

[PATCH 1/2] add notmuch keybinding 'd'

[Tomi Ollila]

On Fri, 06 Jan 2012 15:10:57 -0500, Antoine Beaupr?  
wrote:
> 
> For the curious, those (other) patches are:
> 
>  * lib: add 'safe' setting for flags
>  * lib: Add back the synchronization of 'T' flag with deleted tag
>  * run notmuch-hello-mode-hook at the end of the hello mode setup

To add other replies, there are now notmuch-hello-mode-hook and
notmuch-hello-refresh-hook impmelented.

> Most of those do not change the current behavior, and I have been
> running them for more than 4 months.
> 
> I'd very much like to get help to get this in... 
> 
> A.

Tomi

[PATCH 1/2] add notmuch keybinding 'd'

[Antoine Beaupré]

On Fri, 06 Jan 2012 16:51:51 -0400, David Bremner  wrote:
> On Fri, 06 Jan 2012 15:10:57 -0500, Antoine Beaupr?  
> wrote:
> > On Tue, 03 Jan 2012 21:57:22 +0200, Jani Nikula  wrote:
> 
> >  * lib: add 'safe' setting for flags
> >  * lib: Add back the synchronization of 'T' flag with deleted tag
> >  * run notmuch-hello-mode-hook at the end of the hello mode setup
> 
> > 
> > Most of those do not change the current behavior, and I have been
> > running them for more than 4 months.
> > 
> > I'd very much like to get help to get this in... 
> 
> Hi Antoine;
> 
> I understand your frustration; it's not very motivating to feel
> ignored. Over the last few months we have been working to develop a
> patch review process for notmuch [1], but as you can see from [2] there
> is still a backlog of patches that have not been reviewed, the two lib
> patches you mention among them. More reviewers are always welcome ;).

Hi,

Thanks for the nice words.

I am sorry I whined on the list like this. :) I guess I was a bit tired
and disappointed no progress had been done on those patches, but I
understand how hard it is to keep up with the crazy flood on the list.

> [1]: http://notmuchmail.org/nmbug/
> [2]: http://nmbug.tethera.net/status/

This is a great initiative!

I am glad to see my patches still sitting there at least! ;) And I am
also happy to see Jamie's patches for the delete key there, if I had
more time I would actually go through and review them, unfortunately, I
have very little time to review stuff that, honestly, "just works" for
me right now. ;)

Sorry again for the outburst, keep up the good work!

A.

-- 
La guerre, c'est le massacre d'hommes qui ne se connaissent pas,
au profit d'hommes qui se connaissent mais ne se massacreront pas.
- Paul Val?ry
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: 

[PATCH 1/2] add notmuch keybinding 'd'

[Antoine Beaupré]

On Wed, 04 Jan 2012 08:52:13 +, David Edmondson  wrote:
> On Tue, 03 Jan 2012 14:56:50 +, David Edmondson  wrote:
> > On Sat, 16 Jul 2011 14:39:59 -0400, Antoine Beaupr?  > koumbit.org> wrote:
> > > It adds a tag 'deleted' and removes the tags 'inbox' and 'unread'. It
> > > works in show as well as in search mode
> > 
> > Various people have asked for a keybinding to add a 'delete' tag. Is
> > this version the right one to choose?
> 
> No-one has spoken up in favour of this particular change (and the removal
> of "unread" seems questionable) so I plan to mark it 'obsolete'. If
> anyone would like to bring it back, please post an updated version of
> the patch and argue for it.

I do think this is superseded by this:

id:"1325975294-646-4-git-send-email-jrollins at finestructure.net"

Thanks again Jamie. :)

A.

-- 
La nature n'a cr?? ni ma?tres ni esclaves
Je ne veux ni donner ni recevoir de lois.
- Denis Diderot
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: 

[PATCH 1/2] add notmuch keybinding 'd'

[Antoine Beaupré]

It adds a tag 'deleted' and removes the tags 'inbox' and 'unread'. It
works in show as well as in search mode

Based on previous work by: Sebastian Spaeth 

Signed-off-by: Antoine Beaupré 
---
 emacs/notmuch-show.el |8 
 emacs/notmuch.el  |   11 +++
 2 files changed, 19 insertions(+), 0 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index f96743b..c83b992 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -875,6 +875,7 @@ function is used. "
(define-key map "+" 'notmuch-show-add-tag)
(define-key map "x" 'notmuch-show-archive-thread-then-exit)
(define-key map "a" 'notmuch-show-archive-thread)
+   (define-key map "d" 'notmuch-show-delete)
(define-key map "N" 'notmuch-show-next-message)
(define-key map "P" 'notmuch-show-previous-message)
(define-key map "n" 'notmuch-show-next-open-message)
@@ -1297,6 +1298,13 @@ the result."
 (mapcar (lambda (s) (concat "-" s)) toremove))
   (notmuch-show-set-tags new-tags
 
+(defun notmuch-show-delete ()
+  "Delete current mail (tag +deleted -unread -inbox)."
+  (interactive)
+  (notmuch-show-add-tag "deleted")
+  (notmuch-show-remove-tag "unread")
+  (notmuch-show-remove-tag "inbox"))
+
 (defun notmuch-show-toggle-headers ()
   "Toggle the visibility of the current message headers."
   (interactive)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index f11ec24..f6fb07b 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -215,6 +215,7 @@ For a mouse binding, return nil."
 (define-key map [mouse-1] 'notmuch-search-show-thread)
 (define-key map "*" 'notmuch-search-operate-all)
 (define-key map "a" 'notmuch-search-archive-thread)
+(define-key map "d" 'notmuch-search-delete-thread-or-region)
 (define-key map "-" 'notmuch-search-remove-tag)
 (define-key map "+" 'notmuch-search-add-tag)
 (define-key map (kbd "RET") 'notmuch-search-show-thread)
@@ -611,6 +612,16 @@ This function advances the next thread when finished."
   "Data that has not yet been processed.")
 (make-variable-buffer-local 'notmuch-search-process-filter-data)
 
+(defun notmuch-search-delete-thread-or-region ()
+  "Delete the currently selected thread (tag \"+deleted -inbox -unread\").
+
+This function advances the next thread when finished."
+  (interactive)
+  (notmuch-search-add-tag "deleted")
+  (notmuch-search-remove-tag "inbox")
+  (notmuch-search-remove-tag "unread")
+  (forward-line))
+
 (defun notmuch-search-process-sentinel (proc msg)
   "Add a message to let user know when \"notmuch search\" exits"
   (let ((buffer (process-buffer proc))
-- 
1.7.5.4

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] add notmuch keybinding 'd'

[David Edmondson]

On Sat, 16 Jul 2011 14:39:59 -0400, Antoine Beaupré  wrote:
> It adds a tag 'deleted' and removes the tags 'inbox' and 'unread'. It
> works in show as well as in search mode

Various people have asked for a keybinding to add a 'delete' tag. Is
this version the right one to choose?

It seems sane to me (though I won't use it).


pgpwGU12vOd5F.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] add notmuch keybinding 'd'

[Jani Nikula]

On Tue, 03 Jan 2012 14:56:50 +, David Edmondson  wrote:
> On Sat, 16 Jul 2011 14:39:59 -0400, Antoine Beaupré  
> wrote:
> > It adds a tag 'deleted' and removes the tags 'inbox' and 'unread'. It
> > works in show as well as in search mode
> 
> Various people have asked for a keybinding to add a 'delete' tag. Is
> this version the right one to choose?

The code's there, and talk is cheap... but I'd rather like to see a
solution that would make it easy for users to add arbitrary tagging
operations to key bindings, instead of a fixed binding for "deleted".

That way perhaps adding a default 'd' for "deleted" wouldn't feel so
special either.

> It seems sane to me (though I won't use it).

I wouldn't use it either, and I don't use "deleted" tag in the first
place. And even if I used it, I'd still like to keep the distinction
between "deleted after reading" and "deleted unread", which this patch
loses by removing the "unread" tag.


BR,
Jani.
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] add notmuch keybinding 'd'

[Jameson Graef Rollins]

On Tue, 03 Jan 2012 21:57:22 +0200, Jani Nikula  wrote:
> The code's there, and talk is cheap... but I'd rather like to see a
> solution that would make it easy for users to add arbitrary tagging
> operations to key bindings, instead of a fixed binding for "deleted".

It's already easy for users to add arbitrary key bindings.  It's emacs,
and the whole point of which is that it's infinitely extensible [0]:

(define-key notmuch-show-mode-map "d"
  (lambda ()
"Delete current message and advance to next message."
(interactive)
(notmuch-show-add-tag "delete")
(notmuch-show-next-open-message-or-pop)))

There really can't be an "easier" solution to add a key binding other
than just adding the above to your .emacs, and I really don't think it
would be worth it to try to make one.

The fact that it's already so easy to customize the key bindings is why
I've been reluctant (or even against) getting into protracted
discussions about what the default key bindings should be.  Everyone is
going to want a different behavior, and since it's easy enough to
customize, just let users define what they want.

> I wouldn't use it either, and I don't use "deleted" tag in the first
> place. And even if I used it, I'd still like to keep the distinction
> between "deleted after reading" and "deleted unread", which this patch
> loses by removing the "unread" tag.

Beyond what I just said about letting everyone customize things
themselves, I agree that I don't personally want other tags added or
removed when I "delete" a message.  The key binding above is actually
the one I use.

jamie.

[0] http://notmuchmail.org/emacstips/#index6h2


pgpEHraO8ovZi.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] add notmuch keybinding 'd'

[Jani Nikula]

On Tue, 03 Jan 2012 13:35:23 -0800, Jameson Graef Rollins 
 wrote:
> There really can't be an "easier" solution to add a key binding other
> than just adding the above to your .emacs, and I really don't think it
> would be worth it to try to make one.

I guess you're right. Thanks for the example too.

> The fact that it's already so easy to customize the key bindings is why
> I've been reluctant (or even against) getting into protracted
> discussions about what the default key bindings should be.  Everyone is
> going to want a different behavior, and since it's easy enough to
> customize, just let users define what they want.

This is what I was basically after too: provide elementary functions
that make it easy for users to do what they want. (Just in this case
nothing more is really needed.)

As a side note, GNU Global has an interesting approach of not binding
any keys, unless you have done:
(setq gtags-suggested-key-mapping t)


BR,
Jani.
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] add notmuch keybinding 'd'

[David Edmondson]

On Tue, 03 Jan 2012 14:56:50 +, David Edmondson  wrote:
> On Sat, 16 Jul 2011 14:39:59 -0400, Antoine Beaupré  
> wrote:
> > It adds a tag 'deleted' and removes the tags 'inbox' and 'unread'. It
> > works in show as well as in search mode
> 
> Various people have asked for a keybinding to add a 'delete' tag. Is
> this version the right one to choose?

No-one has spoken up in favour of this particular change (and the removal
of "unread" seems questionable) so I plan to mark it 'obsolete'. If
anyone would like to bring it back, please post an updated version of
the patch and argue for it.


pgpRhtaJ74rNA.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] add notmuch keybinding 'd'

[Antoine Beaupré]

On Tue, 03 Jan 2012 21:57:22 +0200, Jani Nikula  wrote:
> I wouldn't use it either, and I don't use "deleted" tag in the first
> place. And even if I used it, I'd still like to keep the distinction
> between "deleted after reading" and "deleted unread", which this patch
> loses by removing the "unread" tag.

I have been using this for months now.

But honestly, I don't care much anymore: the hard part is not the tag,
it's what you do with it after (hint: just remove the damn file).

Most patches I have submitted here haven't been accepted and I have to
painfully reroll my own packages every time there's a new release, which
has been a very frustrating experience. To see such a trivial patch
obsoleted tops it.

For the curious, those (other) patches are:

 * lib: add 'safe' setting for flags
 * lib: Add back the synchronization of 'T' flag with deleted tag
 * run notmuch-hello-mode-hook at the end of the hello mode setup

Most of those do not change the current behavior, and I have been
running them for more than 4 months.

I'd very much like to get help to get this in... 

A.


pgpBBUYcqd9cb.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] add notmuch keybinding 'd'

[Jameson Graef Rollins]

On Fri, 06 Jan 2012 15:10:57 -0500, Antoine Beaupré  wrote:
> Most patches I have submitted here haven't been accepted and I have to
> painfully reroll my own packages every time there's a new release, which
> has been a very frustrating experience. To see such a trivial patch
> obsoleted tops it.

Don't be too over dramatic, Antoine.  A lot of patches have sat fallow
for a long time, and a lot of us maintain our own stuff on top what's in
master.

There's also been discussion on this particular topic since long before
you showed up.  cworth pushed back on adding a delete key until we had a
more integrated solution.  I think the same thing is happening here.

I'm going to take a crack at an implementation of this functionality
this weekend that I think will satisfy most of out needs.

jamie.


pgphahDsuLqNp.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] add notmuch keybinding 'd'

[David Bremner]

On Fri, 06 Jan 2012 15:10:57 -0500, Antoine Beaupré  wrote:
> On Tue, 03 Jan 2012 21:57:22 +0200, Jani Nikula  wrote:

>  * lib: add 'safe' setting for flags
>  * lib: Add back the synchronization of 'T' flag with deleted tag
>  * run notmuch-hello-mode-hook at the end of the hello mode setup

> 
> Most of those do not change the current behavior, and I have been
> running them for more than 4 months.
> 
> I'd very much like to get help to get this in... 

Hi Antoine;

I understand your frustration; it's not very motivating to feel
ignored. Over the last few months we have been working to develop a
patch review process for notmuch [1], but as you can see from [2] there
is still a backlog of patches that have not been reviewed, the two lib
patches you mention among them. More reviewers are always welcome ;).

David

[1]: http://notmuchmail.org/nmbug/
[2]: http://nmbug.tethera.net/status/
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] add notmuch keybinding 'd'

[Jani Nikula]

Hi Antoine -

On Fri, 06 Jan 2012 15:10:57 -0500, Antoine Beaupré  wrote:
> On Tue, 03 Jan 2012 21:57:22 +0200, Jani Nikula  wrote:
> > I wouldn't use it either, and I don't use "deleted" tag in the first
> > place. And even if I used it, I'd still like to keep the distinction
> > between "deleted after reading" and "deleted unread", which this patch
> > loses by removing the "unread" tag.
> 
> I have been using this for months now.
> 
> But honestly, I don't care much anymore: the hard part is not the tag,
> it's what you do with it after (hint: just remove the damn file).
> 
> Most patches I have submitted here haven't been accepted and I have to
> painfully reroll my own packages every time there's a new release, which
> has been a very frustrating experience. To see such a trivial patch
> obsoleted tops it.

This patch, while trivial, fixes a specific use case for you, according
to your preferences. I was hoping for something more generic, and
Jameson showed how this can be done in one's .emacs without adding new
code (or carrying your own patches) at all. If this approach does not
work for you, please let us know why!

> For the curious, those (other) patches are:
> 
>  * lib: add 'safe' setting for flags
>  * lib: Add back the synchronization of 'T' flag with deleted tag
>  * run notmuch-hello-mode-hook at the end of the hello mode setup
> 
> Most of those do not change the current behavior, and I have been
> running them for more than 4 months.

I haven't looked at the patches, but please understand that not changing
the current behaviour is not a sufficient reason for inclusion. Once in,
people will start using the features, which will need to be maintained
and supported potentially for a very long time. Once in, it's not easy
to take features out. Especially so for lib. So we need to be careful.

Tests have also become an increasingly important part in getting any
non-trivial changes in. It's not enough that they work perfectly now; we
need to be able to make sure later changes won't break them.

> I'd very much like to get help to get this in... 

I'll try to find a moment to review your other patches.

I've also had my moments of frustration, but things have really improved
significantly since you've sent those patches. David is doing an
excellent job. Be persistent!


Kind regards,
Jani.
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] add notmuch keybinding 'd'

[Tomi Ollila]

On Fri, 06 Jan 2012 15:10:57 -0500, Antoine Beaupré  wrote:
> 
> For the curious, those (other) patches are:
> 
>  * lib: add 'safe' setting for flags
>  * lib: Add back the synchronization of 'T' flag with deleted tag
>  * run notmuch-hello-mode-hook at the end of the hello mode setup

To add other replies, there are now notmuch-hello-mode-hook and
notmuch-hello-refresh-hook impmelented.

> Most of those do not change the current behavior, and I have been
> running them for more than 4 months.
> 
> I'd very much like to get help to get this in... 
> 
> A.

Tomi
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] add notmuch keybinding 'd'

[Antoine Beaupré]

On Fri, 06 Jan 2012 16:51:51 -0400, David Bremner  wrote:
> On Fri, 06 Jan 2012 15:10:57 -0500, Antoine Beaupré  
> wrote:
> > On Tue, 03 Jan 2012 21:57:22 +0200, Jani Nikula  wrote:
> 
> >  * lib: add 'safe' setting for flags
> >  * lib: Add back the synchronization of 'T' flag with deleted tag
> >  * run notmuch-hello-mode-hook at the end of the hello mode setup
> 
> > 
> > Most of those do not change the current behavior, and I have been
> > running them for more than 4 months.
> > 
> > I'd very much like to get help to get this in... 
> 
> Hi Antoine;
> 
> I understand your frustration; it's not very motivating to feel
> ignored. Over the last few months we have been working to develop a
> patch review process for notmuch [1], but as you can see from [2] there
> is still a backlog of patches that have not been reviewed, the two lib
> patches you mention among them. More reviewers are always welcome ;).

Hi,

Thanks for the nice words.

I am sorry I whined on the list like this. :) I guess I was a bit tired
and disappointed no progress had been done on those patches, but I
understand how hard it is to keep up with the crazy flood on the list.

> [1]: http://notmuchmail.org/nmbug/
> [2]: http://nmbug.tethera.net/status/

This is a great initiative!

I am glad to see my patches still sitting there at least! ;) And I am
also happy to see Jamie's patches for the delete key there, if I had
more time I would actually go through and review them, unfortunately, I
have very little time to review stuff that, honestly, "just works" for
me right now. ;)

Sorry again for the outburst, keep up the good work!

A.

-- 
La guerre, c'est le massacre d'hommes qui ne se connaissent pas,
au profit d'hommes qui se connaissent mais ne se massacreront pas.
- Paul Valéry


pgpYinAvqsFLV.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] add notmuch keybinding 'd'

[Antoine Beaupré]

On Wed, 04 Jan 2012 08:52:13 +, David Edmondson  wrote:
> On Tue, 03 Jan 2012 14:56:50 +, David Edmondson  wrote:
> > On Sat, 16 Jul 2011 14:39:59 -0400, Antoine Beaupré  
> > wrote:
> > > It adds a tag 'deleted' and removes the tags 'inbox' and 'unread'. It
> > > works in show as well as in search mode
> > 
> > Various people have asked for a keybinding to add a 'delete' tag. Is
> > this version the right one to choose?
> 
> No-one has spoken up in favour of this particular change (and the removal
> of "unread" seems questionable) so I plan to mark it 'obsolete'. If
> anyone would like to bring it back, please post an updated version of
> the patch and argue for it.

I do think this is superseded by this:

id:"1325975294-646-4-git-send-email-jroll...@finestructure.net"

Thanks again Jamie. :)

A.

-- 
La nature n'a créé ni maîtres ni esclaves
Je ne veux ni donner ni recevoir de lois.
- Denis Diderot


pgpq7lWzF40yT.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch