[PATCH 2/2] NEWS: fix some old typos and trailing whitespace

[Pieter Praet]

On Thu, 12 Jan 2012 23:11:35 -0400, David Bremner  wrote:
> On Thu, 12 Jan 2012 18:06:14 +0100, Pieter Praet  wrote:
> > That would indeed have been the most sensible thing to do.
> > 
> > Could someone (who -unlike me- has already submitted his/her public SSH
> > key for commit access) add something along those lines to the Patch
> > Formatting guidelines [1] ?  Perhaps just quote Carl's statement [2] ?
> > 
> 
> Hi Pieter;
> 
> It's a wiki, anyone can push.
> 

Oh, I wasn't aware of this. (changed recently?)

http://notmuchmail.org/patchformatting/ has been amended!

> d


Peace

-- 
Pieter

Re: [PATCH 2/2] NEWS: fix some old typos and trailing whitespace

[Pieter Praet]

On Thu, 12 Jan 2012 23:11:35 -0400, David Bremner da...@tethera.net wrote:
 On Thu, 12 Jan 2012 18:06:14 +0100, Pieter Praet pie...@praet.org wrote:
  That would indeed have been the most sensible thing to do.
  
  Could someone (who -unlike me- has already submitted his/her public SSH
  key for commit access) add something along those lines to the Patch
  Formatting guidelines [1] ?  Perhaps just quote Carl's statement [2] ?
  
 
 Hi Pieter;
 
 It's a wiki, anyone can push.
 

Oh, I wasn't aware of this. (changed recently?)

http://notmuchmail.org/patchformatting/ has been amended!

 d


Peace

-- 
Pieter
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 2/2] NEWS: fix some old typos and trailing whitespace

[David Bremner]

On Thu, 12 Jan 2012 18:06:14 +0100, Pieter Praet  wrote:
> That would indeed have been the most sensible thing to do.
> 
> Could someone (who -unlike me- has already submitted his/her public SSH
> key for commit access) add something along those lines to the Patch
> Formatting guidelines [1] ?  Perhaps just quote Carl's statement [2] ?
> 

Hi Pieter;

It's a wiki, anyone can push.

d

[PATCH 2/2] NEWS: fix some old typos and trailing whitespace

[Pieter Praet]

On Thu, 17 Nov 2011 08:21:59 +0200, Jani Nikula  wrote:
> On Nov 16, 2011 11:39 PM, "Pieter Praet"  wrote:
> >
> > On Wed, 16 Nov 2011 22:54:35 +0200, Tomi Ollila 
> wrote:
> > > On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet 
> wrote:
> > > > No further explanation needed.
> > > > ---
> > > >  NEWS |   14 +++---
> > > >  1 files changed, 7 insertions(+), 7 deletions(-)
> > >
> > > The 'No further explanation needed.' should be *BELOW* the waistline
> (---) ;);
> > > now it goes to the commit message which is probably not what anybody
> wants.
> > >
> >
> > That was intended :)
> >
> > Empty commit messages are frowned upon (even if the commit subject is
> > sufficiently descriptive), so "rather a pointless one than none?" :)
> 
> Generally I think the message should be self-contained and understandable
> without the subject line, so IMHO a full meaningful sentence is better than
> one/none, even if it's repetition.
> 
> BR,
> Jani.

That would indeed have been the most sensible thing to do.

Could someone (who -unlike me- has already submitted his/her public SSH
key for commit access) add something along those lines to the Patch
Formatting guidelines [1] ?  Perhaps just quote Carl's statement [2] ?


Peace

-- 
Pieter

[1] http://notmuchmail.org/patchformatting/
[2] id:"87ocmwok2w.fsf at yoom.home.cworth.org"

Re: [PATCH 2/2] NEWS: fix some old typos and trailing whitespace

[David Bremner]

On Thu, 12 Jan 2012 18:06:14 +0100, Pieter Praet pie...@praet.org wrote:
 That would indeed have been the most sensible thing to do.
 
 Could someone (who -unlike me- has already submitted his/her public SSH
 key for commit access) add something along those lines to the Patch
 Formatting guidelines [1] ?  Perhaps just quote Carl's statement [2] ?
 

Hi Pieter;

It's a wiki, anyone can push.

d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 2/2] NEWS: fix some old typos and trailing whitespace

[Jani Nikula]

On Nov 16, 2011 11:39 PM, "Pieter Praet"  wrote:
>
> On Wed, 16 Nov 2011 22:54:35 +0200, Tomi Ollila 
wrote:
> > On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet 
wrote:
> > > No further explanation needed.
> > > ---
> > >  NEWS |   14 +++---
> > >  1 files changed, 7 insertions(+), 7 deletions(-)
> >
> > The 'No further explanation needed.' should be *BELOW* the waistline
(---) ;);
> > now it goes to the commit message which is probably not what anybody
wants.
> >
>
> That was intended :)
>
> Empty commit messages are frowned upon (even if the commit subject is
> sufficiently descriptive), so "rather a pointless one than none?" :)

Generally I think the message should be self-contained and understandable
without the subject line, so IMHO a full meaningful sentence is better than
one/none, even if it's repetition.

BR,
Jani.
-- next part --
An HTML attachment was scrubbed...
URL: 

[PATCH 2/2] NEWS: fix some old typos and trailing whitespace

[Tomi Ollila]

On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet  wrote:
> No further explanation needed.
> ---
>  NEWS |   14 +++---
>  1 files changed, 7 insertions(+), 7 deletions(-)

The 'No further explanation needed.' should be *BELOW* the waistline (---) ;);
now it goes to the commit message which is probably not what anybody wants.

Tomi

[PATCH 2/2] NEWS: fix some old typos and trailing whitespace

[Pieter Praet]

On Wed, 16 Nov 2011 22:54:35 +0200, Tomi Ollila  wrote:
> On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet  wrote:
> > No further explanation needed.
> > ---
> >  NEWS |   14 +++---
> >  1 files changed, 7 insertions(+), 7 deletions(-)
> 
> The 'No further explanation needed.' should be *BELOW* the waistline (---) ;);
> now it goes to the commit message which is probably not what anybody wants.
> 

That was intended :)

Empty commit messages are frowned upon (even if the commit subject is
sufficiently descriptive), so "rather a pointless one than none?" :)

> Tomi
> 


Peace

-- 
Pieter

[PATCH 2/2] NEWS: fix some old typos and trailing whitespace

[Pieter Praet]

No further explanation needed.
---
 NEWS |   14 +++---
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/NEWS b/NEWS
index 6c064da..daec4ad 100644
--- a/NEWS
+++ b/NEWS
@@ -130,7 +130,7 @@ Ruby bindings changes
 -

   - Wrap new library functions notmuch_database_{begin,end}_atomic.
-  - Add new exception Notmuch::UnbalancedAtomicError. 
+  - Add new exception Notmuch::UnbalancedAtomicError.
   - Rename destroy  to destroy! according to Ruby naming conventions.
   - Update for n_d_find_message* API changes (see above).

@@ -159,7 +159,7 @@ Improved handling of message/rfc822 parts
   headers, is unfortunately not yet supported (but hopefully will be
   soon).

-Improved Build system portability 
+Improved Build system portability

   Certain parts of the shell script generating notmuch.sym were
   specific to the GNU versions of sed and nm. The new version should
@@ -202,7 +202,7 @@ Sebastian Spaeth contributed two changes related to unicode 
and UTF8:
   * message tags are now explicitly unicode
   * query string is encoded as a UTF8 byte string

-Build-System improvments
+Build-System improvements
 

 Generate notmuch.sym after the relevant object files
@@ -217,7 +217,7 @@ Bug-fix release.
 

 Re-export Xapian exception typeinfo symbols.
-  
+
   It turned out our aggressive symbol hiding caused problems for
   people running gcc 4.4.5.

@@ -382,7 +382,7 @@ Hiding of repeated subjects in collapsed thread view

   In notmuch-show mode, if a collapsed message has the same subject as
   its parent, the subject is not shown.
-  
+
 Automatic detection and hiding of original message in top-posted message

   When a message contains a line looking something like:
@@ -448,7 +448,7 @@ Ruby bindings are now much more complete
   Including QUERY.sort, QUERY.to_s, MESSAGE.maildir_flags_to_tags,
   MESSAGE.tags_to_maildir_flags, and MESSAGE.get_filenames

-* Python bindings have been upodated and extended
+* Python bindings have been updated and extended
   (docs online at http://packages.python.org/notmuch/)

   New bindings:
@@ -467,7 +467,7 @@ Ruby bindings are now much more complete
s2 -= s1

Removed:
- - len(Messages()) as it exausted the iterator.
+ - len(Messages()) as it exhausted the iterator.
Use len(list(Messages())) or
Query.count_messages() to get the length.

-- 
1.7.7.1

Re: [PATCH 2/2] NEWS: fix some old typos and trailing whitespace

[Tomi Ollila]

On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet pie...@praet.org wrote:
 No further explanation needed.
 ---
  NEWS |   14 +++---
  1 files changed, 7 insertions(+), 7 deletions(-)

The 'No further explanation needed.' should be *BELOW* the waistline (---) ;);
now it goes to the commit message which is probably not what anybody wants.

Tomi

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 2/2] NEWS: fix some old typos and trailing whitespace

[Jani Nikula]

On Nov 16, 2011 11:39 PM, Pieter Praet pie...@praet.org wrote:

 On Wed, 16 Nov 2011 22:54:35 +0200, Tomi Ollila tomi.oll...@iki.fi
wrote:
  On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet pie...@praet.org
wrote:
   No further explanation needed.
   ---
NEWS |   14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
 
  The 'No further explanation needed.' should be *BELOW* the waistline
(---) ;);
  now it goes to the commit message which is probably not what anybody
wants.
 

 That was intended :)

 Empty commit messages are frowned upon (even if the commit subject is
 sufficiently descriptive), so rather a pointless one than none? :)

Generally I think the message should be self-contained and understandable
without the subject line, so IMHO a full meaningful sentence is better than
one/none, even if it's repetition.

BR,
Jani.
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch